xvine:fixes
[oweals/gnunet.git] / src / dv / gnunet-service-dv.c
index 1eaaf9774ac016bd4f9ebe1bd3489fbd54e7baf0..abade848fe77017d20bfaf0231d0dca918d9f7d5 100644 (file)
@@ -97,13 +97,13 @@ struct Target
 struct RouteMessage
 {
   /**
-   * Type: GNUNET_MESSAGE_TYPE_DV_ROUTE
+   * Type: #GNUNET_MESSAGE_TYPE_DV_ROUTE
    */
   struct GNUNET_MessageHeader header;
 
   /**
    * Expected (remaining) distance.  Must be always smaller than
-   * DEFAULT_FISHEYE_DEPTH, should be zero at the target.  Must
+   * #DEFAULT_FISHEYE_DEPTH, should be zero at the target.  Must
    * be decremented by one at each hop.  Peers must not forward
    * these messages further once the counter has reached zero.
    */
@@ -145,9 +145,9 @@ struct PendingMessage
   const struct GNUNET_MessageHeader *msg;
 
   /**
-   * Ultimate target for the message.
+   * Next target for the message (a neighbour of ours).
    */
-  struct GNUNET_PeerIdentity ultimate_target;
+  struct GNUNET_PeerIdentity next_target;
 
   /**
    * Unique ID of the message.
@@ -205,7 +205,7 @@ struct DirectNeighbor
    * NULL if we are not currently building it.
    * Keys are peer identities, values are 'struct Target' entries.
    * Note that the distances in the targets are from the point-of-view
-   * of the peer, not from us!
+   * of the other peer, not from us!
    */
   struct GNUNET_CONTAINER_MultiPeerMap *neighbor_table_consensus;
 
@@ -269,6 +269,11 @@ struct DirectNeighbor
    */
   uint32_t distance;
 
+  /**
+   * The network this peer is in
+   */
+  enum GNUNET_ATS_Network_Type network;
+
   /**
    * Is this neighbor connected at the core level?
    */
@@ -319,7 +324,7 @@ struct ConsensusSet
   struct Route **targets;
 
   /**
-   * Size of the 'targets' array.
+   * Size of the @e targets array.
    */
   unsigned int array_length;
 
@@ -336,7 +341,7 @@ static struct GNUNET_CONTAINER_MultiPeerMap *direct_neighbors;
 /**
  * Hashmap with all routes that we currently support; contains
  * routing information for all peers from distance 2
- * up to distance DEFAULT_FISHEYE_DEPTH.
+ * up to distance #DEFAULT_FISHEYE_DEPTH.
  */
 static struct GNUNET_CONTAINER_MultiPeerMap *all_routes;
 
@@ -344,7 +349,7 @@ static struct GNUNET_CONTAINER_MultiPeerMap *all_routes;
  * Array of consensus sets we expose to the outside world.  Sets
  * are structured by the distance to the target.
  */
-static struct ConsensusSet consensi[DEFAULT_FISHEYE_DEPTH - 1];
+static struct ConsensusSet consensi[DEFAULT_FISHEYE_DEPTH];
 
 /**
  * Handle to the core service api.
@@ -378,6 +383,15 @@ static struct GNUNET_STATISTICS_Handle *stats;
  */
 static struct GNUNET_ATS_PerformanceHandle *ats;
 
+/**
+ * Task scheduled to refresh routes based on direct neighbours.
+ */
+static GNUNET_SCHEDULER_TaskIdentifier rr_task;
+
+/**
+ * #GNUNET_YES if we are shutting down.
+ */
+static int in_shutdown;
 
 /**
  * Start creating a new DV set union by initiating the connection.
@@ -430,8 +444,9 @@ send_data_to_plugin (const struct GNUNET_MessageHeader *message,
   size_t size;
 
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Delivering message from peer `%s'\n",
-              GNUNET_i2s (origin));
+              "Delivering message from peer `%s' at distance %u\n",
+              GNUNET_i2s (origin),
+              (unsigned int) distance);
   size = sizeof (struct GNUNET_DV_ReceivedMessage) +
     ntohs (message->size);
   if (size >= GNUNET_SERVER_MAX_MESSAGE_SIZE)
@@ -471,7 +486,7 @@ send_control_to_plugin (const struct GNUNET_MessageHeader *message)
  *
  * @param target peer that received the message
  * @param uid plugin-chosen UID for the message
- * @param nack GNUNET_NO to send ACK, GNUNET_YES to send NACK
+ * @param nack #GNUNET_NO to send ACK, #GNUNET_YES to send NACK
  */
 static void
 send_ack_to_plugin (const struct GNUNET_PeerIdentity *target,
@@ -498,13 +513,16 @@ send_ack_to_plugin (const struct GNUNET_PeerIdentity *target,
  *
  * @param peer peer with a changed distance
  * @param distance new distance to the peer
+ * @param network network used by the neighbor
  */
 static void
 send_distance_change_to_plugin (const struct GNUNET_PeerIdentity *peer,
-                               uint32_t distance)
+                               uint32_t distance,
+                                enum GNUNET_ATS_Network_Type network)
 {
   struct GNUNET_DV_DistanceUpdateMessage du_msg;
 
+  GNUNET_break (GNUNET_ATS_NET_UNSPECIFIED != network);
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Delivering DISTANCE_CHANGED for message about peer `%s'\n",
               GNUNET_i2s (peer));
@@ -512,6 +530,7 @@ send_distance_change_to_plugin (const struct GNUNET_PeerIdentity *peer,
   du_msg.header.type = htons (GNUNET_MESSAGE_TYPE_DV_DISTANCE_CHANGED);
   du_msg.distance = htonl (distance);
   du_msg.peer = *peer;
+  du_msg.network = htonl ((uint32_t) network);
   send_control_to_plugin (&du_msg.header);
 }
 
@@ -521,19 +540,22 @@ send_distance_change_to_plugin (const struct GNUNET_PeerIdentity *peer,
  *
  * @param target peer that connected
  * @param distance distance to the target
+ * @param network the network the next hop is located in
  */
 static void
 send_connect_to_plugin (const struct GNUNET_PeerIdentity *target,
-                       uint32_t distance)
+                       uint32_t distance,
+                        enum GNUNET_ATS_Network_Type network)
 {
   struct GNUNET_DV_ConnectMessage cm;
 
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Delivering CONNECT about peer `%s'\n",
-              GNUNET_i2s (target));
+              "Delivering CONNECT about peer %s with distance %u\n",
+              GNUNET_i2s (target), distance);
   cm.header.size = htons (sizeof (cm));
   cm.header.type = htons (GNUNET_MESSAGE_TYPE_DV_CONNECT);
   cm.distance = htonl (distance);
+  cm.network = htonl ((uint32_t) network);
   cm.peer = *target;
   send_control_to_plugin (&cm.header);
 }
@@ -581,12 +603,10 @@ core_transmit_notify (void *cls, size_t size, void *buf)
   dn->cth = NULL;
   if (NULL == buf)
   {
-    /* peer disconnected */
+    /* client disconnected */
     return 0;
   }
   off = 0;
-  pending = dn->pm_head;
-  off = 0;
   while ( (NULL != (pending = dn->pm_head)) &&
          (size >= off + (msize = ntohs (pending->msg->size))))
   {
@@ -596,20 +616,31 @@ core_transmit_notify (void *cls, size_t size, void *buf)
                                  pending);
     memcpy (&cbuf[off], pending->msg, msize);
     if (0 != pending->uid)
-      send_ack_to_plugin (&pending->ultimate_target,
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                  "Acking transmission of %u bytes to %s with plugin\n",
+                  msize,
+                  GNUNET_i2s (&pending->next_target));
+      send_ack_to_plugin (&pending->next_target,
                          pending->uid,
                          GNUNET_NO);
+    }
     GNUNET_free (pending);
     off += msize;
   }
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Transmitting total of %u bytes to %s\n",
+             off,
+             GNUNET_i2s (&dn->peer));
+  GNUNET_assert (NULL != core_api);
   if (NULL != dn->pm_head)
     dn->cth =
       GNUNET_CORE_notify_transmit_ready (core_api,
                                         GNUNET_YES /* cork */,
-                                        0 /* priority */,
+                                        GNUNET_CORE_PRIO_BEST_EFFORT,
                                         GNUNET_TIME_UNIT_FOREVER_REL,
                                         &dn->peer,
-                                        msize,                                 
+                                        msize,
                                         &core_transmit_notify, dn);
   return off;
 }
@@ -619,10 +650,10 @@ core_transmit_notify (void *cls, size_t size, void *buf)
  * Forward the given payload to the given target.
  *
  * @param target where to send the message
+ * @param distance distance to the @a sender
  * @param uid unique ID for the message
- * @param ultimate_target ultimate recipient for the message
- * @param distance expected (remaining) distance to the target
  * @param sender original sender of the message
+ * @param actual_target ultimate recipient for the message
  * @param payload payload of the message
  */
 static void
@@ -630,7 +661,7 @@ forward_payload (struct DirectNeighbor *target,
                 uint32_t distance,
                 uint32_t uid,
                 const struct GNUNET_PeerIdentity *sender,
-                const struct GNUNET_PeerIdentity *ultimate_target,
+                const struct GNUNET_PeerIdentity *actual_target,
                 const struct GNUNET_MessageHeader *payload)
 {
   struct PendingMessage *pm;
@@ -638,11 +669,15 @@ forward_payload (struct DirectNeighbor *target,
   size_t msize;
 
   if ( (target->pm_queue_size >= MAX_QUEUE_SIZE) &&
+       (0 == uid) &&
        (0 != memcmp (sender,
                     &my_identity,
                     sizeof (struct GNUNET_PeerIdentity))) )
   {
-    GNUNET_break (0 == uid);
+    /* not _our_ client and queue is full, drop */
+    GNUNET_STATISTICS_update (stats,
+                              "# messages dropped",
+                              1, GNUNET_NO);
     return;
   }
   msize = sizeof (struct RouteMessage) + ntohs (payload->size);
@@ -652,27 +687,28 @@ forward_payload (struct DirectNeighbor *target,
     return;
   }
   pm = GNUNET_malloc (sizeof (struct PendingMessage) + msize);
-  pm->ultimate_target = *ultimate_target;
+  pm->next_target = target->peer;
   pm->uid = uid;
   pm->msg = (const struct GNUNET_MessageHeader *) &pm[1];
   rm = (struct RouteMessage *) &pm[1];
   rm->header.size = htons ((uint16_t) msize);
   rm->header.type = htons (GNUNET_MESSAGE_TYPE_DV_ROUTE);
   rm->distance = htonl (distance);
-  rm->target = target->peer;
+  rm->target = *actual_target;
   rm->sender = *sender;
   memcpy (&rm[1], payload, ntohs (payload->size));
   GNUNET_CONTAINER_DLL_insert_tail (target->pm_head,
                                    target->pm_tail,
                                    pm);
   target->pm_queue_size++;
+  GNUNET_assert (NULL != core_api);
   if (NULL == target->cth)
     target->cth = GNUNET_CORE_notify_transmit_ready (core_api,
                                                     GNUNET_YES /* cork */,
-                                                    0 /* priority */,
+                                                    GNUNET_CORE_PRIO_BEST_EFFORT,
                                                     GNUNET_TIME_UNIT_FOREVER_REL,
                                                     &target->peer,
-                                                    msize,                                     
+                                                    msize,
                                                     &core_transmit_notify, target);
 }
 
@@ -689,6 +725,7 @@ get_consensus_slot (uint32_t distance)
   struct ConsensusSet *cs;
   unsigned int i;
 
+  GNUNET_assert (distance < DEFAULT_FISHEYE_DEPTH);
   cs = &consensi[distance];
   i = 0;
   while ( (i < cs->array_length) &&
@@ -715,6 +752,12 @@ allocate_route (struct Route *route,
 {
   unsigned int i;
 
+  if (distance >= DEFAULT_FISHEYE_DEPTH)
+  {
+    route->target.distance = htonl (distance);
+    route->set_offset = UINT_MAX; /* invalid slot */
+    return;
+  }
   i = get_consensus_slot (distance);
   route->set_offset = i;
   consensi[distance].targets[i] = route;
@@ -730,6 +773,9 @@ allocate_route (struct Route *route,
 static void
 release_route (struct Route *route)
 {
+  if (UINT_MAX == route->set_offset)
+    return;
+  GNUNET_assert (ntohl (route->target.distance) < DEFAULT_FISHEYE_DEPTH);
   consensi[ntohl (route->target.distance)].targets[route->set_offset] = NULL;
   route->set_offset = UINT_MAX; /* indicate invalid slot */
 }
@@ -745,13 +791,8 @@ static void
 move_route (struct Route *route,
            uint32_t new_distance)
 {
-  unsigned int i;
-
   release_route (route);
-  i = get_consensus_slot (new_distance);
-  route->set_offset = i;
-  consensi[new_distance].targets[i] = route;
-  route->target.distance = htonl (new_distance);
+  allocate_route (route, new_distance);
 }
 
 
@@ -772,25 +813,32 @@ build_set (void *cls)
   struct DirectNeighbor *neighbor = cls;
   struct GNUNET_SET_Element element;
   struct Target *target;
+  struct Route *route;
+
   target = NULL;
-  while ( (DEFAULT_FISHEYE_DEPTH - 1 > neighbor->consensus_insertion_distance) &&
+  /* skip over NULL entries */
+  while ( (DEFAULT_FISHEYE_DEPTH > neighbor->consensus_insertion_distance) &&
+         (consensi[neighbor->consensus_insertion_distance].array_length > neighbor->consensus_insertion_offset) &&
+         (NULL == consensi[neighbor->consensus_insertion_distance].targets[neighbor->consensus_insertion_offset]) )
+    neighbor->consensus_insertion_offset++;
+  while ( (DEFAULT_FISHEYE_DEPTH > neighbor->consensus_insertion_distance) &&
          (consensi[neighbor->consensus_insertion_distance].array_length == neighbor->consensus_insertion_offset) )
   {
     /* If we reached the last element of a consensus array element: increase distance and start with next array */
     neighbor->consensus_insertion_offset = 0;
     neighbor->consensus_insertion_distance++;
     /* skip over NULL entries */
-    while ( (DEFAULT_FISHEYE_DEPTH - 1 > neighbor->consensus_insertion_distance) &&
+    while ( (DEFAULT_FISHEYE_DEPTH > neighbor->consensus_insertion_distance) &&
            (consensi[neighbor->consensus_insertion_distance].array_length  > neighbor->consensus_insertion_offset) &&
            (NULL == consensi[neighbor->consensus_insertion_distance].targets[neighbor->consensus_insertion_offset]) )
       neighbor->consensus_insertion_offset++;
   }
-  if (DEFAULT_FISHEYE_DEPTH - 1 == neighbor->consensus_insertion_distance)
+  if (DEFAULT_FISHEYE_DEPTH == neighbor->consensus_insertion_distance)
   {
     /* we have added all elements to the set, run the operation */
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                "Finished building my SET for peer `%s' with %u elements, committing\n",
-               GNUNET_i2s(&neighbor->peer),
+               GNUNET_i2s (&neighbor->peer),
                neighbor->consensus_elements);
     GNUNET_SET_commit (neighbor->set_op,
                       neighbor->my_set);
@@ -799,36 +847,31 @@ build_set (void *cls)
     return;
   }
 
-  target = &consensi[neighbor->consensus_insertion_distance].targets[neighbor->consensus_insertion_offset]->target;
+  route = consensi[neighbor->consensus_insertion_distance].targets[neighbor->consensus_insertion_offset];
+  GNUNET_assert (NULL != route);
+  target = &route->target;
+  GNUNET_assert (ntohl (target->distance) < DEFAULT_FISHEYE_DEPTH);
   element.size = sizeof (struct Target);
   element.type = htons (0); /* do we need this? */
   element.data = target;
 
   /* Find next non-NULL entry */
   neighbor->consensus_insertion_offset++;
-  /* skip over NULL entries */
-  while ( (DEFAULT_FISHEYE_DEPTH - 1 > neighbor->consensus_insertion_distance) &&
-         (consensi[neighbor->consensus_insertion_distance].array_length > neighbor->consensus_insertion_offset) &&
-         (NULL == consensi[neighbor->consensus_insertion_distance].targets[neighbor->consensus_insertion_offset]) )
-  {
-    neighbor->consensus_insertion_offset++;
-  }
-
-  if ( (0 != memcmp(&target->peer, &my_identity, sizeof (my_identity))) &&
-       (0 != memcmp(&target->peer, &neighbor->peer, sizeof (neighbor->peer))) )
+  if ( (0 != memcmp (&target->peer, &my_identity, sizeof (my_identity))) &&
+       (0 != memcmp (&target->peer, &neighbor->peer, sizeof (neighbor->peer))) )
   {
     /* Add target if it is not the neighbor or this peer */
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                 "Adding peer `%s' with distance %u to SET\n",
                 GNUNET_i2s (&target->peer),
-                ntohl (target->distance));
+                ntohl (target->distance) + 1);
     GNUNET_SET_add_element (neighbor->my_set,
                             &element,
                             &build_set, neighbor);
     neighbor->consensus_elements++;
   }
   else
-    build_set(neighbor);
+    build_set (neighbor);
 }
 
 
@@ -855,6 +898,10 @@ handle_direct_connect (struct DirectNeighbor *neighbor)
                                             &neighbor->peer);
   if (NULL != route)
   {
+    GNUNET_assert (GNUNET_YES ==
+                  GNUNET_CONTAINER_multipeermap_remove (all_routes,
+                                                         &neighbor->peer,
+                                                         route));
     send_disconnect_to_plugin (&neighbor->peer);
     release_route (route);
     GNUNET_free (route);
@@ -862,8 +909,7 @@ handle_direct_connect (struct DirectNeighbor *neighbor)
 
   neighbor->direct_route = GNUNET_new (struct Route);
   neighbor->direct_route->next_hop = neighbor;
-  neighbor->direct_route->target.peer= neighbor->peer;
-  neighbor->direct_route->target.distance = DIRECT_NEIGHBOR_COST;
+  neighbor->direct_route->target.peer = neighbor->peer;
   allocate_route (neighbor->direct_route, DIRECT_NEIGHBOR_COST);
 
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
@@ -893,7 +939,7 @@ handle_direct_connect (struct DirectNeighbor *neighbor)
     }
     else
       neighbor->initiate_task = GNUNET_SCHEDULER_add_now (&initiate_set_union,
-                                                       neighbor);
+                                                          neighbor);
   }
   else
   {
@@ -936,6 +982,7 @@ handle_core_connect (void *cls,
                                                peer);
   if (NULL != neighbor)
   {
+    GNUNET_break (GNUNET_ATS_NET_UNSPECIFIED != neighbor->network);
     GNUNET_break (GNUNET_YES != neighbor->connected);
     neighbor->connected = GNUNET_YES;
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
@@ -959,6 +1006,7 @@ handle_core_connect (void *cls,
                                                    GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY));
   neighbor->connected = GNUNET_YES;
   neighbor->distance = 0; /* unknown */
+  neighbor->network = GNUNET_ATS_NET_UNSPECIFIED;
 }
 
 
@@ -968,7 +1016,7 @@ handle_core_connect (void *cls,
  * @param cls NULL
  * @param key key of the value
  * @param value value to free
- * @return GNUNET_OK to continue to iterate
+ * @return #GNUNET_OK to continue to iterate
  */
 static int
 free_targets (void *cls,
@@ -980,6 +1028,33 @@ free_targets (void *cls,
 }
 
 
+/**
+ * Add a new route to the given @a target via the given @a neighbor.
+ *
+ * @param target the target of the route
+ * @param neighbor the next hop for communicating with the @a target
+ */
+static void
+add_new_route (struct Target *target,
+               struct DirectNeighbor *neighbor)
+{
+  struct Route *route;
+
+  route = GNUNET_new (struct Route);
+  route->next_hop = neighbor;
+  route->target.peer = target->peer;
+  allocate_route (route, ntohl (target->distance) + 1);
+  GNUNET_assert (GNUNET_YES ==
+                GNUNET_CONTAINER_multipeermap_put (all_routes,
+                                                   &route->target.peer,
+                                                   route,
+                                                   GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY));
+  send_connect_to_plugin (&route->target.peer,
+                          ntohl (route->target.distance),
+                          neighbor->network);
+}
+
+
 /**
  * Multipeerhmap iterator for checking if a given route is
  * (now) useful to this peer.
@@ -988,7 +1063,7 @@ free_targets (void *cls,
  * @param key key value stored under
  * @param value a 'struct Target' that may or may not be useful; not that
  *        the distance in 'target' does not include the first hop yet
- * @return GNUNET_YES to continue iteration, GNUNET_NO to stop
+ * @return #GNUNET_YES to continue iteration, #GNUNET_NO to stop
  */
 static int
 check_possible_route (void *cls,
@@ -999,30 +1074,29 @@ check_possible_route (void *cls,
   struct Target *target = value;
   struct Route *route;
 
+  if (GNUNET_YES ==
+      GNUNET_CONTAINER_multipeermap_contains (direct_neighbors,
+                                              key))
+    return GNUNET_YES; /* direct route, do not care about alternatives */
   route = GNUNET_CONTAINER_multipeermap_get (all_routes,
                                             key);
   if (NULL != route)
   {
+    /* we have an existing route, check how it compares with going via 'target' */
     if (ntohl (route->target.distance) > ntohl (target->distance) + 1)
     {
-      /* this 'target' is cheaper than the existing route; switch to alternative route! */
+      /* via 'target' is cheaper than the existing route; switch to alternative route! */
       move_route (route, ntohl (target->distance) + 1);
       route->next_hop = neighbor;
-      send_distance_change_to_plugin (&target->peer, ntohl (target->distance) + 1);
+      send_distance_change_to_plugin (&target->peer,
+                                      ntohl (target->distance) + 1,
+                                      neighbor->network);
     }
     return GNUNET_YES; /* got a route to this target already */
   }
-  route = GNUNET_new (struct Route);
-  route->next_hop = neighbor;
-  route->target.distance = htonl (ntohl (target->distance) + 1);
-  route->target.peer = target->peer;
-  allocate_route (route, ntohl (route->target.distance));
-  GNUNET_assert (GNUNET_YES ==
-                GNUNET_CONTAINER_multipeermap_put (all_routes,
-                                                   &route->target.peer,
-                                                   route,
-                                                   GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY));
-  send_connect_to_plugin (&route->target.peer, ntohl (target->distance));
+  if (ntohl (target->distance) >= DEFAULT_FISHEYE_DEPTH)
+    return GNUNET_YES; /* distance is too large to be interesting */
+  add_new_route (target, neighbor);
   return GNUNET_YES;
 }
 
@@ -1033,8 +1107,8 @@ check_possible_route (void *cls,
  *
  * @param cls NULL
  * @param key peer identity of the given direct neighbor
- * @param value a 'struct DirectNeighbor' to check for additional routes
- * @return GNUNET_YES to continue iteration
+ * @param value a `struct DirectNeighbor` to check for additional routes
+ * @return #GNUNET_YES to continue iteration
  */
 static int
 refresh_routes (void *cls,
@@ -1054,6 +1128,36 @@ refresh_routes (void *cls,
 }
 
 
+/**
+ * Task to run #refresh_routes() on all direct neighbours.
+ *
+ * @param cls NULL
+ * @param tc unused
+ */
+static void
+refresh_routes_task (void *cls,
+                     const struct GNUNET_SCHEDULER_TaskContext *tc)
+{
+  rr_task = GNUNET_SCHEDULER_NO_TASK;
+  GNUNET_CONTAINER_multipeermap_iterate (direct_neighbors,
+                                        &refresh_routes,
+                                         NULL);
+}
+
+
+/**
+ * Asynchronously run #refresh_routes() at the next opportunity
+ * on all direct neighbours.
+ */
+static void
+schedule_refresh_routes ()
+{
+  if (GNUNET_SCHEDULER_NO_TASK == rr_task)
+    rr_task = GNUNET_SCHEDULER_add_now (&refresh_routes_task,
+                                        NULL);
+}
+
+
 /**
  * Get distance information from 'atsi'.
  *
@@ -1069,21 +1173,40 @@ get_atsi_distance (const struct GNUNET_ATS_Information *atsi,
 
   for (i = 0; i < atsi_count; i++)
     if (ntohl (atsi[i].type) == GNUNET_ATS_QUALITY_NET_DISTANCE)
-      return (0 == ntohl (atsi->value)) ? DIRECT_NEIGHBOR_COST : ntohl (atsi->value); // FIXME: 0 check should not be required once ATS is fixed!
+      return (0 == ntohl (atsi[i].value)) ? DIRECT_NEIGHBOR_COST : ntohl (atsi[i].value); // FIXME: 0 check should not be required once ATS is fixed!
   /* If we do not have explicit distance data, assume direct neighbor. */
   return DIRECT_NEIGHBOR_COST;
 }
 
 
+/**
+ * Get network information from 'atsi'.
+ *
+ * @param atsi performance data
+ * @param atsi_count number of entries in atsi
+ * @return connected transport network
+ */
+static enum GNUNET_ATS_Network_Type
+get_atsi_network (const struct GNUNET_ATS_Information *atsi,
+                   uint32_t atsi_count)
+{
+  uint32_t i;
+
+  for (i = 0; i < atsi_count; i++)
+    if (ntohl (atsi[i].type) == GNUNET_ATS_NETWORK_TYPE)
+      return (enum GNUNET_ATS_Network_Type) ntohl (atsi[i].value);
+  return GNUNET_ATS_NET_UNSPECIFIED;
+}
+
 /**
  * Multipeermap iterator for freeing routes that go via a particular
  * neighbor that disconnected and is thus no longer available.
  *
  * @param cls the direct neighbor that is now unavailable
  * @param key key value stored under
- * @param value a 'struct Route' that may or may not go via neighbor
+ * @param value a `struct Route` that may or may not go via neighbor
  *
- * @return GNUNET_YES to continue iteration, GNUNET_NO to stop
+ * @return #GNUNET_YES to continue iteration, #GNUNET_NO to stop
  */
 static int
 cull_routes (void *cls,
@@ -1115,6 +1238,9 @@ cull_routes (void *cls,
 static void
 handle_direct_disconnect (struct DirectNeighbor *neighbor)
 {
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Culling routes via %s due to direct disconnect\n",
+             GNUNET_i2s (&neighbor->peer));
   GNUNET_CONTAINER_multipeermap_iterate (all_routes,
                                         &cull_routes,
                                          neighbor);
@@ -1176,11 +1302,14 @@ handle_direct_disconnect (struct DirectNeighbor *neighbor)
  *
  * @param cls closure
  * @param address the address
- * @param active is this address in active use
+ * @param active #GNUNET_YES if this address is actively used
+ *        to maintain a connection to a peer;
+ *        #GNUNET_NO if the address is not actively used;
+ *        #GNUNET_SYSERR if this address is no longer available for ATS
  * @param bandwidth_out assigned outbound bandwidth for the connection
  * @param bandwidth_in assigned inbound bandwidth for the connection
  * @param ats performance data for the address (as far as known)
- * @param ats_count number of performance records in 'ats'
+ * @param ats_count number of performance records in @a ats
  */
 static void
 handle_ats_update (void *cls,
@@ -1193,20 +1322,34 @@ handle_ats_update (void *cls,
 {
   struct DirectNeighbor *neighbor;
   uint32_t distance;
+  enum GNUNET_ATS_Network_Type network = GNUNET_ATS_NET_UNSPECIFIED;
+
+  if (NULL == address)
+  {
+    /* ATS service temporarily disconnected */
+    return;
+  }
 
-  if (GNUNET_NO == active)
-       return;
+  if (GNUNET_YES != active)
+  {
+    // FIXME: handle disconnect/inactive case too!
+    return;
+  }
   distance = get_atsi_distance (ats, ats_count);
-  /*
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-             "ATS says distance to %s is %u\n",
-             GNUNET_i2s (&address->peer),
-             (unsigned int) distance);*/
+  network = get_atsi_network (ats, ats_count);
+  GNUNET_break (GNUNET_ATS_NET_UNSPECIFIED != network);
   /* check if entry exists */
   neighbor = GNUNET_CONTAINER_multipeermap_get (direct_neighbors,
                                                &address->peer);
   if (NULL != neighbor)
   {
+    neighbor->network = network;
+    if (neighbor->distance == distance)
+      return; /* nothing new to see here, move along */
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                "ATS says distance to %s is now %u\n",
+                GNUNET_i2s (&address->peer),
+                (unsigned int) distance);
     if ( (DIRECT_NEIGHBOR_COST == neighbor->distance) &&
         (DIRECT_NEIGHBOR_COST == distance) )
       return; /* no change */
@@ -1217,9 +1360,7 @@ handle_ats_update (void *cls,
                                "# peers connected (1-hop)",
                                -1, GNUNET_NO);
       handle_direct_disconnect (neighbor);
-      GNUNET_CONTAINER_multipeermap_iterate (direct_neighbors,
-                                            &refresh_routes,
-                                            NULL);
+      schedule_refresh_routes ();
       return;
     }
     neighbor->distance = distance;
@@ -1230,6 +1371,10 @@ handle_ats_update (void *cls,
     handle_direct_connect (neighbor);
     return;
   }
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "ATS says distance to %s is now %u\n",
+             GNUNET_i2s (&address->peer),
+             (unsigned int) distance);
   neighbor = GNUNET_new (struct DirectNeighbor);
   neighbor->peer = address->peer;
   GNUNET_assert (GNUNET_YES ==
@@ -1239,6 +1384,7 @@ handle_ats_update (void *cls,
                                                    GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY));
   neighbor->connected = GNUNET_NO; /* not yet */
   neighbor->distance = distance;
+  neighbor->network = network;
 }
 
 
@@ -1247,9 +1393,9 @@ handle_ats_update (void *cls,
  * if we also used it for our route, we need to remove it from our
  * 'all_routes' set (and later check if an alternative path now exists).
  *
- * @param cls the 'struct DirectNeighbor'
+ * @param cls the `struct DirectNeighbor`
  * @param key peer identity for the target
- * @param value a 'struct Target' previously reachable via the given neighbor
+ * @param value a `struct Target` previously reachable via the given neighbor
  */
 static int
 check_target_removed (void *cls,
@@ -1262,28 +1408,37 @@ check_target_removed (void *cls,
 
   new_target = GNUNET_CONTAINER_multipeermap_get (neighbor->neighbor_table_consensus,
                                                  key);
-  if (NULL == new_target)
+  current_route = GNUNET_CONTAINER_multipeermap_get (all_routes,
+                                                     key);
+  if (NULL != new_target)
   {
-    /* target was revoked, check if it was used */
-    current_route = GNUNET_CONTAINER_multipeermap_get (all_routes,
-                                                      key);
-    if ( (NULL == current_route) ||
-        (current_route->next_hop != neighbor) )
+    /* target was in old set, is in new set */
+    if ( (NULL != current_route) &&
+         (current_route->next_hop == neighbor) &&
+         (current_route->target.distance != new_target->distance) )
     {
-      /* didn't matter, wasn't used */
-      return GNUNET_OK;
+      /* need to recalculate routes due to distance change */
+      neighbor->target_removed = GNUNET_YES;
     }
-    /* remove existing route */
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-               "Lost route to %s\n",
-               GNUNET_i2s (&current_route->target.peer));
-    GNUNET_assert (GNUNET_YES ==
-                  GNUNET_CONTAINER_multipeermap_remove (all_routes, key, current_route));
-    send_disconnect_to_plugin (&current_route->target.peer);
-    GNUNET_free (current_route);
-    neighbor->target_removed = GNUNET_YES;
     return GNUNET_OK;
   }
+  /* target was revoked, check if it was used */
+  if ( (NULL == current_route) ||
+       (current_route->next_hop != neighbor) )
+  {
+    /* didn't matter, wasn't used */
+    return GNUNET_OK;
+  }
+  /* remove existing route */
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Lost route to %s\n",
+              GNUNET_i2s (&current_route->target.peer));
+  GNUNET_assert (GNUNET_YES ==
+                 GNUNET_CONTAINER_multipeermap_remove (all_routes, key, current_route));
+  send_disconnect_to_plugin (&current_route->target.peer);
+  release_route (current_route);
+  GNUNET_free (current_route);
+  neighbor->target_removed = GNUNET_YES;
   return GNUNET_OK;
 }
 
@@ -1292,9 +1447,9 @@ check_target_removed (void *cls,
  * Check if a target was added to the set of the other peer; if it
  * was added or impoves the existing route, do the needed updates.
  *
- * @param cls the 'struct DirectNeighbor'
+ * @param cls the `struct DirectNeighbor`
  * @param key peer identity for the target
- * @param value a 'struct Target' now reachable via the given neighbor
+ * @param value a `struct Target` now reachable via the given neighbor
  */
 static int
 check_target_added (void *cls,
@@ -1313,15 +1468,34 @@ check_target_added (void *cls,
     /* route exists */
     if (current_route->next_hop == neighbor)
     {
-      /* we had the same route before, no change */
+      /* we had the same route before, no change in target */
       if (ntohl (target->distance) + 1 != ntohl (current_route->target.distance))
       {
-       current_route->target.distance = htonl (ntohl (target->distance) + 1);
-       send_distance_change_to_plugin (&target->peer, ntohl (target->distance) + 1);
+        /* but distance changed! */
+        if (ntohl (target->distance) + 1 > DEFAULT_FISHEYE_DEPTH)
+        {
+          /* distance increased beyond what is allowed, kill route */
+          GNUNET_assert (GNUNET_YES ==
+                         GNUNET_CONTAINER_multipeermap_remove (all_routes,
+                                                               key,
+                                                               current_route));
+          send_disconnect_to_plugin (key);
+          release_route (current_route);
+          GNUNET_free (current_route);
+        }
+        else
+        {
+          /* distance decreased, update route */
+          move_route (current_route,
+                      ntohl (target->distance) + 1);
+          send_distance_change_to_plugin (&target->peer,
+                                          ntohl (target->distance) + 1,
+                                          neighbor->network);
+        }
       }
       return GNUNET_OK;
     }
-    if (ntohl (current_route->target.distance) >= ntohl (target->distance) + 1)
+    if (ntohl (current_route->target.distance) <= ntohl (target->distance) + 1)
     {
       /* alternative, shorter route exists, ignore */
       return GNUNET_OK;
@@ -1331,9 +1505,12 @@ check_target_added (void *cls,
        very short routes to take over longer paths; as we don't
        check that the shorter routes actually work, a malicious
        direct neighbor can use this to DoS our long routes */
+
+    move_route (current_route, ntohl (target->distance) + 1);
     current_route->next_hop = neighbor;
-    current_route->target.distance = htonl (ntohl (target->distance) + 1);
-    send_distance_change_to_plugin (&target->peer, ntohl (target->distance) + 1);
+    send_distance_change_to_plugin (&target->peer,
+                                    ntohl (target->distance) + 1,
+                                    neighbor->network);
     return GNUNET_OK;
   }
   /* new route */
@@ -1344,14 +1521,16 @@ check_target_added (void *cls,
   current_route = GNUNET_new (struct Route);
   current_route->next_hop = neighbor;
   current_route->target.peer = target->peer;
-  current_route->target.distance = htonl (ntohl (target->distance) + 1);
+  allocate_route (current_route, ntohl (target->distance) + 1);
   GNUNET_assert (GNUNET_YES ==
                 GNUNET_CONTAINER_multipeermap_put (all_routes,
                                                    &current_route->target.peer,
                                                    current_route,
                                                    GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY));
+
   send_connect_to_plugin (&current_route->target.peer,
-                         ntohl (current_route->target.distance));
+                         ntohl (current_route->target.distance),
+                         neighbor->network);
   return GNUNET_OK;
 }
 
@@ -1362,9 +1541,9 @@ check_target_added (void *cls,
  * We have learned a new route from the other peer.  Add it to the
  * route set we're building.
  *
- * @param cls the 'struct DirectNeighbor' we're building the consensus with
- * @param element a result element, only valid if status is GNUNET_SET_STATUS_OK
- * @param status see enum GNUNET_SET_Status
+ * @param cls the `struct DirectNeighbor` we're building the consensus with
+ * @param element a result element, only valid if status is #GNUNET_SET_STATUS_OK
+ * @param status see `enum GNUNET_SET_Status`
  */
 static void
 handle_set_union_result (void *cls,
@@ -1372,28 +1551,30 @@ handle_set_union_result (void *cls,
                         enum GNUNET_SET_Status status)
 {
   struct DirectNeighbor *neighbor = cls;
+  struct DirectNeighbor *dn;
   struct Target *target;
   char *status_str;
 
-  switch (status) {
-    case GNUNET_SET_STATUS_OK:
-      status_str = "GNUNET_SET_STATUS_OK";
-      break;
-    case GNUNET_SET_STATUS_TIMEOUT:
-      status_str = "GNUNET_SET_STATUS_TIMEOUT";
-      break;
-    case GNUNET_SET_STATUS_FAILURE:
-      status_str = "GNUNET_SET_STATUS_FAILURE";
-      break;
-    case GNUNET_SET_STATUS_HALF_DONE:
-      status_str = "GNUNET_SET_STATUS_HALF_DONE";
-      break;
-    case GNUNET_SET_STATUS_DONE:
-      status_str = "GNUNET_SET_STATUS_DONE";
-      break;
-    default:
-      status_str = "UNDEFINED";
-      break;
+  switch (status)
+  {
+  case GNUNET_SET_STATUS_OK:
+    status_str = "GNUNET_SET_STATUS_OK";
+    break;
+  case GNUNET_SET_STATUS_TIMEOUT:
+    status_str = "GNUNET_SET_STATUS_TIMEOUT";
+    break;
+  case GNUNET_SET_STATUS_FAILURE:
+    status_str = "GNUNET_SET_STATUS_FAILURE";
+    break;
+  case GNUNET_SET_STATUS_HALF_DONE:
+    status_str = "GNUNET_SET_STATUS_HALF_DONE";
+    break;
+  case GNUNET_SET_STATUS_DONE:
+    status_str = "GNUNET_SET_STATUS_DONE";
+    break;
+  default:
+    status_str = "UNDEFINED";
+    break;
   }
 
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
@@ -1407,10 +1588,22 @@ handle_set_union_result (void *cls,
       GNUNET_break_op (0);
       return;
     }
+    if ( (NULL != (dn = GNUNET_CONTAINER_multipeermap_get (direct_neighbors, &((struct Target *) element->data)->peer))) && (DIRECT_NEIGHBOR_COST == dn->distance) )
+    {
+      /* this is a direct neighbor of ours, we do not care about routes
+         to this peer */
+      return;
+    }
     target = GNUNET_new (struct Target);
     memcpy (target, element->data, sizeof (struct Target));
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                "Received information about peer `%s' with distance %u from SET\n",
+                GNUNET_i2s (&target->peer),
+                ntohl (target->distance) + 1);
+
     if (NULL == neighbor->neighbor_table_consensus)
-      neighbor->neighbor_table_consensus = GNUNET_CONTAINER_multipeermap_create (10, GNUNET_NO);
+      neighbor->neighbor_table_consensus
+        = GNUNET_CONTAINER_multipeermap_create (10, GNUNET_NO);
     if (GNUNET_YES !=
        GNUNET_CONTAINER_multipeermap_put (neighbor->neighbor_table_consensus,
                                           &target->peer,
@@ -1442,36 +1635,36 @@ handle_set_union_result (void *cls,
                                                              neighbor);
     break;
   case GNUNET_SET_STATUS_HALF_DONE:
+    break;
+  case GNUNET_SET_STATUS_DONE:
     /* we got all of our updates; integrate routing table! */
     neighbor->target_removed = GNUNET_NO;
-    GNUNET_CONTAINER_multipeermap_iterate (neighbor->neighbor_table,
-                                          &check_target_removed,
-                                          neighbor);
+    if (NULL == neighbor->neighbor_table_consensus)
+      neighbor->neighbor_table_consensus = GNUNET_CONTAINER_multipeermap_create (10, GNUNET_NO);
+    if (NULL != neighbor->neighbor_table)
+      GNUNET_CONTAINER_multipeermap_iterate (neighbor->neighbor_table,
+                                             &check_target_removed,
+                                             neighbor);
     if (GNUNET_YES == neighbor->target_removed)
     {
       /* check if we got an alternative for the removed routes */
-      GNUNET_CONTAINER_multipeermap_iterate (direct_neighbors,
-                                            &refresh_routes,
-                                            NULL);
+      schedule_refresh_routes ();
     }
     /* add targets that appeared (and check for improved routes) */
-    if (NULL == neighbor->neighbor_table_consensus)
-      neighbor->neighbor_table_consensus = GNUNET_CONTAINER_multipeermap_create (10, GNUNET_NO);
     GNUNET_CONTAINER_multipeermap_iterate (neighbor->neighbor_table_consensus,
-                                          &check_target_added,
-                                          neighbor);
+                                           &check_target_added,
+                                           neighbor);
     if (NULL != neighbor->neighbor_table)
     {
       GNUNET_CONTAINER_multipeermap_iterate (neighbor->neighbor_table,
-                                            &free_targets,
-                                            NULL);
+                                             &free_targets,
+                                             NULL);
       GNUNET_CONTAINER_multipeermap_destroy (neighbor->neighbor_table);
       neighbor->neighbor_table = NULL;
     }
     neighbor->neighbor_table = neighbor->neighbor_table_consensus;
     neighbor->neighbor_table_consensus = NULL;
-    break;
-  case GNUNET_SET_STATUS_DONE:
+
     /* operation done, schedule next run! */
     neighbor->set_op = NULL;
     if (0 < memcmp (&neighbor->peer,
@@ -1543,7 +1736,7 @@ listen_set_union (void *cls,
 /**
  * Start creating a new DV set union by initiating the connection.
  *
- * @param cls the 'struct DirectNeighbor' of the peer we're building
+ * @param cls the `struct DirectNeighbor *` of the peer we're building
  *        a routing consensus with
  * @param tc scheduler context
  */
@@ -1551,6 +1744,7 @@ static void
 initiate_set_union (void *cls,
                    const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
+  static uint16_t salt;
   struct DirectNeighbor *neighbor = cls;
 
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
@@ -1562,7 +1756,7 @@ initiate_set_union (void *cls,
   neighbor->set_op = GNUNET_SET_prepare (&neighbor->peer,
                                          &neighbor->real_session_id,
                                          NULL,
-                                         0 /* FIXME: salt */,
+                                         salt++,
                                          GNUNET_SET_RESULT_ADDED,
                                          &handle_set_union_result,
                                          neighbor);
@@ -1582,7 +1776,7 @@ initiate_set_union (void *cls,
  * @param cls closure
  * @param peer peer which sent the message (immediate sender)
  * @param message the message
- * @return GNUNET_OK on success, GNUNET_SYSERR if the other peer violated the protocol
+ * @return #GNUNET_OK on success, #GNUNET_SYSERR if the other peer violated the protocol
  */
 static int
 handle_dv_route_message (void *cls, const struct GNUNET_PeerIdentity *peer,
@@ -1591,68 +1785,164 @@ handle_dv_route_message (void *cls, const struct GNUNET_PeerIdentity *peer,
   const struct RouteMessage *rm;
   const struct GNUNET_MessageHeader *payload;
   struct Route *route;
+  struct DirectNeighbor *neighbor;
+  struct DirectNeighbor *dn;
+  struct Target *target;
+  uint32_t distance;
+  char me[5];
+  char src[5];
+  char prev[5];
+  char dst[5];
 
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-             "Handling DV message\n");
   if (ntohs (message->size) < sizeof (struct RouteMessage) + sizeof (struct GNUNET_MessageHeader))
   {
     GNUNET_break_op (0);
     return GNUNET_SYSERR;
   }
   rm = (const struct RouteMessage *) message;
+  distance = ntohl (rm->distance);
   payload = (const struct GNUNET_MessageHeader *) &rm[1];
   if (ntohs (message->size) != sizeof (struct RouteMessage) + ntohs (payload->size))
   {
     GNUNET_break_op (0);
     return GNUNET_SYSERR;
   }
+  strncpy (prev, GNUNET_i2s (peer), 4);
+  strncpy (me, GNUNET_i2s (&my_identity), 4);
+  strncpy (src, GNUNET_i2s (&rm->sender), 4);
+  strncpy (dst, GNUNET_i2s (&rm->target), 4);
+  prev[4] = me[4] = src[4] = dst[4] = '\0';
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Handling DV message with %u bytes payload of type %u from %s to %s routed by %s to me (%s @ hop %u)\n",
+              ntohs (message->size) - sizeof (struct RouteMessage),
+              ntohs (payload->type),
+              src, dst,
+              prev, me,
+              (unsigned int) distance + 1);
+
   if (0 == memcmp (&rm->target,
                   &my_identity,
                   sizeof (struct GNUNET_PeerIdentity)))
   {
+    if ((NULL
+        != (dn = GNUNET_CONTAINER_multipeermap_get (direct_neighbors,
+            &rm->sender))) && (DIRECT_NEIGHBOR_COST == dn->distance))
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                  "Discarding DV message, as %s is a direct neighbor\n",
+                  GNUNET_i2s (&rm->sender));
+      GNUNET_STATISTICS_update (stats,
+                                "# messages discarded (direct neighbor)",
+                                1, GNUNET_NO);
+      return GNUNET_OK;
+    }
     /* message is for me, check reverse route! */
     route = GNUNET_CONTAINER_multipeermap_get (all_routes,
                                               &rm->sender);
-    if (NULL == route)
+    if ( (NULL == route) &&
+         (distance < DEFAULT_FISHEYE_DEPTH) )
     {
-      /* don't have reverse route, drop */
-      GNUNET_STATISTICS_update (stats,
-                               "# message discarded (no reverse route)",
-                               1, GNUNET_NO);
-      return GNUNET_OK;
+      /* don't have reverse route yet, learn it! */
+      neighbor = GNUNET_CONTAINER_multipeermap_get (direct_neighbors,
+                                                    peer);
+      if (NULL == neighbor)
+      {
+        GNUNET_break (0);
+        return GNUNET_SYSERR;
+      }
+      target = GNUNET_new (struct Target);
+      target->peer = rm->sender;
+      target->distance = htonl (distance);
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                  "Learning sender %s at distance %u from delivery!\n",
+                  GNUNET_i2s (&rm->sender),
+                  (unsigned int) distance + 1);
+      if (NULL == neighbor->neighbor_table)
+        neighbor->neighbor_table = GNUNET_CONTAINER_multipeermap_create (10, GNUNET_NO);
+      if (GNUNET_YES !=
+          GNUNET_CONTAINER_multipeermap_put (neighbor->neighbor_table,
+                                             &target->peer,
+                                             target,
+                                             GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY))
+      {
+        GNUNET_break_op (0);
+        GNUNET_free (target);
+        return GNUNET_SYSERR;
+      }
+      add_new_route (target, neighbor);
     }
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-               "Delivering %u bytes to myself!\n",
-               ntohs (payload->size));
+               "Delivering %u bytes from %s to myself!\n",
+               ntohs (payload->size),
+                GNUNET_i2s (&rm->sender));
     send_data_to_plugin (payload,
                         &rm->sender,
-                        ntohl (route->target.distance));
+                        1 + distance);
     return GNUNET_OK;
   }
+  if ( (NULL == GNUNET_CONTAINER_multipeermap_get (direct_neighbors,
+                                                   &rm->sender)) &&
+       (NULL == GNUNET_CONTAINER_multipeermap_get (all_routes,
+                                                   &rm->sender)) )
+  {
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                "Learning sender %s at distance %u from forwarding!\n",
+                GNUNET_i2s (&rm->sender),
+                1 + distance);
+    neighbor = GNUNET_CONTAINER_multipeermap_get (direct_neighbors,
+                                                  peer);
+    if (NULL == neighbor)
+    {
+      GNUNET_break (0);
+      return GNUNET_SYSERR;
+    }
+    target = GNUNET_new (struct Target);
+    target->peer = rm->sender;
+    target->distance = htonl (distance);
+    if (NULL == neighbor->neighbor_table)
+      neighbor->neighbor_table = GNUNET_CONTAINER_multipeermap_create (10, GNUNET_NO);
+    if (GNUNET_YES !=
+        GNUNET_CONTAINER_multipeermap_put (neighbor->neighbor_table,
+                                           &target->peer,
+                                           target,
+                                           GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY))
+    {
+      GNUNET_break_op (0);
+      GNUNET_free (target);
+    }
+    add_new_route (target, neighbor);
+  }
+
   route = GNUNET_CONTAINER_multipeermap_get (all_routes,
                                             &rm->target);
   if (NULL == route)
   {
-    GNUNET_STATISTICS_update (stats,
-                             "# messages discarded (no route)",
-                             1, GNUNET_NO);
-    return GNUNET_OK;
+    neighbor = GNUNET_CONTAINER_multipeermap_get (direct_neighbors,
+                                                  &rm->target);
+    if (NULL == neighbor)
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                  "No route to %s, not routing %u bytes!\n",
+                  GNUNET_i2s (&rm->target),
+                  ntohs (payload->size));
+      GNUNET_STATISTICS_update (stats,
+                                "# messages discarded (no route)",
+                                1, GNUNET_NO);
+      return GNUNET_OK;
+    }
   }
-  if (ntohl (route->target.distance) > ntohl (rm->distance) + 1)
+  else
   {
-    GNUNET_STATISTICS_update (stats,
-                             "# messages discarded (target too far)",
-                             1, GNUNET_NO);
-    return GNUNET_OK;
+    neighbor = route->next_hop;
   }
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
              "Forwarding message to %s\n",
-             GNUNET_i2s (&rm->target));
-  forward_payload (route->next_hop,
-                  ntohl (route->target.distance),
+             GNUNET_i2s (&neighbor->peer));
+  forward_payload (neighbor,
+                  distance + 1,
                   0,
-                  &rm->target,
                   &rm->sender,
+                  &rm->target,
                   payload);
   return GNUNET_OK;
 }
@@ -1694,6 +1984,10 @@ handle_dv_send_message (void *cls, struct GNUNET_SERVER_Client *client,
   if (NULL == route)
   {
     /* got disconnected */
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                "No route to %s, dropping local message of type %u\n",
+                GNUNET_i2s (&msg->target),
+                ntohs (payload->type));
     GNUNET_STATISTICS_update (stats,
                              "# local messages discarded (no route)",
                              1, GNUNET_NO);
@@ -1702,15 +1996,16 @@ handle_dv_send_message (void *cls, struct GNUNET_SERVER_Client *client,
     return;
   }
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-             "Forwarding %u bytes to %s\n",
+             "Forwarding %u bytes of type %u to %s\n",
              ntohs (payload->size),
+              ntohs (payload->type),
              GNUNET_i2s (&msg->target));
 
   forward_payload (route->next_hop,
-                  ntohl (route->target.distance),
+                  0 /* first hop, distance is zero */,
                   htonl (msg->uid),
-                  &msg->target,
                   &my_identity,
+                  &msg->target,
                   payload);
   GNUNET_SERVER_receive_done (client, GNUNET_OK);
 }
@@ -1777,9 +2072,10 @@ handle_core_disconnect (void *cls, const struct GNUNET_PeerIdentity *peer)
                              -1, GNUNET_NO);
   }
   cleanup_neighbor (neighbor);
-  GNUNET_CONTAINER_multipeermap_iterate (direct_neighbors,
-                                        &refresh_routes,
-                                         NULL);
+
+  if (GNUNET_YES == in_shutdown)
+    return;
+  schedule_refresh_routes ();
 }
 
 
@@ -1789,11 +2085,12 @@ handle_core_disconnect (void *cls, const struct GNUNET_PeerIdentity *peer)
  * @param cls NULL
  * @param key key value stored under
  * @param value the route to be freed
- *
- * @return GNUNET_YES to continue iteration, GNUNET_NO to stop
+ * @return #GNUNET_YES to continue iteration, #GNUNET_NO to stop
  */
 static int
-free_route (void *cls, const struct GNUNET_PeerIdentity * key, void *value)
+free_route (void *cls,
+            const struct GNUNET_PeerIdentity *key,
+            void *value)
 {
   struct Route *route = value;
 
@@ -1813,15 +2110,15 @@ free_route (void *cls, const struct GNUNET_PeerIdentity * key, void *value)
  * @param cls NULL
  * @param key key value stored under
  * @param value the direct neighbor to be freed
- *
- * @return GNUNET_YES to continue iteration, GNUNET_NO to stop
+ * @return #GNUNET_YES to continue iteration, #GNUNET_NO to stop
  */
 static int
-free_direct_neighbors (void *cls, const struct GNUNET_PeerIdentity * key, void *value)
+free_direct_neighbors (void *cls,
+                       const struct GNUNET_PeerIdentity *key,
+                       void *value)
 {
   struct DirectNeighbor *neighbor = value;
 
-  GNUNET_break (0);
   cleanup_neighbor (neighbor);
   return GNUNET_YES;
 }
@@ -1834,10 +2131,13 @@ free_direct_neighbors (void *cls, const struct GNUNET_PeerIdentity * key, void *
  * @param tc unused
  */
 static void
-shutdown_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+shutdown_task (void *cls,
+               const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   unsigned int i;
 
+  in_shutdown = GNUNET_YES;
+  GNUNET_assert (NULL != core_api);
   GNUNET_CORE_disconnect (core_api);
   core_api = NULL;
   GNUNET_ATS_performance_done (ats);
@@ -1852,30 +2152,38 @@ shutdown_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   stats = NULL;
   GNUNET_SERVER_notification_context_destroy (nc);
   nc = NULL;
-  for (i=0;i<DEFAULT_FISHEYE_DEPTH - 1;i++)
+  for (i=0;i<DEFAULT_FISHEYE_DEPTH;i++)
+  {
     GNUNET_array_grow (consensi[i].targets,
                       consensi[i].array_length,
                       0);
+  }
+  if (GNUNET_SCHEDULER_NO_TASK != rr_task)
+  {
+    GNUNET_SCHEDULER_cancel (rr_task);
+    rr_task = GNUNET_SCHEDULER_NO_TASK;
+  }
 }
 
 
 /**
  * Notify newly connected client about an existing route.
  *
- * @param cls the 'struct GNUNET_SERVER_Client'
+ * @param cls the `struct GNUNET_SERVER_Client *`
  * @param key peer identity
- * @param value the XXX.
- * @return GNUNET_OK (continue to iterate)
+ * @param value the `struct Route *`
+ * @return #GNUNET_OK (continue to iterate)
  */
 static int
-add_route (void *cls,
-          const struct GNUNET_PeerIdentity *key,
-          void *value)
+notify_client_about_route (void *cls,
+                           const struct GNUNET_PeerIdentity *key,
+                           void *value)
 {
   struct GNUNET_SERVER_Client *client = cls;
   struct Route *route = value;
   struct GNUNET_DV_ConnectMessage cm;
 
+  memset (&cm, 0, sizeof (cm));
   cm.header.size = htons (sizeof (cm));
   cm.header.type = htons (GNUNET_MESSAGE_TYPE_DV_CONNECT);
   cm.distance = htonl (route->target.distance);
@@ -1904,7 +2212,7 @@ handle_start (void *cls, struct GNUNET_SERVER_Client *client,
   GNUNET_SERVER_notification_context_add (nc, client);
   GNUNET_SERVER_receive_done (client, GNUNET_OK);
   GNUNET_CONTAINER_multipeermap_iterate (all_routes,
-                                        &add_route,
+                                        &notify_client_about_route,
                                         client);
 }
 
@@ -1950,7 +2258,7 @@ run (void *cls, struct GNUNET_SERVER_Handle *server,
       0},
     {NULL, NULL, 0, 0}
   };
-
+  in_shutdown = GNUNET_NO;
   cfg = c;
   direct_neighbors = GNUNET_CONTAINER_multipeermap_create (128, GNUNET_NO);
   all_routes = GNUNET_CONTAINER_multipeermap_create (65536, GNUNET_NO);
@@ -1968,6 +2276,7 @@ run (void *cls, struct GNUNET_SERVER_Handle *server,
   if (NULL == ats)
   {
     GNUNET_CORE_disconnect (core_api);
+    core_api = NULL;
     return;
   }
   nc = GNUNET_SERVER_notification_context_create (server,