GNUNET_CONSTANTS_BLOOMFILTER_K);
// FIXME: pass priority!?
GDS_NEIGHBOURS_handle_get (GNUNET_BLOCK_TYPE_DHT_HELLO,
- GNUNET_DHT_RO_FIND_PEER,
+ GNUNET_DHT_RO_FIND_PEER | GNUNET_DHT_RO_RECORD_ROUTE,
FIND_PEER_REPLICATION_LEVEL,
0,
&my_identity_hash,
count = 0;
while ((pos != NULL) && (count < bucket_size))
{
- if ((bloom == NULL) ||
- (GNUNET_NO ==
- GNUNET_CONTAINER_bloomfilter_test (bloom,
- &pos->phash)))
+ if ( (NULL == bloom) ||
+ (GNUNET_NO ==
+ GNUNET_CONTAINER_bloomfilter_test (bloom,
+ &pos->phash)))
{
dist = get_distance (key,
&pos->phash);
}
if (NULL == chosen)
GNUNET_STATISTICS_update (GDS_stats,
- gettext_noop ("# Peer selection failed"), 1,
+ gettext_noop ("# Peer selection failed"),
+ 1,
GNUNET_NO);
+ else
+ GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+ "Selected peer `%s' in greedy routing for %s\n",
+ GNUNET_i2s (chosen->id),
+ GNUNET_h2s (key));
return chosen;
}
for (bc = 0; bc <= closest_bucket; bc++)
{
pos = k_buckets[bc].head;
- while ((pos != NULL) && (count < bucket_size))
+ while ( (NULL != pos) && (count < bucket_size) )
{
- if ((bloom != NULL) &&
- (GNUNET_YES ==
- GNUNET_CONTAINER_bloomfilter_test (bloom,
- &pos->phash)))
+ if ( (NULL != bloom) &&
+ (GNUNET_YES ==
+ GNUNET_CONTAINER_bloomfilter_test (bloom,
+ &pos->phash)) )
{
GNUNET_STATISTICS_update (GDS_stats,
gettext_noop
continue; /* Ignore bloomfiltered peers */
}
if (0 == selected--)
+ {
+ GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+ "Selected peer `%s' in random routing for %s\n",
+ GNUNET_i2s (pos->id),
+ GNUNET_h2s (key));
return pos;
+ }
}
}
GNUNET_break (0);
struct PeerInfo *);
for (off = 0; off < ret; off++)
{
- nxt = select_peer (key, bloom, hop_count);
+ nxt = select_peer (key,
+ bloom,
+ hop_count);
if (NULL == nxt)
break;
rtargets[off] = nxt;
"Adding myself (%s) to PUT bloomfilter for %s\n",
GNUNET_i2s (&my_identity),
GNUNET_h2s (key));
- GNUNET_CONTAINER_bloomfilter_add (bf, &my_identity_hash);
+ GNUNET_CONTAINER_bloomfilter_add (bf,
+ &my_identity_hash);
GNUNET_STATISTICS_update (GDS_stats,
gettext_noop ("# PUT requests routed"),
1,
if (GNUNET_YES == log_route_details_stderr)
{
char *tmp;
+ char *pp;
+ pp = GNUNET_STRINGS_pp2s (put_path,
+ putlen);
tmp = GNUNET_strdup (GNUNET_i2s (&my_identity));
LOG_TRAFFIC (GNUNET_ERROR_TYPE_DEBUG,
- "R5N PUT %s: %s->%s (%u, %u=>%u)\n",
+ "R5N PUT %s: %s->%s (%u, %u=>%u, PP: %s)\n",
GNUNET_h2s (&put->key),
GNUNET_i2s (peer->id),
tmp,
GNUNET_CRYPTO_hash_matching_bits (&peer->phash,
&put->key),
GNUNET_CRYPTO_hash_matching_bits (&my_identity_hash,
- &put->key)
- );
+ &put->key),
+ pp);
+ GNUNET_free (pp);
GNUNET_free (tmp);
}
switch (GNUNET_BLOCK_get_key
/**
* Handle a result from local datacache for a GET operation.
*
- * @param cls the `struct ClientHandle` of the client doing the query
+ * @param cls the `struct PeerInfo` for which this is a reply
* @param type type of the block
* @param expiration_time when does the content expire
* @param key key for the content
const void *data,
size_t data_size)
{
- // FIXME: we can probably do better here by
- // passing the peer that did the query in the closure...
- GDS_ROUTING_process (NULL,
- type,
- expiration_time,
- key,
- put_path_length, put_path,
- 0, NULL,
- data, data_size);
+ struct PeerInfo *peer = cls;
+ char *pp;
+
+ pp = GNUNET_STRINGS_pp2s (put_path,
+ put_path_length);
+ GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+ "Found local result for %s (PP: %s)\n",
+ GNUNET_h2s (key),
+ pp);
+ GNUNET_free (pp);
+ GDS_NEIGHBOURS_handle_reply (peer->id,
+ type,
+ expiration_time,
+ key,
+ put_path_length, put_path,
+ get_path_length, get_path,
+ data, data_size);
}
const char *xquery;
int forwarded;
- if (NULL == peer)
- {
- GNUNET_break (0);
- return;
- }
/* parse and validate message */
msize = ntohs (get->header.size);
xquery_size = ntohl (get->xquery_size);
"filter-size",
reply_bf_size,
NULL);
- /* remember request for routing replies */
- GDS_ROUTING_add (peer->id,
- type,
- bg, /* bg now owned by routing, but valid at least until end of this function! */
- options,
- &get->key,
- xquery,
- xquery_size);
GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
"GET for %s at %s after %u hops\n",
GNUNET_h2s (&get->key),
xquery_size,
bg,
&handle_local_result,
- NULL);
+ peer);
}
}
else
GNUNET_NO);
}
+ /* remember request for routing replies */
+ GDS_ROUTING_add (peer->id,
+ type,
+ bg, /* bg now owned by routing, but valid at least until end of this function! */
+ options,
+ &get->key,
+ xquery,
+ xquery_size);
+
/* P2P forwarding */
forwarded = GNUNET_NO;
if (eval != GNUNET_BLOCK_EVALUATION_OK_LAST)
}
+/**
+ * Process a reply, after the @a get_path has been updated.
+ *
+ * @param expiration_time when does the reply expire
+ * @param key key matching the query
+ * @param get_path_length number of entries in @a get_path
+ * @param get_path path the reply has taken
+ * @param put_path_length number of entries in @a put_path
+ * @param put_path path the PUT has taken
+ * @param type type of the block
+ * @param data_size number of bytes in @a data
+ * @param data payload of the reply
+ */
+static void
+process_reply_with_path (struct GNUNET_TIME_Absolute expiration_time,
+ const struct GNUNET_HashCode *key,
+ unsigned int get_path_length,
+ const struct GNUNET_PeerIdentity *get_path,
+ unsigned int put_path_length,
+ const struct GNUNET_PeerIdentity *put_path,
+ enum GNUNET_BLOCK_Type type,
+ size_t data_size,
+ const void *data)
+{
+ /* forward to local clients */
+ GDS_CLIENTS_handle_reply (expiration_time,
+ key,
+ get_path_length,
+ get_path,
+ put_path_length,
+ put_path,
+ type,
+ data_size,
+ data);
+ GDS_CLIENTS_process_get_resp (type,
+ get_path,
+ get_path_length,
+ put_path,
+ put_path_length,
+ expiration_time,
+ key,
+ data,
+ data_size);
+ if (GNUNET_YES == cache_results)
+ {
+ struct GNUNET_PeerIdentity xput_path[get_path_length + 1 + put_path_length];
+
+ GNUNET_memcpy (xput_path,
+ put_path,
+ put_path_length * sizeof (struct GNUNET_PeerIdentity));
+ GNUNET_memcpy (&xput_path[put_path_length],
+ get_path,
+ get_path_length * sizeof (struct GNUNET_PeerIdentity));
+
+ GDS_DATACACHE_handle_put (expiration_time,
+ key,
+ get_path_length + put_path_length,
+ xput_path,
+ type,
+ data_size,
+ data);
+ }
+ /* forward to other peers */
+ GDS_ROUTING_process (type,
+ expiration_time,
+ key,
+ put_path_length,
+ put_path,
+ get_path_length,
+ get_path,
+ data,
+ data_size);
+}
+
+
/**
* Core handler for p2p result messages.
*
if (GNUNET_YES == log_route_details_stderr)
{
char *tmp;
+ char *pp;
+ char *gp;
+ gp = GNUNET_STRINGS_pp2s (get_path,
+ get_path_length);
+ pp = GNUNET_STRINGS_pp2s (put_path,
+ put_path_length);
tmp = GNUNET_strdup (GNUNET_i2s (&my_identity));
LOG_TRAFFIC (GNUNET_ERROR_TYPE_DEBUG,
- "R5N RESULT %s: %s->%s (%u)\n",
+ "R5N RESULT %s: %s->%s (GP: %s, PP: %s)\n",
GNUNET_h2s (&prm->key),
GNUNET_i2s (peer->id),
tmp,
- get_path_length + 1);
+ gp,
+ pp);
+ GNUNET_free (gp);
+ GNUNET_free (pp);
GNUNET_free (tmp);
}
/* if we got a HELLO, consider it for our own routing table */
h);
}
- /* append 'peer' to 'get_path' */
- {
- struct GNUNET_PeerIdentity xget_path[get_path_length + 1];
-#if SANITY_CHECKS
- for (unsigned int i=0;i<=get_path_length;i++)
+ /* First, check if 'peer' is already on the path, and if
+ so, truncate it instead of expanding. */
+ for (unsigned int i=0;i<=get_path_length;i++)
+ if (0 == memcmp (&get_path[i],
+ peer->id,
+ sizeof (struct GNUNET_PeerIdentity)))
{
- for (unsigned int j=0;j<i;j++)
- {
- GNUNET_break (0 != memcmp (&get_path[i],
- &get_path[j],
- sizeof (struct GNUNET_PeerIdentity)));
- }
- GNUNET_break (0 != memcmp (&get_path[i],
- peer->id,
- sizeof (struct GNUNET_PeerIdentity)));
+ process_reply_with_path (GNUNET_TIME_absolute_ntoh (prm->expiration_time),
+ &prm->key,
+ i,
+ get_path,
+ put_path_length,
+ put_path,
+ type,
+ data_size,
+ data);
+ return;
}
-#endif
+
+ /* Need to append 'peer' to 'get_path' (normal case) */
+ {
+ struct GNUNET_PeerIdentity xget_path[get_path_length + 1];
+
GNUNET_memcpy (xget_path,
get_path,
get_path_length * sizeof (struct GNUNET_PeerIdentity));
xget_path[get_path_length] = *peer->id;
- get_path_length++;
-
- /* forward to local clients */
- GDS_CLIENTS_handle_reply (GNUNET_TIME_absolute_ntoh (prm->expiration_time),
- &prm->key,
- get_path_length,
- xget_path,
- put_path_length,
- put_path,
- type,
- data_size,
- data);
- GDS_CLIENTS_process_get_resp (type,
- xget_path,
- get_path_length,
- put_path, put_path_length,
- GNUNET_TIME_absolute_ntoh (prm->expiration_time),
- &prm->key,
- data,
- data_size);
- if (GNUNET_YES == cache_results)
- {
- struct GNUNET_PeerIdentity xput_path[get_path_length + 1 + put_path_length];
- GNUNET_memcpy (xput_path,
- put_path,
- put_path_length * sizeof (struct GNUNET_PeerIdentity));
- GNUNET_memcpy (&xput_path[put_path_length],
- xget_path,
- get_path_length * sizeof (struct GNUNET_PeerIdentity));
-
- GDS_DATACACHE_handle_put (GNUNET_TIME_absolute_ntoh (prm->expiration_time),
- &prm->key,
- get_path_length + put_path_length,
- xput_path,
- type,
- data_size,
- data);
- }
- /* forward to other peers */
- GDS_ROUTING_process (NULL,
- type,
- GNUNET_TIME_absolute_ntoh (prm->expiration_time),
- &prm->key,
- put_path_length,
- put_path,
- get_path_length,
- xget_path,
- data,
- data_size);
+ process_reply_with_path (GNUNET_TIME_absolute_ntoh (prm->expiration_time),
+ &prm->key,
+ get_path_length + 1,
+ xget_path,
+ put_path_length,
+ put_path,
+ type,
+ data_size,
+ data);
}
}
projects / oweals / gnunet.git / blobdiff