abort on error -- missing return
[oweals/gnunet.git] / src / dht / dht_api.c
index eded50efcde080001fc6fb5d76faf30f86220e5d..a50d2a2287974eef7c8e492c87903cd8a4a614f2 100644 (file)
  */
 
 #include "platform.h"
-#include "gnunet_bandwidth_lib.h"
-#include "gnunet_client_lib.h"
+#include "gnunet_util_lib.h"
 #include "gnunet_constants.h"
-#include "gnunet_container_lib.h"
 #include "gnunet_arm_service.h"
 #include "gnunet_hello_lib.h"
 #include "gnunet_protocols.h"
-#include "gnunet_server_lib.h"
-#include "gnunet_time_lib.h"
 #include "gnunet_dht_service.h"
 #include "dht.h"
 
-#define DEBUG_DHT_API GNUNET_NO
+#define DEBUG_DHT_API GNUNET_EXTRA_LOGGING
+
+#define LOG(kind,...) GNUNET_log_from (kind, "dht-api",__VA_ARGS__)
 
 /**
  * Entry in our list of messages to be (re-)transmitted.
@@ -104,15 +102,15 @@ struct PendingMessage
 
 
 /**
- * Handle to a route request
+ * Handle to a GET request
  */
-struct GNUNET_DHT_RouteHandle
+struct GNUNET_DHT_GetHandle
 {
 
   /**
    * Iterator to call on data receipt
    */
-  GNUNET_DHT_ReplyProcessor iter;
+  GNUNET_DHT_GetIterator iter;
 
   /**
    * Closure for the iterator callback
@@ -137,9 +135,9 @@ struct GNUNET_DHT_RouteHandle
   GNUNET_HashCode key;
 
   /**
-   * Unique identifier for this request (for key collisions). FIXME: redundant!?
+   * Unique identifier for this request (for key collisions).
    */
-  uint64_t uid;
+  uint64_t unique_id;
 
 };
 
@@ -200,21 +198,13 @@ struct GNUNET_DHT_Handle
 };
 
 
-/**
- * Transmit the next pending message, called by notify_transmit_ready
- */
-static size_t transmit_pending (void *cls, size_t size, void *buf);
-
-
 /**
  * Handler for messages received from the DHT service
  * a demultiplexer which handles numerous message types
  *
  */
-static void service_message_handler (void *cls,
-                                     const struct GNUNET_MessageHeader *msg);
-
-
+static void
+service_message_handler (void *cls, const struct GNUNET_MessageHeader *msg);
 
 
 /**
@@ -230,13 +220,12 @@ try_connect (struct GNUNET_DHT_Handle *handle)
   handle->client = GNUNET_CLIENT_connect ("dht", handle->cfg);
   if (handle->client == NULL)
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
-                _("Failed to connect to the DHT service!\n"));
+    LOG (GNUNET_ERROR_TYPE_WARNING,
+         _("Failed to connect to the DHT service!\n"));
     return GNUNET_NO;
   }
 #if DEBUG_DHT
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Starting to process replies from DHT\n");
+  LOG (GNUNET_ERROR_TYPE_DEBUG, "Starting to process replies from DHT\n");
 #endif
   GNUNET_CLIENT_receive (handle->client, &service_message_handler, handle,
                          GNUNET_TIME_UNIT_FOREVER_REL);
@@ -250,14 +239,14 @@ try_connect (struct GNUNET_DHT_Handle *handle)
  *
  * @param cls the 'struct GNUNET_DHT_Handle*'
  * @param key key for the request (not used)
- * @param value the 'struct GNUNET_DHT_RouteHandle*'
+ * @param value the 'struct GNUNET_DHT_GetHandle*'
  * @return GNUNET_YES (always)
  */
 static int
 add_request_to_pending (void *cls, const GNUNET_HashCode * key, void *value)
 {
   struct GNUNET_DHT_Handle *handle = cls;
-  struct GNUNET_DHT_RouteHandle *rh = value;
+  struct GNUNET_DHT_GetHandle *rh = value;
 
   if (GNUNET_NO == rh->message->in_pending_queue)
   {
@@ -273,7 +262,8 @@ add_request_to_pending (void *cls, const GNUNET_HashCode * key, void *value)
  * Try to send messages from list of messages to send
  * @param handle DHT_Handle
  */
-static void process_pending_messages (struct GNUNET_DHT_Handle *handle);
+static void
+process_pending_messages (struct GNUNET_DHT_Handle *handle);
 
 
 /**
@@ -298,7 +288,7 @@ try_reconnect (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   handle->client = GNUNET_CLIENT_connect ("dht", handle->cfg);
   if (handle->client == NULL)
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "dht reconnect failed(!)\n");
+    LOG (GNUNET_ERROR_TYPE_DEBUG, "dht reconnect failed(!)\n");
     return;
   }
   GNUNET_CONTAINER_multihashmap_iterate (handle->active_requests,
@@ -318,6 +308,9 @@ do_disconnect (struct GNUNET_DHT_Handle *handle)
   if (handle->client == NULL)
     return;
   GNUNET_assert (handle->reconnect_task == GNUNET_SCHEDULER_NO_TASK);
+  if (NULL != handle->th)
+    GNUNET_CLIENT_notify_transmit_ready_cancel (handle->th);
+  handle->th = NULL;
   GNUNET_CLIENT_disconnect (handle->client, GNUNET_NO);
   handle->client = NULL;
   handle->reconnect_task =
@@ -325,6 +318,13 @@ do_disconnect (struct GNUNET_DHT_Handle *handle)
 }
 
 
+/**
+ * Transmit the next pending message, called by notify_transmit_ready
+ */
+static size_t
+transmit_pending (void *cls, size_t size, void *buf);
+
+
 /**
  * Try to send messages from list of messages to send
  */
@@ -348,11 +348,9 @@ process_pending_messages (struct GNUNET_DHT_Handle *handle)
                                            GNUNET_TIME_UNIT_FOREVER_REL,
                                            GNUNET_YES, &transmit_pending,
                                            handle);
-  if (NULL == handle->th)
-  {
-    do_disconnect (handle);
+  if (NULL != handle->th)
     return;
-  }
+  do_disconnect (handle);
 }
 
 
@@ -369,8 +367,8 @@ transmit_pending (void *cls, size_t size, void *buf)
   handle->th = NULL;
   if (buf == NULL)
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Transmission to DHT service failed!  Reconnecting!\n");
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "Transmission to DHT service failed!  Reconnecting!\n");
     do_disconnect (handle);
     return 0;
   }
@@ -402,9 +400,10 @@ transmit_pending (void *cls, size_t size, void *buf)
   if (GNUNET_YES == head->free_on_send)
     GNUNET_free (head);
   process_pending_messages (handle);
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Forwarded request of %u bytes to DHT service\n",
-              (unsigned int) tsize);
+#if DEBUG_DHT
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Forwarded request of %u bytes to DHT service\n", (unsigned int) tsize);
+#endif
   return tsize;
 }
 
@@ -412,64 +411,57 @@ transmit_pending (void *cls, size_t size, void *buf)
 /**
  * Process a given reply that might match the given
  * request.
+ *
+ * @param cls the 'struct GNUNET_DHT_ClientResultMessage'
+ * @param key query of the request
+ * @param value the 'struct GNUNET_DHT_RouteHandle' of a request matching the same key
+ * @return GNUNET_YES to continue to iterate over all results,
+ *         GNUNET_NO if the reply is malformed
  */
 static int
 process_reply (void *cls, const GNUNET_HashCode * key, void *value)
 {
-  const struct GNUNET_DHT_RouteResultMessage *dht_msg = cls;
-  struct GNUNET_DHT_RouteHandle *rh = value;
-  const struct GNUNET_MessageHeader *enc_msg;
-  size_t enc_size;
-  uint64_t uid;
-  const struct GNUNET_PeerIdentity **outgoing_path;
-  const struct GNUNET_PeerIdentity *pos;
-  uint32_t outgoing_path_length;
-  unsigned int i;
-  char *path_offset;
-
-  uid = GNUNET_ntohll (dht_msg->unique_id);
-  if (uid != rh->uid)
+  const struct GNUNET_DHT_ClientResultMessage *dht_msg = cls;
+  struct GNUNET_DHT_GetHandle *get_handle = value;
+  const struct GNUNET_PeerIdentity *put_path;
+  const struct GNUNET_PeerIdentity *get_path;
+  uint32_t put_path_length;
+  uint32_t get_path_length;
+  size_t data_length;
+  size_t msize;
+  size_t meta_length;
+  const void *data;
+
+  if (dht_msg->unique_id != get_handle->unique_id)
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Reply UID did not match request UID\n");
+    /* UID mismatch */
+    LOG (GNUNET_ERROR_TYPE_DEBUG, "Ignoring reply (UID mismatch: %llu/%llu)\n",
+         dht_msg->unique_id, get_handle->unique_id);
     return GNUNET_YES;
   }
-  enc_msg = (const struct GNUNET_MessageHeader *) &dht_msg[1];
-  enc_size = ntohs (enc_msg->size);
-  if (enc_size < sizeof (struct GNUNET_MessageHeader))
-  {
-    GNUNET_break (0);
-    return GNUNET_NO;
-  }
-  path_offset = (char *) &dht_msg[1];
-  path_offset += enc_size;
-  pos = (const struct GNUNET_PeerIdentity *) path_offset;
-  outgoing_path_length = ntohl (dht_msg->outgoing_path_length);
-  if (outgoing_path_length * sizeof (struct GNUNET_PeerIdentity) >
-      ntohs (dht_msg->header.size) - enc_size)
+  msize = ntohs (dht_msg->header.size);
+  put_path_length = ntohl (dht_msg->put_path_length);
+  get_path_length = ntohl (dht_msg->get_path_length);
+  meta_length =
+      sizeof (struct GNUNET_DHT_ClientResultMessage) +
+      sizeof (struct GNUNET_PeerIdentity) * (get_path_length + put_path_length);
+  if ((msize < meta_length) ||
+      (get_path_length >
+       GNUNET_SERVER_MAX_MESSAGE_SIZE / sizeof (struct GNUNET_PeerIdentity)) ||
+      (put_path_length >
+       GNUNET_SERVER_MAX_MESSAGE_SIZE / sizeof (struct GNUNET_PeerIdentity)))
   {
     GNUNET_break (0);
     return GNUNET_NO;
   }
-
-  if (outgoing_path_length > 0)
-  {
-    outgoing_path =
-        GNUNET_malloc ((outgoing_path_length +
-                        1) * sizeof (struct GNUNET_PeerIdentity *));
-    for (i = 0; i < outgoing_path_length; i++)
-    {
-      outgoing_path[i] = pos;
-      pos++;
-    }
-    outgoing_path[outgoing_path_length] = NULL;
-  }
-  else
-    outgoing_path = NULL;
-
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Processing reply.\n");
-  rh->iter (rh->iter_cls, &rh->key, outgoing_path, enc_msg);
-  GNUNET_free_non_null (outgoing_path);
+  data_length = msize - meta_length;
+  put_path = (const struct GNUNET_PeerIdentity *) &dht_msg[1];
+  get_path = &put_path[put_path_length];
+  data = &get_path[get_path_length];
+  get_handle->iter (get_handle->iter_cls,
+                    GNUNET_TIME_absolute_ntoh (dht_msg->expiration), key,
+                    get_path, get_path_length, put_path, put_path_length,
+                    ntohl (dht_msg->type), data_length, data);
   return GNUNET_YES;
 }
 
@@ -485,40 +477,34 @@ static void
 service_message_handler (void *cls, const struct GNUNET_MessageHeader *msg)
 {
   struct GNUNET_DHT_Handle *handle = cls;
-  const struct GNUNET_DHT_RouteResultMessage *dht_msg;
+  const struct GNUNET_DHT_ClientResultMessage *dht_msg;
 
   if (msg == NULL)
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Error receiving data from DHT service, reconnecting\n");
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "Error receiving data from DHT service, reconnecting\n");
     do_disconnect (handle);
     return;
   }
-  if (ntohs (msg->type) != GNUNET_MESSAGE_TYPE_DHT_LOCAL_ROUTE_RESULT)
+  if (ntohs (msg->type) != GNUNET_MESSAGE_TYPE_DHT_CLIENT_RESULT)
   {
     GNUNET_break (0);
     do_disconnect (handle);
     return;
   }
-  if (ntohs (msg->size) < sizeof (struct GNUNET_DHT_RouteResultMessage))
+  if (ntohs (msg->size) < sizeof (struct GNUNET_DHT_ClientResultMessage))
   {
     GNUNET_break (0);
     do_disconnect (handle);
     return;
   }
-  dht_msg = (const struct GNUNET_DHT_RouteResultMessage *) msg;
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Comparing reply `%s' against %u pending requests.\n",
-              GNUNET_h2s (&dht_msg->key),
-              GNUNET_CONTAINER_multihashmap_size (handle->active_requests));
+  LOG (GNUNET_ERROR_TYPE_DEBUG, "Received reply from DHT service\n");
+  dht_msg = (const struct GNUNET_DHT_ClientResultMessage *) msg;
   GNUNET_CONTAINER_multihashmap_get_multiple (handle->active_requests,
                                               &dht_msg->key, &process_reply,
                                               (void *) dht_msg);
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Continuing to process replies from DHT\n");
   GNUNET_CLIENT_receive (handle->client, &service_message_handler, handle,
                          GNUNET_TIME_UNIT_FOREVER_REL);
-
 }
 
 
@@ -594,11 +580,6 @@ GNUNET_DHT_disconnect (struct GNUNET_DHT_Handle *handle)
 }
 
 
-
-
-/* ***** Special low-level API providing generic routing abstraction ***** */
-
-
 /**
  * Timeout for the transmission of a fire&forget-request.  Clean it up.
  *
@@ -606,17 +587,11 @@ GNUNET_DHT_disconnect (struct GNUNET_DHT_Handle *handle)
  * @param tc scheduler context
  */
 static void
-timeout_route_request (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+timeout_put_request (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   struct PendingMessage *pending = cls;
   struct GNUNET_DHT_Handle *handle;
 
-  if (pending->free_on_send != GNUNET_YES)
-  {
-    /* timeouts should only apply to fire & forget requests! */
-    GNUNET_break (0);
-    return;
-  }
   handle = pending->handle;
   GNUNET_CONTAINER_DLL_remove (handle->pending_head, handle->pending_tail,
                                pending);
@@ -627,278 +602,185 @@ timeout_route_request (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 
 
 /**
- * Initiate a generic DHT route operation.
+ * Perform a PUT operation storing data in the DHT.
  *
- * @param handle handle to the DHT service
- * @param key the key to look up
- * @param desired_replication_level how many peers should ultimately receive
- *                this message (advisory only, target may be too high for the
- *                given DHT or not hit exactly).
- * @param options options for routing
- * @param enc send the encapsulated message to a peer close to the key
- * @param iter function to call on each result, NULL if no replies are expected
- * @param iter_cls closure for iter
- * @param timeout when to abort with an error if we fail to get
- *                a confirmation for the request (when necessary) or how long
- *                to wait for tramission to the service; only applies
- *                if 'iter' is NULL
- * @param cont continuation to call when the request has been transmitted
- *             the first time to the service
+ * @param handle handle to DHT service
+ * @param key the key to store under
+ * @param desired_replication_level estimate of how many
+ *                nearest peers this request should reach
+ * @param options routing options for this message
+ * @param type type of the value
+ * @param size number of bytes in data; must be less than 64k
+ * @param data the data to store
+ * @param exp desired expiration time for the value
+ * @param timeout how long to wait for transmission of this request
+ * @param cont continuation to call when done (transmitting request to service)
  * @param cont_cls closure for cont
- * @return handle to stop the request, NULL if the request is "fire and forget"
  */
-struct GNUNET_DHT_RouteHandle *
-GNUNET_DHT_route_start (struct GNUNET_DHT_Handle *handle,
-                        const GNUNET_HashCode * key,
-                        uint32_t desired_replication_level,
-                        enum GNUNET_DHT_RouteOption options,
-                        const struct GNUNET_MessageHeader *enc,
-                        struct GNUNET_TIME_Relative timeout,
-                        GNUNET_DHT_ReplyProcessor iter, void *iter_cls,
-                        GNUNET_SCHEDULER_Task cont, void *cont_cls)
+void
+GNUNET_DHT_put (struct GNUNET_DHT_Handle *handle, const GNUNET_HashCode * key,
+                uint32_t desired_replication_level,
+                enum GNUNET_DHT_RouteOption options,
+                enum GNUNET_BLOCK_Type type, size_t size, const char *data,
+                struct GNUNET_TIME_Absolute exp,
+                struct GNUNET_TIME_Relative timeout, GNUNET_SCHEDULER_Task cont,
+                void *cont_cls)
 {
+  struct GNUNET_DHT_ClientPutMessage *put_msg;
+  size_t msize;
   struct PendingMessage *pending;
-  struct GNUNET_DHT_RouteMessage *message;
-  struct GNUNET_DHT_RouteHandle *route_handle;
-  uint16_t msize;
-  uint16_t esize;
-
-  esize = ntohs (enc->size);
-  if (sizeof (struct GNUNET_DHT_RouteMessage) + esize >=
-      GNUNET_SERVER_MAX_MESSAGE_SIZE)
+
+  msize = sizeof (struct GNUNET_DHT_ClientPutMessage) + size;
+  if ((msize >= GNUNET_SERVER_MAX_MESSAGE_SIZE) ||
+      (size >= GNUNET_SERVER_MAX_MESSAGE_SIZE))
   {
     GNUNET_break (0);
-    return NULL;
+    if (NULL != cont)
+      cont (cont_cls, NULL);
+    return;
   }
-  msize = sizeof (struct GNUNET_DHT_RouteMessage) + esize;
   pending = GNUNET_malloc (sizeof (struct PendingMessage) + msize);
-  message = (struct GNUNET_DHT_RouteMessage *) &pending[1];
-  pending->msg = &message->header;
+  put_msg = (struct GNUNET_DHT_ClientPutMessage *) &pending[1];
+  pending->msg = &put_msg->header;
   pending->handle = handle;
   pending->cont = cont;
   pending->cont_cls = cont_cls;
-
-  message->header.size = htons (msize);
-  message->header.type = htons (GNUNET_MESSAGE_TYPE_DHT_LOCAL_ROUTE);
-  message->options = htonl ((uint32_t) options);
-  message->desired_replication_level = htonl (desired_replication_level);
-  message->reserved = 0;
-  message->key = *key;
-  handle->uid_gen++;
-  message->unique_id = GNUNET_htonll (handle->uid_gen);
-  memcpy (&message[1], enc, esize);
-
-  if (iter != NULL)
-  {
-    route_handle = GNUNET_malloc (sizeof (struct GNUNET_DHT_RouteHandle));
-    route_handle->key = *key;
-    route_handle->iter = iter;
-    route_handle->iter_cls = iter_cls;
-    route_handle->dht_handle = handle;
-    route_handle->uid = handle->uid_gen;
-    route_handle->message = pending;
-    GNUNET_CONTAINER_multihashmap_put (handle->active_requests, key,
-                                       route_handle,
-                                       GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
-  }
-  else
-  {
-    route_handle = NULL;
-    pending->free_on_send = GNUNET_YES;
-    pending->timeout_task =
-        GNUNET_SCHEDULER_add_delayed (timeout, &timeout_route_request, pending);
-  }
+  pending->free_on_send = GNUNET_YES;
+  pending->timeout_task =
+      GNUNET_SCHEDULER_add_delayed (timeout, &timeout_put_request, pending);
+  put_msg->header.size = htons (msize);
+  put_msg->header.type = htons (GNUNET_MESSAGE_TYPE_DHT_CLIENT_PUT);
+  put_msg->type = htonl (type);
+  put_msg->options = htonl ((uint32_t) options);
+  put_msg->desired_replication_level = htonl (desired_replication_level);
+  put_msg->expiration = GNUNET_TIME_absolute_hton (exp);
+  put_msg->key = *key;
+  memcpy (&put_msg[1], data, size);
   GNUNET_CONTAINER_DLL_insert (handle->pending_head, handle->pending_tail,
                                pending);
   pending->in_pending_queue = GNUNET_YES;
   process_pending_messages (handle);
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "DHT route start request processed, returning %p\n",
-              route_handle);
-  return route_handle;
 }
 
 
 /**
- * Stop a previously issued routing request
+ * Perform an asynchronous GET operation on the DHT identified. See
+ * also "GNUNET_BLOCK_evaluate".
  *
- * @param route_handle handle to the request to stop
+ * @param handle handle to the DHT service
+ * @param timeout how long to wait for transmission of this request to the service
+ * @param type expected type of the response object
+ * @param key the key to look up
+ * @param desired_replication_level estimate of how many
+                  nearest peers this request should reach
+ * @param options routing options for this message
+ * @param xquery extended query data (can be NULL, depending on type)
+ * @param xquery_size number of bytes in xquery
+ * @param iter function to call on each result
+ * @param iter_cls closure for iter
+ * @return handle to stop the async get
  */
-void
-GNUNET_DHT_route_stop (struct GNUNET_DHT_RouteHandle *route_handle)
+struct GNUNET_DHT_GetHandle *
+GNUNET_DHT_get_start (struct GNUNET_DHT_Handle *handle,
+                      struct GNUNET_TIME_Relative timeout,
+                      enum GNUNET_BLOCK_Type type, const GNUNET_HashCode * key,
+                      uint32_t desired_replication_level,
+                      enum GNUNET_DHT_RouteOption options, const void *xquery,
+                      size_t xquery_size, GNUNET_DHT_GetIterator iter,
+                      void *iter_cls)
 {
-  struct GNUNET_DHT_Handle *handle;
-  struct PendingMessage *pending;
-  struct GNUNET_DHT_StopMessage *message;
+  struct GNUNET_DHT_ClientGetMessage *get_msg;
+  struct GNUNET_DHT_GetHandle *get_handle;
   size_t msize;
+  struct PendingMessage *pending;
 
-  handle = route_handle->dht_handle;
-  if (GNUNET_NO == route_handle->message->in_pending_queue)
+  msize = sizeof (struct GNUNET_DHT_ClientGetMessage) + xquery_size;
+  if ((msize >= GNUNET_SERVER_MAX_MESSAGE_SIZE) ||
+      (xquery_size >= GNUNET_SERVER_MAX_MESSAGE_SIZE))
   {
-    /* need to send stop message */
-    msize = sizeof (struct GNUNET_DHT_StopMessage);
-    pending = GNUNET_malloc (sizeof (struct PendingMessage) + msize);
-    message = (struct GNUNET_DHT_StopMessage *) &pending[1];
-    pending->msg = &message->header;
-    message->header.size = htons (msize);
-    message->header.type = htons (GNUNET_MESSAGE_TYPE_DHT_LOCAL_ROUTE_STOP);
-    message->reserved = 0;
-    message->unique_id = GNUNET_htonll (route_handle->uid);
-    message->key = route_handle->key;
-    pending->handle = handle;
-    pending->free_on_send = GNUNET_YES;
-    pending->in_pending_queue = GNUNET_YES;
-    GNUNET_CONTAINER_DLL_insert (handle->pending_head, handle->pending_tail,
-                                 pending);
-    process_pending_messages (handle);
-  }
-  else
-  {
-    /* simply remove pending request from message queue before
-     * transmission, no need to transmit STOP request! */
-    GNUNET_CONTAINER_DLL_remove (handle->pending_head, handle->pending_tail,
-                                 route_handle->message);
+    GNUNET_break (0);
+    return NULL;
   }
-  GNUNET_assert (GNUNET_YES ==
-                 GNUNET_CONTAINER_multihashmap_remove (route_handle->
-                                                       dht_handle->
-                                                       active_requests,
-                                                       &route_handle->key,
-                                                       route_handle));
-  GNUNET_free (route_handle->message);
-  GNUNET_free (route_handle);
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "DHT route stop request processed\n");
+  pending = GNUNET_malloc (sizeof (struct PendingMessage) + msize);
+  get_msg = (struct GNUNET_DHT_ClientGetMessage *) &pending[1];
+  pending->msg = &get_msg->header;
+  pending->handle = handle;
+  pending->free_on_send = GNUNET_NO;
+  get_msg->header.size = htons (msize);
+  get_msg->header.type = htons (GNUNET_MESSAGE_TYPE_DHT_CLIENT_GET);
+  get_msg->options = htonl ((uint32_t) options);
+  get_msg->desired_replication_level = htonl (desired_replication_level);
+  get_msg->type = htonl (type);
+  get_msg->key = *key;
+  handle->uid_gen++;
+  get_msg->unique_id = handle->uid_gen;
+  memcpy (&get_msg[1], xquery, xquery_size);
+  GNUNET_CONTAINER_DLL_insert (handle->pending_head, handle->pending_tail,
+                               pending);
+  pending->in_pending_queue = GNUNET_YES;
+  get_handle = GNUNET_malloc (sizeof (struct GNUNET_DHT_GetHandle));
+  get_handle->iter = iter;
+  get_handle->iter_cls = iter_cls;
+  get_handle->message = pending;
+  get_handle->unique_id = get_msg->unique_id;
+  GNUNET_CONTAINER_multihashmap_put (handle->active_requests, key, get_handle,
+                                     GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
+  process_pending_messages (handle);
+  return get_handle;
 }
 
 
-
-/* ***** Special API for controlling DHT routing maintenance ******* */
-
-
 /**
- * Send a control message to the DHT.
+ * Stop async DHT-get.
  *
- * @param handle handle to the DHT service
- * @param command command
- * @param variable variable to the command
- * @param cont continuation to call when done (transmitting request to service)
- * @param cont_cls closure for cont
+ * @param get_handle handle to the GET operation to stop
  */
-static void
-send_control_message (struct GNUNET_DHT_Handle *handle, uint16_t command,
-                      uint16_t variable, GNUNET_SCHEDULER_Task cont,
-                      void *cont_cls)
+void
+GNUNET_DHT_get_stop (struct GNUNET_DHT_GetHandle *get_handle)
 {
-  struct GNUNET_DHT_ControlMessage *msg;
+  struct GNUNET_DHT_Handle *handle;
+  const struct GNUNET_DHT_ClientGetMessage *get_msg;
+  struct GNUNET_DHT_ClientGetStopMessage *stop_msg;
   struct PendingMessage *pending;
 
+  handle = get_handle->message->handle;
+  get_msg =
+      (const struct GNUNET_DHT_ClientGetMessage *) get_handle->message->msg;
+
+  /* generate STOP */
   pending =
       GNUNET_malloc (sizeof (struct PendingMessage) +
-                     sizeof (struct GNUNET_DHT_ControlMessage));
-  msg = (struct GNUNET_DHT_ControlMessage *) &pending[1];
-  pending->msg = &msg->header;
-  msg->header.size = htons (sizeof (struct GNUNET_DHT_ControlMessage));
-  msg->header.type = htons (GNUNET_MESSAGE_TYPE_DHT_CONTROL);
-  msg->command = htons (command);
-  msg->variable = htons (variable);
+                     sizeof (struct GNUNET_DHT_ClientGetStopMessage));
+  stop_msg = (struct GNUNET_DHT_ClientGetStopMessage *) &pending[1];
+  pending->msg = &stop_msg->header;
+  pending->handle = handle;
   pending->free_on_send = GNUNET_YES;
-  pending->cont = cont;
-  pending->cont_cls = cont_cls;
-  pending->in_pending_queue = GNUNET_YES;
+  stop_msg->header.size =
+      htons (sizeof (struct GNUNET_DHT_ClientGetStopMessage));
+  stop_msg->header.type = htons (GNUNET_MESSAGE_TYPE_DHT_CLIENT_GET_STOP);
+  stop_msg->reserved = htonl (0);
+  stop_msg->unique_id = get_msg->unique_id;
+  stop_msg->key = get_msg->key;
   GNUNET_CONTAINER_DLL_insert (handle->pending_head, handle->pending_tail,
                                pending);
-  process_pending_messages (handle);
-}
-
-
-/**
- * Send a message to the DHT telling it to issue a single find
- * peer request using the peers unique identifier as key.  This
- * is used to fill the routing table, and is normally controlled
- * by the DHT itself.  However, for testing and perhaps more
- * close control over the DHT, this can be explicitly managed.
- *
- * @param handle handle to the DHT service
- * @param cont continuation to call when done (transmitting request to service)
- * @param cont_cls closure for cont
- */
-void
-GNUNET_DHT_find_peers (struct GNUNET_DHT_Handle *handle,
-                       GNUNET_SCHEDULER_Task cont, void *cont_cls)
-{
-  send_control_message (handle, GNUNET_MESSAGE_TYPE_DHT_FIND_PEER, 0, cont,
-                        cont_cls);
-}
-
-
-
-#if HAVE_MALICIOUS
-
-/**
- * Send a message to the DHT telling it to start issuing random GET
- * requests every 'frequency' milliseconds.
- *
- * @param handle handle to the DHT service
- * @param frequency delay between sending malicious messages
- * @param cont continuation to call when done (transmitting request to service)
- * @param cont_cls closure for cont
- */
-void
-GNUNET_DHT_set_malicious_getter (struct GNUNET_DHT_Handle *handle,
-                                 struct GNUNET_TIME_Relative frequency,
-                                 GNUNET_SCHEDULER_Task cont, void *cont_cls)
-{
-  if (frequency.rel_value > UINT16_MAX)
-  {
-    GNUNET_break (0);
-    return;
-  }
-  send_control_message (handle, GNUNET_MESSAGE_TYPE_DHT_MALICIOUS_GET,
-                        frequency.rel_value, cont, cont_cls);
-}
+  pending->in_pending_queue = GNUNET_YES;
 
-/**
- * Send a message to the DHT telling it to start issuing random PUT
- * requests every 'frequency' milliseconds.
- *
- * @param handle handle to the DHT service
- * @param frequency delay between sending malicious messages
- * @param cont continuation to call when done (transmitting request to service)
- * @param cont_cls closure for cont
- */
-void
-GNUNET_DHT_set_malicious_putter (struct GNUNET_DHT_Handle *handle,
-                                 struct GNUNET_TIME_Relative frequency,
-                                 GNUNET_SCHEDULER_Task cont, void *cont_cls)
-{
-  if (frequency.rel_value > UINT16_MAX)
+  /* remove 'GET' from active status */
+  GNUNET_assert (GNUNET_YES ==
+                 GNUNET_CONTAINER_multihashmap_remove (handle->active_requests,
+                                                       &get_msg->key,
+                                                       get_handle));
+  if (GNUNET_YES == get_handle->message->in_pending_queue)
   {
-    GNUNET_break (0);
-    return;
+    GNUNET_CONTAINER_DLL_remove (handle->pending_head, handle->pending_tail,
+                                 get_handle->message);
+    get_handle->message->in_pending_queue = GNUNET_NO;
   }
+  GNUNET_free (get_handle->message);
+  GNUNET_free (get_handle);
 
-  send_control_message (handle, GNUNET_MESSAGE_TYPE_DHT_MALICIOUS_PUT,
-                        frequency.rel_value, cont, cont_cls);
-}
-
-
-/**
- * Send a message to the DHT telling it to start dropping
- * all requests received.
- *
- * @param handle handle to the DHT service
- * @param cont continuation to call when done (transmitting request to service)
- * @param cont_cls closure for cont
- *
- */
-void
-GNUNET_DHT_set_malicious_dropper (struct GNUNET_DHT_Handle *handle,
-                                  GNUNET_SCHEDULER_Task cont, void *cont_cls)
-{
-  send_control_message (handle, GNUNET_MESSAGE_TYPE_DHT_MALICIOUS_DROP, 0, cont,
-                        cont_cls);
+  process_pending_messages (handle);
 }
 
-#endif
 
 /* end of dht_api.c */