use big endian
[oweals/gnunet.git] / src / datastore / plugin_datastore_mysql.c
index 234e2fd93402f9d8e5dd0594304dbb355ddf1ec6..c216e989c9e5523e4d49d4e4ab15970f056b6713 100644 (file)
@@ -49,9 +49,8 @@
  *
  * 1) in /etc/gnunet.conf, set
  *    <pre>
- *
- *     sqstore = "sqstore_mysql"
- *
+ *     [datastore]
+ *     DATABASE = "mysql"
  *    </pre>
  * 2) Then access mysql as root,
  *    <pre>
  * - The tables can be verified/fixed in two ways;
  *   1) by running mysqlcheck -A, or
  *   2) by executing (inside of mysql using the GNUnet database):
- *   mysql> REPAIR TABLE gn080;
+ *   mysql> REPAIR TABLE gn090;
  *   mysql> REPAIR TABLE gn072;
  *
  * PROBLEMS?
  * to it, create tables, issue queries etc.
  *
  * TODO:
- * - implement GET
- * - remove 'size' field in gn080.
  * - use FOREIGN KEY for 'uid/vkey'
  * - consistent naming of uid/vkey
  */
    automatically apply a LIMIT on the outermost clause, so we need to
    repeat ourselves quite a bit.  All hail the performance gods (and thanks
    to #mysql on freenode) */
-#define SELECT_IT_LOW_PRIORITY "(SELECT size,type,prio,anonLevel,expire,hash,vkey FROM gn080 FORCE INDEX(prio) WHERE (prio = ? AND vkey > ?) "\
-                               "ORDER BY prio ASC,vkey ASC LIMIT 1) "\
+#define SELECT_IT_LOW_PRIORITY "(SELECT type,prio,anonLevel,expire,hash,vkey FROM gn090 FORCE INDEX(prio) WHERE (prio = ? AND vkey > ?) "\
+                               "ORDER BY prio ASC,vkey ASC LIMIT 1) "                          \
                                "UNION "\
-                               "(SELECT size,type,prio,anonLevel,expire,hash,vkey FROM gn080 FORCE INDEX(prio) WHERE (prio > ? AND vkey != ?)"\
+                               "(SELECT type,prio,anonLevel,expire,hash,vkey FROM gn090 FORCE INDEX(prio) WHERE (prio > ? AND vkey != ?)"\
                                "ORDER BY prio ASC,vkey ASC LIMIT 1)"\
                                "ORDER BY prio ASC,vkey ASC LIMIT 1"
 
-#define SELECT_IT_NON_ANONYMOUS "(SELECT size,type,prio,anonLevel,expire,hash,vkey FROM gn080 FORCE INDEX(prio) WHERE (prio = ? AND vkey < ?)"\
+#define SELECT_IT_NON_ANONYMOUS "(SELECT type,prio,anonLevel,expire,hash,vkey FROM gn090 FORCE INDEX(prio) WHERE (prio = ? AND vkey < ?)"\
                                 " AND anonLevel=0 ORDER BY prio DESC,vkey DESC LIMIT 1) "\
                                 "UNION "\
-                                "(SELECT size,type,prio,anonLevel,expire,hash,vkey FROM gn080 FORCE INDEX(prio) WHERE (prio < ? AND vkey != ?)"\
+                                "(SELECT type,prio,anonLevel,expire,hash,vkey FROM gn090 FORCE INDEX(prio) WHERE (prio < ? AND vkey != ?)"\
                                 " AND anonLevel=0 ORDER BY prio DESC,vkey DESC LIMIT 1) "\
                                 "ORDER BY prio DESC,vkey DESC LIMIT 1"
 
-#define SELECT_IT_EXPIRATION_TIME "(SELECT size,type,prio,anonLevel,expire,hash,vkey FROM gn080 FORCE INDEX(expire) WHERE (expire = ? AND vkey > ?) "\
+#define SELECT_IT_EXPIRATION_TIME "(SELECT type,prio,anonLevel,expire,hash,vkey FROM gn090 FORCE INDEX(expire) WHERE (expire = ? AND vkey > ?) "\
                                   "ORDER BY expire ASC,vkey ASC LIMIT 1) "\
                                   "UNION "\
-                                  "(SELECT size,type,prio,anonLevel,expire,hash,vkey FROM gn080 FORCE INDEX(expire) WHERE (expire > ? AND vkey != ?) "\
+                                  "(SELECT type,prio,anonLevel,expire,hash,vkey FROM gn090 FORCE INDEX(expire) WHERE (expire > ? AND vkey != ?) "\
                                   "ORDER BY expire ASC,vkey ASC LIMIT 1)"\
                                   "ORDER BY expire ASC,vkey ASC LIMIT 1"
 
 
-#define SELECT_IT_MIGRATION_ORDER "(SELECT size,type,prio,anonLevel,expire,hash,vkey FROM gn080 FORCE INDEX(expire) WHERE (expire = ? AND vkey < ?)"\
+#define SELECT_IT_MIGRATION_ORDER "(SELECT type,prio,anonLevel,expire,hash,vkey FROM gn090 FORCE INDEX(expire) WHERE (expire = ? AND vkey < ?)"\
                                   " AND expire > ? AND type!=3"\
                                   " ORDER BY expire DESC,vkey DESC LIMIT 1) "\
                                   "UNION "\
-                                  "(SELECT size,type,prio,anonLevel,expire,hash,vkey FROM gn080 FORCE INDEX(expire) WHERE (expire < ? AND vkey != ?)"\
+                                  "(SELECT type,prio,anonLevel,expire,hash,vkey FROM gn090 FORCE INDEX(expire) WHERE (expire < ? AND vkey != ?)"\
                                   " AND expire > ? AND type!=3"\
                                   " ORDER BY expire DESC,vkey DESC LIMIT 1)"\
                                   "ORDER BY expire DESC,vkey DESC LIMIT 1"
 
-#define SELECT_SIZE "SELECT sum(size) FROM gn080"
+// #define SELECT_SIZE "SELECT SUM(BIT_LENGTH(value) DIV 8) FROM gn072"
 
 
 struct GNUNET_MysqlStatementHandle
@@ -211,10 +208,45 @@ struct GNUNET_MysqlStatementHandle
 
 };
 
+/**
+ * Context for the universal iterator.
+ */
+struct NextRequestClosure;
+
+/**
+ * Type of a function that will prepare
+ * the next iteration.
+ *
+ * @param cls closure
+ * @param nc the next context; NULL for the last
+ *         call which gives the callback a chance to
+ *         clean up the closure
+ * @return GNUNET_OK on success, GNUNET_NO if there are
+ *         no more values, GNUNET_SYSERR on error
+ */
+typedef int (*PrepareFunction)(void *cls,
+                              struct NextRequestClosure *nc);
+
+
 struct NextRequestClosure
 {
   struct Plugin *plugin;
 
+  struct GNUNET_TIME_Absolute now;
+
+  /**
+   * Function to call to prepare the next
+   * iteration.
+   */
+  PrepareFunction prep;
+
+  /**
+   * Closure for prep.
+   */
+  void *prep_cls;
+
+  MYSQL_BIND rbind[6];
+
   unsigned int type;
   
   unsigned int iter_select;
@@ -254,7 +286,6 @@ struct Plugin
    */
   char *cnffile;
 
-
   /**
    * Closure of the 'next_task' (must be freed if 'next_task' is cancelled).
    */
@@ -278,45 +309,43 @@ struct Plugin
   struct GNUNET_MysqlStatementHandle *insert_value;
 
   /**
-   * Statements dealing with gn080 table 
+   * Statements dealing with gn090 table 
    */
-#define INSERT_ENTRY "INSERT INTO gn080 (size,type,prio,anonLevel,expire,hash,vhash,vkey) VALUES (?,?,?,?,?,?,?,?)"
+#define INSERT_ENTRY "INSERT INTO gn090 (type,prio,anonLevel,expire,hash,vhash,vkey) VALUES (?,?,?,?,?,?,?)"
   struct GNUNET_MysqlStatementHandle *insert_entry;
   
-#define DELETE_ENTRY_BY_VKEY "DELETE FROM gn080 WHERE vkey=?"
+#define DELETE_ENTRY_BY_VKEY "DELETE FROM gn090 WHERE vkey=?"
   struct GNUNET_MysqlStatementHandle *delete_entry_by_vkey;
   
-#define SELECT_ENTRY_BY_HASH "SELECT size,type,prio,anonLevel,expire,hash,vkey FROM gn080 FORCE INDEX (hash_vkey) WHERE hash=? AND vkey > ? ORDER BY vkey ASC LIMIT 1 OFFSET ?"
+#define SELECT_ENTRY_BY_HASH "SELECT type,prio,anonLevel,expire,hash,vkey FROM gn090 FORCE INDEX (hash_vkey) WHERE hash=? AND vkey > ? ORDER BY vkey ASC LIMIT 1 OFFSET ?"
   struct GNUNET_MysqlStatementHandle *select_entry_by_hash;
   
-#define SELECT_ENTRY_BY_HASH_AND_VHASH "SELECT size,type,prio,anonLevel,expire,hash,vkey FROM gn080 FORCE INDEX (hash_vhash_vkey) WHERE hash=? AND vhash=? AND vkey > ? ORDER BY vkey ASC LIMIT 1 OFFSET ?"
+#define SELECT_ENTRY_BY_HASH_AND_VHASH "SELECT type,prio,anonLevel,expire,hash,vkey FROM gn090 FORCE INDEX (hash_vhash_vkey) WHERE hash=? AND vhash=? AND vkey > ? ORDER BY vkey ASC LIMIT 1 OFFSET ?"
   struct GNUNET_MysqlStatementHandle *select_entry_by_hash_and_vhash;
 
-#define SELECT_ENTRY_BY_HASH_AND_TYPE "SELECT size,type,prio,anonLevel,expire,hash,vkey FROM gn080 FORCE INDEX (hash_vkey) WHERE hash=? AND vkey > ? AND type=? ORDER BY vkey ASC LIMIT 1 OFFSET ?"
+#define SELECT_ENTRY_BY_HASH_AND_TYPE "SELECT type,prio,anonLevel,expire,hash,vkey FROM gn090 FORCE INDEX (hash_vkey) WHERE hash=? AND vkey > ? AND type=? ORDER BY vkey ASC LIMIT 1 OFFSET ?"
   struct GNUNET_MysqlStatementHandle *select_entry_by_hash_and_type;
   
-#define SELECT_ENTRY_BY_HASH_VHASH_AND_TYPE "SELECT size,type,prio,anonLevel,expire,hash,vkey FROM gn080 FORCE INDEX (hash_vhash_vkey) WHERE hash=? AND vhash=? AND vkey > ? AND type=? ORDER BY vkey ASC LIMIT 1 OFFSET ?"
+#define SELECT_ENTRY_BY_HASH_VHASH_AND_TYPE "SELECT type,prio,anonLevel,expire,hash,vkey FROM gn090 FORCE INDEX (hash_vhash_vkey) WHERE hash=? AND vhash=? AND vkey > ? AND type=? ORDER BY vkey ASC LIMIT 1 OFFSET ?"
   struct GNUNET_MysqlStatementHandle *select_entry_by_hash_vhash_and_type;
   
-#define COUNT_ENTRY_BY_HASH "SELECT count(*) FROM gn080 FORCE INDEX (hash) WHERE hash=?"
+#define COUNT_ENTRY_BY_HASH "SELECT count(*) FROM gn090 FORCE INDEX (hash) WHERE hash=?"
   struct GNUNET_MysqlStatementHandle *count_entry_by_hash;
 
-#define COUNT_ENTRY_BY_HASH_AND_VHASH "SELECT count(*) FROM gn080 FORCE INDEX (hash_vhash_vkey) WHERE hash=? AND vhash=?"
+#define COUNT_ENTRY_BY_HASH_AND_VHASH "SELECT count(*) FROM gn090 FORCE INDEX (hash_vhash_vkey) WHERE hash=? AND vhash=?"
   struct GNUNET_MysqlStatementHandle *count_entry_by_hash_and_vhash;
 
-#define COUNT_ENTRY_BY_HASH_AND_TYPE "SELECT count(*) FROM gn080 FORCE INDEX (hash) WHERE hash=? AND type=?"
+#define COUNT_ENTRY_BY_HASH_AND_TYPE "SELECT count(*) FROM gn090 FORCE INDEX (hash) WHERE hash=? AND type=?"
   struct GNUNET_MysqlStatementHandle *count_entry_by_hash_and_type;
 
-#define COUNT_ENTRY_BY_HASH_VHASH_AND_TYPE "SELECT count(*) FROM gn080 FORCE INDEX (hash_vhash) WHERE hash=? AND vhash=? AND type=?"
+#define COUNT_ENTRY_BY_HASH_VHASH_AND_TYPE "SELECT count(*) FROM gn090 FORCE INDEX (hash_vhash) WHERE hash=? AND vhash=? AND type=?"
   struct GNUNET_MysqlStatementHandle *count_entry_by_hash_vhash_and_type;
 
-#define UPDATE_ENTRY "UPDATE gn080 SET prio=prio+?,expire=IF(expire>=?,expire,?) WHERE vkey=?"
+#define UPDATE_ENTRY "UPDATE gn090 SET prio=prio+?,expire=IF(expire>=?,expire,?) WHERE vkey=?"
   struct GNUNET_MysqlStatementHandle *update_entry;
 
   struct GNUNET_MysqlStatementHandle *iter[4];
 
-  //static unsigned int stat_size;
-
   /**
    * Size of the mysql database on disk.
    */
@@ -338,6 +367,7 @@ get_my_cnf_path (const struct GNUNET_CONFIGURATION_Handle *cfg)
 #ifndef WINDOWS
   struct passwd *pw;
 #endif
+  int configured;
 
 #ifndef WINDOWS
   pw = getpwuid (getuid ());
@@ -349,10 +379,12 @@ get_my_cnf_path (const struct GNUNET_CONFIGURATION_Handle *cfg)
     }
   if (GNUNET_YES ==
       GNUNET_CONFIGURATION_have_value (cfg,
-                                      "MYSQL", "CONFIG"))
+                                      "datastore-mysql", "CONFIG"))
     {
-      GNUNET_CONFIGURATION_get_value_filename (cfg,
-                                              "MYSQL", "CONFIG", &cnffile);
+      GNUNET_assert (GNUNET_OK == 
+                    GNUNET_CONFIGURATION_get_value_filename (cfg,
+                                                             "datastore-mysql", "CONFIG", &cnffile));
+      configured = GNUNET_YES;
     }
   else
     {
@@ -363,6 +395,7 @@ get_my_cnf_path (const struct GNUNET_CONFIGURATION_Handle *cfg)
 #endif
       GNUNET_asprintf (&cnffile, "%s/.my.cnf", home_dir);
       GNUNET_free (home_dir);
+      configured = GNUNET_NO;
     }
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
              _("Trying to use file `%s' for MySQL configuration.\n"),
@@ -370,9 +403,10 @@ get_my_cnf_path (const struct GNUNET_CONFIGURATION_Handle *cfg)
   if ((0 != STAT (cnffile, &st)) ||
       (0 != ACCESS (cnffile, R_OK)) || (!S_ISREG (st.st_mode)))
     {
-      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                 _("Could not access file `%s': %s\n"), cnffile,
-                 STRERROR (errno));
+      if (configured == GNUNET_YES)
+       GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                   _("Could not access file `%s': %s\n"), cnffile,
+                   STRERROR (errno));
       GNUNET_free (cnffile);
       return NULL;
     }
@@ -380,6 +414,25 @@ get_my_cnf_path (const struct GNUNET_CONFIGURATION_Handle *cfg)
 }
 
 
+
+/**
+ * Free a prepared statement.
+ */
+static void
+prepared_statement_destroy (struct Plugin *plugin, 
+                           struct GNUNET_MysqlStatementHandle
+                           *s)
+{
+  GNUNET_CONTAINER_DLL_remove (plugin->shead,
+                              plugin->stail,
+                              s);
+  if (s->valid)
+    mysql_stmt_close (s->statement);
+  GNUNET_free (s->query);
+  GNUNET_free (s);
+}
+
+
 /**
  * Close database connection and all prepared statements (we got a DB
  * disconnect error).
@@ -390,16 +443,9 @@ iclose (struct Plugin *plugin)
   struct GNUNET_MysqlStatementHandle *spos;
 
   spos = plugin->shead;
-  while (spos != NULL)
-    {
-      if (spos->statement != NULL)
-       {
-         mysql_stmt_close (spos->statement);
-         spos->statement = NULL;
-       }
-      spos->valid = GNUNET_NO;
-      spos = spos->next;
-    }
+  while (NULL != plugin->shead)
+    prepared_statement_destroy (plugin,
+                               plugin->shead);
   if (plugin->dbf != NULL)
     {
       mysql_close (plugin->dbf);
@@ -436,57 +482,62 @@ iopen (struct Plugin *ret)
   mysql_options (ret->dbf, MYSQL_OPT_RECONNECT, &reconnect);
   mysql_options (ret->dbf,
                  MYSQL_OPT_CONNECT_TIMEOUT, (const void *) &timeout);
+  mysql_options(ret->dbf, MYSQL_SET_CHARSET_NAME, "UTF8");
   timeout = 60; /* in seconds */
   mysql_options (ret->dbf, MYSQL_OPT_READ_TIMEOUT, (const void *) &timeout);
   mysql_options (ret->dbf, MYSQL_OPT_WRITE_TIMEOUT, (const void *) &timeout);
   mysql_dbname = NULL;
   if (GNUNET_YES == GNUNET_CONFIGURATION_have_value (ret->env->cfg,
-                                                    "MYSQL", "DATABASE"))
+                                                    "datastore-mysql", "DATABASE"))
     GNUNET_assert (GNUNET_OK == 
                   GNUNET_CONFIGURATION_get_value_string (ret->env->cfg,
-                                                         "MYSQL", "DATABASE", 
+                                                         "datastore-mysql", "DATABASE", 
                                                          &mysql_dbname));
   else
     mysql_dbname = GNUNET_strdup ("gnunet");
   mysql_user = NULL;
   if (GNUNET_YES == GNUNET_CONFIGURATION_have_value (ret->env->cfg,
-                                                    "MYSQL", "USER"))
+                                                    "datastore-mysql", "USER"))
     {
-      GNUNET_break (GNUNET_OK == 
+      GNUNET_assert (GNUNET_OK == 
                    GNUNET_CONFIGURATION_get_value_string (ret->env->cfg,
-                                                          "MYSQL", "USER", 
+                                                          "datastore-mysql", "USER", 
                                                           &mysql_user));
     }
   mysql_password = NULL;
   if (GNUNET_YES == GNUNET_CONFIGURATION_have_value (ret->env->cfg,
-                                                    "MYSQL", "PASSWORD"))
+                                                    "datastore-mysql", "PASSWORD"))
     {
-      GNUNET_break (GNUNET_OK ==
+      GNUNET_assert (GNUNET_OK ==
                    GNUNET_CONFIGURATION_get_value_string (ret->env->cfg,
-                                                          "MYSQL", "PASSWORD",
+                                                          "datastore-mysql", "PASSWORD",
                                                           &mysql_password));
     }
   mysql_server = NULL;
   if (GNUNET_YES == GNUNET_CONFIGURATION_have_value (ret->env->cfg,
-                                                    "MYSQL", "HOST"))
+                                                    "datastore-mysql", "HOST"))
     {
-      GNUNET_break (GNUNET_OK == 
+      GNUNET_assert (GNUNET_OK == 
                    GNUNET_CONFIGURATION_get_value_string (ret->env->cfg,
-                                                          "MYSQL", "HOST", 
+                                                          "datastore-mysql", "HOST", 
                                                           &mysql_server));
     }
   mysql_port = 0;
   if (GNUNET_YES == GNUNET_CONFIGURATION_have_value (ret->env->cfg,
-                                                    "MYSQL", "PORT"))
+                                                    "datastore-mysql", "PORT"))
     {
-      GNUNET_break (GNUNET_OK ==
-                   GNUNET_CONFIGURATION_get_value_number (ret->env->cfg, "MYSQL",
+      GNUNET_assert (GNUNET_OK ==
+                   GNUNET_CONFIGURATION_get_value_number (ret->env->cfg, "datastore-mysql",
                                                           "PORT", &mysql_port));
     }
 
   GNUNET_assert (mysql_dbname != NULL);
   mysql_real_connect (ret->dbf, mysql_server, mysql_user, mysql_password,
-                      mysql_dbname, (unsigned int) mysql_port, NULL, 0);
+                      mysql_dbname, (unsigned int) mysql_port, NULL,
+                     CLIENT_IGNORE_SIGPIPE);
+  GNUNET_free_non_null (mysql_server);
+  GNUNET_free_non_null (mysql_user);
+  GNUNET_free_non_null (mysql_password);
   GNUNET_free (mysql_dbname);
   if (mysql_error (ret->dbf)[0])
     {
@@ -521,44 +572,6 @@ run_statement (struct Plugin *plugin,
 }
 
 
-/**
- * Run the given MySQL SELECT statement.  The statement
- * must have only a single result (one column, one row).
- *
- * @return result on success, NULL on error
- */
-static char *
-run_statement_select (struct Plugin *plugin,
-                     const char *statement)
-{
-  MYSQL_RES *sql_res;
-  MYSQL_ROW sql_row;
-  char *ret;
-  
-  if ((NULL == plugin->dbf) && (GNUNET_OK != iopen (plugin)))
-    return NULL;
-  mysql_query (plugin->dbf, statement);
-  if ((mysql_error (plugin->dbf)[0]) ||
-      (!(sql_res = mysql_use_result (plugin->dbf))) ||
-      (!(sql_row = mysql_fetch_row (sql_res))))
-    {
-      LOG_MYSQL (GNUNET_ERROR_TYPE_ERROR,
-                 "mysql_query", plugin);
-      return NULL;
-    }
-  if ((mysql_num_fields (sql_res) != 1) || (sql_row[0] == NULL))
-    {
-      GNUNET_break (mysql_num_fields (sql_res) == 1);
-      if (sql_res != NULL)
-        mysql_free_result (sql_res);
-      return NULL;
-    }
-  ret = GNUNET_strdup (sql_row[0]);
-  mysql_free_result (sql_res);
-  return ret;
-}
-
-
 /**
  * Create a prepared statement.
  *
@@ -613,24 +626,7 @@ prepare_statement (struct Plugin *plugin,
     }
   ret->valid = GNUNET_YES;
   return GNUNET_OK;
-}
-
 
-/**
- * Free a prepared statement.
- */
-static void
-prepared_statement_destroy (struct Plugin *plugin, 
-                           struct GNUNET_MysqlStatementHandle
-                           *s)
-{
-  GNUNET_CONTAINER_DLL_remove (plugin->shead,
-                              plugin->stail,
-                              s);
-  if (s->valid)
-    mysql_stmt_close (s->statement);
-  GNUNET_free (s->query);
-  GNUNET_free (s);
 }
 
 
@@ -864,13 +860,26 @@ do_delete_value (struct Plugin *plugin,
 {
   int ret;
 
+#if DEBUG_MYSQL
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Deleting value %llu from gn072 table\n",
+             vkey);
+#endif
   ret = prepared_statement_run (plugin,
                                plugin->delete_value,
                                NULL,
                                MYSQL_TYPE_LONGLONG,
                                &vkey, GNUNET_YES, -1);
   if (ret > 0)
-    ret = GNUNET_OK;
+    {
+      ret = GNUNET_OK;
+    }
+  else
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                 "Deleting value %llu from gn072 table failed\n",
+                 vkey);
+    }
   return ret;
 }
 
@@ -888,16 +897,33 @@ do_insert_value (struct Plugin *plugin,
                  unsigned long long *vkey)
 {
   unsigned long length = size;
+  int ret;
 
-  return prepared_statement_run (plugin,
-                                plugin->insert_value,
-                                vkey,
-                                MYSQL_TYPE_BLOB,
-                                value, length, &length, -1);
+  ret = prepared_statement_run (plugin,
+                               plugin->insert_value,
+                               vkey,
+                               MYSQL_TYPE_BLOB,
+                               value, length, &length, -1);
+  if (ret == GNUNET_OK)
+    {
+#if DEBUG_MYSQL
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                 "Inserted value number %llu with length %u into gn072 table\n",
+                 *vkey,
+                 size);
+#endif
+    }
+  else
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                 "Failed to insert %u byte value into gn072 table\n",
+                 size);
+    }
+  return ret;
 }
 
 /**
- * Delete an entry from the gn080 table.
+ * Delete an entry from the gn090 table.
  *
  * @param vkey vkey identifying the entry to delete
  * @return GNUNET_OK on success, GNUNET_NO if no such value exists, GNUNET_SYSERR on error
@@ -908,13 +934,26 @@ do_delete_entry_by_vkey (struct Plugin *plugin,
 {
   int ret;
 
+#if DEBUG_MYSQL
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Deleting value %llu from gn090 table\n",
+             vkey);
+#endif
   ret = prepared_statement_run (plugin,
                                plugin->delete_entry_by_vkey,
                                NULL,
                                MYSQL_TYPE_LONGLONG,
                                &vkey, GNUNET_YES, -1);
   if (ret > 0)
-    ret = GNUNET_OK;
+    {
+      ret = GNUNET_OK;
+    }
+  else
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                 "Deleting value %llu from gn090 table failed\n",
+                 vkey);
+    }
   return ret;
 }
 
@@ -925,73 +964,25 @@ return_ok (void *cls, unsigned int num_values, MYSQL_BIND * values)
 }
 
 
-/**
- * Continuation of "sqlite_next_request".
- *
- * @param next_cls the next context
- * @param tc the task context (unused)
- */
-static void 
-sqlite_next_request_cont (void *next_cls,
-                         const struct GNUNET_SCHEDULER_TaskContext *tc)
+static int
+iterator_helper_prepare (void *cls,
+                        struct NextRequestClosure *nrc)
 {
-  struct NextRequestClosure *nrc = next_cls;
   struct Plugin *plugin;
   int ret;
-  unsigned int size;
-  unsigned int type;
-  unsigned int priority;
-  unsigned int anonymity;
-  unsigned long long exp;
-  unsigned long long vkey;
-  unsigned long hashSize;
-  GNUNET_HashCode key;
-  struct GNUNET_TIME_Absolute now;
-  struct GNUNET_TIME_Absolute expiration;
-  MYSQL_BIND rbind[7];
-  unsigned int contentSize;
-  unsigned long length;
-  MYSQL_BIND dbind[1];
-  char datum[GNUNET_SERVER_MAX_MESSAGE_SIZE];
 
- AGAIN:
+  if (nrc == NULL)
+    return GNUNET_NO;
   plugin = nrc->plugin;
-  plugin->next_task = GNUNET_SCHEDULER_NO_TASK;
-  plugin->next_task_nc = NULL;
-  hashSize = sizeof (GNUNET_HashCode);
-  memset (rbind, 0, sizeof (rbind));
-  rbind[0].buffer_type = MYSQL_TYPE_LONG;
-  rbind[0].buffer = &size;
-  rbind[0].is_unsigned = 1;
-  rbind[1].buffer_type = MYSQL_TYPE_LONG;
-  rbind[1].buffer = &type;
-  rbind[1].is_unsigned = 1;
-  rbind[2].buffer_type = MYSQL_TYPE_LONG;
-  rbind[2].buffer = &priority;
-  rbind[2].is_unsigned = 1;
-  rbind[3].buffer_type = MYSQL_TYPE_LONG;
-  rbind[3].buffer = &anonymity;
-  rbind[3].is_unsigned = 1;
-  rbind[4].buffer_type = MYSQL_TYPE_LONGLONG;
-  rbind[4].buffer = &exp;
-  rbind[4].is_unsigned = 1;
-  rbind[5].buffer_type = MYSQL_TYPE_BLOB;
-  rbind[5].buffer = &key;
-  rbind[5].buffer_length = hashSize;
-  rbind[5].length = &hashSize;
-  rbind[6].buffer_type = MYSQL_TYPE_LONGLONG;
-  rbind[6].buffer = &vkey;
-  rbind[6].is_unsigned = GNUNET_YES;
-
-  now = GNUNET_TIME_absolute_get ();
+  ret = GNUNET_SYSERR;
   switch (nrc->iter_select)
     {
     case 0:
     case 1:
       ret = prepared_statement_run_select (plugin,
                                           plugin->iter[nrc->iter_select],
-                                          7,
-                                          rbind,
+                                          6,
+                                          nrc->rbind,
                                           &return_ok,
                                           NULL,
                                           MYSQL_TYPE_LONG,
@@ -1010,8 +1001,8 @@ sqlite_next_request_cont (void *next_cls,
     case 2:
       ret = prepared_statement_run_select (plugin,
                                           plugin->iter[nrc->iter_select],
-                                          7,
-                                          rbind,
+                                          6,
+                                          nrc->rbind,
                                           &return_ok,
                                           NULL,
                                           MYSQL_TYPE_LONGLONG,
@@ -1030,8 +1021,8 @@ sqlite_next_request_cont (void *next_cls,
     case 3:
       ret = prepared_statement_run_select (plugin,
                                           plugin->iter[nrc->iter_select],
-                                          7,
-                                          rbind,
+                                          6,
+                                          nrc->rbind,
                                           &return_ok,
                                           NULL,
                                           MYSQL_TYPE_LONGLONG,
@@ -1041,7 +1032,7 @@ sqlite_next_request_cont (void *next_cls,
                                           &nrc->last_vkey,
                                           GNUNET_YES,
                                           MYSQL_TYPE_LONGLONG,
-                                          &now.value,
+                                          &nrc->now.value,
                                           GNUNET_YES,
                                           MYSQL_TYPE_LONGLONG,
                                           &nrc->last_expire,
@@ -1050,50 +1041,101 @@ sqlite_next_request_cont (void *next_cls,
                                           &nrc->last_vkey,
                                           GNUNET_YES,
                                           MYSQL_TYPE_LONGLONG,
-                                          &now.value,
+                                          &nrc->now.value,
                                           GNUNET_YES, -1);
       break;
     default:
       GNUNET_assert (0);
-      return;
     }
-  if (ret != GNUNET_OK)
+  return ret;
+}
+
+
+/**
+ * Continuation of "mysql_next_request".
+ *
+ * @param next_cls the next context
+ * @param tc the task context (unused)
+ */
+static void 
+mysql_next_request_cont (void *next_cls,
+                         const struct GNUNET_SCHEDULER_TaskContext *tc)
+{
+  struct NextRequestClosure *nrc = next_cls;
+  struct Plugin *plugin;
+  int ret;
+  unsigned int type;
+  unsigned int priority;
+  unsigned int anonymity;
+  unsigned long long exp;
+  unsigned long long vkey;
+  unsigned long hashSize;
+  GNUNET_HashCode key;
+  struct GNUNET_TIME_Absolute expiration;
+  unsigned long length;
+  MYSQL_BIND *rbind; /* size 7 */
+  MYSQL_BIND dbind[1];
+  char datum[GNUNET_SERVER_MAX_MESSAGE_SIZE];
+
+  plugin = nrc->plugin;
+  plugin->next_task = GNUNET_SCHEDULER_NO_TASK;
+  plugin->next_task_nc = NULL;
+
+ AGAIN: 
+  GNUNET_assert (nrc->plugin->next_task == GNUNET_SCHEDULER_NO_TASK);
+  nrc->now = GNUNET_TIME_absolute_get ();
+  hashSize = sizeof (GNUNET_HashCode);
+  memset (nrc->rbind, 0, sizeof (nrc->rbind));
+  rbind = nrc->rbind;
+  rbind[0].buffer_type = MYSQL_TYPE_LONG;
+  rbind[0].buffer = &type;
+  rbind[0].is_unsigned = 1;
+  rbind[1].buffer_type = MYSQL_TYPE_LONG;
+  rbind[1].buffer = &priority;
+  rbind[1].is_unsigned = 1;
+  rbind[2].buffer_type = MYSQL_TYPE_LONG;
+  rbind[2].buffer = &anonymity;
+  rbind[2].is_unsigned = 1;
+  rbind[3].buffer_type = MYSQL_TYPE_LONGLONG;
+  rbind[3].buffer = &exp;
+  rbind[3].is_unsigned = 1;
+  rbind[4].buffer_type = MYSQL_TYPE_BLOB;
+  rbind[4].buffer = &key;
+  rbind[4].buffer_length = hashSize;
+  rbind[4].length = &hashSize;
+  rbind[5].buffer_type = MYSQL_TYPE_LONGLONG;
+  rbind[5].buffer = &vkey;
+  rbind[5].is_unsigned = GNUNET_YES;
+
+  if ( (GNUNET_YES == nrc->end_it) ||
+       (GNUNET_OK != nrc->prep (nrc->prep_cls,
+                               nrc)))
     goto END_SET;
+  GNUNET_assert (nrc->plugin->next_task == GNUNET_SCHEDULER_NO_TASK);
   nrc->last_vkey = vkey;
   nrc->last_prio = priority;
   nrc->last_expire = exp;
-  if ((rbind[0].buffer_type != MYSQL_TYPE_LONG) ||
-      (!rbind[0].is_unsigned) ||
-      (rbind[1].buffer_type != MYSQL_TYPE_LONG) ||
-      (!rbind[1].is_unsigned) ||
-      (rbind[2].buffer_type != MYSQL_TYPE_LONG) ||
-      (!rbind[2].is_unsigned) ||
-      (rbind[3].buffer_type != MYSQL_TYPE_LONG) ||
-      (!rbind[3].is_unsigned) ||
-      (rbind[4].buffer_type != MYSQL_TYPE_LONGLONG) ||
-      (!rbind[4].is_unsigned) ||
-      (rbind[5].buffer_type != MYSQL_TYPE_BLOB) ||
-      (rbind[5].buffer_length != sizeof (GNUNET_HashCode)) ||
-      (*rbind[5].length != sizeof (GNUNET_HashCode)) ||
-      (rbind[6].buffer_type != MYSQL_TYPE_LONGLONG) ||
-      (!rbind[6].is_unsigned))
+  if ( (rbind[4].buffer_length != sizeof (GNUNET_HashCode)) ||
+       (hashSize != sizeof (GNUNET_HashCode)) )
     {
       GNUNET_break (0);
       goto END_SET;
     }    
-  contentSize = *(unsigned int *) rbind[0].buffer;
-  if (contentSize >= GNUNET_SERVER_MAX_MESSAGE_SIZE)
-    {
-      GNUNET_break (0); /* far too big */
-      goto END_SET;
-    }
+#if DEBUG_MYSQL
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Found value %llu with prio %u, anon %u, expire %llu selecting from gn090 table\n",
+             vkey,           
+             priority,
+             anonymity,
+             exp);
+#endif
   /* now do query on gn072 */
-  length = contentSize;
-  memset (rbind, 0, sizeof (rbind));
-  rbind[0].buffer_type = MYSQL_TYPE_BLOB;
-  rbind[0].buffer_length = contentSize;
-  rbind[0].length = &length;
-  rbind[0].buffer = datum;
+  length = sizeof (datum);
+  memset (dbind, 0, sizeof (dbind));
+  dbind[0].buffer_type = MYSQL_TYPE_BLOB;
+  dbind[0].buffer_length = length;
+  dbind[0].length = &length;
+  dbind[0].buffer = datum;
   ret = prepared_statement_run_select (plugin,
                                       plugin->select_value,
                                       1,
@@ -1105,23 +1147,33 @@ sqlite_next_request_cont (void *next_cls,
   GNUNET_break (ret <= 1);     /* should only have one rbind! */
   if (ret > 0)
     ret = GNUNET_OK;
-  if ((ret != GNUNET_OK) ||
-      (dbind[0].buffer_length != contentSize) || (length != contentSize))
+  if (ret != GNUNET_OK) 
     {
-      GNUNET_break (ret != 0); /* should have one rbind! */
-      GNUNET_break (length == contentSize);    /* length should match! */
-      GNUNET_break (dbind[0].buffer_length == contentSize);    /* length should be internally consistent! */
-      do_delete_value (plugin, vkey);
-      if (ret != 0)
-       do_delete_entry_by_vkey (plugin, vkey);
-      plugin->content_size -= contentSize;
+      GNUNET_break (0);
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING, 
+                 _("Failed to obtain value %llu from table `%s'\n"),
+                 vkey,
+                 "gn072");
       goto AGAIN;
     }
+  GNUNET_break (length <= sizeof(datum));
+#if DEBUG_MYSQL
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Calling iterator with value `%s' number %llu of size %u with type %u, priority %u, anonymity %u and expiration %llu\n",
+             GNUNET_h2s (&key),
+             vkey,           
+             length,
+             type,
+             priority,
+             anonymity,
+             exp);
+#endif
+  GNUNET_assert (nrc->plugin->next_task == GNUNET_SCHEDULER_NO_TASK);
   expiration.value = exp;
   ret = nrc->dviter (nrc->dviter_cls,
                     nrc,
                     &key,
-                    contentSize,
+                    length,
                     datum,
                     type,
                     priority,
@@ -1130,19 +1182,26 @@ sqlite_next_request_cont (void *next_cls,
                     vkey);
   if (ret == GNUNET_SYSERR)
     {
-      /* is this correct, or should we not call iter again period?  */
-      goto END_SET;
+      nrc->end_it = GNUNET_YES;
+      return;
     }
   if (ret == GNUNET_NO)
     {
       do_delete_value (plugin, vkey);
       do_delete_entry_by_vkey (plugin, vkey);
-      plugin->content_size -= contentSize;
+      plugin->content_size -= length;
     }
   return;
  END_SET:
   /* call dviter with "end of set" */
-  return;
+  GNUNET_assert (nrc->plugin->next_task == GNUNET_SCHEDULER_NO_TASK);
+  nrc->dviter (nrc->dviter_cls, 
+              NULL, NULL, 0, NULL, 0, 0, 0, 
+              GNUNET_TIME_UNIT_ZERO_ABS, 0);
+  GNUNET_assert (nrc->plugin->next_task == GNUNET_SCHEDULER_NO_TASK);
+  nrc->prep (nrc->prep_cls, NULL);
+  GNUNET_assert (nrc->plugin->next_task == GNUNET_SCHEDULER_NO_TASK);
+  GNUNET_free (nrc);
 }
 
 
@@ -1168,7 +1227,7 @@ mysql_plugin_next_request (void *next_cls,
     nrc->end_it = GNUNET_YES;
   nrc->plugin->next_task_nc = nrc;
   nrc->plugin->next_task = GNUNET_SCHEDULER_add_now (nrc->plugin->env->sched,
-                                                    &sqlite_next_request_cont,
+                                                    &mysql_next_request_cont,
                                                     nrc);
 }  
 
@@ -1199,7 +1258,7 @@ iterateHelper (struct Plugin *plugin,
   nrc->iter_select = iter_select;
   nrc->dviter = dviter;
   nrc->dviter_cls = dviter_cls;
-
+  nrc->prep = &iterator_helper_prepare;
   if (is_asc)
     {
       nrc->last_prio = 0;
@@ -1247,16 +1306,20 @@ mysql_plugin_get_size (void *cls)
  */
 static int
 mysql_plugin_put (void *cls,
-                    const GNUNET_HashCode * key,
-                    uint32_t size,
-                    const void *data,
-                    enum GNUNET_BLOCK_Type type,
-                    uint32_t priority,
-                    uint32_t anonymity,
-                    struct GNUNET_TIME_Absolute expiration,
-                    char **msg)
+                 const GNUNET_HashCode * key,
+                 uint32_t size,
+                 const void *data,
+                 enum GNUNET_BLOCK_Type type,
+                 uint32_t priority,
+                 uint32_t anonymity,
+                 struct GNUNET_TIME_Absolute expiration,
+                 char **msg)
 {
   struct Plugin *plugin = cls;
+  unsigned int itype = type;
+  unsigned int ipriority = priority;
+  unsigned int ianonymity = anonymity;
+  unsigned long long lexpiration = expiration.value;
   unsigned long hashSize;
   unsigned long hashSize2;
   unsigned long long vkey;
@@ -1278,19 +1341,16 @@ mysql_plugin_put (void *cls,
                              plugin->insert_entry,
                              NULL,
                              MYSQL_TYPE_LONG,
-                             &size,
+                             &itype,
                              GNUNET_YES,
                              MYSQL_TYPE_LONG,
-                             &type,
+                             &ipriority,
                              GNUNET_YES,
                              MYSQL_TYPE_LONG,
-                             &priority,
-                             GNUNET_YES,
-                             MYSQL_TYPE_LONG,
-                             &anonymity,
+                             &ianonymity,
                              GNUNET_YES,
                              MYSQL_TYPE_LONGLONG,
-                             &expiration.value,
+                             &lexpiration,
                              GNUNET_YES,
                              MYSQL_TYPE_BLOB,
                              key,
@@ -1306,6 +1366,13 @@ mysql_plugin_put (void *cls,
       do_delete_value (plugin, vkey);
       return GNUNET_SYSERR;
     }
+#if DEBUG_MYSQL
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Inserted value `%s' number %llu with size %u into gn090 table\n",
+             GNUNET_h2s (key),
+             vkey,
+             (unsigned int) size);
+#endif
   plugin->content_size += size;
   return GNUNET_OK;
 }
@@ -1334,6 +1401,111 @@ mysql_plugin_iter_low_priority (void *cls,
 }
 
 
+struct GetContext
+{
+  GNUNET_HashCode key;
+  GNUNET_HashCode vhash;
+
+  unsigned int prio;
+  unsigned int anonymity;
+  unsigned long long expiration;
+  unsigned long long vkey;
+  unsigned long long total;
+  int off;
+  int count;
+  int have_vhash;
+};
+
+
+static int
+get_statement_prepare (void *cls,
+                      struct NextRequestClosure *nrc)
+{
+  struct GetContext *gc = cls;
+  struct Plugin *plugin;
+  int ret;
+  unsigned int limit_off;
+  unsigned long hashSize;
+
+  if (NULL == nrc)
+    {
+      GNUNET_free (gc);
+      return GNUNET_NO;
+    }
+  if (gc->count == gc->total)
+    return GNUNET_NO;
+  plugin = nrc->plugin;
+  hashSize = sizeof (GNUNET_HashCode);
+  if (gc->count + gc->off == gc->total)
+    nrc->last_vkey = 0;          /* back to start */
+  if (gc->count == 0)
+    limit_off = gc->off;
+  else
+    limit_off = 0;
+#if DEBUG_MYSQL
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Obtaining result number %d/%lld at offset %d with lvc %llu for GET `%s'\n",
+             gc->count+1,
+             gc->total,
+             limit_off,
+             nrc->last_vkey,
+             GNUNET_h2s (&gc->key));  
+#endif
+  if (nrc->type != 0)
+    {
+      if (gc->have_vhash)
+       {
+         ret =
+           prepared_statement_run_select
+           (plugin,
+            plugin->select_entry_by_hash_vhash_and_type, 6, nrc->rbind, &return_ok,
+            NULL, MYSQL_TYPE_BLOB, &gc->key, hashSize, &hashSize,
+            MYSQL_TYPE_BLOB, &gc->vhash, hashSize, &hashSize,
+            MYSQL_TYPE_LONGLONG, &nrc->last_vkey, GNUNET_YES, MYSQL_TYPE_LONG,
+            &nrc->type, GNUNET_YES, MYSQL_TYPE_LONG, &limit_off, GNUNET_YES,
+            -1);
+       }
+      else
+       {
+         ret =
+           prepared_statement_run_select
+           (plugin,
+            plugin->select_entry_by_hash_and_type, 6, nrc->rbind, &return_ok, NULL,
+            MYSQL_TYPE_BLOB, &gc->key, hashSize, &hashSize,
+            MYSQL_TYPE_LONGLONG, &nrc->last_vkey, GNUNET_YES, MYSQL_TYPE_LONG,
+            &nrc->type, GNUNET_YES, MYSQL_TYPE_LONG, &limit_off, GNUNET_YES,
+            -1);
+       }
+    }
+  else
+    {
+      if (gc->have_vhash)
+       {
+         ret =
+           prepared_statement_run_select
+           (plugin,
+            plugin->select_entry_by_hash_and_vhash, 6, nrc->rbind, &return_ok, NULL,
+            MYSQL_TYPE_BLOB, &gc->key, hashSize, &hashSize, MYSQL_TYPE_BLOB,
+            &gc->vhash, hashSize, &hashSize, MYSQL_TYPE_LONGLONG,
+            &nrc->last_vkey, GNUNET_YES, MYSQL_TYPE_LONG, &limit_off,
+            GNUNET_YES, -1);
+       }
+      else
+       {
+         ret =
+           prepared_statement_run_select
+           (plugin,
+            plugin->select_entry_by_hash, 6, nrc->rbind, &return_ok, NULL,
+            MYSQL_TYPE_BLOB, &gc->key, hashSize, &hashSize,
+            MYSQL_TYPE_LONGLONG, &nrc->last_vkey, GNUNET_YES, MYSQL_TYPE_LONG,
+            &limit_off, GNUNET_YES, -1);
+       }
+    }
+  gc->count++;
+  return ret;
+}
+
+
 /**
  * Iterate over the results for a particular key
  * in the datastore.
@@ -1359,21 +1531,13 @@ mysql_plugin_get (void *cls,
                  PluginIterator iter, void *iter_cls)
 {
   struct Plugin *plugin = cls;
-  int count;
-  unsigned long long total;
-  int off;
+  unsigned int itype = type;
   int ret;
-  unsigned int size;
-  unsigned int rtype;
-  unsigned int prio;
-  unsigned int level;
-  unsigned int limit_off;
-  unsigned long long expiration;
-  unsigned long long vkey;
-  unsigned long long last_vkey;
+  MYSQL_BIND cbind[1];
+  struct GetContext *gc;
+  struct NextRequestClosure *nrc;
+  long long total;
   unsigned long hashSize;
-  unsigned long hashSize2;
-  MYSQL_BIND rbind[7];
 
   if (iter == NULL) 
     return;
@@ -1385,12 +1549,11 @@ mysql_plugin_get (void *cls,
       return;
     }
   hashSize = sizeof (GNUNET_HashCode);
-  hashSize2 = sizeof (GNUNET_HashCode);
-  memset (rbind, 0, sizeof (rbind));
+  memset (cbind, 0, sizeof (cbind));
   total = -1;
-  rbind[0].buffer_type = MYSQL_TYPE_LONGLONG;
-  rbind[0].buffer = &total;
-  rbind[0].is_unsigned = GNUNET_YES;
+  cbind[0].buffer_type = MYSQL_TYPE_LONGLONG;
+  cbind[0].buffer = &total;
+  cbind[0].is_unsigned = GNUNET_NO;
   if (type != 0)
     {
       if (vhash != NULL)
@@ -1398,9 +1561,9 @@ mysql_plugin_get (void *cls,
           ret =
             prepared_statement_run_select
             (plugin,
-            plugin->count_entry_by_hash_vhash_and_type, 1, rbind, &return_ok, NULL,
-             MYSQL_TYPE_BLOB, key, hashSize2, &hashSize2, MYSQL_TYPE_BLOB,
-             vhash, hashSize2, &hashSize2, MYSQL_TYPE_LONG, &type, GNUNET_YES,
+            plugin->count_entry_by_hash_vhash_and_type, 1, cbind, &return_ok, NULL,
+             MYSQL_TYPE_BLOB, key, hashSize, &hashSize, MYSQL_TYPE_BLOB,
+             vhash, hashSize, &hashSize, MYSQL_TYPE_LONG, &itype, GNUNET_YES,
              -1);
         }
       else
@@ -1408,9 +1571,9 @@ mysql_plugin_get (void *cls,
           ret =
             prepared_statement_run_select
             (plugin,
-            plugin->count_entry_by_hash_and_type, 1, rbind, &return_ok, NULL,
-             MYSQL_TYPE_BLOB, key, hashSize2, &hashSize2, MYSQL_TYPE_LONG,
-             &type, GNUNET_YES, -1);
+            plugin->count_entry_by_hash_and_type, 1, cbind, &return_ok, NULL,
+             MYSQL_TYPE_BLOB, key, hashSize, &hashSize, MYSQL_TYPE_LONG,
+             &itype, GNUNET_YES, -1);
 
         }
     }
@@ -1421,9 +1584,9 @@ mysql_plugin_get (void *cls,
           ret =
             prepared_statement_run_select
             (plugin,
-            plugin->count_entry_by_hash_and_vhash, 1, rbind, &return_ok, NULL,
-             MYSQL_TYPE_BLOB, key, hashSize2, &hashSize2, MYSQL_TYPE_BLOB,
-             vhash, hashSize2, &hashSize2, -1);
+            plugin->count_entry_by_hash_and_vhash, 1, cbind, &return_ok, NULL,
+             MYSQL_TYPE_BLOB, key, hashSize, &hashSize, MYSQL_TYPE_BLOB,
+             vhash, hashSize, &hashSize, -1);
 
         }
       else
@@ -1431,126 +1594,46 @@ mysql_plugin_get (void *cls,
           ret =
             prepared_statement_run_select (plugin,
                                           plugin->count_entry_by_hash,
-                                          1, rbind, &return_ok,
+                                          1, cbind, &return_ok,
                                           NULL, MYSQL_TYPE_BLOB,
-                                          key, hashSize2,
-                                          &hashSize2, -1);
+                                          key, hashSize,
+                                          &hashSize, -1);
         }
     }
-  if ((ret != GNUNET_OK) || (-1 == total))
-    return;
-  if (total == 0)
-    return;
-
-  last_vkey = 0;
-  count = 0;
-  off = GNUNET_CRYPTO_random_u32 (GNUNET_CRYPTO_QUALITY_WEAK, total);
-
-  memset (rbind, 0, sizeof (rbind));
-  rbind[0].buffer_type = MYSQL_TYPE_LONG;
-  rbind[0].buffer = &size;
-  rbind[0].is_unsigned = GNUNET_YES;
-  rbind[1].buffer_type = MYSQL_TYPE_LONG;
-  rbind[1].buffer = &rtype;
-  rbind[1].is_unsigned = GNUNET_YES;
-  rbind[2].buffer_type = MYSQL_TYPE_LONG;
-  rbind[2].buffer = &prio;
-  rbind[2].is_unsigned = GNUNET_YES;
-  rbind[3].buffer_type = MYSQL_TYPE_LONG;
-  rbind[3].buffer = &level;
-  rbind[3].is_unsigned = GNUNET_YES;
-  rbind[4].buffer_type = MYSQL_TYPE_LONGLONG;
-  rbind[4].buffer = &expiration;
-  rbind[4].is_unsigned = GNUNET_YES;
-  rbind[5].buffer_type = MYSQL_TYPE_BLOB;
-  rbind[5].buffer = (void*) key;
-  rbind[5].buffer_length = hashSize;
-  rbind[5].length = &hashSize;
-  rbind[6].buffer_type = MYSQL_TYPE_LONGLONG;
-  rbind[6].buffer = &vkey;
-  rbind[6].is_unsigned = GNUNET_YES;
-  while (1)
+  if ((ret != GNUNET_OK) || (0 >= total))
     {
-      if (count == 0)
-        limit_off = off;
-      else
-        limit_off = 0;
-      if (type != 0)
-        {
-          if (vhash != NULL)
-            {
-              ret =
-                prepared_statement_run_select
-                (plugin,
-                plugin->select_entry_by_hash_vhash_and_type, 7, rbind, &return_ok,
-                 NULL, MYSQL_TYPE_BLOB, key, hashSize, &hashSize,
-                 MYSQL_TYPE_BLOB, vhash, hashSize2, &hashSize2,
-                 MYSQL_TYPE_LONGLONG, &last_vkey, GNUNET_YES, MYSQL_TYPE_LONG,
-                 &type, GNUNET_YES, MYSQL_TYPE_LONG, &limit_off, GNUNET_YES,
-                 -1);
-            }
-          else
-            {
-              ret =
-                prepared_statement_run_select
-                (plugin,
-                plugin->select_entry_by_hash_and_type, 7, rbind, &return_ok, NULL,
-                 MYSQL_TYPE_BLOB, key, hashSize, &hashSize,
-                 MYSQL_TYPE_LONGLONG, &last_vkey, GNUNET_YES, MYSQL_TYPE_LONG,
-                 &type, GNUNET_YES, MYSQL_TYPE_LONG, &limit_off, GNUNET_YES,
-                 -1);
-            }
-        }
-      else
-        {
-          if (vhash != NULL)
-            {
-              ret =
-                prepared_statement_run_select
-                (plugin,
-                plugin->select_entry_by_hash_and_vhash, 7, rbind, &return_ok, NULL,
-                 MYSQL_TYPE_BLOB, key, hashSize, &hashSize, MYSQL_TYPE_BLOB,
-                 vhash, hashSize2, &hashSize2, MYSQL_TYPE_LONGLONG,
-                 &last_vkey, GNUNET_YES, MYSQL_TYPE_LONG, &limit_off,
-                 GNUNET_YES, -1);
-            }
-          else
-            {
-              ret =
-                prepared_statement_run_select
-                (plugin,
-                plugin->select_entry_by_hash, 7, rbind, &return_ok, NULL,
-                 MYSQL_TYPE_BLOB, key, hashSize, &hashSize,
-                 MYSQL_TYPE_LONGLONG, &last_vkey, GNUNET_YES, MYSQL_TYPE_LONG,
-                 &limit_off, GNUNET_YES, -1);
-            }
-        }
-      if (ret != GNUNET_OK)
-        break;
-      last_vkey = vkey;
-#if FIXME
-      datum = assembleDatum (rbind);
-      if (datum == NULL)
-        continue;
-      count++;
-      ret = iter (iter_cls, key, datum, vkey);
+      iter (iter_cls, 
+           NULL, NULL, 0, NULL, 0, 0, 0, 
+           GNUNET_TIME_UNIT_ZERO_ABS, 0);
+      return;
+    }
+#if DEBUG_MYSQL
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Iterating over %lld results for GET `%s'\n",
+             total,
+             GNUNET_h2s (key));
 #endif
-      ret = GNUNET_SYSERR;
-      if (ret == GNUNET_SYSERR)
-        {
-          break;
-        }
-      if (ret == GNUNET_NO)
-        {
-          do_delete_value (plugin, vkey);
-          do_delete_entry_by_vkey (plugin, vkey);
-          plugin->content_size -= size;
-        }
-      if (count + off == total)
-        last_vkey = 0;          /* back to start */
-      if (count == total)
-        break;
+  gc = GNUNET_malloc (sizeof (struct GetContext));
+  gc->key = *key;
+  if (vhash != NULL)
+    {
+      gc->have_vhash = GNUNET_YES;
+      gc->vhash = *vhash;
     }
+  gc->total = total;
+  gc->off = GNUNET_CRYPTO_random_u32 (GNUNET_CRYPTO_QUALITY_WEAK, total);
+  
+
+  nrc = GNUNET_malloc (sizeof (struct NextRequestClosure));
+  nrc->plugin = plugin;
+  nrc->type = type;  
+  nrc->iter_select = -1;
+  nrc->dviter = iter;
+  nrc->dviter_cls = iter_cls;
+  nrc->prep = &get_statement_prepare;
+  nrc->prep_cls = gc;
+  nrc->last_vkey = 0;
+  mysql_plugin_next_request (nrc, GNUNET_NO);
 }
 
 
@@ -1586,22 +1669,38 @@ mysql_plugin_update (void *cls,
 {
   struct Plugin *plugin = cls;
   unsigned long long vkey = uid;
+  unsigned long long lexpire = expire.value;
+  int ret;
 
-  return prepared_statement_run (plugin,
-                                plugin->update_entry,
-                                NULL,
-                                MYSQL_TYPE_LONG,
-                                &delta,
-                                GNUNET_NO,
-                                MYSQL_TYPE_LONGLONG,
-                                &expire.value,
-                                GNUNET_YES,
-                                MYSQL_TYPE_LONGLONG,
-                                &expire.value,
-                                GNUNET_YES,
-                                MYSQL_TYPE_LONGLONG,
-                                &vkey,
-                                GNUNET_YES, -1);
+#if DEBUG_MYSQL
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Updating value %llu adding %d to priority and maxing exp at %llu\n",
+             vkey,
+             delta,
+             lexpire);
+#endif
+  ret = prepared_statement_run (plugin,
+                               plugin->update_entry,
+                               NULL,
+                               MYSQL_TYPE_LONG,
+                               &delta,
+                               GNUNET_NO,
+                               MYSQL_TYPE_LONGLONG,
+                               &lexpire,
+                               GNUNET_YES,
+                               MYSQL_TYPE_LONGLONG,
+                               &lexpire,
+                               GNUNET_YES,
+                               MYSQL_TYPE_LONGLONG,
+                               &vkey,
+                               GNUNET_YES, -1);
+  if (ret != GNUNET_OK)
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                 "Failed to update value %llu\n",
+                 vkey);
+    }
+  return ret;
 }
 
 
@@ -1640,8 +1739,8 @@ mysql_plugin_iter_zero_anonymity (void *cls,
  */
 static void
 mysql_plugin_iter_ascending_expiration (void *cls,
-                                          enum GNUNET_BLOCK_Type type,
-                                          PluginIterator iter,
+                                       enum GNUNET_BLOCK_Type type,
+                                       PluginIterator iter,
                                        void *iter_cls)
 {
   struct Plugin *plugin = cls;
@@ -1702,7 +1801,7 @@ mysql_plugin_drop (void *cls)
   struct Plugin *plugin = cls;
 
   if ((GNUNET_OK != run_statement (plugin,
-                                  "DROP TABLE gn080")) ||
+                                  "DROP TABLE gn090")) ||
       (GNUNET_OK != run_statement (plugin,
                                   "DROP TABLE gn072")))
     return;                     /* error */
@@ -1735,8 +1834,7 @@ libgnunet_plugin_datastore_mysql_init (void *cls)
     }
 #define MRUNS(a) (GNUNET_OK != run_statement (plugin, a) )
 #define PINIT(a,b) (NULL == (a = prepared_statement_create(plugin, b)))
-  if (MRUNS ("CREATE TABLE IF NOT EXISTS gn080 ("
-             " size INT(11) UNSIGNED NOT NULL DEFAULT 0,"
+  if (MRUNS ("CREATE TABLE IF NOT EXISTS gn090 ("
              " type INT(11) UNSIGNED NOT NULL DEFAULT 0,"
              " prio INT(11) UNSIGNED NOT NULL DEFAULT 0,"
              " anonLevel INT(11) UNSIGNED NOT NULL DEFAULT 0,"
@@ -1821,6 +1919,7 @@ libgnunet_plugin_datastore_mysql_done (void *cls)
       GNUNET_SCHEDULER_cancel (plugin->env->sched,
                               plugin->next_task);
       plugin->next_task = GNUNET_SCHEDULER_NO_TASK;
+      plugin->next_task_nc->prep (plugin->next_task_nc->prep_cls, NULL);
       GNUNET_free (plugin->next_task_nc);
       plugin->next_task_nc = NULL;
     }