global reindent, now with uncrustify hook enabled
[oweals/gnunet.git] / src / credential / plugin_rest_credential.c
index 59022e794457f9e4a4c52ad6165ad96c9011d853..513ddfff9e4ef47ceb515515efe47e41591acd45 100644 (file)
@@ -2,24 +2,24 @@
    This file is part of GNUnet.
    Copyright (C) 2012-2016 GNUnet e.V.
 
-   GNUnet is free software; you can redistribute it and/or modify
-   it under the terms of the GNU General Public License as published
-   by the Free Software Foundation; either version 3, or (at your
-   option) any later version.
+   GNUnet is free software: you can redistribute it and/or modify it
+   under the terms of the GNU Affero General Public License as published
+   by the Free Software Foundation, either version 3 of the License,
+   or (at your option) any later version.
 
    GNUnet is distributed in the hope that it will be useful, but
    WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   General Public License for more details.
+   Affero General Public License for more details.
 
-   You should have received a copy of the GNU General Public License
-   along with GNUnet; see the file COPYING.  If not, write to the
-   Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
-   Boston, MA 02110-1301, USA.
  */
+   You should have received a copy of the GNU Affero General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+     SPDX-License-Identifier: AGPL3.0-or-later
+ */
 /**
  * @author Martin Schanzenbach
- * @file gns/plugin_rest_credential.c
+ * @file credential/plugin_rest_credential.c
  * @brief GNUnet CREDENTIAL REST plugin
  *
  */
@@ -109,7 +109,7 @@ struct RequestHandle
   /**
    * ID of a task associated with the resolution process.
    */
-  struct GNUNET_SCHEDULER_Task * timeout_task;
+  struct GNUNET_SCHEDULER_Task *timeout_task;
 
   /**
    * The root of the received JSON or NULL
@@ -155,7 +155,6 @@ struct RequestHandle
    * Timeout
    */
   struct GNUNET_TIME_Relative timeout;
-
 };
 
 
@@ -177,7 +176,7 @@ cleanup_handle (struct RequestHandle *handle)
   if (NULL != handle->subject_attr)
     GNUNET_free (handle->subject_attr);
   if (NULL != handle->verify_request)
-    GNUNET_CREDENTIAL_verify_cancel (handle->verify_request);
+    GNUNET_CREDENTIAL_request_cancel (handle->verify_request);
   if (NULL != handle->credential)
     GNUNET_CREDENTIAL_disconnect (handle->credential);
   if (NULL != handle->id_op)
@@ -194,12 +193,6 @@ cleanup_handle (struct RequestHandle *handle)
 }
 
 
-/**
- * Task run on shutdown.  Cleans up everything.
- *
- * @param cls unused
- * @param tc scheduler context
- */
 static void
 do_error (void *cls)
 {
@@ -213,24 +206,29 @@ do_error (void *cls)
 
 /**
  * Attribute delegation to JSON
- * @param attr the attribute
+ *
+ * @param delegation_chain_entry the DSE
  * @return JSON, NULL if failed
  */
 static json_t*
-attribute_delegation_to_json (struct GNUNET_CREDENTIAL_Delegation *delegation_chain_entry)
+attribute_delegation_to_json (struct
+                              GNUNET_CREDENTIAL_Delegation *
+                              delegation_chain_entry)
 {
   char *subject;
   char *issuer;
   json_t *attr_obj;
 
-  issuer = GNUNET_CRYPTO_ecdsa_public_key_to_string (&delegation_chain_entry->issuer_key);
+  issuer = GNUNET_CRYPTO_ecdsa_public_key_to_string (
+    &delegation_chain_entry->issuer_key);
   if (NULL == issuer)
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Issuer in delegation malformed\n");
     return NULL;
   }
-  subject = GNUNET_CRYPTO_ecdsa_public_key_to_string (&delegation_chain_entry->subject_key);
+  subject = GNUNET_CRYPTO_ecdsa_public_key_to_string (
+    &delegation_chain_entry->subject_key);
   if (NULL == subject)
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
@@ -240,7 +238,7 @@ attribute_delegation_to_json (struct GNUNET_CREDENTIAL_Delegation *delegation_ch
   }
   attr_obj = json_object ();
 
-    json_object_set_new (attr_obj, "issuer", json_string (issuer));
+  json_object_set_new (attr_obj, "issuer", json_string (issuer));
   json_object_set_new (attr_obj, "issuer_attribute",
                        json_string (delegation_chain_entry->issuer_attribute));
 
@@ -248,7 +246,8 @@ attribute_delegation_to_json (struct GNUNET_CREDENTIAL_Delegation *delegation_ch
   if (0 < delegation_chain_entry->subject_attribute_len)
   {
     json_object_set_new (attr_obj, "subject_attribute",
-                         json_string (delegation_chain_entry->subject_attribute));
+                         json_string (
+                           delegation_chain_entry->subject_attribute));
   }
   GNUNET_free (issuer);
   GNUNET_free (subject);
@@ -257,6 +256,7 @@ attribute_delegation_to_json (struct GNUNET_CREDENTIAL_Delegation *delegation_ch
 
 /**
  * JSONAPI resource to Credential
+ *
  * @param res the JSONAPI resource
  * @return the resulting credential, NULL if failed
  */
@@ -275,7 +275,7 @@ json_to_credential (json_t *res)
     return NULL;
   }
   attribute = json_string_value (tmp);
-  cred = GNUNET_malloc (sizeof (struct GNUNET_CREDENTIAL_Credential)
+  cred = GNUNET_malloc (sizeof(struct GNUNET_CREDENTIAL_Credential)
                         + strlen (attribute));
   cred->issuer_attribute = attribute;
   cred->issuer_attribute_len = strlen (attribute);
@@ -286,8 +286,8 @@ json_to_credential (json_t *res)
     return NULL;
   }
 
-  GNUNET_CRYPTO_ecdsa_public_key_from_string (json_string_value(tmp),
-                                              strlen (json_string_value(tmp)),
+  GNUNET_CRYPTO_ecdsa_public_key_from_string (json_string_value (tmp),
+                                              strlen (json_string_value (tmp)),
                                               &cred->issuer_key);
   tmp = json_object_get (res, "subject");
   if (0 == json_is_string (tmp))
@@ -295,8 +295,8 @@ json_to_credential (json_t *res)
     GNUNET_free (cred);
     return NULL;
   }
-  GNUNET_CRYPTO_ecdsa_public_key_from_string (json_string_value(tmp),
-                                              strlen (json_string_value(tmp)),
+  GNUNET_CRYPTO_ecdsa_public_key_from_string (json_string_value (tmp),
+                                              strlen (json_string_value (tmp)),
                                               &cred->subject_key);
 
   tmp = json_object_get (res, "signature");
@@ -308,25 +308,26 @@ json_to_credential (json_t *res)
   signature = json_string_value (tmp);
   GNUNET_STRINGS_base64_decode (signature,
                                 strlen (signature),
-                                (char**)&sig);
+                                (char**) &sig);
   GNUNET_memcpy (&cred->signature,
                  sig,
-                 sizeof (struct GNUNET_CRYPTO_EcdsaSignature));
+                 sizeof(struct GNUNET_CRYPTO_EcdsaSignature));
   GNUNET_free (sig);
+
   tmp = json_object_get (res, "expiration");
   if (0 == json_is_integer (tmp))
   {
     GNUNET_free (cred);
     return NULL;
   }
-  cred->expiration.abs_value_us = json_integer_value (tmp); 
+  cred->expiration.abs_value_us = json_integer_value (tmp);
   return cred;
 }
 
 
 /**
  * Credential to JSON
+ *
  * @param cred the credential
  * @return the resulting json, NULL if failed
  */
@@ -345,7 +346,7 @@ credential_to_json (struct GNUNET_CREDENTIAL_Credential *cred)
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Issuer in credential malformed\n");
     return NULL;
-  }  
+  }
   subject = GNUNET_CRYPTO_ecdsa_public_key_to_string (&cred->subject_key);
   if (NULL == subject)
   {
@@ -354,38 +355,32 @@ credential_to_json (struct GNUNET_CREDENTIAL_Credential *cred)
     GNUNET_free (issuer);
     return NULL;
   }
-  GNUNET_STRINGS_base64_encode ((char*)&cred->signature,
-                                sizeof (struct GNUNET_CRYPTO_EcdsaSignature),
+  GNUNET_STRINGS_base64_encode ((char*) &cred->signature,
+                                sizeof(struct GNUNET_CRYPTO_EcdsaSignature),
                                 &signature);
-  memcpy (attribute,
-          cred->issuer_attribute,
-          cred->issuer_attribute_len);
+  GNUNET_memcpy (attribute,
+                 cred->issuer_attribute,
+                 cred->issuer_attribute_len);
   attribute[cred->issuer_attribute_len] = '\0';
   cred_obj = json_object ();
   json_object_set_new (cred_obj, "issuer", json_string (issuer));
   json_object_set_new (cred_obj, "subject", json_string (subject));
   json_object_set_new (cred_obj, "attribute", json_string (attribute));
   json_object_set_new (cred_obj, "signature", json_string (signature));
-  json_object_set_new (cred_obj, "expiration", json_integer (cred->expiration.abs_value_us));
+  json_object_set_new (cred_obj, "expiration", json_integer (
+                         cred->expiration.abs_value_us));
   GNUNET_free (issuer);
   GNUNET_free (subject);
   GNUNET_free (signature);
   return cred_obj;
 }
 
-/**
- * Function called with the result of a Credential lookup.
- *
- * @param cls the 'const char *' name that was resolved
- * @param cd_count number of records returned
- * @param cd array of @a cd_count records with the results
- */
 static void
 handle_collect_response (void *cls,
-                        unsigned int d_count,
-                        struct GNUNET_CREDENTIAL_Delegation *delegation_chain,
-                        unsigned int c_count,
-                        struct GNUNET_CREDENTIAL_Credential *cred)
+                         unsigned int d_count,
+                         struct GNUNET_CREDENTIAL_Delegation *delegation_chain,
+                         unsigned int c_count,
+                         struct GNUNET_CREDENTIAL_Credential *cred)
 {
   struct RequestHandle *handle = cls;
   struct MHD_Response *resp;
@@ -399,7 +394,8 @@ handle_collect_response (void *cls,
   uint32_t i;
 
   handle->verify_request = NULL;
-  if (NULL == cred) {
+  if (NULL == cred)
+  {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Verify failed.\n");
     handle->response_code = MHD_HTTP_NOT_FOUND;
@@ -419,11 +415,12 @@ handle_collect_response (void *cls,
                    handle->issuer_attr);
   GNUNET_free (issuer);
   json_document = GNUNET_JSONAPI_document_new ();
-  json_resource = GNUNET_JSONAPI_resource_new (GNUNET_REST_JSONAPI_CREDENTIAL_TYPEINFO,
-                                               id);
+  json_resource = GNUNET_JSONAPI_resource_new (
+    GNUNET_REST_JSONAPI_CREDENTIAL_TYPEINFO,
+    id);
   GNUNET_free (id);
   cred_array = json_array ();
-  for (i=0;i<c_count;i++)
+  for (i = 0; i < c_count; i++)
   {
     cred_obj = credential_to_json (&cred[i]);
     json_array_append_new (cred_array, cred_obj);
@@ -439,7 +436,7 @@ handle_collect_response (void *cls,
   json_decref (cred_array);
   GNUNET_JSONAPI_document_delete (json_document);
   resp = GNUNET_REST_create_response (result);
-  GNUNET_free(result);
+  GNUNET_free (result);
   handle->proc (handle->proc_cls, resp, MHD_HTTP_OK);
   cleanup_handle (handle);
 }
@@ -450,6 +447,7 @@ subject_ego_lookup (void *cls,
 {
   struct RequestHandle *handle = cls;
   const struct GNUNET_CRYPTO_EcdsaPrivateKey *sub_key;
+
   handle->ego_lookup = NULL;
 
   if (NULL == ego)
@@ -470,13 +468,6 @@ subject_ego_lookup (void *cls,
 
 
 
-/**
- * Function called with the result of a Credential lookup.
- *
- * @param cls the 'const char *' name that was resolved
- * @param cd_count number of records returned
- * @param cd array of @a cd_count records with the results
- */
 static void
 handle_verify_response (void *cls,
                         unsigned int d_count,
@@ -484,7 +475,6 @@ handle_verify_response (void *cls,
                         unsigned int c_count,
                         struct GNUNET_CREDENTIAL_Credential *cred)
 {
-
   struct RequestHandle *handle = cls;
   struct MHD_Response *resp;
   struct GNUNET_JSONAPI_Document *json_document;
@@ -499,7 +489,8 @@ handle_verify_response (void *cls,
   uint32_t i;
 
   handle->verify_request = NULL;
-  if (NULL == cred) {
+  if (NULL == cred)
+  {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Verify failed.\n");
     handle->response_code = MHD_HTTP_NOT_FOUND;
@@ -519,8 +510,9 @@ handle_verify_response (void *cls,
                    handle->issuer_attr);
   GNUNET_free (issuer);
   json_document = GNUNET_JSONAPI_document_new ();
-  json_resource = GNUNET_JSONAPI_resource_new (GNUNET_REST_JSONAPI_CREDENTIAL_TYPEINFO,
-                                               id);
+  json_resource = GNUNET_JSONAPI_resource_new (
+    GNUNET_REST_JSONAPI_CREDENTIAL_TYPEINFO,
+    id);
   GNUNET_free (id);
   attr_array = json_array ();
   for (i = 0; i < d_count; i++)
@@ -529,7 +521,7 @@ handle_verify_response (void *cls,
     json_array_append_new (attr_array, attr_obj);
   }
   cred_array = json_array ();
-  for (i=0;i<c_count;i++)
+  for (i = 0; i < c_count; i++)
   {
     cred_obj = credential_to_json (&cred[i]);
     json_array_append_new (cred_array, cred_obj);
@@ -556,7 +548,7 @@ handle_verify_response (void *cls,
 
 static void
 collect_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
-                   const char* url,
+                   const char*url,
                    void *cls)
 {
   struct RequestHandle *handle = cls;
@@ -581,19 +573,19 @@ collect_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
   GNUNET_CRYPTO_hash (GNUNET_REST_JSONAPI_CREDENTIAL_ISSUER_ATTR,
                       strlen (GNUNET_REST_JSONAPI_CREDENTIAL_ISSUER_ATTR),
                       &key);
-  if ( GNUNET_NO ==
-       GNUNET_CONTAINER_multihashmap_contains (conndata_handle->url_param_map,
-                                               &key) )
+  if (GNUNET_NO ==
+      GNUNET_CONTAINER_multihashmap_contains (conndata_handle->url_param_map,
+                                              &key))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Missing issuer attribute\n");
-    GNUNET_SCHEDULER_add_now (&do_error, handle); 
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
   tmp = GNUNET_CONTAINER_multihashmap_get (conndata_handle->url_param_map,
                                            &key);
   entity_attr = GNUNET_strdup (tmp);
-  tmp = strtok(entity_attr, ".");
+  tmp = strtok (entity_attr, ".");
   if (NULL == tmp)
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
@@ -602,7 +594,7 @@ collect_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
     GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
-  if (GNUNET_OK != 
+  if (GNUNET_OK !=
       GNUNET_CRYPTO_ecdsa_public_key_from_string (tmp,
                                                   strlen (tmp),
                                                   &handle->issuer_key))
@@ -613,7 +605,7 @@ collect_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
     GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
-  tmp = strtok (NULL, "."); //Issuer attribute
+  tmp = strtok (NULL, ".");  // Issuer attribute
   if (NULL == tmp)
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
@@ -628,13 +620,12 @@ collect_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
   GNUNET_CRYPTO_hash (GNUNET_REST_JSONAPI_CREDENTIAL_SUBJECT_EGO,
                       strlen (GNUNET_REST_JSONAPI_CREDENTIAL_SUBJECT_EGO),
                       &key);
-  if ( GNUNET_NO ==
-       GNUNET_CONTAINER_multihashmap_contains (conndata_handle->url_param_map,
-                                               &key) )
+  if (GNUNET_NO ==
+      GNUNET_CONTAINER_multihashmap_contains (conndata_handle->url_param_map,
+                                              &key))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Missing subject\n");
-    GNUNET_free (entity_attr);
     GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
@@ -644,8 +635,7 @@ collect_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Malformed subject\n");
-    GNUNET_free (entity_attr);
-    GNUNET_SCHEDULER_add_now (&do_error, handle); 
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
   handle->ego_lookup = GNUNET_IDENTITY_ego_lookup (cfg,
@@ -658,7 +648,7 @@ collect_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
 
 static void
 verify_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
-                  const char* url,
+                  const char*url,
                   void *cls)
 {
   struct RequestHandle *handle = cls;
@@ -692,19 +682,19 @@ verify_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
   GNUNET_CRYPTO_hash (GNUNET_REST_JSONAPI_CREDENTIAL_ISSUER_ATTR,
                       strlen (GNUNET_REST_JSONAPI_CREDENTIAL_ISSUER_ATTR),
                       &key);
-  if ( GNUNET_NO ==
-       GNUNET_CONTAINER_multihashmap_contains (conndata_handle->url_param_map,
-                                               &key) )
+  if (GNUNET_NO ==
+      GNUNET_CONTAINER_multihashmap_contains (conndata_handle->url_param_map,
+                                              &key))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Missing issuer attribute\n");
-    GNUNET_SCHEDULER_add_now (&do_error, handle); 
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
   tmp = GNUNET_CONTAINER_multihashmap_get (conndata_handle->url_param_map,
                                            &key);
   entity_attr = GNUNET_strdup (tmp);
-  tmp = strtok(entity_attr, ".");
+  tmp = strtok (entity_attr, ".");
   if (NULL == tmp)
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
@@ -713,7 +703,7 @@ verify_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
     GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
-  if (GNUNET_OK != 
+  if (GNUNET_OK !=
       GNUNET_CRYPTO_ecdsa_public_key_from_string (tmp,
                                                   strlen (tmp),
                                                   &handle->issuer_key))
@@ -724,7 +714,7 @@ verify_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
     GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
-  tmp = strtok (NULL, "."); //Issuer attribute
+  tmp = strtok (NULL, ".");  // Issuer attribute
   if (NULL == tmp)
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
@@ -739,13 +729,12 @@ verify_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
   GNUNET_CRYPTO_hash (GNUNET_REST_JSONAPI_CREDENTIAL_SUBJECT_KEY,
                       strlen (GNUNET_REST_JSONAPI_CREDENTIAL_SUBJECT_KEY),
                       &key);
-  if ( GNUNET_NO ==
-       GNUNET_CONTAINER_multihashmap_contains (conndata_handle->url_param_map,
-                                               &key) )
+  if (GNUNET_NO ==
+      GNUNET_CONTAINER_multihashmap_contains (conndata_handle->url_param_map,
+                                              &key))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Missing subject key\n");
-    GNUNET_free (entity_attr);
     GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
@@ -755,17 +744,16 @@ verify_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Malformed subject\n");
-    GNUNET_free (entity_attr);
-    GNUNET_SCHEDULER_add_now (&do_error, handle); 
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
   if (GNUNET_OK !=
       GNUNET_CRYPTO_ecdsa_public_key_from_string (tmp,
                                                   strlen (tmp),
-                                                  &handle->subject_key)) {
+                                                  &handle->subject_key))
+  {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Malformed subject key\n");
-    GNUNET_free (entity_attr);
     GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
@@ -780,9 +768,9 @@ verify_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
 
   struct GNUNET_JSON_Specification docspec[] = {
     GNUNET_JSON_spec_jsonapi_document (&json_obj),
-    GNUNET_JSON_spec_end()
+    GNUNET_JSON_spec_end ()
   };
-  char term_data[handle->rest_handle->data_size+1];
+  char term_data[handle->rest_handle->data_size + 1];
   term_data[handle->rest_handle->data_size] = '\0';
   credential_count = 0;
   GNUNET_memcpy (term_data,
@@ -803,11 +791,11 @@ verify_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
     return;
   }
 
-  resource_count = GNUNET_JSONAPI_document_resource_count(json_obj);
+  resource_count = GNUNET_JSONAPI_document_resource_count (json_obj);
   GNUNET_assert (1 == resource_count);
-  res = (GNUNET_JSONAPI_document_get_resource(json_obj, 0));
-  if (GNUNET_NO == GNUNET_JSONAPI_resource_check_type(res,
-                                                      GNUNET_REST_JSONAPI_CREDENTIAL_TYPEINFO))
+  res = (GNUNET_JSONAPI_document_get_resource (json_obj, 0));
+  if (GNUNET_NO == GNUNET_JSONAPI_resource_check_type (res,
+                                                       GNUNET_REST_JSONAPI_CREDENTIAL_TYPEINFO))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Resource not a credential!\n");
@@ -823,10 +811,10 @@ verify_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
 
   GNUNET_assert (json_is_array (cred_json));
 
-  credential_count = json_array_size(cred_json);
+  credential_count = json_array_size (cred_json);
 
   struct GNUNET_CREDENTIAL_Credential credentials[credential_count];
-  for (i=0;i<credential_count;i++)
+  for (i = 0; i < credential_count; i++)
   {
     cred = json_to_credential (json_array_get (cred_json, i));
     if (NULL == cred)
@@ -837,11 +825,11 @@ verify_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
     }
     GNUNET_memcpy (&credentials[i],
                    cred,
-                   sizeof (struct GNUNET_CREDENTIAL_Credential));
+                   sizeof(struct GNUNET_CREDENTIAL_Credential));
     credentials[i].issuer_attribute = GNUNET_strdup (cred->issuer_attribute);
     GNUNET_free (cred);
   }
-  GNUNET_JSONAPI_document_delete(json_obj);
+  GNUNET_JSONAPI_document_delete (json_obj);
   handle->verify_request = GNUNET_CREDENTIAL_verify (handle->credential,
                                                      &handle->issuer_key,
                                                      handle->issuer_attr,
@@ -850,9 +838,8 @@ verify_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
                                                      credentials,
                                                      &handle_verify_response,
                                                      handle);
-  for (i=0;i<credential_count;i++)
-    GNUNET_free ((char*)credentials[i].issuer_attribute);
-
+  for (i = 0; i < credential_count; i++)
+    GNUNET_free ((char*) credentials[i].issuer_attribute);
 }
 
 void
@@ -875,30 +862,35 @@ send_cred_response (struct RequestHandle *handle,
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Subject malformed\n");
+    GNUNET_free (issuer);
     return;
   }
   GNUNET_asprintf (&id,
                    "%s.%s",
                    issuer,
-                   (char*)&cred[1]);
+                   (char*) &cred[1]);
   subject = GNUNET_CRYPTO_ecdsa_public_key_to_string (&cred->subject_key);
   if (NULL == subject)
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Subject malformed\n");
+    GNUNET_free (id);
+    GNUNET_free (issuer);
     return;
   }
-  GNUNET_STRINGS_base64_encode ((char*)&cred->signature,
-                                sizeof (struct GNUNET_CRYPTO_EcdsaSignature),
+  GNUNET_STRINGS_base64_encode ((char*) &cred->signature,
+                                sizeof(struct GNUNET_CRYPTO_EcdsaSignature),
                                 &signature);
   json_document = GNUNET_JSONAPI_document_new ();
-  json_resource = GNUNET_JSONAPI_resource_new (GNUNET_REST_JSONAPI_CREDENTIAL_TYPEINFO,
-                                               id);
+  json_resource = GNUNET_JSONAPI_resource_new (
+    GNUNET_REST_JSONAPI_CREDENTIAL_TYPEINFO,
+    id);
   GNUNET_free (id);
-  cred_obj = json_object();
+  cred_obj = json_object ();
   json_object_set_new (cred_obj, "issuer", json_string (issuer));
   json_object_set_new (cred_obj, "subject", json_string (subject));
-  json_object_set_new (cred_obj, "expiration", json_integer( cred->expiration.abs_value_us));
+  json_object_set_new (cred_obj, "expiration", json_integer (
+                         cred->expiration.abs_value_us));
   json_object_set_new (cred_obj, "signature", json_string (signature));
   GNUNET_JSONAPI_resource_add_attr (json_resource,
                                     GNUNET_REST_JSONAPI_CREDENTIAL,
@@ -931,8 +923,8 @@ get_cred_issuer_cb (void *cls,
   const struct GNUNET_CRYPTO_EcdsaPrivateKey *issuer_key;
   struct GNUNET_HashCode key;
   struct GNUNET_CREDENTIAL_Credential *cred;
-  char* expiration_str;
-  char* tmp;
+  char*expiration_str;
+  char*tmp;
 
   handle->id_op = NULL;
 
@@ -959,50 +951,63 @@ get_cred_issuer_cb (void *cls,
   GNUNET_CRYPTO_hash (GNUNET_REST_JSONAPI_CREDENTIAL_EXPIRATION,
                       strlen (GNUNET_REST_JSONAPI_CREDENTIAL_EXPIRATION),
                       &key);
-  if ( GNUNET_NO ==
-       GNUNET_CONTAINER_multihashmap_contains (handle->rest_handle->url_param_map,
-                                               &key) )
+  if (GNUNET_NO ==
+      GNUNET_CONTAINER_multihashmap_contains (
+        handle->rest_handle->url_param_map,
+        &key))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Missing expiration\n");
-    GNUNET_SCHEDULER_add_now (&do_error, handle); 
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
+    return;
+  }
+  expiration_str = GNUNET_CONTAINER_multihashmap_get (
+    handle->rest_handle->url_param_map,
+    &key);
+  if (NULL == expiration_str)
+  {
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                "Expiration malformed\n");
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
-  expiration_str = GNUNET_CONTAINER_multihashmap_get (handle->rest_handle->url_param_map,
-                                                      &key);
+
   if (GNUNET_OK == GNUNET_STRINGS_fancy_time_to_relative (expiration_str,
                                                           &etime_rel))
   {
     etime_abs = GNUNET_TIME_relative_to_absolute (etime_rel);
-  } else if (GNUNET_OK != GNUNET_STRINGS_fancy_time_to_absolute (expiration_str,
-                                                                 &etime_abs))
+  }
+  else if (GNUNET_OK != GNUNET_STRINGS_fancy_time_to_absolute (expiration_str,
+                                                               &etime_abs))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Malformed expiration: %s\n", expiration_str);
-    GNUNET_SCHEDULER_add_now (&do_error, handle); 
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
   GNUNET_CRYPTO_hash (GNUNET_REST_JSONAPI_CREDENTIAL_ISSUER_ATTR,
                       strlen (GNUNET_REST_JSONAPI_CREDENTIAL_ISSUER_ATTR),
                       &key);
-  if ( GNUNET_NO ==
-       GNUNET_CONTAINER_multihashmap_contains (handle->rest_handle->url_param_map,
-                                               &key) )
+  if (GNUNET_NO ==
+      GNUNET_CONTAINER_multihashmap_contains (
+        handle->rest_handle->url_param_map,
+        &key))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Missing issuer attribute\n");
-    GNUNET_SCHEDULER_add_now (&do_error, handle); 
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
-  handle->issuer_attr = GNUNET_strdup(GNUNET_CONTAINER_multihashmap_get 
-                                      (handle->rest_handle->url_param_map,
-                                       &key));
+  handle->issuer_attr = GNUNET_strdup (GNUNET_CONTAINER_multihashmap_get
+                                         (handle->rest_handle->url_param_map,
+                                         &key));
   GNUNET_CRYPTO_hash (GNUNET_REST_JSONAPI_CREDENTIAL_SUBJECT_KEY,
                       strlen (GNUNET_REST_JSONAPI_CREDENTIAL_SUBJECT_KEY),
                       &key);
-  if ( GNUNET_NO ==
-       GNUNET_CONTAINER_multihashmap_contains (handle->rest_handle->url_param_map,
-                                               &key) )
+  if (GNUNET_NO ==
+      GNUNET_CONTAINER_multihashmap_contains (
+        handle->rest_handle->url_param_map,
+        &key))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Missing subject\n");
@@ -1015,13 +1020,14 @@ get_cred_issuer_cb (void *cls,
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Malformed subject\n");
-    GNUNET_SCHEDULER_add_now (&do_error, handle); 
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
   if (GNUNET_OK !=
       GNUNET_CRYPTO_ecdsa_public_key_from_string (tmp,
                                                   strlen (tmp),
-                                                  &handle->subject_key)) {
+                                                  &handle->subject_key))
+  {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Malformed subject key\n");
     GNUNET_SCHEDULER_add_now (&do_error, handle);
@@ -1045,7 +1051,7 @@ get_cred_issuer_cb (void *cls,
 
 static void
 issue_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
-                 const char* url,
+                 const char*url,
                  void *cls)
 {
   struct RequestHandle *handle = cls;
@@ -1053,29 +1059,24 @@ issue_cred_cont (struct GNUNET_REST_RequestHandle *conndata_handle,
   handle->identity = GNUNET_IDENTITY_connect (cfg,
                                               NULL,
                                               NULL);
-  handle->id_op = GNUNET_IDENTITY_get(handle->identity,
-                                      "credential-issuer",
-                                      &get_cred_issuer_cb,
-                                      handle);
+  handle->id_op = GNUNET_IDENTITY_get (handle->identity,
+                                       "credential-issuer",
+                                       &get_cred_issuer_cb,
+                                       handle);
   handle->timeout_task = GNUNET_SCHEDULER_add_delayed (handle->timeout,
                                                        &do_error,
                                                        handle);
 }
 
-/**
- * Handle rest request
- *
- * @param handle the lookup handle
- */
 static void
 options_cont (struct GNUNET_REST_RequestHandle *con_handle,
-              const char* url,
+              const char*url,
               void *cls)
 {
   struct MHD_Response *resp;
   struct RequestHandle *handle = cls;
 
-  //For GNS, independent of path return all options
+  // For GNS, independent of path return all options
   resp = GNUNET_REST_create_response (NULL);
   MHD_add_response_header (resp,
                            "Access-Control-Allow-Methods",
@@ -1087,21 +1088,11 @@ options_cont (struct GNUNET_REST_RequestHandle *con_handle,
 }
 
 
-/**
- * Function processing the REST call
- *
- * @param method HTTP method
- * @param url URL of the HTTP request
- * @param data body of the HTTP request (optional)
- * @param data_size length of the body
- * @param proc callback function for the result
- * @param proc_cls closure for callback function
- * @return GNUNET_OK if request accepted
- */
 static void
-rest_credential_process_request(struct GNUNET_REST_RequestHandle *conndata_handle,
-                                GNUNET_REST_ResultProcessor proc,
-                                void *proc_cls)
+rest_credential_process_request (struct
+                                 GNUNET_REST_RequestHandle *conndata_handle,
+                                 GNUNET_REST_ResultProcessor proc,
+                                 void *proc_cls)
 {
   struct RequestHandle *handle = GNUNET_new (struct RequestHandle);
   struct GNUNET_REST_RequestHandlerError err;
@@ -1112,10 +1103,13 @@ rest_credential_process_request(struct GNUNET_REST_RequestHandle *conndata_handl
   handle->rest_handle = conndata_handle;
 
   static const struct GNUNET_REST_RequestHandler handlers[] = {
-    {MHD_HTTP_METHOD_POST, GNUNET_REST_API_NS_CREDENTIAL_VERIFY, &verify_cred_cont},
-    {MHD_HTTP_METHOD_GET, GNUNET_REST_API_NS_CREDENTIAL_COLLECT, &collect_cred_cont},
-    {MHD_HTTP_METHOD_GET, GNUNET_REST_API_NS_CREDENTIAL_ISSUE, &issue_cred_cont},
-    {MHD_HTTP_METHOD_OPTIONS, GNUNET_REST_API_NS_CREDENTIAL, &options_cont},
+    { MHD_HTTP_METHOD_POST, GNUNET_REST_API_NS_CREDENTIAL_VERIFY,
+      &verify_cred_cont },
+    { MHD_HTTP_METHOD_GET, GNUNET_REST_API_NS_CREDENTIAL_COLLECT,
+      &collect_cred_cont },
+    { MHD_HTTP_METHOD_GET, GNUNET_REST_API_NS_CREDENTIAL_ISSUE,
+      &issue_cred_cont },
+    { MHD_HTTP_METHOD_OPTIONS, GNUNET_REST_API_NS_CREDENTIAL, &options_cont },
     GNUNET_REST_HANDLER_END
   };
 
@@ -1140,19 +1134,20 @@ void *
 libgnunet_plugin_rest_credential_init (void *cls)
 {
   static struct Plugin plugin;
+
   cfg = cls;
   struct GNUNET_REST_Plugin *api;
 
   if (NULL != plugin.cfg)
     return NULL;                /* can only initialize once! */
-  memset (&plugin, 0, sizeof (struct Plugin));
+  memset (&plugin, 0, sizeof(struct Plugin));
   plugin.cfg = cfg;
   api = GNUNET_new (struct GNUNET_REST_Plugin);
   api->cls = &plugin;
   api->name = GNUNET_REST_API_NS_CREDENTIAL;
   api->process_request = &rest_credential_process_request;
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
-              _("GNS REST API initialized\n"));
+              _ ("GNS REST API initialized\n"));
   return api;
 }