/*
This file is part of GNUnet.
- (C) 2011 Christian Grothoff (and other contributing authors)
+ Copyright (C) 2011-2014 Christian Grothoff (and other contributing authors)
GNUnet is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published
* @author Matthias Wachs
* @author Christian Grothoff
*/
-#include "plugin_ats_proportional.h"
+#include "platform.h"
+#include "gnunet_statistics_service.h"
+#include "gnunet_ats_plugin.h"
+#include "gnunet_ats_service.h"
+#include "gnunet-service-ats_addresses.h"
+
+#define PROP_STABILITY_FACTOR 1.25
+
#define LOG(kind,...) GNUNET_log_from (kind, "ats-proportional",__VA_ARGS__)
* outbound quota is configured and the bandwidth available in
* these networks is distributed over the addresses. The solver
* first assigns every addresses the minimum amount of bandwidth
- * GNUNET_CONSTANTS_DEFAULT_BW_IN_OUT and then distributes the
+ * #GNUNET_CONSTANTS_DEFAULT_BW_IN_OUT and then distributes the
* remaining bandwidth available according to the preference
* values. For each peer only a single address gets bandwidth
* assigned and only one address marked as active. The most
* solver is when an address switches network it is located
* in. This is common because addresses added by transport's
* validation mechanism are commonly located in
- * GNUNET_ATS_NET_UNSPECIFIED. Addresses in validation are located
+ * #GNUNET_ATS_NET_UNSPECIFIED. Addresses in validation are located
* in this network type and only if a connection is successful on
* return of payload data transport switches to the real network
* the address is located in. When an address changes networks it
* is first of all removed from the old network using the solver
- * API function GAS_proportional_address_delete and the network in
+ * API function #GAS_proportional_address_delete() and the network in
* the address struct is updated. A lookup for the respective new
* proportional network is done and stored in the addresse's
* solver_information field. Next the address is re-added to the
* solver using the solver API function
- * GAS_proportional_address_add. If the address was marked as in
+ * #GAS_proportional_address_add(). If the address was marked as in
* active, the solver checks if bandwidth is available in the
* network and if yes sets the address to active and updates the
* bandwidth distribution in this network. If no bandwidth is
* the best available address. Several checks are done when an
* address is selected. First if this address is currently blocked
* by addresses from being suggested. An address is blocked for the
- * duration of ATS_BLOCKING_DELTA when it is suggested to
+ * duration of #ATS_BLOCKING_DELTA when it is suggested to
* transport. Next it is checked if at least
- * GNUNET_CONSTANTS_DEFAULT_BW_IN_OUT bytes bandwidth is available
+ * #GNUNET_CONSTANTS_DEFAULT_BW_IN_OUT bytes bandwidth is available
* in the addresse's network, because suggesting an address without
* bandwidth does not make sense. This also ensures that all active
* addresses in this network get at least the minimum amount of
*
*/
-#define PREF_AGING_INTERVAL GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 10)
-#define PREF_AGING_FACTOR 0.95
-
-#define DEFAULT_REL_PREFERENCE 1.0
-#define DEFAULT_ABS_PREFERENCE 0.0
-#define MIN_UPDATE_INTERVAL GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 10)
+#define PROPORTIONALITY_FACTOR 2.0
/**
* A handle for the proportional solver
*/
struct GAS_PROPORTIONAL_Handle
{
- struct GNUNET_ATS_PluginEnvironment *env;
/**
- * Statistics handle
+ * Our execution environment.
*/
- struct GNUNET_STATISTICS_Handle *stats;
+ struct GNUNET_ATS_PluginEnvironment *env;
/**
* Hashmap containing all valid addresses
*/
- const struct GNUNET_CONTAINER_MultiPeerMap *addresses;
+ struct GNUNET_CONTAINER_MultiPeerMap *addresses;
/**
* Pending address requests
*/
struct GNUNET_CONTAINER_MultiPeerMap *requests;
- /**
- * Bandwidth changed callback
- */
- GAS_bandwidth_changed_cb bw_changed;
-
- /**
- * Bandwidth changed callback cls
- */
- void *bw_changed_cls;
-
- /**
- * ATS function to get preferences
- */
- GAS_get_preferences get_preferences;
-
- /**
- * Closure for ATS function to get preferences
- */
- void *get_preferences_cls;
-
- /**
- * ATS function to get properties
- */
- GAS_get_properties get_properties;
-
- /**
- * Closure for ATS function to get properties
- */
- void *get_properties_cls;
-
/**
* Bulk lock
*/
*/
unsigned int network_count;
+ /**
+ * Proportionality factor
+ */
+ double prop_factor;
+
+ /**
+ * Stability factor
+ */
+ double stability_factor;
};
/**
/**
* ATS network type
*/
- unsigned int type;
+ enum GNUNET_ATS_Network_Type type;
/**
* Network description
*/
- char *desc;
+ const char *desc;
/**
* Total inbound quota
- *
*/
unsigned long long total_quota_in;
/**
* Total outbound quota
- *
*/
unsigned long long total_quota_out;
*/
char *stat_active;
+ /**
+ * Linked list of addresses in this network: head
+ */
struct AddressWrapper *head;
+
+ /**
+ * Linked list of addresses in this network: tail
+ */
struct AddressWrapper *tail;
};
*/
struct AddressSolverInformation
{
+ /**
+ * Network scope this address is in
+ */
struct Network *network;
/**
* Inbound quota
- *
*/
- unsigned long long calculated_quota_in_NBO;
+ uint32_t calculated_quota_in;
/**
* Outbound quota
- *
*/
- unsigned long long calculated_quota_out_NBO;
+ uint32_t calculated_quota_out;
+ /**
+ * When was this address activated
+ */
+ struct GNUNET_TIME_Absolute activated;
};
struct ATS_Address *addr;
};
+
/**
- * Important solver functions
- * ---------------------------
+ * Function used to unload the plugin.
+ *
+ * @param cls return value from #libgnunet_plugin_ats_proportional_init()
*/
-
-void *
-libgnunet_plugin_ats_proportional_init (void *cls)
-{
- struct GNUNET_ATS_PluginEnvironment *env = cls;
- struct GAS_PROPORTIONAL_Handle *s;
- struct Network * cur;
- char * net_str[GNUNET_ATS_NetworkTypeCount] = GNUNET_ATS_NetworkTypeString;
- int c;
-
- GNUNET_assert (NULL != env);
- GNUNET_assert(NULL != env->cfg);
- GNUNET_assert(NULL != env->stats);
- GNUNET_assert(NULL != env->bandwidth_changed_cb);
- GNUNET_assert(NULL != env->get_preferences);
- GNUNET_assert(NULL != env->get_property);
-
- s = GNUNET_new (struct GAS_PROPORTIONAL_Handle);
- s->env = env;
- env->sf.s_add = &GAS_proportional_address_add;
- env->sf.s_address_update_property = &GAS_proportional_address_property_changed;
- env->sf.s_address_update_session = &GAS_proportional_address_session_changed;
- env->sf.s_address_update_inuse = &GAS_proportional_address_inuse_changed;
- env->sf.s_address_update_network = &GAS_proportional_address_change_network;
- env->sf.s_get = &GAS_proportional_get_preferred_address;
- env->sf.s_get_stop = &GAS_proportional_stop_get_preferred_address;
- env->sf.s_pref = &GAS_proportional_address_change_preference;
- env->sf.s_feedback = &GAS_proportional_address_preference_feedback;
- env->sf.s_del = &GAS_proportional_address_delete;
- env->sf.s_bulk_start = &GAS_proportional_bulk_start;
- env->sf.s_bulk_stop = &GAS_proportional_bulk_stop;
-
- s->stats = (struct GNUNET_STATISTICS_Handle *) env->stats;
- s->bw_changed = env->bandwidth_changed_cb;
- s->bw_changed_cls = env->bw_changed_cb_cls;
- s->get_preferences = env->get_preferences;
- s->get_preferences_cls = env->get_preference_cls;
- s->get_properties = env->get_property;
- s->get_properties_cls = env->get_property_cls;
- s->network_count = env->network_count;
- s->network_entries = GNUNET_malloc (env->network_count * sizeof (struct Network));
-
- /* Init */
- s->active_addresses = 0;
- s->total_addresses = 0;
- s->bulk_lock = GNUNET_NO;
- s->addresses = env->addresses;
- s->requests = GNUNET_CONTAINER_multipeermap_create (10, GNUNET_NO);
-
- for (c = 0; c < env->network_count; c++)
- {
- cur = &s->network_entries[c];
- cur->total_addresses = 0;
- cur->active_addresses = 0;
- cur->type = env->networks[c];
- cur->total_quota_in = env->in_quota[c];
- cur->total_quota_out = env->out_quota[c];
- cur->desc = net_str[c];
- GNUNET_asprintf (&cur->stat_total,
- "# ATS addresses %s total", cur->desc);
- GNUNET_asprintf (&cur->stat_active,
- "# ATS active addresses %s total", cur->desc);
- LOG (GNUNET_ERROR_TYPE_INFO, "Added network %u `%s' %p\n", c, cur->desc, s);
- }
- return s;
-}
-
void *
libgnunet_plugin_ats_proportional_done (void *cls)
{
- struct GAS_PROPORTIONAL_Handle *s = cls;
+ struct GNUNET_ATS_SolverFunctions *sf = cls;
+ struct GAS_PROPORTIONAL_Handle *s = sf->cls;
struct AddressWrapper *cur;
struct AddressWrapper *next;
int c;
- GNUNET_assert(s != NULL);
+
for (c = 0; c < s->network_count; c++)
{
if (s->network_entries[c].total_addresses > 0)
* Test if bandwidth is available in this network to add an additional address
*
* @param net the network type to update
- * @return GNUNET_YES or GNUNET_NO
+ * @return #GNUNET_YES or #GNUNET_NO
*/
static int
is_bandwidth_available_in_network (struct Network *net)
return GNUNET_NO;
}
+
/**
* Update bandwidth assigned to peers in this network
*
* @param s the solver handle
* @param net the network type to update
- * @param address_except address excluded from notification, since we suggest
* this address
*/
static void
distribute_bandwidth (struct GAS_PROPORTIONAL_Handle *s,
- struct Network *net, struct ATS_Address *address_except)
+ struct Network *net)
{
struct AddressSolverInformation *asi;
- struct AddressWrapper *cur;
-
+ struct AddressWrapper *cur_address;
unsigned long long remaining_quota_in = 0;
unsigned long long quota_out_used = 0;
unsigned long long remaining_quota_out = 0;
unsigned long long quota_in_used = 0;
+ int count_addresses;
uint32_t min_bw = ntohl (GNUNET_CONSTANTS_DEFAULT_BW_IN_OUT.value__);
- double peer_prefs;
- double total_prefs; /* Important: has to be double not float due to precision */
+ double relative_peer_prefence;
+ double sum_relative_peer_prefences; /* Important: has to be double not float due to precision */
double cur_pref; /* Important: has to be double not float due to precision */
- const double *t = NULL; /* Important: has to be double not float due to precision */
- int c;
- unsigned long long assigned_quota_in = 0;
- unsigned long long assigned_quota_out = 0;
+ double peer_weight;
+ double total_weight;
+ const double *peer_relative_prefs = NULL; /* Important: has to be double not float due to precision */
+ uint32_t assigned_quota_in = 0;
+ uint32_t assigned_quota_out = 0;
- LOG(GNUNET_ERROR_TYPE_DEBUG,
- "Recalculate quota for network type `%s' for %u addresses (in/out): %llu/%llu \n",
- net->desc, net->active_addresses, net->total_quota_in,
- net->total_quota_in);
+
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Recalculate quota for network type `%s' for %u addresses (in/out): %llu/%llu \n",
+ net->desc,
+ net->active_addresses,
+ net->total_quota_in,
+ net->total_quota_in);
if (net->active_addresses == 0)
+ {
return; /* no addresses to update */
+ }
/* Idea
* Assign every peer in network minimum Bandwidth
remaining_quota_out = net->total_quota_out - (net->active_addresses * min_bw);
LOG(GNUNET_ERROR_TYPE_DEBUG, "Remaining bandwidth : (in/out): %llu/%llu \n",
remaining_quota_in, remaining_quota_out);
- total_prefs = 0.0;
- for (cur = net->head; NULL != cur; cur = cur->next)
+ sum_relative_peer_prefences = 0.0;
+
+ /* Calculate sum of relative preference for active addresses in this network */
+ count_addresses = 0;
+ for (cur_address = net->head; NULL != cur_address; cur_address = cur_address->next)
{
- if (GNUNET_YES == cur->addr->active)
- {
- GNUNET_assert(
- NULL != (t = s->get_preferences (s->get_preferences_cls, &cur->addr->peer)));
+ if (GNUNET_YES != cur_address->addr->active)
+ continue;
+
+ GNUNET_assert( NULL != (peer_relative_prefs = s->env->get_preferences (s->env->cls,
+ &cur_address->addr->peer)));
+ relative_peer_prefence = 0.0;
+ relative_peer_prefence += peer_relative_prefs[GNUNET_ATS_PREFERENCE_BANDWIDTH];
+ sum_relative_peer_prefences += relative_peer_prefence;
+ count_addresses ++;
+ }
- peer_prefs = 0.0;
- for (c = 0; c < GNUNET_ATS_PreferenceCount; c++)
- {
- if (c != GNUNET_ATS_PREFERENCE_END)
- {
- //fprintf (stderr, "VALUE[%u] %s %.3f \n", c, GNUNET_i2s (&cur->addr->peer), t[c]);
- peer_prefs += t[c];
- }
- }
- total_prefs += (peer_prefs / (GNUNET_ATS_PreferenceCount - 1));
+ if (count_addresses != net->active_addresses)
+ {
+ GNUNET_break (0);
+ LOG (GNUNET_ERROR_TYPE_WARNING,
+ "%s: Counted %u active addresses, but network says to have %u active addresses\n",
+ net->desc, count_addresses, net->active_addresses);
+ for (cur_address = net->head; NULL != cur_address; cur_address = cur_address->next)
+ {
+ if (GNUNET_YES != cur_address->addr->active)
+ continue;
+
+ LOG (GNUNET_ERROR_TYPE_WARNING,
+ "Active: `%s' `%s' length %u\n",
+ GNUNET_i2s (&cur_address->addr->peer),
+ cur_address->addr->plugin,
+ cur_address->addr->addr_len);
}
}
- for (cur = net->head; NULL != cur; cur = cur->next)
+
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Total relative preference %.3f for %u addresses in network %s\n",
+ sum_relative_peer_prefences, net->active_addresses, net->desc);
+
+ for (cur_address = net->head; NULL != cur_address; cur_address = cur_address->next)
{
- if (GNUNET_YES == cur->addr->active)
+ if (GNUNET_YES == cur_address->addr->active)
{
- cur_pref = 0.0;
- GNUNET_assert(
- NULL != (t = s->get_preferences (s->get_preferences_cls, &cur->addr->peer)));
+ GNUNET_assert( NULL != (peer_relative_prefs =
+ s->env->get_preferences (s->env->cls,
+ &cur_address->addr->peer)));
- for (c = 0; c < GNUNET_ATS_PreferenceCount; c++)
- {
- if (c != GNUNET_ATS_PREFERENCE_END)
- cur_pref += t[c];
- }
- cur_pref /= 2;
+ cur_pref = peer_relative_prefs[GNUNET_ATS_PREFERENCE_BANDWIDTH];
+ total_weight = net->active_addresses +
+ s->prop_factor * sum_relative_peer_prefences;
+ peer_weight = (1.0 + (s->prop_factor * cur_pref));
assigned_quota_in = min_bw
- + ((cur_pref / total_prefs) * remaining_quota_in);
+ + ((peer_weight / total_weight) * remaining_quota_in);
assigned_quota_out = min_bw
- + ((cur_pref / total_prefs) * remaining_quota_out);
+ + ((peer_weight / total_weight) * remaining_quota_out);
- LOG(GNUNET_ERROR_TYPE_DEBUG,
- "New quota for peer `%s' with preference (cur/total) %.3f/%.3f (in/out): %llu / %llu\n",
- GNUNET_i2s (&cur->addr->peer), cur_pref, total_prefs,
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "New quota for peer `%s' with weight (cur/total) %.3f/%.3f (in/out): %llu / %llu\n",
+ GNUNET_i2s (&cur_address->addr->peer), peer_weight, total_weight,
assigned_quota_in, assigned_quota_out);
}
else
assigned_quota_out = UINT32_MAX;
/* Compare to current bandwidth assigned */
- asi = cur->addr->solver_information;
- asi->calculated_quota_in_NBO = htonl (assigned_quota_in);
- asi->calculated_quota_out_NBO = htonl (assigned_quota_out);
+ asi = cur_address->addr->solver_information;
+ asi->calculated_quota_in = assigned_quota_in;
+ asi->calculated_quota_out = assigned_quota_out;
}
LOG(GNUNET_ERROR_TYPE_DEBUG,
"Total bandwidth assigned is (in/out): %llu /%llu\n", quota_in_used,
}
}
+
+/**
+ * Context for finding the best address* Linked list of addresses in this network: head
+ */
struct FindBestAddressCtx
{
+ /**
+ * The solver handle
+ */
struct GAS_PROPORTIONAL_Handle *s;
+
+ /**
+ * The currently best address
+ */
struct ATS_Address *best;
};
+
+/**
+ * Find index of a ATS property type in the array.
+ */
static int
find_property_index (uint32_t type)
{
int existing_types[] = GNUNET_ATS_QualityProperties;
int c;
+
for (c = 0; c < GNUNET_ATS_QualityPropertiesCount; c++)
if (existing_types[c] == type)
return c;
return GNUNET_SYSERR;
}
+
/**
* Find a "good" address to use for a peer by iterating over the addresses for this peer.
* If we already have an existing address, we stick to it.
* Otherwise, we pick by lowest distance and then by lowest latency.
*
- * @param cls the 'struct ATS_Address**' where we store the result
+ * @param cls the `struct FindBestAddressCtx *' where we store the result
* @param key unused
- * @param value another 'struct ATS_Address*' to consider using
- * @return GNUNET_OK (continue to iterate)
+ * @param value another `struct ATS_Address*` to consider using
+ * @return #GNUNET_OK (continue to iterate)
*/
static int
find_best_address_it (void *cls,
const struct GNUNET_PeerIdentity *key,
void *value)
{
- struct FindBestAddressCtx *ctx = (struct FindBestAddressCtx *) cls;
- struct ATS_Address *current = (struct ATS_Address *) value;
- struct ATS_Address *current_best = (struct ATS_Address *) value;
- struct GNUNET_TIME_Absolute now;
+ struct FindBestAddressCtx *ctx = cls;
+ struct ATS_Address *current = value;
+ struct ATS_Address *current_best = current;
struct AddressSolverInformation *asi;
- const double *norm_prop_cur;
- const double *norm_prop_best;
+ struct GNUNET_TIME_Relative active_time;
+ struct GNUNET_TIME_Relative min_active_time;
+ double best_delay;
+ double best_distance;
+ double cur_delay;
+ double cur_distance;
int index;
current_best = NULL;
asi = current->solver_information;
- now = GNUNET_TIME_absolute_get ();
-
- if (current->blocked_until.abs_value_us
- == GNUNET_TIME_absolute_max (now, current->blocked_until).abs_value_us)
+ if (NULL == asi)
{
- /* This address is blocked for suggestion */
- LOG(GNUNET_ERROR_TYPE_DEBUG, "Address %p blocked for suggestion for %s \n",
- current,
- GNUNET_STRINGS_relative_time_to_string (GNUNET_TIME_absolute_get_difference (now, current->blocked_until), GNUNET_YES));
+ GNUNET_break (0);
return GNUNET_OK;
}
+
if (GNUNET_NO == is_bandwidth_available_in_network (asi->network))
+ {
return GNUNET_OK; /* There's no bandwidth available in this network */
+ }
if (NULL != ctx->best)
{
/* Compare current addresses with denominated 'best' address */
-
current_best = ctx->best;
- if ((0 != ctx->best->addr_len) && (0 == current->addr_len))
- {
- /* saved address was an outbound address, but we have an inbound address */
- current_best = current;
- goto end;
- }
- if (ctx->best->t_last_activity.abs_value_us < current->t_last_activity.abs_value_us)
- {
- /* Current address is newer */
- current_best = current;
- }
- if (ctx->best->t_added.abs_value_us < current->t_added.abs_value_us)
- {
- /* Current address is newer */
- current_best = current;
- goto end;
- }
}
- if (NULL == ctx->best)
+ else
{
/* We do not have a 'best' address so take this address */
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Setting initial address %p\n",
+ current);
current_best = current;
goto end;
}
- if ( (ntohl (ctx->best->assigned_bw_in.value__) == 0) &&
- (ntohl (current->assigned_bw_in.value__) > 0) )
+ if (GNUNET_YES == current->active)
{
- /* stick to existing connection */
- current_best = current;
+ GNUNET_assert (asi->activated.abs_value_us != GNUNET_TIME_UNIT_ZERO_ABS.abs_value_us);
+ active_time = GNUNET_TIME_absolute_get_duration (asi->activated);
+ min_active_time.rel_value_us = ((double) GNUNET_TIME_UNIT_SECONDS.rel_value_us) *
+ ctx->s->stability_factor;
+ if (active_time.rel_value_us <= min_active_time.rel_value_us)
+ {
+ /* Keep active address for stability reasons */
+ ctx->best = current;
+ return GNUNET_NO;
+ }
}
/* Now compare ATS information */
- norm_prop_cur = ctx->s->get_properties (ctx->s->get_properties_cls,
- (const struct ATS_Address *) current);
- norm_prop_best = ctx->s->get_properties (ctx->s->get_properties_cls,
- (const struct ATS_Address *) ctx->best);
-
index = find_property_index (GNUNET_ATS_QUALITY_NET_DISTANCE);
- if (GNUNET_SYSERR != index)
- {
- /* user shorter distance */
- if (norm_prop_cur[index] < norm_prop_best[index])
- current_best = current;
- else
- current_best = ctx->best;
- }
-
+ cur_distance = current->atsin[index].norm;
+ best_distance = ctx->best->atsin[index].norm;
index = find_property_index (GNUNET_ATS_QUALITY_NET_DELAY);
- if (GNUNET_SYSERR != index)
+ cur_delay = current->atsin[index].norm;
+ best_delay = ctx->best->atsin[index].norm;
+
+ /* user shorter distance */
+ if (cur_distance < best_distance)
{
- /* User connection with less delay */
- if (norm_prop_cur[index] < norm_prop_best[index])
+ if (GNUNET_NO == ctx->best->active)
+ {
+ current_best = current; /* Use current */
+ }
+ else if ((best_distance / cur_distance) > ctx->s->stability_factor)
+ {
+ /* Best and active address performs worse */
current_best = current;
- else
- current_best = ctx->best;
+ }
}
-end:
- ctx->best = current_best;
- return GNUNET_OK;
-}
-
-/**
- * Helper functions
- * ---------------------------
- */
-static void
-propagate_bandwidth (struct GAS_PROPORTIONAL_Handle *s,
- struct Network *net, struct ATS_Address *address_except)
-{
- struct AddressWrapper *cur;
- struct AddressSolverInformation *asi;
- for (cur = net->head; NULL != cur; cur = cur->next)
+ else
{
- asi = cur->addr->solver_information;
- if ( (cur->addr->assigned_bw_in.value__ != asi->calculated_quota_in_NBO) ||
- (cur->addr->assigned_bw_out.value__ != asi->calculated_quota_out_NBO) )
- {
- cur->addr->assigned_bw_in.value__ = asi->calculated_quota_in_NBO;
- cur->addr->assigned_bw_out.value__ = asi->calculated_quota_in_NBO;
- /* Notify on change */
- if ((GNUNET_YES == cur->addr->active) && (cur->addr != address_except))
- s->bw_changed (s->bw_changed_cls, cur->addr);
- }
+ /* Use current best */
+ current_best = ctx->best;
}
-}
-/**
- * Distribibute bandwidth
- *
- * @param s the solver handle
- * @param n the network, can be NULL for all network
- * @param address_except do not notify for this address
- */
-static void
-distribute_bandwidth_in_network (struct GAS_PROPORTIONAL_Handle *s,
- struct Network *n, struct ATS_Address *address_except)
-{
- if (GNUNET_YES == s->bulk_lock)
+ /* User connection with less delay */
+ if (cur_delay < best_delay)
{
- s->bulk_requests++;
- return;
- }
- if (NULL != n)
- {
- if (NULL != s->env->info_cb)
- s->env->info_cb(s->env->info_cb_cls, GAS_OP_SOLVE_START,
- GAS_STAT_SUCCESS, GAS_INFO_PROP_SINGLE);
- distribute_bandwidth(s, n, address_except);
- if (NULL != s->env->info_cb)
- s->env->info_cb(s->env->info_cb_cls, GAS_OP_SOLVE_STOP,
- GAS_STAT_SUCCESS, GAS_INFO_PROP_SINGLE);
- if (NULL != s->env->info_cb)
- s->env->info_cb(s->env->info_cb_cls, GAS_OP_SOLVE_UPDATE_NOTIFICATION_START,
- GAS_STAT_SUCCESS, GAS_INFO_PROP_SINGLE);
- propagate_bandwidth(s, n, address_except);
- if (NULL != s->env->info_cb)
- s->env->info_cb(s->env->info_cb_cls, GAS_OP_SOLVE_UPDATE_NOTIFICATION_STOP,
- GAS_STAT_SUCCESS, GAS_INFO_PROP_SINGLE);
+ if (GNUNET_NO == ctx->best->active)
+ {
+ current_best = current; /* Use current */
+ }
+ else if ((best_delay / cur_delay) > ctx->s->stability_factor)
+ {
+ /* Best and active address performs worse */
+ current_best = current;
+ }
}
else
{
- int i;
- if (NULL != s->env->info_cb)
- s->env->info_cb(s->env->info_cb_cls, GAS_OP_SOLVE_START,
- GAS_STAT_SUCCESS, GAS_INFO_PROP_ALL);
- for (i = 0; i < s->network_count; i++)
- distribute_bandwidth(s, &s->network_entries[i], NULL);
- if (NULL != s->env->info_cb)
- s->env->info_cb(s->env->info_cb_cls, GAS_OP_SOLVE_STOP,
- GAS_STAT_SUCCESS, GAS_INFO_PROP_ALL);
- if (NULL != s->env->info_cb)
- s->env->info_cb(s->env->info_cb_cls, GAS_OP_SOLVE_UPDATE_NOTIFICATION_START,
- GAS_STAT_SUCCESS, GAS_INFO_PROP_ALL);
- for (i = 0; i < s->network_count; i++)
- {
- propagate_bandwidth(s, &s->network_entries[i], address_except);
- }
- if (NULL != s->env->info_cb)
- s->env->info_cb(s->env->info_cb_cls, GAS_OP_SOLVE_UPDATE_NOTIFICATION_STOP,
- GAS_STAT_SUCCESS, GAS_INFO_PROP_ALL);
+ /* Use current best */
+ current_best = ctx->best;
}
+
+end:
+ ctx->best = current_best;
+ return GNUNET_OK;
}
+
/**
- * Lookup network struct by type
+ * Find the currently best address for a peer from the set of addresses available
+ * or return NULL of no address is available
*
- * @param s the solver handle
- * @param type the network type
- * @return the network struct
+ * @param s the proportional handle
+ * @param addresses the address hashmap
+ * @param id the peer id
+ * @return the address or NULL
*/
-static struct Network *
-get_network (struct GAS_PROPORTIONAL_Handle *s, uint32_t type)
+struct ATS_Address *
+get_best_address (struct GAS_PROPORTIONAL_Handle *s,
+ struct GNUNET_CONTAINER_MultiPeerMap *addresses,
+ const struct GNUNET_PeerIdentity *id)
{
- int c;
- for (c = 0; c < s->network_count; c++)
- {
- if (s->network_entries[c].type == type)
- return &s->network_entries[c];
- }
- return NULL ;
+ struct FindBestAddressCtx fba_ctx;
+
+ fba_ctx.best = NULL;
+ fba_ctx.s = s;
+ GNUNET_CONTAINER_multipeermap_get_multiple (addresses,
+ id,
+ &find_best_address_it,
+ &fba_ctx);
+ return fba_ctx.best;
}
+
/**
* Hashmap Iterator to find current active address for peer
*
*/
static int
get_active_address_it (void *cls,
- const struct GNUNET_PeerIdentity *key,
- void *value)
+ const struct GNUNET_PeerIdentity *key,
+ void *value)
{
struct ATS_Address **dest = cls;
struct ATS_Address *aa = (struct ATS_Address *) value;
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Checking address %p\n", aa);
+
if (GNUNET_YES == aa->active)
{
-
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Address %p is active\n", aa);
if (NULL != (*dest))
{
/* should never happen */
- LOG(GNUNET_ERROR_TYPE_ERROR, "Multiple active addresses for peer `%s'\n",
- GNUNET_i2s (&aa->peer));
+ LOG (GNUNET_ERROR_TYPE_ERROR,
+ "Multiple active addresses for peer `%s'\n",
+ GNUNET_i2s (&aa->peer));
GNUNET_break(0);
return GNUNET_NO;
}
(*dest) = aa;
+
}
return GNUNET_OK;
}
+
/**
* Find current active address for peer
*
*/
static struct ATS_Address *
get_active_address (void *solver,
- const struct GNUNET_CONTAINER_MultiPeerMap * addresses,
- const struct GNUNET_PeerIdentity *peer)
+ const struct GNUNET_CONTAINER_MultiPeerMap * addresses,
+ const struct GNUNET_PeerIdentity *peer)
{
- struct ATS_Address * dest = NULL;
+ static struct ATS_Address *dest;
+ dest = NULL;
GNUNET_CONTAINER_multipeermap_get_multiple (addresses, peer,
- &get_active_address_it, &dest);
+ &get_active_address_it,
+ &dest);
return dest;
}
+/**
+ * Lookup network struct by type
+ *
+ * @param s the solver handle
+ * @param type the network type
+ * @return the network struct
+ */
+static struct Network *
+get_network (struct GAS_PROPORTIONAL_Handle *s,
+ enum GNUNET_ATS_Network_Type type)
+{
+ if (type >= s->env->network_count)
+ {
+ GNUNET_break (0);
+ return NULL;
+ }
+ return &s->network_entries[type];
+}
+
+
+/**
+ * Increase address count in network
+ *
+ * @param s the solver handle
+ * @param net the network type
+ * @param total increase total addresses
+ * @param active increase active addresses
+ */
static void
-addresse_increment (struct GAS_PROPORTIONAL_Handle *s, struct Network *net,
- int total, int active)
+address_increment (struct GAS_PROPORTIONAL_Handle *s,
+ struct Network *net,
+ int total,
+ int active)
{
if (GNUNET_YES == total)
{
s->total_addresses++;
net->total_addresses++;
- GNUNET_STATISTICS_update (s->stats, "# ATS addresses total", 1, GNUNET_NO);
- GNUNET_STATISTICS_update (s->stats, net->stat_total, 1, GNUNET_NO);
+ GNUNET_STATISTICS_update (s->env->stats,
+ "# ATS addresses total", 1, GNUNET_NO);
+ GNUNET_STATISTICS_update (s->env->stats,
+ net->stat_total, 1, GNUNET_NO);
}
if (GNUNET_YES == active)
{
net->active_addresses++;
s->active_addresses++;
- GNUNET_STATISTICS_update (s->stats, "# ATS active addresses total", 1,
+ GNUNET_STATISTICS_update (s->env->stats,
+ "# ATS active addresses total", 1,
GNUNET_NO);
- GNUNET_STATISTICS_update (s->stats, net->stat_active, 1, GNUNET_NO);
+ GNUNET_STATISTICS_update (s->env->stats,
+ net->stat_active, 1, GNUNET_NO);
}
}
+/**
+ * Decrease address count in network
+ *
+ * @param s the solver handle
+ * @param net the network type
+ * @param total decrease total addresses
+ * @param active decrease active addresses
+ */
static int
-addresse_decrement (struct GAS_PROPORTIONAL_Handle *s, struct Network *net,
- int total, int active)
+addresse_decrement (struct GAS_PROPORTIONAL_Handle *s,
+ struct Network *net,
+ int total,
+ int active)
{
int res = GNUNET_OK;
+
if (GNUNET_YES == total)
{
if (s->total_addresses < 1)
else
{
s->total_addresses--;
- GNUNET_STATISTICS_update (s->stats, "# ATS addresses total", -1,
+ GNUNET_STATISTICS_update (s->env->stats,
+ "# ATS addresses total", -1,
GNUNET_NO);
}
if (net->total_addresses < 1)
else
{
net->total_addresses--;
- GNUNET_STATISTICS_update (s->stats, net->stat_total, -1, GNUNET_NO);
+ GNUNET_STATISTICS_update (s->env->stats,
+ net->stat_total, -1, GNUNET_NO);
}
}
else
{
net->active_addresses--;
- GNUNET_STATISTICS_update (s->stats, net->stat_active, -1, GNUNET_NO);
+ GNUNET_STATISTICS_update (s->env->stats,
+ net->stat_active, -1, GNUNET_NO);
}
if (s->active_addresses < 1)
{
else
{
s->active_addresses--;
- GNUNET_STATISTICS_update (s->stats, "# ATS addresses total", -1,
+ GNUNET_STATISTICS_update (s->env->stats,
+ "# ATS addresses total", -1,
GNUNET_NO);
}
}
return res;
}
-/**
- * Solver API functions
- * ---------------------------
- */
/**
- * Changes the preferences for a peer in the problem
+ * Compares addresses
*
- * @param solver the solver handle
- * @param peer the peer to change the preference for
- * @param kind the kind to change the preference
- * @param pref_rel the normalized preference value for this kind over all clients
+ * @param a address a
+ * @param b address b
+ * @return GNUNET_YES if equal, GNUNET_NO else
*/
-void
-GAS_proportional_address_change_preference (void *solver,
- const struct GNUNET_PeerIdentity *peer,
- enum GNUNET_ATS_PreferenceKind kind,
- double pref_rel)
+static int
+address_eq (struct ATS_Address *a, struct ATS_Address *b)
{
- struct GAS_PROPORTIONAL_Handle *s = solver;
- GNUNET_assert(NULL != solver);
- GNUNET_assert(NULL != peer);
-
- distribute_bandwidth_in_network (s, NULL, NULL);
+ GNUNET_assert (NULL != a);
+ GNUNET_assert (NULL != b);
+ if (0 != strcmp(a->plugin, b->plugin))
+ return GNUNET_NO;
+ if (a->addr_len != b->addr_len)
+ return GNUNET_NO;
+ if (0 != memcmp (a->addr, b->addr, b->addr_len))
+ return GNUNET_NO;
+ if (a->session_id != b->session_id)
+ return GNUNET_NO;
+ return GNUNET_YES;
}
/**
- * Get application feedback for a peer
+ * Notify bandwidth changes to addresses
*
- * @param solver the solver handle
- * @param application the application
- * @param peer the peer to change the preference for
- * @param scope the time interval for this feedback: [now - scope .. now]
- * @param kind the kind to change the preference
- * @param score the score
+ * @param s solver handle
+ * @param net the network to propagate changes in
*/
-void
-GAS_proportional_address_preference_feedback (void *solver, void *application,
- const struct GNUNET_PeerIdentity *peer,
- const struct GNUNET_TIME_Relative scope,
- enum GNUNET_ATS_PreferenceKind kind, double score)
+static void
+propagate_bandwidth (struct GAS_PROPORTIONAL_Handle *s,
+ struct Network *net)
{
- struct GAS_PROPORTIONAL_Handle *s = solver;
- GNUNET_assert(NULL != solver);
- GNUNET_assert(NULL != peer);
+ struct AddressWrapper *cur;
+ struct AddressSolverInformation *asi;
- GNUNET_assert(NULL != s);
- GNUNET_break(0);
+ for (cur = net->head; NULL != cur; cur = cur->next)
+ {
+ asi = cur->addr->solver_information;
+ if ( (cur->addr->assigned_bw_in != asi->calculated_quota_in) ||
+ (cur->addr->assigned_bw_out != asi->calculated_quota_out) )
+ {
+ cur->addr->assigned_bw_in = asi->calculated_quota_in;
+ cur->addr->assigned_bw_out = asi->calculated_quota_out;
+
+ /* Reset for next iteration */
+ asi->calculated_quota_in = 0;
+ asi->calculated_quota_out = 0;
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Bandwidth for %s address %p for peer `%s' changed to %u/%u\n",
+ (GNUNET_NO == cur->addr->active) ? "inactive" : "active",
+ cur->addr,
+ GNUNET_i2s (&cur->addr->peer),
+ cur->addr->assigned_bw_in,
+ cur->addr->assigned_bw_out);
+
+ /* Notify on change */
+ if ((GNUNET_YES == cur->addr->active))
+ {
+ s->env->bandwidth_changed_cb (s->env->cls,
+ cur->addr);
+ }
+ }
+ }
}
+
/**
- * Get the preferred address for a specific peer
+ * Distribibute bandwidth
*
- * @param solver the solver handle
- * @param peer the identity of the peer
+ * @param s the solver handle
+ * @param n the network, can be NULL for all network
*/
-const struct ATS_Address *
-GAS_proportional_get_preferred_address (void *solver,
- const struct GNUNET_PeerIdentity *peer)
+static void
+distribute_bandwidth_in_network (struct GAS_PROPORTIONAL_Handle *s,
+ struct Network *n)
{
- struct GAS_PROPORTIONAL_Handle *s = solver;
- struct Network *net_prev;
- struct Network *net_cur;
- struct ATS_Address *prev;
- struct FindBestAddressCtx fba_ctx;
- struct AddressSolverInformation *asi;
- struct AddressSolverInformation *asi_prev;
-
- GNUNET_assert(s != NULL);
- GNUNET_assert(peer != NULL);
+ if (GNUNET_YES == s->bulk_lock)
+ {
+ s->bulk_requests++;
+ return;
+ }
- /* Add to list of pending requests */
- if (GNUNET_NO == GNUNET_CONTAINER_multipeermap_contains (s->requests,
- peer))
+ if (NULL != n)
{
- GNUNET_assert (GNUNET_OK ==
- GNUNET_CONTAINER_multipeermap_put (s->requests,
- peer, NULL,
- GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY));
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Redistributing bandwidth in network %s with %u active and %u total addresses\n",
+ GNUNET_ATS_print_network_type(n->type),
+ n->active_addresses, n->total_addresses);
+
+ s->env->info_cb (s->env->cls,
+ GAS_OP_SOLVE_START,
+ GAS_STAT_SUCCESS,
+ GAS_INFO_PROP_SINGLE);
+
+ /* Distribute */
+ distribute_bandwidth(s, n);
+
+ s->env->info_cb (s->env->cls,
+ GAS_OP_SOLVE_STOP,
+ GAS_STAT_SUCCESS,
+ GAS_INFO_PROP_SINGLE);
+ s->env->info_cb (s->env->cls,
+ GAS_OP_SOLVE_UPDATE_NOTIFICATION_START,
+ GAS_STAT_SUCCESS,
+ GAS_INFO_PROP_SINGLE);
+
+ /* Do propagation */
+ propagate_bandwidth (s, n);
+
+ s->env->info_cb (s->env->cls,
+ GAS_OP_SOLVE_UPDATE_NOTIFICATION_STOP,
+ GAS_STAT_SUCCESS,
+ GAS_INFO_PROP_SINGLE);
}
+ else
+ {
+ int i;
+ s->env->info_cb (s->env->cls,
+ GAS_OP_SOLVE_START,
+ GAS_STAT_SUCCESS,
+ GAS_INFO_PROP_ALL);
+ for (i = 0; i < s->network_count; i++)
+ {
+ /* Distribute */
+ distribute_bandwidth(s, &s->network_entries[i]);
+ }
+
+ s->env->info_cb (s->env->cls,
+ GAS_OP_SOLVE_STOP,
+ GAS_STAT_SUCCESS,
+ GAS_INFO_PROP_ALL);
+ s->env->info_cb (s->env->cls,
+ GAS_OP_SOLVE_UPDATE_NOTIFICATION_START,
+ GAS_STAT_SUCCESS,
+ GAS_INFO_PROP_ALL);
+ for (i = 0; i < s->network_count; i++)
+ {
+ /* Do propagation */
+ propagate_bandwidth(s, &s->network_entries[i]);
+ }
+ s->env->info_cb (s->env->cls,
+ GAS_OP_SOLVE_UPDATE_NOTIFICATION_STOP,
+ GAS_STAT_SUCCESS,
+ GAS_INFO_PROP_ALL);
+ }
+}
- /* Get address with: stick to current address, lower distance, lower latency */
- fba_ctx.s = s;
- fba_ctx.best = NULL;
- GNUNET_CONTAINER_multipeermap_get_multiple (s->addresses, peer,
- &find_best_address_it, &fba_ctx);
- if (NULL == fba_ctx.best)
+/**
+ * Update active address for a peer:
+ * Check if active address exists and what the best address is, if addresses
+ * are different switch
+ *
+ * @param s solver handle
+ * @param peer the peer to check
+ * return the new address or NULL if no update was performed
+ */
+static struct ATS_Address *
+update_active_address (struct GAS_PROPORTIONAL_Handle *s,
+ const struct GNUNET_PeerIdentity *peer)
+{
+ struct ATS_Address *best_address;
+ struct ATS_Address *current_address;
+ struct AddressSolverInformation *asi;
+ struct Network *net;
+
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Updating active address for peer `%s'\n",
+ GNUNET_i2s (peer));
+
+ /* Find active address */
+ current_address = get_active_address (s,
+ s->addresses,
+ peer);
+
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Peer `%s' has active address %p\n",
+ GNUNET_i2s (peer),
+ current_address);
+
+ /* Find best address */
+ best_address = get_best_address (s,
+ s->addresses,
+ peer);
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Peer `%s' has best address %p\n",
+ GNUNET_i2s (peer),
+ best_address);
+
+ if (NULL != current_address)
{
- LOG(GNUNET_ERROR_TYPE_INFO, "Cannot suggest address for peer `%s'\n",
- GNUNET_i2s (peer));
- return NULL ;
+ if ( (NULL == best_address) ||
+ ( (NULL != best_address) &&
+ (GNUNET_NO == address_eq (current_address,
+ best_address)) ) )
+ {
+ /* We switch to a new address (or to none),
+ mark old address as inactive */
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Disabling previous %s address %p for peer `%s'\n",
+ (GNUNET_NO == current_address->active) ? "inactive" : "active",
+ current_address,
+ GNUNET_i2s (peer));
+
+ asi = current_address->solver_information;
+ GNUNET_assert (NULL != asi);
+
+ net = asi->network;
+ asi->activated = GNUNET_TIME_UNIT_ZERO_ABS;
+ current_address->active = GNUNET_NO; /* No active any longer */
+ current_address->assigned_bw_in = 0; /* no bandwidth assigned */
+ current_address->assigned_bw_out = 0; /* no bandwidth assigned */
+
+ if (GNUNET_SYSERR == addresse_decrement (s, net, GNUNET_NO, GNUNET_YES))
+ GNUNET_break(0);
+
+ /* Update network of previous address */
+ distribute_bandwidth_in_network (s, net);
+ }
+ if (NULL == best_address)
+ {
+ /* We previously had an active address, but now we cannot suggest one
+ * Therefore we have to disconnect the peer */
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Disconnecting peer `%s' with previous address %p\n",
+ GNUNET_i2s (peer),
+ current_address);
+ s->env->bandwidth_changed_cb (s->env->cls,
+ current_address);
+ }
}
-
- LOG(GNUNET_ERROR_TYPE_INFO, "Suggesting %s address %p for peer `%s'\n",
- (GNUNET_NO == fba_ctx.best->active) ? "inactive" : "active", fba_ctx.best,
- GNUNET_i2s (peer));
- asi = fba_ctx.best->solver_information;
- net_cur = asi->network ;
- if (NULL == fba_ctx.best)
+ if (NULL == best_address)
{
- LOG(GNUNET_ERROR_TYPE_ERROR,
- "Trying to suggesting unknown address peer `%s'\n", GNUNET_i2s (peer));
- GNUNET_break(0);
- return NULL ;
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Cannot suggest address for peer `%s'\n",
+ GNUNET_i2s (peer));
+ return NULL;
}
- if (GNUNET_YES == fba_ctx.best->active)
+
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Suggesting new address %p for peer `%s'\n",
+ best_address,
+ GNUNET_i2s (peer));
+
+ if ( (NULL != current_address) &&
+ (GNUNET_YES == address_eq (best_address, current_address)) )
{
- /* This address was selected previously, so no need to update quotas */
- return fba_ctx.best;
+ GNUNET_break (GNUNET_NO != current_address->active);
+ return best_address; /* Same same */
}
- /* This address was not active, so we have to:
- *
- * - mark previous active address as not active
- * - update quota for previous address network
- * - update quota for this address network
- */
- prev = get_active_address (s, s->addresses, peer);
- if (NULL != prev)
+ asi = best_address->solver_information;
+ GNUNET_assert (NULL != asi);
+ net = asi->network;
+
+ /* Mark address as active */
+ asi->activated = GNUNET_TIME_absolute_get ();
+ best_address->active = GNUNET_YES;
+ address_increment (s, net, GNUNET_NO, GNUNET_YES);
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Address %p for peer `%s' is now active\n",
+ best_address,
+ GNUNET_i2s (peer));
+ /* Distribute bandwidth */
+ distribute_bandwidth_in_network (s, net);
+ return best_address;
+}
+
+
+/**
+ * Changes the preferences for a peer in the problem
+ *
+ * @param solver the solver handle
+ * @param peer the peer to change the preference for
+ * @param kind the kind to change the preference
+ * @param pref_rel the normalized preference value for this kind over all clients
+ */
+static void
+GAS_proportional_address_change_preference (void *solver,
+ const struct GNUNET_PeerIdentity *peer,
+ enum GNUNET_ATS_PreferenceKind kind,
+ double pref_rel)
+{
+ struct GAS_PROPORTIONAL_Handle *s = solver;
+ struct ATS_Address *best_address;
+ struct ATS_Address *active_address;
+ struct AddressSolverInformation *asi;
+
+ if (GNUNET_NO ==
+ GNUNET_CONTAINER_multipeermap_contains (s->requests, peer))
+ return; /* Peer is not requested */
+
+ /* This peer is requested, find best address */
+ active_address = get_active_address (s, s->addresses, peer);
+ best_address = update_active_address (s, peer);
+
+ if ((NULL != best_address) && ((NULL != active_address) &&
+ (GNUNET_YES == address_eq (active_address, best_address))))
{
- asi_prev = prev->solver_information;
- net_prev = (struct Network *) asi_prev->network;
- prev->active = GNUNET_NO; /* No active any longer */
- prev->assigned_bw_in = BANDWIDTH_ZERO; /* no bandwidth assigned */
- prev->assigned_bw_out = BANDWIDTH_ZERO; /* no bandwidth assigned */
- if (GNUNET_SYSERR == addresse_decrement (s, net_prev, GNUNET_NO, GNUNET_YES))
- GNUNET_break(0);
- distribute_bandwidth_in_network (s, net_prev, NULL);
+ asi = best_address->solver_information;
+ GNUNET_assert (NULL != asi);
+
+ /* We sticked to the same address, therefore redistribute */
+ distribute_bandwidth_in_network (s, asi->network);
}
+}
- if (GNUNET_NO == (is_bandwidth_available_in_network (net_cur)))
+
+/**
+ * Get application feedback for a peer
+ *
+ * @param solver the solver handle
+ * @param application the application
+ * @param peer the peer to change the preference for
+ * @param scope the time interval for this feedback: [now - scope .. now]
+ * @param kind the kind to change the preference
+ * @param score the score
+ */
+static void
+GAS_proportional_address_preference_feedback (void *solver,
+ struct GNUNET_SERVER_Client *application,
+ const struct GNUNET_PeerIdentity *peer,
+ const struct GNUNET_TIME_Relative scope,
+ enum GNUNET_ATS_PreferenceKind kind,
+ double score)
+{
+ struct GAS_PROPORTIONAL_Handle *s = solver;
+
+ GNUNET_assert(NULL != peer);
+ GNUNET_assert(NULL != s);
+}
+
+
+/**
+ * Get the preferred address for a specific peer
+ *
+ * @param solver the solver handle
+ * @param peer the identity of the peer
+ * @return best address
+ */
+static const struct ATS_Address *
+GAS_proportional_get_preferred_address (void *solver,
+ const struct GNUNET_PeerIdentity *peer)
+{
+ struct GAS_PROPORTIONAL_Handle *s = solver;
+ const struct ATS_Address *best_address;
+
+ /* Add to list of pending requests */
+ if (GNUNET_NO ==
+ GNUNET_CONTAINER_multipeermap_contains (s->requests, peer))
{
- GNUNET_break(0); /* This should never happen*/
- return NULL ;
+ GNUNET_assert (GNUNET_OK ==
+ GNUNET_CONTAINER_multipeermap_put (s->requests,
+ peer,
+ NULL,
+ GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY));
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Start suggesting addresses for peer `%s'\n",
+ GNUNET_i2s (peer));
}
- fba_ctx.best->active = GNUNET_YES;
- addresse_increment (s, net_cur, GNUNET_NO, GNUNET_YES);
- distribute_bandwidth_in_network (s, net_cur, fba_ctx.best);
- return fba_ctx.best;
+ best_address = update_active_address (s, peer);
+ if (s->bulk_lock > 0)
+ return NULL; /* Do not suggest since bulk lock is pending */
+
+ return best_address;
}
+
/**
* Stop notifying about address and bandwidth changes for this peer
*
* @param solver the solver handle
* @param peer the peer
*/
-void
+static void
GAS_proportional_stop_get_preferred_address (void *solver,
- const struct GNUNET_PeerIdentity *peer)
+ const struct GNUNET_PeerIdentity *peer)
{
struct GAS_PROPORTIONAL_Handle *s = solver;
struct ATS_Address *cur;
struct AddressSolverInformation *asi;
struct Network *cur_net;
- if (GNUNET_YES
- == GNUNET_CONTAINER_multipeermap_contains (s->requests,
- peer))
- GNUNET_assert (GNUNET_OK == GNUNET_CONTAINER_multipeermap_remove (s->requests, peer,
- NULL));
+ if (GNUNET_YES ==
+ GNUNET_CONTAINER_multipeermap_contains (s->requests, peer))
+ {
+ GNUNET_assert (GNUNET_OK ==
+ GNUNET_CONTAINER_multipeermap_remove (s->requests,
+ peer,
+ NULL));
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Stop suggesting addresses for peer `%s'\n",
+ GNUNET_i2s (peer));
+ }
cur = get_active_address (s,
- s->addresses, peer);
+ s->addresses,
+ peer);
if (NULL != cur)
{
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Disabling %s address %p for peer `%s'\n",
+ (GNUNET_NO == cur->active) ? "inactive" : "active",
+ cur,
+ GNUNET_i2s (&cur->peer));
+
/* Disabling current address */
asi = cur->solver_information;
cur_net = asi->network ;
+ asi->activated = GNUNET_TIME_UNIT_ZERO_ABS;
cur->active = GNUNET_NO; /* No active any longer */
- cur->assigned_bw_in = BANDWIDTH_ZERO; /* no bandwidth assigned */
- cur->assigned_bw_out = BANDWIDTH_ZERO; /* no bandwidth assigned */
- if (GNUNET_SYSERR == addresse_decrement (s, cur_net, GNUNET_NO, GNUNET_YES))
+ cur->assigned_bw_in = 0; /* no bandwidth assigned */
+ cur->assigned_bw_out = 0; /* no bandwidth assigned */
+
+ if (GNUNET_SYSERR ==
+ addresse_decrement (s, cur_net, GNUNET_NO, GNUNET_YES))
GNUNET_break(0);
- distribute_bandwidth_in_network (s, cur_net, NULL );
+
+ distribute_bandwidth_in_network (s, cur_net);
}
- return;
}
+
/**
* Remove an address from the solver
*
* @param address the address to remove
* @param session_only delete only session not whole address
*/
-void
-GAS_proportional_address_delete (void *solver, struct ATS_Address *address,
- int session_only)
+static void
+GAS_proportional_address_delete (void *solver,
+ struct ATS_Address *address,
+ int session_only)
{
struct GAS_PROPORTIONAL_Handle *s = solver;
struct Network *net;
struct AddressWrapper *aw;
struct AddressSolverInformation *asi;
- const struct ATS_Address *new_address;
-
/* Remove an adress completely, we have to:
* - Remove from specific network
GNUNET_break (0);
return;
}
-
net = asi->network;
if (GNUNET_NO == session_only)
{
- LOG(GNUNET_ERROR_TYPE_INFO,
- "Deleting %s address %p for peer `%s' from network `%s' (total: %u/ active: %u)\n",
- (GNUNET_NO == address->active) ? "inactive" : "active", address,
- GNUNET_i2s (&address->peer), net->desc, net->total_addresses,
- net->active_addresses);
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Deleting %s address %p for peer `%s' from network `%s' (total: %u/ active: %u)\n",
+ (GNUNET_NO == address->active) ? "inactive" : "active",
+ address,
+ GNUNET_i2s (&address->peer),
+ net->desc,
+ net->total_addresses,
+ net->active_addresses);
/* Remove address */
addresse_decrement (s, net, GNUNET_YES, GNUNET_NO);
GNUNET_break(0);
return;
}
- GNUNET_CONTAINER_DLL_remove(net->head, net->tail, aw);
- GNUNET_free_non_null (aw->addr->solver_information);
- GNUNET_free(aw);
+ GNUNET_CONTAINER_DLL_remove (net->head,
+ net->tail,
+ aw);
+ GNUNET_free (aw);
}
else
{
/* Remove session only: remove if active and update */
- LOG(GNUNET_ERROR_TYPE_INFO,
- "Deleting %s session %p for peer `%s' from network `%s' (total: %u/ active: %u)\n",
- (GNUNET_NO == address->active) ? "inactive" : "active", address,
- GNUNET_i2s (&address->peer), net->desc, net->total_addresses,
- net->active_addresses);
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Deleting %s session %p for peer `%s' from network `%s' (total: %u/ active: %u)\n",
+ (GNUNET_NO == address->active) ? "inactive" : "active",
+ address,
+ GNUNET_i2s (&address->peer),
+ net->desc,
+ net->total_addresses,
+ net->active_addresses);
}
if (GNUNET_YES == address->active)
{
/* Address was active, remove from network and update quotas*/
address->active = GNUNET_NO;
- address->assigned_bw_in = BANDWIDTH_ZERO;
- address->assigned_bw_out = BANDWIDTH_ZERO;
+ address->assigned_bw_in = 0;
+ address->assigned_bw_out = 0;
+ asi->calculated_quota_in = 0;
+ asi->calculated_quota_out = 0;
- if (GNUNET_SYSERR == addresse_decrement (s, net, GNUNET_NO, GNUNET_YES))
+ if (GNUNET_SYSERR ==
+ addresse_decrement (s, net, GNUNET_NO, GNUNET_YES))
GNUNET_break(0);
- distribute_bandwidth_in_network (s, net, NULL);
- if (NULL == (new_address = GAS_proportional_get_preferred_address (s, &address->peer)))
+ distribute_bandwidth_in_network (s, net);
+
+ if (NULL ==
+ update_active_address (s, &address->peer))
{
/* No alternative address found, disconnect peer */
- s->bw_changed (s->bw_changed_cls, address);
- }
- else
- {
- s->bw_changed (s->bw_changed_cls, (struct ATS_Address *) new_address);
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Disconnecting peer `%s' after deleting previous address %p\n",
+ GNUNET_i2s (&address->peer),
+ address);
+ s->env->bandwidth_changed_cb (s->env->cls,
+ address);
}
}
- LOG(GNUNET_ERROR_TYPE_INFO,
- "After deleting address now total %u and active %u addresses in network `%s'\n",
- net->total_addresses, net->active_addresses, net->desc);
+ if (GNUNET_NO == session_only)
+ {
+ GNUNET_free_non_null (address->solver_information);
+ address->solver_information = NULL;
+ }
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "After deleting address now total %u and active %u addresses in network `%s'\n",
+ net->total_addresses,
+ net->active_addresses,
+ net->desc);
}
+
/**
* Start a bulk operation
*
* @param solver the solver
*/
-void
+static void
GAS_proportional_bulk_start (void *solver)
{
- LOG(GNUNET_ERROR_TYPE_DEBUG, "Locking solver for bulk operation ...\n");
- struct GAS_PROPORTIONAL_Handle *s = (struct GAS_PROPORTIONAL_Handle *) solver;
+ struct GAS_PROPORTIONAL_Handle *s = solver;
- GNUNET_assert(NULL != solver);
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Locking solver for bulk operation ...\n");
+ GNUNET_assert (NULL != solver);
s->bulk_lock++;
}
/**
* Bulk operation done
*/
-void
+static void
GAS_proportional_bulk_stop (void *solver)
{
- LOG(GNUNET_ERROR_TYPE_DEBUG, "Unlocking solver from bulk operation ...\n");
-
- struct GAS_PROPORTIONAL_Handle *s = (struct GAS_PROPORTIONAL_Handle *) solver;
- GNUNET_assert(NULL != solver);
+ struct GAS_PROPORTIONAL_Handle *s = solver;
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Unlocking solver from bulk operation ...\n");
if (s->bulk_lock < 1)
{
GNUNET_break(0);
s->bulk_lock--;
if ((0 == s->bulk_lock) && (0 < s->bulk_requests))
{
- LOG(GNUNET_ERROR_TYPE_DEBUG, "No lock pending, recalculating\n");
- distribute_bandwidth_in_network (s, NULL, NULL);
+ LOG(GNUNET_ERROR_TYPE_INFO, "No lock pending, recalculating\n");
+ distribute_bandwidth_in_network (s, NULL);
s->bulk_requests = 0;
}
}
* @param address the address to add
* @param network network type of this address
*/
-void
-GAS_proportional_address_add (void *solver, struct ATS_Address *address,
- uint32_t network);
+static void
+GAS_proportional_address_add (void *solver,
+ struct ATS_Address *address,
+ uint32_t network);
+
/**
* Transport properties for this address have changed
* @param abs_value the absolute value of the property
* @param rel_value the normalized value
*/
-void
+static void
GAS_proportional_address_property_changed (void *solver,
- struct ATS_Address *address, uint32_t type, uint32_t abs_value,
- double rel_value)
+ struct ATS_Address *address,
+ enum GNUNET_ATS_Property type,
+ uint32_t abs_value,
+ double rel_value)
{
- struct GAS_PROPORTIONAL_Handle *s;
+ struct GAS_PROPORTIONAL_Handle *s = solver;
struct Network *n;
struct AddressSolverInformation *asi;
+ struct ATS_Address *best_address;
+ struct ATS_Address *active_address;
- GNUNET_assert(NULL != solver);
- GNUNET_assert(NULL != address);
-
- s = (struct GAS_PROPORTIONAL_Handle *) solver;
asi = address->solver_information;
- n = asi->network;
-
- if (NULL == n)
+ if (NULL == asi)
{
GNUNET_break(0);
return;
}
- LOG(GNUNET_ERROR_TYPE_DEBUG,
- "Property `%s' for peer `%s' address %p changed to %.2f \n",
- GNUNET_ATS_print_property_type (type), GNUNET_i2s (&address->peer),
- address, rel_value);
- switch (type)
- {
- case GNUNET_ATS_UTILIZATION_OUT:
- case GNUNET_ATS_UTILIZATION_IN:
- case GNUNET_ATS_UTILIZATION_PAYLOAD_IN:
- case GNUNET_ATS_UTILIZATION_PAYLOAD_OUT:
- case GNUNET_ATS_QUALITY_NET_DELAY:
- case GNUNET_ATS_QUALITY_NET_DISTANCE:
- case GNUNET_ATS_COST_WAN:
- case GNUNET_ATS_COST_LAN:
- case GNUNET_ATS_COST_WLAN:
- distribute_bandwidth_in_network (s, n, NULL);
- break;
- }
-}
-
-/**
- * Transport session for this address has changed
- *
- * NOTE: values in addresses are already updated
- *
- * @param solver solver handle
- * @param address the address
- * @param cur_session the current session
- * @param new_session the new session
- */
-void
-GAS_proportional_address_session_changed (void *solver,
- struct ATS_Address *address, uint32_t cur_session, uint32_t new_session)
-{
- if (cur_session != new_session)
- {
- LOG(GNUNET_ERROR_TYPE_DEBUG, "Session changed from %u to %u\n", cur_session,
- new_session);
- }
-}
-
-/**
- * Usage for this address has changed
- *
- * NOTE: values in addresses are already updated
- *
- * @param solver solver handle
- * @param address the address
- * @param in_use usage state
- */
-void
-GAS_proportional_address_inuse_changed (void *solver,
- struct ATS_Address *address, int in_use)
-{
- LOG(GNUNET_ERROR_TYPE_DEBUG, "Usage changed to %s\n",
- (GNUNET_YES == in_use) ? "USED" : "UNUSED");
-}
-
-/**
- * Network scope for this address has changed
- *
- * NOTE: values in addresses are already updated
- *
- * @param solver solver handle
- * @param address the address
- * @param current_network the current network
- * @param new_network the new network
- */
-void
-GAS_proportional_address_change_network (void *solver,
- struct ATS_Address *address, uint32_t current_network, uint32_t new_network)
-{
- struct GAS_PROPORTIONAL_Handle *s = (struct GAS_PROPORTIONAL_Handle *) solver;
- struct AddressSolverInformation *asi;
- int save_active = GNUNET_NO;
-
- struct Network *new_net = NULL;
-
- if (current_network == new_network)
+ n = asi->network;
+ if (NULL == n)
{
GNUNET_break(0);
return;
}
- /* Network changed */
- LOG(GNUNET_ERROR_TYPE_DEBUG,
- "Network type changed, moving %s address from `%s' to `%s'\n",
- (GNUNET_YES == address->active) ? "active" : "inactive",
- GNUNET_ATS_print_network_type (current_network),
- GNUNET_ATS_print_network_type (new_network));
-
- save_active = address->active;
+ LOG(GNUNET_ERROR_TYPE_INFO,
+ "Property `%s' for peer `%s' address %p changed to %.2f \n",
+ GNUNET_ATS_print_property_type (type), GNUNET_i2s (&address->peer),
+ address, rel_value);
- /* Disable and assign no bandwidth */
- address->active = GNUNET_NO;
- address->assigned_bw_in = BANDWIDTH_ZERO; /* no bandwidth assigned */
- address->assigned_bw_out = BANDWIDTH_ZERO; /* no bandwidth assigned */
+ if (GNUNET_NO == GNUNET_CONTAINER_multipeermap_contains (s->requests, &address->peer))
+ return; /* Peer is not requested */
- /* Remove from old network */
- GAS_proportional_address_delete (solver, address, GNUNET_NO);
+ /* This peer is requested, find active and best address */
+ active_address = get_active_address(s, s->addresses, &address->peer);
+ best_address = update_active_address (s,
+ &address->peer);
- /* Set new network type */
- if (NULL == (new_net = get_network (solver, new_network)))
+ if ((NULL != best_address) && ((NULL != active_address) &&
+ (GNUNET_YES == address_eq (active_address, best_address))))
{
- /* Address changed to invalid network... */
- LOG(GNUNET_ERROR_TYPE_ERROR,
- _("Invalid network type `%u' `%s': Disconnect!\n"), new_network,
- GNUNET_ATS_print_network_type (new_network));
+ asi = best_address->solver_information;
+ GNUNET_assert (NULL != asi);
- /* Find new address to suggest since no bandwidth in network*/
- if (NULL == GAS_proportional_get_preferred_address (s, &address->peer))
- {
- /* No alternative address found, disconnect peer */
- s->bw_changed (s->bw_changed_cls, address);
- }
- return;
- }
-
- /* Add to new network and update*/
- asi = address->solver_information;
- asi->network = new_net;
- GAS_proportional_address_add (solver, address, new_network);
- if (GNUNET_YES == save_active)
- {
- /* check if bandwidth available in new network */
- if (GNUNET_YES == (is_bandwidth_available_in_network (new_net)))
- {
- /* Assign bandwidth to updated address */
- address->active = GNUNET_YES;
- addresse_increment (s, new_net, GNUNET_NO, GNUNET_YES);
- distribute_bandwidth_in_network (solver, new_net, NULL);
- }
- else
- {
- LOG(GNUNET_ERROR_TYPE_DEBUG,
- "Not enough bandwidth in new network, suggesting alternative address ..\n");
- /* Find new address to suggest since no bandwidth in network*/
- if (NULL == GAS_proportional_get_preferred_address (s, &address->peer))
- {
- /* No alternative address found, disconnect peer */
- s->bw_changed (s->bw_changed_cls, address);
- }
- }
+ /* We sticked to the same address, therefore redistribute */
+ distribute_bandwidth_in_network (s, asi->network);
}
}
+
/**
* Add a new single address to a network
*
* @param address the address to add
* @param network network type of this address
*/
-void
-GAS_proportional_address_add (void *solver, struct ATS_Address *address,
- uint32_t network)
+static void
+GAS_proportional_address_add (void *solver,
+ struct ATS_Address *address,
+ enum GNUNET_ATS_Network_Type network)
{
struct GAS_PROPORTIONAL_Handle *s = solver;
- struct Network *net = NULL;
- struct AddressWrapper *aw = NULL;
+ struct Network *net;
+ struct AddressWrapper *aw;
struct AddressSolverInformation *asi;
- GNUNET_assert(NULL != s);
net = get_network (s, network);
if (NULL == net)
{
- GNUNET_break(0);
+ GNUNET_break (0);
+ LOG (GNUNET_ERROR_TYPE_ERROR,
+ "Unknown network %u `%s' for new address %p for peer `%s'\n",
+ network,
+ GNUNET_ATS_print_network_type (network),
+ address,
+ GNUNET_i2s (&address->peer));
return;
}
aw = GNUNET_new (struct AddressWrapper);
aw->addr = address;
GNUNET_CONTAINER_DLL_insert(net->head, net->tail, aw);
- addresse_increment (s, net, GNUNET_YES, GNUNET_NO);
+ address_increment (s, net, GNUNET_YES, GNUNET_NO);
asi = GNUNET_new (struct AddressSolverInformation);
asi->network = net;
- asi->calculated_quota_in_NBO = 0;
- asi->calculated_quota_out_NBO = 0;
+ asi->calculated_quota_in = 0;
+ asi->calculated_quota_out = 0;
aw->addr->solver_information = asi;
- if (GNUNET_YES == GNUNET_CONTAINER_multipeermap_contains (s->requests, &address->peer))
+ LOG(GNUNET_ERROR_TYPE_INFO,
+ "Adding new address %p for peer `%s', now total %u and active %u addresses in network `%s'\n",
+ address, GNUNET_i2s(&address->peer), net->total_addresses, net->active_addresses, net->desc);
+
+ if (GNUNET_NO == GNUNET_CONTAINER_multipeermap_contains (s->requests, &address->peer))
+ return; /* Peer is not requested */
+
+ /* This peer is requested, find best address */
+ update_active_address (s, &address->peer);
+}
+
+
+
+/**
+ * Function invoked when the plugin is loaded.
+ *
+ * @param[in,out] cls the `struct GNUNET_ATS_PluginEnvironment *` to use;
+ * modified to return the API functions (ugh).
+ * @return the `struct GAS_PROPORTIONAL_Handle` to pass as a closure
+ */
+void *
+libgnunet_plugin_ats_proportional_init (void *cls)
+{
+ static struct GNUNET_ATS_SolverFunctions sf;
+ struct GNUNET_ATS_PluginEnvironment *env = cls;
+ struct GAS_PROPORTIONAL_Handle *s;
+ struct Network * cur;
+ float f_tmp;
+ int c;
+
+ GNUNET_assert (NULL != env);
+ GNUNET_assert (NULL != env->cfg);
+ GNUNET_assert (NULL != env->bandwidth_changed_cb);
+ GNUNET_assert (NULL != env->get_preferences);
+
+ s = GNUNET_new (struct GAS_PROPORTIONAL_Handle);
+ s->env = env;
+ sf.cls = s;
+ sf.s_add = &GAS_proportional_address_add;
+ sf.s_address_update_property = &GAS_proportional_address_property_changed;
+ sf.s_get = &GAS_proportional_get_preferred_address;
+ sf.s_get_stop = &GAS_proportional_stop_get_preferred_address;
+ sf.s_pref = &GAS_proportional_address_change_preference;
+ sf.s_feedback = &GAS_proportional_address_preference_feedback;
+ sf.s_del = &GAS_proportional_address_delete;
+ sf.s_bulk_start = &GAS_proportional_bulk_start;
+ sf.s_bulk_stop = &GAS_proportional_bulk_stop;
+
+ s->network_entries = GNUNET_malloc (env->network_count * sizeof (struct Network));
+
+ /* Init */
+ s->active_addresses = 0;
+ s->total_addresses = 0;
+ s->bulk_lock = GNUNET_NO;
+ s->addresses = env->addresses;
+ s->requests = GNUNET_CONTAINER_multipeermap_create (10, GNUNET_NO);
+
+ s->stability_factor = PROP_STABILITY_FACTOR;
+ if (GNUNET_SYSERR !=
+ GNUNET_CONFIGURATION_get_value_float (env->cfg, "ats",
+ "PROP_STABILITY_FACTOR", &f_tmp))
{
- if (NULL == get_active_address (s, s->addresses, &address->peer))
+ if ((f_tmp < 1.0) || (f_tmp > 2.0))
{
- if (NULL != GAS_proportional_get_preferred_address (s, &address->peer))
- s->bw_changed (s->bw_changed_cls, (struct ATS_Address *) address);
+ LOG (GNUNET_ERROR_TYPE_ERROR,
+ _("Invalid %s configuration %f \n"),
+ "PROP_STABILITY_FACTOR",
+ f_tmp);
+ }
+ else
+ {
+ s->stability_factor = f_tmp;
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Using %s of %.3f\n",
+ "PROP_STABILITY_FACTOR", f_tmp);
}
}
- LOG(GNUNET_ERROR_TYPE_INFO,
- "Adding new address %p for peer `%s', now total %u and active %u addresses in network `%s'\n",
- address, GNUNET_i2s(&address->peer), net->total_addresses, net->active_addresses, net->desc);
+ s->prop_factor = PROPORTIONALITY_FACTOR;
+ if (GNUNET_SYSERR !=
+ GNUNET_CONFIGURATION_get_value_float (env->cfg, "ats",
+ "PROP_PROPORTIONALITY_FACTOR",
+ &f_tmp))
+ {
+ if (f_tmp < 1.0)
+ {
+ LOG (GNUNET_ERROR_TYPE_ERROR,
+ _("Invalid %s configuration %f \n"),
+ "PROP_PROPORTIONALITY_FACTOR", f_tmp);
+ }
+ else
+ {
+ s->prop_factor = f_tmp;
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Using %s of %.3f\n",
+ "PROP_PROPORTIONALITY_FACTOR", f_tmp);
+ }
+ }
+
+ for (c = 0; c < env->network_count; c++)
+ {
+ cur = &s->network_entries[c];
+ cur->type = c;
+ cur->total_quota_in = env->in_quota[c];
+ cur->total_quota_out = env->out_quota[c];
+ cur->desc = GNUNET_ATS_print_network_type (c);
+ GNUNET_asprintf (&cur->stat_total,
+ "# ATS addresses %s total",
+ cur->desc);
+ GNUNET_asprintf (&cur->stat_active,
+ "# ATS active addresses %s total",
+ cur->desc);
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ "Added network %u `%s' (%llu/%llu)\n",
+ c,
+ cur->desc,
+ cur->total_quota_in,
+ cur->total_quota_out);
+ }
+ return &sf;
}