more changes
[oweals/gnunet.git] / src / ats / gnunet-service-ats_addresses.c
index 1262c0ad40e31a6db7ec48e4d8732fb4158a1bf5..1066b78aa2b9b869c25ee8c860bb23366c9cbf71 100644 (file)
@@ -36,8 +36,6 @@
 #endif
 #include "gnunet-service-ats_addresses_simplistic.h"
 
-#define ATS_BLOCKING_DELTA GNUNET_TIME_relative_multiply(GNUNET_TIME_UNIT_MILLISECONDS, 100)
-
 
 /**
  * Available ressource assignment modes
@@ -62,23 +60,109 @@ enum ATS_Mode
   MODE_MLP
 };
 
-static struct GNUNET_CONTAINER_MultiHashMap *addresses;
+/**
+ * Handle for ATS address component
+ */
+struct GAS_Addresses_Suggestion_Requests
+{
+  struct GAS_Addresses_Suggestion_Requests *next;
+  struct GAS_Addresses_Suggestion_Requests *prev;
+
+  struct GNUNET_PeerIdentity id;
+};
+
+/**
+ * Handle for ATS address component
+ */
+struct GAS_Addresses_Handle
+{
+  /**
+   * A multihashmap to store all addresses
+   */
+  struct GNUNET_CONTAINER_MultiHashMap *addresses;
+
+  /**
+   * Configure WAN quota in
+   */
+  unsigned long long wan_quota_in;
+
+  /**
+   * Configure WAN quota out
+   */
+  unsigned long long wan_quota_out;
+
+  /**
+   * Is ATS addresses running
+   */
+  int running;
+
+  /**
+   * Configured ATS solver
+   */
+  int ats_mode;
+
+  /**
+   *  Solver handle
+   */
+  void *solver;
+
+  /**
+   * Address suggestion requests DLL head
+   */
+  struct GAS_Addresses_Suggestion_Requests *r_head;
+
+  /**
+   * Address suggestion requests DLL tail
+   */
+  struct GAS_Addresses_Suggestion_Requests *r_tail;
+
+  /* Solver functions */
 
-static void *solver;
+  /**
+   * Initialize solver
+   */
+  GAS_solver_init s_init;
 
-static unsigned long long wan_quota_in;
+  /**
+   * Add an address to the solver
+   */
+  GAS_solver_address_add s_add;
 
-static unsigned long long wan_quota_out;
+  /**
+   * Update address in solver
+   */
+  GAS_solver_address_update s_update;
 
-static unsigned int active_addr_count;
+  /**
+   * Get address from solver
+   */
+  GAS_solver_get_preferred_address s_get;
 
-static int ats_mode;
+  /**
+   * Delete address in solver
+   */
+  GAS_solver_address_delete s_del;
 
-static int running;
+  /**
+   * Change preference for quality in solver
+   */
+  GAS_solver_address_change_preference s_pref;
+
+  /**
+   * Shutdown solver
+   */
+  GAS_solver_done s_done;
+};
+
+
+/**
+ * Temporary handle
+ */
+struct GAS_Addresses_Handle *handle;
 
 
 static unsigned int
-assemble_ats_information (struct ATS_Address *aa,  struct GNUNET_ATS_Information **dest)
+assemble_ats_information (const struct ATS_Address *aa,  struct GNUNET_ATS_Information **dest)
 {
   unsigned int ats_count = GNUNET_ATS_PropertyCount - 1;
   struct GNUNET_ATS_Information *ats = GNUNET_malloc (ats_count * sizeof (struct GNUNET_ATS_Information));
@@ -103,74 +187,57 @@ assemble_ats_information (struct ATS_Address *aa,  struct GNUNET_ATS_Information
   return ats_count;
 }
 
-static void
-send_bw_notification (struct ATS_Address *aa)
-{
-  struct GNUNET_ATS_Information *ats;
-  uint32_t ats_count;
-
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "New bandwidth for peer %s is %u/%u\n",
-              GNUNET_i2s (&aa->peer), ntohl (aa->assigned_bw_in.value__),
-              ntohl (aa->assigned_bw_out.value__));
-  ats_count = assemble_ats_information (aa, &ats);
-
-  GAS_scheduling_transmit_address_suggestion (&aa->peer, aa->plugin, aa->addr,
-                                              aa->addr_len, aa->session_id,
-                                              ats, ats_count,
-                                              aa->assigned_bw_out,
-                                              aa->assigned_bw_in);
-  GAS_reservations_set_bandwidth (&aa->peer, aa->assigned_bw_in);
-  GAS_performance_notify_all_clients (&aa->peer, aa->plugin, aa->addr, aa->addr_len,
-                                  aa->active,
-                                  ats, ats_count, aa->assigned_bw_out,
-                                  aa->assigned_bw_in);
-  GNUNET_free (ats);
-}
-
-/**
- * Update a bandwidth assignment for a peer.  This trivial method currently
- * simply assigns the same share to all active connections.
- *
- * @param cls unused
- * @param key unused
- * @param value the 'struct ATS_Address'
- * @return GNUNET_OK (continue to iterate)
- */
-static int
-update_bw_simple_it (void *cls, const struct GNUNET_HashCode * key, void *value)
-{
-  struct ATS_Address *aa = value;
-
-  if (GNUNET_YES != aa->active)
-    return GNUNET_OK;
-  GNUNET_assert (active_addr_count > 0);
-
-
-  /* Simple method */
-  aa->assigned_bw_in.value__ = htonl (wan_quota_in / active_addr_count);
-  aa->assigned_bw_out.value__ = htonl (wan_quota_out / active_addr_count);
-
-  send_bw_notification (aa);
-
-  return GNUNET_OK;
-}
-
-
-/**
- * Some (significant) input changed, recalculate bandwidth assignment
- * for all peers.
- */
-static void
-recalculate_assigned_bw ()
+static unsigned int
+disassemble_ats_information (const struct GNUNET_ATS_Information *src,
+                             uint32_t ats_count,
+                             struct ATS_Address *dest)
 {
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Recalculating bandwidth for all active connections\n");
-  GNUNET_STATISTICS_update (GSA_stats, "# bandwidth recalculations performed",
-                            1, GNUNET_NO);
-  GNUNET_STATISTICS_set (GSA_stats, "# active addresses", active_addr_count,
-                         GNUNET_NO);
-
-  GNUNET_CONTAINER_multihashmap_iterate (addresses, &update_bw_simple_it, NULL);
+  int i;
+  int res = 0;
+  for (i = 0; i < ats_count; i++)
+    switch (ntohl (src[i].type))
+    {
+    case GNUNET_ATS_UTILIZATION_UP:
+      dest->atsp_utilization_out.value__ = src[i].value;
+      res ++;
+      break;
+    case GNUNET_ATS_UTILIZATION_DOWN:
+      dest->atsp_utilization_in.value__ = src[i].value;
+      res ++;
+      break;
+    case GNUNET_ATS_QUALITY_NET_DELAY:
+      dest->atsp_latency.rel_value = ntohl (src[i].value);
+      res ++;
+      break;
+    case GNUNET_ATS_QUALITY_NET_DISTANCE:
+      dest->atsp_distance = ntohl (src[i].value);
+      res ++;
+      break;
+    case GNUNET_ATS_COST_WAN:
+      dest->atsp_cost_wan = ntohl (src[i].value);
+      res ++;
+      break;
+    case GNUNET_ATS_COST_LAN:
+      dest->atsp_cost_lan = ntohl (src[i].value);
+      res ++;
+      break;
+    case GNUNET_ATS_COST_WLAN:
+      dest->atsp_cost_wlan = ntohl (src[i].value);
+      res ++;
+      break;
+    case GNUNET_ATS_NETWORK_TYPE:
+      dest->atsp_network_type = ntohl (src[i].value);
+      res ++;
+      break;
+    case GNUNET_ATS_ARRAY_TERMINATOR:
+      break;
+    default:
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                  "Received unsupported ATS type %u\n", ntohl (src[i].type));
+      GNUNET_break (0);
+      break;
+    }
+  return res;
 }
 
 /**
@@ -180,7 +247,6 @@ recalculate_assigned_bw ()
 static void
 free_address (struct ATS_Address *addr)
 {
-  GNUNET_free_non_null (addr->ats);
   GNUNET_free (addr->plugin);
   GNUNET_free (addr);
 }
@@ -209,6 +275,10 @@ create_address (const struct GNUNET_PeerIdentity *peer,
   memcpy (&aa[1], plugin_addr, plugin_addr_len);
   aa->plugin = GNUNET_strdup (plugin_name);
   aa->session_id = session_id;
+  aa->active = GNUNET_NO;
+  aa->mlp_information = NULL;
+  aa->assigned_bw_in = GNUNET_BANDWIDTH_value_init(0);
+  aa->assigned_bw_out = GNUNET_BANDWIDTH_value_init(0);
   return aa;
 }
 
@@ -226,21 +296,11 @@ destroy_address (struct ATS_Address *addr)
 
   ret = GNUNET_NO;
   GNUNET_assert (GNUNET_YES ==
-                 GNUNET_CONTAINER_multihashmap_remove (addresses,
+                 GNUNET_CONTAINER_multihashmap_remove (handle->addresses,
                                                        &addr->peer.hashPubKey,
                                                        addr));
 
-#if HAVE_LIBGLPK
-  if (ats_mode == MODE_MLP)
-    GAS_mlp_address_delete (solver, addresses, addr);
-#endif
-
-  if (GNUNET_YES == addr->active)
-  {
-    active_addr_count--;
-    addr->active = GNUNET_NO;
-    ret = GNUNET_YES;
-  }
+  handle->s_del (handle->solver, handle->addresses, addr);
   free_address (addr);
   return ret;
 }
@@ -263,11 +323,6 @@ compare_address_it (void *cls, const struct GNUNET_HashCode * key, void *value)
   struct CompareAddressContext *cac = cls;
   struct ATS_Address *aa = value;
 
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Comparing peer %4s: address length %u session %u <-> address length %u session %u\n",
-      GNUNET_h2s (key),
-      aa->addr_len, aa->session_id,
-      cac->search->addr_len, cac->search->session_id);
-
   /* Find an matching exact address:
    *
    * Compare by:
@@ -346,15 +401,9 @@ find_address (const struct GNUNET_PeerIdentity *peer,
   cac.exact_address = NULL;
   cac.base_address = NULL;
   cac.search = addr;
-  GNUNET_CONTAINER_multihashmap_get_multiple (addresses, &peer->hashPubKey,
+  GNUNET_CONTAINER_multihashmap_get_multiple (handle->addresses, &peer->hashPubKey,
                                               &compare_address_it, &cac);
 
-#if 0
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Found exact address: %s           base address: %s\n",
-              (cac.exact_address != NULL) ? "YES" : "NO",
-              (cac.base_address != NULL) ? "YES" : "NO");
-#endif
   if (cac.exact_address == NULL)
     return cac.base_address;
   return cac.exact_address;
@@ -376,11 +425,6 @@ lookup_address (const struct GNUNET_PeerIdentity *peer,
                        plugin_addr, plugin_addr_len,
                        session_id);
 
-  aa->mlp_information = NULL;
-  aa->ats = GNUNET_malloc (atsi_count * sizeof (struct GNUNET_ATS_Information));
-  aa->ats_count = atsi_count;
-  memcpy (aa->ats, atsi, atsi_count * sizeof (struct GNUNET_ATS_Information));
-
   /* Get existing address or address with session == 0 */
   old = find_address (peer, aa);
   free_address (aa);
@@ -396,49 +440,6 @@ lookup_address (const struct GNUNET_PeerIdentity *peer,
 }
 
 
-#if DEADCODE
-static int
-compare_address_session_it (void *cls, const struct GNUNET_HashCode * key, void *value)
-{
-  struct CompareAddressContext *cac = cls;
-  struct ATS_Address *aa = value;
-
-  if ((aa->addr_len == cac->search->addr_len) && (0 == strcmp (aa->plugin, cac->search->plugin)))
-  {
-      if ((0 == memcmp (aa->addr, cac->search->addr, aa->addr_len)) && (aa->session_id == cac->search->session_id))
-      {
-        cac->exact_address = aa;
-        return GNUNET_NO;
-      }
-  }
-  return GNUNET_YES;
-}
-
-
-/**
- * Find an existing equivalent address record.
- * Compares by peer identity and network address AND by session ID
- * (one of the two must match).
- *
- * @param peer peer to lookup addresses for
- * @param addr existing address record
- * @return existing address record, NULL for none
- */
-static struct ATS_Address *
-find_exact_address (const struct GNUNET_PeerIdentity *peer,
-              const struct ATS_Address *addr)
-{
-  struct CompareAddressContext cac;
-
-  cac.exact_address = NULL;
-  cac.search = addr;
-  GNUNET_CONTAINER_multihashmap_get_multiple (addresses, &peer->hashPubKey,
-                                              &compare_address_session_it, &cac);
-  return cac.exact_address;
-}
-#endif
-
-
 void
 GAS_addresses_add (const struct GNUNET_PeerIdentity *peer,
                       const char *plugin_name, const void *plugin_addr,
@@ -448,21 +449,29 @@ GAS_addresses_add (const struct GNUNET_PeerIdentity *peer,
 {
   struct ATS_Address *aa;
   struct ATS_Address *old;
+  unsigned int ats_res;
+
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Received `%s' for peer `%s'\n",
+              "ADDRESS ADD",
+              GNUNET_i2s (peer));
 
-  if (GNUNET_NO == running)
+  if (GNUNET_NO == handle->running)
     return;
 
-  GNUNET_assert (NULL != addresses);
+  GNUNET_assert (NULL != handle->addresses);
 
   aa = create_address (peer,
                        plugin_name,
                        plugin_addr, plugin_addr_len,
                        session_id);
-
   aa->mlp_information = NULL;
-  aa->ats = GNUNET_malloc (atsi_count * sizeof (struct GNUNET_ATS_Information));
-  aa->ats_count = atsi_count;
-  memcpy (aa->ats, atsi, atsi_count * sizeof (struct GNUNET_ATS_Information));
+  if (atsi_count != (ats_res = disassemble_ats_information(atsi, atsi_count, aa)))
+  {
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                "While adding address: had %u ATS elements to add, could only add %u\n",
+                atsi_count, ats_res);
+  }
 
   /* Get existing address or address with session == 0 */
   old = find_address (peer, aa);
@@ -470,36 +479,40 @@ GAS_addresses_add (const struct GNUNET_PeerIdentity *peer,
   {
     /* We have a new address */
     GNUNET_assert (GNUNET_OK ==
-                   GNUNET_CONTAINER_multihashmap_put (addresses,
+                   GNUNET_CONTAINER_multihashmap_put (handle->addresses,
                                                       &peer->hashPubKey, aa,
                                                       GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE));
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Added new address for peer `%s' session id %u, %p\n",
                 GNUNET_i2s (peer), session_id, aa);
+    /* Tell solver about update */
+    handle->s_add (handle->solver, handle->addresses, aa);
     return;
   }
 
-  if (old->session_id == 0)
+  if (old->session_id != 0)
   {
-    /* We have a base address with out an session, update this address */
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Updated existing address for peer `%s' %p with new session %u\n",
-              GNUNET_i2s (peer), old, session_id);
-    GNUNET_free_non_null (old->ats);
-    old->session_id = session_id;
-    old->ats = NULL;
-    old->ats_count = 0;
-    old->ats = aa->ats;
-    old->ats_count = aa->ats_count;
-    GNUNET_free (aa->plugin);
-    GNUNET_free (aa);
-    return;
+      /* This address and session is already existing */
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                "Added already existing address for peer `%s' `%s' %p with new session %u\n",
+                GNUNET_i2s (peer), plugin_name, session_id);
+      GNUNET_break (0);
+      return;
   }
 
-  /* This address and session is already existing */
-  GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-            "Added already existing address for peer `%s' `%s' %p with new session %u\n",
-            GNUNET_i2s (peer), plugin_name, session_id);
-  GNUNET_break (0);
+  /* We have an address without an session, update this address */
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+            "Updated existing address for peer `%s' %p with new session %u\n",
+            GNUNET_i2s (peer), old, session_id);
+  old->session_id = session_id;
+  if (atsi_count != (ats_res = disassemble_ats_information(atsi, atsi_count, old)))
+  {
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                "While updating address: had %u ATS elements to add, could only add %u\n",
+                atsi_count, ats_res);
+  }
+  GNUNET_free (aa->plugin);
+  GNUNET_free (aa);
+  handle->s_add (handle->solver, handle->addresses, old);
 }
 
 
@@ -511,12 +524,17 @@ GAS_addresses_update (const struct GNUNET_PeerIdentity *peer,
                       uint32_t atsi_count)
 {
   struct ATS_Address *old;
-  uint32_t i;
+  uint32_t ats_res;
+
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                "Received `%s' for peer `%s'\n",
+                "ADDRESS UPDATE",
+                GNUNET_i2s (peer));
 
-  if (GNUNET_NO == running)
+  if (GNUNET_NO == handle->running)
     return;
 
-  GNUNET_assert (NULL != addresses);
+  GNUNET_assert (NULL != handle->addresses);
 
   /* Get existing address */
   old = lookup_address (peer, plugin_name, plugin_addr, plugin_addr_len,
@@ -529,44 +547,15 @@ GAS_addresses_update (const struct GNUNET_PeerIdentity *peer,
     return;
   }
 
-  for (i = 0; i < atsi_count; i++)
-    switch (ntohl (atsi[i].type))
-    {
-    case GNUNET_ATS_UTILIZATION_UP:
-      old->atsp_utilization_out.value__ = atsi[i].value;
-      break;
-    case GNUNET_ATS_UTILIZATION_DOWN:
-      old->atsp_utilization_in.value__ = atsi[i].value;
-      break;
-    case GNUNET_ATS_QUALITY_NET_DELAY:
-      old->atsp_latency.rel_value = ntohl (atsi[i].value);
-      break;
-    case GNUNET_ATS_QUALITY_NET_DISTANCE:
-      old->atsp_distance = ntohl (atsi[i].value);
-      break;
-    case GNUNET_ATS_COST_WAN:
-      old->atsp_cost_wan = ntohl (atsi[i].value);
-      break;
-    case GNUNET_ATS_COST_LAN:
-      old->atsp_cost_lan = ntohl (atsi[i].value);
-      break;
-    case GNUNET_ATS_COST_WLAN:
-      old->atsp_cost_wlan = ntohl (atsi[i].value);
-      break;
-    case GNUNET_ATS_NETWORK_TYPE:
-      old->atsp_network_type = ntohl (atsi[i].value);
-      break;
+  if (atsi_count != (ats_res = disassemble_ats_information (atsi, atsi_count, old)))
+  {
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                "While adding address: had %u ATS elements to add, could only add %u\n",
+                atsi_count, ats_res);
+  }
 
-    default:
-      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
-                  "Received unsupported ATS type %u\n", ntohl (atsi[i].type));
-      GNUNET_break (0);
-      break;
-    }
-#if HAVE_LIBGLPK
-  if (ats_mode == MODE_MLP)
-    GAS_mlp_address_update (solver, addresses, old);
-#endif
+  /* Tell solver about update */
+  handle->s_update (handle->solver, handle->addresses, old);
 }
 
 
@@ -601,8 +590,8 @@ destroy_by_session_id (void *cls, const struct GNUNET_HashCode * key, void *valu
                 "Deleting address for peer `%s': `%s' %u\n",
                 GNUNET_i2s (&aa->peer), aa->plugin, aa->session_id);
 
-    if (GNUNET_YES == destroy_address (aa))
-      recalculate_assigned_bw ();
+    destroy_address (aa);
+      // FIXME if (GNUNET_YES == destroy_address (aa))recalculate_assigned_bw ();
     return GNUNET_OK;
   }
   /* session != 0, just remove session */
@@ -619,8 +608,7 @@ destroy_by_session_id (void *cls, const struct GNUNET_HashCode * key, void *valu
   if (GNUNET_YES == aa->active)
   {
     aa->active = GNUNET_NO;
-    active_addr_count--;
-    recalculate_assigned_bw ();
+    //FIXME recalculate_assigned_bw ();
   }
 
   /* session == 0 and addrlen == 0 : destroy address */
@@ -635,8 +623,8 @@ destroy_by_session_id (void *cls, const struct GNUNET_HashCode * key, void *valu
   {
     /* session was set to 0, update address */
 #if HAVE_LIBGLPK
-  if (ats_mode == MODE_MLP)
-    GAS_mlp_address_update (solver, addresses, aa);
+  if (handle->ats_mode == MODE_MLP)
+    GAS_mlp_address_update (handle->solver, handle->addresses, aa);
 #endif
   }
 
@@ -652,7 +640,12 @@ GAS_addresses_destroy (const struct GNUNET_PeerIdentity *peer,
   struct ATS_Address *aa;
   struct ATS_Address *old;
 
-  if (GNUNET_NO == running)
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Received `%s' for peer `%s'\n",
+              "ADDRESS DESTROY",
+              GNUNET_i2s (peer));
+
+  if (GNUNET_NO == handle->running)
     return;
 
   /* Get existing address */
@@ -665,120 +658,27 @@ GAS_addresses_destroy (const struct GNUNET_PeerIdentity *peer,
     return;
   }
 
-
   GNUNET_break (0 < strlen (plugin_name));
   aa = create_address (peer, plugin_name, plugin_addr, plugin_addr_len, session_id);
-
-  GNUNET_CONTAINER_multihashmap_get_multiple (addresses, &peer->hashPubKey,
+  GNUNET_CONTAINER_multihashmap_get_multiple (handle->addresses, &peer->hashPubKey,
                                               &destroy_by_session_id, aa);
-
   free_address (aa);
 }
 
 
-/**
- * Find a "good" address to use for a peer.  If we already have an existing
- * address, we stick to it.  Otherwise, we pick by lowest distance and then
- * by lowest latency.
- *
- * @param cls the 'struct ATS_Address**' where we store the result
- * @param key unused
- * @param value another 'struct ATS_Address*' to consider using
- * @return GNUNET_OK (continue to iterate)
- */
-static int
-find_address_it (void *cls, const struct GNUNET_HashCode * key, void *value)
-{
-  struct ATS_Address **ap = cls;
-  struct ATS_Address *aa = (struct ATS_Address *) value;
-  struct ATS_Address *ab = *ap;
-  struct GNUNET_TIME_Absolute now;
-
-  now = GNUNET_TIME_absolute_get();
-
-  if (aa->blocked_until.abs_value == GNUNET_TIME_absolute_max (now, aa->blocked_until).abs_value)
-  {
-    /* This address is blocked for suggestion */
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Address %p blocked for suggestion for %llu ms \n",
-                aa,
-                GNUNET_TIME_absolute_get_difference(now, aa->blocked_until).rel_value);
-    return GNUNET_OK;
-  }
-
-  aa->block_interval = GNUNET_TIME_relative_add (aa->block_interval, ATS_BLOCKING_DELTA);
-  aa->blocked_until = GNUNET_TIME_absolute_add (now, aa->block_interval);
-
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Address %p ready for suggestion, block interval now %llu \n", aa, aa->block_interval);
-
-  /* FIXME this is a hack */
-
-
-  if (NULL != ab)
-  {
-    if ((0 == strcmp (ab->plugin, "tcp")) &&
-        (0 == strcmp (aa->plugin, "tcp")))
-    {
-      if ((0 != ab->addr_len) &&
-          (0 == aa->addr_len))
-      {
-        /* saved address was an outbound address, but we have an inbound address */
-        *ap = aa;
-        return GNUNET_OK;
-      }
-      if (0 == ab->addr_len)
-      {
-        /* saved address was an inbound address, so do not overwrite */
-        return GNUNET_OK;
-      }
-    }
-  }
-  /* FIXME end of hack */
-
-  if (NULL == ab)
-  {
-    *ap = aa;
-    return GNUNET_OK;
-  }
-  if ((ntohl (ab->assigned_bw_in.value__) == 0) &&
-      (ntohl (aa->assigned_bw_in.value__) > 0))
-  {
-    /* stick to existing connection */
-    *ap = aa;
-    return GNUNET_OK;
-  }
-  if (ab->atsp_distance > aa->atsp_distance)
-  {
-    /* user shorter distance */
-    *ap = aa;
-    return GNUNET_OK;
-  }
-  if (ab->atsp_latency.rel_value > aa->atsp_latency.rel_value)
-  {
-    /* user lower latency */
-    *ap = aa;
-    return GNUNET_OK;
-  }
-  /* don't care */
-  return GNUNET_OK;
-}
-
-
 int
 GAS_addresses_in_use (const struct GNUNET_PeerIdentity *peer,
                       const char *plugin_name, const void *plugin_addr,
                       size_t plugin_addr_len, uint32_t session_id, int in_use)
 {
-#if DEBUG_ATS
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Received `%s' message for peer `%s': %i\n", "ADDRESS_IN_USE",
-              GNUNET_i2s (peer), in_use);
-#endif
-
   struct ATS_Address *old;
 
-  if (GNUNET_NO == running)
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                "Received `%s' for peer `%s'\n",
+                "ADDRESS IN USE",
+                GNUNET_i2s (peer));
+
+  if (GNUNET_NO == handle->running)
     return GNUNET_SYSERR;
 
   old = lookup_address (peer, plugin_name, plugin_addr, plugin_addr_len, session_id, NULL, 0);
@@ -803,112 +703,110 @@ GAS_addresses_in_use (const struct GNUNET_PeerIdentity *peer,
     return GNUNET_SYSERR;
   }
   old->used = in_use;
-#if HAVE_LIBGLPK
-  if (ats_mode == MODE_MLP)
-     GAS_mlp_address_update (solver, addresses, old);
-#endif
+
+  /* Tell solver about update */
+  handle->s_update (handle->solver, handle->addresses, old);
+
   return GNUNET_OK;
 }
 
 
-static void 
-request_address_mlp (const struct GNUNET_PeerIdentity *peer)
+/**
+ * Cancel address suggestions for a peer
+ *
+ * @param peer the respective peer
+ */
+void
+GAS_addresses_request_address_cancel (const struct GNUNET_PeerIdentity *peer)
 {
-  struct ATS_Address *aa;
-  aa = NULL;
-
-#if HAVE_GLPK
-  /* Get preferred address from MODE_MLP */
-  struct ATS_PreferedAddress * paddr = NULL;
-  paddr = GAS_mlp_get_preferred_address (mlp, addresses, peer);
-  aa = paddr->address;
-  aa->assigned_bw_out = GNUNET_BANDWIDTH_value_init(paddr->bandwidth_out);
-  /* FIXME use bw in value */
-  paddr->bandwidth_in = paddr->bandwidth_out;
-  aa->assigned_bw_in = GNUNET_BANDWIDTH_value_init (paddr->bandwidth_in);
-  GNUNET_free (paddr);
-#endif
+  struct GAS_Addresses_Suggestion_Requests *cur = handle->r_head;
+
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Received request: `%s' for peer %s\n", "request_address_cancel", GNUNET_i2s (peer));
 
-  if (aa == NULL)
+  while (NULL != cur)
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
-                "Cannot suggest address for peer `%s'\n", GNUNET_i2s (peer));
-    return;
+      if (0 == memcmp (peer, &cur->id, sizeof (cur->id)))
+        break; /* found */
+      cur = cur->next;
   }
-  if (aa->active == GNUNET_NO)
-  {
-    aa->active = GNUNET_YES;
-    active_addr_count++;
 
-    send_bw_notification (aa);
-  }
-  else
+  if (NULL == cur)
   {
-    /* just to be sure... */
-    GAS_scheduling_transmit_address_suggestion (peer, aa->plugin, aa->addr,
-                                                aa->addr_len, aa->session_id,
-                                                aa->ats, aa->ats_count,
-                                                aa->assigned_bw_out,
-                                                aa->assigned_bw_in);
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                  "No address requests pending for peer `%s', cannot remove!\n", GNUNET_i2s (peer));
+      return;
   }
-
+  GAS_addresses_handle_backoff_reset (peer);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Removed request pending for peer `%s\n", GNUNET_i2s (peer));
+  GNUNET_CONTAINER_DLL_remove (handle->r_head, handle->r_tail, cur);
+  GNUNET_free (cur);
 }
 
 
-static void 
-request_address_simple (const struct GNUNET_PeerIdentity *peer)
+/**
+ * Add an address suggestions for a peer
+ *
+ * @param peer the respective peer
+ */
+void
+GAS_addresses_request_address (const struct GNUNET_PeerIdentity *peer)
 {
+  struct GAS_Addresses_Suggestion_Requests *cur = handle->r_head;
   struct ATS_Address *aa;
-  aa = NULL;
+  struct GNUNET_ATS_Information *ats;
+  unsigned int ats_count;
+
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Received `%s' for peer `%s'\n",
+              "REQUEST ADDRESS",
+              GNUNET_i2s (peer));
+
+  if (GNUNET_NO == handle->running)
+    return;
+  while (NULL != cur)
+  {
+      if (0 == memcmp (peer, &cur->id, sizeof (cur->id)))
+        break; /* already suggesting */
+      cur = cur->next;
+  }
+  if (NULL == cur)
+  {
+      cur = GNUNET_malloc (sizeof (struct GAS_Addresses_Suggestion_Requests));
+      cur->id = (*peer);
+      GNUNET_CONTAINER_DLL_insert (handle->r_head, handle->r_tail, cur);
+  }
 
-  /* Get address with: stick to current address, lower distance, lower latency */
-  GNUNET_CONTAINER_multihashmap_get_multiple (addresses, &peer->hashPubKey,
-                                              &find_address_it, &aa);
-  if (aa == NULL)
+  /* Get prefered address from solver */
+  aa = (struct ATS_Address *) handle->s_get (handle->solver, handle->addresses, peer);
+  if (NULL == aa)
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                 "Cannot suggest address for peer `%s'\n", GNUNET_i2s (peer));
     return;
   }
 
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Suggesting address %p for peer `%s'\n", aa, GNUNET_i2s (peer));
 
-  if (aa->active == GNUNET_NO)
-  {
-    aa->active = GNUNET_YES;
-    active_addr_count++;
-    if (ats_mode == MODE_SIMPLISTIC)
-    {
-      recalculate_assigned_bw ();
-    }
-  }
-  else
-  {
-    /* just to be sure... */
-    GAS_scheduling_transmit_address_suggestion (peer, aa->plugin, aa->addr,
-                                                aa->addr_len, aa->session_id,
-                                                aa->ats, aa->ats_count,
-                                                aa->assigned_bw_out,
-                                                aa->assigned_bw_in);
-  }
-}
+  ats_count = assemble_ats_information (aa, &ats);
+  GAS_scheduling_transmit_address_suggestion (peer,
+                                              aa->plugin,
+                                              aa->addr, aa->addr_len,
+                                              aa->session_id,
+                                              ats, ats_count,
+                                              aa->assigned_bw_out,
+                                              aa->assigned_bw_in);
 
+  aa->block_interval = GNUNET_TIME_relative_add (aa->block_interval, ATS_BLOCKING_DELTA);
+  aa->blocked_until = GNUNET_TIME_absolute_add (GNUNET_TIME_absolute_get(), aa->block_interval);
 
-void
-GAS_addresses_request_address (const struct GNUNET_PeerIdentity *peer)
-{
-  if (GNUNET_NO == running)
-    return;
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+       "Address %p ready for suggestion, block interval now %llu \n",
+       aa, aa->block_interval);
 
-  if (ats_mode == MODE_SIMPLISTIC)
-  {
-    request_address_simple (peer);
-  }
-  if (ats_mode == MODE_MLP)
-  {
-    request_address_mlp(peer);
-  }
+  GNUNET_free (ats);
 }
 
 
@@ -918,7 +816,8 @@ reset_address_it (void *cls, const struct GNUNET_HashCode * key, void *value)
   struct ATS_Address *aa = value;
 
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Resetting interval for peer `%s' address %p from %llu to 0\n", GNUNET_i2s (&aa->peer), aa, aa->block_interval);
+              "Resetting interval for peer `%s' address %p from %llu to 0\n",
+              GNUNET_i2s (&aa->peer), aa, aa->block_interval);
 
   aa->blocked_until = GNUNET_TIME_UNIT_ZERO_ABS;
   aa->block_interval = GNUNET_TIME_UNIT_ZERO;
@@ -929,30 +828,152 @@ reset_address_it (void *cls, const struct GNUNET_HashCode * key, void *value)
 void
 GAS_addresses_handle_backoff_reset (const struct GNUNET_PeerIdentity *peer)
 {
-  GNUNET_break (GNUNET_SYSERR != GNUNET_CONTAINER_multihashmap_get_multiple (addresses,
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Received `%s' for peer `%s'\n",
+              "RESET BACKOFF",
+              GNUNET_i2s (peer));
+
+  GNUNET_break (GNUNET_SYSERR != GNUNET_CONTAINER_multihashmap_get_multiple (handle->addresses,
                                               &peer->hashPubKey,
                                               &reset_address_it,
                                               NULL));
 }
 
 
-
-// FIXME: this function should likely end up in the LP-subsystem and
-// not with 'addresses' in the future...
 void
 GAS_addresses_change_preference (const struct GNUNET_PeerIdentity *peer,
                                  enum GNUNET_ATS_PreferenceKind kind,
                                  float score)
 {
-  if (GNUNET_NO == running)
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Received `%s' for peer `%s'\n",
+              "CHANGE PREFERENCE",
+              GNUNET_i2s (peer));
+
+  if (GNUNET_NO == handle->running)
     return;
-#if HAVE_LIBGLPK
-  if (ats_mode == MODE_MLP)
-    GAS_mlp_address_change_preference (solver, peer, kind, score);
-#endif
+
+  /* Tell solver about update */
+  handle->s_pref (handle->solver, peer, kind, score);
+}
+
+static unsigned int
+load_quotas (const struct GNUNET_CONFIGURATION_Handle *cfg, unsigned long long *out_dest, unsigned long long *in_dest, int dest_length)
+{
+  int quotas[GNUNET_ATS_NetworkTypeCount] = GNUNET_ATS_NetworkType;
+  char * entry_in = NULL;
+  char * entry_out = NULL;
+  char * quota_out_str;
+  char * quota_in_str;
+  int c;
+
+  for (c = 0; (c < GNUNET_ATS_NetworkTypeCount) && (c < dest_length); c++)
+  {
+    in_dest[c] = 0;
+    out_dest[c] = 0;
+    switch (quotas[c]) {
+      case GNUNET_ATS_NET_UNSPECIFIED:
+        entry_out = "UNSPECIFIED_QUOTA_OUT";
+        entry_in = "UNSPECIFIED_QUOTA_IN";
+        break;
+      case GNUNET_ATS_NET_LOOPBACK:
+        entry_out = "LOOPBACK_QUOTA_OUT";
+        entry_in = "LOOPBACK_QUOTA_IN";
+        break;
+      case GNUNET_ATS_NET_LAN:
+        entry_out = "LAN_QUOTA_OUT";
+        entry_in = "LAN_QUOTA_IN";
+        break;
+      case GNUNET_ATS_NET_WAN:
+        entry_out = "WAN_QUOTA_OUT";
+        entry_in = "WAN_QUOTA_IN";
+        break;
+      case GNUNET_ATS_NET_WLAN:
+        entry_out = "WLAN_QUOTA_OUT";
+        entry_in = "WLAN_QUOTA_IN";
+        break;
+      default:
+        break;
+    }
+
+    if ((entry_in == NULL) || (entry_out == NULL))
+      continue;
+
+    /* quota out */
+    if (GNUNET_OK == GNUNET_CONFIGURATION_get_value_string(cfg, "ats", entry_out, &quota_out_str))
+    {
+      if (0 == strcmp(quota_out_str, BIG_M_STRING) ||
+          (GNUNET_SYSERR == GNUNET_STRINGS_fancy_size_to_bytes (quota_out_str, &out_dest[c])))
+        out_dest[c] = UINT32_MAX;
+
+      GNUNET_free (quota_out_str);
+      quota_out_str = NULL;
+    }
+    else if (GNUNET_ATS_NET_UNSPECIFIED == quotas[c])
+      out_dest[c] = UINT32_MAX;
+    else
+      out_dest[c] = UINT32_MAX;
+
+    /* quota in */
+    if (GNUNET_OK == GNUNET_CONFIGURATION_get_value_string(cfg, "ats", entry_in, &quota_in_str))
+    {
+      if (0 == strcmp(quota_in_str, BIG_M_STRING) ||
+          (GNUNET_SYSERR == GNUNET_STRINGS_fancy_size_to_bytes (quota_in_str, &in_dest[c])))
+        in_dest[c] = UINT32_MAX;
+
+      GNUNET_free (quota_in_str);
+      quota_in_str = NULL;
+    }
+    else if (GNUNET_ATS_NET_UNSPECIFIED == quotas[c])
+    {
+      in_dest[c] = UINT32_MAX;
+    }
+    else
+    {
+        in_dest[c] = UINT32_MAX;
+    }
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Loaded quota: %s %u, %s %u\n", entry_in, in_dest[c], entry_out, out_dest[c]);
+
+  }
+  return GNUNET_ATS_NetworkTypeCount;
 }
 
 
+static void
+bandwidth_changed_cb (struct ATS_Address *address)
+{
+  struct GAS_Addresses_Suggestion_Requests *cur;
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Bandwidth assignment changed for peer %s \n", GNUNET_i2s(&address->peer));
+  struct GNUNET_ATS_Information *ats;
+  unsigned int ats_count;
+
+  cur = handle->r_head;
+  while (NULL != cur)
+  {
+      if (0 == memcmp (&address->peer, &cur->id, sizeof (cur->id)))
+        break; /* we have an address request pending*/
+      cur = cur->next;
+  }
+  if (NULL == cur)
+  {
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                  "Nobody is interested in peer `%s' :(\n",GNUNET_i2s (&address->peer));
+      return;
+  }
+
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Sending bandwidth update for peer `%s'\n",GNUNET_i2s (&address->peer));
+
+  ats_count = assemble_ats_information (address, &ats);
+  GAS_scheduling_transmit_address_suggestion (&address->peer,
+                                              address->plugin,
+                                              address->addr, address->addr_len,
+                                              address->session_id,
+                                              ats, ats_count,
+                                              address->assigned_bw_out,
+                                              address->assigned_bw_in);
+}
+
 
 /**
  * Initialize address subsystem.
@@ -960,54 +981,31 @@ GAS_addresses_change_preference (const struct GNUNET_PeerIdentity *peer,
  * @param cfg configuration to use
  * @param stats the statistics handle to use
  */
-void
+struct GAS_Addresses_Handle *
 GAS_addresses_init (const struct GNUNET_CONFIGURATION_Handle *cfg,
                     const struct GNUNET_STATISTICS_Handle *stats)
 {
-  int c;
-  char *quota_wan_in_str;
-  char *quota_wan_out_str;
+  struct GAS_Addresses_Handle *ah;
+  int quotas[GNUNET_ATS_NetworkTypeCount] = GNUNET_ATS_NetworkType;
+  unsigned long long  quotas_in[GNUNET_ATS_NetworkTypeCount];
+  unsigned long long  quotas_out[GNUNET_ATS_NetworkTypeCount];
+  int quota_count;
   char *mode_str;
-  running = GNUNET_NO;
-
-  /* Initialize the system with configuration values */
-  if (GNUNET_OK == GNUNET_CONFIGURATION_get_value_string(cfg, "ats", "WAN_QUOTA_IN", &quota_wan_in_str))
-  {
-    if (0 == strcmp(quota_wan_in_str, "unlimited") ||
-        (GNUNET_SYSERR == GNUNET_STRINGS_fancy_size_to_bytes (quota_wan_in_str, &wan_quota_in)))
-      wan_quota_in = (UINT32_MAX) /10;
-
-    GNUNET_free (quota_wan_in_str);
-    quota_wan_in_str = NULL;
-  }
-  else
-  {
-    wan_quota_in = (UINT32_MAX) /10;
-  }
+  int c;
 
-  if (GNUNET_OK == GNUNET_CONFIGURATION_get_value_string(cfg, "ats", "WAN_QUOTA_OUT", &quota_wan_out_str))
-  {
-    if (0 == strcmp(quota_wan_out_str, "unlimited") ||
-        (GNUNET_SYSERR == GNUNET_STRINGS_fancy_size_to_bytes (quota_wan_out_str, &wan_quota_out)))
-      wan_quota_out = (UINT32_MAX) /10;
-
-    GNUNET_free (quota_wan_out_str);
-    quota_wan_out_str = NULL;
-  }
-  else
-  {
-    wan_quota_out = (UINT32_MAX) /10;
-  }
+  ah = GNUNET_malloc (sizeof (struct GAS_Addresses_Handle));
+  handle = ah;
+  handle->running = GNUNET_NO;
 
   /* Initialize the addresses database */
-  addresses = GNUNET_CONTAINER_multihashmap_create (128, GNUNET_NO);
-  GNUNET_assert (NULL != addresses);
+  ah->addresses = GNUNET_CONTAINER_multihashmap_create (128, GNUNET_NO);
+  GNUNET_assert (NULL != ah->addresses);
 
   /* Figure out configured solution method */
   if (GNUNET_SYSERR == GNUNET_CONFIGURATION_get_value_string (cfg, "ats", "MODE", &mode_str))
   {
       GNUNET_log (GNUNET_ERROR_TYPE_WARNING, "No ressource assignment method configured, using simplistic approch\n");
-      ats_mode = MODE_SIMPLISTIC;
+      ah->ats_mode = MODE_SIMPLISTIC;
   }
   else
   {
@@ -1015,57 +1013,80 @@ GAS_addresses_init (const struct GNUNET_CONFIGURATION_Handle *cfg,
         mode_str[c] = toupper (mode_str[c]);
       if (0 == strcmp (mode_str, "SIMPLISTIC"))
       {
-          ats_mode = MODE_SIMPLISTIC;
+          ah->ats_mode = MODE_SIMPLISTIC;
       }
       else if (0 == strcmp (mode_str, "MLP"))
       {
-          ats_mode = MODE_MLP;
+          ah->ats_mode = MODE_MLP;
 #if !HAVE_LIBGLPK
           GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Assignment method `%s' configured, but GLPK is not availabe, please install \n", mode_str);
-          ats_mode = MODE_SIMPLISTIC;
+          ah->ats_mode = MODE_SIMPLISTIC;
 #endif
       }
       else
       {
           GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Invalid ressource assignment method `%s' configured, using simplistic approch\n", mode_str);
-          ats_mode = MODE_SIMPLISTIC;
+          ah->ats_mode = MODE_SIMPLISTIC;
       }
+      GNUNET_free (mode_str);
   }
-
   /* Start configured solution method */
-  switch (ats_mode)
+  switch (ah->ats_mode)
   {
     case MODE_MLP:
       /* Init the MLP solver with default values */
-      solver = GAS_mlp_init (cfg, stats, MLP_MAX_EXEC_DURATION, MLP_MAX_ITERATIONS);
-      if (NULL != solver)
-      {
-          ats_mode = MODE_MLP;
-          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "ATS started in %s mode\n", "MLP");
-          break;
-      }
-      GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Failed to initialize MLP solver!\n");
+#if HAVE_LIBGLPK
+      ah->ats_mode = MODE_MLP;
+      ah->s_init = &GAS_mlp_init;
+      ah->s_add = &GAS_mlp_address_add;
+      ah->s_update = &GAS_mlp_address_update;
+      ah->s_get = &GAS_mlp_get_preferred_address;
+      ah->s_pref = &GAS_mlp_address_change_preference;
+      ah->s_del =  &GAS_mlp_address_delete;
+      ah->s_done = &GAS_mlp_done;
+#else
+      GNUNET_free (ah);
+      return NULL;
+#endif
+      break;
     case MODE_SIMPLISTIC:
       /* Init the simplistic solver with default values */
+      ah->ats_mode = MODE_SIMPLISTIC;
+      ah->s_init = &GAS_simplistic_init;
+      ah->s_add = &GAS_simplistic_address_add;
+      ah->s_update = &GAS_simplistic_address_update;
+      ah->s_get = &GAS_simplistic_get_preferred_address;
+      ah->s_pref = &GAS_simplistic_address_change_preference;
+      ah->s_del  = &GAS_simplistic_address_delete;
+      ah->s_done = &GAS_simplistic_done;
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "ATS started in %s mode\n", "SIMPLISTIC");
-      solver = GAS_simplistic_init (cfg, stats);
-      if (NULL != solver)
-      {
-          ats_mode = MODE_SIMPLISTIC;
-          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "ATS started in %s mode\n", "SIMPLISTIC");
-          break;
-      }
-      else
-      {
-        GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Failed to initialize simplistic solver!\n");
-        return;
-      }
       break;
     default:
+      return NULL;
       break;
   }
+
+  GNUNET_assert (NULL != ah->s_init);
+  GNUNET_assert (NULL != ah->s_add);
+  GNUNET_assert (NULL != ah->s_update);
+  GNUNET_assert (NULL != ah->s_get);
+  GNUNET_assert (NULL != ah->s_pref);
+  GNUNET_assert (NULL != ah->s_del);
+  GNUNET_assert (NULL != ah->s_done);
+
+  quota_count = load_quotas(cfg, quotas_in, quotas_out, GNUNET_ATS_NetworkTypeCount);
+
+  ah->solver = ah->s_init (cfg, stats, quotas, quotas_in, quotas_out, quota_count, &bandwidth_changed_cb);
+  if (NULL == ah->solver)
+  {
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Failed to initialize solver!\n");
+    GNUNET_free (ah);
+    return NULL;
+  }
+
   /* up and running */
-  running = GNUNET_YES;
+  ah->running = GNUNET_YES;
+  return ah;
 }
 
 
@@ -1090,12 +1111,11 @@ free_address_it (void *cls, const struct GNUNET_HashCode * key, void *value)
 void
 GAS_addresses_destroy_all ()
 {
-  if (GNUNET_NO == running)
+  if (GNUNET_NO == handle->running)
     return;
 
-  if (addresses != NULL)
-    GNUNET_CONTAINER_multihashmap_iterate (addresses, &free_address_it, NULL);
-  GNUNET_assert (active_addr_count == 0);
+  if (handle->addresses != NULL)
+    GNUNET_CONTAINER_multihashmap_iterate (handle->addresses, &free_address_it, NULL);
 }
 
 
@@ -1103,27 +1123,26 @@ GAS_addresses_destroy_all ()
  * Shutdown address subsystem.
  */
 void
-GAS_addresses_done ()
+GAS_addresses_done (struct GAS_Addresses_Handle *handle)
 {
-  GAS_addresses_destroy_all ();
-  running = GNUNET_NO;
-  GNUNET_CONTAINER_multihashmap_destroy (addresses);
-  addresses = NULL;
+  struct GAS_Addresses_Suggestion_Requests *cur;
 
-  /* Stop configured solution method */
-  switch (ats_mode)
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Shutting down addresses\n");
+  GNUNET_assert (NULL != handle);
+  GAS_addresses_destroy_all ();
+  handle->running = GNUNET_NO;
+  GNUNET_CONTAINER_multihashmap_destroy (handle->addresses);
+  handle->addresses = NULL;
+  while (NULL != (cur = handle->r_head))
   {
-    case MODE_MLP:
-      /* Init the MLP solver with default values */
-      GAS_mlp_done (solver);
-      break;
-    case MODE_SIMPLISTIC:
-      /* Init the simplistic solver with default values */
-      GAS_simplistic_done (solver);
-      break;
-    default:
-      break;
+      GNUNET_CONTAINER_DLL_remove (handle->r_head, handle->r_tail, cur);
+      GNUNET_free (cur);
   }
+  handle->s_done (handle->solver);
+  GNUNET_free (handle);
+  /* Stop configured solution method */
+
 }
 
 struct PeerIteratorContext
@@ -1166,15 +1185,15 @@ GAS_addresses_iterate_peers (GNUNET_ATS_Peer_Iterator p_it, void *p_it_cls)
 
   if (NULL == p_it)
       return;
-  GNUNET_assert (NULL != addresses);
+  GNUNET_assert (NULL != handle->addresses);
 
-  size = GNUNET_CONTAINER_multihashmap_size(addresses);
+  size = GNUNET_CONTAINER_multihashmap_size(handle->addresses);
   if (0 != size)
   {
     ip_ctx.it = p_it;
     ip_ctx.it_cls = p_it_cls;
     ip_ctx.peers_returned = GNUNET_CONTAINER_multihashmap_create (size, GNUNET_NO);
-    GNUNET_CONTAINER_multihashmap_iterate (addresses, &peer_it, &ip_ctx);
+    GNUNET_CONTAINER_multihashmap_iterate (handle->addresses, &peer_it, &ip_ctx);
     GNUNET_CONTAINER_multihashmap_destroy (ip_ctx.peers_returned);
   }
   p_it (p_it_cls, NULL);
@@ -1228,7 +1247,7 @@ GAS_addresses_get_peer_info (const struct GNUNET_PeerIdentity *peer, GNUNET_ATS_
   struct PeerInfoIteratorContext pi_ctx;
   struct GNUNET_BANDWIDTH_Value32NBO zero_bw;
   GNUNET_assert (NULL != peer);
-  GNUNET_assert (NULL != addresses);
+  GNUNET_assert (NULL != handle->addresses);
   if (NULL == pi_it)
     return; /* does not make sense without callback */
 
@@ -1236,7 +1255,7 @@ GAS_addresses_get_peer_info (const struct GNUNET_PeerIdentity *peer, GNUNET_ATS_
   pi_ctx.it = pi_it;
   pi_ctx.it_cls = pi_it_cls;
 
-  GNUNET_CONTAINER_multihashmap_get_multiple (addresses, &peer->hashPubKey, &peerinfo_it, &pi_ctx);
+  GNUNET_CONTAINER_multihashmap_get_multiple (handle->addresses, &peer->hashPubKey, &peerinfo_it, &pi_ctx);
 
   if (NULL != pi_it)
     pi_it (pi_it_cls, NULL, NULL, NULL, 0, GNUNET_NO, NULL, 0, zero_bw, zero_bw);