solver has to suggest address
[oweals/gnunet.git] / src / ats / gnunet-service-ats-solver_proportional.c
index 03cba6eb1a4b0746918faa982b0d94d57995221d..14e1c8ffcedf1ef3e9727a4a7c618ca4725adce7 100644 (file)
@@ -1,22 +1,22 @@
 /*
    This file is part of GNUnet.
    (C) 2011 Christian Grothoff (and other contributing authors)
-
    GNUnet is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published
    by the Free Software Foundation; either version 3, or (at your
    option) any later version.
-
    GNUnet is distributed in the hope that it will be useful, but
    WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
    General Public License for more details.
-
    You should have received a copy of the GNU General Public License
    along with GNUnet; see the file COPYING.  If not, write to the
    Free Software Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.
-*/
+ This file is part of GNUnet.
+ (C) 2011 Christian Grothoff (and other contributing authors)
+
+ GNUnet is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published
+ by the Free Software Foundation; either version 3, or (at your
+ option) any later version.
+
+ GNUnet is distributed in the hope that it will be useful, but
+ WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with GNUnet; see the file COPYING.  If not, write to the
+ Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+ Boston, MA 02111-1307, USA.
+ */
 
 /**
  * @file ats/gnunet-service-ats-solver_proportional.c
@@ -37,9 +37,9 @@
  * on gnunet.org:/vcs/fsnsg/ats-paper.git/tech-doku/ats-tech-guide.tex
  * use build_txt.sh to generate plaintext output
  *
- * ATS addresses : simplistic solver
+ * ATS addresses : proportional solver
  *
- *    The simplistic solver ("simplistic") distributes the available
+ *    The proportional solver ("proportional") distributes the available
  *    bandwidth fair over all the addresses influenced by the
  *    preference values. For each available network type an in- and
  *    outbound quota is configured and the bandwidth available in
  *    is used to specify network related information as total adresses
  *    and active addresses in this network and the configured in- and
  *    outbound quota. Each network also contains a list of addresses
- *    added to the solver located in this network. The simplistic
+ *    added to the solver located in this network. The proportional
  *    solver uses the addresses' solver_information field to store the
- *    simplistic network it belongs to for each address.
+ *    proportional network it belongs to for each address.
  *
  *     3.2 Initializing
  *
- *    When the simplistic solver is initialized the solver creates a
+ *    When the proportional solver is initialized the solver creates a
  *    new solver handle and initializes the network structures with
  *    the quotas passed from addresses and returns the handle solver.
  *
@@ -95,7 +95,7 @@
  *     3.4 Updating an address
  *
  *    The main purpose of address updates is to update the ATS
- *    information for addresse selection. Important for the simplistic
+ *    information for addresse selection. Important for the proportional
  *    solver is when an address switches network it is located
  *    in. This is common because addresses added by transport's
  *    validation mechanism are commonly located in
  *    return of payload data transport switches to the real network
  *    the address is located in.  When an address changes networks it
  *    is first of all removed from the old network using the solver
- *    API function GAS_simplistic_address_delete and the network in
+ *    API function GAS_proportional_address_delete and the network in
  *    the address struct is updated. A lookup for the respective new
- *    simplistic network is done and stored in the addresse's
+ *    proportional network is done and stored in the addresse's
  *    solver_information field. Next the address is re-added to the
  *    solver using the solver API function
- *    GAS_simplistic_address_add. If the address was marked as in
+ *    GAS_proportional_address_add. If the address was marked as in
  *    active, the solver checks if bandwidth is available in the
  *    network and if yes sets the address to active and updates the
  *    bandwidth distribution in this network. If no bandwidth is
 #define DEFAULT_ABS_PREFERENCE 0.0
 #define MIN_UPDATE_INTERVAL GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 10)
 
-
 /**
  * A handle for the proportional solver
  */
@@ -228,6 +227,11 @@ struct GAS_PROPORTIONAL_Handle
    */
   const struct GNUNET_CONTAINER_MultiHashMap *addresses;
 
+  /**
+   * Pending address requests
+   */
+  struct GNUNET_CONTAINER_MultiHashMap *requests;
+
   /**
    * Bandwidth changed callback
    */
@@ -268,7 +272,6 @@ struct GAS_PROPORTIONAL_Handle
    */
   int bulk_requests;
 
-
   /**
    * Total number of addresses for solver
    */
@@ -291,7 +294,6 @@ struct GAS_PROPORTIONAL_Handle
 
 };
 
-
 /**
  * Representation of a network
  */
@@ -343,7 +345,6 @@ struct Network
   struct AddressWrapper *tail;
 };
 
-
 /**
  * Wrapper for addresses to store them in network's linked list
  */
@@ -365,8 +366,6 @@ struct AddressWrapper
   struct ATS_Address *addr;
 };
 
-
-
 /**
  *  Important solver functions
  *  ---------------------------
@@ -381,27 +380,24 @@ struct AddressWrapper
 static int
 is_bandwidth_available_in_network (struct Network *net)
 {
-       GNUNET_assert (NULL != net);
+  GNUNET_assert(NULL != net);
   unsigned int na = net->active_addresses + 1;
   uint32_t min_bw = ntohl (GNUNET_CONSTANTS_DEFAULT_BW_IN_OUT.value__);
-  if (((net->total_quota_in / na) > min_bw) &&
-      ((net->total_quota_out / na) > min_bw))
+  if (((net->total_quota_in / na) > min_bw)
+      && ((net->total_quota_out / na) > min_bw))
   {
-    LOG (GNUNET_ERROR_TYPE_DEBUG,
-         "Enough bandwidth available for %u active addresses in network `%s'\n",
-         na,
-         net->desc);
+    LOG(GNUNET_ERROR_TYPE_DEBUG,
+        "Enough bandwidth available for %u active addresses in network `%s'\n",
+        na, net->desc);
 
     return GNUNET_YES;
   }
-    LOG (GNUNET_ERROR_TYPE_DEBUG,
-         "Not enough bandwidth available for %u active addresses in network `%s'\n",
-         na,
-         net->desc);
+  LOG(GNUNET_ERROR_TYPE_DEBUG,
+      "Not enough bandwidth available for %u active addresses in network `%s'\n",
+      na, net->desc);
   return GNUNET_NO;
 }
 
-
 /**
  * Update bandwidth assigned to peers in this network
  *
@@ -412,8 +408,7 @@ is_bandwidth_available_in_network (struct Network *net)
  */
 static void
 distribute_bandwidth_in_network (struct GAS_PROPORTIONAL_Handle *s,
-                          struct Network *net,
-                          struct ATS_Address *address_except)
+    struct Network *net, struct ATS_Address *address_except)
 {
   unsigned long long remaining_quota_in = 0;
   unsigned long long quota_out_used = 0;
@@ -431,15 +426,16 @@ distribute_bandwidth_in_network (struct GAS_PROPORTIONAL_Handle *s,
   unsigned long long assigned_quota_out = 0;
   struct AddressWrapper *cur;
 
-       if (GNUNET_YES == s->bulk_lock)
-       {
-               s->bulk_requests++;
-               return;
-       }
+  if (GNUNET_YES == s->bulk_lock)
+  {
+    s->bulk_requests++;
+    return;
+  }
 
-  LOG (GNUNET_ERROR_TYPE_DEBUG,
-              "Recalculate quota for network type `%s' for %u addresses (in/out): %llu/%llu \n",
-              net->desc, net->active_addresses, net->total_quota_in, net->total_quota_in);
+  LOG(GNUNET_ERROR_TYPE_DEBUG,
+      "Recalculate quota for network type `%s' for %u addresses (in/out): %llu/%llu \n",
+      net->desc, net->active_addresses, net->total_quota_in,
+      net->total_quota_in);
 
   if (net->active_addresses == 0)
     return; /* no addresses to update */
@@ -451,126 +447,122 @@ distribute_bandwidth_in_network (struct GAS_PROPORTIONAL_Handle *s,
 
   if ((net->active_addresses * min_bw) > net->total_quota_in)
   {
-    GNUNET_break (0);
+    GNUNET_break(0);
     return;
   }
   if ((net->active_addresses * min_bw) > net->total_quota_out)
   {
-    GNUNET_break (0);
+    GNUNET_break(0);
     return;
   }
 
   remaining_quota_in = net->total_quota_in - (net->active_addresses * min_bw);
   remaining_quota_out = net->total_quota_out - (net->active_addresses * min_bw);
-  LOG (GNUNET_ERROR_TYPE_DEBUG, "Remaining bandwidth : (in/out): %llu/%llu \n",
-              remaining_quota_in, remaining_quota_out);
+  LOG(GNUNET_ERROR_TYPE_DEBUG, "Remaining bandwidth : (in/out): %llu/%llu \n",
+      remaining_quota_in, remaining_quota_out);
   total_prefs = 0.0;
   for (cur = net->head; NULL != cur; cur = cur->next)
   {
-      if (GNUNET_YES == cur->addr->active)
+    if (GNUNET_YES == cur->addr->active)
+    {
+      GNUNET_assert(
+          NULL != (t = s->get_preferences (s->get_preferences_cls, &cur->addr->peer)));
+
+      peer_prefs = 0.0;
+      for (c = 0; c < GNUNET_ATS_PreferenceCount; c++)
       {
-        GNUNET_assert (NULL != (t = s->get_preferences (s->get_preferences_cls, &cur->addr->peer)));
-
-                               peer_prefs = 0.0;
-                               for (c = 0; c < GNUNET_ATS_PreferenceCount; c++)
-                               {
-                                       if (c != GNUNET_ATS_PREFERENCE_END)
-                                       {
-                                               //fprintf (stderr, "VALUE[%u] %s %.3f \n", c, GNUNET_i2s (&cur->addr->peer), t[c]);
-                                               peer_prefs += t[c];
-                                       }
-                               }
-                               total_prefs += (peer_prefs / (GNUNET_ATS_PreferenceCount -1));
+        if (c != GNUNET_ATS_PREFERENCE_END)
+        {
+          //fprintf (stderr, "VALUE[%u] %s %.3f \n", c, GNUNET_i2s (&cur->addr->peer), t[c]);
+          peer_prefs += t[c];
+        }
       }
+      total_prefs += (peer_prefs / (GNUNET_ATS_PreferenceCount - 1));
+    }
   }
   for (cur = net->head; NULL != cur; cur = cur->next)
   {
-     if (GNUNET_YES == cur->addr->active)
-     {
-       cur_pref = 0.0;
-       GNUNET_assert (NULL != (t = s->get_preferences (s->get_preferences_cls, &cur->addr->peer)));
-
-                        for (c = 0; c < GNUNET_ATS_PreferenceCount; c++)
-                        {
-                                if (c != GNUNET_ATS_PREFERENCE_END)
-                                        cur_pref += t[c];
-                        }
-                        cur_pref /= 2;
-
-       assigned_quota_in = min_bw + ((cur_pref / total_prefs) * remaining_quota_in);
-       assigned_quota_out = min_bw + ((cur_pref / total_prefs) * remaining_quota_out);
-
-       LOG (GNUNET_ERROR_TYPE_DEBUG,
-                   "New quota for peer `%s' with preference (cur/total) %.3f/%.3f (in/out): %llu / %llu\n",
-                   GNUNET_i2s (&cur->addr->peer),
-                   cur_pref, total_prefs,
-                   assigned_quota_in, assigned_quota_out);
-     }
-     else
-     {
-       assigned_quota_in = 0;
-       assigned_quota_out = 0;
-     }
-
-     quota_in_used += assigned_quota_in;
-     quota_out_used += assigned_quota_out;
-     /* Prevent overflow due to rounding errors */
-     if (assigned_quota_in > UINT32_MAX)
-       assigned_quota_in = UINT32_MAX;
-     if (assigned_quota_out > UINT32_MAX)
-       assigned_quota_out = UINT32_MAX;
-
-     /* Compare to current bandwidth assigned */
-     if ((assigned_quota_in != ntohl(cur->addr->assigned_bw_in.value__)) ||
-         (assigned_quota_out != ntohl(cur->addr->assigned_bw_out.value__)))
-     {
-       cur->addr->assigned_bw_in.value__ = htonl (assigned_quota_in);
-       cur->addr->assigned_bw_out.value__ = htonl (assigned_quota_out);
-       /* Notify on change */
-       if ((GNUNET_YES == cur->addr->active) && (cur->addr != address_except))
-         s->bw_changed (s->bw_changed_cls, cur->addr);
-     }
+    if (GNUNET_YES == cur->addr->active)
+    {
+      cur_pref = 0.0;
+      GNUNET_assert(
+          NULL != (t = s->get_preferences (s->get_preferences_cls, &cur->addr->peer)));
+
+      for (c = 0; c < GNUNET_ATS_PreferenceCount; c++)
+      {
+        if (c != GNUNET_ATS_PREFERENCE_END)
+          cur_pref += t[c];
+      }
+      cur_pref /= 2;
+
+      assigned_quota_in = min_bw
+          + ((cur_pref / total_prefs) * remaining_quota_in);
+      assigned_quota_out = min_bw
+          + ((cur_pref / total_prefs) * remaining_quota_out);
+
+      LOG(GNUNET_ERROR_TYPE_DEBUG,
+          "New quota for peer `%s' with preference (cur/total) %.3f/%.3f (in/out): %llu / %llu\n",
+          GNUNET_i2s (&cur->addr->peer), cur_pref, total_prefs,
+          assigned_quota_in, assigned_quota_out);
+    }
+    else
+    {
+      assigned_quota_in = 0;
+      assigned_quota_out = 0;
+    }
+
+    quota_in_used += assigned_quota_in;
+    quota_out_used += assigned_quota_out;
+    /* Prevent overflow due to rounding errors */
+    if (assigned_quota_in > UINT32_MAX)
+      assigned_quota_in = UINT32_MAX;
+    if (assigned_quota_out > UINT32_MAX)
+      assigned_quota_out = UINT32_MAX;
+
+    /* Compare to current bandwidth assigned */
+    if ((assigned_quota_in != ntohl (cur->addr->assigned_bw_in.value__))
+        || (assigned_quota_out != ntohl (cur->addr->assigned_bw_out.value__)))
+    {
+      cur->addr->assigned_bw_in.value__ = htonl (assigned_quota_in);
+      cur->addr->assigned_bw_out.value__ = htonl (assigned_quota_out);
+      /* Notify on change */
+      if ((GNUNET_YES == cur->addr->active) && (cur->addr != address_except))
+        s->bw_changed (s->bw_changed_cls, cur->addr);
+    }
 
   }
-  LOG (GNUNET_ERROR_TYPE_DEBUG,
-                          "Total bandwidth assigned is (in/out): %llu /%llu\n",
-                          quota_in_used,
-                          quota_out_used);
+  LOG(GNUNET_ERROR_TYPE_DEBUG,
+      "Total bandwidth assigned is (in/out): %llu /%llu\n", quota_in_used,
+      quota_out_used);
   if (quota_out_used > net->total_quota_out + 1) /* +1 is required due to rounding errors */
   {
-      LOG (GNUNET_ERROR_TYPE_ERROR,
-                            "Total outbound bandwidth assigned is larger than allowed (used/allowed) for %u active addresses: %llu / %llu\n",
-                            net->active_addresses,
-                            quota_out_used,
-                            net->total_quota_out);
+    LOG(GNUNET_ERROR_TYPE_ERROR,
+        "Total outbound bandwidth assigned is larger than allowed (used/allowed) for %u active addresses: %llu / %llu\n",
+        net->active_addresses, quota_out_used, net->total_quota_out);
   }
   if (quota_in_used > net->total_quota_in + 1) /* +1 is required due to rounding errors */
   {
-      LOG (GNUNET_ERROR_TYPE_ERROR,
-                            "Total inbound bandwidth assigned is larger than allowed (used/allowed) for %u active addresses: %llu / %llu\n",
-                            net->active_addresses,
-                            quota_in_used,
-                            net->total_quota_in);
+    LOG(GNUNET_ERROR_TYPE_ERROR,
+        "Total inbound bandwidth assigned is larger than allowed (used/allowed) for %u active addresses: %llu / %llu\n",
+        net->active_addresses, quota_in_used, net->total_quota_in);
   }
 }
 
-
 struct FindBestAddressCtx
 {
-       struct GAS_PROPORTIONAL_Handle *s;
-       struct ATS_Address *best;
+  struct GAS_PROPORTIONAL_Handle *s;
+  struct ATS_Address *best;
 };
 
-
 static int
 find_property_index (uint32_t type)
 {
-       int existing_types[] = GNUNET_ATS_QualityProperties;
-       int c;
-       for (c = 0; c < GNUNET_ATS_QualityPropertiesCount; c++)
-               if (existing_types[c] == type)
-                       return c;
-       return GNUNET_SYSERR;
+  int existing_types[] = GNUNET_ATS_QualityProperties;
+  int c;
+  for (c = 0; c < GNUNET_ATS_QualityPropertiesCount; c++)
+    if (existing_types[c] == type)
+      return c;
+  return GNUNET_SYSERR;
 }
 
 /**
@@ -584,9 +576,10 @@ find_property_index (uint32_t type)
  * @return GNUNET_OK (continue to iterate)
  */
 static int
-find_best_address_it (void *cls, const struct GNUNET_HashCode * key, void *value)
+find_best_address_it (void *cls, const struct GNUNET_HashCode * key,
+    void *value)
 {
-       struct FindBestAddressCtx *fba_ctx = (struct FindBestAddressCtx *) cls;
+  struct FindBestAddressCtx *fba_ctx = (struct FindBestAddressCtx *) cls;
   struct ATS_Address *current = (struct ATS_Address *) value;
   struct GNUNET_TIME_Absolute now;
   struct Network *net = (struct Network *) current->solver_information;
@@ -594,30 +587,29 @@ find_best_address_it (void *cls, const struct GNUNET_HashCode * key, void *value
   const double *norm_prop_prev;
   int index;
 
-  now = GNUNET_TIME_absolute_get();
+  now = GNUNET_TIME_absolute_get ();
 
-  if (current->blocked_until.abs_value == GNUNET_TIME_absolute_max (now, current->blocked_until).abs_value)
+  if (current->blocked_until.abs_value_us
+      == GNUNET_TIME_absolute_max (now, current->blocked_until).abs_value_us)
   {
     /* This address is blocked for suggestion */
-    LOG (GNUNET_ERROR_TYPE_DEBUG,
-                "Address %p blocked for suggestion for %llu ms \n",
-                current,
-                GNUNET_TIME_absolute_get_difference(now, current->blocked_until).rel_value);
+    LOG(GNUNET_ERROR_TYPE_DEBUG, "Address %p blocked for suggestion for %s \n",
+        current,
+        GNUNET_STRINGS_relative_time_to_string (GNUNET_TIME_absolute_get_difference (now, current->blocked_until), GNUNET_YES));
     return GNUNET_OK;
   }
   if (GNUNET_NO == is_bandwidth_available_in_network (net))
     return GNUNET_OK; /* There's no bandwidth available in this network */
   if (NULL != fba_ctx->best)
   {
-       GNUNET_assert (NULL != fba_ctx->best->plugin);
-       GNUNET_assert (NULL != current->plugin);
+    GNUNET_assert(NULL != fba_ctx->best->plugin);
+    GNUNET_assert(NULL != current->plugin);
     if (0 == strcmp (fba_ctx->best->plugin, current->plugin))
     {
-      if ((0 != fba_ctx->best->addr_len) &&
-          (0 == current->addr_len))
+      if ((0 != fba_ctx->best->addr_len) && (0 == current->addr_len))
       {
         /* saved address was an outbound address, but we have an inbound address */
-       fba_ctx->best = current;
+        fba_ctx->best = current;
         return GNUNET_OK;
       }
       if (0 == fba_ctx->best->addr_len)
@@ -629,30 +621,30 @@ find_best_address_it (void *cls, const struct GNUNET_HashCode * key, void *value
   }
   if (NULL == fba_ctx->best)
   {
-       fba_ctx->best = current;
+    fba_ctx->best = current;
     return GNUNET_OK;
   }
-  if ((ntohl (fba_ctx->best->assigned_bw_in.value__) == 0) &&
-      (ntohl (current->assigned_bw_in.value__) > 0))
+  if ((ntohl (fba_ctx->best->assigned_bw_in.value__) == 0)
+      && (ntohl (current->assigned_bw_in.value__) > 0))
   {
     /* stick to existing connection */
-       fba_ctx->best = current;
+    fba_ctx->best = current;
     return GNUNET_OK;
   }
 
   norm_prop_cur = fba_ctx->s->get_properties (fba_ctx->s->get_properties_cls,
-               (const struct ATS_Address *) current);
+      (const struct ATS_Address *) current);
   norm_prop_prev = fba_ctx->s->get_properties (fba_ctx->s->get_properties_cls,
-               (const struct ATS_Address *) fba_ctx->best);
-/*
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "%s previous %.2f current %.2f\n",
-               "DISTANCE", norm_prop_cur[1], norm_prop_cur[1]);
-*/
+      (const struct ATS_Address *) fba_ctx->best);
+  /*
+   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "%s previous %.2f current %.2f\n",
+   "DISTANCE", norm_prop_cur[1], norm_prop_cur[1]);
+   */
   index = find_property_index (GNUNET_ATS_QUALITY_NET_DISTANCE);
   if (GNUNET_SYSERR == index)
   {
-       GNUNET_break (0);
-       return GNUNET_OK;
+    GNUNET_break(0);
+    return GNUNET_OK;
   }
   if (norm_prop_cur[index] < norm_prop_prev[index])
   {
@@ -660,20 +652,20 @@ find_best_address_it (void *cls, const struct GNUNET_HashCode * key, void *value
     fba_ctx->best = current;
     return GNUNET_OK;
   }
-/*
-  GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "%s previous %.2f current %.2f\n",
-               "DELAY", norm_prop_cur[1], norm_prop_cur[1]);
- */
+  /*
+   GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "%s previous %.2f current %.2f\n",
+   "DELAY", norm_prop_cur[1], norm_prop_cur[1]);
  */
   index = find_property_index (GNUNET_ATS_QUALITY_NET_DELAY);
   if (GNUNET_SYSERR == index)
   {
-       GNUNET_break (0);
-       return GNUNET_OK;
+    GNUNET_break(0);
+    return GNUNET_OK;
   }
   if (norm_prop_cur[index] < norm_prop_prev[index])
   {
     /* user shorter delay */
-       fba_ctx->best = current;
+    fba_ctx->best = current;
     return GNUNET_OK;
   }
 
@@ -694,14 +686,11 @@ find_best_address_it (void *cls, const struct GNUNET_HashCode * key, void *value
 static void
 distribute_bandwidth_in_all_networks (struct GAS_PROPORTIONAL_Handle *s)
 {
-       int i;
-
-       for (i = 0; i < s->networks; i++)
-               distribute_bandwidth_in_network (s, &s->network_entries[i], NULL);
-
+  int i;
+  for (i = 0; i < s->networks; i++)
+    distribute_bandwidth_in_network (s, &s->network_entries[i], NULL );
 }
 
-
 /**
  * Lookup network struct by type
  *
@@ -713,16 +702,15 @@ static struct Network *
 get_network (struct GAS_PROPORTIONAL_Handle *s, uint32_t type)
 {
   int c;
-  for (c = 0 ; c < s->networks; c++)
+  for (c = 0; c < s->networks; c++)
   {
-      if (s->network_entries[c].type == type)
-        return &s->network_entries[c];
+    if (s->network_entries[c].type == type)
+      return &s->network_entries[c];
 
   }
-  return NULL;
+  return NULL ;
 }
 
-
 /**
  * Hashmap Iterator to find current active address for peer
  *
@@ -732,26 +720,28 @@ get_network (struct GAS_PROPORTIONAL_Handle *s, uint32_t type)
  * @return GNUNET_NO on double active address else GNUNET_YES;
  */
 static int
-get_active_address_it (void *cls, const struct GNUNET_HashCode * key, void *value)
+get_active_address_it (void *cls, const struct GNUNET_HashCode * key,
+    void *value)
 {
-  struct ATS_Address * dest = (struct ATS_Address *) (*(struct ATS_Address **)cls);
-  struct ATS_Address * aa = (struct ATS_Address *) value;
+  struct ATS_Address **dest = cls;
+  struct ATS_Address *aa = (struct ATS_Address *) value;
 
   if (GNUNET_YES == aa->active)
   {
-      if (dest != NULL)
-      {
-          /* should never happen */
-          LOG (GNUNET_ERROR_TYPE_ERROR, "Multiple active addresses for peer `%s'\n", GNUNET_i2s (&aa->peer));
-          GNUNET_break (0);
-          return GNUNET_NO;
-      }
-      dest = aa;
+
+    if (NULL != (*dest))
+    {
+      /* should never happen */
+      LOG(GNUNET_ERROR_TYPE_ERROR, "Multiple active addresses for peer `%s'\n",
+          GNUNET_i2s (&aa->peer));
+      GNUNET_break(0);
+      return GNUNET_NO;
+    }
+    (*dest) = aa;
   }
   return GNUNET_OK;
 }
 
-
 /**
  * Find current active address for peer
  *
@@ -762,70 +752,64 @@ get_active_address_it (void *cls, const struct GNUNET_HashCode * key, void *valu
  */
 static struct ATS_Address *
 get_active_address (void *solver,
-                     struct GNUNET_CONTAINER_MultiHashMap * addresses,
-                     const struct GNUNET_PeerIdentity *peer)
+    struct GNUNET_CONTAINER_MultiHashMap * addresses,
+    const struct GNUNET_PeerIdentity *peer)
 {
   struct ATS_Address * dest = NULL;
 
-  GNUNET_CONTAINER_multihashmap_get_multiple(addresses,
-       &peer->hashPubKey,
-       &get_active_address_it, &dest);
+  GNUNET_CONTAINER_multihashmap_get_multiple (addresses, &peer->hashPubKey,
+      &get_active_address_it, &dest);
   return dest;
 }
 
-
-
 static void
-addresse_increment (struct GAS_PROPORTIONAL_Handle *s,
-                                struct Network *net,
-                                int total,
-                                int active)
+addresse_increment (struct GAS_PROPORTIONAL_Handle *s, struct Network *net,
+    int total, int active)
 {
   if (GNUNET_YES == total)
   {
-      s->total_addresses ++;
-      net->total_addresses ++;
-      GNUNET_STATISTICS_update (s->stats, "# ATS addresses total", 1, GNUNET_NO);
-      GNUNET_STATISTICS_update (s->stats, net->stat_total, 1, GNUNET_NO);
+    s->total_addresses++;
+    net->total_addresses++;
+    GNUNET_STATISTICS_update (s->stats, "# ATS addresses total", 1, GNUNET_NO);
+    GNUNET_STATISTICS_update (s->stats, net->stat_total, 1, GNUNET_NO);
   }
   if (GNUNET_YES == active)
   {
-    net->active_addresses ++;
-    s->active_addresses ++;
-    GNUNET_STATISTICS_update (s->stats, "# ATS active addresses total", 1, GNUNET_NO);
+    net->active_addresses++;
+    s->active_addresses++;
+    GNUNET_STATISTICS_update (s->stats, "# ATS active addresses total", 1,
+        GNUNET_NO);
     GNUNET_STATISTICS_update (s->stats, net->stat_active, 1, GNUNET_NO);
   }
 
 }
 
-
 static int
-addresse_decrement (struct GAS_PROPORTIONAL_Handle *s,
-                    struct Network *net,
-                    int total,
-                    int active)
+addresse_decrement (struct GAS_PROPORTIONAL_Handle *s, struct Network *net,
+    int total, int active)
 {
   int res = GNUNET_OK;
   if (GNUNET_YES == total)
   {
     if (s->total_addresses < 1)
     {
-      GNUNET_break (0);
+      GNUNET_break(0);
       res = GNUNET_SYSERR;
     }
     else
     {
-      s->total_addresses --;
-      GNUNET_STATISTICS_update (s->stats, "# ATS addresses total", -1, GNUNET_NO);
+      s->total_addresses--;
+      GNUNET_STATISTICS_update (s->stats, "# ATS addresses total", -1,
+          GNUNET_NO);
     }
     if (net->total_addresses < 1)
     {
-      GNUNET_break (0);
+      GNUNET_break(0);
       res = GNUNET_SYSERR;
     }
     else
     {
-      net->total_addresses --;
+      net->total_addresses--;
       GNUNET_STATISTICS_update (s->stats, net->stat_total, -1, GNUNET_NO);
     }
   }
@@ -834,29 +818,29 @@ addresse_decrement (struct GAS_PROPORTIONAL_Handle *s,
   {
     if (net->active_addresses < 1)
     {
-      GNUNET_break (0);
+      GNUNET_break(0);
       res = GNUNET_SYSERR;
     }
     else
     {
-      net->active_addresses --;
+      net->active_addresses--;
       GNUNET_STATISTICS_update (s->stats, net->stat_active, -1, GNUNET_NO);
     }
     if (s->active_addresses < 1)
     {
-      GNUNET_break (0);
+      GNUNET_break(0);
       res = GNUNET_SYSERR;
     }
     else
     {
-      s->active_addresses --;
-      GNUNET_STATISTICS_update (s->stats, "# ATS addresses total", -1, GNUNET_NO);
+      s->active_addresses--;
+      GNUNET_STATISTICS_update (s->stats, "# ATS addresses total", -1,
+          GNUNET_NO);
     }
   }
   return res;
 }
 
-
 /**
  *  Solver API functions
  *  ---------------------------
@@ -872,28 +856,49 @@ addresse_decrement (struct GAS_PROPORTIONAL_Handle *s,
  */
 void
 GAS_proportional_address_change_preference (void *solver,
-                                                                                       const struct GNUNET_PeerIdentity *peer,
-                                                                                       enum GNUNET_ATS_PreferenceKind kind,
-                                                                                       double pref_rel)
+    const struct GNUNET_PeerIdentity *peer, enum GNUNET_ATS_PreferenceKind kind,
+    double pref_rel)
 {
   struct GAS_PROPORTIONAL_Handle *s = solver;
-  GNUNET_assert (NULL != solver);
-  GNUNET_assert (NULL != peer);
+  GNUNET_assert(NULL != solver);
+  GNUNET_assert(NULL != peer);
 
-       distribute_bandwidth_in_all_networks (s);
+  distribute_bandwidth_in_all_networks (s);
 }
 
+/**
+ * Get application feedback for a peer
+ *
+ * @param solver the solver handle
+ * @param application the application
+ * @param peer the peer to change the preference for
+ * @param scope the time interval for this feedback: [now - scope .. now]
+ * @param kind the kind to change the preference
+ * @param score the score
+ */
+void
+GAS_proportional_address_preference_feedback (void *solver, void *application,
+    const struct GNUNET_PeerIdentity *peer,
+    const struct GNUNET_TIME_Relative scope,
+    enum GNUNET_ATS_PreferenceKind kind, double score)
+{
+  struct GAS_PROPORTIONAL_Handle *s = solver;
+  GNUNET_assert(NULL != solver);
+  GNUNET_assert(NULL != peer);
+
+  GNUNET_assert(NULL != s);
+  GNUNET_break(0);
+}
 
 /**
  * Get the preferred address for a specific peer
  *
  * @param solver the solver handle
- * @param addresses the address hashmap containing all addresses
  * @param peer the identity of the peer
  */
 const struct ATS_Address *
 GAS_proportional_get_preferred_address (void *solver,
-                               const struct GNUNET_PeerIdentity *peer)
+    const struct GNUNET_PeerIdentity *peer)
 {
   struct GAS_PROPORTIONAL_Handle *s = solver;
   struct Network *net_prev;
@@ -901,36 +906,45 @@ GAS_proportional_get_preferred_address (void *solver,
   struct ATS_Address *prev;
   struct FindBestAddressCtx fba_ctx;
 
-  GNUNET_assert (s != NULL);
-  GNUNET_assert (peer != NULL);
+  GNUNET_assert(s != NULL);
+  GNUNET_assert(peer != NULL);
+
+  /* Add to list of pending requests */
+  if (GNUNET_NO == GNUNET_CONTAINER_multihashmap_contains (s->requests,
+          &peer->hashPubKey))
+  {
+    GNUNET_assert (GNUNET_OK == GNUNET_CONTAINER_multihashmap_put (s->requests, &peer->hashPubKey, NULL,
+        GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY));
+  }
 
   /* Get address with: stick to current address, lower distance, lower latency */
   fba_ctx.s = s;
   fba_ctx.best = NULL;
 
   GNUNET_CONTAINER_multihashmap_get_multiple (s->addresses, &peer->hashPubKey,
-                                              &find_best_address_it, &fba_ctx);
+      &find_best_address_it, &fba_ctx);
   if (NULL == fba_ctx.best)
   {
-    LOG (GNUNET_ERROR_TYPE_DEBUG, "Cannot suggest address for peer `%s'\n", GNUNET_i2s (peer));
-    return NULL;
+    LOG(GNUNET_ERROR_TYPE_INFO, "Cannot suggest address for peer `%s'\n",
+        GNUNET_i2s (peer));
+    return NULL ;
   }
 
-  LOG (GNUNET_ERROR_TYPE_DEBUG, "Suggesting %s address %p for peer `%s'\n",
-      (GNUNET_NO == fba_ctx.best->active) ? "inactive" : "active",
-               fba_ctx.best, GNUNET_i2s (peer));
+  LOG(GNUNET_ERROR_TYPE_INFO, "Suggesting %s address %p for peer `%s'\n",
+      (GNUNET_NO == fba_ctx.best->active) ? "inactive" : "active", fba_ctx.best,
+      GNUNET_i2s (peer));
   net_cur = (struct Network *) fba_ctx.best->solver_information;
   if (NULL == fba_ctx.best)
   {
-    LOG (GNUNET_ERROR_TYPE_ERROR, "Trying to suggesting unknown address peer `%s'\n",
-        GNUNET_i2s (peer));
-    GNUNET_break (0);
-    return NULL;
+    LOG(GNUNET_ERROR_TYPE_ERROR,
+        "Trying to suggesting unknown address peer `%s'\n", GNUNET_i2s (peer));
+    GNUNET_break(0);
+    return NULL ;
   }
   if (GNUNET_YES == fba_ctx.best->active)
   {
-      /* This address was selected previously, so no need to update quotas */
-      return fba_ctx.best;
+    /* This address was selected previously, so no need to update quotas */
+    return fba_ctx.best;
   }
 
   /* This address was not active, so we have to:
@@ -939,64 +953,83 @@ GAS_proportional_get_preferred_address (void *solver,
    * - update quota for previous address network
    * - update quota for this address network
    */
-
-  prev = get_active_address (s, (struct GNUNET_CONTAINER_MultiHashMap *) s->addresses, peer);
+  prev = get_active_address (s,
+      (struct GNUNET_CONTAINER_MultiHashMap *) s->addresses, peer);
   if (NULL != prev)
   {
-      net_prev = (struct Network *) prev->solver_information;
-      prev->active = GNUNET_NO; /* No active any longer */
-      prev->assigned_bw_in = GNUNET_BANDWIDTH_value_init (0); /* no bw assigned */
-      prev->assigned_bw_out = GNUNET_BANDWIDTH_value_init (0); /* no bw assigned */
-      s->bw_changed (s->bw_changed_cls, prev); /* notify about bw change, REQUIRED? */
-      if (GNUNET_SYSERR == addresse_decrement (s, net_prev, GNUNET_NO, GNUNET_YES))
-        GNUNET_break (0);
-       distribute_bandwidth_in_network (s, net_prev, NULL);
+    net_prev = (struct Network *) prev->solver_information;
+    prev->active = GNUNET_NO; /* No active any longer */
+    prev->assigned_bw_in = BANDWIDTH_ZERO; /* no bandwidth assigned */
+    prev->assigned_bw_out = BANDWIDTH_ZERO; /* no bandwidth assigned */
+    if (GNUNET_SYSERR == addresse_decrement (s, net_prev, GNUNET_NO, GNUNET_YES))
+      GNUNET_break(0);
+    distribute_bandwidth_in_network (s, net_prev, NULL );
   }
 
   if (GNUNET_NO == (is_bandwidth_available_in_network (fba_ctx.best->solver_information)))
   {
-    GNUNET_break (0); /* This should never happen*/
-    return NULL;
+    GNUNET_break(0); /* This should never happen*/
+    return NULL ;
   }
 
   fba_ctx.best->active = GNUNET_YES;
-  addresse_increment(s, net_cur, GNUNET_NO, GNUNET_YES);
-  distribute_bandwidth_in_network (s, net_cur, fba_ctx.best);
+  addresse_increment (s, net_cur, GNUNET_NO, GNUNET_YES);
+  distribute_bandwidth_in_network (s, net_cur, fba_ctx.best );
   return fba_ctx.best;
 }
 
-
 /**
  * Stop notifying about address and bandwidth changes for this peer
  *
  * @param solver the solver handle
- * @param addresses address hashmap
  * @param peer the peer
  */
 void
 GAS_proportional_stop_get_preferred_address (void *solver,
-                                     const struct GNUNET_PeerIdentity *peer)
+    const struct GNUNET_PeerIdentity *peer)
 {
-       return;
+  struct GAS_PROPORTIONAL_Handle *s = solver;
+  struct ATS_Address *cur;
+  struct Network *cur_net;
+
+  if (GNUNET_YES
+      == GNUNET_CONTAINER_multihashmap_contains (s->requests,
+          &peer->hashPubKey))
+    GNUNET_CONTAINER_multihashmap_remove (s->requests, &peer->hashPubKey,
+        NULL );
+
+  cur = get_active_address (s,
+      (struct GNUNET_CONTAINER_MultiHashMap *) s->addresses, peer);
+  if (NULL != cur)
+  {
+    /* Disabling current address */
+    cur_net = (struct Network *) cur->solver_information;
+    cur->active = GNUNET_NO; /* No active any longer */
+    cur->assigned_bw_in = BANDWIDTH_ZERO; /* no bandwidth assigned */
+    cur->assigned_bw_out = BANDWIDTH_ZERO; /* no bandwidth assigned */
+    if (GNUNET_SYSERR == addresse_decrement (s, cur_net, GNUNET_NO, GNUNET_YES))
+      GNUNET_break(0);
+    distribute_bandwidth_in_network (s, cur_net, NULL );
+  }
+  return;
 }
 
-
 /**
  * Remove an address from the solver
  *
  * @param solver the solver handle
- * @param addresses the address hashmap containing all addresses
  * @param address the address to remove
  * @param session_only delete only session not whole address
  */
 void
-GAS_proportional_address_delete (void *solver,
-                                                                                                                struct ATS_Address *address,
-                                                                                                                int session_only)
+GAS_proportional_address_delete (void *solver, struct ATS_Address *address,
+    int session_only)
 {
   struct GAS_PROPORTIONAL_Handle *s = solver;
   struct Network *net;
   struct AddressWrapper *aw;
+  const struct ATS_Address *new_address;
+
 
   /* Remove an adress completely, we have to:
    * - Remove from specific network
@@ -1010,51 +1043,64 @@ GAS_proportional_address_delete (void *solver,
 
   if (GNUNET_NO == session_only)
   {
-    LOG (GNUNET_ERROR_TYPE_DEBUG, "Deleting %s address %p for peer `%s' from network `%s' (total: %u/ active: %u)\n",
-        (GNUNET_NO == address->active) ? "inactive" : "active",
-        address, GNUNET_i2s (&address->peer),
-        net->desc, net->total_addresses, net->active_addresses);
+    LOG(GNUNET_ERROR_TYPE_INFO,
+        "Deleting %s address %p for peer `%s' from network `%s' (total: %u/ active: %u)\n",
+        (GNUNET_NO == address->active) ? "inactive" : "active", address,
+        GNUNET_i2s (&address->peer), net->desc, net->total_addresses,
+        net->active_addresses);
 
     /* Remove address */
     addresse_decrement (s, net, GNUNET_YES, GNUNET_NO);
     for (aw = net->head; NULL != aw; aw = aw->next)
     {
-        if (aw->addr == address)
-          break;
+      if (aw->addr == address)
+        break;
     }
-    if (NULL == aw )
+    if (NULL == aw)
     {
-        GNUNET_break (0);
-        return;
+      GNUNET_break(0);
+      return;
     }
-    GNUNET_CONTAINER_DLL_remove (net->head, net->tail, aw);
-    GNUNET_free (aw);
+    GNUNET_CONTAINER_DLL_remove(net->head, net->tail, aw);
+    GNUNET_free(aw);
   }
   else
   {
-      /* Remove session only: remove if active and update */
-      LOG (GNUNET_ERROR_TYPE_DEBUG, "Deleting %s session %p for peer `%s' from network `%s' (total: %u/ active: %u)\n",
-          (GNUNET_NO == address->active) ? "inactive" : "active",
-          address, GNUNET_i2s (&address->peer),
-          net->desc, net->total_addresses, net->active_addresses);
+    /* Remove session only: remove if active and update */
+    LOG(GNUNET_ERROR_TYPE_INFO,
+        "Deleting %s session %p for peer `%s' from network `%s' (total: %u/ active: %u)\n",
+        (GNUNET_NO == address->active) ? "inactive" : "active", address,
+        GNUNET_i2s (&address->peer), net->desc, net->total_addresses,
+        net->active_addresses);
   }
 
   if (GNUNET_YES == address->active)
   {
-      /* Address was active, remove from network and update quotas*/
-      address->active = GNUNET_NO;
-      if (GNUNET_SYSERR == addresse_decrement (s, net, GNUNET_NO, GNUNET_YES))
-        GNUNET_break (0);
-      distribute_bandwidth_in_network (s, net, NULL);
+    /* Address was active, remove from network and update quotas*/
+    address->active = GNUNET_NO;
+    address->assigned_bw_in = BANDWIDTH_ZERO;
+    address->assigned_bw_out = BANDWIDTH_ZERO;
+
+    if (GNUNET_SYSERR == addresse_decrement (s, net, GNUNET_NO, GNUNET_YES))
+      GNUNET_break(0);
+    distribute_bandwidth_in_network (s, net, NULL );
+
+    if (NULL == (new_address = GAS_proportional_get_preferred_address (s, &address->peer)))
+    {
+      /* No alternative address found, disconnect peer */
+      s->bw_changed (s->bw_changed_cls, address);
+    }
+    else
+    {
+      s->bw_changed (s->bw_changed_cls, (struct ATS_Address *) new_address);
+    }
   }
-  LOG (GNUNET_ERROR_TYPE_DEBUG, "After deleting address now total %u and active %u addresses in network `%s'\n",
-      net->total_addresses,
-      net->active_addresses,
-      net->desc);
+  LOG(GNUNET_ERROR_TYPE_DEBUG,
+      "After deleting address now total %u and active %u addresses in network `%s'\n",
+      net->total_addresses, net->active_addresses, net->desc);
 
 }
 
-
 /**
  * Start a bulk operation
  *
@@ -1063,11 +1109,11 @@ GAS_proportional_address_delete (void *solver,
 void
 GAS_proportional_bulk_start (void *solver)
 {
-  LOG (GNUNET_ERROR_TYPE_DEBUG, "Locking solver for bulk operation ...\n");
+  LOG(GNUNET_ERROR_TYPE_DEBUG, "Locking solver for bulk operation ...\n");
   struct GAS_PROPORTIONAL_Handle *s = (struct GAS_PROPORTIONAL_Handle *) solver;
 
-  GNUNET_assert (NULL != solver);
-  s->bulk_lock ++;
+  GNUNET_assert(NULL != solver);
+  s->bulk_lock++;
 }
 
 /**
@@ -1076,26 +1122,25 @@ GAS_proportional_bulk_start (void *solver)
 void
 GAS_proportional_bulk_stop (void *solver)
 {
-       LOG (GNUNET_ERROR_TYPE_DEBUG, "Unlocking solver from bulk operation ...\n");
+  LOG(GNUNET_ERROR_TYPE_DEBUG, "Unlocking solver from bulk operation ...\n");
 
   struct GAS_PROPORTIONAL_Handle *s = (struct GAS_PROPORTIONAL_Handle *) solver;
-  GNUNET_assert (NULL != solver);
+  GNUNET_assert(NULL != solver);
 
   if (s->bulk_lock < 1)
   {
-       GNUNET_break (0);
-       return;
+    GNUNET_break(0);
+    return;
   }
-  s->bulk_lock --;
+  s->bulk_lock--;
   if ((0 == s->bulk_lock) && (0 < s->bulk_requests))
   {
-       LOG (GNUNET_ERROR_TYPE_DEBUG, "No lock pending, recalculating\n");
-       distribute_bandwidth_in_all_networks (s);
-       s->bulk_requests = 0;
+    LOG(GNUNET_ERROR_TYPE_DEBUG, "No lock pending, recalculating\n");
+    distribute_bandwidth_in_all_networks (s);
+    s->bulk_requests = 0;
   }
 }
 
-
 /**
  * Add a new single address to a network
  *
@@ -1104,83 +1149,107 @@ GAS_proportional_bulk_stop (void *solver)
  * @param network network type of this address
  */
 void
-GAS_proportional_address_add (void *solver,
-                                                                                                                       struct ATS_Address *address,
-                                                                                                                       uint32_t network);
-
+GAS_proportional_address_add (void *solver, struct ATS_Address *address,
+    uint32_t network);
 
+/**
+ * Transport properties for this address have changed
+ *
+ * @param solver solver handle
+ * @param address the address
+ * @param type the ATSI type in HBO
+ * @param abs_value the absolute value of the property
+ * @param rel_value the normalized value
+ */
 void
 GAS_proportional_address_property_changed (void *solver,
-                                                                                                                       struct ATS_Address *address,
-                                                                                                                       uint32_t type,
-                                                                                                                       uint32_t abs_value,
-                                                                                                                       double rel_value)
+    struct ATS_Address *address, uint32_t type, uint32_t abs_value,
+    double rel_value)
 {
-       struct GAS_PROPORTIONAL_Handle *s;
-       struct Network *n;
-
-       GNUNET_assert (NULL != solver);
-       GNUNET_assert (NULL != address);
-
-       s = (struct GAS_PROPORTIONAL_Handle *) solver;
-       n = (struct Network *) address->solver_information;
-
-       if (NULL == n)
-       {
-               GNUNET_break (0);
-               return;
-       }
-
-  LOG (GNUNET_ERROR_TYPE_DEBUG,
-              "Property `%s' for peer `%s' address %p changed to %.2f %p %p %p\n",
-              GNUNET_ATS_print_property_type (type),
-              GNUNET_i2s (&address->peer),
-              address,
-              rel_value, s, n, &distribute_bandwidth_in_network);
+  struct GAS_PROPORTIONAL_Handle *s;
+  struct Network *n;
+
+  GNUNET_assert(NULL != solver);
+  GNUNET_assert(NULL != address);
+
+  s = (struct GAS_PROPORTIONAL_Handle *) solver;
+  n = (struct Network *) address->solver_information;
+
+  if (NULL == n)
+  {
+    GNUNET_break(0);
+    return;
+  }
+
+  LOG(GNUNET_ERROR_TYPE_DEBUG,
+      "Property `%s' for peer `%s' address %p changed to %.2f \n",
+      GNUNET_ATS_print_property_type (type), GNUNET_i2s (&address->peer),
+      address, rel_value);
   switch (type)
   {
-       case GNUNET_ATS_UTILIZATION_UP:
-       case GNUNET_ATS_UTILIZATION_DOWN:
-       case GNUNET_ATS_QUALITY_NET_DELAY:
-       case GNUNET_ATS_QUALITY_NET_DISTANCE:
-       case GNUNET_ATS_COST_WAN:
-       case GNUNET_ATS_COST_LAN:
-       case GNUNET_ATS_COST_WLAN:
-
-               //FIXME distribute_bandwidth_in_network (s, n, GNUNET_NO);
-       break;
+  case GNUNET_ATS_UTILIZATION_UP:
+  case GNUNET_ATS_UTILIZATION_DOWN:
+  case GNUNET_ATS_QUALITY_NET_DELAY:
+  case GNUNET_ATS_QUALITY_NET_DISTANCE:
+  case GNUNET_ATS_COST_WAN:
+  case GNUNET_ATS_COST_LAN:
+  case GNUNET_ATS_COST_WLAN:
+    distribute_bandwidth_in_network (s, n, GNUNET_NO);
+    break;
   }
 }
 
-
+/**
+ * Transport session for this address has changed
+ *
+ * NOTE: values in addresses are already updated
+ *
+ * @param solver solver handle
+ * @param address the address
+ * @param cur_session the current session
+ * @param new_session the new session
+ */
 void
 GAS_proportional_address_session_changed (void *solver,
-                                                                                                                       struct ATS_Address *address,
-                                                                                                                       uint32_t cur_session,
-                                                                                                                       uint32_t new_session)
+    struct ATS_Address *address, uint32_t cur_session, uint32_t new_session)
 {
-  if (cur_session!= new_session)
+  if (cur_session != new_session)
   {
-      LOG (GNUNET_ERROR_TYPE_DEBUG,
-                  "Session changed from %u to %u\n", cur_session, new_session);
+    LOG(GNUNET_ERROR_TYPE_DEBUG, "Session changed from %u to %u\n", cur_session,
+        new_session);
   }
 }
 
+/**
+ * Usage for this address has changed
+ *
+ * NOTE: values in addresses are already updated
+ *
+ * @param solver solver handle
+ * @param address the address
+ * @param in_use usage state
+ */
 void
 GAS_proportional_address_inuse_changed (void *solver,
-                                                                                                                       struct ATS_Address *address,
-                                                                                                                       int in_use)
+    struct ATS_Address *address, int in_use)
 {
-       LOG (GNUNET_ERROR_TYPE_DEBUG,
-                                                       "Usage changed to %s\n",
-                                                       (GNUNET_YES == in_use) ? "USED" : "UNUSED");
+  LOG(GNUNET_ERROR_TYPE_DEBUG, "Usage changed to %s\n",
+      (GNUNET_YES == in_use) ? "USED" : "UNUSED");
 }
 
+/**
+ * Network scope for this address has changed
+ *
+ * NOTE: values in addresses are already updated
+ *
+ * @param solver solver handle
+ * @param address the address
+ * @param current_network the current network
+ * @param new_network the new network
+ */
 void
 GAS_proportional_address_change_network (void *solver,
-                                                                                                                                          struct ATS_Address *address,
-                                                                                                                                          uint32_t current_network,
-                                                                                                                                          uint32_t new_network)
+    struct ATS_Address *address, uint32_t current_network, uint32_t new_network)
 {
   struct ATS_Address *new;
   struct GAS_PROPORTIONAL_Handle *s = (struct GAS_PROPORTIONAL_Handle *) solver;
@@ -1189,63 +1258,71 @@ GAS_proportional_address_change_network (void *solver,
 
   if (current_network == new_network)
   {
-       GNUNET_break (0);
-       return;
+    GNUNET_break(0);
+    return;
   }
 
-       /* Network changed */
-       LOG (GNUNET_ERROR_TYPE_DEBUG, "Network type changed, moving %s address from `%s' to `%s'\n",
-                       (GNUNET_YES == address->active) ? "active" : "inactive",
-                        GNUNET_ATS_print_network_type (current_network),
-                        GNUNET_ATS_print_network_type (new_network));
+  /* Network changed */
+  LOG(GNUNET_ERROR_TYPE_DEBUG,
+      "Network type changed, moving %s address from `%s' to `%s'\n",
+      (GNUNET_YES == address->active) ? "active" : "inactive",
+      GNUNET_ATS_print_network_type (current_network),
+      GNUNET_ATS_print_network_type (new_network));
 
   save_active = address->active;
-       /* remove from old network */
-       GAS_proportional_address_delete (solver, address, GNUNET_NO);
-
-       /* set new network type */
-       new_net = get_network (solver, new_network);
-       if (NULL == new_net)
-       {
-               /* Address changed to invalid network... */
-               LOG (GNUNET_ERROR_TYPE_ERROR, _("Cannot find network of type `%u' %s\n"),
-                               new_network, GNUNET_ATS_print_network_type (new_network));
-               address->assigned_bw_in = GNUNET_BANDWIDTH_value_init (0);
-               address->assigned_bw_out = GNUNET_BANDWIDTH_value_init (0);
-               s->bw_changed  (s->bw_changed_cls, address);
-               return;
-       }
-       address->solver_information = new_net;
-
-       /* Add to new network and update*/
-       GAS_proportional_address_add (solver, address, new_network);
-       if (GNUNET_YES == save_active)
-       {
-               /* check if bandwidth available in new network */
-               if (GNUNET_YES == (is_bandwidth_available_in_network (new_net)))
-               {
-                               /* Suggest updated address */
-                               address->active = GNUNET_YES;
-                               addresse_increment (s, new_net, GNUNET_NO, GNUNET_YES);
-                               distribute_bandwidth_in_network (solver, new_net, NULL);
-               }
-               else
-               {
-                       LOG (GNUNET_ERROR_TYPE_DEBUG, "Not enough bandwidth in new network, suggesting alternative address ..\n");
-
-                       /* Set old address to zero bw */
-                       address->assigned_bw_in = GNUNET_BANDWIDTH_value_init (0);
-                       address->assigned_bw_out = GNUNET_BANDWIDTH_value_init (0);
-                       s->bw_changed  (s->bw_changed_cls, address);
-
-                       /* Find new address to suggest since no bandwidth in network*/
-                       new = (struct ATS_Address *) GAS_proportional_get_preferred_address (s, &address->peer);
-                       if (NULL != new)
-                       {
-                                       /* Have an alternative address to suggest */
-                                       s->bw_changed  (s->bw_changed_cls, new);
-                       }
-               }
+
+  /* Disable and assign no bandwidth */
+  address->active = GNUNET_NO;
+  address->assigned_bw_in = BANDWIDTH_ZERO; /* no bandwidth assigned */
+  address->assigned_bw_out = BANDWIDTH_ZERO; /* no bandwidth assigned */
+
+  /* Remove from old network */
+  GAS_proportional_address_delete (solver, address, GNUNET_NO);
+
+  /* Set new network type */
+  if (NULL == (new_net = get_network (solver, new_network)))
+  {
+    /* Address changed to invalid network... */
+    LOG(GNUNET_ERROR_TYPE_ERROR,
+        _("Invalid network type `%u' `%s': Disconnect!\n"), new_network,
+        GNUNET_ATS_print_network_type (new_network));
+
+    /* Find new address to suggest since no bandwidth in network*/
+    if (NULL == (new = (struct ATS_Address *) GAS_proportional_get_preferred_address (s, &address->peer)))
+    {
+      /* No alternative address found, disconnect peer */
+      s->bw_changed (s->bw_changed_cls, address);
+    }
+    return;
+  }
+
+  /* Add to new network and update*/
+  address->solver_information = new_net;
+  GAS_proportional_address_add (solver, address, new_network);
+  if (GNUNET_YES == save_active)
+  {
+    /* check if bandwidth available in new network */
+    if (GNUNET_YES == (is_bandwidth_available_in_network (new_net)))
+    {
+      /* Assign bandwidth to updated address */
+      address->active = GNUNET_YES;
+      addresse_increment (s, new_net, GNUNET_NO, GNUNET_YES);
+      distribute_bandwidth_in_network (solver, new_net, NULL );
+    }
+    else
+    {
+      LOG(GNUNET_ERROR_TYPE_DEBUG,
+          "Not enough bandwidth in new network, suggesting alternative address ..\n");
+      /* Find new address to suggest since no bandwidth in network*/
+      if (NULL
+          == (new =
+              (struct ATS_Address *) GAS_proportional_get_preferred_address (s,
+                  &address->peer)))
+      {
+        /* No alternative address found, disconnect peer */
+        s->bw_changed (s->bw_changed_cls, address);
+      }
+    }
   }
 }
 
@@ -1253,40 +1330,47 @@ GAS_proportional_address_change_network (void *solver,
  * Add a new single address to a network
  *
  * @param solver the solver Handle
- * @param addresses the address hashmap containing all addresses
  * @param address the address to add
  * @param network network type of this address
  */
 void
-GAS_proportional_address_add (void *solver,
-                                                                                                                       struct ATS_Address *address,
-                                                                                                                       uint32_t network)
+GAS_proportional_address_add (void *solver, struct ATS_Address *address,
+    uint32_t network)
 {
   struct GAS_PROPORTIONAL_Handle *s = solver;
   struct Network *net = NULL;
   struct AddressWrapper *aw = NULL;
-  GNUNET_assert (NULL != s);
+  const struct ATS_Address *new_address;
+
+  GNUNET_assert(NULL != s);
+
 
   net = get_network (s, network);
   if (NULL == net)
   {
-    GNUNET_break (0);
+    GNUNET_break(0);
     return;
   }
 
   aw = GNUNET_malloc (sizeof (struct AddressWrapper));
   aw->addr = address;
-  GNUNET_CONTAINER_DLL_insert (net->head, net->tail, aw);
+  GNUNET_CONTAINER_DLL_insert(net->head, net->tail, aw);
   addresse_increment (s, net, GNUNET_YES, GNUNET_NO);
   aw->addr->solver_information = net;
 
-  LOG (GNUNET_ERROR_TYPE_DEBUG, "After adding address now total %u and active %u addresses in network `%s'\n",
-      net->total_addresses,
-      net->active_addresses,
-      net->desc);
+  if (GNUNET_YES == GNUNET_CONTAINER_multihashmap_contains (s->requests, &address->peer.hashPubKey))
+  {
+    if (NULL == get_active_address (s, (struct GNUNET_CONTAINER_MultiHashMap *) s->addresses, &address->peer))
+    {
+      if (NULL != (new_address = GAS_proportional_get_preferred_address (s, &address->peer)))
+          s->bw_changed (s->bw_changed_cls, (struct ATS_Address *) address);
+    }
+  }
+  LOG(GNUNET_ERROR_TYPE_DEBUG,
+      "After adding address now total %u and active %u addresses in network `%s'\n",
+      net->total_addresses, net->active_addresses, net->desc);
 }
 
-
 /**
  * Init the proportional problem solver
  *
@@ -1312,34 +1396,32 @@ GAS_proportional_address_add (void *solver,
  * @param bw_changed_cb_cls cls for callback
  * @param get_preference callback to get relative preferences for a peer
  * @param get_preference_cls cls for callback to get relative preferences
+ * @param get_properties for callback to get relative properties
+ * @param get_properties_cls cls for callback to get relative properties
  * @return handle for the solver on success, NULL on fail
  */
 void *
 GAS_proportional_init (const struct GNUNET_CONFIGURATION_Handle *cfg,
-                       const struct GNUNET_STATISTICS_Handle *stats,
-                       const struct GNUNET_CONTAINER_MultiHashMap *addresses,
-                       int *network,
-                       unsigned long long *out_quota,
-                       unsigned long long *in_quota,
-                       int dest_length,
-                       GAS_bandwidth_changed_cb bw_changed_cb,
-                       void *bw_changed_cb_cls,
-                       GAS_get_preferences get_preference,
-                       void *get_preference_cls,
-                       GAS_get_properties get_properties,
-                       void *get_properties_cls)
+    const struct GNUNET_STATISTICS_Handle *stats,
+    const struct GNUNET_CONTAINER_MultiHashMap *addresses, int *network,
+    unsigned long long *out_quota, unsigned long long *in_quota,
+    int dest_length, GAS_bandwidth_changed_cb bw_changed_cb,
+    void *bw_changed_cb_cls, GAS_get_preferences get_preference,
+    void *get_preference_cls, GAS_get_properties get_properties,
+    void *get_properties_cls)
 {
   int c;
-  struct GAS_PROPORTIONAL_Handle *s = GNUNET_malloc (sizeof (struct GAS_PROPORTIONAL_Handle));
+  struct GAS_PROPORTIONAL_Handle *s =
+      GNUNET_malloc (sizeof (struct GAS_PROPORTIONAL_Handle));
   struct Network * cur;
   char * net_str[GNUNET_ATS_NetworkTypeCount] = GNUNET_ATS_NetworkTypeString;
 
-  GNUNET_assert (NULL != cfg);
-  GNUNET_assert (NULL != stats);
-  GNUNET_assert (NULL != network);
-  GNUNET_assert (NULL != bw_changed_cb);
-  GNUNET_assert (NULL != get_preference);
-  GNUNET_assert (NULL != get_properties);
+  GNUNET_assert(NULL != cfg);
+  GNUNET_assert(NULL != stats);
+  GNUNET_assert(NULL != network);
+  GNUNET_assert(NULL != bw_changed_cb);
+  GNUNET_assert(NULL != get_preference);
+  GNUNET_assert(NULL != get_properties);
 
   s->stats = (struct GNUNET_STATISTICS_Handle *) stats;
   s->bw_changed = bw_changed_cb;
@@ -1355,22 +1437,24 @@ GAS_proportional_init (const struct GNUNET_CONFIGURATION_Handle *cfg,
   s->bulk_lock = GNUNET_NO;
   s->addresses = addresses;
 
+  s->requests = GNUNET_CONTAINER_multihashmap_create (10, GNUNET_YES);
+
   for (c = 0; c < dest_length; c++)
   {
-      cur = &s->network_entries[c];
-      cur->total_addresses = 0;
-      cur->active_addresses = 0;
-      cur->type = network[c];
-      cur->total_quota_in = in_quota[c];
-      cur->total_quota_out = out_quota[c];
-      cur->desc = net_str[c];
-      GNUNET_asprintf (&cur->stat_total, "# ATS addresses %s total", cur->desc);
-      GNUNET_asprintf (&cur->stat_active, "# ATS active addresses %s total", cur->desc);
+    cur = &s->network_entries[c];
+    cur->total_addresses = 0;
+    cur->active_addresses = 0;
+    cur->type = network[c];
+    cur->total_quota_in = in_quota[c];
+    cur->total_quota_out = out_quota[c];
+    cur->desc = net_str[c];
+    GNUNET_asprintf (&cur->stat_total, "# ATS addresses %s total", cur->desc);
+    GNUNET_asprintf (&cur->stat_active, "# ATS active addresses %s total",
+        cur->desc);
   }
   return s;
 }
 
-
 /**
  * Shutdown the proportional problem solver
  *
@@ -1383,57 +1467,53 @@ GAS_proportional_done (void *solver)
   struct AddressWrapper *cur;
   struct AddressWrapper *next;
   int c;
-  GNUNET_assert (s != NULL);
+  GNUNET_assert(s != NULL);
 
   for (c = 0; c < s->networks; c++)
   {
-      if (s->network_entries[c].total_addresses > 0)
-      {
-        LOG (GNUNET_ERROR_TYPE_ERROR,
-                    "Had %u addresses for network `%s' not deleted during shutdown\n",
-                    s->network_entries[c].total_addresses,
-                    s->network_entries[c].desc);
-        GNUNET_break (0);
-      }
+    if (s->network_entries[c].total_addresses > 0)
+    {
+      LOG(GNUNET_ERROR_TYPE_ERROR,
+          "Had %u addresses for network `%s' not deleted during shutdown\n",
+          s->network_entries[c].total_addresses, s->network_entries[c].desc);
+      GNUNET_break(0);
+    }
 
-      if (s->network_entries[c].active_addresses > 0)
-      {
-        LOG (GNUNET_ERROR_TYPE_ERROR,
-                    "Had %u active addresses for network `%s' not deleted during shutdown\n",
-                    s->network_entries[c].active_addresses,
-                    s->network_entries[c].desc);
-        GNUNET_break (0);
-      }
+    if (s->network_entries[c].active_addresses > 0)
+    {
+      LOG(GNUNET_ERROR_TYPE_ERROR,
+          "Had %u active addresses for network `%s' not deleted during shutdown\n",
+          s->network_entries[c].active_addresses, s->network_entries[c].desc);
+      GNUNET_break(0);
+    }
 
-      next = s->network_entries[c].head;
-      while (NULL != (cur = next))
-      {
-          next = cur->next;
-          GNUNET_CONTAINER_DLL_remove (s->network_entries[c].head,
-                                       s->network_entries[c].tail,
-                                       cur);
-          GNUNET_free (cur);
-      }
-      GNUNET_free (s->network_entries[c].stat_total);
-      GNUNET_free (s->network_entries[c].stat_active);
+    next = s->network_entries[c].head;
+    while (NULL != (cur = next))
+    {
+      next = cur->next;
+      GNUNET_CONTAINER_DLL_remove(s->network_entries[c].head,
+          s->network_entries[c].tail, cur);
+      GNUNET_free(cur);
+    }
+    GNUNET_free(s->network_entries[c].stat_total);
+    GNUNET_free(s->network_entries[c].stat_active);
   }
   if (s->total_addresses > 0)
   {
-    LOG (GNUNET_ERROR_TYPE_ERROR,
-                "Had %u addresses not deleted during shutdown\n",
-                s->total_addresses);
-    GNUNET_break (0);
+    LOG(GNUNET_ERROR_TYPE_ERROR,
+        "Had %u addresses not deleted during shutdown\n", s->total_addresses);
+    GNUNET_break(0);
   }
   if (s->active_addresses > 0)
   {
-    LOG (GNUNET_ERROR_TYPE_ERROR,
-                "Had %u active addresses not deleted during shutdown\n",
-                s->active_addresses);
-    GNUNET_break (0);
+    LOG(GNUNET_ERROR_TYPE_ERROR,
+        "Had %u active addresses not deleted during shutdown\n",
+        s->active_addresses);
+    GNUNET_break(0);
   }
-  GNUNET_free (s->network_entries);
-  GNUNET_free (s);
+  GNUNET_free(s->network_entries);
+  GNUNET_CONTAINER_multihashmap_destroy (s->requests);
+  GNUNET_free(s);
 }
 
-
 /* end of gnunet-service-ats-solver_proportional.c */