ext4: add support for filesystems without JOURNAL
authorMarek Szyprowski <m.szyprowski@samsung.com>
Fri, 21 Jun 2019 13:35:35 +0000 (15:35 +0200)
committerTom Rini <trini@konsulko.com>
Thu, 18 Jul 2019 15:31:24 +0000 (11:31 -0400)
JOURNAL is optional for EXT4 (and EXT3) filesystems, so add support for
skipping it. This fixes corrupting EXT4 volumes without JOURNAL after
using uboot's 'ext4write' command.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
fs/ext4/ext4_journal.c
fs/ext4/ext4_journal.h

index 6adbab93a68fb96cec282b71c8b22716f83d5593..3559daf11d2b2d87f3e28cfe5906951276f2773a 100644 (file)
@@ -645,6 +645,10 @@ void ext4fs_update_journal(void)
        struct ext_filesystem *fs = get_fs();
        long int blknr;
        int i;
+
+       if (!(fs->sb->feature_compatibility & EXT4_FEATURE_COMPAT_HAS_JOURNAL))
+               return;
+
        ext4fs_read_inode(ext4fs_root, EXT2_JOURNAL_INO, &inode_journal);
        blknr = read_allocated_block(&inode_journal, jrnl_blk_idx++, NULL);
        update_descriptor_block(blknr);
index c9cf195f33322dda8a55088147363ee2a95c3b68..43fb8e7664118804e366dc4626acac55fbd0d644 100644 (file)
@@ -17,6 +17,8 @@
 #ifndef __EXT4_JRNL__
 #define __EXT4_JRNL__
 
+#define EXT4_FEATURE_COMPAT_HAS_JOURNAL                0x0004
+
 #define EXT2_JOURNAL_INO               8       /* Journal inode */
 #define EXT2_JOURNAL_SUPERBLOCK        0       /* Journal  Superblock number */