arm: socfpga: Move Stratix 10 SDRAM driver to DM
authorLey Foon Tan <ley.foon.tan@intel.com>
Mon, 6 May 2019 01:56:01 +0000 (09:56 +0800)
committerMarek Vasut <marex@denx.de>
Mon, 6 May 2019 10:44:17 +0000 (12:44 +0200)
Convert Stratix 10 SDRAM driver to device model.

Get rid of call to socfpga_per_reset() and use reset
framework.

SPL is changed from calling function in SDRAM driver
directly to just probing UCLASS_RAM.

Move sdram_s10.h from arch to driver/ddr/altera directory.

Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
arch/arm/mach-socfpga/include/mach/sdram_s10.h [deleted file]
arch/arm/mach-socfpga/spl_s10.c
configs/socfpga_stratix10_defconfig
drivers/ddr/altera/Kconfig
drivers/ddr/altera/sdram_s10.c
drivers/ddr/altera/sdram_s10.h [new file with mode: 0644]
include/configs/socfpga_stratix10_socdk.h
scripts/config_whitelist.txt

diff --git a/arch/arm/mach-socfpga/include/mach/sdram_s10.h b/arch/arm/mach-socfpga/include/mach/sdram_s10.h
deleted file mode 100644 (file)
index f39206c..0000000
+++ /dev/null
@@ -1,192 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0
- *
- * Copyright (C) 2017-2018 Intel Corporation <www.intel.com>
- *
- */
-
-#ifndef        _SDRAM_S10_H_
-#define        _SDRAM_S10_H_
-
-phys_size_t sdram_calculate_size(void);
-int sdram_mmr_init_full(unsigned int sdr_phy_reg);
-int sdram_calibration_full(void);
-
-#define DDR_TWR                                15
-#define DDR_READ_LATENCY_DELAY         40
-#define DDR_ACTIVATE_FAWBANK           0x1
-
-/* ECC HMC registers */
-#define DDRIOCTRL                      0x8
-#define DDRCALSTAT                     0xc
-#define DRAMADDRWIDTH                  0xe0
-#define ECCCTRL1                       0x100
-#define ECCCTRL2                       0x104
-#define ERRINTEN                       0x110
-#define ERRINTENS                      0x114
-#define INTMODE                                0x11c
-#define INTSTAT                                0x120
-#define AUTOWB_CORRADDR                        0x138
-#define ECC_REG2WRECCDATABUS           0x144
-#define ECC_DIAGON                     0x150
-#define ECC_DECSTAT                    0x154
-#define HPSINTFCSEL                    0x210
-#define RSTHANDSHAKECTRL               0x214
-#define RSTHANDSHAKESTAT               0x218
-
-#define DDR_HMC_DDRIOCTRL_IOSIZE_MSK           0x00000003
-#define DDR_HMC_DDRCALSTAT_CAL_MSK             BIT(0)
-#define DDR_HMC_ECCCTL_AWB_CNT_RST_SET_MSK     BIT(16)
-#define DDR_HMC_ECCCTL_CNT_RST_SET_MSK         BIT(8)
-#define DDR_HMC_ECCCTL_ECC_EN_SET_MSK          BIT(0)
-#define DDR_HMC_ECCCTL2_RMW_EN_SET_MSK         BIT(8)
-#define DDR_HMC_ECCCTL2_AWB_EN_SET_MSK         BIT(0)
-#define DDR_HMC_ECC_DIAGON_ECCDIAGON_EN_SET_MSK        BIT(16)
-#define DDR_HMC_ECC_DIAGON_WRDIAGON_EN_SET_MSK BIT(0)
-#define DDR_HMC_ERRINTEN_SERRINTEN_EN_SET_MSK  BIT(0)
-#define DDR_HMC_ERRINTEN_DERRINTEN_EN_SET_MSK  BIT(1)
-#define DDR_HMC_INTSTAT_SERRPENA_SET_MSK       BIT(0)
-#define DDR_HMC_INTSTAT_DERRPENA_SET_MSK       BIT(1)
-#define DDR_HMC_INTSTAT_ADDRMTCFLG_SET_MSK     BIT(16)
-#define DDR_HMC_INTMODE_INTMODE_SET_MSK                BIT(0)
-#define DDR_HMC_RSTHANDSHAKE_MASK              0x000000ff
-#define DDR_HMC_CORE2SEQ_INT_REQ               0xF
-#define DDR_HMC_SEQ2CORE_INT_RESP_MASK         BIT(3)
-#define DDR_HMC_HPSINTFCSEL_ENABLE_MASK                0x001f1f1f
-
-#define        DDR_HMC_ERRINTEN_INTMASK                                \
-               (DDR_HMC_ERRINTEN_SERRINTEN_EN_SET_MSK |        \
-                DDR_HMC_ERRINTEN_DERRINTEN_EN_SET_MSK)
-
-/* NOC DDR scheduler */
-#define DDR_SCH_ID_COREID              0
-#define DDR_SCH_ID_REVID               0x4
-#define DDR_SCH_DDRCONF                        0x8
-#define DDR_SCH_DDRTIMING              0xc
-#define DDR_SCH_DDRMODE                        0x10
-#define DDR_SCH_READ_LATENCY           0x14
-#define DDR_SCH_ACTIVATE               0x38
-#define DDR_SCH_DEVTODEV               0x3c
-#define DDR_SCH_DDR4TIMING             0x40
-
-#define DDR_SCH_DDRTIMING_ACTTOACT_OFF         0
-#define DDR_SCH_DDRTIMING_RDTOMISS_OFF         6
-#define DDR_SCH_DDRTIMING_WRTOMISS_OFF         12
-#define DDR_SCH_DDRTIMING_BURSTLEN_OFF         18
-#define DDR_SCH_DDRTIMING_RDTOWR_OFF           21
-#define DDR_SCH_DDRTIMING_WRTORD_OFF           26
-#define DDR_SCH_DDRTIMING_BWRATIO_OFF          31
-#define DDR_SCH_DDRMOD_BWRATIOEXTENDED_OFF     1
-#define DDR_SCH_ACTIVATE_RRD_OFF               0
-#define DDR_SCH_ACTIVATE_FAW_OFF               4
-#define DDR_SCH_ACTIVATE_FAWBANK_OFF           10
-#define DDR_SCH_DEVTODEV_BUSRDTORD_OFF         0
-#define DDR_SCH_DEVTODEV_BUSRDTOWR_OFF         2
-#define DDR_SCH_DEVTODEV_BUSWRTORD_OFF         4
-
-/* HMC MMR IO48 registers */
-#define CTRLCFG0                       0x28
-#define CTRLCFG1                       0x2c
-#define DRAMTIMING0                    0x50
-#define CALTIMING0                     0x7c
-#define CALTIMING1                     0x80
-#define CALTIMING2                     0x84
-#define CALTIMING3                     0x88
-#define CALTIMING4                     0x8c
-#define CALTIMING9                     0xa0
-#define DRAMADDRW                      0xa8
-#define DRAMSTS                                0xec
-#define NIOSRESERVED0                  0x110
-#define NIOSRESERVED1                  0x114
-#define NIOSRESERVED2                  0x118
-
-#define DRAMADDRW_CFG_COL_ADDR_WIDTH(x)                        \
-       (((x) >> 0) & 0x1F)
-#define DRAMADDRW_CFG_ROW_ADDR_WIDTH(x)                        \
-       (((x) >> 5) & 0x1F)
-#define DRAMADDRW_CFG_BANK_ADDR_WIDTH(x)               \
-       (((x) >> 10) & 0xF)
-#define DRAMADDRW_CFG_BANK_GRP_ADDR_WIDTH(x)           \
-       (((x) >> 14) & 0x3)
-#define DRAMADDRW_CFG_CS_ADDR_WIDTH(x)                 \
-       (((x) >> 16) & 0x7)
-
-#define CTRLCFG0_CFG_MEMTYPE(x)                                \
-       (((x) >> 0) & 0xF)
-#define CTRLCFG0_CFG_DIMM_TYPE(x)                      \
-       (((x) >> 4) & 0x7)
-#define CTRLCFG0_CFG_AC_POS(x)                         \
-       (((x) >> 7) & 0x3)
-#define CTRLCFG0_CFG_CTRL_BURST_LEN(x)                 \
-       (((x) >> 9) & 0x1F)
-
-#define CTRLCFG1_CFG_DBC3_BURST_LEN(x)                 \
-       (((x) >> 0) & 0x1F)
-#define CTRLCFG1_CFG_ADDR_ORDER(x)                     \
-       (((x) >> 5) & 0x3)
-#define CTRLCFG1_CFG_CTRL_EN_ECC(x)                    \
-       (((x) >> 7) & 0x1)
-
-#define DRAMTIMING0_CFG_TCL(x)                         \
-       (((x) >> 0) & 0x7F)
-
-#define CALTIMING0_CFG_ACT_TO_RDWR(x)                  \
-       (((x) >> 0) & 0x3F)
-#define CALTIMING0_CFG_ACT_TO_PCH(x)                   \
-       (((x) >> 6) & 0x3F)
-#define CALTIMING0_CFG_ACT_TO_ACT(x)                   \
-       (((x) >> 12) & 0x3F)
-#define CALTIMING0_CFG_ACT_TO_ACT_DB(x)                        \
-       (((x) >> 18) & 0x3F)
-
-#define CALTIMING1_CFG_RD_TO_RD(x)                     \
-       (((x) >> 0) & 0x3F)
-#define CALTIMING1_CFG_RD_TO_RD_DC(x)                  \
-       (((x) >> 6) & 0x3F)
-#define CALTIMING1_CFG_RD_TO_RD_DB(x)                  \
-       (((x) >> 12) & 0x3F)
-#define CALTIMING1_CFG_RD_TO_WR(x)                     \
-       (((x) >> 18) & 0x3F)
-#define CALTIMING1_CFG_RD_TO_WR_DC(x)                  \
-       (((x) >> 24) & 0x3F)
-
-#define CALTIMING2_CFG_RD_TO_WR_DB(x)                  \
-       (((x) >> 0) & 0x3F)
-#define CALTIMING2_CFG_RD_TO_WR_PCH(x)                 \
-       (((x) >> 6) & 0x3F)
-#define CALTIMING2_CFG_RD_AP_TO_VALID(x)               \
-       (((x) >> 12) & 0x3F)
-#define CALTIMING2_CFG_WR_TO_WR(x)                     \
-       (((x) >> 18) & 0x3F)
-#define CALTIMING2_CFG_WR_TO_WR_DC(x)                  \
-       (((x) >> 24) & 0x3F)
-
-#define CALTIMING3_CFG_WR_TO_WR_DB(x)                  \
-       (((x) >> 0) & 0x3F)
-#define CALTIMING3_CFG_WR_TO_RD(x)                     \
-       (((x) >> 6) & 0x3F)
-#define CALTIMING3_CFG_WR_TO_RD_DC(x)                  \
-       (((x) >> 12) & 0x3F)
-#define CALTIMING3_CFG_WR_TO_RD_DB(x)                  \
-       (((x) >> 18) & 0x3F)
-#define CALTIMING3_CFG_WR_TO_PCH(x)                    \
-       (((x) >> 24) & 0x3F)
-
-#define CALTIMING4_CFG_WR_AP_TO_VALID(x)               \
-       (((x) >> 0) & 0x3F)
-#define CALTIMING4_CFG_PCH_TO_VALID(x)                 \
-       (((x) >> 6) & 0x3F)
-#define CALTIMING4_CFG_PCH_ALL_TO_VALID(x)             \
-       (((x) >> 12) & 0x3F)
-#define CALTIMING4_CFG_ARF_TO_VALID(x)                 \
-       (((x) >> 18) & 0xFF)
-#define CALTIMING4_CFG_PDN_TO_VALID(x)                 \
-       (((x) >> 26) & 0x3F)
-
-#define CALTIMING9_CFG_4_ACT_TO_ACT(x)                 \
-       (((x) >> 0) & 0xFF)
-
-/* Firewall DDR scheduler MPFE */
-#define FW_HMC_ADAPTOR_REG_ADDR                        0xf8020004
-#define FW_HMC_ADAPTOR_MPU_MASK                        BIT(0)
-
-#endif /* _SDRAM_S10_H_ */
index a141ffe82a89ef3809948c721014a074211f46ad..ec65e1ce649a4ba1e8d9100a7311e8b0080f5c05 100644 (file)
@@ -15,9 +15,9 @@
 #include <asm/arch/firewall_s10.h>
 #include <asm/arch/mailbox_s10.h>
 #include <asm/arch/reset_manager.h>
-#include <asm/arch/sdram_s10.h>
 #include <asm/arch/system_manager.h>
 #include <watchdog.h>
+#include <dm/uclass.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
@@ -175,11 +175,15 @@ void board_init_f(ulong dummy)
        clrbits_le32(CCU_REG_ADDR(CCU_IOM_MPRT_ADMASK_MEM_RAM0),
                     CCU_ADMASK_P_MASK | CCU_ADMASK_NS_MASK);
 
-       debug("DDR: Initializing Hard Memory Controller\n");
-       if (sdram_mmr_init_full(0)) {
-               puts("DDR: Initialization failed.\n");
-               hang();
-       }
+#if CONFIG_IS_ENABLED(ALTERA_SDRAM)
+               struct udevice *dev;
+
+               ret = uclass_get_device(UCLASS_RAM, 0, &dev);
+               if (ret) {
+                       debug("DRAM init failed: %d\n", ret);
+                       hang();
+               }
+#endif
 
        mbox_init();
 
index 73a1231d46b702f89e0d711cd2f2e2cbd9a61dc6..18cc95945004dee41932ea293bb7868f322bf735 100644 (file)
@@ -31,6 +31,7 @@ CONFIG_DEFAULT_DEVICE_TREE="socfpga_stratix10_socdk"
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_SPL_DM_SEQ_ALIAS=y
+CONFIG_SPL_ALTERA_SDRAM=y
 CONFIG_DM_GPIO=y
 CONFIG_DWAPB_GPIO=y
 CONFIG_DM_I2C=y
index 83c1ab5e079ffbb5bb43cf9cf55677a63804c2c2..2b1c1be3b51295da37cc774e53f674d25cbec9a0 100644 (file)
@@ -1,8 +1,8 @@
 config SPL_ALTERA_SDRAM
        bool "SoCFPGA DDR SDRAM driver in SPL"
        depends on SPL
-       depends on TARGET_SOCFPGA_GEN5 || TARGET_SOCFPGA_ARRIA10
-       select RAM if TARGET_SOCFPGA_GEN5
-       select SPL_RAM if TARGET_SOCFPGA_GEN5
+       depends on TARGET_SOCFPGA_GEN5 || TARGET_SOCFPGA_ARRIA10 || TARGET_SOCFPGA_STRATIX10
+       select RAM if TARGET_SOCFPGA_GEN5 || TARGET_SOCFPGA_STRATIX10
+       select SPL_RAM if TARGET_SOCFPGA_GEN5 || TARGET_SOCFPGA_STRATIX10
        help
          Enable DDR SDRAM controller for the SoCFPGA devices.
index e4d4a02ca2c3da8dccfdd3f0347c2149991aca47..56cbbac9fe1f1242d977786ed919306bd5bc47bc 100644 (file)
@@ -5,17 +5,31 @@
  */
 
 #include <common.h>
+#include <dm.h>
 #include <errno.h>
 #include <div64.h>
 #include <fdtdec.h>
-#include <asm/io.h>
+#include <ram.h>
+#include <reset.h>
+#include "sdram_s10.h"
 #include <wait_bit.h>
 #include <asm/arch/firewall_s10.h>
-#include <asm/arch/sdram_s10.h>
 #include <asm/arch/system_manager.h>
 #include <asm/arch/reset_manager.h>
+#include <asm/io.h>
 #include <linux/sizes.h>
 
+struct altera_sdram_priv {
+       struct ram_info info;
+       struct reset_ctl_bulk resets;
+};
+
+struct altera_sdram_platdata {
+       void __iomem *hmc;
+       void __iomem *ddr_sch;
+       void __iomem *iomhc;
+};
+
 DECLARE_GLOBAL_DATA_PTR;
 
 static const struct socfpga_system_manager *sysmgr_regs =
@@ -51,25 +65,26 @@ u32 ddr_config[] = {
        DDR_CONFIG(1, 4, 10, 17),
 };
 
-static u32 hmc_readl(u32 reg)
+static u32 hmc_readl(struct altera_sdram_platdata *plat, u32 reg)
 {
-       return readl(((void __iomem *)SOCFPGA_HMC_MMR_IO48_ADDRESS + (reg)));
+       return readl(plat->iomhc + reg);
 }
 
-static u32 hmc_ecc_readl(u32 reg)
+static u32 hmc_ecc_readl(struct altera_sdram_platdata *plat, u32 reg)
 {
-       return readl((void __iomem *)SOCFPGA_SDR_ADDRESS + (reg));
+       return readl(plat->hmc + reg);
 }
 
-static u32 hmc_ecc_writel(u32 data, u32 reg)
+static u32 hmc_ecc_writel(struct altera_sdram_platdata *plat,
+                         u32 data, u32 reg)
 {
-       return writel(data, (void __iomem *)SOCFPGA_SDR_ADDRESS + (reg));
+       return writel(data, plat->hmc + reg);
 }
 
-static u32 ddr_sch_writel(u32 data, u32 reg)
+static u32 ddr_sch_writel(struct altera_sdram_platdata *plat, u32 data,
+                         u32 reg)
 {
-       return writel(data,
-                     (void __iomem *)SOCFPGA_SDR_SCHEDULER_ADDRESS + (reg));
+       return writel(data, plat->ddr_sch + reg);
 }
 
 int match_ddr_conf(u32 ddr_conf)
@@ -83,37 +98,38 @@ int match_ddr_conf(u32 ddr_conf)
        return 0;
 }
 
-static int emif_clear(void)
+static int emif_clear(struct altera_sdram_platdata *plat)
 {
-       hmc_ecc_writel(0, RSTHANDSHAKECTRL);
+       hmc_ecc_writel(plat, 0, RSTHANDSHAKECTRL);
 
-       return wait_for_bit_le32((const void *)(SOCFPGA_SDR_ADDRESS +
+       return wait_for_bit_le32((const void *)(plat->hmc +
                                 RSTHANDSHAKESTAT),
                                 DDR_HMC_RSTHANDSHAKE_MASK,
                                 false, 1000, false);
 }
 
-static int emif_reset(void)
+static int emif_reset(struct altera_sdram_platdata *plat)
 {
        u32 c2s, s2c, ret;
 
-       c2s = hmc_ecc_readl(RSTHANDSHAKECTRL) & DDR_HMC_RSTHANDSHAKE_MASK;
-       s2c = hmc_ecc_readl(RSTHANDSHAKESTAT) & DDR_HMC_RSTHANDSHAKE_MASK;
+       c2s = hmc_ecc_readl(plat, RSTHANDSHAKECTRL) & DDR_HMC_RSTHANDSHAKE_MASK;
+       s2c = hmc_ecc_readl(plat, RSTHANDSHAKESTAT) & DDR_HMC_RSTHANDSHAKE_MASK;
 
        debug("DDR: c2s=%08x s2c=%08x nr0=%08x nr1=%08x nr2=%08x dst=%08x\n",
-             c2s, s2c, hmc_readl(NIOSRESERVED0), hmc_readl(NIOSRESERVED1),
-             hmc_readl(NIOSRESERVED2), hmc_readl(DRAMSTS));
+             c2s, s2c, hmc_readl(plat, NIOSRESERVED0),
+             hmc_readl(plat, NIOSRESERVED1), hmc_readl(plat, NIOSRESERVED2),
+             hmc_readl(plat, DRAMSTS));
 
-       if (s2c && emif_clear()) {
+       if (s2c && emif_clear(plat)) {
                printf("DDR: emif_clear() failed\n");
                return -1;
        }
 
        debug("DDR: Triggerring emif reset\n");
-       hmc_ecc_writel(DDR_HMC_CORE2SEQ_INT_REQ, RSTHANDSHAKECTRL);
+       hmc_ecc_writel(plat, DDR_HMC_CORE2SEQ_INT_REQ, RSTHANDSHAKECTRL);
 
        /* if seq2core[3] = 0, we are good */
-       ret = wait_for_bit_le32((const void *)(SOCFPGA_SDR_ADDRESS +
+       ret = wait_for_bit_le32((const void *)(plat->hmc +
                                 RSTHANDSHAKESTAT),
                                 DDR_HMC_SEQ2CORE_INT_RESP_MASK,
                                 false, 1000, false);
@@ -122,7 +138,7 @@ static int emif_reset(void)
                return ret;
        }
 
-       ret = emif_clear();
+       ret = emif_clear(plat);
        if (ret) {
                printf("DDR: emif_clear() failed\n");
                return ret;
@@ -240,13 +256,37 @@ static void sdram_size_check(bd_t *bd)
        debug("DDR: SDRAM size check passed!\n");
 }
 
+/**
+ * sdram_calculate_size() - Calculate SDRAM size
+ *
+ * Calculate SDRAM device size based on SDRAM controller parameters.
+ * Size is specified in bytes.
+ */
+static phys_size_t sdram_calculate_size(struct altera_sdram_platdata *plat)
+{
+       u32 dramaddrw = hmc_readl(plat, DRAMADDRW);
+
+       phys_size_t size = 1 << (DRAMADDRW_CFG_CS_ADDR_WIDTH(dramaddrw) +
+                        DRAMADDRW_CFG_BANK_GRP_ADDR_WIDTH(dramaddrw) +
+                        DRAMADDRW_CFG_BANK_ADDR_WIDTH(dramaddrw) +
+                        DRAMADDRW_CFG_ROW_ADDR_WIDTH(dramaddrw) +
+                        DRAMADDRW_CFG_COL_ADDR_WIDTH(dramaddrw));
+
+       size *= (2 << (hmc_ecc_readl(plat, DDRIOCTRL) &
+                       DDR_HMC_DDRIOCTRL_IOSIZE_MSK));
+
+       return size;
+}
+
 /**
  * sdram_mmr_init_full() - Function to initialize SDRAM MMR
  *
  * Initialize the SDRAM MMR.
  */
-int sdram_mmr_init_full(unsigned int unused)
+static int sdram_mmr_init_full(struct udevice *dev)
 {
+       struct altera_sdram_platdata *plat = dev->platdata;
+       struct altera_sdram_priv *priv = dev_get_priv(dev);
        u32 update_value, io48_value, ddrioctl;
        u32 i;
        int ret;
@@ -303,19 +343,16 @@ int sdram_mmr_init_full(unsigned int unused)
                return -1;
        }
 
-       /* release DDR scheduler from reset */
-       socfpga_per_reset(SOCFPGA_RESET(SDR), 0);
-
        /* Try 3 times to do a calibration */
        for (i = 0; i < 3; i++) {
-               ret = wait_for_bit_le32((const void *)(SOCFPGA_SDR_ADDRESS +
+               ret = wait_for_bit_le32((const void *)(plat->hmc +
                                        DDRCALSTAT),
                                        DDR_HMC_DDRCALSTAT_CAL_MSK, true, 1000,
                                        false);
                if (!ret)
                        break;
 
-               emif_reset();
+               emif_reset(plat);
        }
 
        if (ret) {
@@ -324,16 +361,16 @@ int sdram_mmr_init_full(unsigned int unused)
        }
        debug("DDR: Calibration success\n");
 
-       u32 ctrlcfg0 = hmc_readl(CTRLCFG0);
-       u32 ctrlcfg1 = hmc_readl(CTRLCFG1);
-       u32 dramaddrw = hmc_readl(DRAMADDRW);
-       u32 dramtim0 = hmc_readl(DRAMTIMING0);
-       u32 caltim0 = hmc_readl(CALTIMING0);
-       u32 caltim1 = hmc_readl(CALTIMING1);
-       u32 caltim2 = hmc_readl(CALTIMING2);
-       u32 caltim3 = hmc_readl(CALTIMING3);
-       u32 caltim4 = hmc_readl(CALTIMING4);
-       u32 caltim9 = hmc_readl(CALTIMING9);
+       u32 ctrlcfg0 = hmc_readl(plat, CTRLCFG0);
+       u32 ctrlcfg1 = hmc_readl(plat, CTRLCFG1);
+       u32 dramaddrw = hmc_readl(plat, DRAMADDRW);
+       u32 dramtim0 = hmc_readl(plat, DRAMTIMING0);
+       u32 caltim0 = hmc_readl(plat, CALTIMING0);
+       u32 caltim1 = hmc_readl(plat, CALTIMING1);
+       u32 caltim2 = hmc_readl(plat, CALTIMING2);
+       u32 caltim3 = hmc_readl(plat, CALTIMING3);
+       u32 caltim4 = hmc_readl(plat, CALTIMING4);
+       u32 caltim9 = hmc_readl(plat, CALTIMING9);
 
        /*
         * Configure the DDR IO size [0xFFCFB008]
@@ -349,12 +386,12 @@ int sdram_mmr_init_full(unsigned int unused)
         *      bit[9:6] = Minor Release #
         *      bit[14:10] = Major Release #
         */
-       update_value = hmc_readl(NIOSRESERVED0);
-       hmc_ecc_writel(((update_value & 0xFF) >> 5), DDRIOCTRL);
-       ddrioctl = hmc_ecc_readl(DDRIOCTRL);
+       update_value = hmc_readl(plat, NIOSRESERVED0);
+       hmc_ecc_writel(plat, ((update_value & 0xFF) >> 5), DDRIOCTRL);
+       ddrioctl = hmc_ecc_readl(plat, DDRIOCTRL);
 
        /* enable HPS interface to HMC */
-       hmc_ecc_writel(DDR_HMC_HPSINTFCSEL_ENABLE_MASK, HPSINTFCSEL);
+       hmc_ecc_writel(plat, DDR_HMC_HPSINTFCSEL_ENABLE_MASK, HPSINTFCSEL);
 
        /* Set the DDR Configuration */
        io48_value = DDR_CONFIG(CTRLCFG1_CFG_ADDR_ORDER(ctrlcfg1),
@@ -365,10 +402,10 @@ int sdram_mmr_init_full(unsigned int unused)
 
        update_value = match_ddr_conf(io48_value);
        if (update_value)
-               ddr_sch_writel(update_value, DDR_SCH_DDRCONF);
+               ddr_sch_writel(plat, update_value, DDR_SCH_DDRCONF);
 
        /* Configure HMC dramaddrw */
-       hmc_ecc_writel(hmc_readl(DRAMADDRW), DRAMADDRWIDTH);
+       hmc_ecc_writel(plat, hmc_readl(plat, DRAMADDRW), DRAMADDRWIDTH);
 
        /*
         * Configure DDR timing
@@ -392,7 +429,7 @@ int sdram_mmr_init_full(unsigned int unused)
                      CALTIMING0_CFG_ACT_TO_RDWR(caltim0) +
                      CALTIMING4_CFG_PCH_TO_VALID(caltim4));
 
-       ddr_sch_writel(((CALTIMING0_CFG_ACT_TO_ACT(caltim0) <<
+       ddr_sch_writel(plat, ((CALTIMING0_CFG_ACT_TO_ACT(caltim0) <<
                         DDR_SCH_DDRTIMING_ACTTOACT_OFF) |
                        (update_value << DDR_SCH_DDRTIMING_RDTOMISS_OFF) |
                        (io48_value << DDR_SCH_DDRTIMING_WRTOMISS_OFF) |
@@ -406,12 +443,12 @@ int sdram_mmr_init_full(unsigned int unused)
                        DDR_SCH_DDRTIMING);
 
        /* Configure DDR mode [precharge = 0] */
-       ddr_sch_writel(((ddrioctl ? 0 : 1) <<
+       ddr_sch_writel(plat, ((ddrioctl ? 0 : 1) <<
                         DDR_SCH_DDRMOD_BWRATIOEXTENDED_OFF),
                        DDR_SCH_DDRMODE);
 
        /* Configure the read latency */
-       ddr_sch_writel((DRAMTIMING0_CFG_TCL(dramtim0) >> 1) +
+       ddr_sch_writel(plat, (DRAMTIMING0_CFG_TCL(dramtim0) >> 1) +
                        DDR_READ_LATENCY_DELAY,
                        DDR_SCH_READ_LATENCY);
 
@@ -419,7 +456,7 @@ int sdram_mmr_init_full(unsigned int unused)
         * Configuring timing values concerning activate commands
         * [FAWBANK alway 1 because always 4 bank DDR]
         */
-       ddr_sch_writel(((CALTIMING0_CFG_ACT_TO_ACT_DB(caltim0) <<
+       ddr_sch_writel(plat, ((CALTIMING0_CFG_ACT_TO_ACT_DB(caltim0) <<
                         DDR_SCH_ACTIVATE_RRD_OFF) |
                        (CALTIMING9_CFG_4_ACT_TO_ACT(caltim9) <<
                         DDR_SCH_ACTIVATE_FAW_OFF) |
@@ -431,7 +468,7 @@ int sdram_mmr_init_full(unsigned int unused)
         * Configuring timing values concerning device to device data bus
         * ownership change
         */
-       ddr_sch_writel(((CALTIMING1_CFG_RD_TO_RD_DC(caltim1) <<
+       ddr_sch_writel(plat, ((CALTIMING1_CFG_RD_TO_RD_DC(caltim1) <<
                         DDR_SCH_DEVTODEV_BUSRDTORD_OFF) |
                        (CALTIMING1_CFG_RD_TO_WR_DC(caltim1) <<
                         DDR_SCH_DEVTODEV_BUSRDTOWR_OFF) |
@@ -440,7 +477,7 @@ int sdram_mmr_init_full(unsigned int unused)
                        DDR_SCH_DEVTODEV);
 
        /* assigning the SDRAM size */
-       unsigned long long size = sdram_calculate_size();
+       unsigned long long size = sdram_calculate_size(plat);
        /* If the size is invalid, use default Config size */
        if (size <= 0)
                hw_size = PHYS_SDRAM_1_SIZE;
@@ -462,18 +499,17 @@ int sdram_mmr_init_full(unsigned int unused)
 
        /* Enable or disable the SDRAM ECC */
        if (CTRLCFG1_CFG_CTRL_EN_ECC(ctrlcfg1)) {
-               setbits_le32(SOCFPGA_SDR_ADDRESS + ECCCTRL1,
+               setbits_le32(plat->hmc + ECCCTRL1,
                             (DDR_HMC_ECCCTL_AWB_CNT_RST_SET_MSK |
                              DDR_HMC_ECCCTL_CNT_RST_SET_MSK |
                              DDR_HMC_ECCCTL_ECC_EN_SET_MSK));
-               clrbits_le32(SOCFPGA_SDR_ADDRESS + ECCCTRL1,
+               clrbits_le32(plat->hmc + ECCCTRL1,
                             (DDR_HMC_ECCCTL_AWB_CNT_RST_SET_MSK |
                              DDR_HMC_ECCCTL_CNT_RST_SET_MSK));
-               setbits_le32(SOCFPGA_SDR_ADDRESS + ECCCTRL2,
+               setbits_le32(plat->hmc + ECCCTRL2,
                             (DDR_HMC_ECCCTL2_RMW_EN_SET_MSK |
                              DDR_HMC_ECCCTL2_AWB_EN_SET_MSK));
-               writel(DDR_HMC_ERRINTEN_INTMASK,
-                      SOCFPGA_SDR_ADDRESS + ERRINTENS);
+               hmc_ecc_writel(plat, DDR_HMC_ERRINTEN_INTMASK, ERRINTENS);
 
                /* Enable non-secure writes to HMC Adapter for SDRAM ECC */
                writel(FW_HMC_ADAPTOR_MPU_MASK, FW_HMC_ADAPTOR_REG_ADDR);
@@ -482,39 +518,98 @@ int sdram_mmr_init_full(unsigned int unused)
                if (!cpu_has_been_warmreset())
                        sdram_init_ecc_bits(&bd);
        } else {
-               clrbits_le32(SOCFPGA_SDR_ADDRESS + ECCCTRL1,
+               clrbits_le32(plat->hmc + ECCCTRL1,
                             (DDR_HMC_ECCCTL_AWB_CNT_RST_SET_MSK |
                              DDR_HMC_ECCCTL_CNT_RST_SET_MSK |
                              DDR_HMC_ECCCTL_ECC_EN_SET_MSK));
-               clrbits_le32(SOCFPGA_SDR_ADDRESS + ECCCTRL2,
+               clrbits_le32(plat->hmc + ECCCTRL2,
                             (DDR_HMC_ECCCTL2_RMW_EN_SET_MSK |
                              DDR_HMC_ECCCTL2_AWB_EN_SET_MSK));
        }
 
        sdram_size_check(&bd);
 
+       priv->info.base = bd.bi_dram[0].start;
+       priv->info.size = gd->ram_size;
+
        debug("DDR: HMC init success\n");
        return 0;
 }
 
-/**
- * sdram_calculate_size() - Calculate SDRAM size
- *
- * Calculate SDRAM device size based on SDRAM controller parameters.
- * Size is specified in bytes.
- */
-phys_size_t sdram_calculate_size(void)
+static int altera_sdram_ofdata_to_platdata(struct udevice *dev)
 {
-       u32 dramaddrw = hmc_readl(DRAMADDRW);
+       struct altera_sdram_platdata *plat = dev->platdata;
+       fdt_addr_t addr;
 
-       phys_size_t size = 1 << (DRAMADDRW_CFG_CS_ADDR_WIDTH(dramaddrw) +
-                        DRAMADDRW_CFG_BANK_GRP_ADDR_WIDTH(dramaddrw) +
-                        DRAMADDRW_CFG_BANK_ADDR_WIDTH(dramaddrw) +
-                        DRAMADDRW_CFG_ROW_ADDR_WIDTH(dramaddrw) +
-                        DRAMADDRW_CFG_COL_ADDR_WIDTH(dramaddrw));
+       addr = dev_read_addr_index(dev, 0);
+       if (addr == FDT_ADDR_T_NONE)
+               return -EINVAL;
+       plat->ddr_sch = (void __iomem *)addr;
 
-       size *= (2 << (hmc_ecc_readl(DDRIOCTRL) &
-                       DDR_HMC_DDRIOCTRL_IOSIZE_MSK));
+       addr = dev_read_addr_index(dev, 1);
+       if (addr == FDT_ADDR_T_NONE)
+               return -EINVAL;
+       plat->iomhc = (void __iomem *)addr;
 
-       return size;
+       addr = dev_read_addr_index(dev, 2);
+       if (addr == FDT_ADDR_T_NONE)
+               return -EINVAL;
+       plat->hmc = (void __iomem *)addr;
+
+       return 0;
 }
+
+static int altera_sdram_probe(struct udevice *dev)
+{
+       int ret;
+       struct altera_sdram_priv *priv = dev_get_priv(dev);
+
+       ret = reset_get_bulk(dev, &priv->resets);
+       if (ret) {
+               dev_err(dev, "Can't get reset: %d\n", ret);
+               return -ENODEV;
+       }
+       reset_deassert_bulk(&priv->resets);
+
+       if (sdram_mmr_init_full(dev) != 0) {
+               puts("SDRAM init failed.\n");
+               goto failed;
+       }
+
+       return 0;
+
+failed:
+       reset_release_bulk(&priv->resets);
+       return -ENODEV;
+}
+
+static int altera_sdram_get_info(struct udevice *dev,
+                                struct ram_info *info)
+{
+       struct altera_sdram_priv *priv = dev_get_priv(dev);
+
+       info->base = priv->info.base;
+       info->size = priv->info.size;
+
+       return 0;
+}
+
+static struct ram_ops altera_sdram_ops = {
+       .get_info = altera_sdram_get_info,
+};
+
+static const struct udevice_id altera_sdram_ids[] = {
+       { .compatible = "altr,sdr-ctl-s10" },
+       { /* sentinel */ }
+};
+
+U_BOOT_DRIVER(altera_sdram) = {
+       .name = "altr_sdr_ctl",
+       .id = UCLASS_RAM,
+       .of_match = altera_sdram_ids,
+       .ops = &altera_sdram_ops,
+       .ofdata_to_platdata = altera_sdram_ofdata_to_platdata,
+       .platdata_auto_alloc_size = sizeof(struct altera_sdram_platdata),
+       .probe = altera_sdram_probe,
+       .priv_auto_alloc_size = sizeof(struct altera_sdram_priv),
+};
diff --git a/drivers/ddr/altera/sdram_s10.h b/drivers/ddr/altera/sdram_s10.h
new file mode 100644 (file)
index 0000000..096c06c
--- /dev/null
@@ -0,0 +1,188 @@
+/* SPDX-License-Identifier: GPL-2.0
+ *
+ * Copyright (C) 2017-2018 Intel Corporation <www.intel.com>
+ *
+ */
+
+#ifndef        _SDRAM_S10_H_
+#define        _SDRAM_S10_H_
+
+#define DDR_TWR                                15
+#define DDR_READ_LATENCY_DELAY         40
+#define DDR_ACTIVATE_FAWBANK           0x1
+
+/* ECC HMC registers */
+#define DDRIOCTRL                      0x8
+#define DDRCALSTAT                     0xc
+#define DRAMADDRWIDTH                  0xe0
+#define ECCCTRL1                       0x100
+#define ECCCTRL2                       0x104
+#define ERRINTEN                       0x110
+#define ERRINTENS                      0x114
+#define INTMODE                                0x11c
+#define INTSTAT                                0x120
+#define AUTOWB_CORRADDR                        0x138
+#define ECC_REG2WRECCDATABUS           0x144
+#define ECC_DIAGON                     0x150
+#define ECC_DECSTAT                    0x154
+#define HPSINTFCSEL                    0x210
+#define RSTHANDSHAKECTRL               0x214
+#define RSTHANDSHAKESTAT               0x218
+
+#define DDR_HMC_DDRIOCTRL_IOSIZE_MSK           0x00000003
+#define DDR_HMC_DDRCALSTAT_CAL_MSK             BIT(0)
+#define DDR_HMC_ECCCTL_AWB_CNT_RST_SET_MSK     BIT(16)
+#define DDR_HMC_ECCCTL_CNT_RST_SET_MSK         BIT(8)
+#define DDR_HMC_ECCCTL_ECC_EN_SET_MSK          BIT(0)
+#define DDR_HMC_ECCCTL2_RMW_EN_SET_MSK         BIT(8)
+#define DDR_HMC_ECCCTL2_AWB_EN_SET_MSK         BIT(0)
+#define DDR_HMC_ECC_DIAGON_ECCDIAGON_EN_SET_MSK        BIT(16)
+#define DDR_HMC_ECC_DIAGON_WRDIAGON_EN_SET_MSK BIT(0)
+#define DDR_HMC_ERRINTEN_SERRINTEN_EN_SET_MSK  BIT(0)
+#define DDR_HMC_ERRINTEN_DERRINTEN_EN_SET_MSK  BIT(1)
+#define DDR_HMC_INTSTAT_SERRPENA_SET_MSK       BIT(0)
+#define DDR_HMC_INTSTAT_DERRPENA_SET_MSK       BIT(1)
+#define DDR_HMC_INTSTAT_ADDRMTCFLG_SET_MSK     BIT(16)
+#define DDR_HMC_INTMODE_INTMODE_SET_MSK                BIT(0)
+#define DDR_HMC_RSTHANDSHAKE_MASK              0x000000ff
+#define DDR_HMC_CORE2SEQ_INT_REQ               0xF
+#define DDR_HMC_SEQ2CORE_INT_RESP_MASK         BIT(3)
+#define DDR_HMC_HPSINTFCSEL_ENABLE_MASK                0x001f1f1f
+
+#define        DDR_HMC_ERRINTEN_INTMASK                                \
+               (DDR_HMC_ERRINTEN_SERRINTEN_EN_SET_MSK |        \
+                DDR_HMC_ERRINTEN_DERRINTEN_EN_SET_MSK)
+
+/* NOC DDR scheduler */
+#define DDR_SCH_ID_COREID              0
+#define DDR_SCH_ID_REVID               0x4
+#define DDR_SCH_DDRCONF                        0x8
+#define DDR_SCH_DDRTIMING              0xc
+#define DDR_SCH_DDRMODE                        0x10
+#define DDR_SCH_READ_LATENCY           0x14
+#define DDR_SCH_ACTIVATE               0x38
+#define DDR_SCH_DEVTODEV               0x3c
+#define DDR_SCH_DDR4TIMING             0x40
+
+#define DDR_SCH_DDRTIMING_ACTTOACT_OFF         0
+#define DDR_SCH_DDRTIMING_RDTOMISS_OFF         6
+#define DDR_SCH_DDRTIMING_WRTOMISS_OFF         12
+#define DDR_SCH_DDRTIMING_BURSTLEN_OFF         18
+#define DDR_SCH_DDRTIMING_RDTOWR_OFF           21
+#define DDR_SCH_DDRTIMING_WRTORD_OFF           26
+#define DDR_SCH_DDRTIMING_BWRATIO_OFF          31
+#define DDR_SCH_DDRMOD_BWRATIOEXTENDED_OFF     1
+#define DDR_SCH_ACTIVATE_RRD_OFF               0
+#define DDR_SCH_ACTIVATE_FAW_OFF               4
+#define DDR_SCH_ACTIVATE_FAWBANK_OFF           10
+#define DDR_SCH_DEVTODEV_BUSRDTORD_OFF         0
+#define DDR_SCH_DEVTODEV_BUSRDTOWR_OFF         2
+#define DDR_SCH_DEVTODEV_BUSWRTORD_OFF         4
+
+/* HMC MMR IO48 registers */
+#define CTRLCFG0                       0x28
+#define CTRLCFG1                       0x2c
+#define DRAMTIMING0                    0x50
+#define CALTIMING0                     0x7c
+#define CALTIMING1                     0x80
+#define CALTIMING2                     0x84
+#define CALTIMING3                     0x88
+#define CALTIMING4                     0x8c
+#define CALTIMING9                     0xa0
+#define DRAMADDRW                      0xa8
+#define DRAMSTS                                0xec
+#define NIOSRESERVED0                  0x110
+#define NIOSRESERVED1                  0x114
+#define NIOSRESERVED2                  0x118
+
+#define DRAMADDRW_CFG_COL_ADDR_WIDTH(x)                        \
+       (((x) >> 0) & 0x1F)
+#define DRAMADDRW_CFG_ROW_ADDR_WIDTH(x)                        \
+       (((x) >> 5) & 0x1F)
+#define DRAMADDRW_CFG_BANK_ADDR_WIDTH(x)               \
+       (((x) >> 10) & 0xF)
+#define DRAMADDRW_CFG_BANK_GRP_ADDR_WIDTH(x)           \
+       (((x) >> 14) & 0x3)
+#define DRAMADDRW_CFG_CS_ADDR_WIDTH(x)                 \
+       (((x) >> 16) & 0x7)
+
+#define CTRLCFG0_CFG_MEMTYPE(x)                                \
+       (((x) >> 0) & 0xF)
+#define CTRLCFG0_CFG_DIMM_TYPE(x)                      \
+       (((x) >> 4) & 0x7)
+#define CTRLCFG0_CFG_AC_POS(x)                         \
+       (((x) >> 7) & 0x3)
+#define CTRLCFG0_CFG_CTRL_BURST_LEN(x)                 \
+       (((x) >> 9) & 0x1F)
+
+#define CTRLCFG1_CFG_DBC3_BURST_LEN(x)                 \
+       (((x) >> 0) & 0x1F)
+#define CTRLCFG1_CFG_ADDR_ORDER(x)                     \
+       (((x) >> 5) & 0x3)
+#define CTRLCFG1_CFG_CTRL_EN_ECC(x)                    \
+       (((x) >> 7) & 0x1)
+
+#define DRAMTIMING0_CFG_TCL(x)                         \
+       (((x) >> 0) & 0x7F)
+
+#define CALTIMING0_CFG_ACT_TO_RDWR(x)                  \
+       (((x) >> 0) & 0x3F)
+#define CALTIMING0_CFG_ACT_TO_PCH(x)                   \
+       (((x) >> 6) & 0x3F)
+#define CALTIMING0_CFG_ACT_TO_ACT(x)                   \
+       (((x) >> 12) & 0x3F)
+#define CALTIMING0_CFG_ACT_TO_ACT_DB(x)                        \
+       (((x) >> 18) & 0x3F)
+
+#define CALTIMING1_CFG_RD_TO_RD(x)                     \
+       (((x) >> 0) & 0x3F)
+#define CALTIMING1_CFG_RD_TO_RD_DC(x)                  \
+       (((x) >> 6) & 0x3F)
+#define CALTIMING1_CFG_RD_TO_RD_DB(x)                  \
+       (((x) >> 12) & 0x3F)
+#define CALTIMING1_CFG_RD_TO_WR(x)                     \
+       (((x) >> 18) & 0x3F)
+#define CALTIMING1_CFG_RD_TO_WR_DC(x)                  \
+       (((x) >> 24) & 0x3F)
+
+#define CALTIMING2_CFG_RD_TO_WR_DB(x)                  \
+       (((x) >> 0) & 0x3F)
+#define CALTIMING2_CFG_RD_TO_WR_PCH(x)                 \
+       (((x) >> 6) & 0x3F)
+#define CALTIMING2_CFG_RD_AP_TO_VALID(x)               \
+       (((x) >> 12) & 0x3F)
+#define CALTIMING2_CFG_WR_TO_WR(x)                     \
+       (((x) >> 18) & 0x3F)
+#define CALTIMING2_CFG_WR_TO_WR_DC(x)                  \
+       (((x) >> 24) & 0x3F)
+
+#define CALTIMING3_CFG_WR_TO_WR_DB(x)                  \
+       (((x) >> 0) & 0x3F)
+#define CALTIMING3_CFG_WR_TO_RD(x)                     \
+       (((x) >> 6) & 0x3F)
+#define CALTIMING3_CFG_WR_TO_RD_DC(x)                  \
+       (((x) >> 12) & 0x3F)
+#define CALTIMING3_CFG_WR_TO_RD_DB(x)                  \
+       (((x) >> 18) & 0x3F)
+#define CALTIMING3_CFG_WR_TO_PCH(x)                    \
+       (((x) >> 24) & 0x3F)
+
+#define CALTIMING4_CFG_WR_AP_TO_VALID(x)               \
+       (((x) >> 0) & 0x3F)
+#define CALTIMING4_CFG_PCH_TO_VALID(x)                 \
+       (((x) >> 6) & 0x3F)
+#define CALTIMING4_CFG_PCH_ALL_TO_VALID(x)             \
+       (((x) >> 12) & 0x3F)
+#define CALTIMING4_CFG_ARF_TO_VALID(x)                 \
+       (((x) >> 18) & 0xFF)
+#define CALTIMING4_CFG_PDN_TO_VALID(x)                 \
+       (((x) >> 26) & 0x3F)
+
+#define CALTIMING9_CFG_4_ACT_TO_ACT(x)                 \
+       (((x) >> 0) & 0xFF)
+
+/* Firewall DDR scheduler MPFE */
+#define FW_HMC_ADAPTOR_REG_ADDR                        0xf8020004
+#define FW_HMC_ADAPTOR_MPU_MASK                        BIT(0)
+
+#endif /* _SDRAM_S10_H_ */
index b8a86f2cb20b8be2eeabed5cf76c92a3fb259021..8d2971c6e231de6f4314c99551fed13d1a3a3b99 100644 (file)
@@ -129,11 +129,6 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
 #define CONFIG_SYS_MEMTEST_START       0
 #define CONFIG_SYS_MEMTEST_END         PHYS_SDRAM_1_SIZE - 0x200000
 
-/*
- * SDRAM controller
- */
-#define CONFIG_SPL_ALTERA_SDRAM
-
 /*
  * Serial / UART configurations
  */
index 46105538151de182db91dd4c4a81beef9f1e6fa5..bc86b848a217f6f6c1c307b77cddb89f81be0f05 100644 (file)
@@ -1824,7 +1824,6 @@ CONFIG_SPLASH_SCREEN_ALIGN
 CONFIG_SPLASH_SOURCE
 CONFIG_SPLL_FREQ
 CONFIG_SPL_
-CONFIG_SPL_ALTERA_SDRAM
 CONFIG_SPL_ATMEL_SIZE
 CONFIG_SPL_BOARD_LOAD_IMAGE
 CONFIG_SPL_BOOTROM_SAVE