cmd: efidebug: fix a build error in show_efi_boot_opt()
authorAKASHI Takahiro <takahiro.akashi@linaro.org>
Tue, 26 Nov 2019 01:11:22 +0000 (10:11 +0900)
committerHeinrich Schuchardt <xypron.glpk@gmx.de>
Tue, 3 Dec 2019 19:54:05 +0000 (20:54 +0100)
I detected the following error in sandbox with Clang on Travis CI:
    +cmd/efidebug.c:703:15: error: result of comparison of constant
     9223372036854775822 with expression of type 'int' is always false
     [-Werror,-Wtautological-constant-out-of-range-compare]
    +        else if (ret == EFI_NOT_FOUND)
    +                 ~~~ ^  ~~~~~~~~~~~~~

Simply changing a type of 'ret' to efi_status_t will fix this error.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
cmd/efidebug.c

index ef97e19d0735851f9fbdb93ee4910a53041b33b1..1fff4390deae3edf95da847c0d31d7d8186cbf37 100644 (file)
@@ -684,7 +684,7 @@ static void show_efi_boot_opt(int id)
        efi_guid_t guid;
        void *data = NULL;
        efi_uintn_t size;
-       int ret;
+       efi_status_t ret;
 
        sprintf(var_name, "Boot%04X", id);
        p = var_name16;
@@ -693,7 +693,7 @@ static void show_efi_boot_opt(int id)
 
        size = 0;
        ret = EFI_CALL(RT->get_variable(var_name16, &guid, NULL, &size, NULL));
-       if (ret == (int)EFI_BUFFER_TOO_SMALL) {
+       if (ret == EFI_BUFFER_TOO_SMALL) {
                data = malloc(size);
                ret = EFI_CALL(RT->get_variable(var_name16, &guid, NULL, &size,
                                                data));