cmd: bootefi: Parse reserved-memory node from DT
[oweals/u-boot.git] / cmd / bootefi.c
1 // SPDX-License-Identifier: GPL-2.0+
2 /*
3  *  EFI application loader
4  *
5  *  Copyright (c) 2016 Alexander Graf
6  */
7
8 #include <common.h>
9 #include <charset.h>
10 #include <command.h>
11 #include <dm.h>
12 #include <efi_loader.h>
13 #include <efi_selftest.h>
14 #include <env.h>
15 #include <errno.h>
16 #include <malloc.h>
17 #include <linux/libfdt.h>
18 #include <linux/libfdt_env.h>
19 #include <mapmem.h>
20 #include <memalign.h>
21 #include <asm-generic/sections.h>
22 #include <linux/linkage.h>
23
24 DECLARE_GLOBAL_DATA_PTR;
25
26 static struct efi_device_path *bootefi_image_path;
27 static struct efi_device_path *bootefi_device_path;
28
29 /**
30  * Set the load options of an image from an environment variable.
31  *
32  * @handle:             the image handle
33  * @env_var:            name of the environment variable
34  * @load_options:       pointer to load options (output)
35  * Return:              status code
36  */
37 static efi_status_t set_load_options(efi_handle_t handle, const char *env_var,
38                                      u16 **load_options)
39 {
40         struct efi_loaded_image *loaded_image_info;
41         size_t size;
42         const char *env = env_get(env_var);
43         u16 *pos;
44         efi_status_t ret;
45
46         *load_options = NULL;
47         ret = EFI_CALL(systab.boottime->open_protocol(
48                                         handle,
49                                         &efi_guid_loaded_image,
50                                         (void **)&loaded_image_info,
51                                         efi_root, NULL,
52                                         EFI_OPEN_PROTOCOL_BY_HANDLE_PROTOCOL));
53         if (ret != EFI_SUCCESS)
54                 return EFI_INVALID_PARAMETER;
55
56         loaded_image_info->load_options = NULL;
57         loaded_image_info->load_options_size = 0;
58         if (!env)
59                 goto out;
60
61         size = utf8_utf16_strlen(env) + 1;
62         loaded_image_info->load_options = calloc(size, sizeof(u16));
63         if (!loaded_image_info->load_options) {
64                 printf("ERROR: Out of memory\n");
65                 EFI_CALL(systab.boottime->close_protocol(handle,
66                                                          &efi_guid_loaded_image,
67                                                          efi_root, NULL));
68                 return EFI_OUT_OF_RESOURCES;
69         }
70         pos = loaded_image_info->load_options;
71         *load_options = pos;
72         utf8_utf16_strcpy(&pos, env);
73         loaded_image_info->load_options_size = size * 2;
74
75 out:
76         return EFI_CALL(systab.boottime->close_protocol(handle,
77                                                         &efi_guid_loaded_image,
78                                                         efi_root, NULL));
79 }
80
81 #if !CONFIG_IS_ENABLED(GENERATE_ACPI_TABLE)
82
83 /**
84  * copy_fdt() - Copy the device tree to a new location available to EFI
85  *
86  * The FDT is copied to a suitable location within the EFI memory map.
87  * Additional 12 KiB are added to the space in case the device tree needs to be
88  * expanded later with fdt_open_into().
89  *
90  * @fdtp:       On entry a pointer to the flattened device tree.
91  *              On exit a pointer to the copy of the flattened device tree.
92  *              FDT start
93  * Return:      status code
94  */
95 static efi_status_t copy_fdt(void **fdtp)
96 {
97         unsigned long fdt_ram_start = -1L, fdt_pages;
98         efi_status_t ret = 0;
99         void *fdt, *new_fdt;
100         u64 new_fdt_addr;
101         uint fdt_size;
102         int i;
103
104         for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
105                 u64 ram_start = gd->bd->bi_dram[i].start;
106                 u64 ram_size = gd->bd->bi_dram[i].size;
107
108                 if (!ram_size)
109                         continue;
110
111                 if (ram_start < fdt_ram_start)
112                         fdt_ram_start = ram_start;
113         }
114
115         /*
116          * Give us at least 12 KiB of breathing room in case the device tree
117          * needs to be expanded later.
118          */
119         fdt = *fdtp;
120         fdt_pages = efi_size_in_pages(fdt_totalsize(fdt) + 0x3000);
121         fdt_size = fdt_pages << EFI_PAGE_SHIFT;
122
123         /*
124          * Safe fdt location is at 127 MiB.
125          * On the sandbox convert from the sandbox address space.
126          */
127         new_fdt_addr = (uintptr_t)map_sysmem(fdt_ram_start + 0x7f00000 +
128                                              fdt_size, 0);
129         ret = efi_allocate_pages(EFI_ALLOCATE_MAX_ADDRESS,
130                                  EFI_BOOT_SERVICES_DATA, fdt_pages,
131                                  &new_fdt_addr);
132         if (ret != EFI_SUCCESS) {
133                 /* If we can't put it there, put it somewhere */
134                 new_fdt_addr = (ulong)memalign(EFI_PAGE_SIZE, fdt_size);
135                 ret = efi_allocate_pages(EFI_ALLOCATE_MAX_ADDRESS,
136                                          EFI_BOOT_SERVICES_DATA, fdt_pages,
137                                          &new_fdt_addr);
138                 if (ret != EFI_SUCCESS) {
139                         printf("ERROR: Failed to reserve space for FDT\n");
140                         goto done;
141                 }
142         }
143         new_fdt = (void *)(uintptr_t)new_fdt_addr;
144         memcpy(new_fdt, fdt, fdt_totalsize(fdt));
145         fdt_set_totalsize(new_fdt, fdt_size);
146
147         *fdtp = (void *)(uintptr_t)new_fdt_addr;
148 done:
149         return ret;
150 }
151
152 static void efi_reserve_memory(u64 addr, u64 size)
153 {
154         u64 pages;
155
156         /* Convert from sandbox address space. */
157         addr = (uintptr_t)map_sysmem(addr, 0);
158         pages = efi_size_in_pages(size + (addr & EFI_PAGE_MASK));
159         addr &= ~EFI_PAGE_MASK;
160         if (efi_add_memory_map(addr, pages, EFI_RESERVED_MEMORY_TYPE,
161                                false) != EFI_SUCCESS)
162                 printf("Reserved memory mapping failed addr %llx size %llx\n",
163                        addr, size);
164 }
165
166 /**
167  * efi_carve_out_dt_rsv() - Carve out DT reserved memory ranges
168  *
169  * The mem_rsv entries of the FDT are added to the memory map. Any failures are
170  * ignored because this is not critical and we would rather continue to try to
171  * boot.
172  *
173  * @fdt: Pointer to device tree
174  */
175 static void efi_carve_out_dt_rsv(void *fdt)
176 {
177         int nr_rsv, i;
178         u64 addr, size;
179         int nodeoffset, subnode;
180
181         nr_rsv = fdt_num_mem_rsv(fdt);
182
183         /* Look for an existing entry and add it to the efi mem map. */
184         for (i = 0; i < nr_rsv; i++) {
185                 if (fdt_get_mem_rsv(fdt, i, &addr, &size) != 0)
186                         continue;
187                 efi_reserve_memory(addr, size);
188         }
189
190         /* process reserved-memory */
191         nodeoffset = fdt_subnode_offset(fdt, 0, "reserved-memory");
192         if (nodeoffset >= 0) {
193                 subnode = fdt_first_subnode(fdt, nodeoffset);
194                 while (subnode >= 0) {
195                         /* check if this subnode has a reg property */
196                         addr = fdtdec_get_addr_size(fdt, subnode, "reg",
197                                                     (fdt_size_t *)&size);
198                         /*
199                          * The /reserved-memory node may have children with
200                          * a size instead of a reg property.
201                          */
202                         if (addr != FDT_ADDR_T_NONE)
203                                 efi_reserve_memory(addr, size);
204                         subnode = fdt_next_subnode(fdt, subnode);
205                 }
206         }
207 }
208
209 /**
210  * get_config_table() - get configuration table
211  *
212  * @guid:       GUID of the configuration table
213  * Return:      pointer to configuration table or NULL
214  */
215 static void *get_config_table(const efi_guid_t *guid)
216 {
217         size_t i;
218
219         for (i = 0; i < systab.nr_tables; i++) {
220                 if (!guidcmp(guid, &systab.tables[i].guid))
221                         return systab.tables[i].table;
222         }
223         return NULL;
224 }
225
226 #endif /* !CONFIG_IS_ENABLED(GENERATE_ACPI_TABLE) */
227
228 /**
229  * efi_install_fdt() - install device tree
230  *
231  * If fdt is not EFI_FDT_USE_INTERNAL, the device tree located at that memory
232  * address will will be installed as configuration table, otherwise the device
233  * tree located at the address indicated by environment variable fdt_addr or as
234  * fallback fdtcontroladdr will be used.
235  *
236  * On architectures using ACPI tables device trees shall not be installed as
237  * configuration table.
238  *
239  * @fdt:        address of device tree or EFI_FDT_USE_INTERNAL to use the
240  *              the hardware device tree as indicated by environment variable
241  *              fdt_addr or as fallback the internal device tree as indicated by
242  *              the environment variable fdtcontroladdr
243  * Return:      status code
244  */
245 efi_status_t efi_install_fdt(void *fdt)
246 {
247         /*
248          * The EBBR spec requires that we have either an FDT or an ACPI table
249          * but not both.
250          */
251 #if CONFIG_IS_ENABLED(GENERATE_ACPI_TABLE)
252         if (fdt) {
253                 printf("ERROR: can't have ACPI table and device tree.\n");
254                 return EFI_LOAD_ERROR;
255         }
256 #else
257         bootm_headers_t img = { 0 };
258         efi_status_t ret;
259
260         if (fdt == EFI_FDT_USE_INTERNAL) {
261                 const char *fdt_opt;
262                 uintptr_t fdt_addr;
263
264                 /* Look for device tree that is already installed */
265                 if (get_config_table(&efi_guid_fdt))
266                         return EFI_SUCCESS;
267                 /* Check if there is a hardware device tree */
268                 fdt_opt = env_get("fdt_addr");
269                 /* Use our own device tree as fallback */
270                 if (!fdt_opt) {
271                         fdt_opt = env_get("fdtcontroladdr");
272                         if (!fdt_opt) {
273                                 printf("ERROR: need device tree\n");
274                                 return EFI_NOT_FOUND;
275                         }
276                 }
277                 fdt_addr = simple_strtoul(fdt_opt, NULL, 16);
278                 if (!fdt_addr) {
279                         printf("ERROR: invalid $fdt_addr or $fdtcontroladdr\n");
280                         return EFI_LOAD_ERROR;
281                 }
282                 fdt = map_sysmem(fdt_addr, 0);
283         }
284
285         /* Install device tree */
286         if (fdt_check_header(fdt)) {
287                 printf("ERROR: invalid device tree\n");
288                 return EFI_LOAD_ERROR;
289         }
290
291         /* Prepare device tree for payload */
292         ret = copy_fdt(&fdt);
293         if (ret) {
294                 printf("ERROR: out of memory\n");
295                 return EFI_OUT_OF_RESOURCES;
296         }
297
298         if (image_setup_libfdt(&img, fdt, 0, NULL)) {
299                 printf("ERROR: failed to process device tree\n");
300                 return EFI_LOAD_ERROR;
301         }
302
303         /* Create memory reservations as indicated by the device tree */
304         efi_carve_out_dt_rsv(fdt);
305
306         /* Install device tree as UEFI table */
307         ret = efi_install_configuration_table(&efi_guid_fdt, fdt);
308         if (ret != EFI_SUCCESS) {
309                 printf("ERROR: failed to install device tree\n");
310                 return ret;
311         }
312 #endif /* GENERATE_ACPI_TABLE */
313
314         return EFI_SUCCESS;
315 }
316
317 /**
318  * do_bootefi_exec() - execute EFI binary
319  *
320  * @handle:             handle of loaded image
321  * Return:              status code
322  *
323  * Load the EFI binary into a newly assigned memory unwinding the relocation
324  * information, install the loaded image protocol, and call the binary.
325  */
326 static efi_status_t do_bootefi_exec(efi_handle_t handle)
327 {
328         efi_status_t ret;
329         efi_uintn_t exit_data_size = 0;
330         u16 *exit_data = NULL;
331         u16 *load_options;
332
333         /* Transfer environment variable as load options */
334         ret = set_load_options(handle, "bootargs", &load_options);
335         if (ret != EFI_SUCCESS)
336                 return ret;
337
338         /* Call our payload! */
339         ret = EFI_CALL(efi_start_image(handle, &exit_data_size, &exit_data));
340         printf("## Application terminated, r = %lu\n", ret & ~EFI_ERROR_MASK);
341         if (ret && exit_data) {
342                 printf("## %ls\n", exit_data);
343                 efi_free_pool(exit_data);
344         }
345
346         efi_restore_gd();
347
348         free(load_options);
349
350         return ret;
351 }
352
353 /**
354  * do_efibootmgr() - execute EFI boot manager
355  *
356  * Return:      status code
357  */
358 static int do_efibootmgr(void)
359 {
360         efi_handle_t handle;
361         efi_status_t ret;
362
363         ret = efi_bootmgr_load(&handle);
364         if (ret != EFI_SUCCESS) {
365                 printf("EFI boot manager: Cannot load any image\n");
366                 return CMD_RET_FAILURE;
367         }
368
369         ret = do_bootefi_exec(handle);
370
371         if (ret != EFI_SUCCESS)
372                 return CMD_RET_FAILURE;
373
374         return CMD_RET_SUCCESS;
375 }
376
377 /**
378  * do_bootefi_image() - execute EFI binary
379  *
380  * Set up memory image for the binary to be loaded, prepare device path, and
381  * then call do_bootefi_exec() to execute it.
382  *
383  * @image_opt:  string of image start address
384  * Return:      status code
385  */
386 static int do_bootefi_image(const char *image_opt)
387 {
388         void *image_buf;
389         unsigned long addr, size;
390         const char *size_str;
391         efi_status_t ret;
392
393 #ifdef CONFIG_CMD_BOOTEFI_HELLO
394         if (!strcmp(image_opt, "hello")) {
395                 char *saddr;
396
397                 saddr = env_get("loadaddr");
398                 size = __efi_helloworld_end - __efi_helloworld_begin;
399
400                 if (saddr)
401                         addr = simple_strtoul(saddr, NULL, 16);
402                 else
403                         addr = CONFIG_SYS_LOAD_ADDR;
404
405                 image_buf = map_sysmem(addr, size);
406                 memcpy(image_buf, __efi_helloworld_begin, size);
407
408                 efi_free_pool(bootefi_device_path);
409                 efi_free_pool(bootefi_image_path);
410                 bootefi_device_path = NULL;
411                 bootefi_image_path = NULL;
412         } else
413 #endif
414         {
415                 size_str = env_get("filesize");
416                 if (size_str)
417                         size = simple_strtoul(size_str, NULL, 16);
418                 else
419                         size = 0;
420
421                 addr = simple_strtoul(image_opt, NULL, 16);
422                 /* Check that a numeric value was passed */
423                 if (!addr && *image_opt != '0')
424                         return CMD_RET_USAGE;
425
426                 image_buf = map_sysmem(addr, size);
427         }
428         ret = efi_run_image(image_buf, size);
429
430         if (ret != EFI_SUCCESS)
431                 return CMD_RET_FAILURE;
432
433         return CMD_RET_SUCCESS;
434 }
435
436 /**
437  * efi_run_image() - run loaded UEFI image
438  *
439  * @source_buffer:      memory address of the UEFI image
440  * @source_size:        size of the UEFI image
441  * Return:              status code
442  */
443 efi_status_t efi_run_image(void *source_buffer, efi_uintn_t source_size)
444 {
445         efi_handle_t mem_handle = NULL, handle;
446         struct efi_device_path *file_path = NULL;
447         efi_status_t ret;
448
449         if (!bootefi_device_path || !bootefi_image_path) {
450                 /*
451                  * Special case for efi payload not loaded from disk,
452                  * such as 'bootefi hello' or for example payload
453                  * loaded directly into memory via JTAG, etc:
454                  */
455                 file_path = efi_dp_from_mem(EFI_RESERVED_MEMORY_TYPE,
456                                             (uintptr_t)source_buffer,
457                                             source_size);
458                 /*
459                  * Make sure that device for device_path exist
460                  * in load_image(). Otherwise, shell and grub will fail.
461                  */
462                 ret = efi_create_handle(&mem_handle);
463                 if (ret != EFI_SUCCESS)
464                         goto out;
465
466                 ret = efi_add_protocol(mem_handle, &efi_guid_device_path,
467                                        file_path);
468                 if (ret != EFI_SUCCESS)
469                         goto out;
470         } else {
471                 file_path = efi_dp_append(bootefi_device_path,
472                                           bootefi_image_path);
473         }
474
475         ret = EFI_CALL(efi_load_image(false, efi_root, file_path, source_buffer,
476                                       source_size, &handle));
477         if (ret != EFI_SUCCESS)
478                 goto out;
479
480         ret = do_bootefi_exec(handle);
481
482 out:
483         if (mem_handle)
484                 efi_delete_handle(mem_handle);
485         if (file_path)
486                 efi_free_pool(file_path);
487         return ret;
488 }
489
490 #ifdef CONFIG_CMD_BOOTEFI_SELFTEST
491 static efi_status_t bootefi_run_prepare(const char *load_options_path,
492                 struct efi_device_path *device_path,
493                 struct efi_device_path *image_path,
494                 struct efi_loaded_image_obj **image_objp,
495                 struct efi_loaded_image **loaded_image_infop)
496 {
497         efi_status_t ret;
498         u16 *load_options;
499
500         ret = efi_setup_loaded_image(device_path, image_path, image_objp,
501                                      loaded_image_infop);
502         if (ret != EFI_SUCCESS)
503                 return ret;
504
505         /* Transfer environment variable as load options */
506         return set_load_options((efi_handle_t)*image_objp, load_options_path,
507                                 &load_options);
508 }
509
510 /**
511  * bootefi_test_prepare() - prepare to run an EFI test
512  *
513  * Prepare to run a test as if it were provided by a loaded image.
514  *
515  * @image_objp:         pointer to be set to the loaded image handle
516  * @loaded_image_infop: pointer to be set to the loaded image protocol
517  * @path:               dummy file path used to construct the device path
518  *                      set in the loaded image protocol
519  * @load_options_path:  name of a U-Boot environment variable. Its value is
520  *                      set as load options in the loaded image protocol.
521  * Return:              status code
522  */
523 static efi_status_t bootefi_test_prepare
524                 (struct efi_loaded_image_obj **image_objp,
525                  struct efi_loaded_image **loaded_image_infop, const char *path,
526                  const char *load_options_path)
527 {
528         efi_status_t ret;
529
530         /* Construct a dummy device path */
531         bootefi_device_path = efi_dp_from_mem(EFI_RESERVED_MEMORY_TYPE, 0, 0);
532         if (!bootefi_device_path)
533                 return EFI_OUT_OF_RESOURCES;
534
535         bootefi_image_path = efi_dp_from_file(NULL, 0, path);
536         if (!bootefi_image_path) {
537                 ret = EFI_OUT_OF_RESOURCES;
538                 goto failure;
539         }
540
541         ret = bootefi_run_prepare(load_options_path, bootefi_device_path,
542                                   bootefi_image_path, image_objp,
543                                   loaded_image_infop);
544         if (ret == EFI_SUCCESS)
545                 return ret;
546
547         efi_free_pool(bootefi_image_path);
548         bootefi_image_path = NULL;
549 failure:
550         efi_free_pool(bootefi_device_path);
551         bootefi_device_path = NULL;
552         return ret;
553 }
554
555 /**
556  * bootefi_run_finish() - finish up after running an EFI test
557  *
558  * @loaded_image_info: Pointer to a struct which holds the loaded image info
559  * @image_obj: Pointer to a struct which holds the loaded image object
560  */
561 static void bootefi_run_finish(struct efi_loaded_image_obj *image_obj,
562                                struct efi_loaded_image *loaded_image_info)
563 {
564         efi_restore_gd();
565         free(loaded_image_info->load_options);
566         efi_delete_handle(&image_obj->header);
567 }
568
569 /**
570  * do_efi_selftest() - execute EFI selftest
571  *
572  * Return:      status code
573  */
574 static int do_efi_selftest(void)
575 {
576         struct efi_loaded_image_obj *image_obj;
577         struct efi_loaded_image *loaded_image_info;
578         efi_status_t ret;
579
580         ret = bootefi_test_prepare(&image_obj, &loaded_image_info,
581                                    "\\selftest", "efi_selftest");
582         if (ret != EFI_SUCCESS)
583                 return CMD_RET_FAILURE;
584
585         /* Execute the test */
586         ret = EFI_CALL(efi_selftest(&image_obj->header, &systab));
587         bootefi_run_finish(image_obj, loaded_image_info);
588
589         return ret != EFI_SUCCESS;
590 }
591 #endif /* CONFIG_CMD_BOOTEFI_SELFTEST */
592
593 /**
594  * do_bootefi() - execute `bootefi` command
595  *
596  * @cmdtp:      table entry describing command
597  * @flag:       bitmap indicating how the command was invoked
598  * @argc:       number of arguments
599  * @argv:       command line arguments
600  * Return:      status code
601  */
602 static int do_bootefi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
603 {
604         efi_status_t ret;
605         void *fdt;
606
607         if (argc < 2)
608                 return CMD_RET_USAGE;
609
610         /* Initialize EFI drivers */
611         ret = efi_init_obj_list();
612         if (ret != EFI_SUCCESS) {
613                 printf("Error: Cannot initialize UEFI sub-system, r = %lu\n",
614                        ret & ~EFI_ERROR_MASK);
615                 return CMD_RET_FAILURE;
616         }
617
618         if (argc > 2) {
619                 uintptr_t fdt_addr;
620
621                 fdt_addr = simple_strtoul(argv[2], NULL, 16);
622                 fdt = map_sysmem(fdt_addr, 0);
623         } else {
624                 fdt = EFI_FDT_USE_INTERNAL;
625         }
626         ret = efi_install_fdt(fdt);
627         if (ret == EFI_INVALID_PARAMETER)
628                 return CMD_RET_USAGE;
629         else if (ret != EFI_SUCCESS)
630                 return CMD_RET_FAILURE;
631
632         if (!strcmp(argv[1], "bootmgr"))
633                 return do_efibootmgr();
634 #ifdef CONFIG_CMD_BOOTEFI_SELFTEST
635         else if (!strcmp(argv[1], "selftest"))
636                 return do_efi_selftest();
637 #endif
638
639         return do_bootefi_image(argv[1]);
640 }
641
642 #ifdef CONFIG_SYS_LONGHELP
643 static char bootefi_help_text[] =
644         "<image address> [fdt address]\n"
645         "  - boot EFI payload stored at address <image address>.\n"
646         "    If specified, the device tree located at <fdt address> gets\n"
647         "    exposed as EFI configuration table.\n"
648 #ifdef CONFIG_CMD_BOOTEFI_HELLO
649         "bootefi hello\n"
650         "  - boot a sample Hello World application stored within U-Boot\n"
651 #endif
652 #ifdef CONFIG_CMD_BOOTEFI_SELFTEST
653         "bootefi selftest [fdt address]\n"
654         "  - boot an EFI selftest application stored within U-Boot\n"
655         "    Use environment variable efi_selftest to select a single test.\n"
656         "    Use 'setenv efi_selftest list' to enumerate all tests.\n"
657 #endif
658         "bootefi bootmgr [fdt address]\n"
659         "  - load and boot EFI payload based on BootOrder/BootXXXX variables.\n"
660         "\n"
661         "    If specified, the device tree located at <fdt address> gets\n"
662         "    exposed as EFI configuration table.\n";
663 #endif
664
665 U_BOOT_CMD(
666         bootefi, 3, 0, do_bootefi,
667         "Boots an EFI payload from memory",
668         bootefi_help_text
669 );
670
671 /**
672  * efi_set_bootdev() - set boot device
673  *
674  * This function is called when a file is loaded, e.g. via the 'load' command.
675  * We use the path to this file to inform the UEFI binary about the boot device.
676  *
677  * @dev:        device, e.g. "MMC"
678  * @devnr:      number of the device, e.g. "1:2"
679  * @path:       path to file loaded
680  */
681 void efi_set_bootdev(const char *dev, const char *devnr, const char *path)
682 {
683         struct efi_device_path *device, *image;
684         efi_status_t ret;
685
686         /* efi_set_bootdev is typically called repeatedly, recover memory */
687         efi_free_pool(bootefi_device_path);
688         efi_free_pool(bootefi_image_path);
689
690         ret = efi_dp_from_name(dev, devnr, path, &device, &image);
691         if (ret == EFI_SUCCESS) {
692                 bootefi_device_path = device;
693                 if (image) {
694                         /* FIXME: image should not contain device */
695                         struct efi_device_path *image_tmp = image;
696
697                         efi_dp_split_file_path(image, &device, &image);
698                         efi_free_pool(image_tmp);
699                 }
700                 bootefi_image_path = image;
701         } else {
702                 bootefi_device_path = NULL;
703                 bootefi_image_path = NULL;
704         }
705 }