libopkg: store checksums in binary form, use integer index for architecture
[oweals/opkg-lede.git] / libopkg / pkg_hash.c
1 /* opkg_hash.c - the opkg package management system
2
3    Steven M. Ayer
4
5    Copyright (C) 2002 Compaq Computer Corporation
6
7    This program is free software; you can redistribute it and/or
8    modify it under the terms of the GNU General Public License as
9    published by the Free Software Foundation; either version 2, or (at
10    your option) any later version.
11
12    This program is distributed in the hope that it will be useful, but
13    WITHOUT ANY WARRANTY; without even the implied warranty of
14    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
15    General Public License for more details.
16 */
17
18 #include <stdio.h>
19
20 #include "hash_table.h"
21 #include "pkg.h"
22 #include "opkg_message.h"
23 #include "pkg_vec.h"
24 #include "pkg_hash.h"
25 #include "parse_util.h"
26 #include "pkg_parse.h"
27 #include "opkg_utils.h"
28 #include "sprintf_alloc.h"
29 #include "file_util.h"
30 #include "libbb/libbb.h"
31 #include "libbb/gzip.h"
32
33 void pkg_hash_init(void)
34 {
35         hash_table_init("pkg-hash", &conf->pkg_hash,
36                         OPKG_CONF_DEFAULT_HASH_LEN);
37 }
38
39 static void free_pkgs(const char *key, void *entry, void *data)
40 {
41         int i;
42         abstract_pkg_t *ab_pkg;
43
44         /* Each entry in the hash table is an abstract package, which contains
45          * a list of packages that provide the abstract package.
46          */
47
48         ab_pkg = (abstract_pkg_t *) entry;
49
50         if (ab_pkg->pkgs) {
51                 for (i = 0; i < ab_pkg->pkgs->len; i++) {
52                         pkg_deinit(ab_pkg->pkgs->pkgs[i]);
53                         free(ab_pkg->pkgs->pkgs[i]);
54                 }
55         }
56
57         abstract_pkg_vec_free(ab_pkg->provided_by);
58         abstract_pkg_vec_free(ab_pkg->replaced_by);
59         pkg_vec_free(ab_pkg->pkgs);
60         free(ab_pkg->depended_upon_by);
61         free(ab_pkg->name);
62         free(ab_pkg);
63 }
64
65 void pkg_hash_deinit(void)
66 {
67         hash_table_foreach(&conf->pkg_hash, free_pkgs, NULL);
68         hash_table_deinit(&conf->pkg_hash);
69 }
70
71 int dist_hash_add_from_file(const char *lists_dir, pkg_src_t * dist)
72 {
73         nv_pair_list_elt_t *l;
74         char *list_file, *subname;
75
76         list_for_each_entry(l, &conf->arch_list.head, node) {
77                 nv_pair_t *nv = (nv_pair_t *) l->data;
78                 sprintf_alloc(&subname, "%s-%s", dist->name, nv->name);
79                 sprintf_alloc(&list_file, "%s/%s", lists_dir, subname);
80
81                 if (file_exists(list_file)) {
82                         if (pkg_hash_add_from_file(list_file, dist, NULL, 0)) {
83                                 free(list_file);
84                                 return -1;
85                         }
86                         pkg_src_list_append(&conf->pkg_src_list, subname,
87                                             dist->value, "__dummy__", 0);
88                 }
89
90                 free(list_file);
91         }
92
93         return 0;
94 }
95
96 int
97 pkg_hash_add_from_file(const char *file_name,
98                        pkg_src_t * src, pkg_dest_t * dest, int is_status_file)
99 {
100         pkg_t *pkg;
101         FILE *fp;
102         char *buf;
103         const size_t len = 4096;
104         int ret = 0;
105         struct gzip_handle zh;
106
107         if (src && src->gzip) {
108                 fp = gzip_fdopen(&zh, file_name);
109         } else {
110                 fp = fopen(file_name, "r");
111         }
112
113         if (fp == NULL) {
114                 opkg_perror(ERROR, "Failed to open %s", file_name);
115                 return -1;
116         }
117
118         buf = xmalloc(len);
119
120         do {
121                 pkg = pkg_new();
122                 pkg->src = src;
123                 pkg->dest = dest;
124
125                 ret = parse_from_stream_nomalloc(pkg_parse_line, pkg, fp, 0,
126                                                  &buf, len);
127
128                 if (pkg->name == NULL) {
129                         /* probably just a blank line */
130                         ret = 1;
131                 }
132
133                 if (ret) {
134                         pkg_deinit(pkg);
135                         free(pkg);
136                         if (ret == -1)
137                                 break;
138                         if (ret == 1)
139                                 /* Probably a blank line, continue parsing. */
140                                 ret = 0;
141                         continue;
142                 }
143
144                 if (!pkg_get_architecture(pkg) || !pkg_get_arch_priority(pkg)) {
145                         char *version_str = pkg_version_str_alloc(pkg);
146                         opkg_msg(NOTICE, "Package %s version %s has no "
147                                  "valid architecture, ignoring.\n",
148                                  pkg->name, version_str);
149                         free(version_str);
150                         continue;
151                 }
152
153                 hash_insert_pkg(pkg, is_status_file);
154
155         } while (!feof(fp));
156
157         free(buf);
158         fclose(fp);
159
160         if (src && src->gzip)
161                 gzip_close(&zh);
162
163         return ret;
164 }
165
166 /*
167  * Load in feed files from the cached "src" and/or "src/gz" locations.
168  */
169 int pkg_hash_load_feeds(void)
170 {
171         pkg_src_list_elt_t *iter;
172         pkg_src_t *src, *subdist;
173         char *list_file, *lists_dir;
174
175         opkg_msg(INFO, "\n");
176
177         lists_dir = conf->restrict_to_default_dest ?
178             conf->default_dest->lists_dir : conf->lists_dir;
179
180         for (iter = void_list_first(&conf->pkg_src_list); iter;
181              iter = void_list_next(&conf->pkg_src_list, iter)) {
182
183                 src = (pkg_src_t *) iter->data;
184
185                 sprintf_alloc(&list_file, "%s/%s", lists_dir, src->name);
186
187                 if (file_exists(list_file)) {
188                         if (pkg_hash_add_from_file(list_file, src, NULL, 0)) {
189                                 free(list_file);
190                                 return -1;
191                         }
192                 }
193                 free(list_file);
194         }
195
196         return 0;
197 }
198
199 /*
200  * Load in status files from the configured "dest"s.
201  */
202 int pkg_hash_load_status_files(void)
203 {
204         pkg_dest_list_elt_t *iter;
205         pkg_dest_t *dest;
206
207         opkg_msg(INFO, "\n");
208
209         for (iter = void_list_first(&conf->pkg_dest_list); iter;
210              iter = void_list_next(&conf->pkg_dest_list, iter)) {
211
212                 dest = (pkg_dest_t *) iter->data;
213
214                 if (file_exists(dest->status_file_name)) {
215                         if (pkg_hash_add_from_file
216                             (dest->status_file_name, NULL, dest, 1))
217                                 return -1;
218                 }
219         }
220
221         return 0;
222 }
223
224 static abstract_pkg_t *abstract_pkg_fetch_by_name(const char *pkg_name)
225 {
226         return (abstract_pkg_t *) hash_table_get(&conf->pkg_hash, pkg_name);
227 }
228
229 pkg_t *pkg_hash_fetch_best_installation_candidate(abstract_pkg_t * apkg,
230                                                   int (*constraint_fcn) (pkg_t *
231                                                                          pkg,
232                                                                          void
233                                                                          *cdata),
234                                                   void *cdata, int quiet)
235 {
236         int i, j;
237         int nprovides = 0;
238         int nmatching = 0;
239         int wrong_arch_found = 0;
240         int arch_priority;
241         pkg_vec_t *matching_pkgs;
242         abstract_pkg_vec_t *matching_apkgs;
243         abstract_pkg_vec_t *provided_apkg_vec;
244         abstract_pkg_t **provided_apkgs;
245         abstract_pkg_vec_t *providers;
246         pkg_t *latest_installed_parent = NULL;
247         pkg_t *latest_matching = NULL;
248         pkg_t *priorized_matching = NULL;
249         pkg_t *held_pkg = NULL;
250         pkg_t *good_pkg_by_name = NULL;
251
252         if (apkg == NULL || apkg->provided_by == NULL
253             || (apkg->provided_by->len == 0))
254                 return NULL;
255
256         matching_pkgs = pkg_vec_alloc();
257         matching_apkgs = abstract_pkg_vec_alloc();
258         providers = abstract_pkg_vec_alloc();
259
260         opkg_msg(DEBUG, "Best installation candidate for %s:\n", apkg->name);
261
262         provided_apkg_vec = apkg->provided_by;
263         nprovides = provided_apkg_vec->len;
264         provided_apkgs = provided_apkg_vec->pkgs;
265         if (nprovides > 1)
266                 opkg_msg(DEBUG, "apkg=%s nprovides=%d.\n", apkg->name,
267                          nprovides);
268
269         /* accumulate all the providers */
270         for (i = 0; i < nprovides; i++) {
271                 abstract_pkg_t *provider_apkg = provided_apkgs[i];
272                 opkg_msg(DEBUG, "Adding %s to providers.\n",
273                          provider_apkg->name);
274                 abstract_pkg_vec_insert(providers, provider_apkg);
275         }
276         nprovides = providers->len;
277
278         for (i = 0; i < nprovides; i++) {
279                 abstract_pkg_t *provider_apkg =
280                     abstract_pkg_vec_get(providers, i);
281                 abstract_pkg_t *replacement_apkg = NULL;
282                 pkg_vec_t *vec;
283
284                 if (provider_apkg->replaced_by
285                     && provider_apkg->replaced_by->len) {
286                         replacement_apkg = provider_apkg->replaced_by->pkgs[0];
287                         if (provider_apkg->replaced_by->len > 1) {
288                                 opkg_msg(NOTICE, "Multiple replacers for %s, "
289                                          "using first one (%s).\n",
290                                          provider_apkg->name,
291                                          replacement_apkg->name);
292                         }
293                 }
294
295                 if (replacement_apkg)
296                         opkg_msg(DEBUG,
297                                  "replacement_apkg=%s for provider_apkg=%s.\n",
298                                  replacement_apkg->name, provider_apkg->name);
299
300                 if (replacement_apkg && (replacement_apkg != provider_apkg)) {
301                         if (abstract_pkg_vec_contains
302                             (providers, replacement_apkg))
303                                 continue;
304                         else
305                                 provider_apkg = replacement_apkg;
306                 }
307
308                 if (!(vec = provider_apkg->pkgs)) {
309                         opkg_msg(DEBUG, "No pkgs for provider_apkg %s.\n",
310                                  provider_apkg->name);
311                         continue;
312                 }
313
314                 /* now check for supported architecture */
315                 {
316                         int max_count = 0;
317
318                         /* count packages matching max arch priority and keep track of last one */
319                         for (j = 0; j < vec->len; j++) {
320                                 pkg_t *maybe = vec->pkgs[j];
321                                 arch_priority = pkg_get_arch_priority(maybe);
322
323                                 opkg_msg(DEBUG,
324                                          "%s arch=%s arch_priority=%d version=%s.\n",
325                                          maybe->name, pkg_get_architecture(maybe),
326                                          arch_priority, pkg_get_string(maybe, PKG_VERSION));
327                                 /* We make sure not to add the same package twice. Need to search for the reason why
328                                    they show up twice sometimes. */
329                                 if ((arch_priority > 0)
330                                     &&
331                                     (!pkg_vec_contains(matching_pkgs, maybe))) {
332                                         max_count++;
333                                         abstract_pkg_vec_insert(matching_apkgs,
334                                                                 maybe->parent);
335                                         pkg_vec_insert(matching_pkgs, maybe);
336                                 }
337                         }
338
339                         if (vec->len > 0 && matching_pkgs->len < 1)
340                                 wrong_arch_found = 1;
341                 }
342         }
343
344         if (matching_pkgs->len < 1) {
345                 if (wrong_arch_found)
346                         opkg_msg(ERROR, "Packages for %s found, but"
347                                  " incompatible with the architectures configured\n",
348                                  apkg->name);
349                 pkg_vec_free(matching_pkgs);
350                 abstract_pkg_vec_free(matching_apkgs);
351                 abstract_pkg_vec_free(providers);
352                 return NULL;
353         }
354
355         if (matching_pkgs->len > 1)
356                 pkg_vec_sort(matching_pkgs,
357                              pkg_name_version_and_architecture_compare);
358         if (matching_apkgs->len > 1)
359                 abstract_pkg_vec_sort(matching_pkgs, abstract_pkg_name_compare);
360
361         for (i = 0; i < matching_pkgs->len; i++) {
362                 pkg_t *matching = matching_pkgs->pkgs[i];
363                 if (constraint_fcn(matching, cdata)) {
364                         opkg_msg(DEBUG, "Candidate: %s %s.\n",
365                                  matching->name, pkg_get_string(matching, PKG_VERSION));
366                         good_pkg_by_name = matching;
367                         /* It has been provided by hand, so it is what user want */
368                         if (matching->provided_by_hand == 1)
369                                 break;
370                 }
371         }
372
373         for (i = 0; i < matching_pkgs->len; i++) {
374                 pkg_t *matching = matching_pkgs->pkgs[i];
375                 latest_matching = matching;
376                 if (matching->parent->state_status == SS_INSTALLED
377                     || matching->parent->state_status == SS_UNPACKED)
378                         latest_installed_parent = matching;
379                 if (matching->state_flag & (SF_HOLD | SF_PREFER)) {
380                         if (held_pkg)
381                                 opkg_msg(NOTICE,
382                                          "Multiple packages (%s and %s) providing"
383                                          " same name marked HOLD or PREFER. "
384                                          "Using latest.\n", held_pkg->name,
385                                          matching->name);
386                         held_pkg = matching;
387                 }
388         }
389
390         if (!good_pkg_by_name && !held_pkg && !latest_installed_parent
391             && matching_apkgs->len > 1 && !quiet) {
392                 int prio = 0;
393                 for (i = 0; i < matching_pkgs->len; i++) {
394                         pkg_t *matching = matching_pkgs->pkgs[i];
395                         arch_priority = pkg_get_arch_priority(matching);
396                         if (arch_priority > prio) {
397                                 priorized_matching = matching;
398                                 prio = arch_priority;
399                                 opkg_msg(DEBUG, "Match %s with priority %i.\n",
400                                          matching->name, prio);
401                         }
402                 }
403
404         }
405
406         if (conf->verbosity >= INFO && matching_apkgs->len > 1) {
407                 opkg_msg(INFO, "%d matching pkgs for apkg=%s:\n",
408                          matching_pkgs->len, apkg->name);
409                 for (i = 0; i < matching_pkgs->len; i++) {
410                         pkg_t *matching = matching_pkgs->pkgs[i];
411                         opkg_msg(INFO, "%s %s %s\n",
412                                  matching->name, pkg_get_string(matching, PKG_VERSION),
413                                  pkg_get_architecture(matching));
414                 }
415         }
416
417         nmatching = matching_apkgs->len;
418
419         pkg_vec_free(matching_pkgs);
420         abstract_pkg_vec_free(matching_apkgs);
421         abstract_pkg_vec_free(providers);
422
423         if (good_pkg_by_name) { /* We found a good candidate, we will install it */
424                 return good_pkg_by_name;
425         }
426         if (held_pkg) {
427                 opkg_msg(INFO, "Using held package %s.\n", held_pkg->name);
428                 return held_pkg;
429         }
430         if (latest_installed_parent) {
431                 opkg_msg(INFO,
432                          "Using latest version of installed package %s.\n",
433                          latest_installed_parent->name);
434                 return latest_installed_parent;
435         }
436         if (priorized_matching) {
437                 opkg_msg(INFO, "Using priorized matching %s %s %s.\n",
438                          priorized_matching->name, pkg_get_string(priorized_matching, PKG_VERSION),
439                          pkg_get_architecture(priorized_matching));
440                 return priorized_matching;
441         }
442         if (nmatching > 1) {
443                 opkg_msg(INFO, "No matching pkg out of %d matching_apkgs.\n",
444                          nmatching);
445                 return NULL;
446         }
447         if (latest_matching) {
448                 opkg_msg(INFO, "Using latest matching %s %s %s.\n",
449                          latest_matching->name, pkg_get_string(latest_matching, PKG_VERSION),
450                          pkg_get_architecture(latest_matching));
451                 return latest_matching;
452         }
453         return NULL;
454 }
455
456 static int pkg_name_constraint_fcn(pkg_t * pkg, void *cdata)
457 {
458         const char *name = (const char *)cdata;
459
460         if (strcmp(pkg->name, name) == 0)
461                 return 1;
462         else
463                 return 0;
464 }
465
466 static pkg_vec_t *pkg_vec_fetch_by_name(const char *pkg_name)
467 {
468         abstract_pkg_t *ab_pkg;
469
470         if (!(ab_pkg = abstract_pkg_fetch_by_name(pkg_name)))
471                 return NULL;
472
473         if (ab_pkg->pkgs)
474                 return ab_pkg->pkgs;
475
476         if (ab_pkg->provided_by) {
477                 abstract_pkg_t *abpkg =
478                     abstract_pkg_vec_get(ab_pkg->provided_by, 0);
479                 if (abpkg != NULL)
480                         return abpkg->pkgs;
481                 else
482                         return ab_pkg->pkgs;
483         }
484
485         return NULL;
486 }
487
488 pkg_t *pkg_hash_fetch_best_installation_candidate_by_name(const char *name)
489 {
490         abstract_pkg_t *apkg = NULL;
491
492         if (!(apkg = abstract_pkg_fetch_by_name(name)))
493                 return NULL;
494
495         return pkg_hash_fetch_best_installation_candidate(apkg,
496                                                           pkg_name_constraint_fcn,
497                                                           apkg->name, 0);
498 }
499
500 pkg_t *pkg_hash_fetch_by_name_version(const char *pkg_name, const char *version)
501 {
502         pkg_vec_t *vec;
503         int i;
504         char *version_str = NULL;
505
506         if (!(vec = pkg_vec_fetch_by_name(pkg_name)))
507                 return NULL;
508
509         for (i = 0; i < vec->len; i++) {
510                 version_str = pkg_version_str_alloc(vec->pkgs[i]);
511                 if (!strcmp(version_str, version)) {
512                         free(version_str);
513                         break;
514                 }
515                 free(version_str);
516         }
517
518         if (i == vec->len)
519                 return NULL;
520
521         return vec->pkgs[i];
522 }
523
524 pkg_t *pkg_hash_fetch_installed_by_name_dest(const char *pkg_name,
525                                              pkg_dest_t * dest)
526 {
527         pkg_vec_t *vec;
528         int i;
529
530         if (!(vec = pkg_vec_fetch_by_name(pkg_name))) {
531                 return NULL;
532         }
533
534         for (i = 0; i < vec->len; i++)
535                 if ((vec->pkgs[i]->state_status == SS_INSTALLED
536                      || vec->pkgs[i]->state_status == SS_UNPACKED)
537                     && vec->pkgs[i]->dest == dest) {
538                         return vec->pkgs[i];
539                 }
540
541         return NULL;
542 }
543
544 pkg_t *pkg_hash_fetch_installed_by_name(const char *pkg_name)
545 {
546         pkg_vec_t *vec;
547         int i;
548
549         if (!(vec = pkg_vec_fetch_by_name(pkg_name))) {
550                 return NULL;
551         }
552
553         for (i = 0; i < vec->len; i++) {
554                 if (vec->pkgs[i]->state_status == SS_INSTALLED
555                     || vec->pkgs[i]->state_status == SS_UNPACKED) {
556                         return vec->pkgs[i];
557                 }
558         }
559
560         return NULL;
561 }
562
563 static void
564 pkg_hash_fetch_available_helper(const char *pkg_name, void *entry, void *data)
565 {
566         int j;
567         abstract_pkg_t *ab_pkg = (abstract_pkg_t *) entry;
568         pkg_vec_t *all = (pkg_vec_t *) data;
569         pkg_vec_t *pkg_vec = ab_pkg->pkgs;
570
571         if (!pkg_vec)
572                 return;
573
574         for (j = 0; j < pkg_vec->len; j++) {
575                 pkg_t *pkg = pkg_vec->pkgs[j];
576                 pkg_vec_insert(all, pkg);
577         }
578 }
579
580 void pkg_hash_fetch_available(pkg_vec_t * all)
581 {
582         hash_table_foreach(&conf->pkg_hash, pkg_hash_fetch_available_helper,
583                            all);
584 }
585
586 static void
587 pkg_hash_fetch_all_installed_helper(const char *pkg_name, void *entry,
588                                     void *data)
589 {
590         abstract_pkg_t *ab_pkg = (abstract_pkg_t *) entry;
591         pkg_vec_t *all = (pkg_vec_t *) data;
592         pkg_vec_t *pkg_vec = ab_pkg->pkgs;
593         int j;
594
595         if (!pkg_vec)
596                 return;
597
598         for (j = 0; j < pkg_vec->len; j++) {
599                 pkg_t *pkg = pkg_vec->pkgs[j];
600                 if (pkg->state_status == SS_INSTALLED
601                     || pkg->state_status == SS_UNPACKED)
602                         pkg_vec_insert(all, pkg);
603         }
604 }
605
606 void pkg_hash_fetch_all_installed(pkg_vec_t * all)
607 {
608         hash_table_foreach(&conf->pkg_hash, pkg_hash_fetch_all_installed_helper,
609                            all);
610 }
611
612 /*
613  * This assumes that the abstract pkg doesn't exist.
614  */
615 static abstract_pkg_t *add_new_abstract_pkg_by_name(const char *pkg_name)
616 {
617         abstract_pkg_t *ab_pkg;
618
619         ab_pkg = abstract_pkg_new();
620
621         ab_pkg->name = xstrdup(pkg_name);
622         hash_table_insert(&conf->pkg_hash, pkg_name, ab_pkg);
623
624         return ab_pkg;
625 }
626
627 abstract_pkg_t *ensure_abstract_pkg_by_name(const char *pkg_name)
628 {
629         abstract_pkg_t *ab_pkg;
630
631         if (!(ab_pkg = abstract_pkg_fetch_by_name(pkg_name)))
632                 ab_pkg = add_new_abstract_pkg_by_name(pkg_name);
633
634         return ab_pkg;
635 }
636
637 void hash_insert_pkg(pkg_t * pkg, int set_status)
638 {
639         abstract_pkg_t *ab_pkg;
640
641         ab_pkg = ensure_abstract_pkg_by_name(pkg->name);
642         if (!ab_pkg->pkgs)
643                 ab_pkg->pkgs = pkg_vec_alloc();
644
645         if (pkg->state_status == SS_INSTALLED) {
646                 ab_pkg->state_status = SS_INSTALLED;
647         } else if (pkg->state_status == SS_UNPACKED) {
648                 ab_pkg->state_status = SS_UNPACKED;
649         }
650
651         buildDepends(pkg);
652
653         buildProvides(ab_pkg, pkg);
654
655         init_providelist(pkg, NULL);
656
657         /* Need to build the conflicts graph before replaces for correct
658          * calculation of replaced_by relation.
659          */
660         buildConflicts(pkg);
661
662         buildReplaces(ab_pkg, pkg);
663
664         buildDependedUponBy(pkg, ab_pkg);
665
666         pkg_vec_insert_merge(ab_pkg->pkgs, pkg, set_status);
667         pkg->parent = ab_pkg;
668 }
669
670 static const char *strip_offline_root(const char *file_name)
671 {
672         unsigned int len;
673
674         if (conf->offline_root) {
675                 len = strlen(conf->offline_root);
676                 if (strncmp(file_name, conf->offline_root, len) == 0)
677                         file_name += len;
678         }
679
680         return file_name;
681 }
682
683 void file_hash_remove(const char *file_name)
684 {
685         file_name = strip_offline_root(file_name);
686         hash_table_remove(&conf->file_hash, file_name);
687 }
688
689 pkg_t *file_hash_get_file_owner(const char *file_name)
690 {
691         file_name = strip_offline_root(file_name);
692         return hash_table_get(&conf->file_hash, file_name);
693 }
694
695 void file_hash_set_file_owner(const char *file_name, pkg_t * owning_pkg)
696 {
697         pkg_t *old_owning_pkg;
698         int file_name_len = strlen(file_name);
699
700         if (file_name[file_name_len - 1] == '/')
701                 return;
702
703         file_name = strip_offline_root(file_name);
704
705         old_owning_pkg = hash_table_get(&conf->file_hash, file_name);
706         hash_table_insert(&conf->file_hash, file_name, owning_pkg);
707
708         if (old_owning_pkg) {
709                 pkg_get_installed_files(old_owning_pkg);
710                 str_list_remove_elt(old_owning_pkg->installed_files, file_name);
711                 pkg_free_installed_files(old_owning_pkg);
712
713                 /* mark this package to have its filelist written */
714                 old_owning_pkg->state_flag |= SF_FILELIST_CHANGED;
715                 owning_pkg->state_flag |= SF_FILELIST_CHANGED;
716         }
717 }