oxnas: fix warning in SATA driver
authorDaniel Golle <daniel@makrotopia.org>
Tue, 31 Mar 2020 19:27:11 +0000 (20:27 +0100)
committerDaniel Golle <daniel@makrotopia.org>
Tue, 31 Mar 2020 20:30:57 +0000 (21:30 +0100)
drivers/ata/sata_oxnas.c: In function 'sata_oxnas_port_irq':
drivers/ata/sata_oxnas.c:2126:25: warning: left shift count >= width of type [-Wshift-count-overflow]
  if (ap->qc_active & (1 << ATA_TAG_INTERNAL)) {
                           ^~

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
target/linux/oxnas/files/drivers/ata/sata_oxnas.c

index 64afa728a18c3ab0b804791ccfeca280585e552b..6e0f7a72a6d5611672704cd0998d846f2d59f0f4 100644 (file)
@@ -2123,7 +2123,7 @@ static void sata_oxnas_port_irq(struct ata_port *ap, int force_error)
        DPRINTK("ENTER port %d irqstatus %x\n", ap->port_no,
                ioread32(port_base + INT_STATUS));
 
-       if (ap->qc_active & (1 << ATA_TAG_INTERNAL)) {
+       if (ap->qc_active & (1ULL << ATA_TAG_INTERNAL)) {
                        qc = ata_qc_from_tag(ap, ATA_TAG_INTERNAL);
                        DPRINTK("completing non-ncq cmd\n");