remove hack in syslog.h that resulted in aliasing violations
authorRich Felker <dalias@aerifal.cx>
Sat, 21 Jun 2014 11:44:46 +0000 (07:44 -0400)
committerRich Felker <dalias@aerifal.cx>
Sat, 21 Jun 2014 11:44:46 +0000 (07:44 -0400)
commit70d9c303b3115ab0fe6060ba0f7b0e4c0a2320b7
tree80a4c81b8a938dea0919152156d363a072b33ed5
parent4ad3588c0eedba8165e377da0ff8d331aa901b94
remove hack in syslog.h that resulted in aliasing violations

this issue affected the prioritynames and facilitynames arrays which
are only provided when requested (usually by syslogd implementations)
and which are presently defined as compound literals. the aliasing
violation seems to have been introduced as a workaround for bad
behavior by gcc's -Wwrite-strings option, but it caused compilers to
completely optimize out the contents of prioritynames and
facilitynames since, under many usage cases, the aliasing rules prove
that the contents are never accessed.
include/syslog.h