remove hack in syslog.h that resulted in aliasing violations
authorRich Felker <dalias@aerifal.cx>
Sat, 21 Jun 2014 11:44:46 +0000 (07:44 -0400)
committerRich Felker <dalias@aerifal.cx>
Mon, 28 Jul 2014 04:27:58 +0000 (00:27 -0400)
commit37eb19e0908697e8ef810cf350a52d2009959f1a
tree6de80c0952f7e4caf68dc15494364b9de5bdec7a
parentc65dbec736419d706a2d3a0070ab3bedb0151f4a
remove hack in syslog.h that resulted in aliasing violations

this issue affected the prioritynames and facilitynames arrays which
are only provided when requested (usually by syslogd implementations)
and which are presently defined as compound literals. the aliasing
violation seems to have been introduced as a workaround for bad
behavior by gcc's -Wwrite-strings option, but it caused compilers to
completely optimize out the contents of prioritynames and
facilitynames since, under many usage cases, the aliasing rules prove
that the contents are never accessed.

(cherry picked from commit 70d9c303b3115ab0fe6060ba0f7b0e4c0a2320b7)
include/syslog.h