DEFAULTSERVICES is dead, remove remains

diff --git a/contrib/experiments/nse/infiniband.conf b/contrib/experiments/nse/infiniband.conf
index 1720e0131216f71dc5b281c29cd125d3a4946305..e42baba95cf237d1d08087c83822388c2c4352fd 100644 (file)
--- a/contrib/experiments/nse/infiniband.conf
+++ b/contrib/experiments/nse/infiniband.conf
@@ -26,7 +26,6 @@ WORKBITS = 0
 PROOFFILE = $SERVICEHOME/nse.proof
 
 [arm]
-DEFAULTSERVICES = core nse
 UNIXPATH = /tmp/test-nse-service-arm.unix
 
 [statistics]

diff --git a/contrib/testbed_configs/regex_profiler_infiniband.conf b/contrib/testbed_configs/regex_profiler_infiniband.conf
index e4d6138cac052de007909fa0f2b128e0d6a33fcb..20642301186b0a2d708c1493814e384f3c6b3015 100644 (file)
--- a/contrib/testbed_configs/regex_profiler_infiniband.conf
+++ b/contrib/testbed_configs/regex_profiler_infiniband.conf
@@ -40,9 +40,6 @@ DISABLE_BF = YES
 # Keep datacache in-memory? (reduces IO)
 IN_MEMORY = YES
 
-[arm]
-DEFAULTSERVICES = core cadet dht statistics regexprofiler
-
 [fs]
 AUTOSTART = NO
 

diff --git a/contrib/testbed_configs/testbed_cluster.conf b/contrib/testbed_configs/testbed_cluster.conf
index d55761f1080ec7a5bd0231f330ad3f0b1b32256c..6d646a0ce90a36007525008cc882d0dbdd66870e 100644 (file)
--- a/contrib/testbed_configs/testbed_cluster.conf
+++ b/contrib/testbed_configs/testbed_cluster.conf
@@ -46,7 +46,6 @@ AUTOSTART = YES
 USE_EPHEMERAL_KEYS = NO
 
 [arm]
-DEFAULTSERVICES = core transport
 #PORT = 12366
 DEBUG = NO
 

diff --git a/contrib/testbed_configs/testbed_infiniband.conf b/contrib/testbed_configs/testbed_infiniband.conf
index aea11a18eaf1ab483163e7b64e7cd062a5784d71..7ad50d77aed1d25b36166800b9333262bd18f87f 100644 (file)
--- a/contrib/testbed_configs/testbed_infiniband.conf
+++ b/contrib/testbed_configs/testbed_infiniband.conf
@@ -46,7 +46,6 @@ AUTOSTART = YES
 USE_EPHEMERAL_KEYS = NO
 
 [arm]
-DEFAULTSERVICES = core
 #PORT = 12366
 DEBUG = NO
 

diff --git a/contrib/testbed_configs/testbed_supermuc.conf b/contrib/testbed_configs/testbed_supermuc.conf
index 02d64d62f06c0685078841c37379f239f2d92db1..35c6e07898f05de3234f82a77013663b40c850e5 100644 (file)
--- a/contrib/testbed_configs/testbed_supermuc.conf
+++ b/contrib/testbed_configs/testbed_supermuc.conf
@@ -49,7 +49,6 @@ AUTOSTART = YES
 USE_EPHEMERAL_KEYS = NO
 
 [arm]
-DEFAULTSERVICES = transport core ats
 #PORT = 12366
 DEBUG = NO
 #PREFIX = strace -r -T -o /${WORK}/trace/${PEERID}.strace

diff --git a/doc/man/gnunet.conf.5 b/doc/man/gnunet.conf.5
index d668c81faaa9eaf7364106806993c712f20c0a8a..2ef88c11e09c989e47065d04c1be93de7c888f21 100644 (file)
--- a/doc/man/gnunet.conf.5
+++ b/doc/man/gnunet.conf.5
@@ -75,15 +75,16 @@ This example is a simple way to get started, using a server that has a known lis
     OPTIONS = \-b
     SERVERS = http://v9.gnunet.org:58080/
 
-    [arm]
-    DEFAULTSERVICES = topology hostlist fs
-
     [nat]
     BEHIND_NAT = YES
     ENABLE_UPNP = YES
     DISABLEV6 = YES
     EXTERNAL_ADDRESS = 157.166.249.10
 
+    [arm]
+    SYSTEM_ONLY = YES
+    USER_ONLY = NO
+
 .SH FILES
 .TP
 ~/.config/gnunet.conf

diff --git a/src/arm/arm.conf.in b/src/arm/arm.conf.in
index 53731586b05df323283d0b46626ffe83491b491d..20d3e1dc0bb9ae7fef67d9a2dbfbebe190d28d2c 100644 (file)
--- a/src/arm/arm.conf.in
+++ b/src/arm/arm.conf.in
@@ -5,9 +5,6 @@ BINARY = gnunet-service-arm
 ACCEPT_FROM = 127.0.0.1;
 ACCEPT_FROM6 = ::1;
 
-
-DEFAULTSERVICES = topology hostlist dht nse cadet fs revocation
-
 # Special case, uses user runtime dir even for per-system service.
 UNIXPATH = $GNUNET_USER_RUNTIME_DIR/gnunet-service-arm.sock
 UNIX_MATCH_UID = YES

diff --git a/src/include/gnunet_crypto_lib.h b/src/include/gnunet_crypto_lib.h
index 38a3ab3b630205f63b6fa4c8ce47141510bb9e27..eb28b8ffddee765fa3a0d188b58e998c538925a7 100644 (file)
--- a/src/include/gnunet_crypto_lib.h
+++ b/src/include/gnunet_crypto_lib.h
@@ -1752,6 +1752,16 @@ GNUNET_CRYPTO_rsa_public_key_hash (const struct GNUNET_CRYPTO_rsa_PublicKey *key
                                    struct GNUNET_HashCode *hc);
 
 
+/**
+ * Obtain the length of the RSA key in bits.
+ *
+ * @param key the public key to introspect
+ * @return length of the key in bits
+ */
+unsigned int
+GNUNET_CRYPTO_rsa_public_key_len (const struct GNUNET_CRYPTO_rsa_PublicKey *key);
+
+
 /**
  * Free memory occupied by the public key.
  *

diff --git a/src/rps/Makefile.am b/src/rps/Makefile.am
index 09369dc732d66fde8840becb984cf64cbb56bbbe..b1fd3d47b841e0dacf49007590c3eb88038d0e50 100644 (file)
--- a/src/rps/Makefile.am
+++ b/src/rps/Makefile.am
@@ -112,4 +112,3 @@ gnunet_rps_profiler_LDADD = $(ld_rps_test_lib)
 
 EXTRA_DIST = \
   test_rps.conf
-

diff --git a/src/testbed/test_testbed_underlay.conf.in b/src/testbed/test_testbed_underlay.conf.in
index 4da34b89bc5c122aeed945c4f13997ef5512890c..5799b52533c7080115d46ac74a7379f6988d33f9 100644 (file)
--- a/src/testbed/test_testbed_underlay.conf.in
+++ b/src/testbed/test_testbed_underlay.conf.in
@@ -11,6 +11,3 @@ FORCESTART = YES
 
 [dv]
 AUTOSTART = NO
-
-[arm]
-DEFAULTSERVICES = core transport testbed-underlay

diff --git a/src/util/crypto_rsa.c b/src/util/crypto_rsa.c
index d1ca760cfa84d775c27c1e10dfc7d9da97b9c24a..58503b73414f5b77726a1b5891694d16bc758814 100644 (file)
--- a/src/util/crypto_rsa.c
+++ b/src/util/crypto_rsa.c
@@ -526,6 +526,32 @@ GNUNET_CRYPTO_rsa_private_key_cmp (struct GNUNET_CRYPTO_rsa_PrivateKey *p1,
 }
 
 
+/**
+ * Obtain the length of the RSA key in bits.
+ *
+ * @param key the public key to introspect
+ * @return length of the key in bits
+ */
+unsigned int
+GNUNET_CRYPTO_rsa_public_key_len (const struct GNUNET_CRYPTO_rsa_PublicKey *key)
+{
+  gcry_mpi_t n;
+  int ret;
+  unsigned int rval;
+
+  ret = key_from_sexp (&n, key->sexp, "rsa", "n");
+  if (0 != ret)
+  {
+    /* this is no public RSA key */
+    GNUNET_break (0);
+    return 0;
+  }
+  rval = gcry_mpi_get_nbits (n);
+  gcry_mpi_release (n);
+  return rval;
+}
+
+
 /**
  * Destroy a blinding key
  *
@@ -549,7 +575,7 @@ GNUNET_CRYPTO_rsa_blinding_key_free (struct GNUNET_CRYPTO_rsa_BlindingKey *bkey)
  */
 size_t
 GNUNET_CRYPTO_rsa_blinding_key_encode (const struct GNUNET_CRYPTO_rsa_BlindingKey *bkey,
-                               char **buffer)
+                                       char **buffer)
 {
   size_t n;
   char *b;

diff --git a/src/util/os_network.c b/src/util/os_network.c
index 715fe5bd60e65292dcc7fe429f5b6a3147e471b0..19b60b6b489eca55840c96556d3fdeea656dc55e 100644 (file)
--- a/src/util/os_network.c
+++ b/src/util/os_network.c
@@ -18,7 +18,6 @@
      Boston, MA 02110-1301, USA.
 
 */
-
 /**
  * @file util/os_network.c
  * @brief function to determine available network interfaces
@@ -38,7 +37,7 @@
  * @brief Enumerate all network interfaces
  *
  * @param proc the callback function
- * @param proc_cls closure for proc
+ * @param proc_cls closure for @a proc
  */
 void
 GNUNET_OS_network_interfaces_list (GNUNET_OS_NetworkInterfaceProcessor proc,