Rich Felker [Wed, 3 Aug 2011 01:15:20 +0000 (21:15 -0400)]
fix sem_timedwait bug introduced in timedwait unification
this dec used to be performed by the cancellation handler, which was
called when popped.
Rich Felker [Wed, 3 Aug 2011 01:11:36 +0000 (21:11 -0400)]
unify and overhaul timed futex waits
new features:
- FUTEX_WAIT_BITSET op will be used for timed waits if available. this
saves a call to clock_gettime.
- error checking for the timespec struct is now inside __timedwait so
it doesn't need to be duplicated everywhere. cond_timedwait still
needs to duplicate it to avoid unlocking the mutex, though.
- pushing and popping the cancellation handler is delegated to
__timedwait, and cancellable/non-cancellable waits are unified.
Rich Felker [Wed, 3 Aug 2011 00:31:15 +0000 (20:31 -0400)]
avoid accessing mutex memory after atomic unlock
this change is needed to fix a race condition and ensure that it's
possible to unlock and destroy or unmap the mutex as soon as
pthread_mutex_lock succeeds. POSIX explicitly gives such an example in
the rationale and requires an implementation to allow such usage.
Rich Felker [Tue, 2 Aug 2011 23:59:56 +0000 (19:59 -0400)]
fix breakage in cancellation due to signal functions overhaul
sigaddset was not accepting SIGCANCEL as a valid signal number.
Rich Felker [Tue, 2 Aug 2011 23:19:09 +0000 (19:19 -0400)]
overhaul posix semaphores to fix destructability race
the race condition these changes address is described in glibc bug
report number 12674:
http://sourceware.org/bugzilla/show_bug.cgi?id=12674
up until now, musl has shared the bug, and i had not been able to
figure out how to eliminate it. in short, the problem is that it's not
valid for sem_post to inspect the waiters count after incrementing the
semaphore value, because another thread may have already successfully
returned from sem_wait, (rightly) deemed itself the only remaining
user of the semaphore, and chosen to destroy and free it (or unmap the
shared memory it's stored in). POSIX is not explicit in blessing this
usage, but it gives a very explicit analogous example with mutexes
(which, in musl and glibc, also suffer from the same race condition
bug) in the rationale for pthread_mutex_destroy.
the new semaphore implementation augments the waiter count with a
redundant waiter indication in the semaphore value itself,
representing the presence of "last minute" waiters that may have
arrived after sem_post read the waiter count. this allows sem_post to
read the waiter count prior to incrementing the semaphore value,
rather than after incrementing it, so as to avoid accessing the
semaphore memory whatsoever after the increment takes place.
a similar, but much simpler, fix should be possible for mutexes and
other locking primitives whose usage rules are stricter than
semaphores.
Rich Felker [Mon, 1 Aug 2011 04:31:15 +0000 (00:31 -0400)]
fix wrong messages in gai_strerror
i had missed the fact that a couple values were unassigned...
Rich Felker [Mon, 1 Aug 2011 04:11:25 +0000 (00:11 -0400)]
port numbers should always be interpreted as decimal
per POSIX and RFC 3493:
If the specified address family is AF_INET, AF_INET6, or AF_UNSPEC,
the service can be specified as a string specifying a decimal port
number.
021 is a valid decimal number, therefore, interpreting it as octal
seems to be non-conformant.
Rich Felker [Mon, 1 Aug 2011 04:03:50 +0000 (00:03 -0400)]
fix crash in dns code with new stdio locking code
Rich Felker [Sun, 31 Jul 2011 04:10:29 +0000 (00:10 -0400)]
consistency: use struct __ucontext instead of ucontext_t in prototypes
this is necessary to avoid build errors if feature test macros are not
properly defined when including ucontext.h
Rich Felker [Sun, 31 Jul 2011 01:11:31 +0000 (21:11 -0400)]
fix race condition in sigqueue
this race is fundamentally due to linux's bogus requirement that
userspace, rather than kernelspace, fill in the siginfo structure. an
intervening signal handler that calls fork could cause both the parent
and child process to send signals claiming to be from the parent,
which could in turn have harmful effects depending on what the
recipient does with the signal. we simply block all signals for the
interval between getuid and sigqueue syscalls (much like what raise()
does already) to prevent the race and make the getuid/sigqueue pair
atomic.
this will be a non-issue if linux is fixed to validate the siginfo
structure or fill it in from kernelspace.
Rich Felker [Sun, 31 Jul 2011 01:09:14 +0000 (21:09 -0400)]
clean up pthread_sigmask/sigprocmask dependency order
it's nicer for the function that doesn't use errno to be independent,
and have the other one call it. saves some time and avoids clobbering
errno.
Rich Felker [Sat, 30 Jul 2011 12:19:31 +0000 (08:19 -0400)]
fix some bugs in setxid and update setrlimit to use __synccall
setrlimit is supposed to be per-process, not per-thread, but again
linux gets it wrong. work around this in userspace. not only is it
needed for correctness; setxid also depends on the resource limits for
all threads being the same to avoid situations where temporarily
unlimiting the limit succeeds in some threads but fails in others.
Rich Felker [Sat, 30 Jul 2011 12:02:14 +0000 (08:02 -0400)]
add proper fuxed-based locking for stdio
previously, stdio used spinlocks, which would be unacceptable if we
ever add support for thread priorities, and which yielded
pathologically bad performance if an application attempted to use
flockfile on a key file as a major/primary locking mechanism.
i had held off on making this change for fear that it would hurt
performance in the non-threaded case, but actually support for
recursive locking had already inflicted that cost. by having the
internal locking functions store a flag indicating whether they need
to perform unlocking, rather than using the actual recursive lock
counter, i was able to combine the conditionals at unlock time,
eliminating any additional cost, and also avoid a nasty corner case
where a huge number of calls to ftrylockfile could cause deadlock
later at the point of internal locking.
this commit also fixes some issues with usage of pthread_self
conflicting with __attribute__((const)) which resulted in crashes with
some compiler versions/optimizations, mainly in flockfile prior to
pthread_create.
Rich Felker [Sat, 30 Jul 2011 10:11:16 +0000 (06:11 -0400)]
eliminate dependence of perror on printf
Rich Felker [Sat, 30 Jul 2011 04:24:26 +0000 (00:24 -0400)]
fix bug in synccall with no threads: lock was taken but never released
Rich Felker [Sat, 30 Jul 2011 03:10:07 +0000 (23:10 -0400)]
add setxid.c for new set*id() framework. missed in last commit.
Rich Felker [Sat, 30 Jul 2011 02:59:44 +0000 (22:59 -0400)]
new attempt at making set*id() safe and robust
changing credentials in a multi-threaded program is extremely
difficult on linux because it requires synchronizing the change
between all threads, which have their own thread-local credentials on
the kernel side. this is further complicated by the fact that changing
the real uid can fail due to exceeding RLIMIT_NPROC, making it
possible that the syscall will succeed in some threads but fail in
others.
the old __rsyscall approach being replaced was robust in that it would
report failure if any one thread failed, but in this case, the program
would be left in an inconsistent state where individual threads might
have different uid. (this was not as bad as glibc, which would
sometimes even fail to report the failure entirely!)
the new approach being committed refuses to change real user id when
it cannot temporarily set the rlimit to infinity. this is completely
POSIX conformant since POSIX does not require an implementation to
allow real-user-id changes for non-privileged processes whatsoever.
still, setting the real uid can fail due to memory allocation in the
kernel, but this can only happen if there is not already a cached
object for the target user. thus, we forcibly serialize the syscalls
attempts, and fail the entire operation on the first failure. this
*should* lead to an all-or-nothing success/failure result, but it's
still fragile and highly dependent on kernel developers not breaking
things worse than they're already broken.
ideally linux will eventually add a CLONE_USERCRED flag that would
give POSIX conformant credential changes without any hacks from
userspace, and all of this code would become redundant and could be
removed ~10 years down the line when everyone has abandoned the old
broken kernels. i'm not holding my breath...
Rich Felker [Fri, 29 Jul 2011 02:03:54 +0000 (22:03 -0400)]
remove ugly prng from mk*temp and just re-poll time on retry
Rich Felker [Fri, 29 Jul 2011 01:48:53 +0000 (21:48 -0400)]
eliminate mk*temp dependency on snprintf
this helps some tiny programs be even more tiny, and barly increases
code size even if both are used.
Rich Felker [Fri, 29 Jul 2011 00:43:40 +0000 (20:43 -0400)]
fix for setenv bogus var argument handling
thanks to mikachu
per POSIX:
The setenv() function shall fail if:
[EINVAL] The name argument is a null pointer, points to an empty
string, or points to a string containing an '=' character.
Rich Felker [Mon, 25 Jul 2011 13:22:05 +0000 (09:22 -0400)]
when resolving symbols with only weak defs, use first def, not last def
Rich Felker [Mon, 25 Jul 2011 13:21:40 +0000 (09:21 -0400)]
comment non-obvious de bruijn sequence code in int parser
Rich Felker [Sun, 24 Jul 2011 06:19:47 +0000 (02:19 -0400)]
fix resolution of weak symbols (hopefully right now) and vdso
Rich Felker [Sun, 24 Jul 2011 05:10:01 +0000 (01:10 -0400)]
workaround for gcc's optimizer breaking dynamic symbol resolution
Rich Felker [Sun, 24 Jul 2011 04:54:55 +0000 (00:54 -0400)]
load vdso, if present, into the dso list
Rich Felker [Sun, 24 Jul 2011 04:54:36 +0000 (00:54 -0400)]
const correctness on function pointer
Rich Felker [Sun, 24 Jul 2011 04:26:12 +0000 (00:26 -0400)]
simplify dynamic linker startup
instead of creating temp dso objects on the stack and moving them to
the heap if dlopen/dlsym are used, use static objects to begin with,
and just donate them to malloc if we no longer need them.
Rich Felker [Sun, 24 Jul 2011 03:45:33 +0000 (23:45 -0400)]
some preliminaries for vdso clock support
these changes also make it so clock_gettime(CLOCK_REALTIME, &ts) works
even on pre-2.6 kernels, emulated via the gettimeofday syscall. there
is no cost for the fallback check, as it falls under the error case
that already must be checked for storing the error code in errno, but
which would normally be hidden inside __syscall_ret.
Rich Felker [Fri, 22 Jul 2011 04:25:56 +0000 (00:25 -0400)]
check for fd exhaustion in forkpty
we cannot report failure after forking, so the idea is to ensure prior
to fork that fd 0,1,2 exist. this will prevent dup2 from possibly
hitting a resource limit and failing in the child process. fcntl
rather than dup2 is used prior to forking to avoid race conditions.
Rich Felker [Fri, 22 Jul 2011 04:23:36 +0000 (00:23 -0400)]
incorrect check for open failure in openpty function
-1, not 0, indicates failure
Rich Felker [Fri, 22 Jul 2011 02:44:05 +0000 (22:44 -0400)]
socket headers macro adjustment - workaround for buggy programs
some program was undefining AF_NETLINK and thereby breaking AF_ROUTE...
Rich Felker [Fri, 22 Jul 2011 01:15:14 +0000 (21:15 -0400)]
fix errno value when fdopendir is given an invalid file descriptor
this resolves an issue reported by Vasiliy Kulikov
Rich Felker [Sun, 17 Jul 2011 03:17:17 +0000 (23:17 -0400)]
ensure in fork that child gets its own new robust mutex list
Rich Felker [Sun, 17 Jul 2011 01:24:02 +0000 (21:24 -0400)]
fix logic error in fread
fread was calling f->read without checking that the file was in
reading mode. this could:
1. crash, if f->read was a null pointer
2. cause unwanted blocking on a terminal already at eof
3. allow reading on a write-only file
Rich Felker [Fri, 15 Jul 2011 02:11:00 +0000 (22:11 -0400)]
fix various bugs in new integer parser framework
1. my interpretation of subject sequence definition was wrong. adjust
parser to conform to the standard.
2. some code for handling tail overflow case was missing (forgot to
finish writing it).
3. typo (= instead of ==) caused ERANGE to wrongly behave like EINVAL
Rich Felker [Thu, 14 Jul 2011 05:12:05 +0000 (01:12 -0400)]
fix wcsto[iu]max with high characters
stopping without letting the parser see a stop character prevented
getting a result. so treat all high chars as the null character and
pass them into the parser.
also eliminated ugly tmp var using compound literals.
Rich Felker [Thu, 14 Jul 2011 04:51:45 +0000 (00:51 -0400)]
new restartable integer parsing framework.
this fixes a number of bugs in integer parsing due to lazy haphazard
wrapping, as well as some misinterpretations of the standard. the new
parser is able to work character-at-a-time or on whole strings, making
it easy to support the wide functions without unbounded space for
conversion. it will also be possible to update scanf to use the new
parser.
Rich Felker [Wed, 13 Jul 2011 00:30:04 +0000 (20:30 -0400)]
gb18030 support in iconv (only from, not to)
also support (and restrict to subsets) older chinese sets, and
explicitly refuse to convert to cjk (since there's no code for it yet)
Rich Felker [Tue, 12 Jul 2011 06:52:06 +0000 (02:52 -0400)]
"implement" getnetbyaddr and getnetbyname
these are useless legacy functions but some old software contains
cruft that expects them to exist...
Rich Felker [Tue, 12 Jul 2011 06:43:24 +0000 (02:43 -0400)]
legacy japanese charset support in iconv (only from, not to)
Rich Felker [Tue, 12 Jul 2011 04:31:39 +0000 (00:31 -0400)]
simplify iconv and support more legacy codepages
Rich Felker [Sat, 9 Jul 2011 22:06:59 +0000 (18:06 -0400)]
add missing signalfd flags
Rich Felker [Mon, 4 Jul 2011 15:55:52 +0000 (11:55 -0400)]
printf: "if a precision is specified, the '0' flag shall be ignored."
Rich Felker [Mon, 4 Jul 2011 05:57:00 +0000 (01:57 -0400)]
zero precision with zero value should not inhibit prefix/width printing
Rich Felker [Mon, 4 Jul 2011 05:01:58 +0000 (01:01 -0400)]
printf("%#x",0) should print 0 not 0x0
Rich Felker [Sun, 3 Jul 2011 23:26:12 +0000 (19:26 -0400)]
iconv was not returning -1 on most failure
this broke most uses of iconv in real-world programs, especially
glib's iconv wrappers.
Rich Felker [Sun, 3 Jul 2011 20:41:20 +0000 (16:41 -0400)]
0.7.12 release notes
Rich Felker [Sat, 2 Jul 2011 02:40:00 +0000 (22:40 -0400)]
fix dlopen UB due to longjmp/volatile rules violation
Rich Felker [Fri, 1 Jul 2011 03:12:07 +0000 (23:12 -0400)]
res_search symbol, aliased to res_query for now (better than nothing)
Rich Felker [Fri, 1 Jul 2011 03:02:27 +0000 (23:02 -0400)]
simple rpath support (no token expansion yet) for dynamic linker
Rich Felker [Fri, 1 Jul 2011 00:23:24 +0000 (20:23 -0400)]
fill in junk in stropts.h
STREAMS are utterly useless as far as I can tell, but some software
was apparently broken by the presence of stropts.h but lack of macros
it's supposed to define...
Rich Felker [Thu, 30 Jun 2011 20:37:51 +0000 (16:37 -0400)]
fix error in previous ld80 fpclassify commit
Rich Felker [Thu, 30 Jun 2011 20:31:43 +0000 (16:31 -0400)]
catch invalid ld80 bit patterns and treat them as nan
this should not be necessary - the invalid bit patterns cannot be
created except through type punning. however, some broken gnu software
is passing them to printf and triggering dangerous stack-smashing, so
let's catch them anyway...
Rich Felker [Thu, 30 Jun 2011 17:27:08 +0000 (13:27 -0400)]
fix logic in __fwriting
Rich Felker [Thu, 30 Jun 2011 16:44:48 +0000 (12:44 -0400)]
add and consolidate nasty stdio_ext junk
hopefully this resolves the rest of the issues with hideously
nonportable hacks in programs that use gnulib.
Rich Felker [Thu, 30 Jun 2011 15:42:33 +0000 (11:42 -0400)]
implement the nonstandard GNU function fpurge
this is a really ugly and backwards function, but its presence will
prevent lots of broken gnulib software from trying to define its own
version of fpurge and thereby failing to build or worse.
Rich Felker [Thu, 30 Jun 2011 12:11:06 +0000 (08:11 -0400)]
fix buffer overrun in getgrent code when there are no group members
Rich Felker [Wed, 29 Jun 2011 23:26:30 +0000 (19:26 -0400)]
posix_memalign should fail if size is not a multiple of sizeof(void *)
Rich Felker [Wed, 29 Jun 2011 21:13:01 +0000 (17:13 -0400)]
avoid errors in ucontext.h when no feature test macros are defined
Rich Felker [Wed, 29 Jun 2011 19:29:52 +0000 (15:29 -0400)]
locking support for random() prng
these interfaces are required to be thread-safe even though they are
not state-free. the random number sequence is shared across all
threads.
Rich Felker [Wed, 29 Jun 2011 04:42:42 +0000 (00:42 -0400)]
work around linux bug in mprotect
per POSIX: The mprotect() function shall change the access protections
to be that specified by prot for those whole pages containing any part
of the address space of the process starting at address addr and
continuing for len bytes.
on the other hand, linux mprotect fails with EINVAL if the base
address and/or length is not page-aligned, so we have to align them
before making the syscall.
Rich Felker [Wed, 29 Jun 2011 04:29:08 +0000 (00:29 -0400)]
textrel support, cheap and ugly
Rich Felker [Wed, 29 Jun 2011 02:06:58 +0000 (22:06 -0400)]
release notes for 0.7.11
Rich Felker [Tue, 28 Jun 2011 23:40:14 +0000 (19:40 -0400)]
reclaim the memory wasted by dynamic linking for use by malloc
Rich Felker [Tue, 28 Jun 2011 18:41:41 +0000 (14:41 -0400)]
use type directives for fenv asm functions
Rich Felker [Tue, 28 Jun 2011 18:20:41 +0000 (14:20 -0400)]
use load address from elf header if possible
this is mostly useless for shared libs (though it could help for
prelink-like purposes); the intended use case is for adding support
for calling the dynamic linker directly to run a program, as in:
./libc.so ./a.out foo
this usage is not yet supported.
Rich Felker [Tue, 28 Jun 2011 18:13:51 +0000 (14:13 -0400)]
make dynamic linker relocate the main program image last, after all libs
prior to this change, copy relocations for initialized pointer
variables would not reflect the relocated contents of the pointer.
Rich Felker [Tue, 28 Jun 2011 12:27:38 +0000 (08:27 -0400)]
fix a few bugs from last dynamic linking build system commit
some cruft was left and DESTDIR was not being used correctly.
Rich Felker [Tue, 28 Jun 2011 02:34:47 +0000 (22:34 -0400)]
minor updates to INSTALL documentation
Rich Felker [Tue, 28 Jun 2011 01:38:11 +0000 (21:38 -0400)]
cleanup shared library build system to be more $HOME-local-install friendly
the path for the dynamic linker is now configurable, and failure to
install the symlink for it will not stop the build.
Rich Felker [Mon, 27 Jun 2011 05:02:28 +0000 (01:02 -0400)]
further fixup dlfcn.h
Rich Felker [Mon, 27 Jun 2011 05:01:19 +0000 (01:01 -0400)]
match LSB/glibc constants for dynamic loader
Rich Felker [Mon, 27 Jun 2011 02:39:34 +0000 (22:39 -0400)]
fix stale pointer issue in dynamic linker with dlopen
Rich Felker [Mon, 27 Jun 2011 02:09:32 +0000 (22:09 -0400)]
don't leave the lock held on dlopen failure..
Rich Felker [Mon, 27 Jun 2011 01:50:01 +0000 (21:50 -0400)]
add RTLD_DEFAULT support
Rich Felker [Mon, 27 Jun 2011 01:36:44 +0000 (21:36 -0400)]
in dlopen: don't use null pointer
deps can be null if a library has no dependencies (such as libc itself)
Rich Felker [Mon, 27 Jun 2011 01:21:04 +0000 (21:21 -0400)]
fix resolving symbols in objects loaded in RTLD_LOCAL mode
basically we temporarily make the library and all its dependencies
part of the global namespace but only for the duration of performing
relocations, then return them to their former state.
Rich Felker [Sun, 26 Jun 2011 23:23:28 +0000 (19:23 -0400)]
experimental dlopen/dlsym and dynlink changes needed to support them
Rich Felker [Sun, 26 Jun 2011 21:41:34 +0000 (17:41 -0400)]
type directives for x86_64 math asm
Rich Felker [Sun, 26 Jun 2011 21:39:17 +0000 (17:39 -0400)]
error handling in dynamic linking
some of the code is not yet used, and is in preparation for dlopen
which needs to be able to handle failure loading libraries without
terminating the program.
Rich Felker [Sun, 26 Jun 2011 20:34:05 +0000 (16:34 -0400)]
fix useless use of potentially-uninitialized mode variable in sem_open
Rich Felker [Sun, 26 Jun 2011 20:12:43 +0000 (16:12 -0400)]
eliminate OOB array hacks in malloc
Rich Felker [Sun, 26 Jun 2011 19:52:37 +0000 (15:52 -0400)]
use .type directives for math asm (needed for dynamic linking to work)
Rich Felker [Sun, 26 Jun 2011 02:36:21 +0000 (22:36 -0400)]
fix some symbol resolution issues in dynamic linker
1. search was wrongly beginning with lib itself rather than dso head
2. inconsistent resolution of function pointers for functions in plt
Rich Felker [Sat, 25 Jun 2011 22:57:17 +0000 (18:57 -0400)]
fix dynamic linker issue in musl-gcc wrapper
Rich Felker [Sat, 25 Jun 2011 22:54:33 +0000 (18:54 -0400)]
wordexp cannot use we_offs unless WRDE_DOOFFS flag is set
previously, a potentially-indeterminate value from we_offs was being
used, resulting in wrong we_wordc and subsequent crashes in the
caller.
Rich Felker [Sat, 25 Jun 2011 22:18:57 +0000 (18:18 -0400)]
XSI search.h API implementation by Szabolcs Nagy
Rich Felker [Sat, 25 Jun 2011 21:49:16 +0000 (17:49 -0400)]
handle library paths better (ignore empty path components, etc.)
Rich Felker [Sat, 25 Jun 2011 19:38:00 +0000 (15:38 -0400)]
move all limits that don't vary out of bits/limits.h, into main limits.h
Rich Felker [Sat, 25 Jun 2011 16:26:08 +0000 (12:26 -0400)]
fix possible (questionable) strict aliasing violations and ptr arith
Rich Felker [Sat, 25 Jun 2011 13:23:36 +0000 (09:23 -0400)]
const correctness in mq_notify
why did gcc allow this invalid assignment to compile in the first place?
Rich Felker [Sat, 25 Jun 2011 05:56:34 +0000 (01:56 -0400)]
proper path searching for dynamic linker
first, use $LD_LIBRARY_PATH unless suid. if that fails, read path from
/etc/ld-musl-$ARCH.path and fallback to a builtin default.
Rich Felker [Sat, 25 Jun 2011 05:38:25 +0000 (01:38 -0400)]
optimize opendir using O_CLOEXEC
Rich Felker [Sat, 25 Jun 2011 04:47:28 +0000 (00:47 -0400)]
discard dso descriptors after performing relocations
eventually (once dlopen exists) this behavior will be conditional on
dlopen/dlsym not being reachable.
Rich Felker [Sat, 25 Jun 2011 04:18:19 +0000 (00:18 -0400)]
keep track of which dsos have been relocated
Rich Felker [Fri, 24 Jun 2011 22:32:30 +0000 (18:32 -0400)]
use soname in ld-musl.so to prevent filename appearing in DT_NEEDEDs
Rich Felker [Fri, 24 Jun 2011 18:02:47 +0000 (14:02 -0400)]
use symlink rather than bogus linker script for libc.so
the linker script caused a bogus DT_NEEDED entry
Rich Felker [Fri, 24 Jun 2011 02:13:47 +0000 (22:13 -0400)]
adapt build/install/gcc-wrapper systems for dynamic linking support
Rich Felker [Fri, 24 Jun 2011 02:04:06 +0000 (22:04 -0400)]
prepare support for LD_LIBRARY_PATH (checking suid/sgid safety)
the use of this test will be much stricter than glibc and other
typical implementations; the environment will not be honored
whatsoever unless the program is confirmed non-suid/sgid by the aux
vector the kernel passed in. no fallback to slow syscall-based
checking is used if the kernel fails to provide the information; we
simply assume the worst (suid) in this case and refuse to honor
environment.
Rich Felker [Thu, 23 Jun 2011 22:02:23 +0000 (18:02 -0400)]
initial commit of prng implementation by Szabolcs Nagy