Muhammad Rifqi Priyo Susanto [Sat, 26 Jan 2019 19:26:37 +0000 (02:26 +0700)]
Add setting to disable confirmation on new player registration (#8102)
Paramat [Sat, 26 Jan 2019 13:14:06 +0000 (13:14 +0000)]
Rename 'Advanced Settings' button to 'All Settings' (#8131)
Paul Ouellette [Sat, 26 Jan 2019 13:12:20 +0000 (08:12 -0500)]
Fix pkgmgr game install with RUN_IN_PLACE=0 (#8113)
Paramat [Fri, 25 Jan 2019 19:01:00 +0000 (19:01 +0000)]
blitToVManip: Check out-of-bounds using node position not index (#8127)
Previously, when using 'place on vmanip' to add a schematic to a
lua voxelmanip, if part of the schematic was outside the voxelmanip
volume, the outside part would often appear in a strange place
elsewhere inside the voxelmanip instead of being trimmed off.
This was due to the out-of-bounds check checking the index.
A position outside the voxelmanip can have an index that satisfies
'0 <= index <= voxelmanip volume', causing the node to be placed
at a strange position inside the voxelmanip.
Use 'vm->m_area.contains(pos)' instead.
Move index calculation to later in the code to optimise.
Paramat [Tue, 22 Jan 2019 21:13:06 +0000 (21:13 +0000)]
Fix warnings about dungeongen.cpp memcpy() and unused variable in MapBlock::deSerializeNetworkSpecific() (#8122)
* Fix warning about dungeongen.cpp memcpy()
* Fix unused variable in MapBlock::deSerializeNetworkSpecific()
* Fix unused variable a simpler way
Jozef Behran [Mon, 21 Jan 2019 08:53:09 +0000 (03:53 -0500)]
Fix randomly rejected form field submits (#8091)
If a formspec is submitted from a form fields handling
callback of another form (or "formspec shown from another
formspec"), the fields submitted for it can get
rejected by the form exploit mitigation subsystem with a
message like "'zorman2000' submitted formspec
('formspec_error:form2') but server hasn't sent formspec to
client, possible exploitation attempt" being sent to logs.
This was already reported as #7374 and a change was made
that fixed the simple testcase included with that bug
report but the bug still kept lurking around and popping
out in more complicated scenarios like the advtrains TSS
route programming UI.
Deep investigation of the problem revealed that this
sequence of events is entirely possible and leads to the
bug:
1. Server: show form1
2. Client *shows form1*
3. Client: submits form1
4. Server: show form2
5. Client: says form1 closed
6. Client *shows form2*
7. Client: submits form2
What happens inside the code is that when the server in
step 4 sends form2, the registry of opened forms is
updated to reflect the fact that form2 is now the valid
form for the client to submit. Then when in step 5 client
says "form1 was closed", the exploit mitigation subsystem
code deletes the registry entry for the client without
bothering to check whether the form client says was
closed just now is indeed the form that is recorded in
that entry as the valid form. Then later, in step 7 the
client tries to submit its valid form fields, these will
be rejected because the entry is missing.
It turns out the procedure where the broken code resides
already gets the form name so a simple "if" around the
offending piece of code fixes the whole thing. And
advtrains TSS agrees with that.
Wuzzy [Sun, 20 Jan 2019 18:49:17 +0000 (19:49 +0100)]
Make advanced settings noiseparams strings translatable (#8062)
Various minor language improvements in settingtypes.txt.
srifqi [Thu, 10 Jan 2019 17:56:48 +0000 (18:56 +0100)]
Advanced settings noiseparams: No tailing comma for empty flags
Previously, when editing noiseparams and disabling all the noise
flags, the noiseparam is displyed in advanced settings with a
tailing comma.
SmallJoker [Thu, 10 Jan 2019 17:54:10 +0000 (18:54 +0100)]
Advanced settings noiseparams: Remove '}' left in .conf
Previously, when editing noiseparams then restoring them to the default,
the final '}' was not removed from minetest.conf.
Paul Ouellette [Sat, 19 Jan 2019 14:17:05 +0000 (09:17 -0500)]
Remove incorrect feature flag (#8086)
And document the versions that introduced the features.
Jozef Behran [Fri, 18 Jan 2019 09:47:50 +0000 (04:47 -0500)]
Optimize subgames search a little bit (#8096)
Reserve space for the list of games in findWorldSubgame. The
performance gain is pretty much negligible but this change
also gets rid of a performance warning by CLANG TIDY.
Paul Ouellette [Wed, 16 Jan 2019 12:39:13 +0000 (07:39 -0500)]
Fix some misspellings (#8104)
SmallJoker [Sun, 13 Jan 2019 15:22:32 +0000 (16:22 +0100)]
world.mt: Only accept true/false/nil values (#8055)
This patch will make distinguishable mods in modpacks possible in the future
`nil` checks are required to provide backwards-compatibility for fresh configured worlds
Jozef Behran [Sun, 13 Jan 2019 14:11:47 +0000 (09:11 -0500)]
Speed up the craft definition handling (#8097)
The craft definition handling code that collects the names of
the craftable nodes suffers from vector reallocation
performance hits, slowing down instances with lots of
crafting recipes (VanessaE's DreamBuilder and most public
server some to my mind when thinking about this). As in each
instance the size of the resulting vector is already known,
add a reserve() call before the offending loops to allocate
the needed chunk of memory within the result vector in one
go, getting rid of the overhead.
Jozef Behran [Sat, 12 Jan 2019 15:57:26 +0000 (10:57 -0500)]
Optimize path finalization in pathfinder (#8100)
The pathfinder needs quite a bunch of items to add to the
resulting list. It turns out the amount of the space needed
for the finalized path is known in advance so preallocate it
to avoid a burst of reallocation calls each time something
needs to look for a path.
Jozef Behran [Sat, 12 Jan 2019 15:15:42 +0000 (10:15 -0500)]
Fix fake LINT check success (#8092)
The code 'if [ -z ${something} ]; then ... fi' means "if
${something} is an empty string, yell at the command line
about 'binary operator expected' and ignore the body of the
if statement, if ${something} is not an empty string,
the condition is false so ignore the body of the if
statement" which clearly isn't what the author wanted. Fix
it by adding a few quotes around the offending ${something}.
Paul Ouellette [Thu, 10 Jan 2019 06:54:20 +0000 (01:54 -0500)]
Make sqlite3 the default auth backend (#8085)
Loic Blot [Wed, 9 Jan 2019 20:14:04 +0000 (21:14 +0100)]
Import strstr function from FreeBSD 11 libc
Loïc Blot [Wed, 9 Jan 2019 13:39:43 +0000 (14:39 +0100)]
Android build fixes
This fixes #8079
rubenwardy [Wed, 9 Jan 2019 13:14:24 +0000 (13:14 +0000)]
pkgmgr: Fix games list not being updated after game install
Fixes #8074
Paramat [Wed, 9 Jan 2019 08:00:50 +0000 (08:00 +0000)]
Settingtypes.txt: Rewrite documentation of 'num_emerge_threads' (#8066)
Loïc Blot [Mon, 7 Jan 2019 16:05:18 +0000 (17:05 +0100)]
Fix a crash on Android with Align2Npot2 (#8070)
* Fix a crash on Android with Align2Npot2
glGetString can be NULL. If stored in a string it triggers a SIGSEGV.
Instead do a basic strstr and verify the pointer
* Better Align2Npot2 check (+ performance)
DS [Sun, 6 Jan 2019 16:21:04 +0000 (17:21 +0100)]
Fix wrong code comment (#8061)
"Get core.registered_on_chat_messages" to "Get core.registered_on_player_receive_fields" where `core.registered_on_player_receive_fields` is gotten
rubenwardy [Sun, 6 Jan 2019 15:54:22 +0000 (15:54 +0000)]
Content store: Disable more details dialog for now (#8060)
* Content store: Disable more details dialog for now
rubenwardy [Sun, 6 Jan 2019 13:16:27 +0000 (13:16 +0000)]
Content store: Fix update button not working
SmallJoker [Sun, 6 Jan 2019 09:24:44 +0000 (10:24 +0100)]
Fix various bugs (Anticheat, Lua helpers) (#8013)
* Fix various bugs (Anticheat, Lua helpers)
Anticheat: Use camera position instead of player position for shoot line calculations
Lua helpers: Increase 'i' to not overwrite earlier added table values
* Remove lag compensation
* * 1.5 for larger selection boxes
rubenwardy [Sun, 6 Jan 2019 09:23:35 +0000 (09:23 +0000)]
Deprecate modpack.txt and use modpack.conf instead (#7892)
* Deprecate modpack.txt and use modpack.conf instead
Translations [Sun, 6 Jan 2019 08:33:11 +0000 (09:33 +0100)]
Run updatepo.sh
Translations [Sun, 6 Jan 2019 08:32:00 +0000 (09:32 +0100)]
Update translations from Weblate
Loïc Blot [Fri, 4 Jan 2019 15:41:42 +0000 (16:41 +0100)]
Drop libgmp on Android and use mini-gmp (#8047)
Loïc Blot [Fri, 4 Jan 2019 13:16:09 +0000 (14:16 +0100)]
Bump android version code for next Play Store version
Loïc Blot [Fri, 4 Jan 2019 11:55:07 +0000 (12:55 +0100)]
Make sqlite3 default auth & player backends for new worlds (#8043)
* Make sqlite3 default auth & player backends for new worlds
Also notify about auth backend depreciation
Loïc Blot [Fri, 4 Jan 2019 10:33:04 +0000 (11:33 +0100)]
Fix on_successful_save -> onSuccessfulSave
Loïc Blot [Fri, 4 Jan 2019 09:20:04 +0000 (10:20 +0100)]
Fix various player save issues (performance penalty on sql backends + bugs)
* PostgreSQL & SQLite3 doesn't setModified(false) on RemotePlayer, then player is saved on each server save call. This results in heavy useless writes.
* PostgreSQL & SQLite3 ack engine meta write whereas db commit hasn't been performed. If commit failed write has failed. We mustn't notify engine write is done.
* serializing player meta must not setModified(false) because it didn't ensure write has been done
* add RemotePlayer::on_successfull_save callback to do the flag update on a successful save
Loïc Blot [Fri, 4 Jan 2019 09:06:46 +0000 (10:06 +0100)]
Player file directory must be only created when using file backend.
Also ensure on each player save that the directory exists
sofar [Thu, 3 Jan 2019 23:26:08 +0000 (15:26 -0800)]
Remove remote media compatibility mode. (#8044)
The fallback code shouldn't be needed and is a remnant of the GET
method that old media servers use. Clients using it are likely
to just waste bandwidth and having to download the media again
through the normal transfer from server method. The most reliable
method is to get all missing textures therefore from the server
directly and not spam the remote media server with 404s.
SmallJoker [Thu, 3 Jan 2019 16:04:26 +0000 (17:04 +0100)]
Proselytize the network. Use IEEE F32 (#8030)
* Proselytize the network. Use IEEE F32
* Remove unused V2F1000 functions
Paramat [Thu, 3 Jan 2019 11:10:07 +0000 (11:10 +0000)]
CSM restrictions: Make 'LOAD_CLIENT_MODS' disable loading of 'builtin' (#8000)
Previously, when the CSM restriction 'LOAD_CLIENT_MODS' was used a
client was still able to add CSM code to 'builtin' to bypass that
restriction, because 'builtin' is not yet verified.
Until server-sent CSM and verifying of 'builtin' are complete, make
'LOAD_CLIENT_MODS' disable the loading of builtin.
Clarify code comments and messages to distinguish between client-side
modding and client-side scripting. 'Scripting' includes 'builtin',
'modding' does not.
Moose [Wed, 2 Jan 2019 22:32:19 +0000 (23:32 +0100)]
autojump setting: Remove repeated doc line (#8041)
HybridDog [Mon, 31 Dec 2018 00:32:54 +0000 (01:32 +0100)]
Add minetest.load_area (#8023)
random-geek [Mon, 31 Dec 2018 00:07:30 +0000 (16:07 -0800)]
Extend pitch fly mode to swimming (#7943)
rubenwardy [Wed, 26 Dec 2018 12:39:28 +0000 (12:39 +0000)]
Fix installed modpacks not being found correctly
stujones11 [Fri, 28 Dec 2018 22:31:09 +0000 (22:31 +0000)]
Update README.android with current build info (#8026)
rubenwardy [Wed, 26 Dec 2018 12:47:32 +0000 (12:47 +0000)]
Content store: Fix bugs relating to packages list size
Loïc Blot [Mon, 24 Dec 2018 09:51:10 +0000 (10:51 +0100)]
CSM: add requested CSM_RF_READ_PLAYERINFO (#8007)
* CSM: add requested CSM_RF_READ_PLAYERINFO
This new CSM limit permit to limit PLAYERINFO read from server.
It affects get_player_names call
Paramat [Sun, 23 Dec 2018 23:49:08 +0000 (23:49 +0000)]
Remove 'Reset singleplayer world' button from full menu on Android (#8017)
Make button appearence dependent on menustyle not platform.
Button only functions with simple menu.
SmallJoker [Sun, 23 Dec 2018 23:22:27 +0000 (00:22 +0100)]
Fix entity rotation in existing worlds (#7989)
stujones11 [Sat, 22 Dec 2018 18:02:00 +0000 (18:02 +0000)]
Android: Fix start-up crashes on version 4.x (#8003)
* Android: Load shared STL library
* Android: Fix exception with window background image
Vitaliy [Sat, 22 Dec 2018 16:36:24 +0000 (19:36 +0300)]
mapnode: add const/noexcept (#8009)
rubenwardy [Sat, 22 Dec 2018 07:46:41 +0000 (07:46 +0000)]
Android: Fix memory leak when displaying images in the mainmenu (#8011)
ClobberXD [Sat, 22 Dec 2018 00:32:27 +0000 (06:02 +0530)]
Lua_api.txt: Add documentation of missing field to 'on_punch' (#8008)
SmallJoker [Fri, 21 Dec 2018 18:05:29 +0000 (19:05 +0100)]
reportMetadataChange; Silence clang warnings
stujones11 [Thu, 20 Dec 2018 22:40:17 +0000 (22:40 +0000)]
Fix more transparency issues with ogles2 driver (#8005)
stujones11 [Thu, 20 Dec 2018 21:11:57 +0000 (21:11 +0000)]
Android: Move touchscreen rare controls inline with settings icon (#8006)
Kevin Abrams [Tue, 18 Dec 2018 19:15:14 +0000 (13:15 -0600)]
Add command line option to load password from file (#7832)
SmallJoker [Tue, 18 Dec 2018 18:50:07 +0000 (19:50 +0100)]
ieee_float: Silence compiler warning
Trivial issue reported by @pgimeno
Pedro Gimeno [Tue, 18 Dec 2018 10:47:29 +0000 (11:47 +0100)]
Fix the part of the float test that requires IEC559/IEEE754 compliance
GCC and CLang compilers fail to support full IEC559 compliance required for the test, when certain compiler flags are active. This patch implements a heuristic that checks for the most common flag in GCC and CLang, plues an extra check which GCC disables when it's not compliant, to hopefully catch most cases where it can't run.
zeuner [Tue, 18 Dec 2018 00:38:39 +0000 (01:38 +0100)]
Lua_api.txt: Document inventory sending behaviour (#7720)
Pedro Gimeno [Sun, 16 Dec 2018 17:44:23 +0000 (18:44 +0100)]
Fix C++11 violation that broke clang on Debian Stretch
Loïc Blot [Sat, 15 Dec 2018 14:12:40 +0000 (15:12 +0100)]
Add a basic kubernetes deployment file (#7979)
* Add a basic kubernetes deployment file
SmallJoker [Sat, 15 Dec 2018 08:01:00 +0000 (09:01 +0100)]
Fix ignored mod.conf mod name for world.mt (broken by
e8eaab6)
Patch supplied by @pgimeno. Thank you.
SmallJoker [Fri, 14 Dec 2018 19:35:43 +0000 (20:35 +0100)]
Android: Add activeobjectmgr.cpp and ieee_float.cpp, sort list
Loïc Blot [Thu, 13 Dec 2018 19:19:19 +0000 (20:19 +0100)]
Add docker image documentation (#7969)
* Add docker image documentation
* Update README.md
Loïc Blot [Thu, 13 Dec 2018 19:18:54 +0000 (20:18 +0100)]
Add an activeobject manager to hold active objects (#7939)
* Add an activeobject manager to hold active objects
* Add unittests
SmallJoker [Thu, 13 Dec 2018 10:20:57 +0000 (11:20 +0100)]
Network: Send IEEE floats (#7768)
Wuzzy [Thu, 13 Dec 2018 10:05:38 +0000 (11:05 +0100)]
Make showOverlayMessage strings translatable (#7964)
ClobberXD [Wed, 12 Dec 2018 08:50:40 +0000 (14:20 +0530)]
(client_)lua_api.txt: Rename func -> function (#7960)
Loïc Blot [Wed, 12 Dec 2018 08:47:32 +0000 (09:47 +0100)]
Gitlab CI: docker image rename + add commit id tag
Vitaliy [Tue, 11 Dec 2018 23:02:09 +0000 (02:02 +0300)]
Make MapNode handle paramtype2≠leveled properly (#7958)
Loïc Blot [Tue, 11 Dec 2018 23:00:08 +0000 (00:00 +0100)]
Add a Dockerfile + gitlab CI build (#7968)
* Add a minetest docker file
* Clone minetest_game from git directly
Paul Ouellette [Tue, 11 Dec 2018 16:37:06 +0000 (11:37 -0500)]
lua_api.txt: Various fixes and improvements (#7945)
* Add missing tables of registered things
* Eliminate some duplication
Registration functions in 'Registered definitions' section merged into
'Registration functions' section.
* Misc. fixes
* Add privilege definition table
* Remove not-special soil group from special groups
* Merge two registration functions sections
* Move 'added to' information to tables section
Also fix some capitalization and missing periods
* Minor fixes
* Split Registration functions into two subsections
And update Registered definition tables to match order
* Fixes
Loïc Blot [Tue, 11 Dec 2018 16:35:39 +0000 (17:35 +0100)]
porting.cpp: better minetest support on BSD
BSD folder detection is pretty raw, just use the same detection as Linux
rubenwardy [Tue, 11 Dec 2018 04:43:14 +0000 (04:43 +0000)]
Fix ContentDB packages timing out by using download_file instead (#7891)
Alex [Tue, 11 Dec 2018 02:57:04 +0000 (18:57 -0800)]
Add object visual type 'item' (#7870)
random-geek [Mon, 10 Dec 2018 20:25:56 +0000 (12:25 -0800)]
Content store: Fix missing screenshot in package view dialog
Paul Ouellette [Mon, 10 Dec 2018 18:18:03 +0000 (13:18 -0500)]
Fix wrong parameter order for inventory callbacks (#7952)
meme [Mon, 10 Dec 2018 13:47:35 +0000 (08:47 -0500)]
Fix dissector script to work with newer versions of Wireshark (#7957)
Wuzzy [Mon, 10 Dec 2018 08:25:47 +0000 (09:25 +0100)]
Add eat sound (#7956)
Update Script [Sun, 9 Dec 2018 13:16:11 +0000 (14:16 +0100)]
Update minetest.conf.example and run updatepo.sh (#7947)
Martin Renold [Sat, 8 Dec 2018 15:26:04 +0000 (16:26 +0100)]
Fix crash if display resolution is not set (#7950)
On my wayland / gnome3 setup DisplayHeightMM() returns 0. This resulted in a
misleading startup error suggesting to fix my font paths.
Paramat [Thu, 6 Dec 2018 23:52:11 +0000 (23:52 +0000)]
Main menu style: Set to 'full' for Android, remove 'auto' option (#7936)
rubenwardy [Thu, 6 Dec 2018 23:32:15 +0000 (23:32 +0000)]
Disable game bar and header on Android (#7940)
Paramat [Thu, 6 Dec 2018 03:56:35 +0000 (03:56 +0000)]
Draw all horizons and sky base, in front of stars (#7932)
Move star draw to before sun glow texture draw and before sun draw,
not currently essential but the logical order. Will be necessary if
a 'no far ground' option is added, to draw stars behind the sun.
Loic Blot [Wed, 5 Dec 2018 19:08:46 +0000 (20:08 +0100)]
Gradle now copy most of assets
It depends on cleanAssets, ensuring they are always fresh
CoderForTheBetter [Wed, 5 Dec 2018 08:28:09 +0000 (03:28 -0500)]
Fix player rotations (#7941)
Paramat [Wed, 5 Dec 2018 08:18:44 +0000 (08:18 +0000)]
Declare mapgens v5 and flat stable. Add missing carpathian (#7942)
SmallJoker [Tue, 4 Dec 2018 19:37:48 +0000 (20:37 +0100)]
Send only changed node metadata to clients instead of whole mapblock (#5268)
Includes newer style changes and fixes by est31
Improve the block position de-serialization
Add type NodeMetadataMap
Loic Blot [Tue, 4 Dec 2018 18:11:03 +0000 (19:11 +0100)]
Update android version code (rebuild)
Loïc Blot [Tue, 4 Dec 2018 15:45:07 +0000 (16:45 +0100)]
Revert "Fix another GCC warning"
This reverts commit
e6811184d5824bf7d8febc157495dbecd3e4e0f7.
Loïc Blot [Tue, 4 Dec 2018 15:18:17 +0000 (16:18 +0100)]
Add testWrapDegrees_0_360_v3f unittests
Loïc Blot [Tue, 4 Dec 2018 14:57:47 +0000 (15:57 +0100)]
Fix another GCC warning
```
[ 10%] Building CXX object src/CMakeFiles/minetest.dir/client/render/interlaced.cpp.o
cc1plus: warning: -Wabi won't warn about anything [-Wabi]
cc1plus: note: -Wabi warns about differences from the most up-to-date ABI, which is also used by default
cc1plus: note: use e.g. -Wabi=11 to warn about changes from GCC 7
```
Loïc Blot [Tue, 4 Dec 2018 11:38:11 +0000 (12:38 +0100)]
Fix a stringop-truncation GCC warning
```
minetest/src/filesys.cpp:312:10: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 10000 equals destination size [-Wstringop-truncation]
strncpy(argv_data[2], path.c_str(), 10000);
```
Loïc Blot [Tue, 4 Dec 2018 11:39:10 +0000 (12:39 +0100)]
Fix uninitialized variable peer_id
Reported by GCC
```
minetest/src/server.cpp:996:42: warning: ‘peer_id’ may be used uninitialized in this function [-Wmaybe-uninitialized]
errorstream << "ProcessData: peer=" << peer_id << e.what() << std::endl;
```
Paramat [Tue, 4 Dec 2018 00:39:30 +0000 (00:39 +0000)]
Mirror 'sunrisebg' texture to fix chopped right edge (#7935)
stujones11 [Mon, 3 Dec 2018 21:35:31 +0000 (21:35 +0000)]
Re-master and improve touchscreen gui icons (#7931)
Increase the resolution of the smaller icons to look better on modern HD screens.
All master SVGs included in the the Android build directory.
Juozas [Mon, 3 Dec 2018 18:31:20 +0000 (20:31 +0200)]
Fix Android build errors (caused by
5f1cd55)
After commit
5f1cd55 touchscreengui.* files were pointing to old file locations
woshiicyrus [Sun, 2 Dec 2018 23:43:02 +0000 (07:43 +0800)]
README: Add linking table of contents (#7601)
Paul Ouellette [Sun, 2 Dec 2018 23:41:05 +0000 (18:41 -0500)]
Improve world configure menu (#7922)
Replace `Subgame mods` with <game name> mods.
Display game description on left instead of dependencies.
Fix double DIR_DELIM in some paths.
Maksim [Sun, 2 Dec 2018 23:39:35 +0000 (00:39 +0100)]
Update Android java code (#7820)
Targets SDK 26 as required by the playstore.
Fixes screen auto-rotation closing game.
Hides on-screen navigation bar if present.
Update gradlew.
Fix display aspect on 18+/:9 displays (like a Samsung Galaxy S9).
Remove small app icons, not required.
Fix xml in unpacking activity.
Support Android permission: On Android 6.0+ you need to manually give write
permission (as required by google).
Background during unpacking (just a demo for now).
Material Design: no more Android 2 interface.
Immersive mode (Android 4.4+ - hide NavBar for fullscreen mode).
Vanessa Dannenberg [Sun, 2 Dec 2018 22:34:29 +0000 (17:34 -0500)]
Raise hotbar limit to 32 slots, add associated keybinding options (#7916)
add associated keybinding options
update docs and settingtypes