rofl0r [Sun, 18 Nov 2012 04:14:40 +0000 (05:14 +0100)]
fcntl.h: O_SEARCH was missing for powerpc
put some macros that do not differ between architectures in the
main header and remove from bits.
restructure mips header so it has the same structure as the others.
rofl0r [Sun, 18 Nov 2012 01:38:41 +0000 (02:38 +0100)]
ppc socket.h: add forgotten cmsghdr
Rich Felker [Sun, 18 Nov 2012 01:04:36 +0000 (20:04 -0500)]
fix typo in dynamic linker path file loading code
fortunately the memory corruption could not hurt anything, but it
prevented clearing the final newline and thus prevented the last path
element from working.
Rich Felker [Sun, 18 Nov 2012 00:51:49 +0000 (19:51 -0500)]
add cleaned-up sys/mtio.h
this is mostly junk, but a few programs with tape-drive support
unconditionally include it, and it might be useful.
Rich Felker [Sat, 17 Nov 2012 23:42:16 +0000 (18:42 -0500)]
add stub versions of some missing optional pthread interfaces
priority inheritance is not yet supported, and priority protection
probably will not be supported ever unless there's serious demand for
it (it's a fairly heavy-weight feature).
per-thread cpu clocks would be nice to have, but to my knowledge linux
is still not capable of supporting them. glibc fakes them by using the
_process_ cpu-time clock and subtracting the thread creation time,
which gives seriously incorrect semantics (worse than not supporting
the feature at all), so until there's a way to do it right, it will
remain as a stub that always fails.
Rich Felker [Sat, 17 Nov 2012 22:25:17 +0000 (17:25 -0500)]
arg-skipping code for powerpc dynamic linker
this allows using the dynamic linker as a command to load programs.
Rich Felker [Sat, 17 Nov 2012 03:22:34 +0000 (22:22 -0500)]
dynamic linking support for powerpc
incomplete but at least partly working. requires all files to be
compiled in the new "secure" plt model, not the old one that put plt
code in the data segment. TLS is untested but may work. invoking the
dynamic linker explicitly to load a program does not yet handle argv
correctly.
Rich Felker [Fri, 16 Nov 2012 06:19:42 +0000 (01:19 -0500)]
fix ppc stat structure definition
rofl0r [Fri, 16 Nov 2012 01:17:02 +0000 (02:17 +0100)]
fix powerpc termios.h and ioctl.h
Rich Felker [Fri, 16 Nov 2012 00:16:10 +0000 (19:16 -0500)]
disable SO_REUSEPORT in sys/socket.h
although a number is reserved for it, this option is not implemented
on Linux and does not work. defining it causes some applications to
use it, and subsequently break due to its failure.
Rich Felker [Thu, 15 Nov 2012 21:01:54 +0000 (16:01 -0500)]
ppc wchar_t is long, not int
Rich Felker [Thu, 15 Nov 2012 13:37:58 +0000 (08:37 -0500)]
Merge remote-tracking branch 'nsz/math'
Rich Felker [Thu, 15 Nov 2012 01:24:46 +0000 (20:24 -0500)]
update copyright file for recent contributions
Rich Felker [Wed, 14 Nov 2012 19:27:51 +0000 (14:27 -0500)]
fix indention with spaces in powerpc asm
Rich Felker [Wed, 14 Nov 2012 19:24:22 +0000 (14:24 -0500)]
fix powerpc atomic compare-and-swap function
previous version did not compare at all; it was just a fancy atomic
write. untested. further atomic fixes may be needed.
Rich Felker [Wed, 14 Nov 2012 19:08:33 +0000 (14:08 -0500)]
update ppc atomic code to match the endian-agnostic version on other archs
Rich Felker [Wed, 14 Nov 2012 19:04:10 +0000 (14:04 -0500)]
fix wchar limits mistakenly copied from arm
Rich Felker [Wed, 14 Nov 2012 19:01:39 +0000 (14:01 -0500)]
Merge remote-tracking branch 'ppc-port/ppc-squashed'
Szabolcs Nagy [Wed, 14 Nov 2012 08:27:54 +0000 (09:27 +0100)]
fenv: return FE_TONEAREST in dummy fegetround
Szabolcs Nagy [Wed, 14 Nov 2012 00:01:38 +0000 (01:01 +0100)]
math: ld80 invtrig cleanups
keeping only commonly used data in invtrigl
Szabolcs Nagy [Tue, 13 Nov 2012 20:54:32 +0000 (21:54 +0100)]
math: simplify hypot and hypotf using scalbn
this also fixes overflow/underflow raising and excess
precision issues (as those are handled well in scalbn)
Szabolcs Nagy [Tue, 13 Nov 2012 18:59:02 +0000 (19:59 +0100)]
math: turn off the STRICT_ASSIGN workaround by default
the volatile hack in STRICT_ASSIGN is only needed if
assignment is not respected and excess precision is kept.
gcc -fexcess-precision=standard and -ffloat-store both
respect assignment and musl use these flags by default.
i kept the macro for now so the workaround may be used
for bad compilers in the future.
rofl0r [Fri, 9 Nov 2012 22:36:55 +0000 (23:36 +0100)]
PPC port cleaned up, static linking works well now.
Richard Pennington [Fri, 9 Nov 2012 22:32:57 +0000 (23:32 +0100)]
import preliminary ppc work by rdp.
Szabolcs Nagy [Tue, 13 Nov 2012 12:34:45 +0000 (13:34 +0100)]
math: use '#pragma STDC FENV_ACCESS ON' when fenv is accessed
Szabolcs Nagy [Tue, 13 Nov 2012 09:55:35 +0000 (10:55 +0100)]
math: excess precision fix modf, modff, scalbn, scalbnf
old code was correct only if the result was stored (without the
excess precision) or musl was compiled with -ffloat-store.
now we use STRICT_ASSIGN to work around the issue.
(see note 160 in c11 section 6.8.6.4)
Szabolcs Nagy [Tue, 13 Nov 2012 09:30:40 +0000 (10:30 +0100)]
math: fix scalbn and scalbnf on overflow/underflow
old code was correct only if the result was stored (without the
excess precision) or musl was compiled with -ffloat-store.
(see note 160 in n1570.pdf section 6.8.6.4)
Szabolcs Nagy [Tue, 13 Nov 2012 09:12:07 +0000 (10:12 +0100)]
math: fix nextafter and nexttoward on maxdbl and maxflt input
old code (return x+x;) returns correct value and raises correct
flags only if the result is stored as double (or float)
Szabolcs Nagy [Tue, 13 Nov 2012 00:31:49 +0000 (01:31 +0100)]
complex: add C11 CMPLX macros and replace cpack with them
Szabolcs Nagy [Mon, 12 Nov 2012 23:49:55 +0000 (00:49 +0100)]
math: raise flags in logl.c on <= 0 arguments
Szabolcs Nagy [Mon, 12 Nov 2012 23:45:51 +0000 (00:45 +0100)]
math: fix logb*.c exceptions now that ilogb raises invalid
Szabolcs Nagy [Mon, 12 Nov 2012 23:30:06 +0000 (00:30 +0100)]
math: raise flags in log2l.c on <= 0 arguments, and fix volatile
Szabolcs Nagy [Mon, 12 Nov 2012 23:21:09 +0000 (00:21 +0100)]
math: raise exception flags in log1pl.c on <= -1 arguments
Szabolcs Nagy [Mon, 12 Nov 2012 22:58:18 +0000 (23:58 +0100)]
math: raise invalid flag in ilogb*.c on +-0, +-inf and nan
Szabolcs Nagy [Mon, 12 Nov 2012 22:41:48 +0000 (23:41 +0100)]
math: fix exception behaviour of expm1l.c on inf and nan
Szabolcs Nagy [Mon, 12 Nov 2012 22:13:28 +0000 (23:13 +0100)]
math: fix long double constants in exp10l.c
Rich Felker [Sun, 11 Nov 2012 21:08:38 +0000 (16:08 -0500)]
debloat src/thread tree but putting lots of junk in one file
POSIX includes mostly-useless attribute-get functions for each
attribute-set function, presumably out of some object-oriented
dogmatism. the get functions are not useful with the simple idiomatic
usage of attributes. there are of course possible valid uses of them
(like writing wrappers for pthread init functions that perform special
actions on the presence of certain attributes), but considering how
tiny these functions are anyway, little is lost by putting them all in
one file, and some build-time cost and archive-file-size benefits are
achieved.
Rich Felker [Sun, 11 Nov 2012 20:54:20 +0000 (15:54 -0500)]
report support of TPS option in unistd.h and sysconf
also update another newish feature in sysconf, stackaddr
Rich Felker [Sun, 11 Nov 2012 20:38:04 +0000 (15:38 -0500)]
add support for thread scheduling (POSIX TPS option)
linux's sched_* syscalls actually implement the TPS (thread
scheduling) functionality, not the PS (process scheduling)
functionality which the sched_* functions are supposed to have.
omitting support for the PS option (and having the sched_* interfaces
fail with ENOSYS rather than omitting them, since some broken software
assumes they exist) seems to be the only conforming way to do this on
linux.
Rich Felker [Sun, 11 Nov 2012 18:56:37 +0000 (13:56 -0500)]
fix clobber of edx in i386 vsyscall asm
this function does not obey the normal calling convention; like a
syscall instruction, it's expected not to clobber any registers except
the return value. clobbering edx could break callers that were reusing
the value cached in edx after the syscall returns.
Rich Felker [Fri, 9 Nov 2012 19:26:25 +0000 (14:26 -0500)]
always add memory streams to stdio open file list
per interpretation for austin group issue #626, fflush(0) and exit()
must block waiting for a lock if another thread has locked a memory
stream with flockfile. this adds some otherwise-unnecessary
synchronization cost to use of memory streams, but there was already a
synchronization cost calling malloc anyway.
previously the stream was only added to the open file list in
single-threaded programs, so that upon subsequent call to
pthread_create, locking could be turned on for the stream.
Rich Felker [Fri, 9 Nov 2012 18:49:40 +0000 (13:49 -0500)]
support ldso path files without final newline
Rich Felker [Fri, 9 Nov 2012 03:41:16 +0000 (22:41 -0500)]
change ldso path file logic to replace rather than add to search path
this change was originally intended just to avoid repeated attempts to
open a nonexistant /etc/ls-musl-$(ARCH).path file, but I realized it
also prevents the default paths from being searched when such a path
file exists. despite the potential to break existing usage, I believe
the new behavior is the right behavior, and it's better to fix it
sooner rather than later. with the old behavior, it was impossible to
inhibit search of default paths which might contain musl-incompatible
libs (or even libs from a different cpu arch, on multi-arch machines).
Rich Felker [Thu, 8 Nov 2012 22:20:50 +0000 (17:20 -0500)]
fix "configure --prefix=" and improve path/arg handling in configure
previously, empty string was treated as "use default". this is
apparently not compatible with standard configure semantics where an
empty prefix puts everything under /. the new logic should be a lot
cleaner and not suffer from such issues.
Rich Felker [Thu, 8 Nov 2012 22:04:20 +0000 (17:04 -0500)]
clean up sloppy nested inclusion from pthread_impl.h
this mirrors the stdio_impl.h cleanup. one header which is not
strictly needed, errno.h, is left in pthread_impl.h, because since
pthread functions return their error codes rather than using errno,
nearly every single pthread function needs the errno constants.
in a few places, rather than bringing in string.h to use memset, the
memset was replaced by direct assignment. this seems to generate much
better code anyway, and makes many functions which were previously
non-leaf functions into leaf functions (possibly eliminating a great
deal of bloat on some platforms where non-leaf functions require ugly
prologue and/or epilogue).
Rich Felker [Thu, 8 Nov 2012 21:39:41 +0000 (16:39 -0500)]
clean up stdio_impl.h
this header evolved to facilitate the extremely lazy practice of
omitting explicit includes of the necessary headers in individual
stdio source files; not only was this sloppy, but it also increased
build time.
now, stdio_impl.h is only including the headers it needs for its own
use; any further headers needed by source files are included directly
where needed.
Rich Felker [Thu, 8 Nov 2012 19:31:49 +0000 (14:31 -0500)]
fix dlsym asm for mips
saving the return address from the delay slot is not valid -- by the
time the instruction executes, the return address has already been
replaced.
Rich Felker [Mon, 5 Nov 2012 19:30:15 +0000 (14:30 -0500)]
improve SOCK_NONBLOCK/SOCK_CLOEXEC fallback code
checking for EINVAL should be sufficient, but qemu user emulation
returns EPROTONOSUPPORT in some of the failure cases, and it seems
conceivable that other kernels doing linux-emulation could make the
same mistake. since DNS lookups and other important code might break
if the fallback does not get invoked, be extra careful and check for
either error.
note that it's important NOT to perform the fallback code on other
errors such as resource-exhaustion cases, since the fallback is not
atomic and will lead to file-descriptor leaks in multi-threaded
programs that use exec. the fallback code is only "safe" to run when
the initial failure is caused by the application's choice of
arguments, not the system state.
Rich Felker [Mon, 5 Nov 2012 19:29:04 +0000 (14:29 -0500)]
fix numerous mips abi constant definition mismatches
Rich Felker [Sun, 4 Nov 2012 22:06:31 +0000 (17:06 -0500)]
mips cache flush/ctl syscall support and header
Rich Felker [Fri, 2 Nov 2012 03:49:57 +0000 (23:49 -0400)]
remove one unnecessary static var from dynamic linker
Rich Felker [Fri, 2 Nov 2012 03:46:39 +0000 (23:46 -0400)]
fix more unused variable warnings
some of these were coming from stdio functions locking files without
unlocking them. I believe it's useful for this to throw a warning, so
I added a new macro that's self-documenting that the file will never
be unlocked to avoid the warning in the few places where it's wrong.
Rich Felker [Fri, 2 Nov 2012 02:58:17 +0000 (22:58 -0400)]
fix unused variable warnings
Rich Felker [Thu, 1 Nov 2012 07:49:43 +0000 (03:49 -0400)]
avoid breakage if somebody wrongly defines empty feature test macros
Rich Felker [Thu, 1 Nov 2012 01:27:48 +0000 (21:27 -0400)]
add dl_iterate_phdr interface
patches by Alex Caudill (npx). the dynamic-linked version is almost
identical to the final submitted patch; I just added a couple missing
lines for saving the phdr address when the dynamic linker is invoked
directly to run a program, and removed a couple to avoid introducing
another unnecessary type. the static-linked version is based on npx's
draft. it could use some improvements which are contingent on the
startup code saving some additional information for later use.
Rich Felker [Mon, 29 Oct 2012 01:17:45 +0000 (21:17 -0400)]
system is a cancellation point
ideally, system would also be cancellable while running the external
command, but I cannot find any way to make that work without either
leaking zombie processes or introducing behavior that is far outside
what the standard specifies. glibc handles cancellation by killing the
child process with SIGKILL, but this could be unsafe in that it could
leave the data being manipulated by the command in an inconsistent
state.
Rich Felker [Sun, 28 Oct 2012 22:45:11 +0000 (18:45 -0400)]
release notes for 0.9.7
Rich Felker [Sun, 28 Oct 2012 19:04:26 +0000 (15:04 -0400)]
fix shmdt syscall calling convention on old archs
Rich Felker [Sat, 27 Oct 2012 23:52:40 +0000 (19:52 -0400)]
separate getc/putc from fgetc/fputc
for conformance, two functions should not have the same address. a
conforming program could use the addresses of getc and fgetc in ways
that assume they are distinct. normally i would just use a wrapper,
but these functions are so small and performance-critical that an
extra layer of function call could make the one that's a wrapper
nearly twice as slow, so I'm just duplicating the code instead.
Rich Felker [Sat, 27 Oct 2012 00:14:19 +0000 (20:14 -0400)]
update documentation
Rich Felker [Fri, 26 Oct 2012 22:15:51 +0000 (18:15 -0400)]
further pcc fixes in configure
-lpcc only works if -nostdlib is not passed, so it's useless. instead,
use -print-file-name to look up the full pathname for libpcc.a, and
check whether that succeeds before trying to link with the result.
also, silence pcc's junk printed on stdout during tests.
Rich Felker [Fri, 26 Oct 2012 20:30:07 +0000 (16:30 -0400)]
add support for detecting pcc's compiler runtime
in old versions of pcc, the directory containing libpcc.a was not in
the library path, and other options like -print-file-name may have
been needed to locate it. however, -print-file-name itself seems to
have been added around the same time that the directory was added to
the search path, and moreover, I see no evidence that older versions
of pcc are capable of building a working musl shared library. thus, it
seems reasonable to just test whether -lpcc is accepted.
Rich Felker [Thu, 25 Oct 2012 19:40:58 +0000 (15:40 -0400)]
use explicit visibility to optimize a few hot-path function calls
on x86 and some other archs, functions which make function calls which
might go through a PLT incur a significant overhead cost loading the
GOT register prior to making the call. this load is utterly useless in
musl, since all calls are bound at library-creation time using
-Bsymbolic-functions, but the compiler has no way of knowing this, and
attempts to set the default visibility to protected have failed due to
bugs in GCC and binutils.
this commit simply manually assigns hidden/protected visibility, as
appropriate, to a few internal-use-only functions which have many
callers, or which have callers that are hot paths like getc/putc. it
shaves about 5k off the i386 libc.so with -Os. many of the
improvements are in syscall wrappers, where the benefit is just size
and performance improvement is unmeasurable noise amid the syscall
overhead. however, stdio may be measurably faster.
if in the future there are toolchains that can do the same thing
globally without introducing linking bugs, it might be worth
considering removing these workarounds.
Rich Felker [Thu, 25 Oct 2012 18:52:12 +0000 (14:52 -0400)]
configure: test not just compiling but linking with -march/-mtune
pcc wrongly passes any option beginning with -m to the linker, and
will break at link time if these options were added to CFLAGS. testing
linking lets us catch this at configure time and skip them.
Rich Felker [Thu, 25 Oct 2012 03:16:41 +0000 (23:16 -0400)]
correct locking in stdio functions that tried to be lock-free
these functions must behave as if they obtain the lock via flockfile
to satisfy POSIX requirements. since another thread can provably hold
the lock when they are called, they must wait to obtain the lock
before they can return, even if the correct return value could be
obtained without locking. in the case of fclose and freopen, failure
to do so could cause correct (albeit obscure) programs to crash or
otherwise misbehave; in the case of feof, ferror, and fwide, failure
to obtain the lock could sometimes return incorrect results. in any
case, having these functions proceed and return while another thread
held the lock was wrong.
Rich Felker [Thu, 25 Oct 2012 01:16:06 +0000 (21:16 -0400)]
greatly improve freopen behavior
1. don't open /dev/null just as a basis to copy flags; use shared
__fmodeflags function to get the right file flags for the mode.
2. handle the case (probably invalid, but whatever) case where the
original stream's file descriptor was closed; previously, the logic
re-closed it.
3. accept the "e" mode flag for close-on-exec; update dup3 to fallback
to using dup2 so we can simply call __dup3 instead of putting fallback
logic in freopen itself.
Rich Felker [Thu, 25 Oct 2012 00:03:43 +0000 (20:03 -0400)]
remove useless failure-check from freopen (can't happen)
Rich Felker [Mon, 22 Oct 2012 19:17:09 +0000 (15:17 -0400)]
simplify logic in stpcpy; avoid copying first aligned byte twice
gcc seems to be generating identical or near-identical code for both
versions, but the newer code is more expressive of what it's doing.
Rich Felker [Sun, 21 Oct 2012 23:15:11 +0000 (19:15 -0400)]
fix issues with wait constants in stdlib.h
the W* namespace is not reserved, so the nonstandard ones must be
moved under extension features. also WNOHANG and WUNTRACED were
missing.
Rich Felker [Sun, 21 Oct 2012 22:37:15 +0000 (18:37 -0400)]
as an extension, have putenv("VAR") behave as unsetenv("VAR")
the behavior of putenv is left undefined if the argument does not
contain an equal sign, but traditional implementations behave this way
and gnulib replaces putenv if it doesn't do this.
Rich Felker [Sun, 21 Oct 2012 22:28:20 +0000 (18:28 -0400)]
accept "nan(n-char-sequence)" in strtod/scanf functions
this will prevent gnulib from wrapping our strtod to handle this
useless feature.
Rich Felker [Sun, 21 Oct 2012 17:23:03 +0000 (13:23 -0400)]
fix copy/paste error in popen changes that broke signals
signal mask was not being restored after fork, but instead blocked again.
nsz [Sun, 21 Oct 2012 00:31:04 +0000 (02:31 +0200)]
complex: make _Complex_I work with gcc -std=c99 -pedantic-errors
Rich Felker [Sat, 20 Oct 2012 01:57:56 +0000 (21:57 -0400)]
support looking up thread-local objects with dlsym
Rich Felker [Sat, 20 Oct 2012 01:41:30 +0000 (21:41 -0400)]
fix breakage in dlsym for looking up RTLD_DEFAULT, etc.
this was broken during the early dynamic-linked TLS commits, which
rearranged some of the code for handling new relocation types.
Rich Felker [Fri, 19 Oct 2012 22:52:14 +0000 (18:52 -0400)]
fix struct stat size/padding on microblaze
Rich Felker [Fri, 19 Oct 2012 19:02:37 +0000 (15:02 -0400)]
fix usage of locks with vfork
__release_ptc() is only valid in the parent; if it's performed in the
child, the lock will be unlocked early then double-unlocked later,
corrupting the lock state.
Rich Felker [Fri, 19 Oct 2012 05:33:52 +0000 (01:33 -0400)]
fix crashes in static-linked multithreaded programs without TLS
Rich Felker [Fri, 19 Oct 2012 04:27:03 +0000 (00:27 -0400)]
fix order of syscall args for microblaze clone syscall
with this commit, based on testing with patches to qemu which are not
yet upstream,
Rich Felker [Fri, 19 Oct 2012 03:02:53 +0000 (23:02 -0400)]
use $CC rather than "$CC" in configure script
this is necessary to allow $CC with arguments in it
Rich Felker [Fri, 19 Oct 2012 02:13:36 +0000 (22:13 -0400)]
inline syscalls for microblaze
Rich Felker [Fri, 19 Oct 2012 02:01:24 +0000 (22:01 -0400)]
ensure microblaze __set_thread_area returns success
since it did not set the return-value register, the caller could
wrongly interpret this as failure.
Rich Felker [Fri, 19 Oct 2012 01:50:55 +0000 (21:50 -0400)]
better support for reverse-endian variants of arm/mips/microblaze
these macros are supported by more compilers
Rich Felker [Fri, 19 Oct 2012 00:26:41 +0000 (20:26 -0400)]
avoid raising spurious division-by-zero exception in printf
Rich Felker [Fri, 19 Oct 2012 00:19:53 +0000 (20:19 -0400)]
floating point environment/exceptions support for mips
Rich Felker [Thu, 18 Oct 2012 20:41:27 +0000 (16:41 -0400)]
fix parent-memory-clobber in posix_spawn (environ)
Rich Felker [Thu, 18 Oct 2012 19:58:23 +0000 (15:58 -0400)]
overhaul system() and popen() to use vfork; fix various related bugs
since we target systems without overcommit, special care should be
taken that system() and popen(), like posix_spawn(), do not fail in
processes whose commit charges are too high to allow ordinary forking.
this in turn requires special precautions to ensure that the parent
process's signal handlers do not end up running in the shared-memory
child, where they could corrupt the state of the parent process.
popen has also been updated to use pipe2, so it does not have a
fd-leak race in multi-threaded programs. since pipe2 is missing on
older kernels, (non-atomic) emulation has been added.
some silly bugs in the old code should be gone too.
Rich Felker [Thu, 18 Oct 2012 04:09:36 +0000 (00:09 -0400)]
fix (hopefully; untested) completely broken/incomplete microblaze sigsetjmp
Rich Felker [Thu, 18 Oct 2012 03:45:21 +0000 (23:45 -0400)]
fix microblaze asm relocations for shared libc
only @PLT relocations are considered functions for purposes of
-Bsymbolic-functions, so always use @PLT. it should not hurt in the
static-linked case.
Rich Felker [Wed, 17 Oct 2012 06:47:11 +0000 (02:47 -0400)]
assert() is supposed to have type void
Rich Felker [Tue, 16 Oct 2012 03:02:57 +0000 (23:02 -0400)]
add memmem function (gnu extension)
based on strstr. passes gnulib tests and a few quick checks of my own.
Rich Felker [Tue, 16 Oct 2012 01:01:48 +0000 (21:01 -0400)]
microblaze TLS relocation support, completely untested
Rich Felker [Mon, 15 Oct 2012 22:51:53 +0000 (18:51 -0400)]
add support for TLS variant I, presently needed for arm and mips
despite documentation that makes it sound a lot different, the only
ABI-constraint difference between TLS variants II and I seems to be
that variant II stores the initial TLS segment immediately below the
thread pointer (i.e. the thread pointer points to the end of it) and
variant I stores the initial TLS segment above the thread pointer,
requiring the thread descriptor to be stored below. the actual value
stored in the thread pointer register also tends to have per-arch
random offsets applied to it for silly micro-optimization purposes.
with these changes applied, TLS should be basically working on all
supported archs except microblaze. I'm still working on getting the
necessary information and a working toolchain that can build TLS
binaries for microblaze, but in theory, static-linked programs with
TLS and dynamic-linked programs where only the main executable uses
TLS should already work on microblaze.
alignment constraints have not yet been heavily tested, so it's
possible that this code does not always align TLS segments correctly
on archs that need TLS variant I.
Rich Felker [Mon, 15 Oct 2012 15:42:46 +0000 (11:42 -0400)]
block uid/gid changes during posix_spawn
usage of vfork creates a situation where a process of lower privilege
may momentarily have write access to the memory of a process of higher
privilege.
consider the case of a multi-threaded suid program which is calling
posix_spawn in one thread while another thread drops the elevated
privileges then runs untrusted (relative to the elevated privilege)
code as the original invoking user. this untrusted code can then
potentially modify the data the child process will use before calling
exec, for example changing the pathname or arguments that will be
passed to exec.
note that if vfork is implemented as fork, the lock will not be held
until the child execs, but since memory is not shared it does not
matter.
Rich Felker [Mon, 15 Oct 2012 01:10:44 +0000 (21:10 -0400)]
fix overlap of thread stacks with thread tls segments
Rich Felker [Sun, 14 Oct 2012 23:56:50 +0000 (19:56 -0400)]
fix main program TLS alignment for dynamic-linked programs
this change brings the behavior in line with the static-linked code,
which seems to be correct.
Rich Felker [Sun, 14 Oct 2012 03:53:18 +0000 (23:53 -0400)]
workaround broken hidden-visibility handling in pcc
with this change, pcc-built musl libc.so seems to work correctly. the
problem is that pcc generates GOT lookups for external-linkage symbols
even if they are hidden, rather than using GOT-relative addressing.
the entire reason we're using hidden visibility on the __libc object
is to make it accessible prior to relocations -- not to mention
inexpensive to access. unfortunately, the workaround makes it even
more expensive on pcc.
when the pcc issue is fixed, an appropriate version test should be
added so new pcc can use the much more efficient variant.
Rich Felker [Sun, 14 Oct 2012 03:46:51 +0000 (23:46 -0400)]
ensure pointer decay in inline-asm arg for i386 syscall6
this is actually a rather subtle issue: do arrays decay to pointers
when used as inline asm args? gcc says yes, but currently pcc says no.
hopefully this discrepency in pcc will be fixed, but since the
behavior is not clearly defined anywhere I can find, I'm using an
explicit operation to cause the decay to occur.
Rich Felker [Sun, 14 Oct 2012 03:25:20 +0000 (23:25 -0400)]
fix namespace clash (libc) in dynlink.c
this makes it so the #undef libc and __libc name are no longer needed,
which were problematic because the "accessor function" mode for
accessing the libc struct could not be used, breaking build on any
compiler without (working) visibility.
Rich Felker [Sun, 14 Oct 2012 03:23:29 +0000 (23:23 -0400)]
remove dead code from dynamic linker