Szabolcs Nagy [Sun, 9 Mar 2014 18:29:41 +0000 (19:29 +0100)]
math.h: make __FLOAT_BITS and __DOUBLE_BITS C89
Remove non-constant aggregate initializer. (Still using long long, but
that is supported by ancient compilers without __extension__ anyway).
Rich Felker [Sun, 9 Mar 2014 07:09:49 +0000 (03:09 -0400)]
fix incorrect rounding in printf floating point corner cases
the printf floating point formatting code contains an optimization to
avoid computing digits that will be thrown away by rounding at the
specified (or default) precision. while it was correctly retaining all
places up to the last decimal place to be printed, it was not
retaining enough precision to see the next nonzero decimal place in
all cases. this could cause incorrect rounding down in round-to-even
(default) rounding mode, for example, when printing 0.5+DBL_EPSILON
with "%.0f".
in the fix, LDBL_MANT_DIG/3 is a lazy (non-sharp) upper bound on the
number of zeros between any two nonzero decimal digits.
Rich Felker [Sun, 9 Mar 2014 06:38:52 +0000 (01:38 -0500)]
fix buffer overflow in printf formatting of denormals with low bit set
empirically the overflow was an off-by-one, and it did not seem to be
overwriting meaningful data. rather than simply increasing the buffer
size by one, however, I have attempted to make the size obviously
correct in terms of bounds on the number of iterations for the loops
that fill the buffer. this still results in no more than a negligible
size increase of the buffer on the stack (6-7 32-bit slots) and is a
"safer" fix unless/until somebody wants to do the proof that a smaller
buffer would suffice.
Rich Felker [Sat, 8 Mar 2014 05:50:19 +0000 (00:50 -0500)]
in sys/procfs.h, avoid using __WORDSIZE macro
this was problematic because several archs don't define __WORDSIZE. we
could add it, but I would rather phase this macro out in the long
term. in our version of the headers, UINTPTR_MAX is available here, so
just use it instead.
Rich Felker [Sat, 8 Mar 2014 05:14:33 +0000 (00:14 -0500)]
add bits/user.h for sh port
this seems to have been overlooked, and resulted in breakage in
anything including sys/user.h.
Rich Felker [Sat, 8 Mar 2014 04:56:48 +0000 (23:56 -0500)]
in fcntl, use unsigned long instead of long for variadic argument type
neither is correct; different commands take different argument types,
and some take no arguments at all. I have a much larger overhaul of
fcntl prepared to address this, but it's not appropriate to commit
during freeze.
the immediate problem being addressed affects forward-compatibility on
x32: if new commands are added and they take pointers, but the
libc-level fcntl function is not aware of them, using long would
sign-extend the pointer to 64 bits and give the kernel an invalid
pointer. on the kernel side, the argument to fcntl is always treated
as unsigned long, so no harm is done by treating possibly-signed
integer arguments as unsigned. for every command that takes an integer
argument except for F_SETOWN, large integer arguments and negative
arguments are handled identically anyway. in the case of F_SETOWN, the
kernel is responsible for converting the argument which it received as
unsigned long to int, so the sign of negative arguments is recovered.
the other problem that will be addressed later is that the type passed
to va_arg does not match the type in the caller of fcntl. an advanced
compiler doing cross-translation-unit analysis could potentially see
this mismatch and issue warnings or otherwise make trouble.
on i386, this patch was confirmed not to alter the code generated by
gcc 4.7.3. in principle the generated code should not be affected on
any arch except x32.
Rich Felker [Thu, 6 Mar 2014 23:59:51 +0000 (18:59 -0500)]
update copyright dates to 2014
rofl0r [Wed, 5 Mar 2014 23:26:03 +0000 (00:26 +0100)]
x32: fix sysinfo()
the kernel uses long longs in the struct, but the documentation
says they're long. so we need to fixup the mismatch between the
userspace and kernelspace structs.
since the struct offers a mem_unit member, we can avoid truncation
by adjusting that value.
Rich Felker [Wed, 5 Mar 2014 21:08:56 +0000 (16:08 -0500)]
fix strerror on mips: one error code is out of the 8-bit table range
if we ever encounter other targets where error codes don't fit in the
8-bit range, the table should probably just be bumped to 16-bit, but
for now I don't want to increase the table size on all archs just
because of a bug in the mips abi.
Rich Felker [Fri, 28 Feb 2014 18:12:40 +0000 (13:12 -0500)]
improve configure's target arch matching
most notably, it was failing to match sh4-*, etc., but in general the
explicit matching of hyphens for some archs was problematic because it
failed to accept simply the musl-style arch name (without a gcc-style
tuple) as an input. the original motivation of matching hyphens was to
prevent incorrectly identifying a 64-bit arch as the corresponding
32-bit arch (e.g. mips* matching mips64) but this is easily fixed by
simply checking (and for now, rejecting as unsupported) the relevant
64-bit archs.
Rich Felker [Fri, 28 Feb 2014 05:09:55 +0000 (00:09 -0500)]
fix missing CFLAGS in configure test for float on sh
Rich Felker [Fri, 28 Feb 2014 04:55:04 +0000 (23:55 -0500)]
fix copy-and-paste error in configure's IEEE double check for sh
Rich Felker [Fri, 28 Feb 2014 04:18:42 +0000 (23:18 -0500)]
add nofpu subarchs to the sh arch, and properly detect compiler's fpu config
Rich Felker [Fri, 28 Feb 2014 03:20:44 +0000 (22:20 -0500)]
fix endian subarchs for sh arch
default endianness for sh on linux is little, and while conventions
vary, "eb" seems to be the most widely used suffix for big endian.
Rich Felker [Fri, 28 Feb 2014 03:03:25 +0000 (22:03 -0500)]
rename superh port to "sh" for consistency
linux, gcc, etc. all use "sh" as the name for the superh arch. there
was already some inconsistency internally in musl: the dynamic linker
was searching for "ld-musl-sh.path" as its path file despite its own
name being "ld-musl-superh.so.1". there was some sentiment in both
directions as to how to resolve the inconsistency, but overall "sh"
was favored.
Rich Felker [Tue, 25 Feb 2014 18:05:38 +0000 (13:05 -0500)]
fix readdir not to set ENOENT when directory is removed while reading
per POSIX, ENOENT is reserved for invalid stream position; it is an
optional error and would only happen if the application performs
invalid seeks on the underlying file descriptor. however, linux's
getdents syscall also returns ENOENT if the directory was removed
between the time it was opened and the time of the read. we need to
catch this case and remap it to simple end-of-file condition (null
pointer return value like an error, but no change to errno). this
issue reportedly affects GNU make in certain corner cases.
rather than backing up and restoring errno, I've just changed the
syscall to be made in a way that doesn't affect errno (via an inline
syscall rather than a call to the __getdents function). the latter
still exists for the purpose of providing the public getdents alias
which sets errno.
Szabolcs Nagy [Mon, 24 Feb 2014 23:28:31 +0000 (00:28 +0100)]
in.h: new IP_MTU_DISCOVER mode IP_PMTUDISC_INTERFACE
introduced in linux v3.13,
482fc6094afad572a4ea1fd722e7b11ca72022a0
to mitigate dns cache poisoning via fragmentation
Szabolcs Nagy [Mon, 24 Feb 2014 23:24:05 +0000 (00:24 +0100)]
if_ether.h: new ethernet protocol type
for High-availability Seamless Redundancy (HSR) specified in IEC 62439-3
new in linux v3.13,
f421436a591d34fa5279b54a96ac07d70250cc8d
Szabolcs Nagy [Mon, 24 Feb 2014 23:22:04 +0000 (00:22 +0100)]
sys/socket.h: add the SO_MAX_PACING_RATE SOL_SOCKET option
introduced in linux v3.13,
62748f32d501f5d3712a7c372bbb92abc7c62bc7
Szabolcs Nagy [Mon, 24 Feb 2014 23:17:29 +0000 (00:17 +0100)]
elf.h: add aarch64 relocations
Szabolcs Nagy [Mon, 24 Feb 2014 23:12:39 +0000 (00:12 +0100)]
elf.h: new elf header flag to mark 2008-NaN vs legacy-NaN on mips
see glibc commit
9c21573c02446b3d5cf6a34b67c8545e5be6a600
Rich Felker [Mon, 24 Feb 2014 22:31:00 +0000 (17:31 -0500)]
add missing sub files for mipsel-sf to use softfloat code
the build system has no automatic way to know this code applies to
both big (default) and little endian variants, so explicit .sub files
are needed.
Szabolcs Nagy [Mon, 24 Feb 2014 22:16:29 +0000 (23:16 +0100)]
mips: add mips-sf subarch support (soft-float)
Userspace emulated floating-point (gcc -msoft-float) is not compatible
with the default mips abi (assumes an FPU or in kernel emulation of it).
Soft vs hard float abi should not be mixed, __mips_soft_float is checked
in musl's configure script and there is no runtime check. The -sf subarch
does not save/restore floating-point registers in setjmp/longjmp and only
provides dummy fenv implementation.
rofl0r [Mon, 24 Feb 2014 21:49:42 +0000 (22:49 +0100)]
fixup general __syscall breakage introduced in x32 port
the reordering of headers caused some risc archs to not see
the __syscall declaration anymore.
this caused build errors on mips with any compiler,
and on arm and microblaze with clang.
we now declare it locally just like the powerpc port does.
Rich Felker [Mon, 24 Feb 2014 04:20:18 +0000 (23:20 -0500)]
make the x32 port use the correct ld-musl-x32.path filename
previously it was wrongly using the x86_64 one, precluding having both
x32 and x86_64 libs present on the same system.
Bobby Bingham [Sat, 5 Oct 2013 10:13:18 +0000 (05:13 -0500)]
superh port
rofl0r [Sun, 23 Feb 2014 19:46:30 +0000 (20:46 +0100)]
fix x32 syscall arch.h timespec fixup code
it's legal to call the __syscall functions with more arguments than
necessary, and the __syscall_cp cancel dummy impl. does just that.
thus we must insert the switch for all possible syscalls numbers
into all of the syscallN inline functions.
rofl0r [Sun, 23 Feb 2014 15:36:43 +0000 (16:36 +0100)]
fix some issues in x32 syscall_cp_fixup
- the nanosleep fixup "fixed" the second timespec* argument erroneusly.
- the futex fixup was missing the check for FUTEX_WAIT.
- general cleanup using a macro.
Rich Felker [Sun, 23 Feb 2014 10:43:09 +0000 (05:43 -0500)]
mostly-cosmetic fixups to x32 port merge
rofl0r [Wed, 8 Jan 2014 02:11:46 +0000 (03:11 +0100)]
configure: suppress bogus pointer-int cast warnings
rofl0r [Tue, 7 Jan 2014 22:30:30 +0000 (23:30 +0100)]
configure: recognize x86_64-x32 and x32
x32 is the internal arch name, but glibc uses x86_64-x32.
there doesn't exist a specific triple for x32 in gcc and binutils.
you're supposed to build your compiler for x86_64 and configure
it with multilib support for "mx32".
however it turns out that using a triple of x86_64-x32 makes
gcc and binutils pick up the right arch (they detect it as x86_64)
and allows us to have a unique triple for cross-compiler toolchains.
rofl0r [Tue, 7 Jan 2014 21:53:38 +0000 (22:53 +0100)]
x32 port (diff against vanilla x86_64)
rofl0r [Tue, 7 Jan 2014 21:43:34 +0000 (22:43 +0100)]
import vanilla x86_64 code as x32
rofl0r [Sat, 11 Jan 2014 12:41:50 +0000 (13:41 +0100)]
sys/shm.h: move arch specific structs to bits/
rofl0r [Tue, 7 Jan 2014 23:04:29 +0000 (00:04 +0100)]
sys/sem.h: cheat and make all longs use time_t instead
most of the members should be time_t anyway, and time_t has the
correct semantics for "syscall_long", so it works on all archs, even x32.
rofl0r [Tue, 7 Jan 2014 23:26:34 +0000 (00:26 +0100)]
use syscall_arg_t type for syscall prototypes in pthread code
rofl0r [Tue, 7 Jan 2014 15:49:23 +0000 (16:49 +0100)]
internal/syscall.h: add syscall_arg_t macro
some 32-on-64 archs require that the actual syscall args be long long.
in that case syscall_arch.h can define syscall_arg_t to whatever it needs
and syscall.h picks it up.
all other archs just use long as usual.
rofl0r [Tue, 7 Jan 2014 02:31:34 +0000 (03:31 +0100)]
internal/syscall.h: use a macro for the syscall args casts
this allows syscall_arch.h to define the macro __scc if special
casting is needed, as is the case for x32, where the actual syscall
arguments are 64bit, but, in case of pointers, would get sign-extended
and thus become invalid.
Rich Felker [Sat, 22 Feb 2014 03:25:26 +0000 (22:25 -0500)]
add fallback emulation for accept4 on old kernels
the other atomic FD_CLOEXEC interfaces (dup3, pipe2, socket) already
had such emulation in place. the justification for doing the emulation
here is the same as for the other functions: it allows applications to
simply use accept4 rather than having to have their own fallback code
for ENOSYS/EINVAL (which one you get is arch-specific!) and there is
no reasonable way an application could benefit from knowing the
operation is emulated/non-atomic since there is no workaround at the
application level for non-atomicity (that is the whole reason these
interfaces were added).
Rich Felker [Tue, 18 Feb 2014 16:04:15 +0000 (11:04 -0500)]
add flock64 alias for (struct) flock in fcntl.h
this was a missing part of the LFS64 API; it's "needed" for use with
fcntl and the corresponding lock commands.
Rich Felker [Thu, 13 Feb 2014 17:27:40 +0000 (12:27 -0500)]
add ipv6 and icmpv6 to getprotoent-family functions
based on patch by orc.
Rich Felker [Thu, 13 Feb 2014 17:24:40 +0000 (12:24 -0500)]
fix typo in table for getprotoent that caused out-of-bound reads
this was unlikely to lead to any crash or dangerous behavior, but
caused adjacent string constants to be treated as part of the
protocols table, possibly returning nonsensical results for unknown
protocol names/numbers or when getprotoent was called in a loop to
enumerate all protocols.
Rich Felker [Wed, 12 Feb 2014 06:03:07 +0000 (01:03 -0500)]
make posix_spawn accept null pid pointer arguments
this is a requirement in the specification that was overlooked.
Szabolcs Nagy [Tue, 11 Feb 2014 17:02:06 +0000 (18:02 +0100)]
add parens when bit and arith ops are mixed in macros in public headers
another commit to silence gcc warnings (-Wparentheses) for standard headers.
changed macros: LOG_UPTO, IN6_ARE_ADDR_EQUAL
Szabolcs Nagy [Tue, 11 Feb 2014 09:51:16 +0000 (10:51 +0100)]
fix signed and unsigned comparision in macros in public headers
gcc -Wsign-compare warns about expanded macros that were defined in
standard headers (before gcc 4.8) which can make builds fail that
use -Werror. changed macros: WIFSIGNALED, __CPU_op_S
Bobby Bingham [Fri, 7 Feb 2014 04:11:22 +0000 (22:11 -0600)]
clone: make clone a wrapper around __clone
The architecture-specific assembly versions of clone did not set errno on
failure, which is inconsistent with glibc. __clone still returns the error
via its return value, and clone is now a wrapper that sets errno as needed.
The public clone has also been moved to src/linux, as it's not directly
related to the pthreads API.
__clone is called by pthread_create, which does not report errors via
errno. Though not strictly necessary, it's nice to avoid clobbering errno
here.
Szabolcs Nagy [Sun, 9 Feb 2014 17:39:53 +0000 (18:39 +0100)]
fix fesetenv(FE_DFL_ENV) on x86_64 (see previous commit)
Szabolcs Nagy [Sun, 9 Feb 2014 17:19:03 +0000 (18:19 +0100)]
fix fesetenv(FE_DFL_ENV) on i386
the default fenv was not set up properly, in particular the
tag word that indicates the contents of the x87 registers was
set to 0 (used) instead of 0xffff (empty)
this could cause random crashes after setting the default fenv
because it corrupted the fpu stack and then any float computation
gives NaN result breaking the program logic (usually after a
float to integer conversion).
Rich Felker [Fri, 7 Feb 2014 06:16:53 +0000 (01:16 -0500)]
in fdopen, avoid setting O_APPEND flag if it's already set
this saves a syscall in the case where the underlying open already
took place with O_APPEND, which is common because fopen with append
modes sets O_APPEND at the time of open before passing the file
descriptor to __fdopen.
Rich Felker [Fri, 7 Feb 2014 05:57:50 +0000 (00:57 -0500)]
fix ftello result for append streams with unflushed output
when there is unflushed output, ftello (and ftell) compute the logical
stream position as the underlying file descriptor's offset plus an
adjustment for the amount of buffered data. however, this can give the
wrong result for append-mode streams where the unflushed writes should
adjust the logical position to be at the end of the file, as if a seek
to end-of-file takes place before the write.
the solution turns out to be a simple trick: when ftello (indirectly)
calls lseek to determine the current file offset, use SEEK_END instead
of SEEK_CUR if the stream is append-mode and there's unwritten
buffered data.
the ISO C rules regarding switching between reading and writing for a
stream opened in an update mode, along with the POSIX rules regarding
switching "active handles", conveniently leave undefined the
hypothetical usage cases where this fix might lead to observably
incorrect offsets.
the bug being fixed was discovered via the test case for glibc issue
Rich Felker [Wed, 5 Feb 2014 22:25:39 +0000 (17:25 -0500)]
reduce namespace pollution in netinet/udp.h
the affected part of the header is responsible for providing both GNU
and BSD versions of the udphdr structure. previously, the
namespace-polluting GNU names were always used for the actual struct
members, and the BSD names, which are named in a manner resembling a
sane namespace, were always macros defined to expand to the GNU names.
now, unless _GNU_SOURCE is defined, the BSD names are used as the
actual structure members, and the macros and GNU names only come into
play when the application requests them.
Rich Felker [Wed, 5 Feb 2014 22:22:26 +0000 (17:22 -0500)]
fix use of legacy u_intN_t types in netinet/tcp.h
policy is to avoid using these types except where they are needed for
namespace conformance. C99-style stdint.h types should be used
instead.
Rich Felker [Wed, 5 Feb 2014 21:55:30 +0000 (16:55 -0500)]
add support for BSD struct tcphdr in netinet/tcp.h
there are two versions of this structure: the BSD version and the GNU
version. previously only the GNU version was supported. the only way
to support both simultaneously is with an anonymous union, which was a
nonstandard extension prior to C11, so some effort is made to avoid
breakage with compilers which do not support anonymous unions.
this commit is based on a patch by Timo Teräs, but with some changes.
in particular, the GNU version of the structure is not exposed unless
_GNU_SOURCE is defined; this both avoids namespace pollution and
dependency on anonymous unions in the default feature profile.
Rich Felker [Wed, 5 Feb 2014 21:34:23 +0000 (16:34 -0500)]
add nonstandard timespec/timeval conversion macros in sys/time.h
these are poorly designed (illogical argument order) and even poorly
implemented (brace issues) on glibc, but unfortunately some software
is using them. we could consider removing them again in the future at
some point if they're documented as deprecated, but for now the
simplest thing to do is just to provide them under _GNU_SOURCE.
Timo Teräs [Mon, 13 Jan 2014 11:36:03 +0000 (13:36 +0200)]
add NO_ADDRESS macro to netdb.h as an alias for NO_DATA
some applications expect it to be defined, despite the standard making
it impossible for it to ever be returned as a value distinct from
NO_DATA. since these macros are outside the scope of the current
standards, no special effort is made to hide NO_ADDRESS under
conditions where the others are exposed.
Timo Teräs [Mon, 13 Jan 2014 11:05:14 +0000 (13:05 +0200)]
add legacy functions setkey() and encrypt()
Rich Felker [Sat, 1 Feb 2014 19:33:33 +0000 (14:33 -0500)]
fix nftw FTW_MOUNT flag
the incorrect check for crossing device boundaries was preventing nftw
from traversing anything except the initially provided pathname.
Szabolcs Nagy [Thu, 23 Jan 2014 02:24:54 +0000 (03:24 +0100)]
fix an overflow in wcsxfrm when n==0
posix allows zero length destination
Rich Felker [Tue, 21 Jan 2014 06:06:42 +0000 (01:06 -0500)]
add version.h to .gitignore; it is a generated file
Rich Felker [Tue, 21 Jan 2014 05:36:35 +0000 (00:36 -0500)]
fix crash in dynamic linker when certain copy relocations are unsatisfied
STB_WEAK is only a weak reference for undefined symbols (those with a
section of SHN_UNDEF). otherwise, it's a weak definition. normally
this distinction would not matter, since a relocation referencing a
symbol that also provides a definition (not SHN_UNDEF) will always
succeed in finding the referenced symbol itself. however, in the case
of copy relocations, the referenced symbol itself is ignored in order
to search for another symbol to copy from, and thus it's possible that
no definition is found. in this case, if the symbol being resolved
happened to be a weak definition, it was misinterpreted as a weak
reference, suppressing the error path and causing a crash when the
copy relocation was performed with a null source pointer passed to
memcpy.
there are almost certainly still situations in which invalid
combinations of symbol and relocation types can cause the dynamic
linker to crash (this is pretty much inevitable), but the intent is
that crashes not be possible for symbol/relocation tables produced by
a valid linker.
Szabolcs Nagy [Tue, 21 Jan 2014 01:01:35 +0000 (02:01 +0100)]
fix initstate to make the state buffer usable in setstate
setstate could use the results of previous initstate or setstate
calls (they return the old state buffer), but the documentation
requires that an initialized state buffer should be possible to
use in setstate immediately, which means that initstate should
save the generator parameters in it.
I also removed the copyright notice since it is present in the
copyright file.
Rich Felker [Thu, 16 Jan 2014 03:29:13 +0000 (22:29 -0500)]
fix system breakage window during make install due to permissions
install.sh was wrongly waiting until after atomically replacing the
old file to set the correct permissions on the new file. in the case
of the dynamic linker, this would cause a dynamic-linked chmod command
not to run (due to missing executable permissions on the dynamic
linker) and thus leave the system in an unusable state.
even if chmod is static-linked, the old behavior had a race window
where dynamic-linked programs could fail to run.
Rich Felker [Thu, 16 Jan 2014 02:48:44 +0000 (21:48 -0500)]
remove more unnecessary operand-size suffixes from x86_64 atomic.h
Rich Felker [Sun, 12 Jan 2014 00:37:09 +0000 (19:37 -0500)]
remove gratuitous temp vars, casts, and suffixes in x86_64 atomic.h
aside from general cleanup, this should allow the identical atomic.h
file to be used for the upcoming x32 port.
Rich Felker [Sat, 11 Jan 2014 16:23:10 +0000 (11:23 -0500)]
remove size suffix in x86_64 __pthread_self asm
the operand size is unnecessary, since the assembler knows it from the
destination register size. removing the suffix makes it so the same
code should work for x32.
Rich Felker [Sat, 11 Jan 2014 16:20:01 +0000 (11:20 -0500)]
make type of st_dev explicitly dev_t in x86_64 stat.h
otherwise it's unclear that it's correct. aside from that, it makes
for a gratuitous difference between the x86_64 header and the upcoming
x32 header.
Rich Felker [Thu, 9 Jan 2014 00:39:18 +0000 (19:39 -0500)]
fix namespace violation in sys/shm.h
in fixing this, I've changed the logic from ugly #if/#else blocks
inside the struct shm_info definition to a fixed struct definition and
optional macros to rename the elements. this will be helpful if we
need to move shm_info to a bits header in the future, as it will keep
the feature test logic out of bits.
Rich Felker [Thu, 9 Jan 2014 00:36:29 +0000 (19:36 -0500)]
fix namespace violations in utmpx.h
Rich Felker [Thu, 9 Jan 2014 00:27:56 +0000 (19:27 -0500)]
add IUTF8 to termios.h on archs that were missing it
Rich Felker [Thu, 9 Jan 2014 00:20:55 +0000 (19:20 -0500)]
fix namespace violations in termios.h, at least mostly
the fix should be complete on archs that use the generic definitions
(i386, arm, x86_64, microblaze), but mips and powerpc have not been
checked thoroughly and may need more fixes.
Rich Felker [Wed, 8 Jan 2014 23:54:33 +0000 (18:54 -0500)]
fix remaining known namespace violations for netinet/in.h
the imr_, imsf_, ip6_, ip6m_, ipi_, ipi6_, SCM_, and SOL_ prefixes are
not in the reserved namespace for this header. thus the constants and
structures using them need to be protected under appropriate feature
test macros.
this also affects some headers which are permitted to include
netinet/in.h, particularly netdb.h and arpa/inet.h.
the SOL_ macros are moved to sys/socket.h where they are in the
reserved namespace (SO*). they are still accessible via netinet/in.h
since it includes sys/socket.h implicitly (which is permitted).
the SCM_SRCRT macro is simply removed, since the definition used for
it, IPV6_RXSRCRT is not defined anywhere. it could be re-added, this
time in sys/socket.h, if the appropriate value can be determined;
however, given that the erroneous definition was not caught, it is
unlikely that any software actually attempts to use SCM_SRCRT.
Rich Felker [Wed, 8 Jan 2014 22:37:05 +0000 (17:37 -0500)]
fix inadvertent use of struct in place of union for semun
Szabolcs Nagy [Wed, 8 Jan 2014 21:52:26 +0000 (22:52 +0100)]
add __isoc99_vfscanf weak alias to vfscanf
this glibc abi compatibility function was missed when the scanf
aliases were added.
Szabolcs Nagy [Wed, 8 Jan 2014 21:51:46 +0000 (22:51 +0100)]
math: add drem and dremf weak aliases to i386 remainder asm
weak_alias was only in the c code, so drem was missing on platforms
where remainder is implemented in asm.
Rich Felker [Wed, 8 Jan 2014 21:12:47 +0000 (16:12 -0500)]
fix type of semctl variadic argument
per POSIX, the variadic argument has type union semun, which may
contain a pointer or int; the type read depends on the command being
issued. this allows the userspace part of the implementation to be
type-correct without requiring special-casing for different commands.
the kernel always expects to receive the argument interpreted as
unsigned long (or equivalently, a pointer), and does its own handling
of extracting the int portion from the representation, as needed.
this change fixes two possible issues: most immediately, reading the
argument as a (signed) long and passing it to the syscall would
perform incorrect sign-extension of pointers on the upcoming x32
target. the other possible issue is that some archs may use different
(user-space) argument-passing convention for unions, preventing va_arg
from correctly obtaining the argument when the type long (or even
unsigned long or void *) is passed to it.
Rich Felker [Wed, 8 Jan 2014 07:18:06 +0000 (02:18 -0500)]
in fcntl, avoid passing pointer arguments to syscalls as longs
really, fcntl should be changed to use the correct type corresponding
to cmd when calling va_arg, and to carry the correct type through
until making the syscall. however, this greatly increases binary size
and does not seem to offer any benefits except formal correctness, so
I'm holding off on that change for now.
the minimal changes made in this patch are in preparation for addition
of the x32 port, where the syscall macros need to know whether their
arguments are pointers or integers in order to properly pass them to
the 64-bit kernel.
Rich Felker [Tue, 7 Jan 2014 08:02:14 +0000 (03:02 -0500)]
fix const-correctness of argument to stime
it's unclear what the historical signature for this function was, but
semantically, the argument should be a pointer to const, and this is
what glibc uses. correct programs should not be using this function
anyway, so it's unlikely to matter.
Rich Felker [Tue, 7 Jan 2014 07:58:28 +0000 (02:58 -0500)]
fix signedness of pgoff argument to remap_file_pages
both the kernel and glibc agree that this argument is unsigned; the
incorrect type ssize_t came from erroneous man pages.
Rich Felker [Tue, 7 Jan 2014 07:50:34 +0000 (02:50 -0500)]
fix const-correctness in sigandset/sigorset arguments
this change is consistent with the corresponding glibc functions and
is semantically const-correct. the incorrect argument types without
const seem to have been taken from erroneous man pages.
Rich Felker [Tue, 7 Jan 2014 07:44:47 +0000 (02:44 -0500)]
remove sys/sysctl.h
this functionality has essentially always been deprecated in linux,
and was never supported by musl. the presence of the header was
reported to cause some software to attempt to use the nonexistant
function, so removing the header is the cleanest solution.
Rich Felker [Tue, 7 Jan 2014 07:41:27 +0000 (02:41 -0500)]
fix incorrect type for wd argument of inotify_rm_watch
this was wrong since the original commit adding inotify, and I don't
see any explanation for it. not even the man pages have it wrong. it
was most likely a copy-and-paste error.
Rich Felker [Tue, 7 Jan 2014 03:17:24 +0000 (22:17 -0500)]
fix argument types for legacy function inet_makeaddr
the type int was taken from seemingly erroneous man pages. glibc uses
in_addr_t (uint32_t), and semantically, the arguments should be
unsigned.
Rich Felker [Tue, 7 Jan 2014 03:05:54 +0000 (22:05 -0500)]
eliminate explicit (long) casts when making syscalls
this practice came from very early, before internal/syscall.h defined
macros that could accept pointer arguments directly and handle them
correctly. aside from being ugly and unnecessary, it looks like it
will be problematic when we add support for 32-bit ABIs on archs where
registers (and syscall arguments) are 64-bit, e.g. x32 and mips n32.
Rich Felker [Tue, 7 Jan 2014 03:03:38 +0000 (22:03 -0500)]
const-qualify the address argument to dladdr
this agrees with implementation practice on glibc and BSD systems, and
is the const-correct way to do things; it eliminates warnings from
passing pointers to const. the prototype without const came from
seemingly erroneous man pages.
Rich Felker [Tue, 7 Jan 2014 02:31:17 +0000 (21:31 -0500)]
add some missing LFS64 aliases for fadvise/fallocate functions
Rich Felker [Fri, 3 Jan 2014 19:33:44 +0000 (14:33 -0500)]
release 0.9.15
rofl0r [Fri, 3 Jan 2014 10:27:46 +0000 (11:27 +0100)]
fanotify.c: fix typo in header inclusion
the header is included only as a guard to check that the declaration
and definition match, so the typo didn't cause any breakage aside
from omitting this check.
Rich Felker [Thu, 2 Jan 2014 22:13:19 +0000 (17:13 -0500)]
disable the brk function
the reasons are the same as for sbrk. unlike sbrk, there is no safe
usage because brk does not return any useful information, so it should
just fail unconditionally.
Rich Felker [Thu, 2 Jan 2014 22:03:34 +0000 (17:03 -0500)]
disable sbrk for all values of increment except 0
use of sbrk is never safe; it conflicts with malloc, and malloc may be
used internally by the implementation basically anywhere. prior to
this change, applications attempting to use sbrk to do their own heap
management simply caused untrackable memory corruption; now, they will
fail with ENOMEM allowing the errors to be fixed.
sbrk(0) is still permitted as a way to get the current brk; some
misguided applications use this as a measurement of their memory
usage or for other related purposes, and such usage is harmless.
eventually sbrk may be re-added if/when malloc is changed to avoid
using the brk by using mmap for all allocations.
rofl0r [Thu, 2 Jan 2014 21:10:45 +0000 (22:10 +0100)]
add fanotify syscall wrapper and header
Timo Teräs [Wed, 25 Dec 2013 11:33:46 +0000 (13:33 +0200)]
fix struct signalfd_siginfo
ssi_ptr is really 64-bit in kernel, so fix that. assuming sizeof(void*)
for it also caused incorrect padding for 32-bits, as the following
64-bits are aligned to 64-bits (and the padding was not taken into
account), so fix the padding as well. add addr_lsb field while there.
Rich Felker [Fri, 20 Dec 2013 16:56:16 +0000 (11:56 -0500)]
implement legacy function herror
based on patch by Timo Teräs; greatly simplified to use fprintf.
Rich Felker [Fri, 20 Dec 2013 16:52:10 +0000 (11:52 -0500)]
add sys/quota.h and quotactl syscall wrapper
based on patch by Timo Teräs.
Rich Felker [Fri, 20 Dec 2013 16:42:03 +0000 (11:42 -0500)]
add netinet/igmp.h and multicast groups to netinet/in.h
based on patch by Timo Teräs.
Timo Teräs [Wed, 18 Dec 2013 11:53:11 +0000 (13:53 +0200)]
add TCP_INFO and TCP_MD5SIG socket option related structures
Rich Felker [Thu, 19 Dec 2013 19:24:55 +0000 (14:24 -0500)]
fix failure of fchmod, fstat, fchdir, and fchown to produce EBADF
the workaround/fallback code for supporting O_PATH file descriptors
when the kernel lacks support for performing these operations on them
caused EBADF to get replaced by ENOENT (due to missing entry in
/proc/self/fd). this is unlikely to affect real-world code (calls that
might yield EBADF are generally unsafe, especially in library code)
but it was breaking some test cases.
the fix I've applied is something of a tradeoff: it adds one syscall
to these operations on kernels where the workaround is needed. the
alternative would be to catch ENOENT from the /proc lookup and
translate it to EBADF, but I want to avoid doing that in the interest
of not touching/depending on /proc at all in these functions as long
as the kernel correctly supports the operations. this is following the
general principle of isolating hacks to code paths that are taken on
broken systems, and keeping the code for correct systems completely
hack-free.
Rich Felker [Thu, 19 Dec 2013 10:05:13 +0000 (05:05 -0500)]
fix hangs in localtime for near-overflowing time_t values on 64-bit archs
Rich Felker [Sun, 15 Dec 2013 00:51:48 +0000 (19:51 -0500)]
fix dynamic linker entry point for microblaze
the ABI allows the callee to clobber stack slots that correspond to
arguments passed in registers, so the caller must adjust the stack
pointer to reserve space appropriately. prior to this fix, the argv
array was possibly clobbered by dynamic linker code before passing
control to the main program.
Rich Felker [Fri, 13 Dec 2013 07:25:09 +0000 (02:25 -0500)]
optimize get_current_dir_name to reduce stack bloat
our getcwd already (as an extension) supports allocation of a buffer
when the buffer argument is a null pointer, so there's no need to
duplicate the allocation logic in this wrapper function. duplicating
it is actually harmful in that it doubles the stack usage from
PATH_MAX to 2*PATH_MAX.
Rich Felker [Fri, 13 Dec 2013 07:20:07 +0000 (02:20 -0500)]
use 0 instead of NULL for null pointer constants
and thereby remove otherwise-unnecessary inclusion of stddef.h