oweals/musl.git
12 years agoremove -std=gnu99 from musl-gcc wrapper
Rich Felker [Sat, 18 Feb 2012 04:51:23 +0000 (23:51 -0500)]
remove -std=gnu99 from musl-gcc wrapper

while probably desirable, changing the default language variant is
outside the scope of the wrapper's responsibility.

12 years agotwo fixes for "make install" handling of shared libs
Rich Felker [Sat, 18 Feb 2012 04:17:48 +0000 (23:17 -0500)]
two fixes for "make install" handling of shared libs

1. don't try to install (and thus build) shared libs when they were
disabled in config.mak

2. ensure that the path for the dynamic linker exists before
attempting to install it.

12 years agoadd get_current_dir_name function
Rich Felker [Sat, 18 Feb 2012 04:10:00 +0000 (23:10 -0500)]
add get_current_dir_name function

12 years agoadd float_t and double_t to math.h
Rich Felker [Thu, 16 Feb 2012 02:47:55 +0000 (21:47 -0500)]
add float_t and double_t to math.h

12 years agofix default nameserver when resolv.conf doesn't exist
Rich Felker [Sat, 11 Feb 2012 05:06:32 +0000 (00:06 -0500)]
fix default nameserver when resolv.conf doesn't exist

12 years agofix illegal goto out of cleanup context in dns lookups
Rich Felker [Sat, 11 Feb 2012 05:05:58 +0000 (00:05 -0500)]
fix illegal goto out of cleanup context in dns lookups

12 years agosmall fix for new pthread cleanup stuff
Rich Felker [Fri, 10 Feb 2012 02:24:56 +0000 (21:24 -0500)]
small fix for new pthread cleanup stuff

even if pthread_create/exit code is not linked, run flag needs to be
checked and cleanup function potentially run on pop. thus, move the
code to the module that's always linked when pthread_cleanup_push/pop
is used.

12 years agoreplace bad cancellation cleanup abi with a sane one
Rich Felker [Thu, 9 Feb 2012 07:33:08 +0000 (02:33 -0500)]
replace bad cancellation cleanup abi with a sane one

the old abi was intended to duplicate glibc's abi at the expense of
being ugly and slow, but it turns out glib was not even using that abi
except on non-gcc-compatible compilers (which it doesn't even support)
and was instead using an exceptions-in-c/unwind-based approach whose
abi we could not duplicate anyway without nasty dwarf2/unwind
integration.

the new abi is copied from a very old glibc abi, which seems to still
be supported/present in current glibc. it avoids all unwinding,
whether by sjlj or exceptions, and merely maintains a linked list of
cleanup functions to be called from the context of pthread_exit. i've
made some care to ensure that longjmp out of a cleanup function should
work, even though it is not required to.

this change breaks abi compatibility with programs which were using
pthread cancellation, which is unfortunate, but that's why i'm making
the change now rather than later. considering that most pthread
features have not been usable until recently anyway, i don't see it as
a major issue at this point.

12 years agodocument iswspace and remove wrongly-included zwsp character
Rich Felker [Thu, 9 Feb 2012 05:27:19 +0000 (00:27 -0500)]
document iswspace and remove wrongly-included zwsp character

12 years agofix typo in iswspace space list table
Rich Felker [Thu, 9 Feb 2012 05:20:24 +0000 (00:20 -0500)]
fix typo in iswspace space list table

12 years agofix typo in inotify.h
Rich Felker [Wed, 8 Feb 2012 03:48:58 +0000 (22:48 -0500)]
fix typo in inotify.h

12 years agoprotect against cancellation in dlopen
Rich Felker [Wed, 8 Feb 2012 01:31:27 +0000 (20:31 -0500)]
protect against cancellation in dlopen

i'm not sure that it's "correct" for dlopen to block cancellation
when calling constructors for libraries it loads, but it sure seems
like the right thing. in any case, dlopen itself needs cancellation
blocked.

12 years agoreduce some wasted space in dso structure
Rich Felker [Wed, 8 Feb 2012 01:29:29 +0000 (20:29 -0500)]
reduce some wasted space in dso structure

12 years agodeclare basename in string.h when _GNU_SOURCE is defined
Rich Felker [Tue, 7 Feb 2012 18:10:30 +0000 (13:10 -0500)]
declare basename in string.h when _GNU_SOURCE is defined

note that it still will have the standards-conformant behavior, not
the GNU behavior. but at least this prevents broken code from ending
up with truncated pointers due to implicit declarations...

12 years agorevert hacks for types of stdint.h integer constant macros
Rich Felker [Tue, 7 Feb 2012 17:08:27 +0000 (12:08 -0500)]
revert hacks for types of stdint.h integer constant macros

per 7.18.4: Each invocation of one of these macros shall expand to an
integer constant expression suitable for use in #if preprocessing
directives. The type of the expression shall have the same type as
would an expression of the corresponding type converted according to
the integer promotions. The value of the expression shall be that of
the argument.

the key phrase is "converted according to the integer promotions".
thus there is no intent or allowance that the expression have
smaller-than-int types.

12 years agomore locale_t interfaces (string stuff) and header updates
Rich Felker [Tue, 7 Feb 2012 02:51:02 +0000 (21:51 -0500)]
more locale_t interfaces (string stuff) and header updates

this should be everything except for some functions where the non-_l
version isn't even implemented yet (mainly some non-ISO-C wcs*
functions).

12 years agofix some omissions and mistakes in locale_t interface definitions
Rich Felker [Tue, 7 Feb 2012 02:33:40 +0000 (21:33 -0500)]
fix some omissions and mistakes in locale_t interface definitions

12 years agoadd more of the locale_t interfaces, all dummied out to ignore the locale
Rich Felker [Tue, 7 Feb 2012 02:29:31 +0000 (21:29 -0500)]
add more of the locale_t interfaces, all dummied out to ignore the locale

12 years agox86_64 vfork implementation
Rich Felker [Mon, 6 Feb 2012 23:23:11 +0000 (18:23 -0500)]
x86_64 vfork implementation

untested; should work.

12 years agorun ctors/dtors for shared objects loaded with dlopen
Rich Felker [Mon, 6 Feb 2012 22:57:29 +0000 (17:57 -0500)]
run ctors/dtors for shared objects loaded with dlopen

12 years agoadd support for init/finit (constructors and destructors)
Rich Felker [Mon, 6 Feb 2012 19:39:09 +0000 (14:39 -0500)]
add support for init/finit (constructors and destructors)

this is mainly in hopes of supporting c++ (not yet possible for other
reasons) but will also help applications/libraries which use (and more
often, abuse) the gcc __attribute__((__constructor__)) feature in "C"
code.

x86_64 and arm versions of the new startup asm are untested and may
have minor problems.

12 years agoadd deprecated (removed from posix) [efg]cvt() functions
Rich Felker [Mon, 6 Feb 2012 06:14:23 +0000 (01:14 -0500)]
add deprecated (removed from posix) [efg]cvt() functions

these have not been heavily tested, but they should work as described
in the old standards. probably broken for non-finite values...

12 years agoinclude dummied-out dlopen and dlsym functions for static binaries
Rich Felker [Fri, 3 Feb 2012 08:16:07 +0000 (03:16 -0500)]
include dummied-out dlopen and dlsym functions for static binaries

these don't work (or do anything at all) but at least make it possible
to static link programs that insist on "having" dynamic loading
support...as long as they don't actually need to use it.

adding real support for dlopen/dlsym with static linking is going to
be significantly more difficult...

12 years agoimprove gcc wrapper to support -nostdlib, -nostartfiles
Rich Felker [Fri, 3 Feb 2012 04:54:46 +0000 (23:54 -0500)]
improve gcc wrapper to support -nostdlib, -nostartfiles

12 years agomake stdio open, read, and write operations cancellation points
Rich Felker [Thu, 2 Feb 2012 05:11:29 +0000 (00:11 -0500)]
make stdio open, read, and write operations cancellation points

it should be noted that only the actual underlying buffer flush and
fill operations are cancellable, not reads from or writes to the
buffer. this behavior is compatible with POSIX, which makes all
cancellation points in stdio optional, and it achieves the goal of
allowing cancellation of a thread that's "stuck" on IO (due to a
non-responsive socket/pipe peer, slow/stuck hardware, etc.) without
imposing any measurable performance cost.

12 years agomake passwd/group functions safe against cancellation in stdio
Rich Felker [Thu, 2 Feb 2012 04:51:19 +0000 (23:51 -0500)]
make passwd/group functions safe against cancellation in stdio

these changes are a prerequisite to making stdio cancellable.

12 years agoapparently gnu caddr_t is supposed to be char *, not unsigned long
Rich Felker [Wed, 1 Feb 2012 19:12:19 +0000 (14:12 -0500)]
apparently gnu caddr_t is supposed to be char *, not unsigned long

this type should never be used anyway, but some old junk uses it..

12 years agofix utmp.h mess, try 2
Rich Felker [Wed, 1 Feb 2012 19:10:38 +0000 (14:10 -0500)]
fix utmp.h mess, try 2

12 years agofix previous utmp.h junk commit
Rich Felker [Tue, 31 Jan 2012 22:10:02 +0000 (17:10 -0500)]
fix previous utmp.h junk commit

12 years agoadd some missing junk in utmp.h
Rich Felker [Tue, 31 Jan 2012 19:39:17 +0000 (14:39 -0500)]
add some missing junk in utmp.h

12 years agoadd fgetpwent (nonstandard function)
Rich Felker [Sun, 29 Jan 2012 16:54:18 +0000 (11:54 -0500)]
add fgetpwent (nonstandard function)

based on patch by Jeremy Huntwork

12 years agoadd linux setfs[ug]id syscall wrappers
Rich Felker [Sun, 29 Jan 2012 02:09:50 +0000 (21:09 -0500)]
add linux setfs[ug]id syscall wrappers

patch by Jeremy Huntwork

12 years agoremove useless "extern" keywords in headers
Rich Felker [Thu, 26 Jan 2012 15:53:37 +0000 (10:53 -0500)]
remove useless "extern" keywords in headers

12 years agofix typo in FPE_FLTUND definition, signal.h
Rich Felker [Wed, 25 Jan 2012 20:30:42 +0000 (15:30 -0500)]
fix typo in FPE_FLTUND definition, signal.h

12 years agoadd MIN/MAX macros to sys/param.h
Rich Felker [Wed, 25 Jan 2012 03:51:27 +0000 (22:51 -0500)]
add MIN/MAX macros to sys/param.h

this is a nonstandard junk header anyway, so just do what apps expect..

12 years agoadd legacy futimes and lutimes functions
Rich Felker [Wed, 25 Jan 2012 00:50:44 +0000 (19:50 -0500)]
add legacy futimes and lutimes functions

based on patch by sh4rm4. these functions are deprecated; futimens and
utimensat should be used instead in new programs.

12 years agomake gcc wrapper support -shared correctly
Rich Felker [Tue, 24 Jan 2012 05:22:27 +0000 (00:22 -0500)]
make gcc wrapper support -shared correctly

it was previously attempting to link start files as part of shared
objects. this is definitely wrong and depending on the platform and
linker could range from just adding extraneous junk to introducing
textrels to making linking fail entirely.

12 years agomake glob mark symlinks-to-directories with the GLOB_MARK flag
Rich Felker [Tue, 24 Jan 2012 00:51:34 +0000 (19:51 -0500)]
make glob mark symlinks-to-directories with the GLOB_MARK flag

POSIX is unclear on whether it should, but all historical
implementations seem to behave this way, and it seems more useful to
applications.

12 years agofix broken copy relocations from dynamic linker cleanup
Rich Felker [Mon, 23 Jan 2012 23:32:40 +0000 (18:32 -0500)]
fix broken copy relocations from dynamic linker cleanup

this issue affected programs which use global variables exported by
non-libc libraries.

12 years agodynamic linker support for PIE binaries (position-independent main program)
Rich Felker [Mon, 23 Jan 2012 07:02:59 +0000 (02:02 -0500)]
dynamic linker support for PIE binaries (position-independent main program)

even with this change, PIE will not work yet due to deficiencies in
the crt1.o startup code.

12 years agocleanup dynamic linker, removing some code duplication
Rich Felker [Mon, 23 Jan 2012 05:57:38 +0000 (00:57 -0500)]
cleanup dynamic linker, removing some code duplication

12 years agoupdate release notes for 0.8.4 v0.8.4
Rich Felker [Mon, 23 Jan 2012 05:37:45 +0000 (00:37 -0500)]
update release notes for 0.8.4

12 years agofix cancellation failure in single-threaded programs
Rich Felker [Sun, 22 Jan 2012 22:19:37 +0000 (17:19 -0500)]
fix cancellation failure in single-threaded programs

even a single-threaded program can be cancellable, e.g. if it's called
pthread_cancel(pthread_self()). the correct predicate to check is not
whether multiple threads have been invoked, but whether pthread_self
has been invoked.

12 years agosupport GLOB_PERIOD flag (GNU extension) to glob function
Rich Felker [Sun, 22 Jan 2012 20:49:42 +0000 (15:49 -0500)]
support GLOB_PERIOD flag (GNU extension) to glob function

patch by sh4rm4

12 years agoupdate WHATSNEW in preparation for 0.8.4 (not finished)
Rich Felker [Sun, 22 Jan 2012 16:37:27 +0000 (11:37 -0500)]
update WHATSNEW in preparation for 0.8.4 (not finished)

12 years agouse prlimit syscall for getrlimit/setrlimit
Rich Felker [Sat, 21 Jan 2012 03:30:52 +0000 (22:30 -0500)]
use prlimit syscall for getrlimit/setrlimit

this allows the full range of 64-bit limit arguments even on 32-bit
systems. fallback to the old syscalls on old kernels that don't
support prlimit.

12 years agoadd prlimit syscall wrapper
Rich Felker [Sat, 21 Jan 2012 03:10:47 +0000 (22:10 -0500)]
add prlimit syscall wrapper

12 years agofix dynamic linker not to depend on DYNAMIC ptr in 0th entry of GOT
Rich Felker [Fri, 20 Jan 2012 16:14:27 +0000 (11:14 -0500)]
fix dynamic linker not to depend on DYNAMIC ptr in 0th entry of GOT

this fixes an issue using gold instead of gnu ld for linking. it also
should eliminate the need of the startup code to even load/pass the
got address to the dynamic linker.

based on patch submitted by sh4rm4 with minor cosmetic changes.

further cleanup will follow.

12 years agoalias basename to glibc name for it, to meet abi goals
Rich Felker [Thu, 19 Jan 2012 04:28:48 +0000 (23:28 -0500)]
alias basename to glibc name for it, to meet abi goals

note that regardless of the name used, basename is always conformant.
it never takes on the bogus gnu behavior, unlike glibc where basename
is nonconformant when declared manually without including libgen.h.

12 years agofix char signedness bug in dynlinker hash function
Rich Felker [Tue, 17 Jan 2012 05:34:58 +0000 (00:34 -0500)]
fix char signedness bug in dynlinker hash function

this only affects non-ascii symbol names, which are probably not in
use anyway..

12 years agofix broken reboot wrapper (syscall needs extra silly magic arguments...)
Rich Felker [Sat, 24 Dec 2011 00:13:48 +0000 (19:13 -0500)]
fix broken reboot wrapper (syscall needs extra silly magic arguments...)

13 years agofix issue with excessive mremap syscalls on realloc
Rich Felker [Thu, 17 Nov 2011 04:59:28 +0000 (23:59 -0500)]
fix issue with excessive mremap syscalls on realloc

CHUNK_SIZE macro was defined incorrectly and shaving off at least one
significant bit in the size of mmapped chunks, resulting in the test
for oldlen==newlen always failing and incurring a syscall. fortunately
i don't think this issue caused any other observable behavior; the
definition worked correctly for all non-mmapped chunks where its
correctness matters more, since their lengths are always multiples of
the alignment.

13 years agofix __cplusplus extern "C" closing brace in pty.h (typo?)
Rich Felker [Fri, 11 Nov 2011 02:01:24 +0000 (21:01 -0500)]
fix __cplusplus extern "C" closing brace in pty.h (typo?)

13 years agofix signed overflows at most-negative values in ato(i|l|ll)
Rich Felker [Fri, 11 Nov 2011 01:44:44 +0000 (20:44 -0500)]
fix signed overflows at most-negative values in ato(i|l|ll)

patch by Pascal Cuoq (with minor tweaks to comments)

13 years agofix all missing instances of __cplusplus checks/extern "C" in headers
Rich Felker [Fri, 11 Nov 2011 01:40:06 +0000 (20:40 -0500)]
fix all missing instances of __cplusplus checks/extern "C" in headers

patch by Arvid Picciani (aep)

13 years agoreport sem value overflows in sem_post
Rich Felker [Wed, 26 Oct 2011 04:28:47 +0000 (00:28 -0400)]
report sem value overflows in sem_post

this is not required by the standard, but it's nicer than corrupting
the state and rather inexpensive.

13 years agoadd some missing GNU FNM_* extensions to the header
Rich Felker [Mon, 17 Oct 2011 16:24:23 +0000 (12:24 -0400)]
add some missing GNU FNM_* extensions to the header

note that none of these are implemented, and programs depending on
them may break... patch by sh4rm4

13 years agofix some details in ugly stuff that doesn't belong in libc
Rich Felker [Mon, 17 Oct 2011 16:23:04 +0000 (12:23 -0400)]
fix some details in ugly stuff that doesn't belong in libc

patches by sh4rm4, presumably needed to make gdb or some similar junk
happy...

13 years agodon't define wchar_t on c++
Rich Felker [Sat, 15 Oct 2011 04:28:49 +0000 (00:28 -0400)]
don't define wchar_t on c++

it's a keyword in c++ (wtf). i'm not sure this is the cleanest
solution; it might be better to avoid ever defining __NEED_wchar_t on
c++. but in any case, this works for now.

13 years agosupport vfork on i386
Rich Felker [Sat, 15 Oct 2011 03:56:31 +0000 (23:56 -0400)]
support vfork on i386

13 years agomake available a namespace-safe vfork, if supported
Rich Felker [Sat, 15 Oct 2011 03:34:12 +0000 (23:34 -0400)]
make available a namespace-safe vfork, if supported

this may be useful to posix_spawn..?

13 years agoadd dummy __cxa_finalize
Rich Felker [Sat, 15 Oct 2011 03:31:04 +0000 (23:31 -0400)]
add dummy __cxa_finalize

musl's dynamic linker does not support unloading dsos, so there's
nothing for this function to do. adding the symbol in case anything
depends on its presence..

13 years agosupport __cxa_atexit, and registering atexit functions from atexit handlers
Rich Felker [Sat, 15 Oct 2011 03:21:54 +0000 (23:21 -0400)]
support __cxa_atexit, and registering atexit functions from atexit handlers

mildly tested; may have bugs. the locking should be updated not to use
spinlocks but that's outside the scope of this one module.

13 years agosimplify atexit and fflush-on-exit handling
Rich Felker [Sat, 15 Oct 2011 03:00:24 +0000 (23:00 -0400)]
simplify atexit and fflush-on-exit handling

13 years agofix F_GETOWN return value handling
Rich Felker [Mon, 10 Oct 2011 02:51:03 +0000 (22:51 -0400)]
fix F_GETOWN return value handling

the fcntl syscall can return a negative value when the command is
F_GETOWN, and this is not an error code but an actual value. thus we
must special-case it and avoid calling __syscall_ret to set errno.
this fix is better than the glibc fix (using F_GETOWN_EX) which only
works on newer kernels and is more complex.

13 years agofix typo in arm clone() asm
Rich Felker [Sun, 9 Oct 2011 04:02:39 +0000 (00:02 -0400)]
fix typo in arm clone() asm

13 years agofix fcntl O_* flags for arm
Rich Felker [Wed, 5 Oct 2011 04:26:49 +0000 (00:26 -0400)]
fix fcntl O_* flags for arm

no idea why these 4 are permuted and the rest are standard/generic

13 years agomake [U]INTn_C() macros have the right type...
Rich Felker [Tue, 4 Oct 2011 15:50:35 +0000 (11:50 -0400)]
make [U]INTn_C() macros have the right type...

...and still be valid in #if directives.

13 years agorecovering ownerdead robust mutex must reset recursive lock count
Rich Felker [Mon, 3 Oct 2011 04:27:47 +0000 (00:27 -0400)]
recovering ownerdead robust mutex must reset recursive lock count

13 years agosimplify robust mutex unlock code path
Rich Felker [Mon, 3 Oct 2011 04:19:05 +0000 (00:19 -0400)]
simplify robust mutex unlock code path

right now it's questionable whether this change is an improvement or
not, but if we later want to support priority inheritance mutexes, it
will be important to have the code paths unified like this to avoid
major code duplication.

13 years agofix crash if pthread_mutex_unlock is called without ever locking
Rich Felker [Mon, 3 Oct 2011 04:11:16 +0000 (00:11 -0400)]
fix crash if pthread_mutex_unlock is called without ever locking

this is valid for error-checking mutexes; otherwise it invokes UB and
would be justified in crashing.

13 years agouse count=0 instead of 1 for recursive mutex with only one lock reference
Rich Felker [Mon, 3 Oct 2011 04:09:08 +0000 (00:09 -0400)]
use count=0 instead of 1 for recursive mutex with only one lock reference

this simplifies the code paths slightly, but perhaps what's nicer is
that it makes recursive mutexes fully reentrant, i.e. locking and
unlocking from a signal handler works even if the interrupted code was
in the middle of locking or unlocking.

13 years agosysconf for PTHREAD_KEYS_MAX
Rich Felker [Mon, 3 Oct 2011 04:03:19 +0000 (00:03 -0400)]
sysconf for PTHREAD_KEYS_MAX

13 years agosynchronize cond var destruction with exiting waits
Rich Felker [Mon, 3 Oct 2011 02:58:28 +0000 (22:58 -0400)]
synchronize cond var destruction with exiting waits

13 years agofix failure-to-wake in rwlock unlock
Rich Felker [Sat, 1 Oct 2011 13:11:35 +0000 (09:11 -0400)]
fix failure-to-wake in rwlock unlock

a reader unlocking the lock need only wake one waiter (necessarily a
writer, but a writer unlocking the lock must wake all waiters
(necessarily readers). if it only wakes one, the remainder can remain
blocked indefinitely, or at least until the first reader unlocks (in
which case the whole lock becomes serialized and behaves as a mutex
rather than a read lock).

13 years agodlsym entry point for arm
Rich Felker [Sat, 1 Oct 2011 05:35:42 +0000 (01:35 -0400)]
dlsym entry point for arm

13 years agodynamic linker entry point for arm
Rich Felker [Sat, 1 Oct 2011 05:33:31 +0000 (01:33 -0400)]
dynamic linker entry point for arm

mildly tested, seems to work

13 years agotypo (copy 2) in arm reloc.h
Rich Felker [Sat, 1 Oct 2011 04:55:16 +0000 (00:55 -0400)]
typo (copy 2) in arm reloc.h

13 years agotypo in arm reloc.h
Rich Felker [Sat, 1 Oct 2011 04:54:43 +0000 (00:54 -0400)]
typo in arm reloc.h

13 years agofirst attempt at arm dynamic linking
Rich Felker [Sat, 1 Oct 2011 04:52:33 +0000 (00:52 -0400)]
first attempt at arm dynamic linking

13 years agofix various bugs in path and error handling in execvp/fexecve
Rich Felker [Thu, 29 Sep 2011 04:48:04 +0000 (00:48 -0400)]
fix various bugs in path and error handling in execvp/fexecve

13 years agodon't crash on null strings in printf
Rich Felker [Thu, 29 Sep 2011 02:07:58 +0000 (22:07 -0400)]
don't crash on null strings in printf

passing null pointer for %s is UB but lots of broken programs do it anyway

13 years agofix excessive/insufficient wakes in __vm_unlock
Rich Felker [Wed, 28 Sep 2011 23:45:37 +0000 (19:45 -0400)]
fix excessive/insufficient wakes in __vm_unlock

there is no need to send a wake when the lock count does not hit zero,
but when it does, all waiters must be woken (since all with the same
sign are eligible to obtain the lock).

13 years agomake getmntent_r discard long lines when it returns error, not seek back
Rich Felker [Wed, 28 Sep 2011 23:37:14 +0000 (19:37 -0400)]
make getmntent_r discard long lines when it returns error, not seek back

seeking back can be performed by the caller, but if the caller doesn't
expect it, it will result in an infinite loop of failures.

13 years agoimprove pshared barriers
Rich Felker [Wed, 28 Sep 2011 22:57:18 +0000 (18:57 -0400)]
improve pshared barriers

eliminate the sequence number field and instead use the counter as the
futex because of the way the lock is held, sequence numbers are
completely useless, and this frees up a field in the barrier structure
to be used as a waiter count for the count futex, which lets us avoid
some syscalls in the best case.

as of now, self-synchronized destruction and unmapping should be fully
safe. before any thread can return from the barrier, all threads in
the barrier have obtained the vm lock, and each holds a shared lock on
the barrier. the barrier memory is not inspected after the shared lock
count reaches 0, nor after the vm lock is released.

13 years agonext step making barrier self-sync'd destruction safe
Rich Felker [Wed, 28 Sep 2011 22:00:02 +0000 (18:00 -0400)]
next step making barrier self-sync'd destruction safe

i think this works, but it can be simplified. (next step)

13 years agobarrier destroy must also wait for threads in other processes exiting barrier
Rich Felker [Wed, 28 Sep 2011 16:47:15 +0000 (12:47 -0400)]
barrier destroy must also wait for threads in other processes exiting barrier

the vm lock only waits for threads in the same process exiting.
actually this fix is not enough, but it's a start...

13 years agostupid typo (caused by rather ugly spelling in POSIX..) in aio
Rich Felker [Wed, 28 Sep 2011 15:36:11 +0000 (11:36 -0400)]
stupid typo (caused by rather ugly spelling in POSIX..) in aio

13 years agocorrectly handle the degenerate barrier in the pshared case
Rich Felker [Wed, 28 Sep 2011 03:08:59 +0000 (23:08 -0400)]
correctly handle the degenerate barrier in the pshared case

13 years agofix crash in pthread_cond_wait mutex-locked check
Rich Felker [Tue, 27 Sep 2011 22:56:29 +0000 (18:56 -0400)]
fix crash in pthread_cond_wait mutex-locked check

it was assuming the result of the condition it was supposed to be
checking for, i.e. that the thread ptr had already been initialized by
pthread_mutex_lock. use the slower call to be safe.

13 years agofix crash in pthread_testcancel if pthread_self has not been called
Rich Felker [Tue, 27 Sep 2011 22:39:49 +0000 (18:39 -0400)]
fix crash in pthread_testcancel if pthread_self has not been called

13 years agoimprove/debloat mutex unlock error checking in pthread_cond_wait
Rich Felker [Tue, 27 Sep 2011 22:22:31 +0000 (18:22 -0400)]
improve/debloat mutex unlock error checking in pthread_cond_wait

we're not required to check this except for error-checking mutexes,
but it doesn't hurt. the new test is actually simpler/lighter, and it
also eliminates the need to later check that pthread_mutex_unlock
succeeds.

13 years agocheck mutex owner in pthread_cond_wait
Rich Felker [Tue, 27 Sep 2011 22:17:27 +0000 (18:17 -0400)]
check mutex owner in pthread_cond_wait

when used with error-checking mutexes, pthread_cond_wait is required
to fail with EPERM if the mutex is not locked by the caller.
previously we relied on pthread_mutex_unlock to generate the error,
but this is not valid, since in the case of such invalid usage the
internal state of the cond variable has already been potentially
corrupted (due to access outside the control of the mutex). thus, we
have to check first.

13 years agofix pshared barrier wrong return value.
Rich Felker [Tue, 27 Sep 2011 21:03:44 +0000 (17:03 -0400)]
fix pshared barrier wrong return value.

i set the return value but then never used it... oops!

13 years agoconvert the barrier pshared option back to 0/1 values when getting it
Rich Felker [Tue, 27 Sep 2011 21:02:19 +0000 (17:02 -0400)]
convert the barrier pshared option back to 0/1 values when getting it

13 years agoimprove error handling in mntent stuff...
Rich Felker [Tue, 27 Sep 2011 21:00:38 +0000 (17:00 -0400)]
improve error handling in mntent stuff...

not sure if this is correct/ideal. it needs further attention.

13 years agofix missing va_end in prctl syscall wrapper
Rich Felker [Tue, 27 Sep 2011 20:47:00 +0000 (16:47 -0400)]
fix missing va_end in prctl syscall wrapper

13 years agofix clobbering of errno in get(pw|gr)([ug]id|nam) by fclose
Rich Felker [Tue, 27 Sep 2011 20:45:29 +0000 (16:45 -0400)]
fix clobbering of errno in get(pw|gr)([ug]id|nam) by fclose

13 years agoprocess-shared barrier support, based on discussion with bdonlan
Rich Felker [Tue, 27 Sep 2011 17:50:29 +0000 (13:50 -0400)]
process-shared barrier support, based on discussion with bdonlan

this implementation is rather heavy-weight, but it's the first
solution i've found that's actually correct. all waiters actually wait
twice at the barrier so that they can synchronize exit, and they hold
a "vm lock" that prevents changes to virtual memory mappings (and
blocks pthread_barrier_destroy) until all waiters are finished
inspecting the barrier.

thus, it is safe for any thread to destroy and/or unmap the barrier's
memory as soon as pthread_barrier_wait returns, without further
synchronization.

13 years agofix incorrect allocation failure check in pthread_create
Rich Felker [Tue, 27 Sep 2011 16:18:44 +0000 (12:18 -0400)]
fix incorrect allocation failure check in pthread_create

mmap returns MAP_FAILED not 0 because some idiot thought the ability
to mmap the null pointer page would be a good idea...