Rich Felker [Thu, 12 Jul 2012 04:14:40 +0000 (00:14 -0400)]
fix mips mcontext_t structure size
otherwise offs in ucontext_t will be wrong, and break code that
inspects or modifies the signal makes (including cancellation code).
Rich Felker [Thu, 12 Jul 2012 03:36:46 +0000 (23:36 -0400)]
fix potential race condition in detached threads
after the thread unmaps its own stack/thread structure, the kernel,
performing child tid clear and futex wake, could clobber a new mapping
made at the same location as the just-removed thread's tid field.
disable kernel clearing of child tid to prevent this.
Rich Felker [Thu, 12 Jul 2012 03:01:09 +0000 (23:01 -0400)]
mips clone: don't free stack space used to copy arg
the mips abi reserves stack space equal to the size of the in-register
args for the callee to save the args, if desired. this would cause the
beginning of the thread structure to be clobbered...
Rich Felker [Thu, 12 Jul 2012 02:59:43 +0000 (22:59 -0400)]
fix mips clone() on real linux kernel
the old code worked in qemu app-level emulation, but not on real
kernels where the clone syscall does not copy the register values to
the new thread. save arguments on the new thread stack instead.
Rich Felker [Thu, 12 Jul 2012 02:29:57 +0000 (22:29 -0400)]
fix MAP_ANONYMOUS value for mips, remove cruft copied from i386
Rich Felker [Thu, 12 Jul 2012 00:44:38 +0000 (20:44 -0400)]
fix clone() on mips (args were in wrong order)
with this change, threads on mips seem to be working
Rich Felker [Wed, 11 Jul 2012 15:35:27 +0000 (11:35 -0400)]
first attempt at making threads work on mips
Rich Felker [Wed, 11 Jul 2012 15:34:46 +0000 (11:34 -0400)]
generic c version of __set_thread_area for archs where it works
on other archs, like x86[_64], asm version is required
Rich Felker [Wed, 11 Jul 2012 08:22:13 +0000 (04:22 -0400)]
initial version of mips (o32) port, based on work by Richard Pennington (rdp)
basically, this version of the code was obtained by starting with
rdp's work from his ellcc source tree, adapting it to musl's build
system and coding style, auditing the bits headers for discrepencies
with kernel definitions or glibc/LSB ABI or large file issues, fixing
up incompatibility with the old binutils from aboriginal linux, and
adding some new special cases to deal with the oddities of sigaction
and pipe syscall interfaces on mips.
at present, minimal test programs work, but some interfaces are broken
or missing. threaded programs probably will not link.
Rich Felker [Wed, 11 Jul 2012 07:20:43 +0000 (03:20 -0400)]
remove unused var in new sigaction code
Rich Felker [Wed, 11 Jul 2012 06:48:12 +0000 (02:48 -0400)]
use unsigned bitmask for consistency in ksigaction
the type doesn't actually matter, just the size, but it's nice to be
consistent...
Rich Felker [Wed, 11 Jul 2012 06:44:55 +0000 (02:44 -0400)]
fix breakage from last commit: forgot to include ksigaction.h
this file can be overridden by a same-named file in an arch dir.
Rich Felker [Wed, 11 Jul 2012 06:44:14 +0000 (02:44 -0400)]
changes to kernel sigaction struct handling in preparation for mips port
Rich Felker [Wed, 11 Jul 2012 05:47:30 +0000 (01:47 -0400)]
make dynamic linker depend on -DSHARED not -fPIC
if libc.a is compiled PIC for use in static PIE code, this should not
cause the dynamic linker (which still does not support static-linked
main program) to be built into libc.a.
Rich Felker [Wed, 11 Jul 2012 05:41:20 +0000 (01:41 -0400)]
fix lots of breakage on dlopen, mostly with explicit pathnames
most importantly, the name for such libs was being set from an
uninitialized buffer. also, shortname always had an initial '/'
character, making it useless for looking up already-loaded libraries
by name, and thus causing repeated searches through the library path.
major changes now:
- shortname is the base name for library lookups with no explicit
pathname. it's initially clear for libraries loaded with an explicit
pathname (and for the main program), but will be set if the same
library (detected via inodes match) is later found by a search.
- exact name match is never used to identify libraries loaded with an
explicit pathname. in this case, there's no explicit search, so we
can just stat the file and check for inode match.
Rich Felker [Tue, 10 Jul 2012 05:18:40 +0000 (01:18 -0400)]
support -mfpmath=387 on x86_64
apparently somebody wants this for something... and it doesn't hurt.
Rich Felker [Tue, 10 Jul 2012 04:59:58 +0000 (00:59 -0400)]
fix wrong value of FLT_EVAL_METHOD for x86_64
Rich Felker [Mon, 9 Jul 2012 01:32:45 +0000 (21:32 -0400)]
make arm syscalls (still non-inline) more efficient
no need to pass zero for unused arguments; just omit them.
Rich Felker [Sun, 8 Jul 2012 04:05:08 +0000 (00:05 -0400)]
remove little-endian assumption from arm atomic.h
this hidden endian dependency had left big endian arm badly broken.
Rich Felker [Sat, 7 Jul 2012 20:32:27 +0000 (16:32 -0400)]
fix dlsym RTLD_NEXT support
previously this was being handled the same as a library-specific,
dependency-order lookup on the next library in the global chain, which
is likely to be utterly meaningless. instead the lookup needs to be in
the global namespace, but omitting the initial portion of the global
library chain up through the calling library.
Rich Felker [Wed, 4 Jul 2012 16:21:22 +0000 (12:21 -0400)]
putw is supposed to return 0 (not the value written) on success
this is not a standard but it's the traditional behavior and it's more
useful because the caller can reliably detect errors.
Rich Felker [Wed, 4 Jul 2012 16:18:46 +0000 (12:18 -0400)]
make sure getw/putw agree with prototypes by defining _GNU_SOURCE
Rich Felker [Wed, 4 Jul 2012 16:18:04 +0000 (12:18 -0400)]
add prototypes for getw/putw
Rich Felker [Wed, 4 Jul 2012 03:53:05 +0000 (23:53 -0400)]
configure: only use -ffloat-store on i386
this option is expensive and only used on old gcc's that lack
-fexcess-precision=standed, but it's not needed on non-i386 archs
where floating point does not have excess precision anyway.
if musl ever supports m68k, i think it will need to be special-cased
too. i'm not aware of any other archs with excess precision.
Rich Felker [Wed, 4 Jul 2012 00:07:33 +0000 (20:07 -0400)]
jmp_buf overhaul fixing several issues
on arm, the location of the saved-signal-mask flag and mask were off
by one between sigsetjmp and siglongjmp, causing incorrect behavior
restoring the signal mask. this is because the siglongjmp code assumed
an extra slot was in the non-sig jmp_buf for the flag, but arm did not
have this. now, the extra slot is removed for all archs since it was
useless.
also, arm eabi requires jmp_buf to have 8-byte alignment. we achieve
that using long long as the type rather than with non-portable gcc
attribute tags.
Rich Felker [Tue, 3 Jul 2012 02:49:25 +0000 (22:49 -0400)]
fix sigsetjmp on arm (needs asm)
no idea why gcc refuses to compile the C code to use a tail call, but
it's best to use asm anyway so we don't have to rely on the quality of
the compiler's optimizations for correct code.
Rich Felker [Tue, 3 Jul 2012 02:48:56 +0000 (22:48 -0400)]
fix missing function declarations for __stdio_exit
Rich Felker [Tue, 3 Jul 2012 00:25:28 +0000 (20:25 -0400)]
fix missing prototype and simplify sincosl on ld64 archs
Rich Felker [Tue, 3 Jul 2012 00:22:50 +0000 (20:22 -0400)]
fix invalid implicit pointer conversion in ld64 modfl
Rich Felker [Fri, 29 Jun 2012 04:56:37 +0000 (00:56 -0400)]
replace old and ugly crypt implementation
the new version is largely the work of Solar Designer, with minor
changes for integration with musl. compared to the old code, text size
is reduced by about 7k, stack space usage by about 70k, and
performance is greatly improved by avoiding expensive calculation of
constant tables on each run.
this version also adds support for extended des-based password hashes,
which allow for unlimited key (password) length and configurable
iteration counts.
i've also published the interface for crypt_r in a new crypt.h header.
especially since this is not a standard interface, i did not feel
compelled to match the glibc abi for the crypt_data structure. the
glibc structure is way too big to allocate on the stack; in fact it's
so big that the first usage may cause the main thread to exceed its
pre-committed stack size of 128k and thus could cause the program to
crash even on systems with overcommit disabled. the only legitimate
use of crypt_data for crypt_r is to store the hash string to return,
so i've reserved 256 bytes, which should be more than sufficient
(longest known password hashes are ~60 characters, and beyond that is
possibly even exceeding some implementations' passwd file field size
limit).
Rich Felker [Mon, 25 Jun 2012 20:06:09 +0000 (16:06 -0400)]
fix arm crti/crtn code
lr must be saved because init/fini-section code from the compiler
clobbers it. this was not a problem when i tested without gcc's
crtbegin/crtend files present, but with them, musl on arm fails to
work (infinite loop in _init).
Rich Felker [Mon, 25 Jun 2012 01:00:57 +0000 (21:00 -0400)]
release notes for 0.9.2
Rich Felker [Sun, 24 Jun 2012 01:38:47 +0000 (21:38 -0400)]
add process_vm_readv and process_vm_writev syscall wrappers
based on a patch submitted by Kristian L. <email@thexception.net>
Rich Felker [Sun, 24 Jun 2012 01:16:44 +0000 (21:16 -0400)]
update syscall defs to latest kernel ones
patch submitted by Kristian L. <email@thexception.net>
Rich Felker [Thu, 21 Jun 2012 02:16:47 +0000 (22:16 -0400)]
proper error handling for fcntl F_GETOWN on modern kernels
on old kernels, there's no way to detect errors; we must assume
negative syscall return values are pgrp ids. but if the F_GETOWN_EX
fcntl works, we can get a reliable answer.
nsz [Wed, 20 Jun 2012 21:25:58 +0000 (23:25 +0200)]
math: fix fma bug on x86 (found by Bruno Haible with gnulib)
The long double adjustment was wrong:
The usual check is
mant_bits & 0x7ff == 0x400
before doing a mant_bits++ or mant_bits-- adjustment since
this is the only case when rounding an inexact ld80 into
double can go wrong. (only in nearest rounding mode)
After such a check the ++ and -- is ok (the mantissa will end
in 0x401 or 0x3ff).
fma is a bit different (we need to add 3 numbers with correct
rounding: hi_xy + lo_xy + z so we should survive two roundings
at different places without precision loss)
The adjustment in fma only checks for zero low bits
mant_bits & 0x3ff == 0
this way the adjusted value is correct when rounded to
double or *less* precision.
(this is an important piece in the fma puzzle)
Unfortunately in this case the -- is not a correct adjustment
because mant_bits might underflow so further checks are needed
and this was the source of the bug.
Rich Felker [Wed, 20 Jun 2012 19:22:03 +0000 (15:22 -0400)]
fix broken wcwidth tables
unicode char data has both "W" and "F" wide types and the old table
only included the "W" ones. this omitted U+3000 (ideographic space)
and all the wide-ascii, etc.
Rich Felker [Wed, 20 Jun 2012 19:15:10 +0000 (15:15 -0400)]
support ld80 pseudo-denormal invalid bit patterns; treat them as nan
this is silly, but it makes apps that read binary junk and interpret
it as ld80 "safer", and it gets gnulib to stop replacing printf...
Rich Felker [Wed, 20 Jun 2012 19:11:27 +0000 (15:11 -0400)]
fix ptsname_r to conform to the upcoming posix requirements
it should return the error code rather than 0/-1 and setting errno.
Rich Felker [Wed, 20 Jun 2012 19:04:47 +0000 (15:04 -0400)]
fix fwrite return value when full write does not succeed
Rich Felker [Wed, 20 Jun 2012 18:50:29 +0000 (14:50 -0400)]
avoid cancellation in pclose
at the point pclose might receive and act on cancellation, it has
already invalidated the FILE passed to it. thus, per musl's QOI
guarantees about cancellation and resource allocation/deallocation,
it's not a candidate for cancellation.
if it were required to be a cancellation point by posix, we would have
to switch the order of deallocation, but somehow still close the pipe
in order to trigger the child process to exit. i looked into doing
this, but the logic gets ugly, and i'm not sure the semantics are
conformant, so i'd rather just leave it alone unless there's a need to
change it.
Rich Felker [Wed, 20 Jun 2012 18:47:34 +0000 (14:47 -0400)]
fix invalid memory access in pclose
Rich Felker [Wed, 20 Jun 2012 18:39:50 +0000 (14:39 -0400)]
make popen cancellation-safe
close was the only cancellation point called from popen, but it left
popen with major resource leaks if any call to close got cancelled.
the easiest, cheapest fix is just to use a non-cancellable close
function.
Rich Felker [Wed, 20 Jun 2012 18:32:48 +0000 (14:32 -0400)]
popen: handle issues with fd0/1 being closed
also check for failure of dup2 and abort the child rather than
reading/writing the wrong file.
Rich Felker [Wed, 20 Jun 2012 17:48:57 +0000 (13:48 -0400)]
duplocale: don't crash when called with LC_GLOBAL_LOCALE
posix has resolved to add this usage; for now, we just avoid writing
anything to the new locale object since it's not used anyway.
Rich Felker [Wed, 20 Jun 2012 16:07:18 +0000 (12:07 -0400)]
make strerror_r behave nicer on failure
if the buffer is too short, at least return a partial string. this is
helpful if the caller is lazy and does not check for failure. care is
taken to avoid writing anything if the buffer length is zero, and to
always null-terminate when the buffer length is non-zero.
Rich Felker [Wed, 20 Jun 2012 13:28:54 +0000 (09:28 -0400)]
fix another oob pointer arithmetic issue in printf floating point
this one could never cause any problems unless the compiler/machine
goes to extra trouble to break oob pointer arithmetic, but it's best
to fix it anyway.
Rich Felker [Wed, 20 Jun 2012 13:27:28 +0000 (09:27 -0400)]
minor perror behavior fix
patch by nsz
Rich Felker [Wed, 20 Jun 2012 02:44:08 +0000 (22:44 -0400)]
fix localeconv values and implementation
dynamic-allocation of the structure is not valid; it can crash an
application if malloc fails. since localeconv is not specified to have
failure conditions, the object needs to have static storage duration.
need to review whether all the values are right or not still..
Rich Felker [Wed, 20 Jun 2012 02:31:19 +0000 (22:31 -0400)]
fix mistake in length test in getlogin_r
this was actually dangerously wrong, but presumably nobody uses this
broken function anymore anyway..
Rich Felker [Wed, 20 Jun 2012 02:24:15 +0000 (22:24 -0400)]
fix dummied-out fsync
if we eventually have build options, it might be nice to make an
option to dummy this out again, in case anybody needs a system-wide
disable for disk/ssd-thrashing, etc. that some daemons do when
logging...
Rich Felker [Wed, 20 Jun 2012 02:22:16 +0000 (22:22 -0400)]
fix dummied-out fdatasync
Rich Felker [Wed, 20 Jun 2012 01:41:43 +0000 (21:41 -0400)]
fix pointer overflow bug in floating point printf
large precision values could cause out-of-bounds pointer arithmetic in
computing the precision cutoff (used to avoid expensive long-precision
arithmetic when the result will be discarded). per the C standard,
this is undefined behavior. one would expect that it works anyway, and
in fact it did in most real-world cases, but it was randomly
(depending on aslr) crashing in i386 binaries running on x86_64
kernels. this is because linux puts the userspace stack near 4GB
(instead of near 3GB) when the kernel is 64-bit, leading to the
out-of-bounds pointer arithmetic overflowing past the end of address
space and giving a very low pointer value, which then compared lower
than a pointer it should have been higher than.
the new code rearranges the arithmetic so that no overflow can occur.
while this bug could crash printf with memory corruption, it's
unlikely to have security impact in real-world applications since the
ability to provide an extremely large field precision value under
attacker-control is required to trigger the bug.
Rich Felker [Tue, 19 Jun 2012 19:32:13 +0000 (15:32 -0400)]
add vhangup syscall wrapper
request/patch by william haddonthethird, slightly modifed to add
_GNU_SOURCE feature test macro so that the compiler can verify the
prototype matches.
Rich Felker [Tue, 19 Jun 2012 19:18:22 +0000 (15:18 -0400)]
include declarations for new stdio_ext functions (gnulib support)
Rich Felker [Tue, 19 Jun 2012 05:35:23 +0000 (01:35 -0400)]
add new stdio extension functions to make gnulib happy
this is mildly ugly, but less ugly than gnulib trying to poke at the
definition of the FILE structure...
Rich Felker [Tue, 19 Jun 2012 05:27:26 +0000 (01:27 -0400)]
stdio: handle file position correctly at program exit
for seekable files, posix imposed requirements on the offset of the
underlying open file description after a stream is closed. this was
correctly handled (as a side effect of the unconditional fflush call)
when streams were explicitly closed by fclose, but was not handled
correctly at program exit time, where fflush(0) was being used.
the weak symbol hackery is to pull in __stdio_exit if either of
__toread or __towrite is used, but avoid calling it twice so we don't
have to keep extra state. the new __stdio_exit is a streamlined fflush
variant that avoids performing any unnecessary operations and which
never unlocks the files or open file list, so we can be sure no other
threads write new data to a stream's buffer after it's already
flushed.
Rich Felker [Tue, 19 Jun 2012 05:12:36 +0000 (01:12 -0400)]
minor cleanup in fflush
Rich Felker [Tue, 19 Jun 2012 04:05:35 +0000 (00:05 -0400)]
remove flush hook cruft that was never used from stdio
there is no need/use for a flush hook. the write function serves this
purpose already. i originally created the hook for implementing mem
streams based on a mistaken reading of posix, and later realized it
wasn't useful but never removed it until now.
Rich Felker [Tue, 19 Jun 2012 01:41:38 +0000 (21:41 -0400)]
fix multiple iconv bugs reading utf-16/32 and wchar_t
Rich Felker [Tue, 19 Jun 2012 00:43:21 +0000 (20:43 -0400)]
fix iconv dest utf-16: unavailable chars must be replaced; EILSEQ is wrong
Rich Felker [Tue, 19 Jun 2012 00:29:41 +0000 (20:29 -0400)]
fix erroneous utf-16 encoding with surrogates in iconv
apparently this was never tested before.
Rich Felker [Mon, 18 Jun 2012 01:24:58 +0000 (21:24 -0400)]
change stdio_ext __freading/__fwriting semantics slightly
the old behavior was to only consider a stream to be "reading" or
"writing" if it had buffered, unread/unwritten data. this reportedly
differs from the traditional behavior of these functions, which is
essentially to return true as much as possible without creating the
possibility that both __freading and __fwriting could return true.
gnulib expects __fwriting to return true as soon as a file is opened
write-only, and possibly expects other cases that depend on the
traditional behavior. and since these functions exist mostly for
gnulib (does anything else use them??), they should match the expected
behavior to avoid even more ugly hacks and workarounds...
Rich Felker [Mon, 18 Jun 2012 00:34:04 +0000 (20:34 -0400)]
fdopen should set errno when it fails due to invalid mode string
Rich Felker [Sat, 16 Jun 2012 01:52:53 +0000 (21:52 -0400)]
header file fixes: multiple include guard consistency and correctness
one file was reusing another file's macro name, and many had
inconsistent underscores and application of SYS prefix, etc.
patch by Szabolcs Nagy (nsz)
Rich Felker [Fri, 15 Jun 2012 03:58:40 +0000 (23:58 -0400)]
direct syscall to open in __init_security needs O_LARGEFILE
it probably does not matter for /dev/null, but this should be done
consistently anyway.
Rich Felker [Thu, 14 Jun 2012 12:36:06 +0000 (08:36 -0400)]
reorder exit code to defer stdio flush until after dtors
this is required in case dtors use stdio.
also remove the old comments; one was cruft from when the code used to
be using function pointers and conditional calls, and has little
motivation now that we're using weak symbols. the other was just
complaining about having to support dtors even though the cost was
made essentially zero in the non-use case by the way it's done here.
Rich Felker [Wed, 13 Jun 2012 18:46:11 +0000 (14:46 -0400)]
revert one change in time.h; no evidence BSD_SOURCE should expose these..
Rich Felker [Wed, 13 Jun 2012 18:43:16 +0000 (14:43 -0400)]
fix feature test macros in time.h
stime is not _XOPEN_SOURCE, and some functions were missing with
_BSD_SOURCE..
Rich Felker [Wed, 13 Jun 2012 18:41:52 +0000 (14:41 -0400)]
add timegm function (inverse of gmtime), nonstandard
Rich Felker [Wed, 13 Jun 2012 15:49:22 +0000 (11:49 -0400)]
add init_module/delete_module syscall wrappers
these are not exposed publicly in any header, but the few programs
that use them (modutils/kmod, etc.) are declaring the functions
themselves rather than making the syscalls directly, and it doesn't
really hurt to have them (same as the capset junk).
Rich Felker [Wed, 13 Jun 2012 15:14:38 +0000 (11:14 -0400)]
add (currently stubbed due to stubbed strverscmp) versionsort function
based on patch by Emil Renner Berthing, with minor changes to dirent.h
for LFS64 and organization of declarations
this code should work unmodified once a real strverscmp is added, but
I've been hesitant to add it because the GNU strverscmp behavior is
harmful in a lot of cases (for instance if you have numeric filenames
in hex). at some point I plan on trying to design a variant of the
algorithm that behaves better on a mix of filename styles.
Rich Felker [Wed, 13 Jun 2012 15:04:31 +0000 (11:04 -0400)]
add deprecated capabilities functions
these were left in glibc for binary compatibility after the public
part of the interface was removed, and libcap kept using them (with
its own copy of the header files) rather than just making the syscalls
directly. might as well add them since they're so small...
Rich Felker [Sun, 10 Jun 2012 01:20:44 +0000 (21:20 -0400)]
fix char signedness bug (arm-specific) in dynamic linker
Rich Felker [Sat, 9 Jun 2012 23:53:29 +0000 (19:53 -0400)]
add pthread_attr_setstack interface (and get)
i originally omitted these (optional, per POSIX) interfaces because i
considered them backwards implementation details. however, someone
later brought to my attention a fairly legitimate use case: allocating
thread stacks in memory that's setup for sharing and/or fast transfer
between CPU and GPU so that the thread can move data to a GPU directly
from automatic-storage buffers without having to go through additional
buffer copies.
perhaps there are other situations in which these interfaces are
useful too.
Rich Felker [Fri, 8 Jun 2012 15:17:49 +0000 (11:17 -0400)]
fix scanning of "-0x" pseudo-hex float (must give negative zero)
Rich Felker [Fri, 8 Jun 2012 15:11:44 +0000 (11:11 -0400)]
fix signedness errors in stdint.h constant macros
the types of these expressions must match the integer promotions.
unsigned 8- and 16-bit values promote to signed int, not unsigned int.
Rich Felker [Fri, 8 Jun 2012 14:36:43 +0000 (10:36 -0400)]
fix %ls breakage in last printf fix
signedness issue kept %ls with no precision from working at all
Rich Felker [Fri, 8 Jun 2012 14:32:59 +0000 (10:32 -0400)]
fix printf %ls with precision limit over-read issue
printf was not printing too many characters, but it was reading one
too many wchar_t elements from the input. this could lead to crashes
if running off the page, or spurious failure if the conversion of the
extra wchar_t resulted in EILSEQ.
Rich Felker [Fri, 8 Jun 2012 03:06:04 +0000 (23:06 -0400)]
fix sysinfo, try 2. it seems to work this time.
Rich Felker [Fri, 8 Jun 2012 02:58:19 +0000 (22:58 -0400)]
sysinfo struct was utter nonsense; no idea where it came from.
this broke the busybox "free" utility (memory reporting) and possibly
other things like uptime.
Rich Felker [Fri, 8 Jun 2012 02:52:41 +0000 (22:52 -0400)]
fix scanf bug reading literals after width-limited field
the field width limit was not being cleared before reading the
literal, causing spurious failures in scanf in cases like "%2d:"
scanning "00:".
Rich Felker [Thu, 7 Jun 2012 04:32:22 +0000 (00:32 -0400)]
check for ld support of -Bsymbolic-functions; disable shared if not avail
this issue affects the last gpl2 version of binutils, which some
people are still using out of aversion to gpl3. musl requires
-Bsymbolic-functions because it's the only way to make a libc.so
that's able to operate prior to dynamic linking but that still behaves
correctly with respect to global vars that may be moved to the main
program via copy relocations.
Rich Felker [Thu, 7 Jun 2012 04:27:34 +0000 (00:27 -0400)]
use -nostdlib in linker tests to avoid possible missing crt/lib issues
Rich Felker [Thu, 7 Jun 2012 04:23:58 +0000 (00:23 -0400)]
avoid linking main program in linker tests
it's possible that the user has provided a compiler that does not have
any libc to link to, so linking a main program is a bad idea. instead,
generate an empty shared library with no dependencies.
Rich Felker [Thu, 7 Jun 2012 02:00:08 +0000 (22:00 -0400)]
make configure try to disable stack protector
in theory we could support stack protector in the libc itself, and
users wanting to experiment with such usage could add
-fstack-protector to CFLAGS intentionally. but to avoid breakage in
the default case, override broken distro-patched gcc that forces stack
protector on.
Rich Felker [Thu, 7 Jun 2012 00:45:52 +0000 (20:45 -0400)]
add configure check for gnu linker hash style setting
some broken distro-provided toolchains have modified gcc to produce
only "gnu hash" dynamic hash table by default. as this is unsupported
by musl, that results in a non-working libc.so. we detect and switch
this on in configure rather than hard-coding it in the Makefile
because it's not supported by old binutils versions, but that might
not even be relevant since old binutils versions already fail from
-Bsymbolic-functions being missing. at some point I may review whether
this should just go in the Makefile...
Rich Felker [Wed, 6 Jun 2012 19:48:06 +0000 (15:48 -0400)]
make gcc wrapper rewrite link options rather than just extending them
this is not tested yet, but should work to get rid of unwanted
--hash-style=gnu hacks present in some distro-patched gcc versions.
Rich Felker [Wed, 6 Jun 2012 15:21:28 +0000 (11:21 -0400)]
treat failure of mprotect in map_library as a fatal load failure
the error will propagate up and be printed to the user at program
start time; at runtime, dlopen will just fail and leave a message for
dlerror.
previously, if mprotect failed, subsequent attempts to perform
relocations would crash the program. this was resulting in an
increasing number of false bug reports on grsec systems where rwx
permission is not possible in cases where users were wrongly
attempting to use non-PIC code in shared libraries. supporting that
usage is in theory possible, but the x86_64 toolchain does not even
support textrels, and the cost of keeping around the necessary
information to handle textrels without rwx permissions is
disproportionate to the benefit (which is essentially just supporting
broken library setups on grsec machines).
also, i unified the error-out code in map_library now that there are 3
places from which munmap might have to be called.
Rich Felker [Tue, 5 Jun 2012 23:42:33 +0000 (19:42 -0400)]
fix ctype abi junk (pointer should point to 0 slot, not -128 slot)
Rich Felker [Mon, 4 Jun 2012 12:03:56 +0000 (08:03 -0400)]
_GNU_SOURCE is supposed to imply _LARGEFILE64_SOURCE
this is ugly and stupid, but now that the *64 symbol names exist, a
lot of broken GNU software detects them in configure, then either
breaks during build due to missing off64_t definition, or attempts to
compile without function declarations/prototypes. "fixing" it here is
easier than telling everyone to add yet another feature test macro to
their builds.
Rich Felker [Sun, 3 Jun 2012 20:31:45 +0000 (16:31 -0400)]
release notes for 0.9.1
Rich Felker [Sun, 3 Jun 2012 20:22:13 +0000 (16:22 -0400)]
fix configure build/host/target terminology usage
Rich Felker [Sun, 3 Jun 2012 01:53:04 +0000 (21:53 -0400)]
ensure that abort always works
Per POSIX, "The abort() function shall cause abnormal process
termination to occur, unless the signal SIGABRT is being caught and
the signal handler does not return."
If SIGABRT is blocked or if a signal handler is installed and does
return, abort is still required to cause abnormal program termination.
We cannot use a_crash() to do this, since a SIGILL handler could also
be installed (and might even longjmp out of the abort, not expecting
to be invoked from within abort), nor can we rely on resetting the
signal handler and re-raising the signal (this has race conditions in
multi-threaded programs). On the other hand, SIGKILL is a perfectly
safe, unblockable way to obtain abnormal program termination, and it
requires no ugly loop-and-retry logic.
Rich Felker [Sun, 3 Jun 2012 01:20:21 +0000 (21:20 -0400)]
add some ugly aliases for LSB ABI compatibility
for some nonsensical reason, glibc's headers use inline functions that
redirect some of the standard functions to ugly nonstandard names (and
likewise for some of their nonstandard functions).
Rich Felker [Sun, 3 Jun 2012 00:15:37 +0000 (20:15 -0400)]
increase default thread stack size to 80k
I've been looking for data that would suggest a good default, and
since little has shown up, i'm doing this based on the limited data I
have. the value 80k is chosen to accommodate 64k of application data
(which happens to be the size of the buffer in git that made it crash
without a patch to call pthread_attr_setstacksize) plus the max stack
usage of most libc functions (with a few exceptions like crypt, which
will be fixed soon to avoid excessive stack usage, and [n]ftw, which
inherently uses a fair bit in recursive directory searching).
if further evidence emerges suggesting that the default should be
larger, I'll consider changing it again, but I'd like to avoid it
getting too large to avoid the issues of large commit charge and rapid
address space exhaustion on 32-bit machines.
Rich Felker [Sun, 3 Jun 2012 00:04:27 +0000 (20:04 -0400)]
remove implementation-reserved bits when saving signal mask
this fix is necessary because a program could be started with some of
the implementation-reserved signals masked (e.g. due to exec having
been called from a signal handler, or from a non-musl program) and
then could obtain an invalid-to-use-later sigset_t as the old/saved
signal mask.
Rich Felker [Sat, 2 Jun 2012 23:56:18 +0000 (19:56 -0400)]
remove no-longer-needed unblocking of signals in pthread_create
this action is now performed in pthread_self initialization; it must
be performed there in case the first call to pthread_create is from a
signal handler, in which case the old signal mask could be restored on
return from the signal.
Rich Felker [Sat, 2 Jun 2012 21:49:14 +0000 (17:49 -0400)]
add LSB abi junk for ctype functions
this should be the last major fix needed to support running
glibc-linked conforming POSIX programs with musl in place of glibc, as
long as musl provides the features they need and they don't use
pthread cancellation (which is implemented as c++ exceptions in glibc,
and fundamentally incompatible with musl).
Rich Felker [Sat, 2 Jun 2012 20:51:04 +0000 (16:51 -0400)]
declare environ in unistd.h when _GNU_SOURCE feature test macro is used
lots of broken programs expect this, and it's gotten to the point of
being a troubleshooting FAQ topic. best to just fix it.