Rich Felker [Sun, 18 Aug 2013 02:28:50 +0000 (22:28 -0400)]
remove spurious tmp file present since initial git check-in
Rich Felker [Sun, 18 Aug 2013 02:21:11 +0000 (22:21 -0400)]
replace system's install command with a shell script
the historical (non-standardized) install command is really
inappropriate for installing binaries/libraries on a system that
utilizes memory-mapped executable files. rather than replacing an
existing file atomically, it overwrites the existing file. this can
cause running programs to see a partially-modified version of the
file, resulting in unpredictable behavior, or SIGBUS. a MAP_COPY mode
for mmap would get around this problem, but Linux lacks MAP_COPY.
the shell script added with this commit works around the problem by
writing temporary files and moving them into place. unlike the
historical install utility, it also support a -l option for installing
a symbolic link atomically, via the same method.
Rich Felker [Sat, 17 Aug 2013 20:23:22 +0000 (16:23 -0400)]
add hkscs/big5-2003/eten extensions to iconv big5
with these changes, the character set implemented as "big5" in musl is
a pure superset of cp950, the canonical "big5", and agrees with the
normative parts of Unicode. this means it has minor differences from
both hkscs and big5-2003:
- the range A2CC-A2CE maps to CJK ideographs rather than numerals,
contrary to changes made in big5-2003.
- C6CD maps to a CJK ideograph rather than its corresponding Kangxi
radical character, contrary to changes made in hkscs.
- F9FE maps to U+2593 rather than U+FFED.
of these differences, none but the last are visually distinct, and the
last is a character used purely for text-based graphics, not to convey
linguistic content.
should there be future demand for strict conformance to big5-2003 or
hkscs mappings, the present charset aliases can be replaced with
distinct variants.
reportedly there are other non-standard big5 extensions in common use
in Taiwan and perhaps elsewhere, which could also be added as layers
on top of the existing big5 support.
there may be additional characters which should be added to the hkscs
table: the whatwg standard for big5 defines what appears to be a
superset of hkscs.
Rich Felker [Fri, 16 Aug 2013 22:19:47 +0000 (18:19 -0400)]
make configure store its command line in config.mak for easy re-run
proper shell quoting and pretty-printing (avoiding ugly gratuitous
quoting and bad quoting style) is included.
Rich Felker [Fri, 16 Aug 2013 21:51:38 +0000 (17:51 -0400)]
fix atomicity and other issues installing dynamic linker symlink
ln -sf is non-atomic; it unlinks the destination first. instead, make
a temporary link and rename it into place.
this commit also fixes some of the dependency tracking behavior for
the link. depending on the directory it's to be installed in is not
reasonable; it causes a new link to be attempted if the library
directory has been modified, but does not attempt to make a new link
just because libc has been updated. instead, depend on the target to
be linked to. this will ensure that, if prefix has changed but
syslibdir has not, the link will be updated to point to the new
prefix.
Rich Felker [Fri, 16 Aug 2013 21:32:30 +0000 (17:32 -0400)]
some initial math asm for armhf (fabs[f] and sqrt[f])
Rich Felker [Fri, 16 Aug 2013 21:09:07 +0000 (17:09 -0400)]
fix detection of arm hardfloat
it turns out that __SOFTFP__ does not indicate the ABI in use but
rather that fpu instructions are not to be used at all. this is
specified in ARM's documentation so I'm unclear on how I previously
got the wrong idea. unfortunately, this resulted in the 0.9.12 release
producing a dynamic linker with the wrong name. fortunately, there do
not yet seem to be any public toolchain builds using the wrong name.
the __ARM_PCS_VFP macro does not seem to be official from ARM, and in
fact it was missing from the very earliest gcc versions (around 4.5.x)
that added -mfloat-abi=hard. it would be possible on such versions to
perform some ugly linker-based tests instead in hopes that the linker
will reject ABI-mismatching object files, if there is demand for
supporting such versions. I would probably prefer to document which
versions are broken and warn users to manually add -D__ARM_PCS_VFP if
using such a version.
there's definitely an argument to be made that the fenv macros should
be exposed even in -mfloat-abi=softfp mode. for now, I have chosen not
to expose them in this case, since the math library will not
necessarily have the capability to raise exceptions (it depends on the
CFLAGS used to compile it), and since exceptions are officially
excluded from the ARM EABI, which the plain "arm" arch aims to
follow.
Rich Felker [Fri, 16 Aug 2013 16:30:37 +0000 (12:30 -0400)]
support floating point environment (fenv) on armhf (hard float) subarchs
patch by nsz. I've tested it on an armhf machine and it seems to be
working correctly.
Rich Felker [Fri, 16 Aug 2013 04:29:32 +0000 (00:29 -0400)]
fix build of x86_64 expl assembly
apparently this label change was not carried over when adapting the
changes from the i386 version.
Rich Felker [Thu, 15 Aug 2013 18:52:27 +0000 (14:52 -0400)]
add function types to arm crt assembly
without these, calls may be resolved incorrectly if the calling code
has been compiled to thumb instead of arm. it's not clear to me at
this point whether crt_arch.h is even working if crt1.c is built as
thumb; this needs testing. but the _init and _fini issues were known
to cause crashes in static-linked apps when libc was built as thumb,
and this commit should fix that issue.
Szabolcs Nagy [Thu, 15 Aug 2013 15:13:24 +0000 (15:13 +0000)]
math: fix pow(x,-1) to raise underflow properly
if FLT_EVAL_METHOD!=0 check if (double)(1/x) is subnormal and not a
power of 2 (if 1/x is power of 2 then either it is exact or the
long double to double rounding already raised inexact and underflow)
Szabolcs Nagy [Thu, 15 Aug 2013 14:18:32 +0000 (14:18 +0000)]
math: fix i386 atan2.s to raise underflow for subnormal results
Szabolcs Nagy [Thu, 15 Aug 2013 14:05:19 +0000 (14:05 +0000)]
math: clean up atan2.c
* remove volatile hacks
* don't care about inexact flag for now (removed all the +-tiny)
* fix atanl to raise underflow properly
* remove signed int arithmetics
* use pi/2 instead of pi_o_2 (gcc generates the same code, which is not
correct, but it does not matter: we mainly care about nearest rounding)
Szabolcs Nagy [Thu, 15 Aug 2013 10:56:57 +0000 (10:56 +0000)]
math: fix x86 asin, atan, exp, log1p to raise underflow
underflow is raised by an inexact subnormal float store,
since subnormal operations are slow, check the underflow
flag and skip the store if it's already raised
Szabolcs Nagy [Thu, 15 Aug 2013 10:54:56 +0000 (10:54 +0000)]
math: fix x86 expl.s to raise underflow and clean up special case handling
Szabolcs Nagy [Thu, 15 Aug 2013 10:14:46 +0000 (10:14 +0000)]
math: fix asin, atan, log1p, tanh to raise underflow on subnormal
for these functions f(x)=x for small inputs, because f(0)=0 and
f'(0)=1, but for subnormal values they should raise the underflow
flag (required by annex F), if they are approximated by a polynomial
around 0 then spurious underflow should be avoided (not required by
annex F)
all these functions should raise inexact flag for small x if x!=0,
but it's not required by the standard and it does not seem a worthy
goal, so support for it is removed in some cases.
raising underflow:
- x*x may not raise underflow for subnormal x if FLT_EVAL_METHOD!=0
- x*x may raise spurious underflow for normal x if FLT_EVAL_METHOD==0
- in case of double subnormal x, store x as float
- in case of float subnormal x, store x*x as float
Szabolcs Nagy [Thu, 15 Aug 2013 10:13:02 +0000 (10:13 +0000)]
math: fix tgamma to raise underflow for large negative values
Szabolcs Nagy [Thu, 15 Aug 2013 10:08:45 +0000 (10:08 +0000)]
math: fix pow(0,-inf) to raise divbyzero flag
Szabolcs Nagy [Thu, 15 Aug 2013 10:07:46 +0000 (10:07 +0000)]
math: minor scalbn*.c simplification
Rich Felker [Wed, 14 Aug 2013 22:18:46 +0000 (18:18 -0400)]
fix length computation in dn_expand
there are two possible points where the length is evaluated: either
the first 'compression' jump, or the null terminator if no jumps have
taken place yet. the previous code only measured the length of the
first component.
Rich Felker [Wed, 14 Aug 2013 21:58:20 +0000 (17:58 -0400)]
de-duplicate dn_expand, fix return value and signature, clean up
the duplicate code in dn_expand and its incorrect return values are
both results of the history of the code: the version in __dns.c was
originally written with no awareness of the legacy resolver API, and
was later copy-and-paste duplicated to provide the legacy API.
this commit is the first of a series that will restructure the
internal dns code to share as much code as possible with the legacy
resolver API functions.
I have also removed the loop detection logic, since the output buffer
length limit naturally prevents loops. in order to avoid long runtime
when encountering a loop if the caller provided a ridiculously long
buffer, the caller-provided length is clamped at the maximum dns name
length.
Rich Felker [Wed, 14 Aug 2013 07:06:21 +0000 (03:06 -0400)]
add arm-optimized memcpy implementation from bionic libc
the approach of this implementation was heavily investigated prior to
adopting it. attempts to obtain similar performance with pure C code
were capping out at about 75% of the performance of the asm, with
considerably larger code size, and were fragile in that the compiler
would sometimes compile part of memcpy into a call to itself.
therefore, just using the asm seems to be the best option.
this commit is the first to make use of the new subarch-specific asm
framework. the new armel directory is the location for arm asm that
should not be used for all arm subarchs, only the default one. armhf
is the name of the little-endian hardfloat-ABI subarch, which can use
the exact same asm. in both cases, the build system finds the asm by
following a memcpy.sub file.
the other two subarchs, armeb and armebhf, would need a big-endian
variant of this code. it would not be hard to adapt the code to big
endian, but I will hold off on doing so until there is demand for it.
Rich Felker [Wed, 14 Aug 2013 06:50:25 +0000 (02:50 -0400)]
rework makefile subarch logic to allow shared files
instead of subarchs getting their own .s files which are used directly
by the makefile to replace the .c file, they now must provide a .sub
file whose contents are a pathname, relative to the location of the
.sub file, which will substitute for the .c file. essentially these
files are acting as symbolic links, but implemented as text files.
Rich Felker [Wed, 14 Aug 2013 06:48:11 +0000 (02:48 -0400)]
add missing MSG_EXCEPT in sys/msg.h
Rich Felker [Tue, 13 Aug 2013 22:18:44 +0000 (18:18 -0400)]
provide declarations for strtod_l and family
these aliases were originally intended to be for ABI compatibility
only, but their presence caused regressions in broken gnulib-based
software whose configure scripts detect the existing of these
functions then use them without declarations, resulting in bogus
return values.
Rich Felker [Sun, 11 Aug 2013 07:49:16 +0000 (03:49 -0400)]
add subarch asm support for PIC objects/shared libc
this rule was omitted in previous subarch asm commit
Rich Felker [Sun, 11 Aug 2013 07:43:25 +0000 (03:43 -0400)]
add missing a_or_l to atomic.h for non-x86 archs
this is needed for recently committed sigaction code
Rich Felker [Sun, 11 Aug 2013 07:27:35 +0000 (03:27 -0400)]
allow subarch-specific asm, including asm specific to the default
the default subarch is the one whose full name is just the base arch
name, with no suffixes. normally, either the asm in the default
subarch is suitable for all subarch variants, or separate asm is
mandatory for each variant. however, in the case of asm which is
purely for optimization purposes, it's possible to have asm that only
works (or only performs well) on the default subarch, and not any othe
the other variants. thus, I have added a mechanism to give a name to
the default variant, for example "armel" for the default,
little-endian arm. further such default-subarch names can be added in
the future as needed.
Rich Felker [Sun, 11 Aug 2013 03:39:43 +0000 (23:39 -0400)]
fix _NSIG and SIGRTMAX on mips
a mips signal mask contains 128 bits, enough for signals 1 through
128. however, the exit status obtained from the wait-family functions
only has room for values up to 127. reportedly signal 128 was causing
kernelspace bugs, so it was removed from the kernel recently; even
without that issue, however, it was impossible to support it correctly
in userspace.
at the same time, the bug was masked on musl by SIGRTMAX incorrectly
yielding 64 on mips, rather than the "correct" value of 128. now that
the _NSIG issue is fixed, SIGRTMAX can be fixed at the same time,
exposing the full range of signals for application use.
note that the (nonstandardized) libc _NSIG value is actually one
greater than the max signal number, and also one greater than the
kernel headers' idea of _NSIG. this is the reason for the discrepency
with the recent kernel changes. since reducing _NSIG by one brought it
down from 129 to 128, rather than from 128 to 127, _NSIG/8, used
widely in the musl sources, is unchanged.
Rich Felker [Sun, 11 Aug 2013 03:33:54 +0000 (23:33 -0400)]
fix definitions of WIFSTOPPED and WIFSIGNALED to support up to signal 127
mips has signal numbers up to 127 (formerly, up to 128, but the last
one never worked right and caused kernel panic when used), so 127 in
the "signal number" field of the wait status is insufficient for
determining that the process was stopped. in addition, a nonzero value
in the upper bits must be present, indicating the signal number which
caused the process to be stopped.
details on this issue can be seen in the email with message id
CAAG0J9-d4BfEhbQovFqUAJ3QoOuXScrpsY1y95PrEPxA5DWedQ@mail.gmail.com on
the linux-mips mailing list, archived at:
http://www.linux-mips.org/archives/linux-mips/2013-06/msg00552.html
and in the associated thread about fixing the mips kernel bug.
commit
4a96b948687166da26a6c327e6c6733ad2336c5c fixed the
corresponding issue in uClibc, but introduced a multiple-evaluation
issue for the WIFSTOPPED macro.
for the most part, none of these issues affected pure musl systems,
since musl has up until now (incorrectly) defined SIGRTMAX as 64 on
all archs, even mips. however, interpreting status of non-musl
programs on mips may have caused problems. with this change, the full
range of signal numbers can be made available on mips.
Rich Felker [Sun, 11 Aug 2013 01:41:05 +0000 (21:41 -0400)]
add pthread_setaffinity_np and pthread_getaffinity_np functions
Rich Felker [Sun, 11 Aug 2013 01:15:11 +0000 (21:15 -0400)]
add cpu affinity interfaces
this first commit just includes the CPU_* and sched_* interfaces, not
the pthread_* interfaces, which may be added later. simple
sanity-check testing has been done for the basic interfaces, but most
of the macros have not yet been tested.
Rich Felker [Sat, 10 Aug 2013 01:25:29 +0000 (21:25 -0400)]
change sigset_t functions to restrict to _NSIG
the idea here is to avoid advertising signals that don't exist and to
make these functions safe to call (e.g. from within other parts of the
implementation) on fake sigset_t objects which do not have the HURD
padding.
Rich Felker [Sat, 10 Aug 2013 01:03:47 +0000 (21:03 -0400)]
optimize posix_spawn to avoid spurious sigaction syscalls
the trick here is that sigaction can track for us which signals have
ever had a signal handler set for them, and only those signals need to
be considered for reset. this tracking mask may have false positives,
since it is impossible to remove bits from it without race conditions.
false negatives are not possible since the mask is updated with atomic
operations prior to making the sigaction syscall.
implementation-internal signals are set to SIG_IGN rather than SIG_DFL
so that a signal raised in the parent (e.g. calling pthread_cancel on
the thread executing pthread_spawn) does not have any chance make it
to the child, where it would cause spurious termination by signal.
this change reduces the minimum/typical number of syscalls in the
child from around 70 to 4 (including execve). this should greatly
improve the performance of posix_spawn and other interfaces which use
it (popen and system).
to facilitate these changes, sigismember is also changed to return 0
rather than -1 for invalid signals, and to return the actual status of
implementation-internal signals. POSIX allows but does not require an
error on invalid signal numbers, and in fact returning an error tends
to confuse applications which wrongly assume the return value of
sigismember is boolean.
Rich Felker [Sat, 10 Aug 2013 00:04:05 +0000 (20:04 -0400)]
fix missing errno from exec failure in posix_spawn
failures prior to the exec attempt were reported correctly, but on
exec failure, the return value contained junk.
Rich Felker [Fri, 9 Aug 2013 23:56:53 +0000 (19:56 -0400)]
block all signals, even implementation-internal ones, in faccessat child
the child process's stack may be insufficient size to support a signal
frame, and there is no reason these signal handlers should run in the
child anyway.
Rich Felker [Fri, 9 Aug 2013 03:17:05 +0000 (23:17 -0400)]
block signals during fork
there are several reasons for this. some of them are related to race
conditions that arise since fork is required to be async-signal-safe:
if fork or pthread_create is called from a signal handler after the
fork syscall has returned but before the subsequent userspace code has
finished, inconsistent state could result. also, there seem to be
kernel and/or strace bugs related to arrival of signals during fork,
at least on some versions, and simply blocking signals eliminates the
possibility of such bugs.
Rich Felker [Thu, 8 Aug 2013 20:10:35 +0000 (16:10 -0400)]
work around libraries with versioned symbols in dynamic linker
this commit does not add versioning support; it merely fixes incorrect
lookups of symbols in libraries that contain versioned symbols.
previously, the version information was completely ignored, and
empirically this seems to have resulted in the oldest version being
chosen, but I am uncertain if that behavior was even reliable.
the new behavior being introduced is to completely ignore symbols
which are marked "hidden" (this seems to be the confusing nomenclature
for non-current-version) when versioning is present. this should solve
all problems related to libraries with symbol versioning as long as
all binaries involved are up-to-date (compatible with the
latest-version symbols), and it's the needed behavior for dlsym under
all circumstances.
rofl0r [Thu, 8 Aug 2013 18:54:32 +0000 (20:54 +0200)]
sys/personality.h: add missing C++ compat
rofl0r [Thu, 8 Aug 2013 18:34:40 +0000 (20:34 +0200)]
sys/personality.h: add missing macros
Rich Felker [Wed, 7 Aug 2013 17:16:14 +0000 (13:16 -0400)]
add Big5 charset support to iconv
at this point, it is just the common base charset equivalent to
Windows CP 950, with no further extensions. HKSCS and possibly other
supersets will be added later. other aliases may need to be added too.
Rich Felker [Wed, 7 Aug 2013 15:19:11 +0000 (11:19 -0400)]
make fcvt decimal point location for zero make more sense
the (obsolete) standard allows either 0 or 1 for the decimal point
location in this case, but since the number of zero digits returned in
the output string (in this implementation) is one more than the number
of digits the caller requested, it makes sense for the decimal point
to be logically "after" the first digit. in a sense, this change goes
with the previous commit which fixed the value of the decimal point
location for non-zero inputs.
Rich Felker [Wed, 7 Aug 2013 15:14:45 +0000 (11:14 -0400)]
fix ecvt/fcvt decimal point position output
these functions are obsolete and have no modern standard. the text in
SUSv2 is highly ambiguous, specifying that "negative means to the left
of the returned digits", which suggested to me that 0 would mean to
the right of the first digit. however, this does not agree with
historic practice, and the Linux man pages are more clear, specifying
that a negative value means "that the decimal point is to the left of
the start of the string" (in which case, 0 would mean the start of the
string, in accordance with historic practice).
Rich Felker [Mon, 5 Aug 2013 17:14:17 +0000 (13:14 -0400)]
iconv support for legacy Korean encodings
like for other character sets, stateful iso-2022 form is not supported
yet but everything else should work. all charset aliases are treated
the same, as Windows codepage 949, because reportedly the EUC-KR
charset name is in widespread (mis?)usage in email and on the web for
data which actually uses the extended characters outside the standard
93x94 grid. this could easily be changed if desired.
the principle of this converter for handling the giant bulk of rare
Hangul syllables outside of the standard KS X 1001 93x94 grid is the
same as the GB18030 converter's treatment of non-explicitly-coded
Unicode codepoints: sequences in the extension range are mapped to an
integer index N, and the converter explicitly computes the Nth Hangul
syllable not explicitly encoded in the character map. empirically,
this requires at most 7 passes over the grid. this approach reduces
the table size required for Korean legacy encodings from roughly 44k
to 17k and should have minimal performance impact on real-world text
conversions since the "slow" characters are rare. where it does have
impact, the cost is merely a large constant time factor.
Rich Felker [Sat, 3 Aug 2013 21:10:42 +0000 (17:10 -0400)]
have new timer threads unblock their own SIGTIMER
unblocking it in the pthread_once init function is not sufficient,
since multiple threads, some of them with the signal blocked, could
already exist before this is called; timers started from such threads
would be non-functional.
Rich Felker [Sat, 3 Aug 2013 20:27:30 +0000 (16:27 -0400)]
add system for resetting TLS to initial values
this is needed for reused threads in the SIGEV_THREAD timer
notification system, and could be reused elsewhere in the future if
needed, though it should be refactored for such use.
for static linking, __init_tls.c is simply modified to export the TLS
info in a structure with external linkage, rather than using statics.
this perhaps makes the code more clear, since the statics were poorly
named for statics. the new __reset_tls.c is only linked if it is used.
for dynamic linking, the code is in dynlink.c. sharing code with
__copy_tls is not practical since __reset_tls must also re-zero
thread-local bss.
Rich Felker [Sat, 3 Aug 2013 17:20:42 +0000 (13:20 -0400)]
fix multiple bugs in SIGEV_THREAD timers
1. the thread result field was reused for storing a kernel timer id,
but would be overwritten if the application code exited or cancelled
the thread.
2. low pointer values were used as the indicator that the timer id is
a kernel timer id rather than a thread id. this is not portable, as
mmap may return low pointers on some conditions. instead, use the fact
that pointers must be aligned and kernel timer ids must be
non-negative to map pointers into the negative integer space.
3. signals were not blocked until after the timer thread started, so a
race condition could allow a signal handler to run in the timer thread
when it's not supposed to exist. this is mainly problematic if the
calling thread was the only thread where the signal was unblocked and
the signal handler assumes it runs in that thread.
Rich Felker [Sat, 3 Aug 2013 07:20:56 +0000 (03:20 -0400)]
add some new linux AT_* flags
Rich Felker [Sat, 3 Aug 2013 07:16:24 +0000 (03:16 -0400)]
fix faccessat to support AT_EACCESS flag
this is another case of the kernel syscall failing to support flags
where it needs to, leading to horrible workarounds in userspace. this
time the workaround requires changing uid/gid, and that's not safe to
do in the current process. in the worst case, kernel resource limits
might prevent recovering the original values, and then there would be
no way to safely return. so, use the safe but horribly inefficient
alternative: forking. clone is used instead of fork to suppress
signals from the child.
fortunately this worst-case code is only needed when effective and
real ids mismatch, which mainly happens in suid programs.
Rich Felker [Sat, 3 Aug 2013 06:28:35 +0000 (02:28 -0400)]
collapse euidaccess to a call to faccessat
it turns out Linux is buggy for faccessat, just like fchmodat: the
kernel does not actually take a flags argument. so we're going to have
to emulate it there.
Rich Felker [Sat, 3 Aug 2013 06:18:19 +0000 (02:18 -0400)]
add prototypes for euidaccess/eaccess
Rich Felker [Sat, 3 Aug 2013 06:15:45 +0000 (02:15 -0400)]
add legacy euidaccess function and eaccess alias for it
this is mainly for ABI compat purposes.
Rich Felker [Sat, 3 Aug 2013 01:20:33 +0000 (21:20 -0400)]
make tdestroy allow null function pointer if no destructor is needed
this change is to align with a change in the glibc interface.
Rich Felker [Sat, 3 Aug 2013 01:13:16 +0000 (21:13 -0400)]
fix aliasing violations in tsearch functions
patch by nsz. the actual object the caller has storing the tree root
has type void *, so accessing it as struct node * is not valid.
instead, simply access the value, move it to a temporary of the
appropriate type and work from there, then move the result back.
Rich Felker [Fri, 2 Aug 2013 23:34:22 +0000 (19:34 -0400)]
protect against long double type mismatches (mainly powerpc for now)
check in configure to be polite (failing early if we're going to fail)
and in vfprintf.c since that is the point at which a mismatching type
would be extremely dangerous.
Rich Felker [Fri, 2 Aug 2013 22:34:39 +0000 (18:34 -0400)]
add legacy function valloc
it was already declared in stdlib.h, but not defined anywhere.
Rich Felker [Fri, 2 Aug 2013 22:14:44 +0000 (18:14 -0400)]
fix feature test macro logic for _BSD_SOURCE
in several places, _BSD_SOURCE was not even implying POSIX, resulting
in it being subtractive rather than additive (compared to the default
features).
Rich Felker [Fri, 2 Aug 2013 22:05:56 +0000 (18:05 -0400)]
add wcsftime_t alias
this is a nonstandard extension.
Rich Felker [Fri, 2 Aug 2013 20:52:17 +0000 (16:52 -0400)]
add missing c++ extern "C" wrapping to link.h
Rich Felker [Fri, 2 Aug 2013 17:33:31 +0000 (13:33 -0400)]
make fchdir, fchmod, fchown, and fstat support O_PATH file descriptors
on newer kernels, fchdir and fstat work anyway. this same fix should
be applied to any other syscalls that are similarly affected.
with this change, the current definitions of O_SEARCH and O_EXEC as
O_PATH are mostly conforming to POSIX requirements. the main remaining
issue is that O_NOFOLLOW has different semantics.
Rich Felker [Fri, 2 Aug 2013 16:59:45 +0000 (12:59 -0400)]
debloat code that depends on /proc/self/fd/%d with shared function
I intend to add more Linux workarounds that depend on using these
pathnames, and some of them will be in "syscall" functions that, from
an anti-bloat standpoint, should not depend on the whole snprintf
framework.
Rich Felker [Fri, 2 Aug 2013 16:25:32 +0000 (12:25 -0400)]
work around linux's lack of flags argument to fchmodat syscall
previously, the AT_SYMLINK_NOFOLLOW flag was ignored, giving
dangerously incorrect behavior -- the target of the symlink had its
modes changed to the modes (usually 0777) intended for the symlink).
this issue was amplified by the fact that musl provides lchmod, as a
wrapper for fchmodat, which some archival programs take as a sign that
symlink modes are supported and thus attempt to use.
emulating AT_SYMLINK_NOFOLLOW was a difficult problem, and I
originally believed it could not be solved, at least not without
depending on kernels newer than 3.5.x or so where O_PATH works halfway
well. however, it turns out that accessing O_PATH file descriptors via
their pseudo-symlink entries in /proc/self/fd works much better than
trying to use the fd directly, and works even on older kernels.
moreover, the kernel has permanently pegged these references to the
inode obtained by the O_PATH open, so there should not be race
conditions with the file being moved, deleted, replaced, etc.
Rich Felker [Fri, 2 Aug 2013 14:02:29 +0000 (10:02 -0400)]
move RPATH search after LD_LIBRARY_PATH search
this is the modern way, and the only way that makes any sense. glibc
has this complicated mechanism with RPATH and RUNPATH that controls
whether RPATH is processed before or after LD_LIBRARY_PATH, presumably
to support legacy binaries, but there is no compelling reason to
support this, and better behavior is obtained by just fixing the
search order.
Rich Felker [Fri, 2 Aug 2013 14:00:09 +0000 (10:00 -0400)]
provide useless 64-bit fcntl macros with _LARGEFILE64_SOURCE
this is all useless but part of the API, which is part of the
_GNU_SOURCE API, so something may need them.
Rich Felker [Fri, 2 Aug 2013 13:59:02 +0000 (09:59 -0400)]
if map_library has allocated a buffer for phdrs, free it on success too
this fixes an oversight in the previous commit.
Rich Felker [Fri, 2 Aug 2013 13:56:49 +0000 (09:56 -0400)]
improve error handling in map_library and support long phdrs
previously, errno could be meaningless when the caller wrote it to the
dlerror string or stderr. try to make it meaningful. also, fix
incorrect check for over-long program headers and instead actually
support them by allocating memory if needed.
Rich Felker [Fri, 2 Aug 2013 13:25:12 +0000 (09:25 -0400)]
fix uninitialized dyn variable in map_library
this can only happen for invalid library files, but they were not
detected reliably because the variable was uninitialized.
Rich Felker [Fri, 2 Aug 2013 05:06:53 +0000 (01:06 -0400)]
fix (deprecated) mktemp logic and update it to match other temp functions
the access function cannot be used to check for existence, because it
operates using real uid/gid rather than effective to determine
accessibility; this matters for the non-final path components.
instead, use stat. failure of stat is success if only the final
component is missing (ENOENT) and otherwise is failure.
Rich Felker [Fri, 2 Aug 2013 04:52:50 +0000 (00:52 -0400)]
remove (no longer useful) namespace-protected __mktemp symbol
Rich Felker [Fri, 2 Aug 2013 04:48:48 +0000 (00:48 -0400)]
make mkdtemp and mkstemp family leave template unchanged on fail
also refactor mkdtemp based on new shared temp code, removing
dependency on the deprecated mktemp, whose behavior made this logic
more difficult.
Rich Felker [Fri, 2 Aug 2013 01:44:43 +0000 (21:44 -0400)]
optimized memset asm for i386 and x86_64
the concept of both versions is the same; they differ only in details.
for long runs, they use "rep movsl" or "rep movsq", and for small
runs, they use a trick, writing from both ends towards the middle,
that reduces the number of branches needed. in addition, if memset is
called multiple times with the same length, all branches will be
predicted; there are no loops.
for larger runs, there are likely faster approaches than "rep", at
least on some cpu models. for 32-bit, it's unlikely that there is any
faster approach that does not require non-baseline instructions; doing
anything fancier would require inspecting cpu capabilities. for
64-bit, there may very well be faster versions that work on all
models; further optimization could be explored in the future.
with these changes, memset is anywhere between 50% faster and 6 times
faster, depending on the cpu model and the length and alignment of the
destination buffer.
Rich Felker [Thu, 1 Aug 2013 21:12:23 +0000 (17:12 -0400)]
work around gcc 4.8's generation of self-referential mem* functions at -O3
Rich Felker [Wed, 31 Jul 2013 19:19:39 +0000 (15:19 -0400)]
in pthread_getattr_np, use mremap rather than madvise to measure stack
the original motivation for this patch was that qemu (and possibly
other syscall emulators) nop out madvise, resulting in an infinite
loop. however, there is another benefit to this change: madvise may
actually undo an explicit madvise the application intended for its
stack, whereas the mremap operation is a true nop. the logic here is
that mremap must fail if it cannot resize the mapping in-place, and
the caller knows that it cannot resize in-place because it knows the
next page of virtual memory is already occupied.
Rich Felker [Wed, 31 Jul 2013 19:14:06 +0000 (15:14 -0400)]
fix theoretical out-of-bound access in dynamic linker
one of the arguments to memcmp may be shorter than the length l-3, and
memcmp is under no obligation not to access past the first byte that
differs. instead use strncmp which conveys the correct semantics. the
performance difference is negligible here and since the code is only
use for shared libc, both functions are already linked anyway.
Rich Felker [Wed, 31 Jul 2013 18:59:36 +0000 (14:59 -0400)]
prevent passing PT_INTERP name to dlopen from double-loading libc
the dev/inode for the main app and the dynamic linker ("interpreter")
are not available, so the subsequent checks don't work. in general we
don't want to make exact string matches to existing libraries prevent
loading new ones, since this breaks loading upgraded modules in
module-loading systems. so instead, special-case it.
the motivation for this fix is that calling dlopen on the names
returned by dl_iterate_phdr or walking the link map (obtained by
dlinfo) seem to be the only methods available to an application to
actually get a list of open dso handles.
Rich Felker [Wed, 31 Jul 2013 18:42:08 +0000 (14:42 -0400)]
add some sanity checks in dynamic loader code
reject elf files which are not ET_EXEC/ET_DYN type as bad exec format,
and reject ET_EXEC files when they cannot be loaded at the correct
address, since they are not relocatable at runtime. the main practical
benefit of this is to make dlopen of the main program fail rather than
producing an unsafe-to-use handle.
Rich Felker [Wed, 31 Jul 2013 18:05:41 +0000 (14:05 -0400)]
fix bug where read error was treated as success reading library headers
Rich Felker [Wed, 31 Jul 2013 04:04:10 +0000 (00:04 -0400)]
don't call null pointer if DT_INIT/DT_FINI are null
it's not clear to me why the linker even outputs these headers if they
are null, but apparently it does so. with the default startfiles, they
will never be null anyway, but this patch allows eliminating crti,
crtn, crtbegin, and crtend (leaving only crt1) if the toolchain is
using init_array/fini_array (or for a C-only, no-ctor environment).
Rich Felker [Tue, 30 Jul 2013 22:15:50 +0000 (18:15 -0400)]
add macros for new(ish) prctl commands
Rich Felker [Tue, 30 Jul 2013 17:04:31 +0000 (13:04 -0400)]
fix some prctl macros that were incorrectly copied into this file
Timo Teräs [Tue, 30 Jul 2013 13:14:56 +0000 (09:14 -0400)]
use separate sigaction buffers for old and new data
in signal() it is needed since __sigaction uses restrict in parameters
and sharing the buffer is technically an aliasing error. do the same
for the syscall, as at least qemu-user does not handle it properly.
Rich Felker [Mon, 29 Jul 2013 07:20:08 +0000 (03:20 -0400)]
release notes for 0.9.12
Rich Felker [Sun, 28 Jul 2013 15:30:42 +0000 (11:30 -0400)]
add missing erfcl wrapper for archs where long double is plain double
Rich Felker [Sun, 28 Jul 2013 07:41:01 +0000 (03:41 -0400)]
fix semantically incorrect use of LC_GLOBAL_LOCALE
LC_GLOBAL_LOCALE refers to the global locale, controlled by setlocale,
not the thread-local locale in effect which these functions should be
using. neither LC_GLOBAL_LOCALE nor 0 has an argument to the *_l
functions has behavior defined by the standard, but 0 is a more
logical choice for requesting the callee to lookup the current locale.
in the future I may move the current locale lookup the the caller (the
non-_l-suffixed wrapper).
at this point, all of the locale logic is dummied out, so no harm was
done, but it should at least avoid misleading usage.
Rich Felker [Sun, 28 Jul 2013 01:37:05 +0000 (21:37 -0400)]
fix indention-with-spaces
Rich Felker [Sat, 27 Jul 2013 21:47:03 +0000 (17:47 -0400)]
reorder strftime to eliminate the incorrect indention level
this change is in preparation for possibly adding support for the
field width and padding specifiers added in POSIX 2008.
Rich Felker [Sat, 27 Jul 2013 21:11:34 +0000 (17:11 -0400)]
add wrapper headers, with warnings, for various incorrect names under sys
also add a warning to the existing sys/poll.h. the warning is absent
from sys/dir.h because it is actually providing a slightly different
API to the program, and thus just replacing the #include directive is
not a valid fix to programs using this one.
Rich Felker [Sat, 27 Jul 2013 04:02:39 +0000 (00:02 -0400)]
a few more fixes for unistd/sysconf feature reporting
Rich Felker [Sat, 27 Jul 2013 03:07:54 +0000 (23:07 -0400)]
report presence of ADV and MSG options in unistd.h and sysconf
Rich Felker [Fri, 26 Jul 2013 19:51:28 +0000 (15:51 -0400)]
report that posix_spawn is supported in unistd.h and sysconf
Rich Felker [Fri, 26 Jul 2013 18:53:50 +0000 (14:53 -0400)]
add ABI symbols for strtol family functions
these odd names are actually generated by mess in glibc's stdlib.h, so
any glibc-linked program using strtol needs them to run against musl.
Rich Felker [Fri, 26 Jul 2013 18:41:12 +0000 (14:41 -0400)]
make ldd report the libc/dynamic linker itself
Rich Felker [Fri, 26 Jul 2013 18:25:51 +0000 (14:25 -0400)]
fix computation of entry point and main app phdrs when invoking via ldso
entry point was wrong for PIE. e_entry was being treated as an
absolute value, whereas it's actually relative to the load address
(which is zero for non-PIE).
phdr pointer was wrong for non-PIE. e_phoff was being treated as
load-address-relative, whereas it's actually a file offset in the ELF
file. in any case, map_library was already computing it correctly, and
the incorrect code in __dynlink was overwriting it with junk.
Rich Felker [Fri, 26 Jul 2013 07:10:11 +0000 (03:10 -0400)]
fix powerpc build breakage from dynamic linker path search changes
Rich Felker [Fri, 26 Jul 2013 05:49:14 +0000 (01:49 -0400)]
new mostly-C crt1 implementation
the only immediate effect of this commit is enabling PIE support on
some archs that did not previously have any Scrt1.s, since the
existing asm files for crt1 override this C code. so some of the
crt_arch.h files committed are only there for the sake of documenting
what their archs "would do" if they used the new C-based crt1.
the expectation is that new archs should use this new system rather
than using heavy asm for crt1. aside from being easier and less
error-prone, it also ensures that PIE support is available immediately
(since Scrt1.o is generated from the same C source, using -fPIC)
rather than having to be added as an afterthought in the porting
process.
Rich Felker [Thu, 25 Jul 2013 07:30:24 +0000 (03:30 -0400)]
fix undefined strcpy call in inet_ntop
source and dest arguments for strcpy cannot overlap, so memmove must
be used here. the length is already known from the above loop.
Rich Felker [Thu, 25 Jul 2013 07:20:02 +0000 (03:20 -0400)]
make inet_ntop format v4-mapped ipv6 addresses properly
based on a patch by orc. POSIX actually fails to specify the format of
the ntop conversion; presumably, any output that will correctly
round-trip back via the (well-specified) pton operation is acceptable.
the new behavior is much more convenient than the old, however.
this patch also affects getnameinfo, which is implemented in terms of
inet_ntop and which is the preferred interface for performing this
conversion.
I've also removed some inexplicable cruft (filling the buffer with 'x'
before doing anything) whose origin I was unable to track down.
Rich Felker [Thu, 25 Jul 2013 03:21:45 +0000 (23:21 -0400)]
do not include math modules in the default -O3 optimization set
it's not clear that -O3 helps them, and gcc seems to have floating
point optimization bugs that introduce additional failures when -O3 is
used on some of these files.
Rich Felker [Thu, 25 Jul 2013 03:17:21 +0000 (23:17 -0400)]
fix incorrect type for new si_call_addr in siginfo_t
apparently the original kernel commit's i386 version of siginfo.h
defined this field as unsigned int, but the asm-generic file always
had void *. unsigned int is obviously not a suitable type for an
address, in a non-arch-specific file, and glibc also has void * here,
so I think void * is the right type for it.
also fix redundant type specifiers.
Szabolcs Nagy [Thu, 25 Jul 2013 00:22:05 +0000 (00:22 +0000)]
add protocol families PF_IB and PF_VSOCK to socket.h
linux commit
8d36eb01da5d371feffa280e501377b5c450f5a5 (2013-05-29)
added PF_IB for InfiniBand
linux commit
d021c344051af91f42c5ba9fdedc176740cbd238 (2013-02-06)
added PF_VSOCK for VMware sockets