oweals/minetest.git
5 years agoOptimize usage of TOSERVER_GOTBLOCKS packet
sfan5 [Wed, 7 Aug 2019 08:31:12 +0000 (10:31 +0200)]
Optimize usage of TOSERVER_GOTBLOCKS packet

5 years agoDo not add group values of zero to group lists. (#8751)
Beha [Wed, 7 Aug 2019 08:48:04 +0000 (04:48 -0400)]
Do not add group values of zero to group lists. (#8751)

This fixes an issue where when the engine looked up groups (for example,
in ABM node names), NodeDefManager's m_group_to_items would contain nodes
with a group value of zero, resulting in nodes with flammable = 0 being
burned by a fire mod with a group:flammable checking ABM.

It brings consistency to the behaviour described in the api
documentation, where zero and nil groups should be the same.

5 years agoClean up and fix freetype=false crashes (#8641)
SmallJoker [Tue, 6 Aug 2019 19:33:13 +0000 (21:33 +0200)]
Clean up and fix freetype=false crashes (#8641)

A IGUIFont of type bitmap/vector cannot be converted to CGUITTFont
Fixes various segfaults in gameplay
Shorter font cache code, cleaned up (?)

5 years agoAdd luacheck to check builtin (#7895)
rubenwardy [Tue, 6 Aug 2019 18:30:18 +0000 (19:30 +0100)]
Add luacheck to check builtin (#7895)

5 years agoMapgen Flat: Fix and improve getSpawnLevelAtPoint() (#8756)
Paramat [Tue, 6 Aug 2019 01:30:28 +0000 (02:30 +0100)]
Mapgen Flat: Fix and improve getSpawnLevelAtPoint() (#8756)

Previously, this wrongly returned ground level (a position containing
a solid node) as spawn level.
Return ground level + 2 (+ 2 to spawn above biome 'dust' nodes).
Improve codestyle and make more consistent with generateTerrain().

5 years agoUpdate curl dependency in buildbot
sfan5 [Mon, 5 Aug 2019 09:25:02 +0000 (11:25 +0200)]
Update curl dependency in buildbot

5 years agoFix binary-string confusion in client network code
sfan5 [Sun, 4 Aug 2019 18:40:35 +0000 (20:40 +0200)]
Fix binary-string confusion in client network code

5 years agoClean up FindOpenGLES2.cmake
sfan5 [Thu, 25 Jul 2019 17:55:40 +0000 (19:55 +0200)]
Clean up FindOpenGLES2.cmake

5 years agoUnify GLES support in gui scaling filter
sfan5 [Wed, 24 Jul 2019 22:11:30 +0000 (00:11 +0200)]
Unify GLES support in gui scaling filter

5 years agoUnify OpenGL ES support
sfan5 [Wed, 24 Jul 2019 22:01:25 +0000 (00:01 +0200)]
Unify OpenGL ES support

5 years agoLet ENABLE_GLES appear in cmake_config.h and change its functionality
sfan5 [Wed, 24 Jul 2019 21:15:28 +0000 (23:15 +0200)]
Let ENABLE_GLES appear in cmake_config.h and change its functionality

5 years agoAdd formspec testing to test mod in minimal
rubenwardy [Tue, 2 Jul 2019 02:43:46 +0000 (03:43 +0100)]
Add formspec testing to test mod in minimal

5 years agoAdd styles to most elements
rubenwardy [Sat, 16 Mar 2019 21:38:36 +0000 (21:38 +0000)]
Add styles to most elements

5 years agoAdd style[] tag with button support
rubenwardy [Fri, 15 Mar 2019 19:03:12 +0000 (19:03 +0000)]
Add style[] tag with button support

5 years agoAdd custom colorable GUIButton implementation
rubenwardy [Fri, 15 Mar 2019 18:39:23 +0000 (18:39 +0000)]
Add custom colorable GUIButton implementation

5 years agoFix negative offsets not being supported by container[]
rubenwardy [Sat, 3 Aug 2019 15:20:15 +0000 (16:20 +0100)]
Fix negative offsets not being supported by container[]

5 years agoBuiltin: Forward old return values
SmallJoker [Fri, 2 Aug 2019 08:20:41 +0000 (10:20 +0200)]
Builtin: Forward old return values

Was forgotten in 69bf964.

5 years agoCorrect ServerActiveObject's virtual getArmorGroups() to be const.
Beha [Thu, 1 Aug 2019 15:11:43 +0000 (11:11 -0400)]
Correct ServerActiveObject's virtual getArmorGroups() to be const.

Due to commit ec3142a , UnitSAO's getArmorGroups() did not match
ServerActiveObject's, notably resulting in the lua get_armor_groups() call
returning nothing.

5 years agoMainmenu: Use textarea in error formspecs
SmallJoker [Thu, 1 Aug 2019 09:56:26 +0000 (11:56 +0200)]
Mainmenu: Use textarea in error formspecs

5 years agoGroup "immortal" also protects players from damage
Wuzzy [Wed, 20 Feb 2019 23:36:17 +0000 (00:36 +0100)]
Group "immortal" also protects players from damage

Document new meaning of immortal=1 for players

Disable breathing if player is immortal

Hide builtin statbars if player immortal (delayed)

Co-authored-by: ClobberXD <ClobberXD@gmail.com>
5 years agoAllow toolcaps to override the built-in times for dig_immediate
sfan5 [Tue, 30 Jul 2019 15:18:37 +0000 (17:18 +0200)]
Allow toolcaps to override the built-in times for dig_immediate

5 years agoSilence invalid clang format warnings in guiScrollBar.cpp (#8724)
Paramat [Wed, 31 Jul 2019 00:30:17 +0000 (01:30 +0100)]
Silence invalid clang format warnings in guiScrollBar.cpp (#8724)

5 years agoSky: Refactor of moon and sun drawing (#8683)
Methacrylon [Tue, 30 Jul 2019 18:25:47 +0000 (20:25 +0200)]
Sky: Refactor of moon and sun drawing (#8683)

Split sun and moon render parts from the main render function.

5 years agoMove the clamping of hp/breath when their maximums change to read_object_properties...
Beha [Tue, 30 Jul 2019 15:29:45 +0000 (11:29 -0400)]
Move the clamping of hp/breath when their maximums change to read_object_properties(). (#8689)

This prevents set_properties() calls that have nothing to do with hp_max or breath_max overriding the saved hp before another mod has the chance to set a player's intended hp_max (such as in on_joinplayer).

5 years agoREADME: make -j$(nproc) (#8699)
Zaoqi [Tue, 30 Jul 2019 07:36:03 +0000 (15:36 +0800)]
README: make -j$(nproc) (#8699)

5 years agoRename guiScrollBar to GUIScrollBar
DS-Minetest [Sat, 27 Jul 2019 13:44:11 +0000 (15:44 +0200)]
Rename guiScrollBar to GUIScrollBar

5 years agoContentCAO: Fix broken attachments on join (#8701)
SmallJoker [Mon, 29 Jul 2019 17:14:07 +0000 (19:14 +0200)]
ContentCAO: Fix broken attachments on join (#8701)

What happened:
1) Object data is received. Client begins to read the data
2) Client initializes all its children (gob_cmd_update_infant)
3) Children try to attach to parent (yet not added)
4) Parent initializes, is added to the environment

And somewhere in between, Irrlicht wrecks up the attachments due to the missing matrix node.

The solution here is to:
1) Use the same structure as ServerActiveObject
2) Attach all children after the parent is really initialized

5 years agolua_api.txt clarifications regarding mapgen object index IDs and handles. (#8713)
Beha [Mon, 29 Jul 2019 12:09:29 +0000 (08:09 -0400)]
lua_api.txt clarifications regarding mapgen object index IDs and handles. (#8713)

5 years agoguiScrollBar: move directly to clicked pos if clicked into tray
DS-Minetest [Thu, 25 Jul 2019 13:16:49 +0000 (15:16 +0200)]
guiScrollBar: move directly to clicked pos if clicked into tray

5 years agoCheck for 'action' field in ABMs & LBMs
SmallJoker [Sat, 27 Jul 2019 18:55:38 +0000 (20:55 +0200)]
Check for 'action' field in ABMs & LBMs

5 years agoPrefix RecipePriority elements with PRIORITY_
Paul Ouellette [Mon, 22 Jul 2019 05:26:22 +0000 (01:26 -0400)]
Prefix RecipePriority elements with PRIORITY_

5 years agoInitialize priority in CraftDefinition constructors
Paul Ouellette [Mon, 22 Jul 2019 05:15:50 +0000 (01:15 -0400)]
Initialize priority in CraftDefinition constructors

The priority is used by getCraftResult, which may be used before
initHash is called.

5 years agominimal: Move get_craft_result tests to test mod
Paul Ouellette [Tue, 9 Jul 2019 22:36:28 +0000 (18:36 -0400)]
minimal: Move get_craft_result tests to test mod

5 years agoFix missing item images clipping in formspecs (#8652)
Pierre-Yves Rollo [Fri, 26 Jul 2019 17:44:29 +0000 (19:44 +0200)]
Fix missing item images clipping in formspecs (#8652)

* Fix clipping of itemimage

* Code style

* More code styling

5 years agoDocument 'wield_item' entity property (#8694)
Alex [Fri, 26 Jul 2019 17:43:54 +0000 (10:43 -0700)]
Document 'wield_item' entity property (#8694)

5 years agoMake FindCURL ready for vcpkg (#8295)
adrido [Fri, 26 Jul 2019 17:43:43 +0000 (19:43 +0200)]
Make FindCURL ready for vcpkg (#8295)

This allows to find and use curl with the vcpkg toolchain file.

5 years agoInitialise 'seabed_height' to avoid compilation warning (#8715)
Paramat [Fri, 26 Jul 2019 16:51:53 +0000 (17:51 +0100)]
Initialise 'seabed_height' to avoid compilation warning (#8715)

5 years agoRe-order mapgens in mainmenu and 'all settings' mapgen selection (#8705)
Paramat [Thu, 25 Jul 2019 19:46:28 +0000 (20:46 +0100)]
Re-order mapgens in mainmenu and 'all settings' mapgen selection (#8705)

v6 always last to discourage selection.
Special mapgens flat, fractal, singlenode, next to last. Of these, singlenode
last to discourage selection.
Of the remaining, v5 last due to age, v7 first due to being the default.

5 years agoMgfractal: Make non-fractal terrain optional (#8702)
Paramat [Thu, 25 Jul 2019 18:58:35 +0000 (19:58 +0100)]
Mgfractal: Make non-fractal terrain optional (#8702)

Enabled by default.
Only allow spawn on fractal, not on seabed terrain.
Various codestyle and comment improvements.

5 years agoRemoved debug.upvaluejoin to prevent leak of insecure environment
y [Tue, 23 Jul 2019 21:13:56 +0000 (21:13 +0000)]
Removed debug.upvaluejoin to prevent leak of insecure environment

5 years agoUpdate README.md (#8700)
Zaoqi [Sat, 20 Jul 2019 23:59:37 +0000 (23:59 +0000)]
Update README.md (#8700)

5 years agoAdd /help formspec for commands and privileges (#8385)
SmallJoker [Sat, 20 Jul 2019 16:22:32 +0000 (18:22 +0200)]
Add /help formspec for commands and privileges (#8385)

* Trigger for 'all' as well
* Add description textarea, double-click to copy

5 years agoImprove documentation of mapgen aliases (#8693)
Paramat [Sat, 20 Jul 2019 01:54:42 +0000 (02:54 +0100)]
Improve documentation of mapgen aliases (#8693)

5 years agoDocument the deprecation of hardcoded cave liquids (#8692)
Paramat [Sat, 20 Jul 2019 00:03:52 +0000 (01:03 +0100)]
Document the deprecation of hardcoded cave liquids (#8692)

5 years agotravis: Disable macOS build
sfan5 [Wed, 17 Jul 2019 13:36:51 +0000 (15:36 +0200)]
travis: Disable macOS build

The build often hits the 50m time limit or fails with spurious errors.
It can be re-enabled when/if we figure out how to solve this.

5 years agoOptimize getting active objects a bit. #8674
Lars Hofhansl [Tue, 16 Jul 2019 22:55:17 +0000 (15:55 -0700)]
Optimize getting active objects a bit. #8674

5 years agoUse vector.dot and vector.cross in vector.angle
HybridDog [Sun, 14 Jul 2019 09:45:55 +0000 (11:45 +0200)]
Use vector.dot and vector.cross in vector.angle

5 years agoAdd vector.dot and vector.cross
HybridDog [Sat, 13 Jul 2019 11:46:44 +0000 (13:46 +0200)]
Add vector.dot and vector.cross

Mostly copied from MarkuBu's code

5 years agoDungeons: Make multiple large rooms possible (#8678)
Paramat [Tue, 16 Jul 2019 19:39:58 +0000 (20:39 +0100)]
Dungeons: Make multiple large rooms possible (#8678)

Re-add the random size range for large rooms.
Remove 'first_room_large' bool.
Add 'large_room_chance' parameter that can disable large rooms,
specify 1 large room, or specify a chance for large rooms.
If 1 or a chance is specified, the first generated room is large,
to take advantage of the intersection checks that are done for the
1st room only.

5 years agoDocs: Clarify where to check for 'protection_bypass' (#8675)
SmallJoker [Sun, 14 Jul 2019 11:23:38 +0000 (13:23 +0200)]
Docs: Clarify where to check for 'protection_bypass' (#8675)

5 years agoMove more dungeon parameter selection to mapgens (#8653)
Paramat [Tue, 9 Jul 2019 19:38:51 +0000 (20:38 +0100)]
Move more dungeon parameter selection to mapgens (#8653)

Move 'num_dungeons' to 'DungeonParams'.
Add new parameter 'num_rooms' to replace 'rooms_min' and 'rooms_max',
so that the mapgen has complete control over the number of rooms.
Add new bool 'first_room_large' so that the mapgen chooses this
instead of a hardcoded 1 in 4 chance.
Add new parameter 'room_size_large' to replace 'room_size_large_min'
and 'room_size_large_max', so that the mapgen has complete control
over this.

5 years agoDo predict when sneak-place to node with on_rightclick
DS-Minetest [Sat, 29 Jun 2019 14:17:00 +0000 (16:17 +0200)]
Do predict when sneak-place to node with on_rightclick

5 years agoImprove ABM time budget handling. #8645
Lars Hofhansl [Mon, 8 Jul 2019 06:23:00 +0000 (23:23 -0700)]
Improve ABM time budget handling. #8645

5 years agoDocument ObjectRef:remove under Lua entity (#8659)
ANAND [Mon, 8 Jul 2019 02:27:56 +0000 (07:57 +0530)]
Document ObjectRef:remove under Lua entity (#8659)

This was previously documented under the general ObjectRef section with a note that this won't work on players. So I think this would fit better with Lua entity-only methods.

This PR also changes the title of the Lua entity-only section from `LuaEntitySAO-only` to `Lua entity only`.

5 years agoImprove grammar and formatting in the README
Hugo Locurcio [Mon, 1 Jul 2019 18:46:28 +0000 (20:46 +0200)]
Improve grammar and formatting in the README

This also clarifies the fact that Minetest saves `minetest.conf`
when closing Minetest for the first time, rather than when starting it
for the first time.

This also fixes the default key for the pitch move mode which is now P.

5 years agoUpdate biome definition dungeon node documentation (#8650)
Paramat [Mon, 1 Jul 2019 21:21:17 +0000 (22:21 +0100)]
Update biome definition dungeon node documentation (#8650)

5 years agoDungeongen: Remove most hardcoded dungeon nodes (#8594)
Paramat [Sun, 30 Jun 2019 21:55:20 +0000 (22:55 +0100)]
Dungeongen: Remove most hardcoded dungeon nodes (#8594)

Biome-defined dungeon nodes was added as a feature to MT 5.0.0.
So now remove most of the hardcoded dungeon node code that assumes a
game has stone, sandstone, desert stone, and no other stone types.
If biome-defined dungeon nodes are not found, dungeon nodes fall back
to the 'cobble' mapgen alias if present, if not present they fall back
to biome-defined 'stone'.
Remove now-unnecessary mapgen aliases from MapgenBasic. Non-mgv6 games
now only need to define 3 to 5 mapgen aliases.

Document dungeon parameters.

Make c_lava_source fallback to c_water_source as both are used as cave
liquids.

5 years agoOptimize and unify mesh processing (#7851)
Vitaliy [Fri, 28 Jun 2019 02:22:16 +0000 (05:22 +0300)]
Optimize and unify mesh processing (#7851)

5 years agoAdd compatible, consistent coordinate system to FormSpecs. (#8524)
v-rob [Thu, 27 Jun 2019 12:40:49 +0000 (05:40 -0700)]
Add compatible, consistent coordinate system to FormSpecs. (#8524)

5 years agoIncrease upper limit of display_gamma to 10 (#8618)
ANAND [Thu, 27 Jun 2019 03:04:12 +0000 (08:34 +0530)]
Increase upper limit of display_gamma to 10 (#8618)

5 years agoAdd support for 9-sliced backgrounds (#8600)
rubenwardy [Sat, 22 Jun 2019 14:03:54 +0000 (15:03 +0100)]
Add support for 9-sliced backgrounds (#8600)

9-slice textures are commonly used in GUIs to allow scaling them to match any resolution without distortion.

https://en.wikipedia.org/wiki/9-slice_scaling

5 years agoFix segfault on quitting with open node formspec (#8608)
SmallJoker [Fri, 21 Jun 2019 19:00:30 +0000 (21:00 +0200)]
Fix segfault on quitting with open node formspec (#8608)

5 years agoImprove buildbot script
Pierre-Yves Rollo [Fri, 21 Jun 2019 00:43:59 +0000 (02:43 +0200)]
Improve buildbot script

PR created under the employment of EvidenceBKidscode

* Variables to set git repositories urls (allows to build from another repo)
* Variables to set git branch to build from (allows to build from non-master branch)
* Variables to change built name
* Make -j uses the proper number of processors (autodetect)
* Changed toolchain from win32 to adpat it to non-debian distros

5 years agoFix handling of --color and --worldlist command line arguments
Markus Mattes [Sat, 25 May 2019 20:41:47 +0000 (22:41 +0200)]
Fix handling of --color and --worldlist command line arguments

They verify the provided value and error if a wrong value got provided
command line description for color was differnt on win32 but  code did not handle any differenc
extended the command line description for world and worldname that it is clear that they only start a local game if used with --go

Fixes #7875

5 years agoExclude vscode editor files from source
Markus Mattes [Sat, 25 May 2019 20:35:03 +0000 (22:35 +0200)]
Exclude vscode editor files from source

5 years agoUpdate README copyright notice to 2019 (#8606)
Vilhelm Prytz [Wed, 19 Jun 2019 00:09:16 +0000 (02:09 +0200)]
Update README copyright notice to 2019 (#8606)

5 years agoMapgen Carpathian: Add optional rivers (#7977)
Paramat [Wed, 19 Jun 2019 00:06:08 +0000 (01:06 +0100)]
Mapgen Carpathian: Add optional rivers (#7977)

Rivers are disabled by default and will not be added to existing worlds.
Rewrite getSpawnLevelAtPoint() to be simpler and more consistent with
generateTerrain().

5 years agoAndroid: Use system provided path for default TMPFolder setting (#8505)
stujones11 [Sat, 15 Jun 2019 13:12:59 +0000 (14:12 +0100)]
Android: Use system provided path for default TMPFolder setting (#8505)

5 years agoUpdate Github templates (#8593)
rubenwardy [Thu, 13 Jun 2019 14:09:15 +0000 (15:09 +0100)]
Update Github templates (#8593)

5 years agoUse CDB author and name in installed package's config (#8550)
Paul Ouellette [Mon, 10 Jun 2019 17:49:00 +0000 (13:49 -0400)]
Use CDB author and name in installed package's config (#8550)

They are used for tracking the package, so should match ContentDB.

5 years agoSettings: Disallow space characters entirely
SmallJoker [Mon, 10 Jun 2019 16:17:57 +0000 (18:17 +0200)]
Settings: Disallow space characters entirely

Lua API:
> Setting names can't contain whitespace or any of ="{}#

5 years agoFormspecs: Close on metadata removal (#8348)
SmallJoker [Mon, 10 Jun 2019 11:01:07 +0000 (13:01 +0200)]
Formspecs: Close on metadata removal (#8348)

Formspecs will now close as soon the formspec string in the node metadata turns invalid.

5 years agoAdd disable_jump to liquids and ladders (#7688)
SmallJoker [Mon, 10 Jun 2019 11:00:35 +0000 (13:00 +0200)]
Add disable_jump to liquids and ladders (#7688)

Remove second nodedef check by improving the colliding node detection
Also remove the 2nd check in old_move, correct standing node a bit

5 years agoAdd compatibility to vcpkg buildsystem (#8317)
adrido [Mon, 10 Jun 2019 01:56:55 +0000 (03:56 +0200)]
Add compatibility to vcpkg buildsystem (#8317)

5 years agoSave forceloaded blocks file periodically (#8535)
Thomas Rudin [Mon, 10 Jun 2019 00:07:33 +0000 (02:07 +0200)]
Save forceloaded blocks file periodically (#8535)

saves the forceloaded blocks periodically.
checks every 10 seconds if the forceloaded blocks got changed in-game
and persists them on-disk if that's the case

5 years agoDamage: Play no damage sound when immortal (#8350)
SmallJoker [Sun, 9 Jun 2019 09:25:41 +0000 (11:25 +0200)]
Damage: Play no damage sound when immortal (#8350)

Add isImmortal server-side for proper enable_damage handling
Rework log messages

5 years agoRemove modstore leftovers. Fix core.show_path_select_dialog documentation (#8572)
DS [Fri, 7 Jun 2019 20:12:20 +0000 (22:12 +0200)]
Remove modstore leftovers. Fix core.show_path_select_dialog documentation (#8572)

This was forgotten in #5852.

5 years agoHTTP API: Allow binary downloads and headers (#8573)
SmallJoker [Thu, 6 Jun 2019 17:13:29 +0000 (19:13 +0200)]
HTTP API: Allow binary downloads and headers (#8573)

Add minetest.features.httpfetch_binary_data

5 years agoDungeons: Settable density noise, move number calculation to mapgens (#8473)
Paramat [Sat, 1 Jun 2019 19:50:43 +0000 (20:50 +0100)]
Dungeons: Settable density noise, move number calculation to mapgens (#8473)

Add user-settable noise parameters for dungeon density to each mapgen,
except V6 which hardcodes this noise parameter.

Move the calculation of number of dungeons generated in a mapchunk out
of dungeongen.cpp and into mapgen code, to allow mapgens to generate
any desired number of dungeons in a mapchunk, instead of being forced
to have number of dungeons determined by a density noise.

This is more flexible and allows mapgens to use dungeon generation to
create custom structures, such as occasional mega-dungeons.

5 years agoFix persistent ^[brighten after damage again (#5739)
SmallJoker [Sun, 26 May 2019 07:54:23 +0000 (09:54 +0200)]
Fix persistent ^[brighten after damage again (#5739)

The old texture modifier is restored by passing `m_previous_texture_modifier`.
Either copy it manually or let the function parameter do that.

Victims so far:
8e0b80a Apr 2018
eb2bda7 May 2019

5 years agooverride.txt: Fix crash due to CRLF endings (#8439)
David G [Sat, 25 May 2019 16:01:55 +0000 (18:01 +0200)]
override.txt: Fix crash due to CRLF endings (#8439)

5 years agoDo not drag-place stack into 'craftpreview' slot (#8514)
SmallJoker [Sat, 25 May 2019 15:37:54 +0000 (17:37 +0200)]
Do not drag-place stack into 'craftpreview' slot (#8514)

5 years agoAdd IGUIScrollbar implementation with variable bar sizes (#8507)
stujones11 [Fri, 24 May 2019 15:42:05 +0000 (16:42 +0100)]
Add IGUIScrollbar implementation with variable bar sizes (#8507)

5 years agoFix forgotten PlayerSAO cast in a90f2ef
SmallJoker [Tue, 21 May 2019 19:37:47 +0000 (21:37 +0200)]
Fix forgotten PlayerSAO cast in a90f2ef

5 years agoMake autoforward simulate the 'up' key (#8249)
DS [Tue, 21 May 2019 18:50:00 +0000 (20:50 +0200)]
Make autoforward simulate the 'up' key (#8249)

5 years agoCheck for out-of-bounds breath when setting breath_max (#8493)
ANAND ツ [Tue, 21 May 2019 17:37:58 +0000 (23:07 +0530)]
Check for out-of-bounds breath when setting breath_max (#8493)

5 years agoFix API site build (#8551)
Paul Ouellette [Tue, 21 May 2019 17:37:10 +0000 (13:37 -0400)]
Fix API site build (#8551)

5 years agol_mapgen.cpp: Fix LINT broken since b1b40fe
SmallJoker [Tue, 21 May 2019 17:16:01 +0000 (19:16 +0200)]
l_mapgen.cpp: Fix LINT broken since b1b40fe

5 years agoPrioritise craft recipes
HybridDog [Wed, 3 Apr 2019 11:46:11 +0000 (13:46 +0200)]
Prioritise craft recipes

When multiple recipes are applicable, the recipes are prioritised in this order:
toolrepair < shapeless with groups < shapeless < shaped with groups < shaped
For cooking and fuel, items are prioritised over item groups

5 years agoTest crafting hash type only once for a recipe
HybridDog [Wed, 3 Apr 2019 11:59:42 +0000 (13:59 +0200)]
Test crafting hash type only once for a recipe

5 years agoAllow multiple cave liquids in a biome definition (#8481)
Paramat [Sat, 18 May 2019 20:13:14 +0000 (21:13 +0100)]
Allow multiple cave liquids in a biome definition (#8481)

This allows games to specify biome cave liquids and avoid the old
hardcoded behaviour, but preserves the ability to have multiple
cave liquids in one biome, such as lava and water.

When multiple cave liquids are defined by the biome definition,
make each entire cave use a randomly chosen liquid, instead of
every small cave segment using a randomly chosen liquid.

Plus an optimisation:
Don't place nodes if cave liquid is defined as 'air'

5 years agoAdd content_rating tag to appdata (#8538)
Carles Pastor Badosa [Sat, 18 May 2019 15:19:56 +0000 (17:19 +0200)]
Add content_rating tag to appdata (#8538)

This tag allows software stores (KDE discover, etc) to filter and know whether applications are suitable for young users.

5 years agoOptimize string (mis)handling (#8128)
Jozef Behran [Sat, 18 May 2019 15:19:13 +0000 (10:19 -0500)]
Optimize string (mis)handling (#8128)

* Optimize statbar drawing

The texture name of the statbar is a string passed by value.
That slows down the client and creates litter in the heap
as the content of the string is allocated there. Convert the
offending parameter to a const reference to avoid the
performance hit.

* Optimize texture cache

There is an unnecessary temporary created when the texture
path is being generated. This slows down the cache each time
a new texture is encountered and it needs to be loaded into
the cache. Additionally, the heap litter created by this
unnecessary temporary is particularly troublesome here as
the following code then piles another string (the resulting
full path of the texture) on top of it, followed by the
texture itself, which both are quite long term objects as
they are subsequently inserted into the cache where they can
remain for quite a while (especially if the texture turns
out to be a common one like dirt, grass or stone).

Use std::string.append to get rid of the temporary which
solves both issues (speed and heap fragmentation).

* Optimize animations in client

Each time an animated node is updated, an unnecessary copy of
the texture name is created, littering the heap with lots of
fragments. This can be specifically troublesome when looking
at oceans or large lava lakes as both of these nodes are
usually animated (the lava animation is pretty visible).
Convert the parameter of GenericCAO::updateTextures to a
const reference to get rid of the unnecessary copy.

There is a comment stating "std::string copy is mandatory as
mod can be a class member and there is a swap on those class
members ... do NOT pass by reference", reinforcing the
belief that the unnecessary copy is in fact necessary.
However one of the first things the code of the method does
is to assign the parameter to its class member, creating
another copy. By rearranging the code a little bit this
"another copy" can then be used by the subsequent code,
getting rid of the need to pass the parameter by value and
thus saving that copying effort.

* Optimize chat console history handling

The GUIChatConsole::replaceAndAddToHistory was getting the
line to work on by value which turns out to be unnecessary.
Get rid of that unnecessary copy by converting the parameter
to a const reference.

* Optimize gui texture setting

The code used to set the texture for GUI components was
getting the name of the texture by value, creating
unnecessary performance bottleneck for mods/games with
heavily textured GUIs. Get rid of the bottleneck by passing
the texture name as a const reference.

* Optimize sound playing code in GUIEngine

The GUIEngine's code receives the specification of the sound
to be played by value, which turns out to be most likely a
mistake as the underlying sound manager interface receives
the same thing by reference. Convert the offending parameter
to a const reference to get rid of the rather bulky copying
effort and the associated performance hit.

* Silence CLANG TIDY warnings for unit tests

Change "std::string" to "const std::string &" to avoid an
unnecessary local value copy, silencing the CLANG TIDY
process.

* Optimize formspec handling

The "formspec prepend" parameter was passed to the formspec
handling code by value, creating unnecessary copy of
std::string and slowing down the game if mods add things like
textured backgrounds for the player inventory and/or other
forms. Get rid of that performance bottleneck by converting
the parameter to a const reference.

* Optimize hotbar image handling

The code that sets the background images for the hotbar is
getting the name of the image by value, creating an
unnecessary std::string copying effort. Fix that by
converting the relevant parameters to const references.

* Optimize inventory deserialization

The inventory manager deserialization code gets the
serialized version of the inventory by value, slowing the
server and the client down when there are inventory updates.
This can get particularly troublesome with pipeworks which
adds nodes that can mess around with inventories
automatically or with mods that have mobs with inventories
that actively use them.

* Optimize texture scaling cache

There is an io::path parameter passed by value in the
procedure used to add images converted from textures,
leading to slowdown when the image is not yet created and
the conversion is thus needed. The performance hit is
quite significant as io::path is similar to std::string
so convert the parameter to a const reference to get rid of
it.

* Optimize translation file loader

Use "std::string::append" when calculating the final index
for the translation table to avoid unnecessary temporary
strings. This speeds the translation file loader up
significantly as std::string uses heap allocation which
tends to be rather slow. Additionally, the heap is no
longer being littered by these unnecessary string
temporaries, increasing performance of code that gets
executed after the translation file loader finishes.

* Optimize server map saving

When the directory structure for the world data is created
during server map saving, an unnecessary value passing of
the directory name slows things down. Remove that overhead
by converting the offending parameter to a const reference.

5 years agoRevert "Inventory: Make addItem for empty ItemStacks respect max stack size" (#8519)
ANAND ︻气デ═一 [Sun, 12 May 2019 17:07:15 +0000 (22:37 +0530)]
Revert "Inventory: Make addItem for empty ItemStacks respect max stack size" (#8519)

Revert commit e6a9e60

5 years agoMove HTTP request logging to infostream (#8526)
ANAND ︻气デ═一 [Sun, 12 May 2019 16:55:15 +0000 (22:25 +0530)]
Move HTTP request logging to infostream (#8526)

5 years agoDefine operators == and != for ItemStack
ANAND ︻气デ═一 [Sat, 11 May 2019 16:48:27 +0000 (22:18 +0530)]
Define operators == and != for ItemStack

5 years agobuiltin/../register.lua: Abort make_wrap_deregistration if param is invalid
ANAND [Sun, 28 Apr 2019 09:42:20 +0000 (15:12 +0530)]
builtin/../register.lua: Abort make_wrap_deregistration if param is invalid

5 years agominimal: Fix crash due to assertion fail
ANAND [Fri, 3 May 2019 12:44:05 +0000 (18:14 +0530)]
minimal: Fix crash due to assertion fail

5 years agoBetter document behavior of on_punchplayer
ANAND [Sat, 27 Apr 2019 12:35:28 +0000 (18:05 +0530)]
Better document behavior of on_punchplayer

Esp. the fact that it's invoked even if the punched player is dead

5 years agoPlayerSAO::setHP - Don't call on_hpchange callbacks if HP hasn't changed
ANAND [Sat, 27 Apr 2019 11:53:36 +0000 (17:23 +0530)]
PlayerSAO::setHP - Don't call on_hpchange callbacks if HP hasn't changed