fix broken copy relocations from dynamic linker cleanup

this issue affected programs which use global variables exported by
non-libc libraries.

diff --git a/src/ldso/dynlink.c b/src/ldso/dynlink.c
index df54230c8cf2517ce9941f14b711f51297b3fcae..28b86bf761c81d3451494b164d07c87c3c2bcbf9 100644 (file)
--- a/src/ldso/dynlink.c
+++ b/src/ldso/dynlink.c
@@ -563,10 +563,13 @@ void *__dynlink(int argc, char **argv)
                ehdr->e_phentsize, ehdr->e_phnum);
 
        /* Load preload/needed libraries, add their symbols to the global
-        * namespace, and perform all remaining relocations. */
+        * namespace, and perform all remaining relocations. The main
+        * program must be relocated LAST since it may contain copy
+        * relocations which depend on libraries' relocations. */
        if (env_preload) load_preload(env_preload);
        load_deps(app);
        make_global(app);
+       reloc_all(app->next);
        reloc_all(app);
 
        /* Switch to runtime mode: any further failures in the dynamic