port numbers should always be interpreted as decimal

per POSIX and RFC 3493:

If the specified address family is AF_INET, AF_INET6, or AF_UNSPEC,
the service can be specified as a string specifying a decimal port
number.

021 is a valid decimal number, therefore, interpreting it as octal
seems to be non-conformant.

diff --git a/src/network/getaddrinfo.c b/src/network/getaddrinfo.c
index 494b412a4a1e5826eacc850d964ceb2ac7616a19..e5fa5191c724a6d7f36eb91685eab36db5e3a30c 100644 (file)
--- a/src/network/getaddrinfo.c
+++ b/src/network/getaddrinfo.c
@@ -76,7 +76,7 @@ int getaddrinfo(const char *host, const char *serv, const struct addrinfo *hint,
 
        if (serv) {
                if (!*serv) return EAI_SERVICE;
-               port = strtoul(serv, &z, 0);
+               port = strtoul(serv, &z, 10);
                if (!*z && port > 65535) return EAI_SERVICE;
                if (!port) {
                        if (flags & AI_NUMERICSERV) return EAI_SERVICE;