fix errno handling in scandir:

1. saved errno was not being restored, illegally clearing errno to 0.
2. no need to backup and save errno around free; it will not touch
except perhaps when the program has already invoked UB...

diff --git a/src/dirent/scandir.c b/src/dirent/scandir.c
index 6a0a99933833fe531db03216d026f40b4ca6f8d2..aad813ac792b574b02d32b8d2b50eb2fd391d483 100644 (file)
--- a/src/dirent/scandir.c
+++ b/src/dirent/scandir.c
@@ -35,12 +35,11 @@ int scandir(const char *path, struct dirent ***res,
        closedir(d);
 
        if (errno) {
-               old_errno = errno;
                if (names) while (cnt-->0) free(names[cnt]);
                free(names);
-               errno = old_errno;
                return -1;
        }
+       errno = old_errno;
 
        if (cmp) qsort(names, cnt, sizeof *names, (int (*)(const void *, const void *))cmp);
        *res = names;