fix negative response and non-response handling for dns queries

previously, all failures to obtain at least one address were treated
as nonexistant names (EAI_NONAME). this failed to account for the
possibility of transient failures (no response at all, or a response
with rcode of 2, server failure) or permanent failures that do not
indicate the nonexistence of the requested name. only an rcode of 3
should be treated as an indication of nonexistence.

diff --git a/src/network/lookup_name.c b/src/network/lookup_name.c
index 8d41627ad354d7c05428092642feaeab53533650..02920930392475fba29d6e10339e7a6a0f378450 100644 (file)
--- a/src/network/lookup_name.c
+++ b/src/network/lookup_name.c
@@ -151,7 +151,10 @@ static int name_from_dns(struct address buf[static MAXADDRS], char canon[static
        for (i=0; i<nq; i++)
                __dns_parse(abuf[i], alens[i], dns_parse_callback, &ctx);
 
-       return ctx.cnt;
+       if (ctx.cnt) return ctx.cnt;
+       if (alens[0] < 4 || (abuf[0][3] & 15) == 2) return EAI_AGAIN;
+       if ((abuf[0][3] & 15) == 3) return EAI_NONAME;
+       return EAI_FAIL;
 }
 
 int __lookup_name(struct address buf[static MAXADDRS], char canon[static 256], const char *name, int family, int flags)