projects / oweals / musl.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 76fd011)
fix MINSIGSTKSZ values for archs with large signal contexts
authorRich Felker <dalias@aerifal.cx>
Wed, 18 Mar 2015 03:12:48 +0000 (23:12 -0400)
committerRich Felker <dalias@aerifal.cx>
Wed, 18 Mar 2015 04:31:37 +0000 (00:31 -0400)
the previous values (2k min and 8k default) were too small for some
archs. aarch64 reserves 4k in the signal context for future extensions
and requires about 4.5k total, and powerpc reportedly uses over 2k.
the new minimums are chosen to fit the saved context and also allow a
minimal signal handler to run.

since the default (SIGSTKSZ) has always been 6k larger than the
minimum, it is also increased to maintain the 6k usable by the signal
handler. this happens to be able to store one pathname buffer and
should be sufficient for calling any function in libc that doesn't
involve conversion between floating point and decimal representations.

x86 (both 32-bit and 64-bit variants) may also need a larger minimum
(around 2.5k) in the future to support avx-512, but the values on
these archs are left alone for now pending further analysis.

the value for PTHREAD_STACK_MIN is not increased to match MINSIGSTKSZ
at this time. this is so as not to preclude applications from using
extremely small thread stacks when they know they will not be handling
signals. unfortunately cancellation and multi-threaded set*id() use
signals as an implementation detail and therefore require a stack
large enough for a signal context, so applications which use extremely
small thread stacks may still need to avoid using these features.

arch/aarch64/bits/signal.h patch | blob | history
arch/arm/bits/signal.h patch | blob | history
arch/i386/bits/signal.h patch | blob | history
arch/microblaze/bits/signal.h patch | blob | history
arch/mips/bits/signal.h patch | blob | history
arch/or1k/bits/signal.h patch | blob | history
arch/powerpc/bits/signal.h patch | blob | history
arch/sh/bits/signal.h patch | blob | history
arch/x32/bits/signal.h patch | blob | history
arch/x86_64/bits/signal.h patch | blob | history
include/signal.h patch | blob | history

diff --git a/arch/aarch64/bits/signal.h b/arch/aarch64/bits/signal.h
index 430da95a05f81a0dc934504cdc6c40a55ed24abb..ef07cc9f0cda22e8d0627a781c3032da4c93da2d 100644 (file)
--- a/arch/aarch64/bits/signal.h
+++ b/arch/aarch64/bits/signal.h
@@ -1,6 +1,11 @@
 #if defined(_POSIX_SOURCE) || defined(_POSIX_C_SOURCE) \
  || defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 
+#if defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
+#define MINSIGSTKSZ 6144
+#define SIGSTKSZ 12288
+#endif
+
 #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 typedef unsigned long greg_t;
 typedef unsigned long gregset_t[34];
diff --git a/arch/arm/bits/signal.h b/arch/arm/bits/signal.h
index 048635fa510ba4b689b54d570d3d5f9cac0a7b50..9d19eeb2fbf9adda7272de752dedba76ae52ca98 100644 (file)
--- a/arch/arm/bits/signal.h
+++ b/arch/arm/bits/signal.h
@@ -1,6 +1,11 @@
 #if defined(_POSIX_SOURCE) || defined(_POSIX_C_SOURCE) \
  || defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 
+#if defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
+#define MINSIGSTKSZ 2048
+#define SIGSTKSZ 8192
+#endif
+
 #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 typedef int greg_t, gregset_t[18];
 typedef struct sigcontext
diff --git a/arch/i386/bits/signal.h b/arch/i386/bits/signal.h
index adf0c07576c7f6b2c90b2f9f3ae46abb6c78e610..1f9085a553b3667d2ef9dad89c01a023ca9e6ffc 100644 (file)
--- a/arch/i386/bits/signal.h
+++ b/arch/i386/bits/signal.h
@@ -1,6 +1,11 @@
 #if defined(_POSIX_SOURCE) || defined(_POSIX_C_SOURCE) \
  || defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 
+#if defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
+#define MINSIGSTKSZ 2048
+#define SIGSTKSZ 8192
+#endif
+
 #ifdef _GNU_SOURCE
 #define REG_GS          0
 #define REG_FS          1
diff --git a/arch/microblaze/bits/signal.h b/arch/microblaze/bits/signal.h
index 01fa7bf506535839145a01e6f977af3b8779b67e..4aa231a2f4d42dbd3a7da7a1067c3a34ce2e3660 100644 (file)
--- a/arch/microblaze/bits/signal.h
+++ b/arch/microblaze/bits/signal.h
@@ -1,6 +1,11 @@
 #if defined(_POSIX_SOURCE) || defined(_POSIX_C_SOURCE) \
  || defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 
+#if defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
+#define MINSIGSTKSZ 2048
+#define SIGSTKSZ 8192
+#endif
+
 #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 typedef unsigned long greg_t, gregset_t[38];
 typedef struct sigcontext
diff --git a/arch/mips/bits/signal.h b/arch/mips/bits/signal.h
index 48bd11054353d57d07f10172f43b4318dccb639a..e221842739b85fae9c4131fe82b5b190221615e1 100644 (file)
--- a/arch/mips/bits/signal.h
+++ b/arch/mips/bits/signal.h
@@ -1,6 +1,11 @@
 #if defined(_POSIX_SOURCE) || defined(_POSIX_C_SOURCE) \
  || defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 
+#if defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
+#define MINSIGSTKSZ 2048
+#define SIGSTKSZ 8192
+#endif
+
 #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 typedef unsigned long long greg_t, gregset_t[32];
 typedef struct {
diff --git a/arch/or1k/bits/signal.h b/arch/or1k/bits/signal.h
index c5e9c0cd605e976a7653fd738cb506f744e8a272..be576d1d7b7dc920204e95caf39d1536914602df 100644 (file)
--- a/arch/or1k/bits/signal.h
+++ b/arch/or1k/bits/signal.h
@@ -1,6 +1,11 @@
 #if defined(_POSIX_SOURCE) || defined(_POSIX_C_SOURCE) \
  || defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 
+#if defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
+#define MINSIGSTKSZ 2048
+#define SIGSTKSZ 8192
+#endif
+
 #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 typedef unsigned long greg_t, gregset_t[34];
 typedef struct sigcontext {
diff --git a/arch/powerpc/bits/signal.h b/arch/powerpc/bits/signal.h
index 3f9f810f2954427cd19ddab824823fa6b0d760fc..17a7354f8d41f776046ff211adb0ebd8ee1142f6 100644 (file)
--- a/arch/powerpc/bits/signal.h
+++ b/arch/powerpc/bits/signal.h
@@ -1,6 +1,11 @@
 #if defined(_POSIX_SOURCE) || defined(_POSIX_C_SOURCE) \
  || defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 
+#if defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
+#define MINSIGSTKSZ 4096
+#define SIGSTKSZ 10240
+#endif
+
 #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 
 typedef unsigned long greg_t, gregset_t[48];
diff --git a/arch/sh/bits/signal.h b/arch/sh/bits/signal.h
index 41b94376dd2612908bed4aab3999e3a0ff127915..160311faebeb8bdeae6f3bee925ebe3a63ac017f 100644 (file)
--- a/arch/sh/bits/signal.h
+++ b/arch/sh/bits/signal.h
@@ -1,6 +1,11 @@
 #if defined(_POSIX_SOURCE) || defined(_POSIX_C_SOURCE) \
  || defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 
+#if defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
+#define MINSIGSTKSZ 2048
+#define SIGSTKSZ 8192
+#endif
+
 #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 typedef int greg_t, gregset_t[16];
 typedef int freg_t, fpregset_t[16];
diff --git a/arch/x32/bits/signal.h b/arch/x32/bits/signal.h
index 2379f1ca83f6562c21c29808ddee7f3f34e20fe1..4c4adf31056ddf8fce6b0c9ae4709e517db10c21 100644 (file)
--- a/arch/x32/bits/signal.h
+++ b/arch/x32/bits/signal.h
@@ -1,6 +1,11 @@
 #if defined(_POSIX_SOURCE) || defined(_POSIX_C_SOURCE) \
  || defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 
+#if defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
+#define MINSIGSTKSZ 2048
+#define SIGSTKSZ 8192
+#endif
+
 #ifdef _GNU_SOURCE
 #define REG_R8          0
 #define REG_R9          1
diff --git a/arch/x86_64/bits/signal.h b/arch/x86_64/bits/signal.h
index b3a761651a1deb5e72224b16bfd3a2ee61fa8043..e3c314175c4e4fbcba6fae566c679e641716986f 100644 (file)
--- a/arch/x86_64/bits/signal.h
+++ b/arch/x86_64/bits/signal.h
@@ -1,6 +1,11 @@
 #if defined(_POSIX_SOURCE) || defined(_POSIX_C_SOURCE) \
  || defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 
+#if defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
+#define MINSIGSTKSZ 2048
+#define SIGSTKSZ 8192
+#endif
+
 #ifdef _GNU_SOURCE
 #define REG_R8          0
 #define REG_R9          1
diff --git a/include/signal.h b/include/signal.h
index b38241a3b149686b7f8fe4613fe09b1ae6460e5e..559362f2993676783389549cb887efcb759683a5 100644 (file)
--- a/include/signal.h
+++ b/include/signal.h
@@ -222,8 +222,6 @@ void (*sigset(int, void (*)(int)))(int);
 #define POLL_HUP 6
 #define SS_ONSTACK    1
 #define SS_DISABLE    2
-#define MINSIGSTKSZ 2048
-#define SIGSTKSZ 8192
 #endif
 
 #if defined(_BSD_SOURCE) || defined(_GNU_SOURCE)
Unnamed repository; edit this file 'description' to name the repository.