dynamic linker: permit error returns from arch-specific reloc function

the immediate motivation is supporting TLSDESC relocations which
require allocation and thus may fail (unless we pre-allocate), but
this mechanism should also be used for throwing an error on
unsupported or invalid relocation types, and perhaps in certain cases,
for reporting when a relocation is not satisfiable.

diff --git a/arch/arm/reloc.h b/arch/arm/reloc.h
index 264b7ab2c4375a7fb7fc6d7b2114031f4114f57b..27c606d4a9db6e48ecfee6eb58707b8544fde5ee 100644 (file)
--- a/arch/arm/reloc.h
+++ b/arch/arm/reloc.h
@@ -19,7 +19,7 @@
 #define IS_COPY(x) ((x)==R_ARM_COPY)
 #define IS_PLT(x) ((x)==R_ARM_JUMP_SLOT)
 
-static inline void do_single_reloc(
+static inline int do_single_reloc(
        struct dso *self, unsigned char *base_addr,
        size_t *reloc_addr, int type, size_t addend,
        Sym *sym, size_t sym_size,
@@ -51,6 +51,7 @@ static inline void do_single_reloc(
                        : self->tls_offset + 8;
                break;
        }
+       return 0;
 }
 
 #define NO_LEGACY_INITFINI

diff --git a/arch/i386/reloc.h b/arch/i386/reloc.h
index 3923b54b100b013665d71d57b25fcf7f3d1a92e8..bc86e96e121cda1ce1ba7428aa7d42df6ed9f4da 100644 (file)
--- a/arch/i386/reloc.h
+++ b/arch/i386/reloc.h
@@ -6,7 +6,7 @@
 #define IS_COPY(x) ((x)==R_386_COPY)
 #define IS_PLT(x) ((x)==R_386_JMP_SLOT)
 
-static inline void do_single_reloc(
+static inline int do_single_reloc(
        struct dso *self, unsigned char *base_addr,
        size_t *reloc_addr, int type, size_t addend,
        Sym *sym, size_t sym_size,
@@ -46,4 +46,5 @@ static inline void do_single_reloc(
                        : self->tls_offset;
                break;
        }
+       return 0;
 }

diff --git a/arch/microblaze/reloc.h b/arch/microblaze/reloc.h
index 7bf3a5b053e9b4207fb607011100b179ae59de83..f2f6c3a01581ca3329c9ef65be131dd456be6c5f 100644 (file)
--- a/arch/microblaze/reloc.h
+++ b/arch/microblaze/reloc.h
@@ -13,7 +13,7 @@
 #define IS_COPY(x) ((x)==R_MICROBLAZE_COPY)
 #define IS_PLT(x) ((x)==R_MICROBLAZE_JUMP_SLOT)
 
-static inline void do_single_reloc(
+static inline int do_single_reloc(
        struct dso *self, unsigned char *base_addr,
        size_t *reloc_addr, int type, size_t addend,
        Sym *sym, size_t sym_size,
@@ -38,6 +38,7 @@ static inline void do_single_reloc(
                *reloc_addr = def.sym->st_value + addend;
                break;
        }
+       return 0;
 }
 
 #include "syscall.h"

diff --git a/arch/mips/reloc.h b/arch/mips/reloc.h
index 4ca81257ec9f53dddb5b3703445e33a8702deb43..08d139da740251104b2ce382690103717bebfd10 100644 (file)
--- a/arch/mips/reloc.h
+++ b/arch/mips/reloc.h
@@ -19,7 +19,7 @@
 #define IS_COPY(x) ((x)==R_MIPS_COPY)
 #define IS_PLT(x) 1
 
-static inline void do_single_reloc(
+static inline int do_single_reloc(
        struct dso *self, unsigned char *base_addr,
        size_t *reloc_addr, int type, size_t addend,
        Sym *sym, size_t sym_size,
@@ -48,6 +48,7 @@ static inline void do_single_reloc(
                        : self->tls_offset - 0x7000;
                break;
        }
+       return 0;
 }
 
 void __reloc_self(int c, size_t *a, size_t *dynv, size_t *got)

diff --git a/arch/powerpc/reloc.h b/arch/powerpc/reloc.h
index 38034c5642b6d684759a68262bb0dd3e5a2953e6..d5ba74a723154b55825966d3d992fcde03745f37 100644 (file)
--- a/arch/powerpc/reloc.h
+++ b/arch/powerpc/reloc.h
@@ -7,7 +7,7 @@
 #define IS_PLT(x) ((x)==R_PPC_JMP_SLOT)
 
 // see linux' arch/powerpc/include/asm/elf.h 
-static inline void do_single_reloc(
+static inline int do_single_reloc(
        struct dso *self, unsigned char *base_addr,
        size_t *reloc_addr, int type, size_t addend,
        Sym *sym, size_t sym_size,
@@ -37,6 +37,7 @@ static inline void do_single_reloc(
                        : self->tls_offset - 0x7000;
                break;
        }
+       return 0;
 }
 
 void __reloc_self(int c, size_t *a, size_t *dynv)

diff --git a/arch/sh/reloc.h b/arch/sh/reloc.h
index db3de081ffd460fbee5974d2179ad25cf6daa067..a1393bb3dd25a117fb10ded67070be5ee2590b72 100644 (file)
--- a/arch/sh/reloc.h
+++ b/arch/sh/reloc.h
@@ -9,7 +9,7 @@
 #define IS_COPY(x) ((x) == R_SH_COPY)
 #define IS_PLT(x)  ((x) == R_SH_JMP_SLOT)
 
-static inline void do_single_reloc(
+static inline int do_single_reloc(
        struct dso *self, unsigned char *base_addr,
        size_t *reloc_addr, int type, size_t addend,
        Sym *sym, size_t sym_size,
@@ -44,4 +44,5 @@ static inline void do_single_reloc(
                        : self->tls_offset + 8;
                break;
        }
+       return 0;
 }

diff --git a/arch/x32/reloc.h b/arch/x32/reloc.h
index f294eece80057bdae80617c7bafa3bfd0f44ba52..1261fb5de7c0cc6ca8565dd35dd3dd2eaacecd13 100644 (file)
--- a/arch/x32/reloc.h
+++ b/arch/x32/reloc.h
@@ -7,7 +7,7 @@
 #define IS_COPY(x) ((x)==R_X86_64_COPY)
 #define IS_PLT(x) ((x)==R_X86_64_JUMP_SLOT)
 
-static inline void do_single_reloc(
+static inline int do_single_reloc(
        struct dso *self, unsigned char *base_addr,
        size_t *reloc_addr, int type, size_t addend,
        Sym *sym, size_t sym_size,
@@ -43,4 +43,5 @@ static inline void do_single_reloc(
                        : 0 - self->tls_offset) + addend;
                break;
        }
+       return 0;
 }

diff --git a/arch/x86_64/reloc.h b/arch/x86_64/reloc.h
index 28cf7cc1563fe1e377e4d53e7bd4416e7f8948ea..30f6561446b5a640e80bccb07cb09eb167f2a9a5 100644 (file)
--- a/arch/x86_64/reloc.h
+++ b/arch/x86_64/reloc.h
@@ -7,7 +7,7 @@
 #define IS_COPY(x) ((x)==R_X86_64_COPY)
 #define IS_PLT(x) ((x)==R_X86_64_JUMP_SLOT)
 
-static inline void do_single_reloc(
+static inline int do_single_reloc(
        struct dso *self, unsigned char *base_addr,
        size_t *reloc_addr, int type, size_t addend,
        Sym *sym, size_t sym_size,
@@ -43,4 +43,5 @@ static inline void do_single_reloc(
                        : 0 - self->tls_offset) + addend;
                break;
        }
+       return 0;
 }