for executing init array functions, use function type with prototype

this is for consistency with the way it's done in in the dynamic
linker, avoiding a deprecated C feature (non-prototype function
types), and improving code generation. GCC unnecessarily uses the
variadic calling convention (e.g. clearing rax on x86_64) when making
a call where the argument types are not known for compatibility with
wrong code which calls variadic functions this way. (C on the other
hand is clear that such calls have undefined behavior.)

diff --git a/src/env/__libc_start_main.c b/src/env/__libc_start_main.c
index 18afdc1d67eba71755f6ea5e18b1c0af5f6e1b07..2d758af760b215aa42f61004938abb35132916f9 100644 (file)
--- a/src/env/__libc_start_main.c
+++ b/src/env/__libc_start_main.c
@@ -58,7 +58,7 @@ static void libc_start_init(void)
        _init();
        uintptr_t a = (uintptr_t)&__init_array_start;
        for (; a<(uintptr_t)&__init_array_end; a+=sizeof(void(*)()))
-               (*(void (**)())a)();
+               (*(void (**)(void))a)();
 }
 
 weak_alias(libc_start_init, __libc_start_init);