const-qualify the address argument to dladdr

this agrees with implementation practice on glibc and BSD systems, and
is the const-correct way to do things; it eliminates warnings from
passing pointers to const. the prototype without const came from
seemingly erroneous man pages.

diff --git a/include/dlfcn.h b/include/dlfcn.h
index db26194b22845389e4b2ea2add95ccfec097e089..78fb0733b2eb82be221e2e26fb5df369be7bb715 100644 (file)
--- a/include/dlfcn.h
+++ b/include/dlfcn.h
@@ -31,7 +31,7 @@ typedef struct {
        const char *dli_sname;
        void *dli_saddr;
 } Dl_info;
-int dladdr(void *, Dl_info *);
+int dladdr(const void *, Dl_info *);
 int dlinfo(void *, int, void *);
 #endif
 

diff --git a/src/ldso/dladdr.c b/src/ldso/dladdr.c
index 265bb681d0d4b19b54706bc0e5b72053b43e876a..7ca718f4fbf4ccc7d2257a56b6ed4a25dbcec4d8 100644 (file)
--- a/src/ldso/dladdr.c
+++ b/src/ldso/dladdr.c
@@ -1,9 +1,9 @@
 #define _GNU_SOURCE
 #include <dlfcn.h>
 
-int __dladdr(void *, Dl_info *);
+int __dladdr(const void *, Dl_info *);
 
-int dladdr(void *addr, Dl_info *info)
+int dladdr(const void *addr, Dl_info *info)
 {
        return __dladdr(addr, info);
 }

diff --git a/src/ldso/dynlink.c b/src/ldso/dynlink.c
index 27d92f2b0a647b87c40574b3c7293954d0e59f93..89e1260bc5a6510ec618ea9abe0b58d4577f5e70 100644 (file)
--- a/src/ldso/dynlink.c
+++ b/src/ldso/dynlink.c
@@ -1331,7 +1331,7 @@ failed:
        return 0;
 }
 
-int __dladdr(void *addr, Dl_info *info)
+int __dladdr(const void *addr, Dl_info *info)
 {
        struct dso *p;
        Sym *sym;
@@ -1441,7 +1441,7 @@ void *__dlsym(void *restrict p, const char *restrict s, void *restrict ra)
 {
        return 0;
 }
-int __dladdr (void *addr, Dl_info *info)
+int __dladdr (const void *addr, Dl_info *info)
 {
        return 0;
 }