treat base 1 as an error in strtol-family functions

ISO C and POSIX only specify behavior for base arguments of 0 and
2-36; POSIX mandates an EINVAL error for unsupported bases. it's not
clear that there's a requirement for implementations not to "support"
additional bases as an extension, but "base 1" did not work in any
meaningful way anyway, so it should be considered unsupported and thus
an error.

diff --git a/src/internal/intscan.c b/src/internal/intscan.c
index 65d497ec8a6fbabe6dafe65983d79c2bb9b2abf1..a4a5ae861282863035a492ce8db0e18d4acfe3ac 100644 (file)
--- a/src/internal/intscan.c
+++ b/src/internal/intscan.c
@@ -29,7 +29,7 @@ unsigned long long __intscan(FILE *f, unsigned base, int pok, unsigned long long
        int c, neg=0;
        unsigned x;
        unsigned long long y;
-       if (base > 36) {
+       if (base > 36 || base == 1) {
                errno = EINVAL;
                return 0;
        }