fix temp file leak in sem_open on successful creation of new semaphore
authorRich Felker <dalias@aerifal.cx>
Thu, 27 Jun 2013 01:41:51 +0000 (21:41 -0400)
committerRich Felker <dalias@aerifal.cx>
Thu, 27 Jun 2013 01:41:51 +0000 (21:41 -0400)
src/thread/sem_open.c

index 66f12ee42000450e5b26ef56b51f11b61ad835ab..9a95d257172096f6bd933005adb1299bbecf00c9 100644 (file)
@@ -123,9 +123,9 @@ sem_t *sem_open(const char *name, int flags, ...)
                        goto fail;
                }
                close(fd);
-               if (link(tmp, name) == 0) break;
-               e = errno;
+               e = link(tmp, name) ? errno : 0;
                unlink(tmp);
+               if (!e) break;
                /* Failure is only fatal when doing an exclusive open;
                 * otherwise, next iteration will try to open the
                 * existing file. */