fix misaligned address buffers in gethostbyname[2][_r] results
authorRich Felker <dalias@aerifal.cx>
Mon, 27 Jun 2016 21:11:30 +0000 (17:11 -0400)
committerRich Felker <dalias@aerifal.cx>
Mon, 27 Jun 2016 21:11:30 +0000 (17:11 -0400)
mistakenly ordering strings before addresses in the result buffer
broke the alignment that the preceding code had set up.

src/network/gethostbyname2_r.c

index 81f71d2160fef695510d53063ba7b8d55716977f..5c1cae98f3f741e17cf5bd44624ea3542bc0c838 100644 (file)
@@ -58,6 +58,13 @@ int gethostbyname2_r(const char *name, int af,
        h->h_addr_list = (void *)buf;
        buf += (cnt+1)*sizeof(char *);
 
+       for (i=0; i<cnt; i++) {
+               h->h_addr_list[i] = (void *)buf;
+               buf += h->h_length;
+               memcpy(h->h_addr_list[i], addrs[i].addr, h->h_length);
+       }
+       h->h_addr_list[i] = 0;
+
        h->h_name = h->h_aliases[0] = buf;
        strcpy(h->h_name, canon);
        buf += strlen(h->h_name)+1;
@@ -70,13 +77,6 @@ int gethostbyname2_r(const char *name, int af,
 
        h->h_aliases[2] = 0;
 
-       for (i=0; i<cnt; i++) {
-               h->h_addr_list[i] = (void *)buf;
-               buf += h->h_length;
-               memcpy(h->h_addr_list[i], addrs[i].addr, h->h_length);
-       }
-       h->h_addr_list[i] = 0;
-
        *res = h;
        return 0;
 }