fix one-byte overflow in legacy getpass function

if the length of the input was equal to the buffer size (128), a fixed
value of zero was written one byte past the end of the static buffer.

diff --git a/src/legacy/getpass.c b/src/legacy/getpass.c
index 15ab9851e8f886d52187cf8910619b08f63cb5bc..d51286c0b03b3b3e9109a1e20804dbb9d4f3c4a1 100644 (file)
--- a/src/legacy/getpass.c
+++ b/src/legacy/getpass.c
@@ -27,7 +27,7 @@ char *getpass(const char *prompt)
 
        l = read(fd, password, sizeof password);
        if (l >= 0) {
-               if (l > 0 && password[l-1] == '\n') l--;
+               if (l > 0 && password[l-1] == '\n' || l==sizeof password) l--;
                password[l] = 0;
        }