Revert "mpc85xx: ddr: Always start DDR RAM in Self Refresh mode"
authorBiwen Li <biwen.li@nxp.com>
Thu, 9 Apr 2020 12:44:48 +0000 (20:44 +0800)
committerPriyanka Jain <priyanka.jain@nxp.com>
Fri, 10 Apr 2020 11:53:41 +0000 (17:23 +0530)
This reverts commit 2a5d5d27edfbdb0e02a7fcf05569f92c02ae44ee.
The commit breaks uboot boot (hang in ddr init)
on many PowerPC boards like P3041DS, P4080DS

Signed-off-by: Biwen Li <biwen.li@nxp.com>
Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com>
drivers/ddr/fsl/mpc85xx_ddr_gen3.c

index 952b296dd8f7a18edd023b6d9a3bc816d21297f4..a9b085db8c2e3e237755e6c6b661eaf4424af319 100644 (file)
@@ -370,8 +370,6 @@ step2:
        debug("Setting DEBUG_3[21] to 0x%08x\n", in_be32(&ddr->debug[2]));
 
 #endif /* part 1 of the workaound */
-       /* Always start in self-refresh, clear after MEM_EN */
-       setbits_be32(&ddr->sdram_cfg_2, SDRAM_CFG2_FRC_SR);
 
        /*
         * 500 painful micro-seconds must elapse between
@@ -384,6 +382,8 @@ step2:
 
 #ifdef CONFIG_DEEP_SLEEP
        if (is_warm_boot()) {
+               /* enter self-refresh */
+               setbits_be32(&ddr->sdram_cfg_2, SDRAM_CFG2_FRC_SR);
                /* do board specific memory setup */
                board_mem_sleep_setup();
                temp_sdram_cfg = (in_be32(&ddr->sdram_cfg) | SDRAM_CFG_BI);
@@ -395,10 +395,6 @@ step2:
        out_be32(&ddr->sdram_cfg, temp_sdram_cfg | SDRAM_CFG_MEM_EN);
        asm volatile("sync;isync");
 
-       /* Exit self-refresh after DDR conf as some ddr memories can fail. */
-       clrbits_be32(&ddr->sdram_cfg_2, SDRAM_CFG2_FRC_SR);
-       asm volatile("sync;isync");
-
        total_gb_size_per_controller = 0;
        for (i = 0; i < CONFIG_CHIP_SELECTS_PER_CTRL; i++) {
                if (!(regs->cs[i].config & 0x80000000))
@@ -548,4 +544,9 @@ step2:
                clrbits_be32(&ddr->sdram_cfg, 0x2);
        }
 #endif /* CONFIG_SYS_FSL_ERRATUM_DDR111_DDR134 */
+#ifdef CONFIG_DEEP_SLEEP
+       if (is_warm_boot())
+               /* exit self-refresh */
+               clrbits_be32(&ddr->sdram_cfg_2, SDRAM_CFG2_FRC_SR);
+#endif
 }