remove explicit locking to prevent __synccall setuid during posix_spawn
authorRich Felker <dalias@aerifal.cx>
Fri, 26 Apr 2013 19:09:49 +0000 (15:09 -0400)
committerRich Felker <dalias@aerifal.cx>
Fri, 26 Apr 2013 19:09:49 +0000 (15:09 -0400)
commita0473a0c826016aec1181819fcd4fff5c074f042
tree141eb6c44848881263145754b2d323c98739fa05
parent43653c1250ad5eb5385d7e08292ad047420f8d25
remove explicit locking to prevent __synccall setuid during posix_spawn

for the duration of the vm-sharing clone used by posix_spawn, all
signals are blocked in the parent process, including
implementation-internal signals. since __synccall cannot do anything
until successfully signaling all threads, the fact that signals are
blocked automatically yields the necessary safety.

aside from debloating and general simplification, part of the
motivation for removing the explicit lock is to simplify the
synchronization logic of __synccall in hopes that it can be made
async-signal-safe, which is needed to make setuid and setgid, which
depend on __synccall, conform to the standard. whether this will be
possible remains to be seen.
src/process/posix_spawn.c