overhaul aio implementation for correctness
authorRich Felker <dalias@aerifal.cx>
Fri, 13 Feb 2015 05:27:45 +0000 (00:27 -0500)
committerRich Felker <dalias@aerifal.cx>
Fri, 13 Feb 2015 06:10:11 +0000 (01:10 -0500)
commit4e8a3561652ebcda6a126b3162fc545573889dc4
treeeb83d08f7b14a6c160118c053452e9cb7774833f
parent594ffed82f4e6ee7da85e9c5da35e32946ae32c9
overhaul aio implementation for correctness

previously, aio operations were not tracked by file descriptor; each
operation was completely independent. this resulted in non-conforming
behavior for non-seekable/append-mode writes (which are required to be
ordered) and made it impossible to implement aio_cancel, which in turn
made closing file descriptors with outstanding aio operations unsafe.

the new implementation is significantly heavier (roughly twice the
size, and seems to be slightly slower) and presently aims mainly at
correctness, not performance.

most of the public interfaces have been moved into a single file,
aio.c, because there is little benefit to be had from splitting them.
whenever any aio functions are used, aio_cancel and the internal
queue lifetime management and fd-to-queue mapping code must be linked,
and these functions make up the bulk of the code size.

the close function's interaction with aio is implemented with weak
alias magic, to avoid pulling in heavy aio cancellation code in
programs that don't use aio, and the expensive cancellation path
(which includes signal blocking) is optimized out when there are no
active aio queues.
src/aio/aio.c [new file with mode: 0644]
src/aio/aio_cancel.c [deleted file]
src/aio/aio_error.c [deleted file]
src/aio/aio_fsync.c [deleted file]
src/aio/aio_readwrite.c [deleted file]
src/aio/aio_return.c [deleted file]
src/aio/aio_suspend.c
src/stdio/__stdio_close.c
src/unistd/close.c