projects / oweals / musl.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 7bbf7c1) | patch
fix multiple issues in legacy function getpass
authorRich Felker <dalias@aerifal.cx>
Sun, 6 Jul 2014 05:34:13 +0000 (01:34 -0400)
committerRich Felker <dalias@aerifal.cx>
Mon, 28 Jul 2014 04:27:59 +0000 (00:27 -0400)
commit4de2f79aea491e00e6f7a33e7ab700ecd615d622
tree1f488c773b0514cc4ea8490d5ae2c7e0a7b0ea25tree | snapshot
parent7bbf7c12548fef40a0872e32d5c6f0903c5ea147commit | diff
fix multiple issues in legacy function getpass

1. failure to output a newline after the password is read
2. fd leaks via missing FD_CLOEXEC
3. fd leaks via failure-to-close when any of the standard streams are
   closed at the time of the call
4. wrongful fallback to use of stdin when opening /dev/tty fails
5. wrongful use of stderr rather than /dev/tty for prompt
6. failure to report error reading password

(cherry picked from commit ea496d6c63ecbb5ea475111808e5c0f799354450)
src/legacy/getpass.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.