fix bogus lazy allocation in ctermid and missing malloc failure check

[oweals/musl.git] / src / stdlib / atoi.c

diff --git a/src/stdlib/atoi.c b/src/stdlib/atoi.c
index 648b154f134049558cd74f676a1835abfe706f6a..9baca7b895a0e2f5c3cfab1554f8dcdd280431b9 100644 (file)
--- a/src/stdlib/atoi.c
+++ b/src/stdlib/atoi.c
@@ -9,7 +9,8 @@ int atoi(const char *s)
        case '-': neg=1;
        case '+': s++;
        }
+       /* Compute n as a negative number to avoid overflow on INT_MIN */
        while (isdigit(*s))
-               n = 10*n + *s++ - '0';
-       return neg ? -n : n;
+               n = 10*n - (*s++ - '0');
+       return neg ? n : -n;
 }