#define NMRP_OPT_HDR_LEN 4
#define NMRP_MIN_PKT_LEN (sizeof(struct eth_hdr) + NMRP_HDR_LEN)
-#define NMRP_MAX_OPT_SIZE 12
-#define NMRP_MAX_OPT_NUM 3
-
-#define NMRP_OPT_NEXT(x) ((struct nmrp_opt*)(((char*)x) + x->len))
-
#define ETH_P_NMRP 0x0912
-#define IP_LEN 4
-#define MAX_LOOP_RECV 1024
#ifndef PACKED
#define PACKED __attribute__((__packed__))
#endif
+#ifdef NMRPFLASH_WINDOWS
+#define setenv(name, value, overwrite) SetEnvironmentVariable(name, value)
+#endif
+
enum nmrp_code {
NMRP_C_NONE = 0,
NMRP_C_ADVERTISE = 1,
struct nmrp_opt {
uint16_t type;
uint16_t len;
- union {
- uint8_t magic[4];
- uint16_t region;
- struct {
- uint8_t addr[4];
- uint8_t mask[4];
- } ip;
- } val;
+ char val[1];
} PACKED;
struct nmrp_msg {
uint8_t code;
uint8_t id;
uint16_t len;
- /* only opts[0] is valid! think of this as a char* */
- struct nmrp_opt opts[NMRP_MAX_OPT_NUM];
- /* this is NOT part of the transmitted packet */
- uint32_t num_opts;
-} PACKED;
-
-struct eth_hdr {
- uint8_t ether_dhost[6];
- uint8_t ether_shost[6];
- uint16_t ether_type;
+ char opts[44];
} PACKED;
struct nmrp_pkt {
static const char *msg_code_str(uint16_t code)
{
-#define CASE_CODE(x) case NMRP_C_ ## x: return #x
+#define MSG_CODE(x) case NMRP_C_ ## x: return #x
static char buf[16];
switch (code) {
- CASE_CODE(ADVERTISE);
- CASE_CODE(CONF_REQ);
- CASE_CODE(CONF_ACK);
- CASE_CODE(CLOSE_REQ);
- CASE_CODE(CLOSE_ACK);
- CASE_CODE(KEEP_ALIVE_REQ);
- CASE_CODE(KEEP_ALIVE_ACK);
- CASE_CODE(TFTP_UL_REQ);
+ MSG_CODE(ADVERTISE);
+ MSG_CODE(CONF_REQ);
+ MSG_CODE(CONF_ACK);
+ MSG_CODE(CLOSE_REQ);
+ MSG_CODE(CLOSE_ACK);
+ MSG_CODE(KEEP_ALIVE_REQ);
+ MSG_CODE(KEEP_ALIVE_ACK);
+ MSG_CODE(TFTP_UL_REQ);
default:
- snprintf(buf, sizeof(buf), "%04x", code);
+ snprintf(buf, sizeof(buf), "%04x", ntohs(code));
return buf;
}
-#undef CASE_CODE
+#undef MSG_CODE
}
static uint16_t to_region_code(const char *region)
{
-#define REGION_CODE(r, c) if (!strcasecmp(region, r)) return c
+#define REGION_CODE(r, c) if (!strcasecmp(region, r)) return htons(c)
REGION_CODE("NA", 0x0001);
REGION_CODE("WW", 0x0002);
REGION_CODE("GR", 0x0003);
return 0;
}
-static void msg_dump(struct nmrp_msg *msg, int dump_opts)
+static void msg_dump(struct nmrp_msg *msg)
{
- struct nmrp_opt *opt;
- int remain_len, len, i;
+ int rem;
fprintf(stderr, "res=0x%04x, code=0x%02x, id=0x%02x, len=%u",
- msg->reserved, msg->code, msg->id, msg->len);
+ ntohs(msg->reserved), msg->code, msg->id, ntohs(msg->len));
+
+ rem = ntohs(msg->len) - NMRP_HDR_LEN;
+ fprintf(stderr, "%s\n", rem ? "" : " (no opts)");
+}
- remain_len = msg->len - NMRP_HDR_LEN;
- fprintf(stderr, "%s\n", remain_len ? "" : " (no opts)");
+static void *msg_opt(struct nmrp_msg *msg, uint16_t type, uint16_t* len)
+{
+ struct nmrp_opt* opt = (struct nmrp_opt*)msg->opts;
+ size_t rem = ntohs(msg->len) - NMRP_HDR_LEN;
+ uint16_t olen;
- if (dump_opts) {
- opt = msg->opts;
+ do {
+ olen = ntohs(opt->len);
+ if (olen < NMRP_OPT_HDR_LEN || olen > rem) {
+ break;
+ }
- while (remain_len > 0) {
- len = opt->len;
- fprintf(stderr, " opt type=%u, len=%u", opt->type, len);
+ if (ntohs(opt->type) == type) {
if (len) {
- for (i = 0; i != len - NMRP_OPT_HDR_LEN; ++i) {
- if (!(i % 16)) {
- fprintf(stderr, "\n ");
- }
-
- fprintf(stderr, "%02x ", ((char*)&opt->val)[i] & 0xff);
- }
- fprintf(stderr, "\n");
+ *len = olen;
}
- remain_len -= len;
- opt = NMRP_OPT_NEXT(opt);
+
+ return opt->val;
}
- }
-}
-static void msg_hton(struct nmrp_msg *msg)
-{
- uint32_t i = 0;
- struct nmrp_opt *opt = msg->opts, *next;
+ opt = (struct nmrp_opt*)(((char *)opt) + olen);
+ rem -= olen;
+ } while (rem);
- msg->reserved = htons(msg->reserved);
- msg->len = htons(msg->len);
+ return NULL;
+}
- for (; i != msg->num_opts; ++i) {
- next = NMRP_OPT_NEXT(opt);
- opt->len = htons(opt->len);
- opt->type = htons(opt->type);
- opt = next;
+static char *msg_filename(struct nmrp_msg *msg)
+{
+ static char buf[256];
+ uint16_t len;
+ char *p = msg_opt(msg, NMRP_O_FILE_NAME, &len);
+ if (p) {
+ len = MIN(sizeof(buf) - 1, len);
+ memcpy(buf, p, len);
+ buf[len] = '\0';
+ return buf;
}
+
+ return NULL;
}
-static void msg_hdr_ntoh(struct nmrp_msg *msg)
+static inline void msg_init(struct nmrp_msg *msg, uint16_t code)
{
- msg->reserved = ntohs(msg->reserved);
- msg->len = ntohs(msg->len);
+ memset(msg, 0, sizeof(*msg));
+ msg->len = htons(NMRP_HDR_LEN);
+ msg->code = code;
}
-static int msg_ntoh(struct nmrp_msg *msg)
+static char *msg_mkopt(struct nmrp_msg *msg, char *p, uint16_t type, const void *val, size_t len)
{
- struct nmrp_opt *opt = msg->opts;
- int remaining;
+ struct nmrp_opt* opt = (struct nmrp_opt*)p;
- remaining = msg->len - NMRP_HDR_LEN;
+ len &= 0xffff;
- // FIXME maximum of two options supported, maximum option
- // size is 12
- if (remaining < NMRP_MAX_OPT_NUM * NMRP_MAX_OPT_SIZE) {
- while (remaining > 0) {
- if (remaining < NMRP_OPT_HDR_LEN) {
- break;
- }
-
- opt->type = ntohs(opt->type);
- opt->len = ntohs(opt->len);
-
- if (opt->len > NMRP_MAX_OPT_SIZE) {
- break;
- }
-
- remaining -= opt->len;
- opt = NMRP_OPT_NEXT(opt);
- }
+ msg->len = ntohs(msg->len);
- if (!remaining) {
- return 0;
- }
+ if ((msg->len + len > sizeof(*msg))) {
+ fprintf(stderr, "Error: invalid option - this is a bug\n");
+ exit(1);
}
- fprintf(stderr, "Unexpected message format.\n");
- msg_dump(msg, 0);
- return 1;
-}
-
-static void *msg_opt_data(struct nmrp_msg *msg, uint16_t type, uint16_t *len)
-{
- static char buf[128];
- struct nmrp_opt *opt = msg->opts;
- int remaining = msg->len - NMRP_HDR_LEN;
+ opt->type = htons(type);
+ opt->len = NMRP_OPT_HDR_LEN + len;
- memset(buf, 0, sizeof(buf));
+ if (val) {
+ memcpy(opt->val, val, len);
+ }
- while (remaining > 0) {
- if (opt->type == type) {
- if (opt->len == NMRP_OPT_HDR_LEN) {
- return NULL;
- }
- *len = opt->len - NMRP_OPT_HDR_LEN;
- memcpy(buf, &opt->val, MIN(*len, sizeof(buf)-1));
- return buf;
- }
+ msg->len += opt->len;
+ p += opt->len;
- remaining -= opt->len;
- opt = NMRP_OPT_NEXT(opt);
- }
+ msg->len = htons(msg->len);
+ opt->len = htons(opt->len);
- return NULL;
+ return p;
}
-static void msg_opt_add(struct nmrp_msg *msg, uint16_t type, void *data,
- uint16_t len)
+static void msg_mkadvertise(struct nmrp_msg *msg, const char *magic)
{
- uint32_t i = 0;
- struct nmrp_opt *opt = msg->opts;
-
- if (len + NMRP_OPT_HDR_LEN > NMRP_MAX_OPT_SIZE
- || msg->num_opts == NMRP_MAX_OPT_NUM) {
- fprintf(stderr, "Invalid option - this is a bug.\n");
- }
+ msg_init(msg, NMRP_C_ADVERTISE);
+ msg_mkopt(msg, msg->opts, NMRP_O_MAGIC_NO, magic, strlen(magic));
+}
- for (; i <= msg->num_opts; ++i) {
- opt = NMRP_OPT_NEXT(opt);
- }
+static void msg_mkconfack(struct nmrp_msg *msg, uint32_t ipaddr, uint32_t ipmask, uint16_t region)
+{
+ char *p;
+ uint32_t ip[2] = { ipaddr, ipmask };
- opt->len = NMRP_OPT_HDR_LEN + len;
- opt->type = type;
+ msg_init(msg, NMRP_C_CONF_ACK);
+ p = msg_mkopt(msg, msg->opts, NMRP_O_DEV_IP, &ip, 8);
+ p = msg_mkopt(msg, p, NMRP_O_FW_UP, NULL, 0);
- if (len) {
- memcpy(&opt->val, data, len);
+#ifdef NMRPFLASH_SET_REGION
+ if (region) {
+ p = msg_mkopt(msg, p, NMRP_O_DEV_REGION, ®ion, 2);
}
-
- msg->len += opt->len;
- ++msg->num_opts;
+#endif
}
-static inline void msg_init(struct nmrp_msg *msg, uint16_t code)
+#ifdef NMRPFLASH_FUZZ
+#define NMRP_INITIAL_TIMEOUT 0
+#define ethsock_create(a, b) ((struct ethsock*)1)
+#define ethsock_get_hwaddr(a) ethsock_get_hwaddr_fake(a)
+#define ethsock_recv(sock, buf, len) read(STDIN_FILENO, buf, len)
+#define ethsock_send(a, b, c) (0)
+#define ethsock_set_timeout(a, b) (0)
+#define ethsock_arp_add(a, b, c, d) (0)
+#define ethsock_arp_del(a, b) (0)
+#define ethsock_ip_add(a, b, c, d) (0)
+#define ethsock_ip_del(a, b) (0)
+#define ethsock_close(a) (0)
+#define tftp_put(a) (0)
+
+static uint8_t *ethsock_get_hwaddr_fake(struct ethsock* sock)
{
- memset(msg, 0, sizeof(*msg));
- msg->len = NMRP_HDR_LEN;
- msg->code = code;
+ static uint8_t hwaddr[6] = { 0xfa, 0xfa, 0xfa, 0xfa, 0xfa, 0xfa };
+ return hwaddr;
}
+#else
+#define NMRP_INITIAL_TIMEOUT 60
+#endif
static int pkt_send(struct ethsock *sock, struct nmrp_pkt *pkt)
{
- size_t len = ntohs(pkt->msg.len) + sizeof(pkt->eh);
- return ethsock_send(sock, pkt, len);
+ return ethsock_send(sock, pkt, sizeof(*pkt));
}
static int pkt_recv(struct ethsock *sock, struct nmrp_pkt *pkt)
{
- ssize_t bytes, len;
+ ssize_t bytes, mlen;
memset(pkt, 0, sizeof(*pkt));
bytes = ethsock_recv(sock, pkt, sizeof(*pkt));
return 1;
} else if (!bytes) {
return 2;
- } else if (bytes < NMRP_MIN_PKT_LEN) {
- fprintf(stderr, "Short packet (%d bytes)\n", (int)bytes);
- return 1;
}
- msg_hdr_ntoh(&pkt->msg);
- len = pkt->msg.len + sizeof(pkt->eh);
+ mlen = ntohs(pkt->msg.len);
- if (bytes < len) {
- fprintf(stderr, "Short packet (expected %d, got %d).\n",
- (int)len, (int)bytes);
+ if (bytes < (mlen + sizeof(pkt->eh))
+ || bytes < NMRP_MIN_PKT_LEN
+ || mlen < NMRP_HDR_LEN) {
+ fprintf(stderr, "Short packet (%d raw, %d message)\n",
+ (int)bytes, (int)mlen);
return 1;
+ } else if (mlen > sizeof(pkt->msg)) {
+ printf("Truncating %d byte message.\n", (int)mlen);
+ pkt->msg.len = htons(sizeof(pkt->msg));
}
- return msg_ntoh(&pkt->msg);
+ return 0;
}
static int mac_parse(const char *str, uint8_t *hwaddr)
return status < 0 ? status : arg.result;
}
-static struct ethsock *gsock = NULL;
-
static void sigh(int sig)
{
- printf("\n");
- if (gsock) {
- ethsock_close(gsock);
- }
-
- exit(1);
+ g_interrupted = 1;
}
static const char *spinner = "\\|/-";
{
struct nmrp_pkt tx, rx;
uint8_t *src, dest[6];
- uint16_t len, region;
+ uint16_t region;
char *filename;
time_t beg;
- int i, status, ulreqs, expect, upload_ok;
+ int i, status, ulreqs, expect, upload_ok, autoip;
struct ethsock *sock;
+ struct ethsock_ip_undo *ip_undo = NULL;
+ struct ethsock_arp_undo *arp_undo = NULL;
+ uint32_t intf_addr;
void (*sigh_orig)(int);
- struct {
- struct in_addr addr;
- struct in_addr mask;
- } PACKED ipconf;
+ struct in_addr ipaddr;
+ struct in_addr ipmask;
if (args->op != NMRP_UPLOAD_FW) {
fprintf(stderr, "Operation not implemented.\n");
return 1;
}
- if ((ipconf.addr.s_addr = inet_addr(args->ipaddr)) == INADDR_NONE) {
+ ipmask.s_addr = inet_addr(args->ipmask);
+ if (ipmask.s_addr == INADDR_NONE
+ || netmask(bitcount(ipmask.s_addr)) != ipmask.s_addr) {
+ fprintf(stderr, "Invalid subnet mask '%s'.\n", args->ipmask);
+ return 1;
+ }
+
+ if (!args->ipaddr) {
+ autoip = true;
+ /* The MAC of the device that was used to test this utility starts
+ * with a4:2b:8c, hence 164 (0xa4) and 183 (0x2b + 0x8c)
+ */
+ args->ipaddr = "10.164.183.252";
+
+ if (!args->ipaddr_intf) {
+ args->ipaddr_intf = "10.164.183.253";
+ }
+ } else if (args->ipaddr_intf) {
+ autoip = true;
+ } else {
+ autoip = false;
+ }
+
+ if ((ipaddr.s_addr = inet_addr(args->ipaddr)) == INADDR_NONE) {
fprintf(stderr, "Invalid IP address '%s'.\n", args->ipaddr);
return 1;
}
- if ((ipconf.mask.s_addr = inet_addr(args->ipmask)) == INADDR_NONE) {
- fprintf(stderr, "Invalid subnet mask '%s'.\n", args->ipmask);
+ if (args->ipaddr_intf && (intf_addr = inet_addr(args->ipaddr_intf)) == INADDR_NONE) {
+ fprintf(stderr, "Invalid IP address '%s'.\n", args->ipaddr_intf);
return 1;
}
- if (strcmp(args->file_local, "-") && access(args->file_local, R_OK) == -1) {
+ if (args->file_local && strcmp(args->file_local, "-") && access(args->file_local, R_OK) == -1) {
fprintf(stderr, "Error accessing file '%s'.\n", args->file_local);
return 1;
}
}
if (args->region) {
- region = htons(to_region_code(args->region));
+ region = to_region_code(args->region);
if (!region) {
fprintf(stderr, "Invalid region code '%s'.\n", args->region);
return 1;
return 1;
}
- status = is_valid_ip(sock, &ipconf.addr, &ipconf.mask);
- if (status <= 0) {
- if (!status) {
- fprintf(stderr, "Address %s/%s cannot be used on interface %s.\n",
- args->ipaddr, args->ipmask, args->intf);
+ sigh_orig = signal(SIGINT, sigh);
+
+ if (!autoip) {
+ status = is_valid_ip(sock, &ipaddr, &ipmask);
+ if (status <= 0) {
+ if (!status) {
+ fprintf(stderr, "Address %s/%s cannot be used on interface %s.\n",
+ args->ipaddr, args->ipmask, args->intf);
+ }
+ goto out;
+ }
+ } else {
+ if (verbosity) {
+ printf("Adding %s to interface %s.\n", args->ipaddr_intf, args->intf);
+ }
+
+ if (ethsock_ip_add(sock, intf_addr, ipmask.s_addr, &ip_undo) != 0) {
+ goto out;
}
- goto out;
}
- gsock = sock;
- sigh_orig = signal(SIGINT, sigh);
-
if (ethsock_set_timeout(sock, args->rx_timeout)) {
goto out;
}
memcpy(tx.eh.ether_dhost, dest, 6);
tx.eh.ether_type = htons(ETH_P_NMRP);
- msg_init(&tx.msg, NMRP_C_ADVERTISE);
- msg_opt_add(&tx.msg, NMRP_O_MAGIC_NO, "NTGR", 4);
- msg_hton(&tx.msg);
+ msg_mkadvertise(&tx.msg, "NTGR");
i = 0;
upload_ok = 0;
- beg = time(NULL);
+ beg = time_monotonic();
- while (1) {
+ while (!g_interrupted) {
printf("\rAdvertising NMRP server on %s ... %c",
args->intf, spinner[i]);
fflush(stdout);
i = (i + 1) & 3;
if (pkt_send(sock, &tx) < 0) {
- perror("sendto");
+ xperror("sendto");
goto out;
}
status = pkt_recv(sock, &rx);
- if (status == 0 && memcmp(rx.eh.ether_dhost, src, 6) == 0) {
- break;
+ if (status == 0) {
+ if (memcmp(rx.eh.ether_dhost, src, 6) == 0) {
+ break;
+ } else if (verbosity) {
+ printf("\nIgnoring bogus response: %s -> %s.\n",
+ mac_to_str(rx.eh.ether_shost),
+ mac_to_str(rx.eh.ether_dhost));
+ }
} else if (status == 1) {
- printf("ERR\n");
goto out;
} else {
- if ((time(NULL) - beg) >= 60) {
+ /* because we don't want nmrpflash's exit status to be zero */
+ status = 1;
+ if ((time_monotonic() - beg) >= NMRP_INITIAL_TIMEOUT) {
printf("\nNo response after 60 seconds. Bailing out.\n");
goto out;
}
expect = NMRP_C_CONF_REQ;
ulreqs = 0;
- do {
+ while (!g_interrupted) {
if (expect != NMRP_C_NONE && rx.msg.code != expect) {
fprintf(stderr, "Received %s while waiting for %s!\n",
msg_code_str(rx.msg.code), msg_code_str(expect));
status = 1;
goto out;
case NMRP_C_CONF_REQ:
- tx.msg.code = NMRP_C_CONF_ACK;
-
- msg_opt_add(&tx.msg, NMRP_O_DEV_IP, &ipconf, 8);
- msg_opt_add(&tx.msg, NMRP_O_FW_UP, NULL, 0);
-
-#ifdef NMRPFLASH_SET_REGION
- if (region) {
- msg_opt_add(&tx.msg, NMRP_O_DEV_REGION, ®ion, 2);
- }
-#endif
-
+ msg_mkconfack(&tx.msg, ipaddr.s_addr, ipmask.s_addr, region);
expect = NMRP_C_TFTP_UL_REQ;
printf("Received configuration request from %s.\n",
memcpy(tx.eh.ether_dhost, rx.eh.ether_shost, 6);
- printf("Sending configuration: ip %s, mask %s.\n",
+ printf("Sending configuration: %s, netmask %s.\n",
args->ipaddr, args->ipmask);
+ if (ethsock_arp_add(sock, rx.eh.ether_shost, ipaddr.s_addr, &arp_undo) != 0) {
+ goto out;
+ }
+
break;
case NMRP_C_TFTP_UL_REQ:
if (!upload_ok) {
break;
}
- len = 0;
- filename = msg_opt_data(&rx.msg, NMRP_O_FILE_NAME, &len);
+ filename = msg_filename(&rx.msg);
if (filename) {
if (!args->file_remote) {
args->file_remote = filename;
}
- printf("Received upload request: filename '%.*s'.\n",
- len, filename);
+ printf("Received upload request: filename '%s'.\n", filename);
} else if (!args->file_remote) {
- args->file_remote = args->file_local;
- printf("Received upload request with empty filename.\n");
+ args->file_remote = leafname(args->file_local);
+ printf("Received upload request without filename.\n");
}
status = 0;
if (args->tftpcmd) {
- printf("Executing '%s' ... ", args->tftpcmd);
- fflush(stdout);
+ printf("Executing '%s' ... \n", args->tftpcmd);
+ setenv("IP", inet_ntoa(ipaddr), 1);
+ setenv("PORT", lltostr(args->port, 10), 1);
+ setenv("MAC", mac_to_str(rx.eh.ether_shost), 1);
+ setenv("NETMASK", inet_ntoa(ipmask), 1);
+ //setenv("FILENAME", args->file_remote ? args->file_remote : "", 1);
status = system(args->tftpcmd);
- if (!status) {
- printf("OK\n");
- } else {
- printf("ERR\n");
- }
}
if (!status && args->file_local) {
- status = is_valid_ip(sock, &ipconf.addr, &ipconf.mask);
- if (status < 0) {
- goto out;
- } else if (!status) {
- printf("IP address of %s has changed. Please assign a "
- "static ip to the interface.\n", args->intf);
- tx.msg.code = NMRP_C_CLOSE_REQ;
- break;
+ if (!autoip) {
+ status = is_valid_ip(sock, &ipaddr, &ipmask);
+ if (status < 0) {
+ goto out;
+ } else if (!status) {
+ printf("IP address of %s has changed. Please assign a "
+ "static ip to the interface.\n", args->intf);
+ tx.msg.code = NMRP_C_CLOSE_REQ;
+ break;
+ }
}
if (verbosity) {
printf("Uploading %s ... ", leafname(args->file_local));
}
fflush(stdout);
- status = tftp_put(args);
+ if (!(status = tftp_put(args))) {
+ printf("OK\n");
+ }
+
}
if (!status) {
- printf("OK\nWaiting for remote to respond.\n");
+ printf("Waiting for remote to respond.\n");
upload_ok = 1;
ethsock_set_timeout(sock, args->ul_timeout);
tx.msg.code = NMRP_C_KEEP_ALIVE_REQ;
break;
case NMRP_C_KEEP_ALIVE_REQ:
tx.msg.code = NMRP_C_KEEP_ALIVE_ACK;
- ethsock_set_timeout(sock, 15000);
+ ethsock_set_timeout(sock, args->ul_timeout);
printf("Received keep-alive request.\n");
break;
case NMRP_C_CLOSE_REQ:
default:
fprintf(stderr, "Unknown message code 0x%02x!\n",
rx.msg.code);
- msg_dump(&rx.msg, 0);
+ msg_dump(&rx.msg);
}
if (tx.msg.code != NMRP_C_NONE) {
- msg_hton(&tx.msg);
-
if (pkt_send(sock, &tx) < 0) {
- perror("sendto");
+ xperror("sendto");
+ goto out;
+ }
+
+ if (tx.msg.code == NMRP_C_CLOSE_REQ) {
goto out;
}
}
ethsock_set_timeout(sock, args->rx_timeout);
- } while (1);
-
- status = 0;
+ }
- if (ulreqs) {
- printf("Reboot your device now.\n");
- } else {
- printf("No upload request received.\n");
+ if (!g_interrupted) {
+ status = 0;
+ if (ulreqs) {
+ printf("Reboot your device now.\n");
+ } else {
+ printf("No upload request received.\n");
+ }
}
out:
signal(SIGINT, sigh_orig);
- gsock = NULL;
+ ethsock_arp_del(sock, &arp_undo);
+ ethsock_ip_del(sock, &ip_undo);
ethsock_close(sock);
return status;
}