nsgmls: resolve coverity warnings related to uninitialed members in C++ classes

[oweals/cde.git] / cde / programs / dtcreate / fileio.c

diff --git a/cde/programs/dtcreate/fileio.c b/cde/programs/dtcreate/fileio.c
index ba1a0b3e679a7799041ccb311e5c7a30c46b9c77..f4d27d82254b090d907548298f4b0bc5d2b37b55 100644 (file)
--- a/cde/programs/dtcreate/fileio.c
+++ b/cde/programs/dtcreate/fileio.c
@@ -412,6 +412,9 @@ ushort WriteDefinitionFile(char *pszFile, ActionData *pAD)
   char            *ptr;
   char            *msgPtr, *fmtPtr, *errPtr;
 
+  if (!pszFile)
+      return 1;
+
   /***************************************************************************/
   /* Open action and filetypes definition file for writing.                  */
   /***************************************************************************/
@@ -613,10 +616,11 @@ ushort WriteDefinitionFile(char *pszFile, ActionData *pAD)
     }
   }
   SetCookie(fp);
-  if (fp) fclose(fp);
-  if(pszFile) {
-    chmod(pszFile, 0644);
-  }
+  if (fp)
+      fclose(fp);
+
+  chmod(pszFile, 0644);
+
   return(0);
 }