avoid parsing InformationBuffer unless status is "success"

The MBIM specification requires that the InformationBuffer
is empty unless the status field is MBIM_STATUS_SUCCESS,
except for 4 explicit combinations of status code and
command id.

Avoid calling the reply handler if the status code is
non-zero and the information buffer is empty.

Signed-off-by: Bjørn Mork <bjorn@mork.no>

diff --git a/mbim-dev.c b/mbim-dev.c
index af76683fc09a52f9ebf7cf8ed72301748ed71949..4474b2d2220d9226eb5eb777c9239be0426a6a4c 100644 (file)
--- a/mbim-dev.c
+++ b/mbim-dev.c
@@ -107,7 +107,10 @@ mbim_recv(struct uloop_fd *u, unsigned int events)
        case MBIM_MESSAGE_TYPE_COMMAND_DONE:
                if (verbose)
                        printf("  status_code: %04X\n", le32toh(msg->status_code));
-               return_code = current_handler->response(msg->buffer, le32toh(msg->buffer_length));
+               if (msg->status_code && !msg->buffer_length)
+                       return_code = -le32toh(msg->status_code);
+               else
+                       return_code = current_handler->response(msg->buffer, le32toh(msg->buffer_length));
                if (return_code < 0)
                        no_close = 0;
                mbim_send_close_msg();