fix chunked transfer encoding in keepalive mode
authorJo-Philipp Wich <jow@openwrt.org>
Wed, 7 Oct 2015 21:57:55 +0000 (23:57 +0200)
committerJo-Philipp Wich <jow@openwrt.org>
Wed, 7 Oct 2015 22:13:10 +0000 (00:13 +0200)
commit7ed2edc40dd6d0171266f3bfbc96466e1d25e3cd
treeb3230a1f9c6c35fcb01b062b2850a60f194650a5
parent1f786a55f9ad8d88a1e8322d0d363ab0602bdeb6
fix chunked transfer encoding in keepalive mode

The two commits

  5162e3b0ee7bd1d0fd6e75e1ca7993a1834b5291
"allow request handlers to disable chunked reponses"

and

  618493e378e2239f0d30902e47adfa134e649fdc
"file: disable chunked encoding for file responses"

broke the chunked transfer encoding handling for proc responses in keep-alive
connections that followed a file response with http status 204 or 304.

The effect of this bug is that cgi responses following a 204 or 304 one where
sent neither in chunked encoding nor with a content-length header, causing
browsers to stall until the keep alive timeout was reached.

Fix the logic flaw by inverting the chunk prevention flag in the client state
and by testing the chunked encoding preconditions every time instead of
once upon client (re-)initialization.

Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>
client.c
file.c
uhttpd.h
utils.c