From: Simon Glass <sjg@chromium.org>
Date: Fri, 22 May 2020 22:32:37 +0000 (-0600)
Subject: checkpatch.pl: Add a check for tests needed for uclasses
X-Git-Tag: v2020.07-rc4~6^2~4
X-Git-Url: https://git.librecmc.org/?p=oweals%2Fu-boot.git;a=commitdiff_plain;h=281236c728be2b26474fe4bfa0e53cc4c5782617

checkpatch.pl: Add a check for tests needed for uclasses

A common problem when submitting a new uclass is to forget to add sandbox
tests. Add a warning for this.

Of course tests should always be added for new code, but this one seems to
be missed by nearly every new contributor.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b8b057ce56..1053d29ce9 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2243,6 +2243,12 @@ sub pos_last_openparen {
 # Checks specific to U-Boot
 sub u_boot_line {
 	my ($realfile, $line,  $herecurr) = @_;
+
+	# ask for a test if a new uclass ID is added
+	if ($realfile =~ /uclass-id.h/ && $line =~ /^\+/) {
+		WARN("NEW_UCLASS",
+		     "Possible new uclass - make sure to add a sandbox driver, plus a test in test/dm/<name>.c\n" . $herecurr);
+	}
 }
 
 sub process {