patman: Suppress empty changelog entries

[oweals/u-boot.git] / tools / fdtgrep.c

diff --git a/tools/fdtgrep.c b/tools/fdtgrep.c
index 8d33205ea2a0938f2ca073c8de1f916b392330e0..e4112b8f692f2e88c52548a824021835905f5042 100644 (file)
--- a/tools/fdtgrep.c
+++ b/tools/fdtgrep.c
@@ -1,9 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Copyright (c) 2013, Google Inc.
  * Written by Simon Glass <sjg@chromium.org>
  *
- * SPDX-License-Identifier:    GPL-2.0+
- *
  * Perform a grep of an FDT either displaying the source subset or producing
  * a new .dtb subset which can be used as required.
  */
@@ -18,6 +17,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
+#include <fdt_region.h>
 
 #include "fdt_host.h"
 #include "libfdt_internal.h"
@@ -134,11 +134,11 @@ static int value_add(struct display_info *disp, struct value_node **headp,
        }
 
        str = strdup(str);
+       if (!str)
+               goto err_mem;
        node = malloc(sizeof(*node));
-       if (!str || !node) {
-               fprintf(stderr, "Out of memory\n");
-               return -1;
-       }
+       if (!node)
+               goto err_mem;
        node->next = *headp;
        node->type = type;
        node->include = include;
@@ -146,6 +146,9 @@ static int value_add(struct display_info *disp, struct value_node **headp,
        *headp = node;
 
        return 0;
+err_mem:
+       fprintf(stderr, "Out of memory\n");
+       return -1;
 }
 
 static bool util_is_printable_string(const void *data, int len)
@@ -774,7 +777,7 @@ char *utilfdt_read(const char *filename)
  */
 static int do_fdtgrep(struct display_info *disp, const char *filename)
 {
-       struct fdt_region *region;
+       struct fdt_region *region = NULL;
        int max_regions;
        int count = 100;
        char path[1024];
@@ -802,8 +805,8 @@ static int do_fdtgrep(struct display_info *disp, const char *filename)
         * The first pass will count the regions, but if it is too many,
         * we do another pass to actually record them.
         */
-       for (i = 0; i < 3; i++) {
-               region = malloc(count * sizeof(struct fdt_region));
+       for (i = 0; i < 2; i++) {
+               region = realloc(region, count * sizeof(struct fdt_region));
                if (!region) {
                        fprintf(stderr, "Out of memory for %d regions\n",
                                count);
@@ -816,11 +819,16 @@ static int do_fdtgrep(struct display_info *disp, const char *filename)
                                disp->flags);
                if (count < 0) {
                        report_error("fdt_find_regions", count);
+                       free(region);
                        return -1;
                }
                if (count <= max_regions)
                        break;
+       }
+       if (count > max_regions) {
                free(region);
+               fprintf(stderr, "Internal error with fdtgrep_find_region()\n");
+               return -1;
        }
 
        /* Optionally print a list of regions */
@@ -915,7 +923,9 @@ static const char usage_synopsis[] =
 /* Helper for getopt case statements */
 #define case_USAGE_COMMON_FLAGS \
        case 'h': usage(NULL); \
+       /* fallthrough */ \
        case 'V': util_version(); \
+       /* fallthrough */ \
        case '?': usage("unknown option");
 
 static const char usage_short_opts[] =
@@ -1077,6 +1087,7 @@ static void scan_args(struct display_info *disp, int argc, char *argv[])
 
                switch (opt) {
                case_USAGE_COMMON_FLAGS
+               /* fallthrough */
                case 'a':
                        disp->show_addr = 1;
                        break;
@@ -1088,7 +1099,7 @@ static void scan_args(struct display_info *disp, int argc, char *argv[])
                        break;
                case 'C':
                        inc = 0;
-                       /* no break */
+                       /* fallthrough */
                case 'c':
                        type = FDT_IS_COMPAT;
                        break;
@@ -1103,7 +1114,7 @@ static void scan_args(struct display_info *disp, int argc, char *argv[])
                        break;
                case 'G':
                        inc = 0;
-                       /* no break */
+                       /* fallthrough */
                case 'g':
                        type = FDT_ANY_GLOBAL;
                        break;
@@ -1121,7 +1132,7 @@ static void scan_args(struct display_info *disp, int argc, char *argv[])
                        break;
                case 'N':
                        inc = 0;
-                       /* no break */
+                       /* fallthrough */
                case 'n':
                        type = FDT_IS_NODE;
                        break;
@@ -1140,7 +1151,7 @@ static void scan_args(struct display_info *disp, int argc, char *argv[])
                        break;
                case 'P':
                        inc = 0;
-                       /* no break */
+                       /* fallthrough */
                case 'p':
                        type = FDT_IS_PROP;
                        break;