Merge branch 'master' of git://git.denx.de/u-boot-sh
[oweals/u-boot.git] / net / nfs.c
index d7aeef916207d037f579e09b3c5576247c4f51a0..aca0ca55f3f76749c8ff3d663b5d05eb68517b7e 100644 (file)
--- a/net/nfs.c
+++ b/net/nfs.c
  * possible, maximum 16 steps). There is no clearing of ".."'s inside the
  * path, so please DON'T DO THAT. thx. */
 
+/* NOTE 4: NFSv3 support added by Guillaume GARDET, 2016-June-20.
+ * NFSv2 is still used by default. But if server does not support NFSv2, then
+ * NFSv3 is used, if available on NFS server. */
+
 #include <common.h>
 #include <command.h>
 #include <net.h>
@@ -47,8 +51,9 @@ static int nfs_offset = -1;
 static int nfs_len;
 static ulong nfs_timeout = NFS_TIMEOUT;
 
-static char dirfh[NFS_FHSIZE]; /* file handle of directory */
-static char filefh[NFS_FHSIZE]; /* file handle of kernel image */
+static char dirfh[NFS_FHSIZE]; /* NFSv2 / NFSv3 file handle of directory */
+static char filefh[NFS3_FHSIZE]; /* NFSv2 / NFSv3 file handle */
+static int filefh3_length;     /* (variable) length of filefh when NFSv3 */
 
 static enum net_loop_state nfs_download_state;
 static struct in_addr nfs_server_ip;
@@ -69,6 +74,10 @@ static char *nfs_filename;
 static char *nfs_path;
 static char nfs_path_buff[2048];
 
+#define NFSV2_FLAG 1
+#define NFSV3_FLAG 1 << 1
+static char supported_nfs_versions = NFSV2_FLAG | NFSV3_FLAG;
+
 static inline int store_block(uchar *src, unsigned offset, unsigned len)
 {
        ulong newsize = offset + len;
@@ -133,13 +142,6 @@ RPC_ADD_CREDENTIALS - Add RPC authentication/verifier entries
 **************************************************************************/
 static uint32_t *rpc_add_credentials(uint32_t *p)
 {
-       int hl;
-       int hostnamelen;
-       char hostname[256];
-
-       strcpy(hostname, "");
-       hostnamelen = strlen(hostname);
-
        /* Here's the executive summary on authentication requirements of the
         * various NFS server implementations:  Linux accepts both AUTH_NONE
         * and AUTH_UNIX authentication (also accepts an empty hostname field
@@ -149,17 +151,11 @@ static uint32_t *rpc_add_credentials(uint32_t *p)
         * it (if the BOOTP/DHCP reply didn't give one, just use an empty
         * hostname).  */
 
-       hl = (hostnamelen + 3) & ~3;
-
        /* Provide an AUTH_UNIX credential.  */
        *p++ = htonl(1);                /* AUTH_UNIX */
-       *p++ = htonl(hl+20);            /* auth length */
-       *p++ = htonl(0);                /* stamp */
-       *p++ = htonl(hostnamelen);      /* hostname string */
-       if (hostnamelen & 3)
-               *(p + hostnamelen / 4) = 0; /* add zero padding */
-       memcpy(p, hostname, hostnamelen);
-       p += hl / 4;
+       *p++ = htonl(20);               /* auth length */
+       *p++ = 0;                       /* stamp */
+       *p++ = 0;                       /* hostname string */
        *p++ = 0;                       /* uid */
        *p++ = 0;                       /* gid */
        *p++ = 0;                       /* auxiliary gid list */
@@ -176,28 +172,39 @@ RPC_LOOKUP - Lookup RPC Port numbers
 **************************************************************************/
 static void rpc_req(int rpc_prog, int rpc_proc, uint32_t *data, int datalen)
 {
-       struct rpc_t pkt;
+       struct rpc_t rpc_pkt;
        unsigned long id;
        uint32_t *p;
        int pktlen;
        int sport;
 
        id = ++rpc_id;
-       pkt.u.call.id = htonl(id);
-       pkt.u.call.type = htonl(MSG_CALL);
-       pkt.u.call.rpcvers = htonl(2);  /* use RPC version 2 */
-       pkt.u.call.prog = htonl(rpc_prog);
-       pkt.u.call.vers = htonl(2);     /* portmapper is version 2 */
-       pkt.u.call.proc = htonl(rpc_proc);
-       p = (uint32_t *)&(pkt.u.call.data);
+       rpc_pkt.u.call.id = htonl(id);
+       rpc_pkt.u.call.type = htonl(MSG_CALL);
+       rpc_pkt.u.call.rpcvers = htonl(2);      /* use RPC version 2 */
+       rpc_pkt.u.call.prog = htonl(rpc_prog);
+       switch (rpc_prog) {
+       case PROG_NFS:
+               if (supported_nfs_versions & NFSV2_FLAG)
+                       rpc_pkt.u.call.vers = htonl(2); /* NFS v2 */
+               else /* NFSV3_FLAG */
+                       rpc_pkt.u.call.vers = htonl(3); /* NFS v3 */
+               break;
+       case PROG_PORTMAP:
+       case PROG_MOUNT:
+       default:
+               rpc_pkt.u.call.vers = htonl(2); /* portmapper is version 2 */
+       }
+       rpc_pkt.u.call.proc = htonl(rpc_proc);
+       p = rpc_pkt.u.call.data;
 
        if (datalen)
-               memcpy((char *)p, (char *)data, datalen*sizeof(uint32_t));
+               memcpy(p, data, datalen * sizeof(uint32_t));
 
-       pktlen = (char *)p + datalen*sizeof(uint32_t) - (char *)&pkt;
+       pktlen = (char *)p + datalen * sizeof(uint32_t) - (char *)&rpc_pkt;
 
        memcpy((char *)net_tx_packet + net_eth_hdr_size() + IP_UDP_HDR_SIZE,
-              (char *)&pkt, pktlen);
+              &rpc_pkt.u.data[0], pktlen);
 
        if (rpc_prog == PROG_PORTMAP)
                sport = SUNRPC_PORT;
@@ -223,7 +230,6 @@ static void rpc_lookup_req(int prog, int ver)
        data[5] = htonl(ver);
        data[6] = htonl(17);    /* IP_UDP */
        data[7] = 0;
-
        rpc_req(PROG_PORTMAP, PORTMAP_GETPORT, data, 8);
 }
 
@@ -290,8 +296,14 @@ static void nfs_readlink_req(void)
        p = &(data[0]);
        p = rpc_add_credentials(p);
 
-       memcpy(p, filefh, NFS_FHSIZE);
-       p += (NFS_FHSIZE / 4);
+       if (supported_nfs_versions & NFSV2_FLAG) {
+               memcpy(p, filefh, NFS_FHSIZE);
+               p += (NFS_FHSIZE / 4);
+       } else { /* NFSV3_FLAG */
+               *p++ = htonl(filefh3_length);
+               memcpy(p, filefh, filefh3_length);
+               p += (filefh3_length / 4);
+       }
 
        len = (uint32_t *)p - (uint32_t *)&(data[0]);
 
@@ -313,17 +325,32 @@ static void nfs_lookup_req(char *fname)
        p = &(data[0]);
        p = rpc_add_credentials(p);
 
-       memcpy(p, dirfh, NFS_FHSIZE);
-       p += (NFS_FHSIZE / 4);
-       *p++ = htonl(fnamelen);
-       if (fnamelen & 3)
-               *(p + fnamelen / 4) = 0;
-       memcpy(p, fname, fnamelen);
-       p += (fnamelen + 3) / 4;
-
-       len = (uint32_t *)p - (uint32_t *)&(data[0]);
-
-       rpc_req(PROG_NFS, NFS_LOOKUP, data, len);
+       if (supported_nfs_versions & NFSV2_FLAG) {
+               memcpy(p, dirfh, NFS_FHSIZE);
+               p += (NFS_FHSIZE / 4);
+               *p++ = htonl(fnamelen);
+               if (fnamelen & 3)
+                       *(p + fnamelen / 4) = 0;
+               memcpy(p, fname, fnamelen);
+               p += (fnamelen + 3) / 4;
+
+               len = (uint32_t *)p - (uint32_t *)&(data[0]);
+
+               rpc_req(PROG_NFS, NFS_LOOKUP, data, len);
+       } else {  /* NFSV3_FLAG */
+               *p++ = htonl(NFS_FHSIZE);       /* Dir handle length */
+               memcpy(p, dirfh, NFS_FHSIZE);
+               p += (NFS_FHSIZE / 4);
+               *p++ = htonl(fnamelen);
+               if (fnamelen & 3)
+                       *(p + fnamelen / 4) = 0;
+               memcpy(p, fname, fnamelen);
+               p += (fnamelen + 3) / 4;
+
+               len = (uint32_t *)p - (uint32_t *)&(data[0]);
+
+               rpc_req(PROG_NFS, NFS3PROC_LOOKUP, data, len);
+       }
 }
 
 /**************************************************************************
@@ -338,11 +365,21 @@ static void nfs_read_req(int offset, int readlen)
        p = &(data[0]);
        p = rpc_add_credentials(p);
 
-       memcpy(p, filefh, NFS_FHSIZE);
-       p += (NFS_FHSIZE / 4);
-       *p++ = htonl(offset);
-       *p++ = htonl(readlen);
-       *p++ = 0;
+       if (supported_nfs_versions & NFSV2_FLAG) {
+               memcpy(p, filefh, NFS_FHSIZE);
+               p += (NFS_FHSIZE / 4);
+               *p++ = htonl(offset);
+               *p++ = htonl(readlen);
+               *p++ = 0;
+       } else { /* NFSV3_FLAG */
+               *p++ = htonl(filefh3_length);
+               memcpy(p, filefh, filefh3_length);
+               p += (filefh3_length / 4);
+               *p++ = htonl(0); /* offset is 64-bit long, so fill with 0 */
+               *p++ = htonl(offset);
+               *p++ = htonl(readlen);
+               *p++ = 0;
+       }
 
        len = (uint32_t *)p - (uint32_t *)&(data[0]);
 
@@ -358,10 +395,16 @@ static void nfs_send(void)
 
        switch (nfs_state) {
        case STATE_PRCLOOKUP_PROG_MOUNT_REQ:
-               rpc_lookup_req(PROG_MOUNT, 1);
+               if (supported_nfs_versions & NFSV2_FLAG)
+                       rpc_lookup_req(PROG_MOUNT, 1);
+               else  /* NFSV3_FLAG */
+                       rpc_lookup_req(PROG_MOUNT, 3);
                break;
        case STATE_PRCLOOKUP_PROG_NFS_REQ:
-               rpc_lookup_req(PROG_NFS, 2);
+               if (supported_nfs_versions & NFSV2_FLAG)
+                       rpc_lookup_req(PROG_NFS, 2);
+               else  /* NFSV3_FLAG */
+                       rpc_lookup_req(PROG_NFS, 3);
                break;
        case STATE_MOUNT_REQ:
                nfs_mount_req(nfs_path);
@@ -389,7 +432,7 @@ static int rpc_lookup_reply(int prog, uchar *pkt, unsigned len)
 {
        struct rpc_t rpc_pkt;
 
-       memcpy((unsigned char *)&rpc_pkt, pkt, len);
+       memcpy(&rpc_pkt.u.data[0], pkt, len);
 
        debug("%s\n", __func__);
 
@@ -421,7 +464,7 @@ static int nfs_mount_reply(uchar *pkt, unsigned len)
 
        debug("%s\n", __func__);
 
-       memcpy((unsigned char *)&rpc_pkt, pkt, len);
+       memcpy(&rpc_pkt.u.data[0], pkt, len);
 
        if (ntohl(rpc_pkt.u.reply.id) > rpc_id)
                return -NFS_RPC_ERR;
@@ -435,6 +478,7 @@ static int nfs_mount_reply(uchar *pkt, unsigned len)
                return -1;
 
        fs_mounted = 1;
+       /*  NFSv2 and NFSv3 use same structure */
        memcpy(dirfh, rpc_pkt.u.reply.data + 1, NFS_FHSIZE);
 
        return 0;
@@ -446,7 +490,7 @@ static int nfs_umountall_reply(uchar *pkt, unsigned len)
 
        debug("%s\n", __func__);
 
-       memcpy((unsigned char *)&rpc_pkt, pkt, len);
+       memcpy(&rpc_pkt.u.data[0], pkt, len);
 
        if (ntohl(rpc_pkt.u.reply.id) > rpc_id)
                return -NFS_RPC_ERR;
@@ -470,7 +514,7 @@ static int nfs_lookup_reply(uchar *pkt, unsigned len)
 
        debug("%s\n", __func__);
 
-       memcpy((unsigned char *)&rpc_pkt, pkt, len);
+       memcpy(&rpc_pkt.u.data[0], pkt, len);
 
        if (ntohl(rpc_pkt.u.reply.id) > rpc_id)
                return -NFS_RPC_ERR;
@@ -482,31 +526,94 @@ static int nfs_lookup_reply(uchar *pkt, unsigned len)
            rpc_pkt.u.reply.astatus  ||
            rpc_pkt.u.reply.data[0]) {
                switch (ntohl(rpc_pkt.u.reply.astatus)) {
-               case 0: /* Not an error */
+               case NFS_RPC_SUCCESS: /* Not an error */
                        break;
-               case 2: /* Remote can't support NFS version */
-                       printf("*** ERROR: NFS version not supported: Requested: V%d, accepted: min V%d - max V%d\n",
-                              2,
-                              ntohl(rpc_pkt.u.reply.data[0]),
-                              ntohl(rpc_pkt.u.reply.data[1]));
+               case NFS_RPC_PROG_MISMATCH:
+                       /* Remote can't support NFS version */
+                       switch (ntohl(rpc_pkt.u.reply.data[0])) {
+                       /* Minimal supported NFS version */
+                       case 3:
+                               debug("*** Warning: NFS version not supported: Requested: V%d, accepted: min V%d - max V%d\n",
+                                     (supported_nfs_versions & NFSV2_FLAG) ?
+                                               2 : 3,
+                                     ntohl(rpc_pkt.u.reply.data[0]),
+                                     ntohl(rpc_pkt.u.reply.data[1]));
+                               debug("Will retry with NFSv3\n");
+                               /* Clear NFSV2_FLAG from supported versions */
+                               supported_nfs_versions &= ~NFSV2_FLAG;
+                               return -NFS_RPC_PROG_MISMATCH;
+                       case 4:
+                       default:
+                               puts("*** ERROR: NFS version not supported");
+                               debug(": Requested: V%d, accepted: min V%d - max V%d\n",
+                                     (supported_nfs_versions & NFSV2_FLAG) ?
+                                               2 : 3,
+                                     ntohl(rpc_pkt.u.reply.data[0]),
+                                     ntohl(rpc_pkt.u.reply.data[1]));
+                               puts("\n");
+                       }
                        break;
+               case NFS_RPC_PROG_UNAVAIL:
+               case NFS_RPC_PROC_UNAVAIL:
+               case NFS_RPC_GARBAGE_ARGS:
+               case NFS_RPC_SYSTEM_ERR:
                default: /* Unknown error on 'accept state' flag */
-                       printf("*** ERROR: accept state error (%d)\n",
-                              ntohl(rpc_pkt.u.reply.astatus));
+                       debug("*** ERROR: accept state error (%d)\n",
+                             ntohl(rpc_pkt.u.reply.astatus));
                        break;
                }
                return -1;
        }
 
-       memcpy(filefh, rpc_pkt.u.reply.data + 1, NFS_FHSIZE);
+       if (supported_nfs_versions & NFSV2_FLAG) {
+               if (((uchar *)&(rpc_pkt.u.reply.data[0]) - (uchar *)(&rpc_pkt) + NFS_FHSIZE) > len)
+                       return -NFS_RPC_DROP;
+               memcpy(filefh, rpc_pkt.u.reply.data + 1, NFS_FHSIZE);
+       } else {  /* NFSV3_FLAG */
+               filefh3_length = ntohl(rpc_pkt.u.reply.data[1]);
+               if (filefh3_length > NFS3_FHSIZE)
+                       filefh3_length  = NFS3_FHSIZE;
+               if (((uchar *)&(rpc_pkt.u.reply.data[0]) - (uchar *)(&rpc_pkt) + filefh3_length) > len)
+                       return -NFS_RPC_DROP;
+               memcpy(filefh, rpc_pkt.u.reply.data + 2, filefh3_length);
+       }
 
        return 0;
 }
 
+static int nfs3_get_attributes_offset(uint32_t *data)
+{
+       if (data[1]) {
+               /* 'attributes_follow' flag is TRUE,
+                * so we have attributes on 21 dwords */
+               /* Skip unused values :
+                       type;   32 bits value,
+                       mode;   32 bits value,
+                       nlink;  32 bits value,
+                       uid;    32 bits value,
+                       gid;    32 bits value,
+                       size;   64 bits value,
+                       used;   64 bits value,
+                       rdev;   64 bits value,
+                       fsid;   64 bits value,
+                       fileid; 64 bits value,
+                       atime;  64 bits value,
+                       mtime;  64 bits value,
+                       ctime;  64 bits value,
+               */
+               return 22;
+       } else {
+               /* 'attributes_follow' flag is FALSE,
+                * so we don't have any attributes */
+               return 1;
+       }
+}
+
 static int nfs_readlink_reply(uchar *pkt, unsigned len)
 {
        struct rpc_t rpc_pkt;
        int rlen;
+       int nfsv3_data_offset = 0;
 
        debug("%s\n", __func__);
 
@@ -523,17 +630,30 @@ static int nfs_readlink_reply(uchar *pkt, unsigned len)
            rpc_pkt.u.reply.data[0])
                return -1;
 
-       rlen = ntohl(rpc_pkt.u.reply.data[1]); /* new path length */
+       if (!(supported_nfs_versions & NFSV2_FLAG)) { /* NFSV3_FLAG */
+               nfsv3_data_offset =
+                       nfs3_get_attributes_offset(rpc_pkt.u.reply.data);
+       }
+
+       /* new path length */
+       rlen = ntohl(rpc_pkt.u.reply.data[1 + nfsv3_data_offset]);
+
+       if (((uchar *)&(rpc_pkt.u.reply.data[0]) - (uchar *)(&rpc_pkt) + rlen) > len)
+               return -NFS_RPC_DROP;
 
-       if (*((char *)&(rpc_pkt.u.reply.data[2])) != '/') {
+       if (*((char *)&(rpc_pkt.u.reply.data[2 + nfsv3_data_offset])) != '/') {
                int pathlen;
+
                strcat(nfs_path, "/");
                pathlen = strlen(nfs_path);
-               memcpy(nfs_path + pathlen, (uchar *)&(rpc_pkt.u.reply.data[2]),
+               memcpy(nfs_path + pathlen,
+                      (uchar *)&(rpc_pkt.u.reply.data[2 + nfsv3_data_offset]),
                       rlen);
                nfs_path[pathlen + rlen] = 0;
        } else {
-               memcpy(nfs_path, (uchar *)&(rpc_pkt.u.reply.data[2]), rlen);
+               memcpy(nfs_path,
+                      (uchar *)&(rpc_pkt.u.reply.data[2 + nfsv3_data_offset]),
+                      rlen);
                nfs_path[rlen] = 0;
        }
        return 0;
@@ -543,10 +663,11 @@ static int nfs_read_reply(uchar *pkt, unsigned len)
 {
        struct rpc_t rpc_pkt;
        int rlen;
+       uchar *data_ptr;
 
        debug("%s\n", __func__);
 
-       memcpy((uchar *)&rpc_pkt, pkt, sizeof(rpc_pkt.u.reply));
+       memcpy(&rpc_pkt.u.data[0], pkt, sizeof(rpc_pkt.u.reply));
 
        if (ntohl(rpc_pkt.u.reply.id) > rpc_id)
                return -NFS_RPC_ERR;
@@ -570,10 +691,28 @@ static int nfs_read_reply(uchar *pkt, unsigned len)
        if (!(nfs_offset % ((NFS_READ_SIZE / 2) * 10)))
                putc('#');
 
-       rlen = ntohl(rpc_pkt.u.reply.data[18]);
-       if (store_block((uchar *)pkt + sizeof(rpc_pkt.u.reply),
-                       nfs_offset, rlen))
-               return -9999;
+       if (supported_nfs_versions & NFSV2_FLAG) {
+               rlen = ntohl(rpc_pkt.u.reply.data[18]);
+               data_ptr = (uchar *)&(rpc_pkt.u.reply.data[19]);
+       } else {  /* NFSV3_FLAG */
+               int nfsv3_data_offset =
+                       nfs3_get_attributes_offset(rpc_pkt.u.reply.data);
+
+               /* count value */
+               rlen = ntohl(rpc_pkt.u.reply.data[1 + nfsv3_data_offset]);
+               /* Skip unused values :
+                       EOF:            32 bits value,
+                       data_size:      32 bits value,
+               */
+               data_ptr = (uchar *)
+                       &(rpc_pkt.u.reply.data[4 + nfsv3_data_offset]);
+       }
+
+       if (((uchar *)&(rpc_pkt.u.reply.data[0]) - (uchar *)(&rpc_pkt) + rlen) > len)
+                       return -9999;
+
+       if (store_block(data_ptr, nfs_offset, rlen))
+                       return -9999;
 
        return rlen;
 }
@@ -603,6 +742,9 @@ static void nfs_handler(uchar *pkt, unsigned dest, struct in_addr sip,
 
        debug("%s\n", __func__);
 
+       if (len > sizeof(struct rpc_t))
+               return;
+
        if (dest != nfs_our_port)
                return;
 
@@ -641,7 +783,7 @@ static void nfs_handler(uchar *pkt, unsigned dest, struct in_addr sip,
                if (reply == -NFS_RPC_DROP) {
                        break;
                } else if (reply == -NFS_RPC_ERR) {
-                       puts("*** ERROR: Cannot umount\n");
+                       debug("*** ERROR: Cannot umount\n");
                        net_set_state(NETLOOP_FAIL);
                } else {
                        puts("\ndone\n");
@@ -657,6 +799,14 @@ static void nfs_handler(uchar *pkt, unsigned dest, struct in_addr sip,
                        puts("*** ERROR: File lookup fail\n");
                        nfs_state = STATE_UMOUNT_REQ;
                        nfs_send();
+               } else if (reply == -NFS_RPC_PROG_MISMATCH &&
+                          supported_nfs_versions != 0) {
+                       /* umount */
+                       nfs_state = STATE_UMOUNT_REQ;
+                       nfs_send();
+                       /* And retry with another supported version */
+                       nfs_state = STATE_PRCLOOKUP_PROG_MOUNT_REQ;
+                       nfs_send();
                } else {
                        nfs_state = STATE_READ_REQ;
                        nfs_offset = 0;
@@ -685,6 +835,8 @@ static void nfs_handler(uchar *pkt, unsigned dest, struct in_addr sip,
 
        case STATE_READ_REQ:
                rlen = nfs_read_reply(pkt, len);
+               if (rlen == -NFS_RPC_DROP)
+                       break;
                net_set_timeout_handler(nfs_timeout, nfs_timeout_handler);
                if (rlen > 0) {
                        nfs_offset += rlen;
@@ -696,6 +848,8 @@ static void nfs_handler(uchar *pkt, unsigned dest, struct in_addr sip,
                } else {
                        if (!rlen)
                                nfs_download_state = NETLOOP_SUCCESS;
+                       if (rlen < 0)
+                               debug("NFS READ error (%d)\n", rlen);
                        nfs_state = STATE_UMOUNT_REQ;
                        nfs_send();
                }
@@ -714,11 +868,12 @@ void nfs_start(void)
 
        if (nfs_path == NULL) {
                net_set_state(NETLOOP_FAIL);
-               puts("*** ERROR: Fail allocate memory\n");
+               printf("*** ERROR: Fail allocate memory\n");
                return;
        }
 
-       if (net_boot_file_name[0] == '\0') {
+       if (!net_parse_bootfile(&nfs_server_ip, nfs_path,
+                               sizeof(nfs_path_buff))) {
                sprintf(nfs_path, "/nfsroot/%02X%02X%02X%02X.img",
                        net_ip.s_addr & 0xFF,
                        (net_ip.s_addr >>  8) & 0xFF,
@@ -727,18 +882,6 @@ void nfs_start(void)
 
                printf("*** Warning: no boot file name; using '%s'\n",
                       nfs_path);
-       } else {
-               char *p = net_boot_file_name;
-
-               p = strchr(p, ':');
-
-               if (p != NULL) {
-                       nfs_server_ip = string_to_ip(net_boot_file_name);
-                       ++p;
-                       strcpy(nfs_path, p);
-               } else {
-                       strcpy(nfs_path, net_boot_file_name);
-               }
        }
 
        nfs_filename = basename(nfs_path);
@@ -755,7 +898,7 @@ void nfs_start(void)
                struct in_addr server_net;
 
                our_net.s_addr = net_ip.s_addr & net_netmask.s_addr;
-               server_net.s_addr = net_server_ip.s_addr & net_netmask.s_addr;
+               server_net.s_addr = nfs_server_ip.s_addr & net_netmask.s_addr;
                if (our_net.s_addr != server_net.s_addr)
                        printf("; sending through gateway %pI4",
                               &net_gateway);
@@ -767,8 +910,7 @@ void nfs_start(void)
                       net_boot_file_expected_size_in_blocks << 9);
                print_size(net_boot_file_expected_size_in_blocks << 9, "");
        }
-       printf("\nLoad address: 0x%lx\n"
-               "Loading: *\b", load_addr);
+       printf("\nLoad address: 0x%lx\nLoading: *\b", load_addr);
 
        net_set_timeout_handler(nfs_timeout, nfs_timeout_handler);
        net_set_udp_handler(nfs_handler);