Merge tag 'dm-pull-29oct19' of git://git.denx.de/u-boot-dm
[oweals/u-boot.git] / drivers / spi / spi-uclass.c
index c061c05443d442e5a12759d5272b719c559133bb..947516073ea99650b1703a9fc5fcc854b5496a81 100644 (file)
@@ -1,13 +1,11 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Copyright (c) 2014 Google, Inc
- *
- * SPDX-License-Identifier:    GPL-2.0+
  */
 
 #include <common.h>
 #include <dm.h>
 #include <errno.h>
-#include <fdtdec.h>
 #include <malloc.h>
 #include <spi.h>
 #include <dm/device-internal.h>
@@ -17,6 +15,8 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
+#define SPI_DEFAULT_SPEED_HZ 100000
+
 static int spi_set_speed_mode(struct udevice *bus, int speed, int mode)
 {
        struct dm_spi_ops *ops;
@@ -51,7 +51,6 @@ int dm_spi_claim_bus(struct udevice *dev)
        struct dm_spi_bus *spi = dev_get_uclass_priv(bus);
        struct spi_slave *slave = dev_get_parent_priv(dev);
        int speed;
-       int ret;
 
        speed = slave->max_hz;
        if (spi->max_hz) {
@@ -61,15 +60,16 @@ int dm_spi_claim_bus(struct udevice *dev)
                        speed = spi->max_hz;
        }
        if (!speed)
-               speed = 100000;
+               speed = SPI_DEFAULT_SPEED_HZ;
        if (speed != slave->speed) {
-               ret = spi_set_speed_mode(bus, speed, slave->mode);
+               int ret = spi_set_speed_mode(bus, speed, slave->mode);
+
                if (ret)
-                       return ret;
+                       return log_ret(ret);
                slave->speed = speed;
        }
 
-       return ops->claim_bus ? ops->claim_bus(dev) : 0;
+       return log_ret(ops->claim_bus ? ops->claim_bus(dev) : 0);
 }
 
 void dm_spi_release_bus(struct udevice *dev)
@@ -94,7 +94,7 @@ int dm_spi_xfer(struct udevice *dev, unsigned int bitlen,
 
 int spi_claim_bus(struct spi_slave *slave)
 {
-       return dm_spi_claim_bus(slave->dev);
+       return log_ret(dm_spi_claim_bus(slave->dev));
 }
 
 void spi_release_bus(struct spi_slave *slave)
@@ -108,16 +108,39 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen,
        return dm_spi_xfer(slave->dev, bitlen, dout, din, flags);
 }
 
+int spi_write_then_read(struct spi_slave *slave, const u8 *opcode,
+                       size_t n_opcode, const u8 *txbuf, u8 *rxbuf,
+                       size_t n_buf)
+{
+       unsigned long flags = SPI_XFER_BEGIN;
+       int ret;
+
+       if (n_buf == 0)
+               flags |= SPI_XFER_END;
+
+       ret = spi_xfer(slave, n_opcode * 8, opcode, NULL, flags);
+       if (ret) {
+               debug("spi: failed to send command (%zu bytes): %d\n",
+                     n_opcode, ret);
+       } else if (n_buf != 0) {
+               ret = spi_xfer(slave, n_buf * 8, txbuf, rxbuf, SPI_XFER_END);
+               if (ret)
+                       debug("spi: failed to transfer %zu bytes of data: %d\n",
+                             n_buf, ret);
+       }
+
+       return ret;
+}
+
 #if !CONFIG_IS_ENABLED(OF_PLATDATA)
 static int spi_child_post_bind(struct udevice *dev)
 {
        struct dm_spi_slave_platdata *plat = dev_get_parent_platdata(dev);
 
-       if (dev_of_offset(dev) == -1)
+       if (!dev_of_valid(dev))
                return 0;
 
-       return spi_slave_ofdata_to_platdata(gd->fdt_blob, dev_of_offset(dev),
-                                           plat);
+       return spi_slave_ofdata_to_platdata(dev, plat);
 }
 #endif
 
@@ -126,13 +149,11 @@ static int spi_post_probe(struct udevice *bus)
 #if !CONFIG_IS_ENABLED(OF_PLATDATA)
        struct dm_spi_bus *spi = dev_get_uclass_priv(bus);
 
-       spi->max_hz = fdtdec_get_int(gd->fdt_blob, dev_of_offset(bus),
-                                    "spi-max-frequency", 0);
+       spi->max_hz = dev_read_u32_default(bus, "spi-max-frequency", 0);
 #endif
 #if defined(CONFIG_NEEDS_MANUAL_RELOC)
        struct dm_spi_ops *ops = spi_get_ops(bus);
 
-
        if (ops->claim_bus)
                ops->claim_bus += gd->reloc_off;
        if (ops->release_bus)
@@ -240,11 +261,10 @@ int spi_cs_info(struct udevice *bus, uint cs, struct spi_cs_info *info)
                return ops->cs_info(bus, cs, info);
 
        /*
-        * We could assume there is at least one valid chip select, but best
-        * to be sure and return an error in this case. The driver didn't
-        * care enough to tell us.
+        * We could assume there is at least one valid chip select.
+        * The driver didn't care enough to tell us.
         */
-       return -ENODEV;
+       return 0;
 }
 
 int spi_find_bus_and_cs(int busnum, int cs, struct udevice **busp,
@@ -305,7 +325,13 @@ int spi_get_bus_and_cs(int busnum, int cs, int speed, int mode,
                }
                plat = dev_get_parent_platdata(dev);
                plat->cs = cs;
-               plat->max_hz = speed;
+               if (speed) {
+                       plat->max_hz = speed;
+               } else {
+                       printf("Warning: SPI speed fallback to %u kHz\n",
+                              SPI_DEFAULT_SPEED_HZ / 1000);
+                       plat->max_hz = SPI_DEFAULT_SPEED_HZ;
+               }
                plat->mode = mode;
                created = true;
        } else if (ret) {
@@ -325,7 +351,9 @@ int spi_get_bus_and_cs(int busnum, int cs, int speed, int mode,
        }
 
        plat = dev_get_parent_platdata(dev);
-       if (!speed) {
+
+       /* get speed and mode from platdata when available */
+       if (plat->max_hz) {
                speed = plat->max_hz;
                mode = plat->mode;
        }
@@ -350,22 +378,6 @@ err:
        return ret;
 }
 
-/* Compatibility function - to be removed */
-struct spi_slave *spi_setup_slave_fdt(const void *blob, int node,
-                                     int bus_node)
-{
-       struct udevice *bus, *dev;
-       int ret;
-
-       ret = uclass_get_device_by_of_offset(UCLASS_SPI, bus_node, &bus);
-       if (ret)
-               return NULL;
-       ret = device_get_child_by_of_offset(bus, node, &dev);
-       if (ret)
-               return NULL;
-       return dev_get_parent_priv(dev);
-}
-
 /* Compatibility function - to be removed */
 struct spi_slave *spi_setup_slave(unsigned int busnum, unsigned int cs,
                                  unsigned int speed, unsigned int mode)
@@ -375,7 +387,7 @@ struct spi_slave *spi_setup_slave(unsigned int busnum, unsigned int cs,
        int ret;
 
        ret = spi_get_bus_and_cs(busnum, cs, speed, mode, NULL, 0, &dev,
-                                 &slave);
+                                &slave);
        if (ret)
                return NULL;
 
@@ -388,27 +400,28 @@ void spi_free_slave(struct spi_slave *slave)
        slave->dev = NULL;
 }
 
-int spi_slave_ofdata_to_platdata(const void *blob, int node,
+int spi_slave_ofdata_to_platdata(struct udevice *dev,
                                 struct dm_spi_slave_platdata *plat)
 {
        int mode = 0;
        int value;
 
-       plat->cs = fdtdec_get_int(blob, node, "reg", -1);
-       plat->max_hz = fdtdec_get_int(blob, node, "spi-max-frequency", 0);
-       if (fdtdec_get_bool(blob, node, "spi-cpol"))
+       plat->cs = dev_read_u32_default(dev, "reg", -1);
+       plat->max_hz = dev_read_u32_default(dev, "spi-max-frequency",
+                                           SPI_DEFAULT_SPEED_HZ);
+       if (dev_read_bool(dev, "spi-cpol"))
                mode |= SPI_CPOL;
-       if (fdtdec_get_bool(blob, node, "spi-cpha"))
+       if (dev_read_bool(dev, "spi-cpha"))
                mode |= SPI_CPHA;
-       if (fdtdec_get_bool(blob, node, "spi-cs-high"))
+       if (dev_read_bool(dev, "spi-cs-high"))
                mode |= SPI_CS_HIGH;
-       if (fdtdec_get_bool(blob, node, "spi-3wire"))
+       if (dev_read_bool(dev, "spi-3wire"))
                mode |= SPI_3WIRE;
-       if (fdtdec_get_bool(blob, node, "spi-half-duplex"))
+       if (dev_read_bool(dev, "spi-half-duplex"))
                mode |= SPI_PREAMBLE;
 
        /* Device DUAL/QUAD mode */
-       value = fdtdec_get_uint(blob, node, "spi-tx-bus-width", 1);
+       value = dev_read_u32_default(dev, "spi-tx-bus-width", 1);
        switch (value) {
        case 1:
                break;
@@ -423,7 +436,7 @@ int spi_slave_ofdata_to_platdata(const void *blob, int node,
                break;
        }
 
-       value = fdtdec_get_uint(blob, node, "spi-rx-bus-width", 1);
+       value = dev_read_u32_default(dev, "spi-rx-bus-width", 1);
        switch (value) {
        case 1:
                break;